D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  In D25334#566992 , @ngraham wrote:
  
  > In D25334#566745 , @ndavis wrote:
  >
  > > Yes that's right, the Kickoff tabs are fine, it's the panel that doesn't 
look right. It just doesn't look good with that kind of highlight to me. Or 
maybe the highlight background is too bright.
  >
  >
  > To me it looks fine with Breeze light IMO. If you think it looks bad with 
Breeze Dark, that seems like kind of a problem since as far as I was aware, 
this is the proposed new highlight style that you're working on, right? It 
definitely needs to look good with Breeze Dark, or at least no worse than the 
status quo.
  
  
  I've found that breeze dark needs high chroma dark blue for the background to 
look good. It's easy enough to do with `KColorUtils::tint()` (doesn't work the 
same as `Qt.tint()` in QML), but I don't know how you'd do that in SVG. When 
you use semi-transparency for a higher chroma color on top of a background with 
lower chroma, it reduces the chroma of the higher chroma color.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

[Yunhe Guo]

guoyunhe added a comment.


  I also think these *.menu and *.directory files should not be required at 
compile time. And they should better be in same repository because they are 
connected so closely.
  
  In this patch, we added a new file `kf5-network.directory` in 
plasma-workspace and reference it here. But this means frameworks 5.65 will 
depend on plasma-workspace 5.18. Any other combination, like frameworks 5.65 + 
plasma 5.17 or frameworks 5.64 + plasma 5.18, will break.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: davidedmundson, ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

[Ahmad Samir]

ahmadsamir updated this revision to Diff 70271.
ahmadsamir marked 8 inline comments as done.
ahmadsamir retitled this revision from "More (and last) fixes to compile 
without implicit conversion from ASCII/ByteArray" to "More fixes to compile 
without implicit conversion from ASCII/ByteArray".
ahmadsamir added a comment.


  Address review comments.
  
  Rebase, and fix some more instances of casting from ASCII that crept up since 
the diff was created.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24349?vs=67151&id=70271

BRANCH
  arcpatch-D24349 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24349

AFFECTED FILES
  src/core/forwardingslavebase.cpp
  src/core/kremoteencoding.cpp
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/filewidgets/kencodingfiledialog.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/ioslaves/ftp/CMakeLists.txt
  src/ioslaves/ftp/ftp.cpp
  src/kcms/kio/kcookiespolicies.cpp
  src/kcms/kio/smbrodlg.cpp
  src/kioexec/main.cpp
  src/kpasswdserver/autotests/CMakeLists.txt
  src/kpasswdserver/autotests/kpasswdservertest.cpp

To: ahmadsamir, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in slavebase.h:979
> This method should be const

A B C, nothing changed inside make it const, D E F.

> dfaure wrote in ftp.cpp:1232
> Should this be remoteEncoding()->decode(...) given that the method will then 
> use q->remoteEncoding()->encode()?
> 
> (I'm a bit confused with kremoteencoding, I could be wrong)

Yes, that makes much more sense; using remoteEncoding()->decode() makes this 
bit of code consistent with the reset of how the ftp ioslave handles encoding.

> dfaure wrote in kcookiespolicies.cpp:367
> fromLatin1 is enough for adviceToStr, like you did on line 177 (so it's 
> inconsistent)
> 
> (repeats 3 more times)

Apparently I was confused by the I18N_NOOP calls in adviceToStr, but looking 
again now, the translations aren't saved in the config file...

> dfaure wrote in smbrodlg.cpp:122
> You could remove the QChar() around I guess.

You're just being polite.

> dfaure wrote in main.cpp:199
> Ouch.
> 
>   QFileInfo info(it->path)
> 
> should be enough.

In my defence, since that looks a bit too crazy even to me, I was worried about 
files with names that have encoding issues, e.g. the dreaded �; but looking up 
just a little at the code I see that fileList was written by the code, so if 
the encoding did go south, that ship has sailed and already has sunk :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24349

To: ahmadsamir, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25512: Remove unused include

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

TEST PLAN
  builds

REPOSITORY
  R265 KConfigWidgets

BRANCH
  incl

REVISION DETAIL
  https://phabricator.kde.org/D25512

AFFECTED FILES
  src/krecentfilesaction.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

[David Edmundson]

davidedmundson added a comment.


  > The trouble is still here: if we land this patch and released new 
frameworks, it won't work with older plasma workspace (like 5.17.0, 5.16.x).
  
  Talk me through what will happen. Do they end up in lost and found?
  
  In terms of the circular dependency, it does indeed seem very weird. Task for 
the KF6 board at least.
  
  So, the state is:
   ksycoca needs to know the name of the menu to use at compile time
   That menu is therefore in the framework
   The directory files it references are not.
  
  IMHO the part that seems most wrong is that ksycocacocacooca needs the name 
at compile time. If we were on gnome we would want to load gnome's menu 
structure surely? Though maybe we need to at least have some menu so that 
ksycococoaoca loads all the applications even if they end up in the wrong "dir".

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: davidedmundson, ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25511: Drop unused broken KGesture support

[Volker Krause]

vkrause added a comment.


  Seems used in KAction in kdelibs4support.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25511

To: davidedmundson
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25511: Drop unused broken KGesture support

[David Edmundson]

davidedmundson edited the summary of this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25511

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

[Yunhe Guo]

guoyunhe added a comment.


  Not sure who should I ping. So I posted in maillist plasma-de...@kde.org

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25511: Drop unused broken KGesture support

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The functionality was disabled before kdelibs 4.0
  (7a390751076bafafc67557007172028956966ef1 
)
  
  These classes were compile time skipped from KShortcutsEditor and
  KShortcutsEditorItem and unused elsewhere in the library.
  
  Gestures exist in some form in Qt.
  
  The header files were installed as _p.h
  
  The symbols were exported, but anyone using them was using clearly
  private API.

TEST PLAN
  Compiles

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25511

AFFECTED FILES
  src/CMakeLists.txt
  src/kgesture.cpp
  src/kgesture_p.h
  src/kgesturemap.cpp
  src/kgesturemap_p.h
  src/kshortcutsdialog_p.h
  src/kshortcutseditor.cpp
  src/kshortcutseditor.h
  src/kshortcutseditoritem.cpp

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

[Luigi Toscano]

ltoscano added a comment.


  Maybe pinging a few Plasma people may be more effective, or though a mailing 
list thread. I don't know.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24046: Allow triggering sort from QML

[Michael Pyne]

mpyne added inline comments.

INLINE COMMENTS

> broulik wrote in personssortfilterproxymodel.h:53
> "You can ... reimplement virtual functions defined in the primary base class 
> hierarchy (that is, virtuals defined in the first non-virtual base class, or 
> in that class's first non-virtual base class, and so forth) if it is safe 
> that programs linked with the prior version of the library call the 
> implementation in the base class rather than the derived one. This is tricky 
> and might be dangerous. Think twice before doing it. Alternatively see below 
> for a workaround."
> Now I'm confused :(

Approximately no one uses C++ virtual classes (which are a separate feature 
from virtual methods which we are used to).

Basically, reimplementing a virtual function that's already defined in a base 
class can be binary compatible for already-compiled programs because it doesn't 
change the size or calling convention of the virtual table: there was already a 
slot in the virtual table to call the base class's implementation of a virtual 
function, and we replaced the pointer in the virtual table to instead call the 
newly-implemented virtual function in the derived class.

The catch is that already-compiled code is not guaranteed to call the derived 
class implementation (due to inlining or other optimizations, for instance) so 
you cannot absolutely rely on your new implementation being called.

If you have to think too hard about whether it's safe or not, it's best to 
assume it's not.

In this case we're literally just calling the original implementation anyways, 
and `Q_INVOKABLE` is just to register it to the meta-object system, so I think 
this should be fine. But if we want to use a separate method I'd label it as 
"KF6 TODO" or something similar so that we can go back and fix it up.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D24046

To: nicolasfella, apol
Cc: mpyne, jbbgameich, broulik, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

[Yunhe Guo]

guoyunhe added a comment.


  @ngraham @ltoscano should I create bug ticket about the dependency issue we 
have here?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » threadweaver » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20FreeBSDQt5.13/27/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 24 Nov 2019 18:51:32 +
 Build duration:
7 min 7 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.autotests.ThreadWeaverJobTests

D23205: [KProcessList] Optimize KProcessList::processInfo

[Michael Pyne]

mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.


  I've reviewed the patch and it's good, you've addressed the issues that were 
noted by Aleix already, so please commit and we can address anything that might 
pop up as it happens.

REPOSITORY
  R244 KCoreAddons

BRANCH
  optimize_kprocesslist_processinfo

REVISION DETAIL
  https://phabricator.kde.org/D23205

To: hallas, davidedmundson, broulik, mpyne
Cc: mpyne, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25508: Make KF6 cleanup work visible

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:c8fa3ab044cb: Make KF6 cleanup work visible (authored by 
dhaumann).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25508?vs=70264&id=70266

REVISION DETAIL
  https://phabricator.kde.org/D25508

AFFECTED FILES
  src/kmoretools/kmoretoolsmenufactory.h

To: dhaumann, gregormi, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  In D25334#566745 , @ndavis wrote:
  
  > Yes that's right, the Kickoff tabs are fine, it's the panel that doesn't 
look right. It just doesn't look good with that kind of highlight to me. Or 
maybe the highlight background is too bright.
  
  
  To me it looks fine with Breeze light IMO. If you think it looks bad with 
Breeze Dark, that seems like kind of a problem since as far as I was aware, 
this is the proposed new highlight style that you're working on, right? It 
definitely needs to look good with Breeze Dark, or at least no worse than the 
status quo.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25508: Make KF6 cleanup work visible

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  work-add-kf6-note-kmoretools

REVISION DETAIL
  https://phabricator.kde.org/D25508

To: dhaumann, gregormi, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25508: Make KF6 cleanup work visible

[Dominik Haumann]

dhaumann created this revision.
dhaumann added a reviewer: gregormi.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  This work is simply about removing an unused private member
  variable that is in an exported class.

TEST PLAN
  make && make test

REPOSITORY
  R304 KNewStuff

BRANCH
  work-add-kf6-note-kmoretools

REVISION DETAIL
  https://phabricator.kde.org/D25508

AFFECTED FILES
  src/kmoretools/kmoretoolsmenufactory.h

To: dhaumann, gregormi
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24349: More (and last) fixes to compile without implicit conversion from ASCII/ByteArray

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Thanks!

INLINE COMMENTS

> forwardingslavebase.cpp:91
>  
> -if (url.scheme() == q->mProtocol) {
> +if (url.scheme() == QString::fromLatin1(q->mProtocol)) {
>  result = q->rewriteUrl(url, newURL);

QLatin1String is sufficient for comparisons (and cheaper)

> kremoteencoding.cpp:95
>  
>  const char *KRemoteEncoding::encoding() const
>  {

KF6 TODO: return QByteArray

> slavebase.h:979
>  QByteArray mProtocol;
> +inline const QString mProtocolToStr() {
> +return QString::fromLatin1(mProtocol);

This method should be const

> ftp.cpp:1232
>  if (!isfile) {
> -ftpFolder(remoteEncoding()->directory(url), false);// ignore 
> errors
> +ftpFolder(QString::fromLocal8Bit(remoteEncoding()->directory(url)), 
> false);// ignore errors
>  }

Should this be remoteEncoding()->decode(...) given that the method will then 
use q->remoteEncoding()->encode()?

(I'm a bit confused with kremoteencoding, I could be wrong)

> kcookiespolicies.cpp:367
> +if (mUi.rbPolicyAccept->isChecked()) {
> +advice = 
> QString::fromLocal8Bit(KCookieAdvice::adviceToStr(KCookieAdvice::Accept));
> +} else if (mUi.rbPolicyAcceptForSession->isChecked()) {

fromLatin1 is enough for adviceToStr, like you did on line 177 (so it's 
inconsistent)

(repeats 3 more times)

> smbrodlg.cpp:122
>unsigned int num = ((a1 & 0x3F) << 10) | ((a2& 0x1F) << 5) | (a3 & 
> 0x1F);
> -  password[i] = QChar((uchar)((num - 17) ^ 173)); // restore
> +  password[i] = QChar(QLatin1Char((num - 17) ^ 173)); // restore
> }

You could remove the QChar() around I guess.

> main.cpp:199
>  for (; it != fileList.end() ; ++it) {
> -QFileInfo info(QFile::encodeName(it->path));
> +QFileInfo info(QString::fromLocal8Bit(QFile::encodeName(it->path)));
>  it->time = info.lastModified();

Ouch.

  QFileInfo info(it->path)

should be enough.

> main.cpp:262
>  qDebug() << sleepSecs << "seconds have passed, deleting" << 
> info.filePath();
> -QFile(QFile::encodeName(src)).remove();
> +QFile(QString::fromLocal8Bit(QFile::encodeName(src))).remove();
>  // NOTE: this is not necessarily a temporary directory.

Same here

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24349

To: ahmadsamir, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

[Waqar Ahmed]

waqar updated this revision to Diff 70262.
waqar added a comment.


  Revert a change, as autodetection fails for languages with similar scripts

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25495?vs=70238&id=70262

BRANCH
  fix-176537 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25495

AFFECTED FILES
  src/core/guesslanguage.cpp

To: waqar, mludwig
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25503: JavaScript: move keywords from TypeScript and other improvements

[Dominik Haumann]

dhaumann added a comment.


  I think this is ok.
  
  I recognize only now that a much better syntax would have been
  
variable_property
  
  but that is off-topic :)
  
  If the kateversions are correct, then I'm fine with this.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25503

To: nibags, cullmann, dhaumann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25506: Remove Attica from KAboutDialog

[Kai Uwe Broulik]

broulik retitled this revision from "Remove Attica" to "Remove Attica from 
KAboutDialog".

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25506

To: broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25506: Remove Attica from KAboutDialog

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25506

To: broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25506: Remove Attica

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It's defunct and unused.
  Gets rid of everything that cannot be done with just `KAboutData`, i.e. 
everything about avatar handling and painting, a person's "location",

TEST PLAN
  T12198 
  
  - About dialog in various apps still looks alright

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25506

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kaboutapplicationconfigattica_p.h.cmake
  src/kaboutapplicationdialog.cpp
  src/kaboutapplicationpersonlistdelegate_p.cpp
  src/kaboutapplicationpersonmodel_p.cpp
  src/kaboutapplicationpersonmodel_p.h
  src/kaboutplugindialog.cpp
  src/kabstractaboutdialog_p.cpp
  src/kabstractaboutdialog_p.h
  src/kxmlgui.qrc
  src/thumb_frame.png

To: broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

[Friedrich W. H. Kossebau]

kossebau added a comment.


  IMHO such idea notes should also be put into the source file or, better, a 
separate TODO file in the toplevel source, not the header (which is going to be 
deployed as part of devel-packages), as this note is uninteresting to users of 
current KXMLGUIClient.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24695

To: meven, #frameworks, kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: KF6 Blogs

[David Faure]

On samedi 23 novembre 2019 16:34:01 CET Dominik Haumann wrote:
> Hi everyone,
> 
> could you who currently are at the KF6 sprint blog a bit more?
> 
> Even if it's just about small details like "app X does not depend on Y
> anymore and this is how we got rid of the dependency" already is valuable
> information, since it helps other contributors to not introduce such code
> anymore.
> 
> The KDE Frameworks are our foundations for pretty much everything we do. It
> deserves more press coverage, including maybe a final dot story.

Nothing has actually been done yet, it's all about making decisions and 
creating tasks ;-)

https://phabricator.kde.org/project/board/310/ is filling up with tasks (there 
are a lot, help welcome!).

Not saying blogs wouldn't be good, but they would be more about plans than 
things already done. And since most of our time is spent in meetings (lots to 
discuss and decide), the blogging should/will probably happen afterwards.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D24349: More (and last) fixes to compile without implicit conversion from ASCII/ByteArray

[Friedrich W. H. Kossebau]

kossebau edited reviewers, added: Frameworks; removed: kossebau.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24349

To: ahmadsamir, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25059: KPluginSelector: use new KAboutPluginDialog

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:918978c7e26e: KPluginSelector: use new KAboutPluginDialog 
(authored by kossebau).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25059?vs=69004&id=70260

REVISION DETAIL
  https://phabricator.kde.org/D25059

AFFECTED FILES
  src/kpluginselector.cpp

To: kossebau, #frameworks, dfaure, apol
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 62 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/62/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 24 Nov 2019 12:53:26 +
 Build duration:
2 min 47 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D25063: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog

[Friedrich W. H. Kossebau]

kossebau marked an inline comment as done.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25063

To: kossebau, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25063: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:e8f558f8b2c7: Deprecate KAboutData::fromPluginMetaData, 
now there is KAboutPluginDialog (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25063?vs=69017&id=70259#toc

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25063?vs=69017&id=70259

REVISION DETAIL
  https://phabricator.kde.org/D25063

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/kaboutdata.cpp
  src/lib/kaboutdata.h

To: kossebau, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D7010: KSqueezedTextLabel: call updateGeometry() when text changes

[Christoph Feck]

cfeck resigned from this revision.
cfeck added a comment.
This revision is now accepted and ready to land.


  Yes, I would prefer the check condition. Feel free to commandeer; it looks 
like the original author didn't find time to further investigate.

REVISION DETAIL
  https://phabricator.kde.org/D7010

To: brauch, dfaure
Cc: rkflx, dfaure, dhaumann, aacid, #frameworks, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25058: Add KAboutPluginDialog, to be used with KPluginMetaData

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
kossebau marked 2 inline comments as done.
Closed by commit R263:415402081d92: Add KAboutPluginDialog, to be used with 
KPluginMetaData (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25058?vs=70052&id=70258#toc

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25058?vs=70052&id=70258

REVISION DETAIL
  https://phabricator.kde.org/D25058

AFFECTED FILES
  src/CMakeLists.txt
  src/kaboutapplicationdialog.cpp
  src/kaboutapplicationdialog.h
  src/kaboutplugindialog.cpp
  src/kaboutplugindialog.h
  src/kabstractaboutdialog_p.cpp
  src/kabstractaboutdialog_p.h
  src/klicensedialog_p.cpp
  src/klicensedialog_p.h

To: kossebau, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25503: JavaScript: move keywords from TypeScript and other improvements

[Nibaldo González]

nibags updated this revision to Diff 70254.
nibags added a comment.


  - Update comment

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25503?vs=70253&id=70254

BRANCH
  improve-javascript

REVISION DETAIL
  https://phabricator.kde.org/D25503

AFFECTED FILES
  autotests/folding/example.rmd.fold
  autotests/folding/highlight.js.fold
  autotests/folding/highlight.jsp.fold
  autotests/folding/highlight.php.fold
  autotests/folding/test.coffee.fold
  autotests/folding/test.htm.fold
  autotests/folding/test.js.fold
  autotests/folding/test.jsx.fold
  autotests/folding/test.markdown.fold
  autotests/folding/test.qml.fold
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/highlight.js.html
  autotests/html/highlight.jsp.html
  autotests/html/highlight.php.html
  autotests/html/highlight.qml.html
  autotests/html/test.coffee.html
  autotests/html/test.htm.html
  autotests/html/test.js.html
  autotests/html/test.jsx.html
  autotests/html/test.markdown.html
  autotests/html/test.qml.html
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/highlight.js
  autotests/input/test.coffee
  autotests/input/test.js
  autotests/input/test.jsx
  autotests/input/test.qml
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/highlight.js.ref
  autotests/reference/highlight.jsp.ref
  autotests/reference/highlight.php.ref
  autotests/reference/highlight.qml.ref
  autotests/reference/test.coffee.ref
  autotests/reference/test.htm.ref
  autotests/reference/test.js.ref
  autotests/reference/test.jsx.ref
  autotests/reference/test.markdown.ref
  autotests/reference/test.qml.ref
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/coffee.xml
  data/syntax/javascript-react.xml
  data/syntax/javascript.xml
  data/syntax/qml.xml
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, cullmann, dhaumann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25503: JavaScript: move keywords from TypeScript and other improvements

[Nibaldo González]

nibags edited the summary of this revision.
nibags added reviewers: cullmann, dhaumann, Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25503

To: nibags, cullmann, dhaumann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25503: JavaScript: move keywords from TypeScript and other improvements

[Nibaldo González]

nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-javascript

REVISION DETAIL
  https://phabricator.kde.org/D25503

AFFECTED FILES
  autotests/folding/example.rmd.fold
  autotests/folding/highlight.js.fold
  autotests/folding/highlight.jsp.fold
  autotests/folding/highlight.php.fold
  autotests/folding/test.coffee.fold
  autotests/folding/test.htm.fold
  autotests/folding/test.js.fold
  autotests/folding/test.jsx.fold
  autotests/folding/test.markdown.fold
  autotests/folding/test.qml.fold
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/highlight.js.html
  autotests/html/highlight.jsp.html
  autotests/html/highlight.php.html
  autotests/html/highlight.qml.html
  autotests/html/test.coffee.html
  autotests/html/test.htm.html
  autotests/html/test.js.html
  autotests/html/test.jsx.html
  autotests/html/test.markdown.html
  autotests/html/test.qml.html
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/highlight.js
  autotests/input/test.coffee
  autotests/input/test.js
  autotests/input/test.jsx
  autotests/input/test.qml
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/highlight.js.ref
  autotests/reference/highlight.jsp.ref
  autotests/reference/highlight.php.ref
  autotests/reference/highlight.qml.ref
  autotests/reference/test.coffee.ref
  autotests/reference/test.htm.ref
  autotests/reference/test.js.ref
  autotests/reference/test.jsx.ref
  autotests/reference/test.markdown.ref
  autotests/reference/test.qml.ref
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/coffee.xml
  data/syntax/javascript-react.xml
  data/syntax/javascript.xml
  data/syntax/qml.xml
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17863: Add ecm_check_linker_flags function

[Tobias C. Berner]

tcberner abandoned this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D17863

To: tcberner, #freebsd, dfaure, apol, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D17595: Upstream Dolphin's file rename dialog

[Méven Car]

meven added a subscriber: lydia.
meven added a comment.


  In D17595#566800 , @dhaumann wrote:
  
  > In D17595#542142 , @meven wrote:
  >
  > > I received the agreements of all contributors including the original code 
author, to relicense this code and hence upstream it.
  >
  >
  > Playing the bad guy here: where are these agreements? On a public mailing 
list, or in your private inbox? If on a public mailing list, you could 
reference these mails on our mail archives in your commit message.
  
  
  On kde-ev-board cc'd private mailing list.
  I'd be happy to add some paper trail in the files as @dhaumann suggested, but 
I don't what form it might take. @lydia any suggestion ?
  
  And by the way If you haven't done already **Sign the FLA** 
https://ev.kde.org/resources/FLA.pdf

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: lydia, dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, 
dhaumann, pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham