D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Fabian Vogt]

fvogt added a comment.


  In D23384#571276 , @ngraham wrote:
  
  > I'm afraid that even with that change, the issue is still present. I 
honestly don't think it would be the worst thing in the world if we always 
handed the kio-fuse paths to apps that don't use ioslaves.
  
  
  It would be. I like to have links like http://kde.org opened properly in the 
web browser, ftp://some/where opened in an FTP client and so on...
  Media players know more about the format and streaming it than kio-fuse ever 
could, so avoiding layers in between if possible is definitely an advantage.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, 
GB_2, michaelh, bruns

D25276: reStructuredText: Fix inline literals highlighting preceding characters

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Ok

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  rst-inline-literal-prefix

REVISION DETAIL
  https://phabricator.kde.org/D25276

To: adrianchavesfernandez, mosra, dhaumann
Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D25708: Don't use nullptr to flags

[Laurent Montel]

mlaurent added a reviewer: romangg.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D25708

To: mlaurent, romangg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25708: Don't use nullptr to flags

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  IT seems that it was a error during modernize code by using nullptr
  but it's a flags so we can't use it

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D25708

AFFECTED FILES
  src/client/xdgshell_stable.cpp
  src/client/xdgshell_v6.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.13 - Build # 51 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.13/51/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 03 Dec 2019 00:47:31 +
 Build duration:
7 min 23 sec and counting
   BUILD ARTIFACTS
  acc/KF5KDE4Support-5.65.0.xmlacc/KF5KDELibs4Support-5.65.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21566/45930)38%
(13018/34241)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11346/11737)50%
(7172/14369)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9470/17858)48%
(5538/11439)src.kdeui19%
(13/67)19%
(13/67)8%
(740/9665)6%
(307/5368)src.kio7%
(2/27)7%
(2/27)0%
(10/2260)0%
(1/1242)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/855)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/186)0%
(0/87)src.solid-networkstatus.kded0%
(0/7)0%
(0/7)0%
(0/220)0%
(0/102)tests0%
(0/34)0%
(0/34)0%
(0/1530)0%
(0/487)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 78 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/78/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 03 Dec 2019 00:47:31 +
 Build duration:
6 min 37 sec and counting
   BUILD ARTIFACTS
  acc/KF5KDE4Support-5.65.0.xmlacc/KF5KDELibs4Support-5.65.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21566/45930)38%
(13018/34241)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11346/11737)50%
(7172/14369)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9470/17858)48%
(5538/11439)src.kdeui19%
(13/67)19%
(13/67)8%
(740/9665)6%
(307/5368)src.kio7%
(2/27)7%
(2/27)0%
(10/2260)0%
(1/1242)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/855)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/186)0%
(0/87)src.solid-networkstatus.kded0%
(0/7)0%
(0/7)0%
(0/220)0%
(0/102)tests0%
(0/34)0%
(0/34)0%
(0/1530)0%
(0/487)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 48 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/48/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 03 Dec 2019 00:47:30 +
 Build duration:
4 min 39 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

TEST PLAN
  Triggered rename dialog. Still have icons in there

REPOSITORY
  R241 KIO

BRANCH
  rena

REVISION DETAIL
  https://phabricator.kde.org/D25707

AFFECTED FILES
  src/widgets/renamedialog.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 77 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/77/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 03 Dec 2019 00:35:19 +
 Build duration:
2 min 30 sec and counting
   CONSOLE OUTPUT
  [...truncated 951 lines...][2019-12-03T00:37:42.321Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.12/src/kdeui/k4style.cpp: In member function ���virtual void K4Style::drawComplexControl(QStyle::ComplexControl, const QStyleOptionComplex*, QPainter*, const QWidget*) const���:[2019-12-03T00:37:42.321Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.12/src/kdeui/k4style.cpp:3156:9: warning: this statement may fall through [-Wimplicit-fallthrough=][2019-12-03T00:37:42.321Z]  3156 | } //option OK[2019-12-03T00:37:42.321Z]   | ^[2019-12-03T00:37:42.321Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.12/src/kdeui/k4style.cpp:3159:5: note: here[2019-12-03T00:37:42.321Z]  3159 | case CC_ComboBox: {[2019-12-03T00:37:42.321Z]   | ^~~~[2019-12-03T00:37:42.322Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.12/src/kdeui/k4style.cpp: In member function ���virtual QRect K4Style::subControlRect(QStyle::ComplexControl, const QStyleOptionComplex*, QStyle::SubControl, const QWidget*) const���:[2019-12-03T00:37:42.322Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.12/src/kdeui/k4style.cpp:3697:13: warning: this statement may fall through [-Wimplicit-fallthrough=][2019-12-03T00:37:42.322Z]  3697 | if (helpBtn) {[2019-12-03T00:37:42.322Z]   | ^~[2019-12-03T00:37:42.322Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.12/src/kdeui/k4style.cpp:3700:9: note: here[2019-12-03T00:37:42.322Z]  3700 | case SC_TitleBarMinButton:[2019-12-03T00:37:42.322Z]   | ^~~~[2019-12-03T00:37:42.322Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.12/src/kdeui/k4style.cpp:3701:13: warning: this statement may fall through [-Wimplicit-fallthrough=][2019-12-03T00:37:42.322Z]  3701 | if (minBtn) {[2019-12-03T00:37:42.322Z]   | ^~[2019-12-03T00:37:42.322Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.12/src/kdeui/k4style.cpp:3706:9: note: here[2019-12-03T00:37:42.322Z]  3706 | case SC_TitleBarNormalButton:[2019-12-03T00:37:42.322Z]   | ^~~~[2019-12-03T00:37:42.322Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.12/src/kdeui/k4style.cpp:3707:13: warning: this statement may fall through [-Wimplicit-fallthrough=][2019-12-03T00:37:42.322Z]  3707 | if (restoreBtn) {[2019-12-03T00:37:42.322Z]   | ^~[2019-12-03T00:37:42.322Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.12/src/kdeui/k4style.cpp:3712:9: note: here[2019-12-03T00:37:42.322Z]  3712 | case SC_TitleBarMaxButton:[2019-12-03T00:37:42.322Z]   | ^~~~[2019-12-03T00:37:42.322Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.12/src/kdeui/k4style.cpp:3713:13: warning: this statement may fall through [-Wimplicit-fallthrough=][2019-12-03T00:37:42.322Z]  3713 | if (maxBtn) {[2019-12-03T00:37:42.322Z]   | ^~[2019-12-03T00:37:42.322Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.12/src/kdeui/k4style.cpp:3718:9: note: here[2019-12-03T00:37:42.322Z]  3718 | case SC_TitleBarShadeButton:[2019-12-03T00:37:42.322Z]   | ^~~~[2019-12-03T00:37:42.322Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.12/src/kdeui/k4style.cpp:3721:20: warning: this statement may fall through [-Wimplicit-fallthrough=][2019-12-03T00:37:42.322Z]  3721 | } else if (subControl == SC_TitleBarShadeButton) {[2019-12-03T00:37:42.322Z]   |^~[2019-12-03T00:37:42.322Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.12/src/kdeui/k4style.cpp:3724:9: note: here[2019-12-03T00:37:42.322Z]  3724 | case SC_TitleBarUnshadeButton:[2019-12-03T00:37:42.322Z]   | ^~~~[2019-12-03T00:37:42.322Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.12/src/kdeui/k4style.cpp:3727:20: warning: this statement may fall through [-Wimplicit-fallthrough=][2019-12-03T00:37:42.322Z]  3727 | } else if (subControl == SC_TitleBarUnshadeButton) {[2019-12-03T00:37:42.322Z]   |^~[2019-12-03T00:37:42.322Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.12/src/kdeui/k4style.cpp:3730:9: note: here[2019-12-03T00:37:42.322Z]  3730 | case SC_TitleBarCloseButton: {[2019-12-03T00:37:42.322Z]   | ^~~~[2019-12-03T00:37:42.322Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.12/src/kdeui/k4style.cpp:3520:9: warning: this statement may fal

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 186 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/186/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 02 Dec 2019 23:39:49 +
 Build duration:
57 min and counting

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 47 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/47/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 03 Dec 2019 00:35:15 +
 Build duration:
1 min 30 sec and counting
   CONSOLE OUTPUT
  [...truncated 1057 lines...][2019-12-03T00:36:44.301Z] #define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))[2019-12-03T00:36:44.301Z]   ^[2019-12-03T00:36:44.569Z] /usr/home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 FreeBSDQt5.13/src/kdeui/kcolordialog.cpp:1754:31: warning: 'grabWindow' is deprecated: Use QScreen::grabWindow() instead [-Wdeprecated-declarations][2019-12-03T00:36:44.569Z] QPixmap pm = QPixmap::grabWindow(desktop->winId(), p.x(), p.y(), 1, 1);[2019-12-03T00:36:44.569Z]   ^[2019-12-03T00:36:44.569Z] /usr/local/include/qt5/QtGui/qpixmap.h:119:5: note: 'grabWindow' has been explicitly marked deprecated here[2019-12-03T00:36:44.569Z] QT_DEPRECATED_X("Use QScreen::grabWindow() instead")[2019-12-03T00:36:44.569Z] ^[2019-12-03T00:36:44.569Z] /usr/local/include/qt5/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'[2019-12-03T00:36:44.569Z] #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)[2019-12-03T00:36:44.569Z] ^[2019-12-03T00:36:44.569Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:649:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'[2019-12-03T00:36:44.569Z] #define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))[2019-12-03T00:36:44.569Z]   ^[2019-12-03T00:36:44.828Z] 6 warnings generated.[2019-12-03T00:36:44.828Z] In file included from /usr/home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 FreeBSDQt5.13/src/kdeui/kdialog.cpp:24:[2019-12-03T00:36:44.828Z] /usr/home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 FreeBSDQt5.13/src/kdeui/kdialog_p.h:39:5: warning: 'QSignalMapper' is deprecated [-Wdeprecated-declarations][2019-12-03T00:36:44.828Z] KDialogPrivate()[2019-12-03T00:36:44.828Z] ^[2019-12-03T00:36:44.828Z] /usr/local/include/qt5/QtCore/qsignalmapper.h:56:5: note: 'QSignalMapper' has been explicitly marked deprecated here[2019-12-03T00:36:44.828Z] QT_DEPRECATED explicit QSignalMapper(QObject *parent = nullptr);[2019-12-03T00:36:44.828Z] ^[2019-12-03T00:36:44.828Z] /usr/local/include/qt5/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'[2019-12-03T00:36:44.828Z] #  define QT_DEPRECATED Q_DECL_DEPRECATED[2019-12-03T00:36:44.828Z] ^[2019-12-03T00:36:44.828Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:233:45: note: expanded from macro 'Q_DECL_DEPRECATED'[2019-12-03T00:36:44.828Z] #  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))[2019-12-03T00:36:44.828Z] ^[2019-12-03T00:36:45.087Z] 4 warnings generated.[2019-12-03T00:36:45.087Z] /usr/home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 FreeBSDQt5.13/src/kdeui/kdialog.cpp:573:18: warning: 'isVirtualDesktop' is deprecated: Use QScreen::virtualSiblings() of primary screen [-Wdeprecated-declarations][2019-12-03T00:36:45.087Z] if (desktop->isVirtualDesktop() &&[2019-12-03T00:36:45.087Z]  ^[2019-12-03T00:36:45.087Z] /usr/local/include/qt5/QtWidgets/qdesktopwidget.h:69:5: note: 'isVirtualDesktop' has been explicitly marked deprecated here[2019-12-03T00:36:45.087Z] QT_DEPRECATED_X("Use QScreen::virtualSiblings() of primary screen")  bool isVirtualDesktop() const;[2019-12-03T00:36:45.087Z] ^[2019-12-03T00:36:45.087Z] /usr/local/include/qt5/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'[2019-12-03T00:36:45.087Z] #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)[2019-12-03T00:36:45.087Z] ^[2019-12-03T00:36:45.087Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:649:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'[2019-12-03T00:36:45.087Z] #define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))[2019-12-03T00:36:45.087Z]   ^[2019-12-03T00:36:45.087Z] /usr/home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 FreeBSDQt5.13/src/kdeui/kdialog.cpp:577:46: warning: 'numScreens' is deprecated: Use QGuiApplication::screens() [-Wdeprecated-declarations][2019-12-03T00:36:45.087Z] if (screen < 0 || screen >= desktop->numScreens()) {[2019-12-03T00:36:45.087Z]  ^[2019-12-03T00:36:45.087Z] /usr/local/include/qt5/QtWidgets/qdesktopwidget.h:71:5: note: 'numScreens' has been explicitly marked deprecated here[2019-12-03T00:36:45.087Z] QT_DEPRECATED_X("Use QGuiApplication::screens()") int numScreens() const;[2019-12-03T00:36:45.087Z] ^[2019-12-03T00

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.13 - Build # 50 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.13/50/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 03 Dec 2019 00:35:22 +
 Build duration:
1 min 41 sec and counting
   CONSOLE OUTPUT
  [...truncated 1273 lines...][2019-12-03T00:37:01.248Z]   |^[2019-12-03T00:37:01.505Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.13/src/kdeui/k4style.cpp: In member function ���virtual void K4Style::drawControl(QStyle::ControlElement, const QStyleOption*, QPainter*, const QWidget*) const���:[2019-12-03T00:37:01.505Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.13/src/kdeui/k4style.cpp:2353:9: warning: this statement may fall through [-Wimplicit-fallthrough=][2019-12-03T00:37:01.505Z]  2353 | }[2019-12-03T00:37:01.505Z]   | ^[2019-12-03T00:37:01.505Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.13/src/kdeui/k4style.cpp:2356:5: note: here[2019-12-03T00:37:01.505Z]  2356 | case CE_HeaderLabel: {[2019-12-03T00:37:01.505Z]   | ^~~~[2019-12-03T00:37:01.505Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.13/src/kdeui/k4style.cpp: In member function ���virtual QRect K4Style::subElementRect(QStyle::SubElement, const QStyleOption*, const QWidget*) const���:[2019-12-03T00:37:01.505Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.13/src/kdeui/k4style.cpp:3000:9: warning: this statement may fall through [-Wimplicit-fallthrough=][2019-12-03T00:37:01.505Z]  3000 | }[2019-12-03T00:37:01.505Z]   | ^[2019-12-03T00:37:01.505Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.13/src/kdeui/k4style.cpp:3003:5: note: here[2019-12-03T00:37:01.505Z]  3003 | case SE_TabBarTabText: {[2019-12-03T00:37:01.505Z]   | ^~~~[2019-12-03T00:37:01.505Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.13/src/kdeui/k4style.cpp: In member function ���virtual void K4Style::drawComplexControl(QStyle::ComplexControl, const QStyleOptionComplex*, QPainter*, const QWidget*) const���:[2019-12-03T00:37:01.505Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.13/src/kdeui/k4style.cpp:3156:9: warning: this statement may fall through [-Wimplicit-fallthrough=][2019-12-03T00:37:01.505Z]  3156 | } //option OK[2019-12-03T00:37:01.505Z]   | ^[2019-12-03T00:37:01.505Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.13/src/kdeui/k4style.cpp:3159:5: note: here[2019-12-03T00:37:01.505Z]  3159 | case CC_ComboBox: {[2019-12-03T00:37:01.505Z]   | ^~~~[2019-12-03T00:37:01.505Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.13/src/kdeui/k4style.cpp: In member function ���virtual QRect K4Style::subControlRect(QStyle::ComplexControl, const QStyleOptionComplex*, QStyle::SubControl, const QWidget*) const���:[2019-12-03T00:37:01.505Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.13/src/kdeui/k4style.cpp:3697:13: warning: this statement may fall through [-Wimplicit-fallthrough=][2019-12-03T00:37:01.505Z]  3697 | if (helpBtn) {[2019-12-03T00:37:01.505Z]   | ^~[2019-12-03T00:37:01.505Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.13/src/kdeui/k4style.cpp:3700:9: note: here[2019-12-03T00:37:01.505Z]  3700 | case SC_TitleBarMinButton:[2019-12-03T00:37:01.505Z]   | ^~~~[2019-12-03T00:37:01.505Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.13/src/kdeui/k4style.cpp:3701:13: warning: this statement may fall through [-Wimplicit-fallthrough=][2019-12-03T00:37:01.505Z]  3701 | if (minBtn) {[2019-12-03T00:37:01.505Z]   | ^~[2019-12-03T00:37:01.505Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.13/src/kdeui/k4style.cpp:3706:9: note: here[2019-12-03T00:37:01.505Z]  3706 | case SC_TitleBarNormalButton:[2019-12-03T00:37:01.505Z]   | ^~~~[2019-12-03T00:37:01.505Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.13/src/kdeui/k4style.cpp:3707:13: warning: this statement may fall through [-Wimplicit-fallthrough=][2019-12-03T00:37:01.505Z]  3707 | if (restoreBtn) {[2019-12-03T00:37:01.505Z]   | ^~[2019-12-03T00:37:01.505Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.13/src/kdeui/k4style.cpp:3712:9: note: here[2019-12-03T00:37:01.505Z]  3712 | case SC_TitleBarMaxButton:[2019-12-03T00:37:01.505Z]   | ^~~~[2019-12-03T00:37:01.505Z] /home/jenkins/workspace/Frameworks/kdelibs4support/kf5-qt5 SUSEQt5.13/src/kdeui/k4style.cpp:3713:13: warning: this statement may fall through [-Wimplicit-fallthrough=][2019-12-03T00:37:01.505Z]  3713 | if (maxBtn) {[2019-12-03T00:37:01.505Z]   | 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 344 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/344/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 02 Dec 2019 23:57:11 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/405)67%
(270/405)56%
(34642/61660)40%
(17582/43544)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9645/10105)47%
(4502/9556)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)59%
(8658/14558)51%
(4515/8815)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4663/8282)43%
(2025/4737)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(678/1206)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(524/1418)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

D25705: Deprecate KIO::pixmapForUrl

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Can easily be done otherwise.

REPOSITORY
  R241 KIO

BRANCH
  pfo

REVISION DETAIL
  https://phabricator.kde.org/D25705

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/pixmaploader.h

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 211 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/211/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 02 Dec 2019 23:57:11 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Nathaniel Graham]

ngraham added a comment.


  I'm afraid that even with that change, the issue is still present. I honestly 
don't think it would be the worst thing in the world if we always handed the 
kio-fuse paths to apps that don't use ioslaves. My impression is that the few 
apps that have implemented their own samba clients and the like did so mostly 
to work around the lack of this feature.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, 
GB_2, michaelh, bruns

D25704: [kfilewidget] Load icons by name

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:b21a6c1a5b93: [kfilewidget] Load icons by name (authored 
by nicolasfella).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25704?vs=70801&id=70803

REVISION DETAIL
  https://phabricator.kde.org/D25704

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: nicolasfella, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Noah Davis]

ndavis marked 3 inline comments as done.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25677

To: ndavis, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Noah Davis]

ndavis updated this revision to Diff 70802.
ndavis added a comment.


  - [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items
  - fix code style

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25677?vs=70720&id=70802

BRANCH
  arcpatch-D25677 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25677

AFFECTED FILES
  src/kcolorscheme.cpp

To: ndavis, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25704: [kfilewidget] Load icons by name

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  icco

REVISION DETAIL
  https://phabricator.kde.org/D25704

To: nicolasfella, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 225 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/225/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 02 Dec 2019 23:39:50 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(271/405)67%
(271/405)56%
(34648/61667)40%
(17592/43540)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9643/10105)47%
(4504/9556)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)59%
(8657/14558)51%
(4522/8815)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4669/8289)43%
(2024/4733)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(678/1206)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(524/1418)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 210 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/210/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 02 Dec 2019 23:39:46 +
 Build duration:
9 min 12 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25704: [kfilewidget] Load icons by name

[Nicolas Fella]

nicolasfella updated this revision to Diff 70801.
nicolasfella added a comment.


  - [kfilewidget] Load icons by name
  - Remove include

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25704?vs=70800&id=70801

BRANCH
  icco

REVISION DETAIL
  https://phabricator.kde.org/D25704

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25700: [KHistoryComboBox] Add method to set an icon provider

[Aleix Pol Gonzalez]

apol added a comment.


  +1 Makes sense to me

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D25700

To: nicolasfella, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 343 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/343/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 02 Dec 2019 23:39:51 +
 Build duration:
8 min 14 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(271/405)67%
(271/405)56%
(34657/61669)40%
(17591/43544)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9642/10105)47%
(4501/9556)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8666/14558)51%
(4529/8815)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4663/8289)43%
(2022/4737)src.gui100%
(2/2)100%
(2/2)89%
(96/108)68%
(45/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(678/1206)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(524/1418)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1798/4289)36%
(1303/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  prov

REVISION DETAIL
  https://phabricator.kde.org/D25701

To: nicolasfella, #plasma, #frameworks, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25704: [kfilewidget] Load icons by name

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Skip the indirection over pixmap

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25704

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:38b02c1baa84: [KColorScheme] Add items to ColorSet and 
Role enums for the total number of… (authored by ndavis).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25676?vs=70718&id=70798

REVISION DETAIL
  https://phabricator.kde.org/D25676

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: ndavis, #frameworks, dfaure, davidedmundson, hpereiradacosta
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Alexander Saoutkin]

feverfew updated this revision to Diff 70799.
feverfew added a comment.


  Chek for userInfo instead of just password

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23384?vs=70773&id=70799

BRANCH
  arcpatch-D23384

REVISION DETAIL
  https://phabricator.kde.org/D23384

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/desktopexecparser.cpp
  src/core/org.kde.KIOFuse.VFS.xml
  src/widgets/CMakeLists.txt
  src/widgets/krun.cpp
  src/widgets/org.kde.KIOFuse.VFS.xml

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, 
GB_2, michaelh, bruns

D25511: Drop unused broken KGesture support

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> CMakeLists.txt:147-148
> -install(FILES
> -  kgesture_p.h
> -  kgesturemap_p.h
> -  ${CMAKE_CURRENT_BINARY_DIR}/kxmlgui_export.h

You only wanted to stop installing those private headers, not all ;)
Fixed with 89670ad5e9d51390bcff340745f7ce7be4ddb322 


REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25511

To: davidedmundson, vkrause
Cc: kossebau, apol, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Nathaniel Graham]

ngraham added a comment.


  This latest change made Totem work, but broke VLC and SMplayer for my 
password-protected Samba share. See the comment I left on 
https://invent.kde.org/kde/kio-fuse/merge_requests/2#note_19607.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, 
GB_2, michaelh, bruns

D25702: Deprecate KUrlPixmapProvider

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  See T12310  for context

TEST PLAN
  builds

REPOSITORY
  R241 KIO

BRANCH
  pmpr

REVISION DETAIL
  https://phabricator.kde.org/D25702

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/kurlpixmapprovider.cpp
  src/widgets/kurlpixmapprovider.h

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 342 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/342/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 02 Dec 2019 23:14:49 +
 Build duration:
1 min 13 sec and counting
   CONSOLE OUTPUT
  [...truncated 893 lines...][2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   * The installation package was faulty and references files it does not[2019-12-02T23:16:02.053Z]   provide.[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T23:16:02.053Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] "/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   * The installation package was faulty and references files it does not[2019-12-02T23:16:02.053Z]   provide.[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T23:16:02.053Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] "/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   * The installation package was faulty and references files it does not[2019-12-02T23:16:02.053Z]   provide.[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T23:16:02.053Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] "/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   * The installation package was faulty and references files it does not[2019-12-02T23:16:02.053Z]   provide.[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T23:16:02.053Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] "/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   * The installation package was faulty and references files it does not[2019-12-02T23:16:02.053Z]   provide.[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T23:16:02.053Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z] "/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T23:16:02.053Z] [2019-12-02T23:16:02.053Z]   * The installation package was faulty and references files it does not[2019-

D25700: [KHistoryComboBox] Add method to set an icon provider

[Nicolas Fella]

nicolasfella updated this revision to Diff 70794.
nicolasfella added a comment.


  - Deprecation, fix, and docs

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25700?vs=70791&id=70794

BRANCH
  icopro

REVISION DETAIL
  https://phabricator.kde.org/D25700

AFFECTED FILES
  src/CMakeLists.txt
  src/khistorycombobox.cpp
  src/khistorycombobox.h

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25700: [KHistoryComboBox] Add method to set an icon provider

[Nicolas Fella]

nicolasfella edited the summary of this revision.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D25700

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

[Nathaniel Graham]

ngraham added a comment.


  In D25420#571163 , @ahmadsamir 
wrote:
  
  > IMHO, it's such a user-visible bug with several reports and it affects all 
apps that use KIO; it should be included if it can catch the 5.65 train.
  >
  > I can confirm it fixes the issue in my local build (and the code LGTM).
  
  
  No objections if folks smarter than me think the code is acceptable. :)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25420

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: ahmadsamir, feverfew, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  setPixmapProvider will be deprecated with D25700 


TEST PLAN
  Open open folder dialog, history combobox still has icons

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  prov

REVISION DETAIL
  https://phabricator.kde.org/D25701

AFFECTED FILES
  src/platformtheme/kdirselectdialog.cpp

To: nicolasfella, #plasma, #frameworks
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

[Nicolas Fella]

nicolasfella added a task: T12310: Kill KUrlPixmapProvider.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D25701

To: nicolasfella, #plasma, #frameworks
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25700: [KHistoryComboBox] Add method to set an icon provider

[Nicolas Fella]

nicolasfella added a task: T12310: Kill KUrlPixmapProvider.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D25700

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25700: [KHistoryComboBox] Add method to set an icon provider

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  An icon provider can be any function that takes a QString and returns a 
QIcon. This shall replace the setPixmapProvider to allow defining icons by name.
  
  Deprecation of setPixmapProvider will be done once the users are ported

TEST PLAN
  Tested with KDirSelectDialog and a patched plasma-integration

REPOSITORY
  R284 KCompletion

BRANCH
  icopro

REVISION DETAIL
  https://phabricator.kde.org/D25700

AFFECTED FILES
  src/khistorycombobox.cpp
  src/khistorycombobox.h

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25533: Deprecate KFileWidget::toolBar

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  This patch itself is still correct though, of course.

REPOSITORY
  R241 KIO

BRANCH
  ktoolbar

REVISION DETAIL
  https://phabricator.kde.org/D25533

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

[David Faure]

dfaure added a comment.


  Urgh. bool members as used here to share state between methods, with the 
assumption that they're always called together and in a certain order, are very 
brittle.
  
  If KDirOperator is a child widget, and it receives and processes a key event, 
it can choose to NOT let the event propagate to the parent widget
  [by calling accept() on the QKeyEvent, or returning false from event(), or 
true from eventFilter(), depending on how the event is processed -- isn't Qt 
easy? ;-)]

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25420

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: ahmadsamir, feverfew, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

[Ahmad Samir]

ahmadsamir added a reviewer: dfaure.
ahmadsamir added a comment.


  IMHO, it's such a user-visible bug with several reports and it affects all 
apps that use KIO; it should be included if it can catch the 5.65 train.
  
  I can confirm it fixes the issue in my local build (and the code LGTM).

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25420

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: ahmadsamir, feverfew, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

[Filip Fila]

filipf edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  enum-item-counts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks, dfaure, davidedmundson, hpereiradacosta
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25599: Fix plugin-metadata translations on windows

[Albert Astals Cid]

aacid added a comment.


  In D25599#570678 , @vonreth wrote:
  
  > Are you sure? 
https://github.com/KDE/ki18n/blob/a5477f812c563ffd7fb08b6ec4bd573bc49bb76a/src/klocalizedstring.cpp#L146
  
  
  Sure about what?
  
  I don't know what that link is supposed to mean :)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25599

To: sars, aacid, vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, sdepiets, michaelh, ngraham, bruns, 
cullmann, kfunk

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

[Filip Fila]

filipf edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

[Filip Fila]

filipf edited the test plan for this revision.
filipf added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

[Filip Fila]

filipf created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
filipf requested review of this revision.

REVISION SUMMARY
  We've ported the SDDM theme to PC3 and now have black labels in PC3 
ToolButtons (keyboard and session button).
  
  The SDDM theme uses a complementary color scheme, which is something the PC2 
ToolButton respects and turns the labels white.
  
  Therefore I just copy pasted PC2's label color code to its PC3 counterpart: 
https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmastyle/ToolButtonStyle.qml

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: filipf
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  So many hardcoded numbers! Much better indeed.

INLINE COMMENTS

> kcolorscheme.cpp:88
>  
> -_effects[0] = 0;
> -_effects[1] = 0;
> -_effects[2] = 0;
> +for(auto &effect : _effects) effect = 0;
>  

coding style: space after `for`, and add `{` ... `}` around the body,  with 
newlines.

> kcolorscheme.cpp:393
>  {
> -switch (role) {
> -case KColorScheme::AlternateBackground:
> -return _brushes.bg[1];
> -case KColorScheme::ActiveBackground:
> -return _brushes.bg[2];
> -case KColorScheme::LinkBackground:
> -return _brushes.bg[3];
> -case KColorScheme::VisitedBackground:
> -return _brushes.bg[4];
> -case KColorScheme::NegativeBackground:
> -return _brushes.bg[5];
> -case KColorScheme::NeutralBackground:
> -return _brushes.bg[6];
> -case KColorScheme::PositiveBackground:
> -return _brushes.bg[7];
> -default:
> -return _brushes.bg[0];
> +if(role >= KColorScheme::NormalBackground && role < 
> KColorScheme::NBackgroundRoles) {
> +return _brushes.bg[role];

coding style: `if (` with a space

(repeats)

> kcolorscheme.cpp:598
>  
> -for (int i = 0; i < 3; i++) {
> -QPalette::ColorGroup state = states[i];
> +for (auto &state : states) {
>  KColorScheme schemeView(state, KColorScheme::View, config);

The `&` seems overkill (and confused me because it looks non-const).
This is just an enum, "copying" by value is faster than following the 
indirection of a reference.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25677

To: ndavis, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader

[David Faure]

dfaure updated this revision to Diff 70787.
dfaure added a comment.


  add missing "get"  (this bug was in kmimetypetrader.h already, blatant proof 
of copy/pasting... ;-) )

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25698?vs=70785&id=70787

BRANCH
  kapplicationtrader

REVISION DETAIL
  https://phabricator.kde.org/D25698

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kapplicationtradertest.cpp
  autotests/kservicetest.cpp
  autotests/kservicetest.h
  src/CMakeLists.txt
  src/services/kapplicationtrader.cpp
  src/services/kapplicationtrader.h
  src/services/kservicetypetrader.h
  src/sycoca/ksycocaentry.h

To: dfaure, broulik, mart, vkrause, nicolasfella
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 209 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/209/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 02 Dec 2019 21:34:24 +
 Build duration:
23 min and counting
   CONSOLE OUTPUT
  [...truncated 846 lines...][2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   * The installation package was faulty and references files it does not[2019-12-02T21:58:02.879Z]   provide.[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:58:02.879Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] "/usr/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   * The installation package was faulty and references files it does not[2019-12-02T21:58:02.879Z]   provide.[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:58:02.879Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] "/usr/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   * The installation package was faulty and references files it does not[2019-12-02T21:58:02.879Z]   provide.[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:58:02.879Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] "/usr/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   * The installation package was faulty and references files it does not[2019-12-02T21:58:02.879Z]   provide.[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:58:02.879Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] "/usr/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   * The installation package was faulty and references files it does not[2019-12-02T21:58:02.879Z]   provide.[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:58:02.879Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z] "/usr/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:58:02.879Z] [2019-12-02T21:58:02.879Z]   * The installation package was faulty and references fil

D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> kapplicationtrader.h:33
> + *
> + * Example: say that you want to the list of all applications that can 
> handle PNG images.
> + * The code would look like:

Typo: you want to _get_...

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D25698

To: dfaure, broulik, mart, vkrause, nicolasfella
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24828: KRun: don't override user preferred app when opening local *.*html and co. files

[Ahmad Samir]

ahmadsamir added a subscriber: ngraham.
ahmadsamir added a comment.


  @ngraham: I do know how to land a diff :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24828

To: ahmadsamir, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25697: Port away from KIconLoader::SizeSmallMedium

[Christoph Feck]

cfeck added a comment.


  Traditionally, 22 was used for toolbar icons. You could replace 22 with 
QStyle::PM_ToolBarIconSize, but it really depends on where you want the icons 
to appear. Generally, QStyle::PM_SmallIconSize is for icons that are placed 
next to a single line of text, unless there is a more specifc PixelMetric enum, 
e.g. QStyle::PM_ButtonIconSize.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25697

To: nicolasfella, #frameworks
Cc: cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25276: reStructuredText: Fix inline literals highlighting preceding characters

[Nibaldo González]

nibags added a comment.


  @dhaumann I take care to correct the version and commit this

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25276

To: adrianchavesfernandez, mosra
Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 185 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/185/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 02 Dec 2019 21:34:25 +
 Build duration:
3 min 30 sec and counting
   CONSOLE OUTPUT
  [...truncated 975 lines...][2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z]   * The installation package was faulty and references files it does not[2019-12-02T21:37:43.333Z]   provide.[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:37:43.333Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z] "C:/CI/Software Installs/kio/include/KF5/KXmlGui"[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z]   * The installation package was faulty and references files it does not[2019-12-02T21:37:43.333Z]   provide.[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:37:43.333Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z] "C:/CI/Software Installs/kio/include/KF5/KXmlGui"[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z]   * The installation package was faulty and references files it does not[2019-12-02T21:37:43.333Z]   provide.[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:37:43.333Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z] "C:/CI/Software Installs/kio/include/KF5/KXmlGui"[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z]   * The installation package was faulty and references files it does not[2019-12-02T21:37:43.333Z]   provide.[2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.333Z] [2019-12-02T21:37:43.594Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:37:43.594Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:37:43.594Z] [2019-12-02T21:37:43.594Z] "C:/CI/Software Installs/kio/include/KF5/KXmlGui"[2019-12-02T21:37:43.594Z] [2019-12-02T21:37:43.594Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:37:43.594Z] [2019-12-02T21:37:43.594Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:37:43.594Z] [2019-12-02T21:37:43.594Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:37:43.594Z] [2019-12-02T21:37:43.594Z]   * The installation package was faulty and references files it does not[2019-12-02T21:37:43.594Z]   provide.[2019-12-02T21:37:43.594Z] [2019-12-02T21:37:43.594Z] [2019-12-02T21:37:43.594Z] [2019-12-02T21:37:43.594Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:37:43.594Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:37:43.594Z] [2019-12-02T21:37:43.594Z] "C:/CI/Software Installs/kio/include/KF5/KXmlGui"[2019-12-02T21:37:43.594Z] [2019-12-02T21:37:43.594Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:37:43.594Z] [2019-12-02T21:37:43.594Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:37:43.594Z] [2019-12-02T21:37:43.594Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:37:43.594Z] [2019-12-02T21:37:43.594Z]   * The installation package was faulty and references files it does 

D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader

[David Faure]

dfaure created this revision.
dfaure added reviewers: broulik, mart, vkrause, nicolasfella.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  The old traders could lookup both applications and plugins, but plugins
  should nowadays be loaded via their JSON file, no desktop-file trader
  needed anymore.
  
  To get rid of plugins and servicetypes from the API, and keep
  only the application-lookup-related code, the older traders will be
  deprecated and their users should either switch to JSON for plugins 
(KPluginLoader)
  or KApplicationTrader for application desktop files.
  
  One API question remains:
   KApplicationTrader::self()->query("...") like the old traders, or
   KApplicationTrader::query("...") (static methods only, or making it a 
namespace, a bit procedural rather than OO), or
   KApplicationTrader().query("...") like QMimeDatabase/QFontDatabase (but with 
default ctors for performance) ?

TEST PLAN
  New unittest (partly based on kservicetest, but simplified and added new 
types of checks) passes

REPOSITORY
  R309 KService

BRANCH
  kapplicationtrader

REVISION DETAIL
  https://phabricator.kde.org/D25698

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kapplicationtradertest.cpp
  autotests/kservicetest.cpp
  autotests/kservicetest.h
  src/CMakeLists.txt
  src/services/kapplicationtrader.cpp
  src/services/kapplicationtrader.h
  src/services/kservicetypetrader.h
  src/sycoca/ksycocaentry.h

To: dfaure, broulik, mart, vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 341 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/341/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 02 Dec 2019 21:34:24 +
 Build duration:
2 min 11 sec and counting
   CONSOLE OUTPUT
  [...truncated 893 lines...][2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   * The installation package was faulty and references files it does not[2019-12-02T21:36:36.036Z]   provide.[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:36:36.036Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] "/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   * The installation package was faulty and references files it does not[2019-12-02T21:36:36.036Z]   provide.[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:36:36.036Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] "/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   * The installation package was faulty and references files it does not[2019-12-02T21:36:36.036Z]   provide.[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:36:36.036Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] "/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   * The installation package was faulty and references files it does not[2019-12-02T21:36:36.036Z]   provide.[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:36:36.036Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] "/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   * The installation package was faulty and references files it does not[2019-12-02T21:36:36.036Z]   provide.[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:36:36.036Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z] "/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:36:36.036Z] [2019-12-02T21:36:36.036Z]   * The installation package was faulty and references files it does not[2019-

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 224 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/224/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 02 Dec 2019 21:34:25 +
 Build duration:
2 min 6 sec and counting
   CONSOLE OUTPUT
  [...truncated 893 lines...][2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z]   * The installation package was faulty and references files it does not[2019-12-02T21:36:30.844Z]   provide.[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:36:30.844Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z] "/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z]   * The installation package was faulty and references files it does not[2019-12-02T21:36:30.844Z]   provide.[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:36:30.844Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z] "/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z]   * The installation package was faulty and references files it does not[2019-12-02T21:36:30.844Z]   provide.[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:36:30.844Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z] "/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z]   * The installation package was faulty and references files it does not[2019-12-02T21:36:30.844Z]   provide.[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:36:30.844Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z] "/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.844Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:36:30.844Z] [2019-12-02T21:36:30.845Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:36:30.845Z] [2019-12-02T21:36:30.845Z]   * The installation package was faulty and references files it does not[2019-12-02T21:36:30.845Z]   provide.[2019-12-02T21:36:30.845Z] [2019-12-02T21:36:30.845Z] [2019-12-02T21:36:30.845Z] [2019-12-02T21:36:30.845Z] CMake Error in autotests/CMakeLists.txt:[2019-12-02T21:36:30.845Z]   Imported target "KF5::XmlGui" includes non-existent path[2019-12-02T21:36:30.845Z] [2019-12-02T21:36:30.845Z] "/home/jenkins/install-prefix/include/KF5/KXmlGui"[2019-12-02T21:36:30.845Z] [2019-12-02T21:36:30.845Z]   in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:[2019-12-02T21:36:30.845Z] [2019-12-02T21:36:30.845Z]   * The path was deleted, renamed, or moved to another location.[2019-12-02T21:36:30.845Z] [2019-12-02T21:36:30.845Z]   * An install or uninstall procedure did not complete successfully.[2019-12-02T21:36:30.845Z] [2019-12-02T21:36:30.845Z]   * The installation package was faulty and references files it does not[2019-1

D24828: KRun: don't override user preferred app when opening local *.*html and co. files

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:afb2f80cbbe1: KRun: don't override user preferred 
app when opening local *.*html and co. files (authored by ahmadsamir, committed 
by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24828?vs=68429&id=70784

REVISION DETAIL
  https://phabricator.kde.org/D24828

AFFECTED FILES
  src/widgets/krun.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25697: Port away from KIconLoader::SizeSmallMedium

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  There is no direct equivalent of SizeSmallMedium (22) in QStyle. There is 
either Small (16) or large (32)

TEST PLAN
  builds

REPOSITORY
  R241 KIO

BRANCH
  sm2

REVISION DETAIL
  https://phabricator.kde.org/D25697

AFFECTED FILES
  src/widgets/ksslinfodialog.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25697: Port away from KIconLoader::SizeSmallMedium

[Nicolas Fella]

nicolasfella added a task: T11637: Investigate if KIconThemes is needed as a 
framework.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25697

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24982: Small improvements in some XML files

[Nibaldo González]

nibags updated this revision to Diff 70781.
nibags added a comment.


  - Resolve conflicts

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24982?vs=70779&id=70781

REVISION DETAIL
  https://phabricator.kde.org/D24982

AFFECTED FILES
  autotests/folding/highlight.y.fold
  data/syntax/apparmor.xml
  data/syntax/coffee.xml
  data/syntax/fortran-fixed.xml
  data/syntax/fortran-free.xml
  data/syntax/html.xml
  data/syntax/logcat.xml
  data/syntax/mustache.xml
  data/syntax/rust.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml
  data/syntax/selinux.xml
  data/syntax/xml.xml
  data/syntax/yacc.xml
  data/syntax/yaml.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24828: KRun: don't override user preferred app when opening local *.*html and co. files

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  ahmad/separate-browser-html (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24828

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25696: Remove dead code

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  This code was last touched before kdelibs was split, so it can be considered 
dead

REPOSITORY
  R241 KIO

BRANCH
  deadd

REVISION DETAIL
  https://phabricator.kde.org/D25696

AFFECTED FILES
  src/widgets/ksslinfodialog.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24982: Small improvements in some XML files

[Nibaldo González]

nibags updated this revision to Diff 70779.
nibags added a comment.


  - Resolve merge conflicts.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24982?vs=68824&id=70779

REVISION DETAIL
  https://phabricator.kde.org/D24982

AFFECTED FILES
  autotests/folding/highlight.y.fold
  data/syntax/apparmor.xml
  data/syntax/coffee.xml
  data/syntax/fortran-fixed.xml
  data/syntax/fortran-free.xml
  data/syntax/html.xml
  data/syntax/logcat.xml
  data/syntax/mustache.xml
  data/syntax/rust.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml
  data/syntax/selinux.xml
  data/syntax/xml.xml
  data/syntax/yacc.xml
  data/syntax/yaml.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24982: Small improvements in some XML files

[Nibaldo González]

nibags added a comment.


  Captures can also be used without dynamic rules, for example in the regular 
expression: `("+)[^"]*\1`
  In these cases, a `capture="true"` attribute can be used to enable captures, 
but in dynamic rules the detection will be automatic.
  
  I could do a benchmark the test units with the disabled captures to check the 
improvement in performance, and see if these changes are worth making.
  
  I don't know if you want to include this diff. If you prefer, I can update 
this diff, remove the inclusion of `?:` in regex and leave only the other 
improvements.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24982

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24828: KRun: don't override user preferred app when opening local *.*html and co. files

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  This makes perfect sense to me, thanks for the detailed analysis and the fix.
  
  Remember to update the version number in the FIXED-IN line (sorry for the 
delay in the review).

REPOSITORY
  R241 KIO

BRANCH
  ahmad/separate-browser-html (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24828

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25441: Send along the config name with requests

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  send-config-name-with-requests (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25441

To: leinir, #knewstuff, #frameworks, #plasma, starbuck, ronaldv, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Alexander Saoutkin]

feverfew updated this revision to Diff 70773.
feverfew added a comment.


  Check for password instead of authority

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23384?vs=70661&id=70773

BRANCH
  arcpatch-D23384

REVISION DETAIL
  https://phabricator.kde.org/D23384

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/desktopexecparser.cpp
  src/core/org.kde.KIOFuse.VFS.xml
  src/widgets/CMakeLists.txt
  src/widgets/krun.cpp
  src/widgets/org.kde.KIOFuse.VFS.xml

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, 
GB_2, michaelh, bruns

D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R252:dcadc14c952d: Conditionally set 
SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals… (authored by 
ngraham).

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25360?vs=69932&id=70769

REVISION DETAIL
  https://phabricator.kde.org/D25360

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: ngraham, #frameworks, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25686: Updates from CMake 3.16 final release

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks for the update!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25686

To: turbov, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Seems to fix the issue and I did not detect any regressions in keyboard 
navigation in open or save dialogs. May be a good idea to wait to commit this 
until after Frameworks 5.65 is tagged though so it has a month of testing in 
production before release rather than just a few days.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25420

To: meven, #frameworks, ngraham, elvisangelaccio
Cc: feverfew, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25686: Updates from CMake 3.16 final release

[Alex Turbov]

turbov added a reviewer: Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25686

To: turbov, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25686: Updates from CMake 3.16 final release

[Alex Turbov]

turbov created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
turbov requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25686

AFFECTED FILES
  data/generators/cmake.xml.tpl
  data/generators/cmake.yaml
  data/syntax/cmake.xml

To: turbov
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Noah Davis]

ndavis added a comment.


  In D25677#570896 , @ngraham wrote:
  
  > > This also replaces some for-loops with C++11 range based for-loops and 
switches for simpler if/else control blocks.
  >
  > Seems like these changes are unrelated and should maybe be in a separate 
commit?
  
  
  The intention of the patch is to reduce the number of hardcoded values, so 
they're related. It wouldn't make sense to switch the hardcoded for-loop ranges 
for the enum values introduced in the parent patch only to replace them with 
range based for-loops immediately afterward.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25677

To: ndavis, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Nathaniel Graham]

ngraham added a comment.


  All right.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25677

To: ndavis, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Nathaniel Graham]

ngraham added a comment.


  @feverfew thanks for rebasing 
https://invent.kde.org/kde/kio-fuse/merge_requests/2. I've tested it and 
confirmed that it fixes case #2! We can continue that portion of the view in 
the comments there.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, 
GB_2, michaelh, bruns

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

[Nathaniel Graham]

ngraham added a subscriber: feverfew.
ngraham added a comment.


  @feverfew thanks for rebasing 
https://invent.kde.org/kde/kio-fuse/merge_requests/2. I've tested it and 
confirmed that it fixes case #2! We can continue that portion of the view in 
the comments there.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25420

To: meven, #frameworks, ngraham, elvisangelaccio
Cc: feverfew, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Nathaniel Graham]

ngraham added a comment.


  > This also replaces some for-loops with C++11 range based for-loops and 
switches for simpler if/else control blocks.
  
  Seems like these changes are unrelated and should maybe be in a separate 
commit?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25677

To: ndavis, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

[Nathaniel Graham]

ngraham added reviewers: davidedmundson, hpereiradacosta.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks, dfaure, davidedmundson, hpereiradacosta
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25562: Add some friendly "report bugs here" links

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R304 KNewStuff

BRANCH
  helpful-linking-for-bugs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25562

To: leinir, #frameworks, #knewstuff, ngraham, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25328: Always rehiglhight() after definition was changed

[Méven Car]

meven added a comment.


  In D25328#564202 , @meven wrote:
  
  > In D25328#563637 , @cullmann 
wrote:
  >
  > > Hmm, the use case is that it re-highlights if you set an invalid 
definition?
  >
  >
  > Here it rehighlight if the definition has changed `definition() != def`.
  >  But since the current definition `m_definition` has initially the value 
`Definition()`, it is the same as the invalid default definition returned by 
`Repository::definitionForFileName` (set in `RepositoryPrivate::load` line 161) 
and does not call `rehighlight`.
  >
  > > Perhaps one should just trigger rehighlight here just for that case, too.
  >
  > So the fix does not really depend on the definition being valid or invalid.
  >
  > Perhaps there is a better way to fix this.
  
  
  Any thought from a SyntaxHighlighter maintainer ?
  I hope I have made the issue clear enough.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25328

To: meven, kossebau, cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

[Méven Car]

meven added a comment.


  ping anyone ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25420

To: meven, #frameworks, ngraham, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis added a reviewer: dfaure.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Noah Davis]

ndavis added a reviewer: dfaure.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25677

To: ndavis, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25682: [WIP] add initial wsdiscovery support

[Nathaniel Graham]

ngraham added a comment.


  OMG it works!!! I can find my windows Samba share in Dolphin again!

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25682

To: sitter
Cc: ngraham, caspermeijn, davidedmundson, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
andrebarros, bruns, emmanuelp, mikesomov

D25311: Add KColumnHeadersProxyModel

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> kcolumnheadersmodel.cpp:83
> +
> +if (newSourceModel) {
> +connect(newSourceModel, 
> &QAbstractItemModel::columnsAboutToBeInserted, this, [this](const 
> QModelIndex&, int first, int last) {

connect(modelAboutToBeReset
modelReset

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25311

To: ahiemstra
Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25683: KDirOperator: Use a fixed line height for scroll speed

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works great, thanks!

REPOSITORY
  R241 KIO

BRANCH
  diroperator_scrollspeed

REVISION DETAIL
  https://phabricator.kde.org/D25683

To: ahiemstra, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25685: [QImageItem/QPixmapItem] Don't lose precision during calculation

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Operate on `QRectF`/`QSizeF` and only round back to integer at the end.

TEST PLAN
  I've always been under the impression that the previews in icons kcm were 
misaligned or cut off slightly.
  Before
  F7796401: Screenshot_20191202_155753.png 

  After
  F7796402: Screenshot_20191202_155733.png 

  
  - Notification thumbnail strip (qpixmapitem) still works
  - QR code in klipper (qimageitem) still works

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25685

AFFECTED FILES
  src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp
  src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25311: Add KColumnHeadersProxyModel

[Volker Krause]

vkrause added a comment.


  In D25311#570700 , @ahiemstra 
wrote:
  
  > @vkrause Is the updated version more what you expected?
  
  
  Yep, thanks, this addresses my concerns. So +1 from me on this.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25311

To: ahiemstra
Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25433: KActionCollection: provide a changed() signal as a replacement for removed()

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25433

To: dfaure, kossebau, mart, davidedmundson, vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25682: [WIP] add initial wsdiscovery support

[Harald Sitter]

sitter added a subscriber: caspermeijn.
sitter added a comment.


  In D25682#570845 , @davidedmundson 
wrote:
  
  > Why do we need to mirror this dsoap-ws-discovery-client lib that seems to 
be copied from somewhere?
  
  
  Testing convenience until @caspermeijn makes a release mostly. The library 
was,or maybe even still is, in flux as API was being shuffled up to kdsoap.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25682

To: sitter
Cc: caspermeijn, davidedmundson, kde-frameworks-devel, kfm-devel, pberestov, 
iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D25682: [WIP] add initial wsdiscovery support

[David Edmundson]

davidedmundson added a comment.


  Why do we need to mirror this dsoap-ws-discovery-client lib that seems to be 
copied from somewhere?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25682

To: sitter
Cc: davidedmundson, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25682: [WIP] add initial wsdiscovery support

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25682

To: sitter
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Fabian Vogt]

fvogt added a comment.


  In D23384#570830 , @ngraham wrote:
  
  > In D23384#570735 , @fvogt wrote:
  >
  > > > Clicking a http link in my chat app now kiofuses it and then has the 
browser desperately try to open /run/user/1000/kio-fuse-bla/http/kde.org/ - it 
only gets the first character in the file, so I usually just see < for a HTML 
page
  > >
  > > Ignoring the elephant in the room which is that this diff forces 
everything through `mountUrl`, that's the expected behavior with a plain HTTP 
URL as the size isn't known until the file is downloaded. So `stat` reports a 
size of `1` until the file is actually opened.
  > >  This is unavoidable, otherwise every `ls` would trigger a download of 
all files. If handling this better is important, `HTTPProtocol::stat` could use 
a `HEAD` request to get the `Content-Length`, but that doesn't work in all 
cases either.
  >
  >
  > Well, we need to fix this or else it's a very serious regression that 
breaks a huge part of the desktop. Opening links in a web browser is pretty 
basic functionality.
  
  
  That issue is not in kio-fuse:
  
  > Ignoring the elephant in the room which is that this diff forces everything 
through `mountUrl`, ...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, 
GB_2, michaelh, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Nathaniel Graham]

ngraham added a comment.


  In D23384#570735 , @fvogt wrote:
  
  > > Clicking a http link in my chat app now kiofuses it and then has the 
browser desperately try to open /run/user/1000/kio-fuse-bla/http/kde.org/ - it 
only gets the first character in the file, so I usually just see < for a HTML 
page
  >
  > Ignoring the elephant in the room which is that this diff forces everything 
through `mountUrl`, that's the expected behavior with a plain HTTP URL as the 
size isn't known until the file is downloaded. So `stat` reports a size of `1` 
until the file is actually opened.
  >  This is unavoidable, otherwise every `ls` would trigger a download of all 
files. If handling this better is important, `HTTPProtocol::stat` could use a 
`HEAD` request to get the `Content-Length`, but that doesn't work in all cases 
either.
  
  
  Well, we need to fix this or else it's a very serious regression that breaks 
a huge part of the desktop. Opening links in a web browser is pretty basic 
functionality.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, 
GB_2, michaelh, bruns

D25683: KDirOperator: Use a fixed line height for scroll speed

[Arjen Hiemstra]

ahiemstra edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25683

To: ahiemstra
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns