D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

2019-12-16 Thread Cyril Rossi 
crossi added inline comments.

INLINE COMMENTS

> davidedmundson wrote in managedconfigmodule.cpp:43
> Any reason for doing this approach rather than connecting to QObject:: 
> destroyed and cleaning the list as we go?

Sort of a guard if one registers manually a KCoreConfigSkeleton and then 
deallocate it.
It is not intended to manage the deallocation as KCoreConfigSkeleton are 
normally registered in the QObject hierarchy.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-12-16 Thread Méven Car 
meven updated this revision to Diff 71703.
meven added a comment.


  Fix Two references to KF 5.65

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25010?vs=71702&id=71703

BRANCH
  arcpatch-D25010_1

REVISION DETAIL
  https://phabricator.kde.org/D25010

AFFECTED FILES
  autotests/jobremotetest.cpp
  src/core/copyjob.cpp
  src/core/deletejob.cpp
  src/core/directorysizejob.cpp
  src/core/global.h
  src/core/statjob.cpp
  src/core/statjob.h
  src/filewidgets/kdiroperator.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/krun.cpp
  src/widgets/paste.cpp
  tests/kioslavetest.cpp
  tests/listjobtest.cpp

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-12-16 Thread Méven Car 
meven updated this revision to Diff 71702.
meven added a comment.


  Fix Two references to KF 5,65

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25010?vs=71701&id=71702

BRANCH
  arcpatch-D25010_1

REVISION DETAIL
  https://phabricator.kde.org/D25010

AFFECTED FILES
  autotests/jobremotetest.cpp
  src/core/copyjob.cpp
  src/core/deletejob.cpp
  src/core/directorysizejob.cpp
  src/core/global.h
  src/core/statjob.cpp
  src/core/statjob.h
  src/filewidgets/kdiroperator.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/krun.cpp
  src/widgets/paste.cpp
  tests/kioslavetest.cpp
  tests/listjobtest.cpp

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-12-16 Thread Méven Car 
meven updated this revision to Diff 71701.
meven added a comment.


  Rebase for kio 5.66

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25010?vs=70669&id=71701

BRANCH
  arcpatch-D25010_1

REVISION DETAIL
  https://phabricator.kde.org/D25010

AFFECTED FILES
  autotests/jobremotetest.cpp
  src/core/copyjob.cpp
  src/core/deletejob.cpp
  src/core/directorysizejob.cpp
  src/core/global.h
  src/core/statjob.cpp
  src/core/statjob.h
  src/filewidgets/kdiroperator.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/krun.cpp
  src/widgets/paste.cpp
  tests/kioslavetest.cpp
  tests/listjobtest.cpp

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26062: Port to QRandomGenerator

2019-12-16 Thread Laurent Montel 
mlaurent added a reviewer: dfaure.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26062

To: mlaurent, dfaure
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26062: Port to QRandomGenerator

2019-12-16 Thread Laurent Montel 
mlaurent created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  qrand is deprecated in qt5.15

REPOSITORY
  R293 Baloo

BRANCH
  remove_qrand (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26062

AFFECTED FILES
  autotests/unit/lib/filemonitortest.cpp

To: mlaurent
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26061: QHash::insertMulti is deprecated

2019-12-16 Thread Laurent Montel 
mlaurent added a reviewer: dfaure.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D26061

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26061: QHash::insertMulti is deprecated

2019-12-16 Thread Laurent Montel 
mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  QHash::insertMulti is deprecated in qt5.15

TEST PLAN
  autotest ok

REPOSITORY
  R304 KNewStuff

BRANCH
  use_qmultihash_direcly (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26061

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26060: Port to QRandomGenerator (qrand was deprecated in qt5.15)

2019-12-16 Thread Laurent Montel 
mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without qrandr

TEST PLAN
  autotest ok

REPOSITORY
  R243 KArchive

BRANCH
  port_qrandomgenerator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26060

AFFECTED FILES
  autotests/kfiltertest.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26060: Port to QRandomGenerator (qrand was deprecated in qt5.15)

2019-12-16 Thread Laurent Montel 
mlaurent added a reviewer: dfaure.
mlaurent removed R243 KArchive as the repository for this revision.

REVISION DETAIL
  https://phabricator.kde.org/D26060

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25716: [KPropertiesDialog] Show extra fields

2019-12-16 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25716

To: broulik, #frameworks, #vdg, dfaure, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25716: [KPropertiesDialog] Show extra fields

2019-12-16 Thread Kai Uwe Broulik 
broulik added a comment.


  Ping

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25716

To: broulik, #frameworks, #vdg, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26055: Enable wheel events on Slider {}

2019-12-16 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26055

To: apol, #plasma, broulik, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26055: Enable wheel events on Slider {}

2019-12-16 Thread David Edmundson 
davidedmundson added a comment.


  > Used it with a test.
  
  What test?
  I just noticed it's missing from p-f/tests/components

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26055

To: apol, #plasma, broulik
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26057: Deprecate the top-level IconSize() function

2019-12-16 Thread Volker Krause 
vkrause added a task: T11637: Investigate if KIconThemes is needed as a 
framework.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D26057

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26057: Deprecate the top-level IconSize() function

2019-12-16 Thread Volker Krause 
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This removes the last of the non-namespaced top-level functions here
  as well.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26057

AFFECTED FILES
  src/CMakeLists.txt
  src/kiconloader.cpp
  src/kiconloader.h

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25530: Sonnet: Add locales that are missing in QLocale

2019-12-16 Thread Waqar Ahmed 
waqar abandoned this revision.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25530

To: waqar
Cc: cullmann, aspotashev, aacid, yurchor, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

2019-12-16 Thread Waqar Ahmed 
waqar added a comment.


  ping

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25495

To: waqar, mludwig
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

2019-12-16 Thread Méven Car 
meven resigned from this revision.
meven added a comment.
This revision now requires review to proceed.


  Leave the first reviewer position to someone else.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26047: Expose KConfig settings to allow registration in KCM Notification

2019-12-16 Thread Méven Car 
meven resigned from this revision.
meven added a comment.
This revision now requires review to proceed.


  Someone else should valide this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26047

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26055: Enable wheel events on Slider {}

2019-12-16 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added reviewers: Plasma, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  So far PC3 version of the slider doesn't react to events, this change
  enables it.

TEST PLAN
  Used it with a test.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26055

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Slider.qml

To: apol, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

2019-12-16 Thread David Edmundson 
davidedmundson added a comment.


  Generally +1

INLINE COMMENTS

> managedconfigmodule.cpp:43
>  ManagedConfigModule *_q;
> -QList _skeletons;
> +QList> _skeletons;
>  };

Any reason for doing this approach rather than connecting to QObject:: 
destroyed and cleaning the list as we go?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart, meven
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26054: partial fix for accentuated characters in file name on Windows

2019-12-16 Thread Matthieu Gallien 
mgallien updated this revision to Diff 71684.
mgallien added a comment.


  sorry for the mess in the previous patch

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26054?vs=71683&id=71684

BRANCH
  fixWriterAccentuatedFileName

REVISION DETAIL
  https://phabricator.kde.org/D26054

AFFECTED FILES
  src/writers/taglibwriter.cpp

To: mgallien, bruns, astippich
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26044: Set breeze as default theme when reading from configuration file

2019-12-16 Thread Aleix Pol Gonzalez 
apol added a comment.


  LGTM otherwise

INLINE COMMENTS

> kiconloader.cpp:564
>  const QString newThemeName = sharedConfig->group("Icons")
> -   .readEntry("Theme", 
> QString());
> +   .readEntry("Theme", 
> QString("breeze"));
>  if (!newThemeName.isEmpty()) {

QStringLiteral

> kicontheme.cpp:607
>  KConfigGroup cg(KSharedConfig::openConfig(), "Icons");
> -theme = cg.readEntry("Theme", QString());
> +theme = cg.readEntry("Theme", QString("breeze"));
>  }

QStringLiteral

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D26044

To: bport, #plasma, ervin, crossi
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26054: partial fix for accentuated characters in file name on Windows

2019-12-16 Thread Matthieu Gallien 
mgallien created this revision.
mgallien added reviewers: bruns, astippich.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
mgallien requested review of this revision.

REVISION SUMMARY
  partial fix to try to get accentuated file names to work with TagLibWriter

TEST PLAN
  no tests

REPOSITORY
  R286 KFileMetaData

BRANCH
  fixWriterAccentuatedFileName

REVISION DETAIL
  https://phabricator.kde.org/D26054

AFFECTED FILES
  CMakeLists.txt
  src/writers/taglibwriter.cpp

To: mgallien, bruns, astippich
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26047: Expose KConfig settings to allow registration in KCM Notification

2019-12-16 Thread Méven Car 
meven accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26047

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart, meven
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

2019-12-16 Thread Méven Car 
meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Code looks sane to me.
  One nitpick

INLINE COMMENTS

> managedconfigmodule.h:205
> + * After manual registration on the fly,
> + * it may be needed to call settingsChanged()
> + */

Mention importance of emitting configChanged signal to automatically call 
settingsChanged as alternative to calling settingsChanged.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart, meven
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25865: kfilemetadata EBN transport protocol cleanup

2019-12-16 Thread John Hayes 
jhayes added a comment.


  You're right, can we just close this?
  
  John

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25865

To: jhayes
Cc: vkrause, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26047: Expose KConfig settings to allow registration in KCM Notification

2019-12-16 Thread Cyril Rossi 
crossi created this revision.
crossi added reviewers: Plasma, Frameworks, ervin, bport, davidedmundson, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  For KCM Notification, allow to register the generated settings to the 
ManagedConfigModule machinery

TEST PLAN
  refactor, no change

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26047

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/badgesettings.kcfgc
  libnotificationmanager/kcfg/donotdisturbsettings.kcfgc
  libnotificationmanager/kcfg/jobsettings.kcfgc
  libnotificationmanager/kcfg/notificationsettings.kcfgc
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26043: Add edit mode menu item to desktop widget context menu

2019-12-16 Thread Björn Feber 
GB_2 updated this revision to Diff 71675.
GB_2 added a comment.


  Remove space

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26043?vs=71674&id=71675

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26043

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg, mart
Cc: mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26043: Add edit mode menu item to desktop widget context menu

2019-12-16 Thread Björn Feber 
GB_2 updated this revision to Diff 71674.
GB_2 added a comment.


  Decrease line count

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26043?vs=71670&id=71674

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26043

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg, mart
Cc: mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

2019-12-16 Thread Cyril Rossi 
crossi created this revision.
crossi added reviewers: Plasma, Frameworks, ervin, bport, davidedmundson, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Helpful for derived class that do not store KConfig settings as children 
items.

TEST PLAN
  Should not break binary compatibility. Same behaviour as before.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

AFFECTED FILES
  src/quickaddons/managedconfigmodule.cpp
  src/quickaddons/managedconfigmodule.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26043: Add edit mode menu item to desktop widget context menu

2019-12-16 Thread Björn Feber 
GB_2 added a reviewer: mart.
GB_2 added a subscriber: mart.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26043

To: GB_2, #plasma, #vdg, mart
Cc: mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26044: Set breeze as default theme when reading from configuration file

2019-12-16 Thread Benjamin Port 
bport added a dependent revision: D24846: Port kcm icons to kconfigxt.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D26044

To: bport, #plasma, ervin, crossi
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26044: Set breeze as default theme when reading from configuration file

2019-12-16 Thread Benjamin Port 
bport created this revision.
bport added reviewers: Plasma, ervin, crossi.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bport requested review of this revision.

REVISION SUMMARY
  Icons KCM is moved to KConfigXT, default value is "breeze" and in that case 
kdeglobals entry will be removed

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D26044

AFFECTED FILES
  src/kiconloader.cpp
  src/kicontheme.cpp

To: bport, #plasma, ervin, crossi
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26043: Add edit mode menu item to desktop widget context menu

2019-12-16 Thread Björn Feber 
GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  - much improves discoverability of the ability to move added widgets without 
clicking and holding (I have seen people having trouble figuring it out)
- makes it more consistent with panel widget context menus
- allows easier access to the edit mode when the desktop is full of widgets

TEST PLAN
  Open the context menu of a widget on the desktop.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26043

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26043: Add edit mode menu item to desktop widget context menu

2019-12-16 Thread Björn Feber 
GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26043

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO

2019-12-16 Thread Alexander Saoutkin 
feverfew updated this revision to Diff 71666.
feverfew added a comment.


  fix indentation

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23384?vs=71543&id=71666

BRANCH
  arcpatch-D23384_1

REVISION DETAIL
  https://phabricator.kde.org/D23384

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/desktopexecparser.cpp
  src/core/org.kde.KIOFuse.VFS.xml

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: alexde, broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, 
LeGast00n, GB_2, michaelh, bruns

D26013: [KeySequenceHelper] Grab actual window when embedded

2019-12-16 Thread David Redondo 
davidre accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26013

To: broulik, #plasma, davidre
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 45 - Still Unstable!

2019-12-16 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/45/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Dec 2019 12:53:26 +
 Build duration:
1 min 4 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 46 - Still Unstable!

2019-12-16 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/46/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Dec 2019 12:51:13 +
 Build duration:
1 min 34 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D23551: CMake config files: use as dep version the Qt one built against (private API)

2019-12-16 Thread Friedrich W. H. Kossebau 
kossebau abandoned this revision.
kossebau added a comment.


  Discarding with same reason as given here: D23550#578745 
 One day someone else will do this 
in a similar way, I am sure ;)

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23551

To: kossebau, #frameworks, aacid, #build_system
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23550: CMake config files: use as min dep version the Qt version we built against

2019-12-16 Thread Friedrich W. H. Kossebau 
kossebau abandoned this revision.
kossebau added a comment.


  Oh well, seems no-one else sees the light yet ;) Given this IMHO wrong data 
in the current CMake config files does not do actual harm in 99.9 % cases I 
will discard this for now, and just do it correctly (for what I see) only in my 
projects :)
  Just have to wait for more people running in the non-99.9 % cases perhaps ;)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23550

To: kossebau, #frameworks, #build_system
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 48 - Still Unstable!

2019-12-16 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/48/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 16 Dec 2019 09:04:30 +
 Build duration:
3 min 18 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 83 - Still Unstable!

2019-12-16 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/83/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 16 Dec 2019 09:04:30 +
 Build duration:
3 min 20 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report