D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> dfaure wrote in slavebase.h:262
> Does this break API docs generation? Suddenly the /** ... */ comment is 
> separated from the enum.

The comment didn't affect the doc generation. But the placement was awkward so 
I changed it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 71754.
chinmoyr added a comment.


  updated kf5 version.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21783?vs=71041=71754

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D12172: Android: Also install plugins, otherwise they are just not available

[Aleix Pol Gonzalez]

apol abandoned this revision.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D12172

To: apol, #build_system, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, vkrause, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25865: kfilemetadata EBN transport protocol cleanup

[John Hayes]

jhayes updated this revision to Diff 71751.
jhayes added a comment.


  - Reversed URI changes

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25865?vs=71236=71751

BRANCH
  ebn-transport-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25865

AFFECTED FILES
  src/extractors/dublincoreextractor.cpp

To: jhayes
Cc: vkrause, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26055: Enable wheel events on Slider {}

[Aleix Pol Gonzalez]

apol updated this revision to Diff 71744.
apol added a comment.


  Just never draw over 20 ticks

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26055?vs=71742=71744

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26055

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Slider.qml
  tests/components/slider3.qml

To: apol, #plasma, broulik, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26073: Port from KDE::icon to KIconUtils for getting icon overlays

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26073

To: vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26055: Enable wheel events on Slider {}

[Aleix Pol Gonzalez]

apol updated this revision to Diff 71742.
apol added a comment.


  don't show too many ticks

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26055?vs=71741=71742

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26055

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Slider.qml
  tests/components/slider3.qml

To: apol, #plasma, broulik, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26055: Enable wheel events on Slider {}

[Aleix Pol Gonzalez]

apol updated this revision to Diff 71741.
apol added a comment.


  Include test

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26055?vs=71685=71741

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26055

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Slider.qml
  tests/components/slider3.qml

To: apol, #plasma, broulik, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26073: Port from KDE::icon to KIconUtils for getting icon overlays

[Volker Krause]

vkrause added a task: T11654: Deprecate 
SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of 
KIconLoader or QIcon API.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D26073

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26073: Port from KDE::icon to KIconUtils for getting icon overlays

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This also removes the last uses of KIconThemes from here.

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26073

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kcmultidialog.cpp
  src/kpluginselector.cpp
  src/ksettings/componentsdialog.cpp

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26057: Deprecate the top-level IconSize() function

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R302:3e668c7fba9f: Deprecate the top-level IconSize() function 
(authored by vkrause).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26057?vs=71689=71737

REVISION DETAIL
  https://phabricator.kde.org/D26057

AFFECTED FILES
  src/CMakeLists.txt
  src/kiconloader.cpp
  src/kiconloader.h

To: vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26071: Avoid unwanted horizontal scrolling

[Kåre Särs]

sars created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
sars requested review of this revision.

REVISION SUMMARY
  It looks like the horizontal scrolling is a bit too sensitive while
  also scrolling vertically. This patch disables horizontal scrolling
  if the vertical wheel event value is larger than the horizontal.
  
  BUG: 415096

REPOSITORY
  R39 KTextEditor

BRANCH
  avoid-unwanted-horizontal-scrolling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26071

AFFECTED FILES
  src/view/kateviewinternal.cpp

To: sars
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D26043: Add edit mode menu item to desktop widget context menu

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> broulik wrote in containmentinterface.cpp:1128
> Please check `m_containment->immutability()` so we don't add this if widgets 
> are locked

Are you sure? It is already automatically disabled when immutability is 
`UserImmutable` and completely hidden if `SystemImmutable`, as it should be 
(same as for the desktop).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26043

To: GB_2, #plasma, #vdg, mart
Cc: broulik, mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, VDG, Dolphin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This includes:
  
  - Rendering hidden items desaturated when in "show all" mode
  - A getter for "show all"
  - Signals for place activation/clicking
  - Signals for middle clicking a place (for e.g. open in a new tab)
  - Possibility to add custom actions to the context menu
  - Possibility to provide own storage teardown procedure
  - Changing view icon size is forwarded to delegates
  
  The delegates are also made somewhat more compact to match Dolphin and 
spacing inbetween sections increased.

TEST PLAN
  Try with branch `broulik/kfileplacesview` in Dolphin.
  
  - Can I remove a `Q_PRIVATE_SLOT`?
  
  - Currently when enabling "show all" and clicking a place, "show all" is 
deactivated again. Dolphin keeps this permanently. Should we change this?
  
  Dolphin (from left to right: current custom view, `KFilePlacesView` current 
look, `KFilePlacesView` more compact new look to match Dolphin)
  F7822829: Screenshot_20191217_162724.png 

  Open dialog (from left to right: current look, more compact look, imho looks 
a bit crowded in conjunction with the file dialog :/0
  F7822826: Screenshot_20191217_162838.png 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26067

AFFECTED FILES
  src/filewidgets/kfileplacesview.cpp
  src/filewidgets/kfileplacesview.h
  src/filewidgets/kfileplacesview_p.h

To: broulik, #frameworks, #vdg, #dolphin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24522: Add presentwindows icon (old "task view" from windows)

[Björn Feber]

GB_2 added a comment.


  In D24522#544338 , @Zren wrote:
  
  > > `preferences-system-windows-effect-presentwindows`
  >
  > That would look like the `homerun` icon, which looks like the "windows" 
logo.
  >
  > F7557693: 2019-10-09___13-01-07.png 
  >
  > When you clicked on "Task View" in Windows, the 2 "obscured" windows would 
animate left/right a little to demonstrate that all windows are now visible. 
There isn't really a good way to know when the KWin Effect is active like that 
though to do a similar animation.
  >
  > Nowadays, Windows has a different icon for their "task history" view.
  
  
  What about this, but with 3 or 2 windows?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24522

To: Zren, #vdg, #breeze
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D26066: [KProcessInfo] Add parent PID

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We basically get this information for free anyway.

TEST PLAN
  - Can now query parent pid in plasma task manager without pulling in ksysguard
  - /proc and ps work, FreeBsd (procstat), and windows untested

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26066

AFFECTED FILES
  autotests/kprocesslisttest.cpp
  src/lib/util/kprocesslist.cpp
  src/lib/util/kprocesslist.h
  src/lib/util/kprocesslist_p.h
  src/lib/util/kprocesslist_unix.cpp
  src/lib/util/kprocesslist_unix_procstat_p.h
  src/lib/util/kprocesslist_win.cpp

To: broulik, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23352: make button icons follow a reasonable size and layout

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23352

To: camiloh, #plasma, mart, ngraham
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D26061: QHash::insertMulti is deprecated

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:ab43b736f326: QHash::insertMulti is deprecated (authored 
by mlaurent).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26061?vs=71698=71712

REVISION DETAIL
  https://phabricator.kde.org/D26061

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> meven wrote in managedconfigmodule.h:205
> Mention importance of emitting configChanged signal to automatically call 
> settingsChanged as alternative to calling settingsChanged.

It is not an alternative, configChanged is a KCoreConfigSkeleton's signal that 
will trigger a settingsChanged.
The proper way to use it, is register several settings (KCoreConfigSkeleton), 
then call settingsChanged that will perform a check on all registered settings.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26061: QHash::insertMulti is deprecated

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  use_qmultihash_direcly (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26061

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26057: Deprecate the top-level IconSize() function

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26057

To: vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26043: Add edit mode menu item to desktop widget context menu

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> containmentinterface.cpp:1128
> +desktopMenu->addSeparator();
> +if (m_containment->containmentType() == 
> Plasma::Types::DesktopContainment) {
> +
> desktopMenu->addAction(m_containment->corona()->actions()->action(QStringLiteral("edit
>  mode")));

Please check `m_containment->immutability()` so we don't add this if widgets 
are locked

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26043

To: GB_2, #plasma, #vdg, mart
Cc: broulik, mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D26047: Expose KConfig settings to allow registration in KCM Notification

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> settings.h:343
>  
> +QList configSkeletons() const;
> +

Not a fan of this becoming public API

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26047

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart