D26484: Add a new parameter for delaying showing menu

[Tranter Madi]

trmdi marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26484: Add a new parameter for delaying showing menu

[Tranter Madi]

trmdi updated this revision to Diff 73030.
trmdi added a comment.


  - Add a new function instead of changing the old exported one

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26484?vs=72975=73030

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26484

AFFECTED FILES
  src/widgets/dropjob.cpp
  src/widgets/dropjob.h

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26484: Add a new parameter for delaying showing menu

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> dropjob.h:129
>   */
> -KIOWIDGETS_EXPORT DropJob *drop(const QDropEvent *dropEvent, const QUrl 
> , JobFlags flags = DefaultFlags);
> +KIOWIDGETS_EXPORT DropJob *drop(const QDropEvent *dropEvent, const QUrl 
> , JobFlags flags = DefaultFlags, bool delayPopup = false);
>  

Do not change signature of exported function, just add another one.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

[Laurent Montel]

mlaurent added a comment.


  No change needed ? I will commit in two days if no complains.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D26320

To: mlaurent, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26484: Add a new parameter for delaying showing menu

[Tranter Madi]

trmdi added a dependent revision: D26514: Delay popup for containments.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26513: Port KNotification from KWindowSystem

[Nicolas Fella]

nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26513

To: davidedmundson, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26513: Port KNotification from KWindowSystem

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  KWindowSystem::activateWindow does the same system call as
  QWindow::requestActivate for X11 and Windows and both currently do
  nothing on wayland.
  
  May as well use Qt implementation

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26513

AFFECTED FILES
  src/knotification.cpp

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26512: Drop unused headers

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  KWindowSystem as a framework is still used or KKeyServer, so it can't be
  completely removed.

TEST PLAN
  Compiles

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26512

AFFECTED FILES
  src/kmainwindow.cpp
  src/kxmlguiwindow.cpp

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 66 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/66/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 07 Jan 2020 22:14:23 +
 Build duration:
3 min 11 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26492

To: broulik, #frameworks, ngraham
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26502: [ConfigModule] Say which package is invalid

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:00405aacf3f6: [ConfigModule] Say which package is invalid 
(authored by broulik).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26502?vs=73009=73019

REVISION DETAIL
  https://phabricator.kde.org/D26502

AFFECTED FILES
  src/quickaddons/configmodule.cpp

To: broulik, #plasma, mart, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> dfaure wrote in krecentfilesmenu.cpp:85
> Why not std::vector?
> 
> std::list is a linked list, so this smells like pointers to nodes containing 
> pointers, lots of indirection.

New entries are pushed to the front, which works in constant time for std::list 
and linear time for std::vector
When the maximum is reached the last element is removed which works in constant 
time for both.

We could turn it around and add new items to the back and iterate reverse, but 
then removing the front item would take linear time for std::vector

Given that n is small (<10 by default) it shouldn't matter much anyway

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D26448

To: nicolasfella, #frameworks, dfaure
Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

[Vlad Zahorodnii]

zzag retitled this revision from "[WIP] [Dialog Shadows] Port to KWindowSystem 
shadows API" to "[Dialog Shadows] Port to KWindowSystem shadows API".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26503

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26491: [Plasma Quick] Add WaylandIntegration class

[Vlad Zahorodnii]

zzag added a dependent revision: D26503: [WIP] [Dialog Shadows] Port to 
KWindowSystem shadows API.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26491

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26503: [WIP] [Dialog Shadows] Port to KWindowSystem shadows API

[Vlad Zahorodnii]

zzag added a dependency: D26491: [Plasma Quick] Add WaylandIntegration class.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26503

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26502: [ConfigModule] Say which package is invalid

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26502

To: broulik, #plasma, mart, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26503: [WIP] [Dialog Shadows] Port to KWindowSystem shadows API

[Vlad Zahorodnii]

zzag added a task: T12496: Shadows API in KWindowSystem.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26503

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26503: [WIP] [Dialog Shadows] Port to KWindowSystem shadows API

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

TEST PLAN
  Run `qmlscene tests/dialog.qml`

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26503

AFFECTED FILES
  src/plasmaquick/dialogshadows.cpp
  src/plasmaquick/waylandintegration.cpp
  src/plasmaquick/waylandintegration_p.h

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26502: [ConfigModule] Say which package is invalid

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Makes it easier to spot mismatches between install path and about data.

TEST PLAN
  F7868200: Screenshot_20200107_194236.png 


REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26502

AFFECTED FILES
  src/quickaddons/configmodule.cpp

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26488: smb ioslave: fix build regression

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:b2ad75170084: smb ioslave: fix build regression (authored 
by meven).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26488?vs=72960=73005

REVISION DETAIL
  https://phabricator.kde.org/D26488

AFFECTED FILES
  smb/kio_smb.cpp
  smb/kio_smb.h
  smb/kio_smb_auth.cpp
  smb/kio_smb_browse.cpp
  smb/kio_smb_dir.cpp
  smb/kio_smb_file.cpp
  smb/kio_smb_internal.cpp
  smb/kio_smb_mount.cpp
  smb/kio_smb_win.cpp

To: meven, #frameworks, mlaurent, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D26488: smb ioslave: fix build regression

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26488

To: meven, #frameworks, mlaurent, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D26501: KMainWindow: fix autoSaveSettings to catch QDockWidgets being shown again

[Friedrich W. H. Kossebau]

kossebau added a comment.


  KMainWindowPrivate::CompressCalls being used here still exposes a small 
issue, as this opens a small time window where the state is not catched before 
a xmlgui client change happens, so some finalizeGUI might (in theory) still use 
old state data, as autoSaveSettings is not yet triggered on e.g. xmlgui client 
removal.
  Something to look into next. But this here should improve things already a 
lot.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D26501

To: kossebau, #frameworks, #kdevelop, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26501: KMainWindow: fix autoSaveSettings to catch QDockWidgets being shown again

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, KDevelop, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  If QDockWidgets are "shown" in QWidget sense a second time, no resize or
  move events might happen as the widget has already been layouted before
  and might simply reappear at same position with same size.
  The old logic did not catch this, so would keep an outdated state stored
  in the auto-save settings of the window, which then would result in wrong
  state being enforced on restoring.

TEST PLAN
  Open KDevelop, open a toolview which was not open before (e.g. "Search in
  all Files"), switch to another toolview not open before, then switch back
  to the first toolview. Now either switch the currently viewed document
  (e.g. open another file) or quit & reopen KDevelop.
  Before the first toolview would hide itself despite officially being still
  visible, with this patch the state is properly hold (when internally being
  restored, like during finalizeGUI on KXmlGui client change).

REPOSITORY
  R263 KXmlGui

BRANCH
  catchdockwidgetsshowninstate

REVISION DETAIL
  https://phabricator.kde.org/D26501

AFFECTED FILES
  src/kmainwindow.cpp

To: kossebau, #frameworks, #kdevelop, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24629: RFC: Introduce KClockSkewNotifier class

[Vlad Zahorodnii]

zzag added a comment.


  The KWin patch has landed. Can we proceed now?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24629

To: zzag, #frameworks
Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

[Ahmad Samir]

ahmadsamir added a comment.


  Hello.
  Bug 415951 doesn't look related to this diff.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26492

To: broulik, #frameworks, ngraham
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26495: Fix API doc, usrSave is called from save not deprecated writeConfig

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:e88f9309e5db: Fix API doc, usrSave is called from save 
not deprecated writeConfig (authored by bport).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26495?vs=72978=72998

REVISION DETAIL
  https://phabricator.kde.org/D26495

AFFECTED FILES
  src/core/kcoreconfigskeleton.h

To: bport, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24629: RFC: Introduce KClockSkewNotifier class

[Vlad Zahorodnii]

zzag updated this revision to Diff 72993.
zzag added a comment.


  Rename signal.

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24629?vs=67889=72993

BRANCH
  kclockskewnotifier

REVISION DETAIL
  https://phabricator.kde.org/D24629

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/clock/kclockskewnotifier.cpp
  src/lib/clock/kclockskewnotifier.h
  src/lib/clock/kclockskewnotifierengine.cpp
  src/lib/clock/kclockskewnotifierengine_linux.cpp
  src/lib/clock/kclockskewnotifierengine_linux_p.h
  src/lib/clock/kclockskewnotifierengine_p.h

To: zzag, #frameworks
Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26484: Add a new parameter for delaying showing menu

[Tranter Madi]

trmdi edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26496: Log categories: fix format adding DEFAULT_SEVERITY

[Méven Car]

meven abandoned this revision.
meven added a comment.


  Thanks @mlaurent I just have old files installed on my system and got 
confused, I thought DEFAULT_SEVERITY was mandatory.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26496

To: meven, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26496: Log categories: fix format adding DEFAULT_SEVERITY

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.


  But you're wrong "log_kdebugsettings: In this file:  
"/home/meven/kde/usr/etc/xdg/kio.categories"  this line  "kf5.kio.cookiejar 
kcookiejar (KIO)"  still use old format. We need to port it" it not for missing 
DEFAULT_SEVERITY argument it's just that kio.categories doesnt use new format.
  but it seems that it's an old version as here I don't see this warning for 
kio.categories.
  
  And you add DEFAULT_SEVERITY [WARNING] but ecm_qt_declare_logging_category 
doesn"t use WARNING as default argument for example:
  "ecm_qt_declare_logging_category(kio_trash_PART_DEBUG_SRCS HEADER 
kiotrashdebug.h IDENTIFIER KIO_TRASH CATEGORY_NAME kf5.kio.trash)"
  so this patch is not correct for sure.

INLINE COMMENTS

> kio.categories:17
> +kf5.kio.widgets KIOWidgets (KIO) DEFAULT_SEVERITY [WARNING] IDENTIFIER 
> [KIO_WIDGETS]
> +org.kde.kio.kpasswdserver KPasswdServer (KIO) IDEFAULT_SEVERITY [WARNING] 
> DENTIFIER [category]
>  org.kde.kurifilter-localdomain KUriFilter Local Domain (KIO)  
> DEFAULT_SEVERITY [WARNING] IDENTIFIER [category]

It's not correct when you paste DEFAULT_SEVERITY [WARNING] => you add "I" from 
identifier

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26496

To: meven, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26496: Log categories: fix format adding DEFAULT_SEVERITY

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, mlaurent.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Prevents warning when launching kdebugsettings such as:
  
log_kdebugsettings: In this file:  
"/home/meven/kde/usr/etc/xdg/kio.categories"  this line  "kf5.kio.cookiejar 
kcookiejar (KIO)"  still use old format. We need to port it

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26496

AFFECTED FILES
  kio.categories

To: meven, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Add a new parameter for delaying showing menu

[Tranter Madi]

trmdi edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26495: Fix API doc, usrSave is called from save not deprecated writeConfig

[Kevin Ottens]

ervin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26495

To: bport, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26488: smb ioslave: fix build regression

[Méven Car]

meven added a reviewer: mlaurent.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26488

To: meven, #frameworks, mlaurent
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D26495: Fix API doc, usrSave is called from save not deprecated writeConfig

[Benjamin Port]

bport created this revision.
bport added a reviewer: ervin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bport requested review of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26495

AFFECTED FILES
  src/core/kcoreconfigskeleton.h

To: bport, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26492

To: broulik, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25583: Quit baloo_file_extractor if DB transaction fails

[David Edmundson]

davidedmundson added a comment.


  Bump.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D25583

To: davidedmundson, bruns, ngraham
Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26484: Add a new parameter for delaying showing menu

[Tranter Madi]

trmdi retitled this revision from "Delay 100ms before showing the menu" to "Add 
a new parameter for delaying showing menu".
trmdi edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Delay 100ms before showing the menu

[Tranter Madi]

trmdi updated this revision to Diff 72975.
trmdi added a comment.


  - Use signal instead of timer

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26484?vs=72945=72975

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26484

AFFECTED FILES
  src/widgets/dropjob.cpp
  src/widgets/dropjob.h

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

[Kai Uwe Broulik]

broulik updated this revision to Diff 72972.
broulik added a comment.


  - Turns out no close on exit doesnt imply the other, old code was correcter 
L:)

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26492?vs=72971=72972

REVISION DETAIL
  https://phabricator.kde.org/D26492

AFFECTED FILES
  src/widgets/kopenwithdialog.cpp

To: broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

[Kai Uwe Broulik]

broulik updated this revision to Diff 72971.
broulik added a comment.


  - Simplify

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26492?vs=72970=72971

REVISION DETAIL
  https://phabricator.kde.org/D26492

AFFECTED FILES
  src/widgets/kopenwithdialog.cpp

To: broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  BUG: 415951

TEST PLAN
  - Normal case still has box
  - Ran with `hideRunInTerminal` and box was gone

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26492

AFFECTED FILES
  src/widgets/kopenwithdialog.cpp

To: broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 260 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/260/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 07 Jan 2020 12:37:09 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26491: [Plasma Quick] Add WaylandIntegration class

[Vlad Zahorodnii]

zzag updated this revision to Diff 72969.
zzag added a comment.


  Rename a function.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26491?vs=72968=72969

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26491

AFFECTED FILES
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/plasmaquick/dialogshadows_p.h
  src/plasmaquick/waylandintegration.cpp
  src/plasmaquick/waylandintegration_p.h

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 268 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/268/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 07 Jan 2020 12:37:09 +
 Build duration:
8 min 11 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.66.0.xmllogs/KF5KIO/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34764/62008)40%
(17676/43770)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9685/10144)47%
(4516/9576)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8695/14613)51%
(4530/8855)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4680/8323)43%
(2067/4802)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(687/1260)40%
(396/978)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(524/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
  

D26491: [Plasma Quick] Add WaylandIntegration class

[Vlad Zahorodnii]

zzag updated this revision to Diff 72968.
zzag added a comment.


  Update logs.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26491?vs=72967=72968

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26491

AFFECTED FILES
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/plasmaquick/dialogshadows_p.h
  src/plasmaquick/waylandintegration.cpp
  src/plasmaquick/waylandintegration_p.h

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26491: [Plasma Quick] Add WaylandIntegration class

[Vlad Zahorodnii]

zzag edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26491

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26491: [Plasma Quick] Add WaylandIntegration class

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  It allows us to get rid of DialogShadows::plasmaShellInterface().

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26491

AFFECTED FILES
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/plasmaquick/dialogshadows_p.h
  src/plasmaquick/waylandintegration.cpp
  src/plasmaquick/waylandintegration_p.h

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26491: [Plasma Quick] Add WaylandIntegration class

[Vlad Zahorodnii]

zzag added a task: T12496: Shadows API in KWindowSystem.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26491

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26191: Add support for FileJob->truncate() in smb/sftp slaves

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.


  I do wonder if maybe more granular return value handling of the smb truncate 
would be in order, but then I suppose the most relevant error is EACCES and 
that'd be handled at opening ¯\_(ツ)_/¯
  
  LGTM

INLINE COMMENTS

> dfaure wrote in kio_sftp.cpp:1497
> self-assignment in some cases is a weird thing to do.
> Why not if (errorCode==..) { errorCode = ..; } ?

I'd just get rid of the assignment TBH. The line below is the last place 
errorCode is used anyway, so the ternary could just move there.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26191

To: feverfew, sitter, dfaure, fvogt
Cc: kde-frameworks-devel, kfm-devel, ngraham, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D26490: [KMessageWidget] Use devicePixelRatioF for animation pixmap

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:fcc7978c7cf1: [KMessageWidget] Use devicePixelRatioF for 
animation pixmap (authored by broulik).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26490?vs=72963=72965

REVISION DETAIL
  https://phabricator.kde.org/D26490

AFFECTED FILES
  src/kmessagewidget.cpp

To: broulik, #frameworks, cullmann
Cc: cullmann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26490: [KMessageWidget] Use devicePixelRatioF for animation pixmap

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Nice catch!

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D26490

To: broulik, #frameworks, cullmann
Cc: cullmann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26490: [KMessageWidget] Use devicePixelRatioF for animation pixmap

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Ensures contents stay crisp during the animation by setting the correct 
fractional device pixel ratio.
  
  BUG: 415528

TEST PLAN
  Ran `QT_SCREEN_SCALE_FACTORS=1.5 kmessagewidgettest`
  Before
  F7867018: Screenshot_20200107_11.png 

  After
  F7867019: Screenshot_20200107_122237.png 


REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D26490

AFFECTED FILES
  src/kmessagewidget.cpp

To: broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26159: Drop KWindowSystem dependency

[Nicolas Fella]

nicolasfella added a comment.


  Please also remove from kde-build-metadata

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26159

To: davidedmundson, apol
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26159: Drop KWindowSystem dependency

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R310:3fec3efc99ac: Drop KWindowSystem dependency (authored by 
davidedmundson).

REPOSITORY
  R310 KTextWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26159?vs=72008=72961

REVISION DETAIL
  https://phabricator.kde.org/D26159

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/findreplace/kfinddialog.h
  src/widgets/ktextedit.cpp

To: davidedmundson, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24932: Add button to open the folder in filelight to view more details

[Kai Uwe Broulik]

broulik requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24932

To: shubham, ngraham, #frameworks, broulik
Cc: broulik, ltoscano, pino, kde-frameworks-devel, #frameworks, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D26488: smb ioslave: fix build regression

[Méven Car]

meven created this revision.
meven added a reviewer: Frameworks.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Regression was introduced in D26420 

TEST PLAN
  builds

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26488

AFFECTED FILES
  smb/kio_smb.cpp
  smb/kio_smb.h
  smb/kio_smb_auth.cpp
  smb/kio_smb_browse.cpp
  smb/kio_smb_dir.cpp
  smb/kio_smb_file.cpp
  smb/kio_smb_internal.cpp
  smb/kio_smb_mount.cpp
  smb/kio_smb_win.cpp

To: meven, #frameworks
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D24932: Add button to open the folder in filelight to view more details

[Kai Uwe Broulik]

broulik reopened this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Can you please look for filelight using 
`KService::serviceByDesktopName("org.kde.filelight")`, then you don't have 
hardcode the executable path, name, icon, etc.

REPOSITORY
  R241 KIO

BRANCH
  file

REVISION DETAIL
  https://phabricator.kde.org/D24932

To: shubham, ngraham, #frameworks
Cc: broulik, ltoscano, pino, kde-frameworks-devel, #frameworks, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D25984: Load translations

[Marco Martin]

mart added a comment.


  ping, what's the current status of this?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: mart, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, hein

D26416: Kicker/Documents optimization: Lazily build KFileItem

[Kai Uwe Broulik]

broulik added a comment.


  Would be lovely in the future to cache those items and make it a proper model 
with backing data rather than requesting everything on demand every time `data` 
is called.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26416

To: meven, #frameworks, apol
Cc: broulik, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26440: Add KSharedConfig::openStateConfig for storing state information

[Kai Uwe Broulik]

broulik added a comment.


  Nice one. Once that `XDG_STATE_HOME` discussion comes to a conclusion [1] we 
could then easily swap the location over, I suppose.
  
  [1] https://lists.freedesktop.org/archives/xdg/2016-December/013803.html

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26440

To: nicolasfella, #frameworks, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> krecentfilesmenu.cpp:150
> +// Don't restore if file doesn't exist anymore
> +if (url.isLocalFile() && !QFile::exists(url.toLocalFile())) {
> +continue;

If we're rewriting this thing anyway, can we please make sure it does not block 
application startup checking if those files exist, as can happen if you had 
opened files on an NFS mount before.

Either do it only when the menu is opened (aboutToShow) and/or asynchronously.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D26448

To: nicolasfella, #frameworks, dfaure
Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D26487: [Kuit] Revert changes in parseUiMarker()

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, ilic, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  This commit partially reverts a9f4cbdda790c3962 
:
  
  - A simple regex is used to find the first whitespace
  - Use QString::indexOf() to search for ':' and '/'
  
  This is faster than using a complex regex. For more details see the
  discussion in D26366 .

TEST PLAN
  make && ctest

REPOSITORY
  R249 KI18n

BRANCH
  l-parseMarkup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26487

AFFECTED FILES
  src/kuitmarkup.cpp

To: ahmadsamir, #frameworks, ilic, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:6d6e2427f8e2: Update KPluginSelector to allow KCM to show 
good state for reset, apply and… (authored by bport).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26466?vs=72906=72954

REVISION DETAIL
  https://phabricator.kde.org/D26466

AFFECTED FILES
  src/kpluginselector.cpp
  src/kpluginselector.h
  src/kpluginselector_p.h

To: bport, #plasma, ervin, crossi, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

[Méven Car]

meven accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D26466

To: bport, #plasma, ervin, crossi, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Delay 100ms before showing the menu

[Tranter Madi]

trmdi planned changes to this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26453: [Purpose] Port QRegExp to QRegularExpression

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:8dc165f088f3: [Purpose] Port QRegExp to 
QRegularExpression (authored by ahmadsamir).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26453?vs=72856=72949

REVISION DETAIL
  https://phabricator.kde.org/D26453

AFFECTED FILES
  src/alternativesmodel.cpp
  src/plugins/phabricator/phabricatorjobs.cpp
  src/plugins/reviewboard/quick/reviewboardrc.cpp

To: ahmadsamir, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 160 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/160/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 07 Jan 2020 08:43:01 +
 Build duration:
5 min 46 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Purpose-5.66.0.xmlcompat_reports/KF5Purpose_compat_report.htmllogs/KF5Purpose/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)30%
(14/47)30%
(14/47)22%
(440/2035)18%
(166/939)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(135/146)53%
(49/92)src100%
(8/8)100%
(8/8)68%
(225/333)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/216)0%
(0/74)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/154)0%
(0/80)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)61%
  

D26194: Port QRegExp to QRegularExpression

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R308:7b356e9dd1ad: Port QRegExp to QRegularExpression 
(authored by ahmadsamir).

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26194?vs=72946=72947

REVISION DETAIL
  https://phabricator.kde.org/D26194

AFFECTED FILES
  src/runnercontext.cpp
  src/runnermanager.cpp

To: ahmadsamir, #plasma, davidedmundson, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26194: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 72946.
ahmadsamir added a comment.


  Rebase

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26194?vs=72116=72946

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26194

AFFECTED FILES
  src/runnercontext.cpp
  src/runnermanager.cpp

To: ahmadsamir, #plasma, davidedmundson, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Delay 100ms before showing the menu

[David Faure]

dfaure added a comment.


  Ah, menu items. Code that is connected to aboutToShow will always execute 
after popup() is called, so delaying the call to popup() can't possibly help, 
unless I'm missing something.
  
  Sounds like we just need a hook, like a signal emitted by this class, with a 
pointer to the menu, so that applications can inject more items before popup() 
is called.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Delay 100ms before showing the menu

[Tranter Madi]

trmdi added a comment.


  In D26484#589327 , @dfaure wrote:
  
  > I don't understand the reasoning, what is this waiting for?
  
  
  It is waiting for additional items to be added when the size is changed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25117: file ioslave: stop copying as soon as the ioslave is killed

[David Faure]

dfaure added a comment.


  I don't see a problem with that. It's common to have activate a "test mode". 
In Qt (single process) there are tons of internal variables exported and used 
with "extern" in unittests. In multi-process scenarios we need cmdline args or 
env vars.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25117

To: meven, #frameworks, dfaure, ngraham, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Delay 100ms before showing the menu

[David Faure]

dfaure added a comment.


  I don't understand the reasoning, what is this waiting for?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

[David Faure]

dfaure added a comment.


  > faster if one msec is even perceivable at all.
  
  It's not, but if an application has 200 strings to translate, then there's a 
0.2s difference. That starts to be perceivable.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26366

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns