D26703: Add icon for text/vnd.kde.kcrash-report

[Kai Uwe Broulik]

broulik closed this revision.
broulik added a comment.


  
https://cgit.kde.org/breeze-icons.git/commit/?id=22286e6a67a1e46c3022d76bb2a2daf73438d646

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26703

To: broulik, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.13 - Build # 89 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.13/89/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Fri, 17 Jan 2020 07:41:33 +
 Build duration:
3 min 13 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   CONSOLE OUTPUT
  [...truncated 17601 lines...][2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/non-starred-symbolic.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/printer-error-symbolic.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/printer-printing-symbolic.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/printer-warning-symbolic.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/rating-unrated.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/rotation-allowed-symbolic.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/rotation-locked-symbolic.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/security-high-symbolic.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/security-low-symbolic.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/security-medium-symbolic.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/semi-starred-symbolic-rtl.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/semi-starred-symbolic.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/starred-symbolic.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/system-lock-screen-symbolic.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/user-available-symbolic.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/user-away-symbolic.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/user-busy-symbolic.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/user-idle-symbolic.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/user-invisible-symbolic.svg[2020-01-17T07:43:19.809Z] -- Installing: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze-dark/status/symbolic/user-not-tracked-symbolic.svg[2020-01-17T07:43:19.809Z] -- 

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kcoredirlister.cpp:2306
> I think you said this would anchor twice, in another review? Needs to be 
> fixed then.
> 
> (Good for readability!)

Right. (I searched through all the porting commits, I missed this one as it 
hasn't committed yet...).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26659

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 63 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/63/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 17 Jan 2020 06:28:33 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.filewatchtest

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.13 - Build # 50 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.13/50/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Fri, 17 Jan 2020 06:28:33 +
 Build duration:
4 min 22 sec and counting
   CONSOLE OUTPUT
  [...truncated 578 lines...][2020-01-17T06:32:35.652Z] [ 21%] Built target KF5BalooCodecs[2020-01-17T06:32:35.935Z] [ 23%] Automatic MOC for target KF5BalooEngine[2020-01-17T06:32:36.218Z] [ 23%] Built target KF5BalooEngine_autogen[2020-01-17T06:32:37.227Z] [ 58%] Built target KF5BalooEngine[2020-01-17T06:32:37.512Z] [ 60%] Automatic MOC for target KF5Baloo[2020-01-17T06:32:37.780Z] [ 60%] Built target KF5Baloo_autogen[2020-01-17T06:32:38.051Z] [ 84%] Built target KF5Baloo[2020-01-17T06:32:38.051Z] [ 85%] Automatic MOC for target balooplugin[2020-01-17T06:32:38.318Z] [ 87%] Built target balooplugin_autogen[2020-01-17T06:32:38.318Z] [ 87%] Automatic MOC for target baloomonitorplugin[2020-01-17T06:32:38.318Z] [ 87%] Built target baloomonitorplugin_autogen[2020-01-17T06:32:38.605Z] [ 92%] Built target balooplugin[2020-01-17T06:32:38.605Z] [100%] Built target baloomonitorplugin[2020-01-17T06:32:38.892Z] Install the project...[2020-01-17T06:32:38.892Z] -- Install configuration: "Debug"[2020-01-17T06:32:38.892Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/lib/cmake/KF5Baloo/KF5BalooQchTargets.cmake[2020-01-17T06:32:38.892Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/lib/cmake/KF5Baloo/KF5BalooConfig.cmake[2020-01-17T06:32:38.892Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/lib/cmake/KF5Baloo/KF5BalooConfigVersion.cmake[2020-01-17T06:32:38.892Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/lib/cmake/KF5Baloo/KF5BalooTargets.cmake[2020-01-17T06:32:38.892Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/lib/cmake/KF5Baloo/KF5BalooTargets-debug.cmake[2020-01-17T06:32:38.892Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/include/KF5/baloo_version.h[2020-01-17T06:32:38.892Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/bin/data/qlogging-categories5/baloo.categories[2020-01-17T06:32:38.892Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/lib/KF5Baloo.lib[2020-01-17T06:32:38.892Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/bin/KF5Baloo.dll[2020-01-17T06:32:39.195Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/include/KF5/Baloo/baloo/core_export.h[2020-01-17T06:32:39.195Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/include/KF5/Baloo/baloo/query.h[2020-01-17T06:32:39.195Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/include/KF5/Baloo/baloo/queryrunnable.h[2020-01-17T06:32:39.195Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/include/KF5/Baloo/baloo/resultiterator.h[2020-01-17T06:32:39.195Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/include/KF5/Baloo/baloo/file.h[2020-01-17T06:32:39.195Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/include/KF5/Baloo/baloo/filemonitor.h[2020-01-17T06:32:39.195Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/include/KF5/Baloo/baloo/taglistjob.h[2020-01-17T06:32:39.195Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/include/KF5/Baloo/baloo/indexerconfig.h[2020-01-17T06:32:39.195Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/include/KF5/Baloo/Baloo/Query[2020-01-17T06:32:39.195Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/include/KF5/Baloo/Baloo/QueryRunnable[2020-01-17T06:32:39.195Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/baloo/include/KF5/Baloo/Baloo/ResultIterator[2020-01-17T06:32:39.195Z] -- Installing: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 407 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/407/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 17 Jan 2020 06:00:51 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.67.0.xmllogs/KF5KIO/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34769/62033)40%
(17684/43790)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9685/10146)47%
(4514/9576)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8704/14618)51%
(4532/8859)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4685/8323)43%
(2072/4806)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(687/1260)40%
(396/978)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(524/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

Re: Updating our coding conventions and coding style for C++11

[Friedrich W. H. Kossebau]

Am Donnerstag, 16. Januar 2020, 23:27:57 CET schrieb David Faure:
> On jeudi 16 janvier 2020 18:29:11 CET Vlad Zahorodnii wrote:
> > I would like us to copy Qt's policy [1] for consistency:
> OK, please do.

+1, thanks for the initiative, Vlad.

> Kai-Uwe wrote:
> > for "auto" I think we should always annotate it with const, *, and/or &
> > where appropriate:
> > auto *something = new MyCustomType;
> > auto *keyEvent = static_cast(event);
> 
> Well, the * is completely redundant in those cases, so it doesn't bring
> anything. I'd be tempted to say, let's not require it.
> But then it raises the question of consistency (without a guideline, we'll
> have some places with * and some places without *).

By my own experience so far I would also settle to say, redundant but very 
helpful to human readers who try to understand some unknown code.

So my +1 for requiring explicit pointer & reference & const with auto. This is 
information too often important for understanding the rest of the code to just 
rely on the human to extract that from the variable initialization code, code 
is much faster to read with that info being explicit.

And sometimes it can also help the code writer to be more sure their 
intention/understanding it matched. And after all "const", "*" & "&" are not 
that expensive to type or bloating up the line :)
More, if you always write them, you will not forget to do so where they are 
not redundant.

Cheers
Friedrich

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 274 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/274/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 17 Jan 2020 06:04:18 +
 Build duration:
7 min 27 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 273 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/273/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 17 Jan 2020 05:38:27 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 251 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/251/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Fri, 17 Jan 2020 05:55:18 +
 Build duration:
7 min 19 sec and counting
   CONSOLE OUTPUT
  [...truncated 3119 lines...][2020-01-17T06:02:29.305Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/lib/plugins/kcm_webshortcuts.dll[2020-01-17T06:02:29.305Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/webshortcuts.desktop[2020-01-17T06:02:29.305Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/lib/plugins/kcm_kio.dll[2020-01-17T06:02:29.305Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/smb.desktop[2020-01-17T06:02:29.305Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/cookies.desktop[2020-01-17T06:02:29.305Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragent.desktop[2020-01-17T06:02:29.305Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/cache.desktop[2020-01-17T06:02:29.305Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/netpref.desktop[2020-01-17T06:02:29.305Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/proxy.desktop[2020-01-17T06:02:29.305Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservicetypes5/uasprovider.desktop[2020-01-17T06:02:29.305Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/android10.desktop[2020-01-17T06:02:29.305Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/chrome10onwinnt51.desktop[2020-01-17T06:02:29.306Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/chrome22oncurrent.desktop[2020-01-17T06:02:29.306Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/chrome23oncurrent.desktop[2020-01-17T06:02:29.306Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/chrome24oncurrent.desktop[2020-01-17T06:02:29.306Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/chrome50oncurrent.desktop[2020-01-17T06:02:29.306Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/chrome570oncurrent.desktop[2020-01-17T06:02:29.306Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/firefox15oncurrent.desktop[2020-01-17T06:02:29.306Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/firefox16oncurrent.desktop[2020-01-17T06:02:29.306Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/firefox20oncurrent.desktop[2020-01-17T06:02:29.306Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/firefox30oncurrent.desktop[2020-01-17T06:02:29.563Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/firefox36oncurrent.desktop[2020-01-17T06:02:29.563Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/firefox520oncurrent.desktop[2020-01-17T06:02:29.563Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/googlebot.desktop[2020-01-17T06:02:29.563Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 406 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/406/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 17 Jan 2020 05:38:27 +
 Build duration:
22 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.67.0.xmllogs/KF5KIO/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34765/62027)40%
(17677/43790)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9685/10146)47%
(4512/9576)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8700/14617)51%
(4527/8859)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4686/8323)43%
(2073/4806)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(687/1260)40%
(396/978)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(524/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 250 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/250/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Fri, 17 Jan 2020 05:38:27 +
 Build duration:
9 min 37 sec and counting
   CONSOLE OUTPUT
  [...truncated 3135 lines...][2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/lib/plugins/kcm_webshortcuts.dll[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/webshortcuts.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/lib/plugins/kcm_kio.dll[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/smb.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/cookies.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragent.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/cache.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/netpref.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/proxy.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservicetypes5/uasprovider.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/android10.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/chrome10onwinnt51.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/chrome22oncurrent.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/chrome23oncurrent.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/chrome24oncurrent.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/chrome50oncurrent.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/chrome570oncurrent.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/firefox15oncurrent.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/firefox16oncurrent.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/firefox20oncurrent.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/firefox30oncurrent.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/firefox36oncurrent.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/firefox520oncurrent.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kio/bin/data/kservices5/useragentstrings/googlebot.desktop[2020-01-17T05:47:58.855Z] -- Installing: C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software 

D26713: Adapt to Qt 5.14 Android changes

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26713

To: vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26440: Add KSharedConfig::openStateConfig for storing state information

[Nathaniel Graham]

ngraham added a task: T12549: Remove cache data from config files.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26440

To: nicolasfella, #frameworks, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Updating our coding conventions and coding style for C++11

[David Jarvie]

On Thursday 16 Jan 2020 18:46:06 Kai Uwe Broulik wrote:
> Hi,
> 
> for "auto" I think we should always annotate it with const, *, and/or &
> where appropriate:
> 
> auto *something = new MyCustomType;
> auto *keyEvent = static_cast(event);
> const auto myList = QStringList({QLatin1String("FooThing"),
> QLatin1String("BarThing")});

This is a bad example of the use of auto. It can be more simply written 
without using auto:

const QStringList myList{QLatin1String("FooThing"),
QLatin1String("BarThing")};

> auto  = foo[bar];
> 
> > The common practice used in KDE seems to be:
> >  for (a:b)
> 
> +1
> 
> Cheers
> Kai Uwe

-- 
David Jarvie.
KDE developer.
KAlarm author -- http://www.astrojar.org.uk/kalarm

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kmountpoint.cpp:438
> +QStringList splitted = path.split(QDir::separator());
> +splitted.pop_back();
> +QString parentPath;

Hmm, what if the symlink *is* the very last component, like your previous 
iteration tried to handle?

> kmountpoint.cpp:445
> +if (fileinfo.isSymLink()) {
> +return findByPath(fileinfo.symLinkTarget());
> +}

I don't want to be a pain, but this is still wrong

If /home/dfaure is a symlink to /opt/dfaure, and then /opt/dfaure/tmp is a 
symlink to /tmp, then the canonical path (and therefore the mount point) for 
/home/dfaure/tmp is in fact /tmp.

But this is going to call findByPath(/opt/dfaure) (the symlink target of the 
first symlink found in the path), and stop there, assuming that everything at 
that target is part of the same mountpoint, which isn't necessarily the case.

I guess this should be findByPath(symLinkTarget() + remainder_of_path)

One possible objection is a case like /a/b/c/d/e/f/g where g is a symlink to h 
(in the same directory), because then both levels of recursion will stat a, b, 
c, d, e, f. But maybe this is unavoidable. I don't know how clever 
canonicalPath() implementations are to optimize such things, while still 
allowing for /a/b/c/d/e to be a symlink to something totally different, like 
/x/y, where /x itself might be a symlink (!!).
OK so maybe the recursion and redoing the stat's for all levels is correct.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26407

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26677: Port away from KLineEdit and KComboBox to Q equivalent

[Gilbert Assaf]

gassaf edited reviewers, added: Frameworks; removed: kde-frameworks-devel.

REPOSITORY
  R305 KNotifyConfig

REVISION DETAIL
  https://phabricator.kde.org/D26677

To: gassaf, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26690: Make "Default Applications" in mimeapps.list the preferred applications

[David Faure]

dfaure added a comment.


  Thanks for looking into this, I'm glad that finally someone does dig into 
this code.
  
  I'm a bit surprised by the solution though. The spec simply says
  
  - add any "Default Applications" and then "Added Associations" in the first 
mimeapps.list
  
  This doesn't need any reverse iteration or prepending, it's just about 
reading Default Applications before Added Associations rather than the other 
way around, isn't it?
  
  I think my comment 5 years ago also meant that the xdg spec allows for the 
default app (left-click in file manager) to be different from the preferred app 
(RMB / Open With).
  But looking at the spec now (Application ordering) it really treats "Default 
Applications" as higher-priority Added Associations, which proves that having 
separated the two is just complete nonsense, they serve the same purpose. Bleh. 
At least it's easier to implement this way :-)

INLINE COMMENTS

> kmimeassociations.cpp:112
> +const QStringList services = group.readXdgListEntry(mimeName);
> +// since the first has precendence and we prepend entries, we need 
> to reverse the list of service
> +std::reverse(services.begin(), services.end());

typo: precedence

> kmimeassociations.cpp:113
> +// since the first has precendence and we prepend entries, we need 
> to reverse the list of service
> +std::reverse(services.begin(), services.end());
> +const QString resolvedMimeName = 
> mimeName.startsWith(QLatin1String("x-scheme-handler/")) ? mimeName : 
> db.mimeTypeForName(mimeName).name();

Iterating with rbegin/rend (instead of the range-for on line 119) would be 
faster.

Or  factorize the rest of the loop with the other method, since that's all 
duplicated otherwise? Then that's a good reason to keep the same range-for.

> kmimeassociations.cpp:125
> +//qDebug() << "prepending mime" << resolvedMimeName << 
> "to service" << pService->entryPath() << "pref=" << pref;
> +m_offerHash.prependServiceOffer(resolvedMimeName, 
> KServiceOffer(pService, pref, 0, pService->allowAsDefault()));
> +--pref;

Replace the last argument with true, clearly this service is allowed as default 
:)
(I'll remove allowAsDefault in KF6 anyway)

> kmimeassociations.cpp:200
>  
> +void KOfferHash::prependServiceOffer(const QString , const 
> KServiceOffer )
> +{

I must be tired, but I don't see any difference between the code of this method 
and the one in addServiceOffer?

(and depending on what the difference should be, I think this should be a 
single method with an enum argument, to reduce duplication)

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D26690

To: meven, dfaure, dvratil, ervin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Updating our coding conventions and coding style for C++11

[Kai Uwe Broulik]

Well, the * is completely redundant in those cases, so it doesn't bring 
anything.
I'd be tempted to say, let's not require it.
But then it raises the question of consistency (without a guideline, we'll have 
some places with * and some places without *).


It provides useful visual information.

auto foo = bar();
auto baz = 

where's the pointer now? Sure, your IDE probably will autocomplete 
operator-> as needed but to me it just feels odd, visually. In any case, 
I'll continue mandating that in code I maintain, even if it's not 
official policy.


Though I also thought the reference would be implied by auto but 
apparently it is not.


Cheers
Kai Uwe

D26692: Fix QRegularExpression::wildcardToRegularExpression() usage

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  l-qregularexpression-too-wildcard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26692

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcoredirlister.cpp:2306
> +d->settings.lstFilters.append(QRegularExpression(
> +
> QRegularExpression::anchoredPattern(QRegularExpression::wildcardToRegularExpression(filter)),
> +QRegularExpression::CaseInsensitiveOption));

I think you said this would anchor twice, in another review? Needs to be fixed 
then.

(Good for readability!)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26659

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Updating our coding conventions and coding style for C++11

[David Faure]

On jeudi 16 janvier 2020 18:29:11 CET Vlad Zahorodnii wrote:
> I would like us to copy Qt's policy [1] for consistency:

OK, please do.

> for (a:b)

+1

Kai-Uwe wrote:
> for "auto" I think we should always annotate it with const, *, and/or &
> where appropriate:
> auto *something = new MyCustomType;
> auto *keyEvent = static_cast(event);

Well, the * is completely redundant in those cases, so it doesn't bring 
anything.
I'd be tempted to say, let's not require it.
But then it raises the question of consistency (without a guideline, we'll have 
some places with * and some places without *).

>From Qt:
examples/widgets/gallery/widgetgallery.cpp:272:auto toolMenu = new 
QMenu(menuToolButton);
tests/manual/cocoa/menurama/main.cpp:40:auto *dockMenu = new QMenu();
Personally, I can survive with this small discrepancy, just like the Qt 
developers clearly can as well.
But if everyone feels strongly that we need to standardize on something

> const auto myList = QStringList({QLatin1String("FooThing"), 
> QLatin1String("BarThing")});
> auto  = foo[bar];

I agree about those, they are not redundant.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 WindowsMSVCQt5.13 - Build # 49 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20WindowsMSVCQt5.13/49/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Thu, 16 Jan 2020 19:22:34 +
 Build duration:
2 min 46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.klanguagenametest
   CONSOLE OUTPUT
  [...truncated 626 lines...][2020-01-16T19:23:58.551Z] -- Installing: C:/CI/workspace/Frameworks/kconfigwidgets/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kconfigwidgets/bin/data/doc/qch/KF5ConfigWidgets.qch[2020-01-16T19:23:58.551Z] -- Installing: C:/CI/workspace/Frameworks/kconfigwidgets/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kconfigwidgets/bin/data/doc/qch/KF5ConfigWidgets.tags[2020-01-16T19:23:58.551Z] -- Installing: C:/CI/workspace/Frameworks/kconfigwidgets/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kconfigwidgets/mkspecs/modules/qt_KConfigWidgets.pri[2020-01-16T19:23:58.551Z] -- Installing: C:/CI/workspace/Frameworks/kconfigwidgets/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kconfigwidgets/lib/plugins/designer/kconfigwidgets5widgets.dll[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Running Tests)[Pipeline] bat[2020-01-16T19:24:01.707Z] [2020-01-16T19:24:01.707Z] C:\CI\workspace\Frameworks\kconfigwidgets\kf5-qt5 WindowsMSVCQt5.13>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" -vcvars_ver=14.16 [2020-01-16T19:24:01.707Z] **[2020-01-16T19:24:01.707Z] ** Visual Studio 2019 Developer Command Prompt v16.4.2[2020-01-16T19:24:01.707Z] ** Copyright (c) 2019 Microsoft Corporation[2020-01-16T19:24:01.707Z] **[2020-01-16T19:24:02.271Z] [vcvarsall.bat] Environment initialized for: 'x64'[2020-01-16T19:24:04.175Z] 'kdeinit5' is not recognized as an internal or external command,[2020-01-16T19:24:04.175Z] operable program or batch file.[2020-01-16T19:24:09.457Z] Cannot find file: C:/CI/workspace/Frameworks/kconfigwidgets/kf5-qt5 WindowsMSVCQt5.13/build/DartConfiguration.tcl[2020-01-16T19:24:09.457Z]Site: [2020-01-16T19:24:09.457Z]Build name: (empty)[2020-01-16T19:24:09.457Z] Create new tag: 20200116-1924 - Experimental[2020-01-16T19:24:09.457Z] Cannot find file: C:/CI/workspace/Frameworks/kconfigwidgets/kf5-qt5 WindowsMSVCQt5.13/build/DartConfiguration.tcl[2020-01-16T19:24:09.457Z] Test project C:/CI/workspace/Frameworks/kconfigwidgets/kf5-qt5 WindowsMSVCQt5.13/build[2020-01-16T19:24:09.457Z] Start 1: kstandardactiontest[2020-01-16T19:24:09.457Z] 1/5 Test #1: kstandardactiontest ..   Passed0.11 sec[2020-01-16T19:24:09.457Z] Start 2: kconfigdialog_unittest[2020-01-16T19:24:09.713Z] 2/5 Test #2: kconfigdialog_unittest ...   Passed0.33 sec[2020-01-16T19:24:09.713Z] Start 3: klanguagenametest[2020-01-16T19:24:09.713Z] 3/5 Test #3: klanguagenametest ***Failed0.04 sec[2020-01-16T19:24:09.713Z] * Start testing of KLanguageNameTest *[2020-01-16T19:24:09.713Z] Config: Using QtTest library 5.13.0, Qt 5.13.0 (x86_64-little_endian-llp64 shared (dynamic) debug build; by MSVC 2017)[2020-01-16T19:24:09.713Z] PASS   : KLanguageNameTest::initTestCase()[2020-01-16T19:24:09.713Z] FAIL!  : KLanguageNameTest::testNameForCode() Compared values are not the same[2020-01-16T19:24:09.713Z]Actual   (KLanguageName::nameForCode("en")): "American English"[2020-01-16T19:24:09.713Z]Expected ("US English"): US English[2020-01-16T19:24:09.713Z] C:\CI\workspace\Frameworks\kconfigwidgets\kf5-qt5 WindowsMSVCQt5.13\autotests\klanguagenametest.cpp(50) : failure location[2020-01-16T19:24:09.713Z] FAIL!  : KLanguageNameTest::testNameForCodeInLocale() Compared values are not the same[2020-01-16T19:24:09.713Z]Actual   (KLanguageName::nameForCodeInLocale("en", "de")): "English"[2020-01-16T19:24:09.713Z]Expected ("US-Englisch") : US-Englisch[2020-01-16T19:24:09.713Z] C:\CI\workspace\Frameworks\kconfigwidgets\kf5-qt5 WindowsMSVCQt5.13\autotests\klanguagenametest.cpp(60) : failure location[2020-01-16T19:24:09.713Z] PASS   : KLanguageNameTest::testNoTranslation()[2020-01-16T19:24:09.713Z] PASS   : KLanguageNameTest::testNoEntry()[2020-01-16T19:24:09.713Z] PASS   : KLanguageNameTest::testNoString()[2020-01-16T19:24:09.713Z] PASS   : KLanguageNameTest::cleanupTestCase()[2020-01-16T19:24:09.713Z] Totals: 5 passed, 2 failed, 0 skipped, 0 blacklisted, 3ms[2020-01-16T19:24:09.713Z] * Finished testing of KLanguageNameTest *[2020-01-16T19:24:09.713Z] [2020-01-16T19:24:09.713Z]   

D25877: [KColorschemeManager] Add option to reenable following global theme

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:a9e1079eba40: [KColorschemeManager] Add option to 
reenable following global theme (authored by davidre).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25877?vs=73079=73734

REVISION DETAIL
  https://phabricator.kde.org/D25877

AFFECTED FILES
  autotests/kcolorschemetest.cpp
  src/kcolorschememanager.cpp
  src/kcolorschememanager.h

To: davidre, #frameworks, ngraham
Cc: ahmadsamir, asemke, kossebau, ngraham, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D26670: ki18n_wrap_ui: error when file doesn't exist

[Christoph Cullmann]

cullmann added inline comments.

INLINE COMMENTS

> kossebau wrote in KF5I18nMacros.cmake.in:52
> This assumes a relative path given. It might make sense to also deal with 
> absolute path, and only append CMAKE_CURRENT_LIST_DIR if not absolute, then 
> check for existance?

Some lines below we anyways do

get_filename_component(_tmp_FILE ${_current_FILE} ABSOLUTE)

Could we not just use the result of this for both the check + output?

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26670

To: davidre, #framework_syntax_highlighting, #localization, #build_system
Cc: cullmann, ngraham, kossebau, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D26457: Introduce shadows API

[Vlad Zahorodnii]

zzag updated this revision to Diff 73733.
zzag added a comment.


  Update doc.

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26457?vs=73728=73733

BRANCH
  kwindowshadow

REVISION DETAIL
  https://phabricator.kde.org/D26457

AFFECTED FILES
  src/CMakeLists.txt
  src/kwindowshadow.cpp
  src/kwindowshadow.h
  src/kwindowshadow_dummy_p.h
  src/kwindowshadow_p.h
  src/kwindowsystemplugininterface.cpp
  src/kwindowsystemplugininterface_p.h
  src/platforms/xcb/CMakeLists.txt
  src/platforms/xcb/kwindowshadow.cpp
  src/platforms/xcb/kwindowshadow_p_x11.h
  src/platforms/xcb/plugin.cpp
  src/platforms/xcb/plugin.h
  src/pluginwrapper.cpp
  src/pluginwrapper_p.h

To: zzag, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kwallet » kf5-qt5 WindowsMSVCQt5.13 - Build # 36 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwallet/job/kf5-qt5%20WindowsMSVCQt5.13/36/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Thu, 16 Jan 2020 18:04:59 +
 Build duration:
3 min 6 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   CONSOLE OUTPUT
  [...truncated 656 lines...][2020-01-16T18:06:39.549Z] [ 82%] Built target kwalletasync_autogen[2020-01-16T18:06:39.549Z] [ 82%] Built target kwalletpath_autogen[2020-01-16T18:06:39.549Z] [ 82%] Built target kwalletmany_autogen[2020-01-16T18:06:39.549Z] [ 82%] Built target kwalletcbc_autogen[2020-01-16T18:06:39.549Z] [ 85%] Built target kwalletsync[2020-01-16T18:06:39.549Z] [ 88%] Built target kwalletboth[2020-01-16T18:06:39.806Z] [ 90%] Built target kwalletpath[2020-01-16T18:06:39.806Z] [ 93%] Built target kwalletasync[2020-01-16T18:06:39.806Z] Install the project...[2020-01-16T18:06:39.806Z] -- Install configuration: "Debug"[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/bin/data/qlogging-categories5/kwallet.categories[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/include/KF5/kwallet_version.h[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/bin/data/dbus-1/interfaces/kf5_org.kde.KWallet.xml[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/lib/KF5Wallet.lib[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/bin/KF5Wallet.dll[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/include/KF5/KWallet/kwallet_export.h[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/include/KF5/KWallet/KWallet[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/include/KF5/KWallet/kwallet.h[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/bin/data/doc/qch/KF5Wallet.qch[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/bin/data/doc/qch/KF5Wallet.tags[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/lib/cmake/KF5Wallet/KF5WalletQchTargets.cmake[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/lib/cmake/KF5Wallet/KF5WalletConfig.cmake[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/lib/cmake/KF5Wallet/KF5WalletConfigVersion.cmake[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/lib/cmake/KF5Wallet/KF5WalletTargets.cmake[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/lib/cmake/KF5Wallet/KF5WalletTargets-debug.cmake[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/mkspecs/modules/qt_KWallet.pri[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/bin/data/dbus-1/services/org.kde.kwalletd5.service[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/bin/kwalletd5.exe[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/bin/data/kservices5/kwalletd5.desktop[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/bin/data/knotifications5/kwalletd.notifyrc[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/kwallet/lib/kwalletbackend5.lib[2020-01-16T18:06:39.806Z] -- Installing: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 

D26707: Fix QRegularExpression::wildcardToRegularExpression() usage

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R311:d4980443755f: Fix 
QRegularExpression::wildcardToRegularExpression() usage (authored by 
ahmadsamir).

REPOSITORY
  R311 KWallet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26707?vs=73702=73732

REVISION DETAIL
  https://phabricator.kde.org/D26707

AFFECTED FILES
  src/api/KWallet/kwallet.cpp
  src/runtime/kwalletd/backend/kwalletbackend.cc

To: ahmadsamir, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26457: Introduce shadows API

[Vlad Zahorodnii]

zzag updated this revision to Diff 73728.
zzag added a comment.


  No `noexcept`
  
  `noexcept` is a very rare thing to see in KF code so let's not deviate too 
much.

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26457?vs=73352=73728

BRANCH
  kwindowshadow

REVISION DETAIL
  https://phabricator.kde.org/D26457

AFFECTED FILES
  src/CMakeLists.txt
  src/kwindowshadow.cpp
  src/kwindowshadow.h
  src/kwindowshadow_dummy_p.h
  src/kwindowshadow_p.h
  src/kwindowsystemplugininterface.cpp
  src/kwindowsystemplugininterface_p.h
  src/platforms/xcb/CMakeLists.txt
  src/platforms/xcb/kwindowshadow.cpp
  src/platforms/xcb/kwindowshadow_p_x11.h
  src/platforms/xcb/plugin.cpp
  src/platforms/xcb/plugin.h
  src/pluginwrapper.cpp
  src/pluginwrapper_p.h

To: zzag, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26713: Adapt to Qt 5.14 Android changes

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  - Library names now have the ABI as a suffix, dependency files need to follow 
that.
  - The Gradle version shipped with Qt changed behavior and is no longer 
appending the build type as a suffix to AAR files.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26713

AFFECTED FILES
  cmake/modules/FindGradle.cmake
  src/CMakeLists.txt

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Updating our coding conventions and coding style for C++11

[Kai Uwe Broulik]

Hi,

for "auto" I think we should always annotate it with const, *, and/or & 
where appropriate:


auto *something = new MyCustomType;
auto *keyEvent = static_cast(event);
const auto myList = QStringList({QLatin1String("FooThing"), 
QLatin1String("BarThing")});

auto  = foo[bar];


The common practice used in KDE seems to be:

 for (a:b)


+1

Cheers
Kai Uwe

Updating our coding conventions and coding style for C++11

[Vlad Zahorodnii]

Hi,

I would like to update our coding conventions
https://community.kde.org/Policies/Library_Code_Policy.

The auto keyword is not mentioned leading to it being a common point of
contention in reviews as we can't point to a reference.

I would like us to copy Qt's policy [1] for consistency:

Optionally, you can use the auto keyword in the following cases. If in
doubt, for example if using auto could make the code less readable, do
not use auto. Keep in mind that code is read much more often than
written.
When it avoids repetition of a type in the same statement.

auto something = new MyCustomType;
auto keyEvent = static_cast(event);
auto myList = QStringList() << QLatin1String("FooThing") <<
QLatin1String("BarThing");

When assigning iterator types.

auto it = myList.const_iterator();

In addition to the coding conventions, I would like to update the KDE
Frameworks Coding Style to include a statement about whitespace before
range-based for loop colons.

The common practice used in KDE seems to be:

for (a:b)

Cheers,
vlad

[1] https://wiki.qt.io/Coding_Conventions#auto_Keyword

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 WindowsMSVCQt5.13 - Build # 48 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20WindowsMSVCQt5.13/48/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Thu, 16 Jan 2020 17:17:51 +
 Build duration:
4 min 59 sec and counting
   CONSOLE OUTPUT
  [...truncated 349 lines...][2020-01-16T17:22:42.531Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/cmake/KF5QQC2DeskopStyle/KF5QQC2DeskopStyleConfig.cmake[2020-01-16T17:22:42.531Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/cmake/KF5QQC2DeskopStyle/KF5QQC2DeskopStyleConfigVersion.cmake[2020-01-16T17:22:42.531Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/qml/QtQuick/Controls.2/org.kde.desktop[2020-01-16T17:22:42.531Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/qml/QtQuick/Controls.2/org.kde.desktop/BusyIndicator.qml[2020-01-16T17:22:42.531Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/qml/QtQuick/Controls.2/org.kde.desktop/Button.qml[2020-01-16T17:22:42.531Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/qml/QtQuick/Controls.2/org.kde.desktop/CheckBox.qml[2020-01-16T17:22:42.531Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/qml/QtQuick/Controls.2/org.kde.desktop/CheckDelegate.qml[2020-01-16T17:22:42.531Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/qml/QtQuick/Controls.2/org.kde.desktop/CheckIndicator.qml[2020-01-16T17:22:42.531Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/qml/QtQuick/Controls.2/org.kde.desktop/ComboBox.qml[2020-01-16T17:22:42.531Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/qml/QtQuick/Controls.2/org.kde.desktop/Container.qml[2020-01-16T17:22:42.531Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/qml/QtQuick/Controls.2/org.kde.desktop/Control.qml[2020-01-16T17:22:42.531Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/qml/QtQuick/Controls.2/org.kde.desktop/DelayButton.qml[2020-01-16T17:22:42.531Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/qml/QtQuick/Controls.2/org.kde.desktop/Dial.qml[2020-01-16T17:22:42.531Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/qml/QtQuick/Controls.2/org.kde.desktop/Dialog.qml[2020-01-16T17:22:42.531Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/qml/QtQuick/Controls.2/org.kde.desktop/DialogButtonBox.qml[2020-01-16T17:22:42.531Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/qml/QtQuick/Controls.2/org.kde.desktop/Drawer.qml[2020-01-16T17:22:42.532Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/qml/QtQuick/Controls.2/org.kde.desktop/Frame.qml[2020-01-16T17:22:42.532Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/qml/QtQuick/Controls.2/org.kde.desktop/GroupBox.qml[2020-01-16T17:22:42.532Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/qml/QtQuick/Controls.2/org.kde.desktop/ItemDelegate.qml[2020-01-16T17:22:42.532Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software Installs/qqc2-desktop-style/lib/qml/QtQuick/Controls.2/org.kde.desktop/Label.qml[2020-01-16T17:22:42.532Z] -- Installing: C:/CI/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 WindowsMSVCQt5.13/install-divert/CI/Software 

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.13 - Build # 128 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.13/128/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Thu, 16 Jan 2020 17:06:30 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: projectroot Failed: 18 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.inlinenote_testFailed: projectroot.autotests.katedocument_testFailed: projectroot.autotests.kateindenttest_testAdaFailed: projectroot.autotests.kateindenttest_testCMakeFailed: projectroot.autotests.kateindenttest_testCppstyleFailed: projectroot.autotests.kateindenttest_testCstyleFailed: projectroot.autotests.kateindenttest_testHaskellFailed: projectroot.autotests.kateindenttest_testLatexFailed: projectroot.autotests.kateindenttest_testNormalFailed: projectroot.autotests.kateindenttest_testPascalFailed: projectroot.autotests.kateindenttest_testPythonFailed: projectroot.autotests.kateindenttest_testReplicodeFailed: projectroot.autotests.kateindenttest_testRubyFailed: projectroot.autotests.kateindenttest_testXmlFailed: projectroot.autotests.katetextbuffertestFailed: projectroot.autotests.kateview_testFailed: projectroot.autotests.messagetestFailed: projectroot.autotests.movingrange_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   CONSOLE OUTPUT
  [...truncated 13896 lines...][2020-01-16T17:16:08.657Z] sonnet.core: Removing loader:  Sonnet::Loader(0x7ff9568a5588)[2020-01-16T17:16:08.657Z] [2020-01-16T17:16:08.657Z]   Start 52: variable_test[2020-01-16T17:16:12.866Z] 52/67 Test #52: variable_test ...   Passed3.45 sec[2020-01-16T17:16:12.866Z]   Start 53: templatehandler_test[2020-01-16T17:16:34.879Z] 53/67 Test #53: templatehandler_test    Passed   19.19 sec[2020-01-16T17:16:34.879Z]   Start 54: katefoldingtest[2020-01-16T17:16:34.879Z] 54/67 Test #54: katefoldingtest .   Passed2.18 sec[2020-01-16T17:16:34.879Z]   Start 55: bug286887[2020-01-16T17:16:35.807Z] 55/67 Test #55: bug286887 ...   Passed2.11 sec[2020-01-16T17:16:35.807Z]   Start 56: katewildcardmatcher_test[2020-01-16T17:16:35.807Z] 56/67 Test #56: katewildcardmatcher_test    Passed0.05 sec[2020-01-16T17:16:35.807Z]   Start 57: completion_test[2020-01-16T17:17:43.481Z] 57/67 Test #57: completion_test .   Passed   67.58 sec[2020-01-16T17:17:43.481Z]   Start 58: commands_test[2020-01-16T17:17:46.026Z] 58/67 Test #58: commands_test ...   Passed2.69 sec[2020-01-16T17:17:46.026Z]   Start 59: scripting_test[2020-01-16T17:17:48.578Z] 59/67 Test #59: scripting_test ..   Passed2.20 sec[2020-01-16T17:17:48.578Z]   Start 60: bug313759[2020-01-16T17:17:56.784Z] 60/67 Test #60: bug313759 ...   Passed7.86 sec[2020-01-16T17:17:56.784Z]   Start 61: bug317111[2020-01-16T17:18:00.122Z] 61/67 Test #61: bug317111 ...   Passed4.08 sec[2020-01-16T17:18:00.122Z]   Start 62: bug205447[2020-01-16T17:18:02.160Z] 62/67 Test #62: bug205447 ...   Passed2.06 sec[2020-01-16T17:18:02.160Z]   Start 63: vimode_modes[2020-01-16T17:18:24.139Z] 63/67 Test #63: vimode_modes    Passed   19.55 sec[2020-01-16T17:18:24.139Z]   Start 64: vimode_view[2020-01-16T17:18:29.430Z] 64/67 Test #64: vimode_view .   Passed7.43 sec[2020-01-16T17:18:29.430Z]   Start 65: vimode_completion[2020-01-16T17:18:33.661Z] 65/67 Test #65: vimode_completion ...   Passed4.17 sec[2020-01-16T17:18:33.661Z]   Start 66: vimode_keys[2020-01-16T17:19:00.265Z] 66/67 Test #66: vimode_keys .   Passed   23.94 sec[2020-01-16T17:19:00.265Z]   Start 67: vimode_emulatedcommandbar[2020-01-16T17:20:08.014Z] 67/67 Test #67: vimode_emulatedcommandbar ...   Passed   67.86 sec[2020-01-16T17:20:08.014Z] [2020-01-16T17:20:08.014Z] 73% tests passed, 18 tests failed out of 67[2020-01-16T17:20:08.014Z] [2020-01-16T17:20:08.014Z] Total Test time (real) = 398.79 sec[2020-01-16T17:20:08.014Z] [2020-01-16T17:20:08.014Z] The following tests FAILED:[2020-01-16T17:20:08.014Z] 	 21 - kateindenttest_testPython (SEGFAULT)[2020-01-16T17:20:08.014Z] 	 22 - kateindenttest_testCstyle (SEGFAULT)[2020-01-16T17:20:08.014Z] 	 23 - kateindenttest_testCppstyle (SEGFAULT)[2020-01-16T17:20:08.014Z] 	 24 - kateindenttest_testCMake (SEGFAULT)[2020-01-16T17:20:08.014Z] 	 25 - kateindenttest_testRuby (SEGFAULT)[2020-01-16T17:20:08.014Z] 	 26 - kateindenttest_testHaskell (SEGFAULT)[2020-01-16T17:20:08.014Z] 	 27 - kateindenttest_testLatex (SEGFAULT)[2020-01-16T17:20:08.014Z] 	 28 - 

D26205: KWallet: Port QRegExp to QRegularExpression

[Mikołaj Płomieński]

blaze added a comment.


  In D26205#595428 , @ahmadsamir 
wrote:
  
  > I still fail to see what's broken, I tested with the system kwallet (5.65 
on tumbleweed) and I don't see any difference between it and a build from a git 
checkout; i.e. falkon doesn't show the saved passwords after restarting it. 
I've already submitted another diff to fix the doubly-anchored pattern issue.
  
  
  
  
  > falkon doesn't show the saved passwords
  
  It's not normal behavior anyways. But have you forgot to restart kwalletd 
process while testing?

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D26205

To: ahmadsamir, #frameworks, aacid, apol
Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26648: Improved quality of JPEG thumbnails

[Nathaniel Graham]

ngraham added a comment.


  Very nice first patch. May it be the first of many! :)

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26648

To: chroniceel, broulik, #frameworks, #vdg, cfeck, ngraham
Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D26648: Improved quality of JPEG thumbnails

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:b18be2ed1a80: Improved quality of JPEG thumbnails 
(authored by chroniceel, committed by ngraham).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26648?vs=73722=73724

REVISION DETAIL
  https://phabricator.kde.org/D26648

AFFECTED FILES
  thumbnail/jpegcreator.cpp

To: chroniceel, broulik, #frameworks, #vdg, cfeck, ngraham
Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D26648: Improved quality of JPEG thumbnails

[Nathaniel Graham]

ngraham added a comment.


  no in a comment is fine

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26648

To: chroniceel, broulik, #frameworks, #vdg, cfeck, ngraham
Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D26648: Improved quality of JPEG thumbnails

[William Tradewell]

chroniceel added a comment.


  wktradew...@gmail.com
  
  ... unless you wanted that in the summary?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26648

To: chroniceel, broulik, #frameworks, #vdg, cfeck, ngraham
Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D26648: Improved quality of JPEG thumbnails

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  @chroniceel Can you provid an email address so we can land this patch with 
correct authorship information?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26648

To: chroniceel, broulik, #frameworks, #vdg, cfeck, ngraham
Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D26648: Improved quality of JPEG thumbnails

[Christoph Feck]

cfeck accepted this revision.
cfeck added a comment.
This revision is now accepted and ready to land.


  Thanks for the detailed investigation, Stefan!

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26648

To: chroniceel, broulik, #frameworks, #vdg, cfeck
Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D26648: Improved quality of JPEG thumbnails

[William Tradewell]

chroniceel added a comment.


  Updated diff. It's setting the quality now, and added a brief comment.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26648

To: chroniceel, broulik, #frameworks, #vdg
Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D26648: Improved quality of JPEG thumbnails

[William Tradewell]

chroniceel updated this revision to Diff 73722.

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26648?vs=73480=73722

REVISION DETAIL
  https://phabricator.kde.org/D26648

AFFECTED FILES
  thumbnail/jpegcreator.cpp

To: chroniceel, broulik, #frameworks, #vdg
Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D26707: Fix QRegularExpression::wildcardToRegularExpression() usage

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R311 KWallet

BRANCH
  l-qregularexpression-wildcard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26707

To: ahmadsamir, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.13 - Build # 127 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.13/127/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Thu, 16 Jan 2020 16:28:38 +
 Build duration:
12 min and counting
   CONSOLE OUTPUT
  [...truncated 528 lines...][2020-01-16T16:40:42.556Z] [  5%] Generating ui_opensaveconfigwidget.h[2020-01-16T16:40:42.556Z] [  5%] Generating ui_navigationconfigwidget.h[2020-01-16T16:40:42.556Z] [  5%] Generating ui_opensaveconfigadvwidget.h[2020-01-16T16:40:42.556Z] [  6%] Generating ui_searchbarincremental.h[2020-01-16T16:40:42.556Z] [  6%] Generating ui_spellcheckbar.h[2020-01-16T16:40:42.556Z] [  7%] Generating qrc_script.cpp[2020-01-16T16:40:42.556Z] [  7%] Generating qrc_ktexteditor.cpp[2020-01-16T16:40:42.556Z] [  7%] Generating ui_searchbarpower.h[2020-01-16T16:40:42.556Z] [  7%] Generating ui_configwidget.h[2020-01-16T16:40:42.556Z] [  7%] Generating ui_howtoimportschema.h[2020-01-16T16:40:42.556Z] [  7%] Generating ui_spellcheckconfigwidget.h[2020-01-16T16:40:42.556Z] Scanning dependencies of target KF5TextEditor[2020-01-16T16:40:42.556Z] [  7%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextbuffer.cpp.obj[2020-01-16T16:40:42.556Z] [  7%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextline.cpp.obj[2020-01-16T16:40:42.556Z] [  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthinttree.cpp.obj[2020-01-16T16:40:42.556Z] [ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katesecuretextbuffer.cpp.obj[2020-01-16T16:40:42.556Z] [  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetexthistory.cpp.obj[2020-01-16T16:40:42.556Z] [  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextrange.cpp.obj[2020-01-16T16:40:42.556Z] [  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionmodel.cpp.obj[2020-01-16T16:40:42.556Z] [  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionwidget.cpp.obj[2020-01-16T16:40:42.556Z] [  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextfolding.cpp.obj[2020-01-16T16:40:42.556Z] [ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextblock.cpp.obj[2020-01-16T16:40:42.556Z] [ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextcursor.cpp.obj[2020-01-16T16:40:42.556Z] [ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiontree.cpp.obj[2020-01-16T16:40:42.556Z] katesecuretextbuffer.cpp[2020-01-16T16:40:42.556Z] katetextline.cpp[2020-01-16T16:40:42.556Z] [ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthintmodel.cpp.obj[2020-01-16T16:40:42.556Z] katetextbuffer.cpp[2020-01-16T16:40:42.556Z] katetextblock.cpp[2020-01-16T16:40:42.556Z] c:\ci\workspace\frameworks\ktexteditor\kf5-qt5 windowsmsvcqt5.13\src\buffer\katetextblock.h(98): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data[2020-01-16T16:40:42.556Z] kateargumenthintmodel.cpp[2020-01-16T16:40:42.556Z] katetextcursor.cpp[2020-01-16T16:40:42.556Z] katetextrange.cpp[2020-01-16T16:40:42.556Z] katetexthistory.cpp[2020-01-16T16:40:42.556Z] katetextfolding.cpp[2020-01-16T16:40:42.556Z] katecompletionwidget.cpp[2020-01-16T16:40:42.556Z] katecompletionmodel.cpp[2020-01-16T16:40:42.556Z] katecompletiontree.cpp[2020-01-16T16:40:42.556Z] kateargumenthinttree.cpp[2020-01-16T16:40:42.556Z] [ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiondelegate.cpp.obj[2020-01-16T16:40:42.556Z] c:\ci\workspace\frameworks\ktexteditor\kf5-qt5 windowsmsvcqt5.13\src\buffer\katetextblock.h(98): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data[2020-01-16T16:40:42.556Z] c:\ci\workspace\frameworks\ktexteditor\kf5-qt5 windowsmsvcqt5.13\src\buffer\katetextblock.h(98): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data[2020-01-16T16:40:42.556Z] c:\ci\workspace\frameworks\ktexteditor\kf5-qt5 windowsmsvcqt5.13\src\buffer\katetextblock.h(98): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data[2020-01-16T16:40:42.556Z] katecompletiondelegate.cpp[2020-01-16T16:40:42.556Z] [ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingwidgetmodel.cpp.obj[2020-01-16T16:40:42.556Z] c:\ci\workspace\frameworks\ktexteditor\kf5-qt5 windowsmsvcqt5.13\src\buffer\katetextblock.h(98): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data[2020-01-16T16:40:42.556Z] expandingwidgetmodel.cpp[2020-01-16T16:40:42.556Z] [ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingdelegate.cpp.obj[2020-01-16T16:40:42.556Z] c:\ci\workspace\frameworks\ktexteditor\kf5-qt5 windowsmsvcqt5.13\src\buffer\katetextblock.h(98): warning C4267: 'return': 

D26691: Optimize code when dropping files into the desktop

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  m_dropActions is conceptually linked to the menu we are showing
  It shouldn't a direct member variable of ContainmentInterface
  
  If we're following the existing pattern of this menu, it should be:
   QHash *> m_dropJobs;
  
  Otherwise you have no overlap protection on something that's async
  
  I also am very confident if you either subclassed DropJob or used lamba's we 
can get rid of all of these hashes and make this code 10 billion times more 
readable. 
  (we have some crashers here, so it would be well worth it)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson
Cc: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D26704: KateMessageWidget: remove unused event filter installation

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:9499d28ba80b: KateMessageWidget: remove unused event 
filter installation (authored by kossebau).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26704?vs=73689=73719

REVISION DETAIL
  https://phabricator.kde.org/D26704

AFFECTED FILES
  src/view/katemessagewidget.cpp

To: kossebau, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26648: Improved quality of JPEG thumbnails

[Stefan Brüns]

bruns added a comment.


  Having had a look at 
https://code.woboq.org/qt5/qtbase/src/plugins/imageformats/jpeg/qjpeghandler.cpp.html#_M/HIGH_QUALITY_THRESHOLD,
 the jpeg handler actually know two different quality settings, `< 50` and `> 
50`, the default being 75, i.e. high.
  
  High quality means floating point DCT and bilinear upsampling 
(Qt::SmoothTransformation), while low means IDCT and nearest neighbor 
upsampling.
  
  
https://code.woboq.org/qt5/qtbase/src/plugins/imageformats/jpeg/qjpeghandler.cpp.html#337
  
https://code.woboq.org/qt5/qtbase/src/plugins/imageformats/jpeg/qjpeghandler.cpp.html#432
  
  In either case, it uses libjpeg's capability to reconstruct smaller versions 
of the image, only decoding it partially, up to DC components only (i.e. 1/8 
scale). So for a 24MPixel (6000x4000), libjpeg returns a 750x500 Pixel image, 
which is then downscaled by Qimage to 256x171 Pixel. Using SmoothTransformation 
for this size should be not to heavy.
  
  
https://code.woboq.org/qt5/qtbase/src/plugins/imageformats/jpeg/qjpeghandler.cpp.html#297
  
  I think best is to set the quality explicitly and mention in a comment what 
intended effect the setting has (so if the jpeghandler behavior changes, the 
code can be adjusted to have the wanted effect).

REVISION DETAIL
  https://phabricator.kde.org/D26648

To: chroniceel, broulik, #frameworks, #vdg
Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D26691: Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi updated this revision to Diff 73716.
trmdi added a comment.


  - Change the cursor to the busy state when the first file is not local

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26691?vs=73694=73716

BRANCH
  improve-file-drop-menu

REVISION DETAIL
  https://phabricator.kde.org/D26691

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.h

To: trmdi, #plasma, mart, broulik, #vdg
Cc: anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26704: KateMessageWidget: remove unused event filter installation

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  I guess this change is correct :-)

REPOSITORY
  R39 KTextEditor

BRANCH
  removeunusedeventfilter

REVISION DETAIL
  https://phabricator.kde.org/D26704

To: kossebau, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26648: Improved quality of JPEG thumbnails

[William Tradewell]

chroniceel added a comment.


  Ping! I think this got buried. Unless someone else is testing this?

REVISION DETAIL
  https://phabricator.kde.org/D26648

To: chroniceel, broulik, #frameworks, #vdg
Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D26703: Add icon for text/vnd.kde.kcrash-report

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26703

To: broulik, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25682: add initial wsdiscovery support

[Harald Sitter]

sitter updated this revision to Diff 73704.
sitter added a comment.


  redesign finish system
  
  it occured to me that the blocking nature of the finish system is entirely 
pointless.
  we already have an eventloop running anyway, so all we need to do is track 
whether all
  entities have been resolved to discoveries. when they have the discoverer is 
finished.
  when all discoverers are finished the entire loop and thus the browse cmd can 
terminate.
  
  also fixed some problems with forced eventloop quitting when the hard timeout 
is hit.
  before quitting the eventloop the udsentry list is flushed now, otherwise we 
may
  lose discoveries depending on timing

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25682?vs=73405=73704

BRANCH
  arcpatch-D25682

REVISION DETAIL
  https://phabricator.kde.org/D25682

AFFECTED FILES
  smb/CMakeLists.txt
  smb/discovery.cpp
  smb/discovery.h
  smb/dnssddiscoverer.cpp
  smb/dnssddiscoverer.h
  smb/kdsoap-ws-discovery-client/.gitignore
  smb/kdsoap-ws-discovery-client/.gitlab-ci.yml
  smb/kdsoap-ws-discovery-client/CMakeLists.txt
  smb/kdsoap-ws-discovery-client/KDSoapWSDiscoveryClientConfig.cmake.in
  smb/kdsoap-ws-discovery-client/LICENSE
  smb/kdsoap-ws-discovery-client/README.md
  smb/kdsoap-ws-discovery-client/examples/CMakeLists.txt
  smb/kdsoap-ws-discovery-client/examples/onvif-discover/CMakeLists.txt
  smb/kdsoap-ws-discovery-client/examples/onvif-discover/main.cpp
  smb/kdsoap-ws-discovery-client/examples/onvif-discover/onvifdiscover.cpp
  smb/kdsoap-ws-discovery-client/examples/onvif-discover/onvifdiscover.h
  smb/kdsoap-ws-discovery-client/src/CMakeLists.txt
  smb/kdsoap-ws-discovery-client/src/wsdiscoveryclient.cpp
  smb/kdsoap-ws-discovery-client/src/wsdiscoveryclient.h
  smb/kdsoap-ws-discovery-client/src/wsdiscoveryprobejob.cpp
  smb/kdsoap-ws-discovery-client/src/wsdiscoveryprobejob.h
  smb/kdsoap-ws-discovery-client/src/wsdiscoverytargetservice.cpp
  smb/kdsoap-ws-discovery-client/src/wsdiscoverytargetservice.h
  
smb/kdsoap-ws-discovery-client/wsdl/docs.oasis-open.org/ws-dd/discovery/1.1/os/wsdd-discovery-1.1-schema-os.xsd
  
smb/kdsoap-ws-discovery-client/wsdl/docs.oasis-open.org/ws-dd/discovery/1.1/os/wsdd-discovery-1.1-wsdl-os.wsdl
  smb/kdsoap-ws-discovery-client/wsdl/download.sh
  smb/kdsoap-ws-discovery-client/wsdl/schemas.xmlsoap.org/ws/2004/08/addressing
  
smb/kdsoap-ws-discovery-client/wsdl/schemas.xmlsoap.org/ws/2004/09/transfer/transfer.wsdl
  
smb/kdsoap-ws-discovery-client/wsdl/schemas.xmlsoap.org/ws/2004/09/transfer/transfer.xsd
  
smb/kdsoap-ws-discovery-client/wsdl/schemas.xmlsoap.org/ws/2005/04/discovery/ws-discovery.wsdl
  
smb/kdsoap-ws-discovery-client/wsdl/schemas.xmlsoap.org/ws/2005/04/discovery/ws-discovery.xsd
  smb/kdsoap-ws-discovery-client/wsdl/www.w3.org/2006/03/addressing/ws-addr.xsd
  smb/kio_smb.h
  smb/kio_smb_browse.cpp
  smb/wsdiscoverer.cpp
  smb/wsdiscoverer.h

To: sitter, dfaure, #frameworks, #dolphin
Cc: meven, schmeisser, bcooksley, ngraham, caspermeijn, davidedmundson, 
kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D26205: KWallet: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.


  In D26205#595111 , @blaze wrote:
  
  > > otherwise, we could just revert this patch
  >
  > The rest of the code is OK. The part that works funny is just the wildcard 
method, and since it's relatively new, I hope there could be a good workaround 
until the situation stabilizes
  
  
  I still fail to see what's broken, I tested with the system kwallet (5.65 on 
tumbleweed) and I don't see any difference between it and a build from a git 
checkout; i.e. falkon doesn't show the saved passwords after restarting it. 
I've already submitted another diff to fix the doubly-anchored pattern issue.
  
  Could you give me another test case? I want to see what's broken to try and 
fix it.
  
  Thanks in advance.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D26205

To: ahmadsamir, #frameworks, aacid, apol
Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26707: Fix QRegularExpression::wildcardToRegularExpression() usage

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, apol, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  It turns out that QRegularExpression::wildcardToRegularExpression() returns
  an anchored (with \A and \z) pattern, so using anchoredPattern() in such
  cases would actually anchor the pattern twice, which is obviously wrong.
  Thanks to Mikołaj Płomieński (blaze) for catching it in
  https://phabricator.kde.org/D26205#594891

TEST PLAN
  make && ctest

REPOSITORY
  R311 KWallet

BRANCH
  l-qregularexpression-wildcard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26707

AFFECTED FILES
  src/api/KWallet/kwallet.cpp
  src/runtime/kwalletd/backend/kwalletbackend.cc

To: ahmadsamir, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26085: KCModuleQml: Ensure defaulted is emitted with the current configModule->representsDefaults on load

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:abd2e496efaa: KCModuleQml: Ensure defaulted is emitted 
with the current configModule… (authored by meven).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26085?vs=71791=73700

REVISION DETAIL
  https://phabricator.kde.org/D26085

AFFECTED FILES
  src/kcmoduleqml.cpp

To: meven, crossi, mart, #frameworks, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:198e589d5df5: Unbreak the 
KNSQuick::Engine::changedEntries functionality (authored by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26543?vs=73698=73699

REVISION DETAIL
  https://phabricator.kde.org/D26543

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/entrywrapper.cpp
  src/core/entrywrapper.h
  src/qtquick/qml/Button.qml
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h

To: leinir, #frameworks, #plasma, ngraham, broulik, mart, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 73698.
leinir added a comment.


  Some housekeeping (rebase on master)
  
  - Actually update the entry when it's updated, don't just ignore it
  - As 5.66 was released, update @since to 5.67
  - Actually use the correct type for the list property

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26543?vs=73680=73698

BRANCH
  unbreak-changedentries-in-qtquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26543

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/entrywrapper.cpp
  src/core/entrywrapper.h
  src/qtquick/qml/Button.qml
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h

To: leinir, #frameworks, #plasma, ngraham, broulik, mart, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D26543#595374 , @davidedmundson 
wrote:
  
  > Given timeframes and where we've ended up. Accepted.
  
  
  Thanks! :)
  
  > I would like to see some KF6 workboard tasks for the future.
  
  That would be a good idea, yup. Most of the things that need doing in 
KNewStuff are marked as TODO KF6 throughout the codebase, but an overview with 
some more... conceptual goals would be good, so it's more clear precisely what 
the basic idea is for the future of the framework.

REPOSITORY
  R304 KNewStuff

BRANCH
  unbreak-changedentries-in-qtquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26543

To: leinir, #frameworks, #plasma, ngraham, broulik, mart, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Given timeframes and where we've ended up. Accepted.
  
  I would like to see some KF6 workboard tasks for the future.
  QVariantList + QGadget should work, though that does require recent Qt.

REPOSITORY
  R304 KNewStuff

BRANCH
  unbreak-changedentries-in-qtquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26543

To: leinir, #frameworks, #plasma, ngraham, broulik, mart, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 272 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/272/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 16 Jan 2020 12:56:29 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 280 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/280/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 16 Jan 2020 12:56:29 +
 Build duration:
19 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.67.0.xmllogs/KF5KIO/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34767/62024)40%
(17661/43786)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9687/10144)47%
(4508/9576)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8699/14617)51%
(4522/8859)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4681/8323)43%
(2068/4802)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(687/1260)40%
(396/978)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(524/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D26543#595368 , @davidedmundson 
wrote:
  
  > I've gone through this again, and I'm somewhat confused.
  >  Entry (via EntryWrapper) doesn't seem usable by QML. It doesn't have any 
properties.
  >
  > If it's just proxying through QML to other C++, then QVariant should be 
fine, no need for a custom box type no need for QQmlListProperty. 
  >  A QVariantList would cover everything.
  
  
  It does not currently, but the intention is to expand upon it and make it 
usable from QML. In the spirit of not lumping everything in and making this yet 
another huge, months long pile of work that nobody has time to review, i 
thought it reasonable to perhaps get this to happen first, and then expand upon 
it as needed by KNSQuick.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D26543

To: leinir, #frameworks, #plasma, ngraham, broulik, mart
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

[David Edmundson]

davidedmundson added a comment.


  I've gone through this again, and I'm somewhat confused.
  Entry (via EntryWrapper) doesn't seem usable by QML. It doesn't have any 
properties.
  
  If it's just proxying through QML to other C++, then QVariant should be fine, 
no need for a custom box type no need for QQmlListProperty. 
  A QVariantList would cover everything.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D26543

To: leinir, #frameworks, #plasma, ngraham, broulik, mart
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26691: Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi updated this revision to Diff 73694.
trmdi marked an inline comment as done.
trmdi added a comment.


  - Remove unneeded code

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26691?vs=73693=73694

BRANCH
  improve-file-drop-menu

REVISION DETAIL
  https://phabricator.kde.org/D26691

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.h

To: trmdi, #plasma, mart, broulik, #vdg
Cc: anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26691: Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi marked an inline comment as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi, #plasma, mart, broulik, #vdg
Cc: anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26691: Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi updated this revision to Diff 73693.
trmdi added a comment.


  - Remove unneeded code

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26691?vs=73634=73693

BRANCH
  improve-file-drop-menu

REVISION DETAIL
  https://phabricator.kde.org/D26691

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.h

To: trmdi, #plasma, mart, broulik, #vdg
Cc: anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26691: Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi added reviewers: broulik, VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi, #plasma, mart, broulik, #vdg
Cc: anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26602: Define K_DOXYGEN as macro to check if kapidox/doxygen is run

[Friedrich W. H. Kossebau]

kossebau added a comment.


  No one any opinion? Guess most people have not run into the need to do 
pre-processor switches for the doc generation, and also never seen 
DOXYGEN_SHOULD_SKIP_THIS before.
  
  So would move forward with this on Thursday, 23rd January, if no-one objects 
until then.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26602

To: kossebau, #frameworks
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
GB_2, michaelh, ngraham, bruns, skadinna

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

[Méven Car]

meven updated this revision to Diff 73690.
meven added a comment.


  Fix poping .length() > 0 ordering

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26407?vs=73687=73690

BRANCH
  arcpatch-D26407

REVISION DETAIL
  https://phabricator.kde.org/D26407

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/kmountpoint.cpp
  src/core/kmountpoint.h

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26704: KateMessageWidget: remove unused event filter installation

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Left-over from removal of event filter when this code was still part
  of Kate repo, commit 487513e4a3573916eff9c417f98896c80c2f6955 


REPOSITORY
  R39 KTextEditor

BRANCH
  removeunusedeventfilter

REVISION DETAIL
  https://phabricator.kde.org/D26704

AFFECTED FILES
  src/view/katemessagewidget.cpp

To: kossebau, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:98c32e29f504: WIP: Refactor KConfigXT (authored by 
tcanabrava).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26202?vs=73608=73688

REVISION DETAIL
  https://phabricator.kde.org/D26202

AFFECTED FILES
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test1.h.ref
  autotests/kconfig_compiler/test10.h.ref
  autotests/kconfig_compiler/test11.h.ref
  autotests/kconfig_compiler/test11a.h.ref
  autotests/kconfig_compiler/test12.h.ref
  autotests/kconfig_compiler/test13.h.ref
  autotests/kconfig_compiler/test9.h.ref
  autotests/kconfig_compiler/test_dpointer.cpp.ref
  autotests/kconfig_compiler/test_translation_kde.h.ref
  autotests/kconfig_compiler/test_translation_kde_domain.h.ref
  autotests/kconfig_compiler/test_translation_qt.h.ref
  autotests/kconfigtest.h
  src/kconfig_compiler/CMakeLists.txt
  src/kconfig_compiler/KCFGXmlParser.cpp
  src/kconfig_compiler/KCFGXmlParser.h
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigCodeGeneratorBase.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXTParameters.cpp
  src/kconfig_compiler/KConfigXTParameters.h
  src/kconfig_compiler/kconfig_compiler.cpp

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

[Méven Car]

meven updated this revision to Diff 73687.
meven marked an inline comment as done.
meven added a comment.


  Check parent dir transitive symlinks, aka manual canonicalPath

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26407?vs=73524=73687

BRANCH
  arcpatch-D26407

REVISION DETAIL
  https://phabricator.kde.org/D26407

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/kmountpoint.cpp
  src/core/kmountpoint.h

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 92 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/92/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 16 Jan 2020 09:31:31 +
 Build duration:
37 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

D26594: Deprecate raiseWidget

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Hi. When introducing the deprecation macros to a lib with 
`ecm_generate_export_header`, one also needs to help kapidox & ecm_add_qch. 
Sadly this was only discovered later, so it is also missing from the first set 
of such commits introducing the use of `ecm_generate_export_header`which you 
might have taken as template :)
  
  bdd8930cca99d81a5a5d4714b267419576e30ede 
 
fixes this. Teaching the documentation tools is meanwhile also documented at 
https://community.kde.org/Policies/Library_Code_Policy#Deprecation_of_API so 
hopefully future additions of ecm_generate_export_header will have all things 
set as needed from the start. Yes, all these duplications are hell. In a 
perfect world all this depreaction support would be part of the language 
specification, and tools would handle things be default... for now this is the 
best someone came up with.

INLINE COMMENTS

> CMakeLists.txt:95
> +DEPRECATION_VERSIONS 5.67
> +EXCLUDE_DEPRECATED_BEFORE_AND_AT ${EXCLUDE_DEPRECATED_BEFORE_AND_AT}
> +)

This also needs the definition as option in the toplevel file. Fixed by 
191078e9387b3b591c46d68f884a18ad96b4f2f6 


REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26594

To: nicolasfella, #frameworks, broulik, apol
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26405: Add mime type for backtraces saved from DrKonqi

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:ae1fb551ce19: Add mime type for backtraces saved from 
DrKonqi (authored by broulik).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26405?vs=72716=73684

REVISION DETAIL
  https://phabricator.kde.org/D26405

AFFECTED FILES
  src/mimetypes/kde5.xml

To: broulik, #frameworks, sitter, mpyne
Cc: mpyne, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26703: Add icon for text/vnd.kde.kcrash-report

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This is for backtraces saved from DrKonqi

TEST PLAN
  F7858683: Screenshot_20200103_225422.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26703

AFFECTED FILES
  icons-dark/mimetypes/16/text-vnd.kde.kcrash-report.svg
  icons-dark/mimetypes/22/text-vnd.kde.kcrash-report.svg
  icons-dark/mimetypes/32/text-vnd.kde.kcrash-report.svg
  icons-dark/mimetypes/64/text-vnd.kde.kcrash-report.svg
  icons/mimetypes/16/text-vnd.kde.kcrash-report.svg
  icons/mimetypes/22/text-vnd.kde.kcrash-report.svg
  icons/mimetypes/32/text-vnd.kde.kcrash-report.svg
  icons/mimetypes/64/text-vnd.kde.kcrash-report.svg

To: broulik, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26405: Add mime type for backtraces saved from DrKonqi

[Kai Uwe Broulik]

broulik added a comment.


  > there's also text/x-apport
  
  I just noticed that Breeze had an icon for that, I don't actually find it in 
mime info

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26405

To: broulik, #frameworks, sitter, mpyne
Cc: mpyne, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

[Dan Leinir Turthra Jensen]

leinir added a comment.


  Thanks to David for making me look at that again, the original choice was 
based on a false-positive test

INLINE COMMENTS

> davidedmundson wrote in quickengine.h:54
> Why QObject here?
> 
> One of the main advantages of using QQmlListProperty over QList is 
> that you can specify the derived type.

Quite simply because i, in my test code, had something around the wrong way... 
Updated patch incoming.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D26543

To: leinir, #frameworks, #plasma, ngraham, broulik, mart
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 73680.
leinir marked an inline comment as done.
leinir added a comment.


  - Actually use the correct type for the list property

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26543?vs=73408=73680

BRANCH
  unbreak-changedentries-in-qtquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26543

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/entrywrapper.cpp
  src/core/entrywrapper.h
  src/qtquick/qml/Button.qml
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h

To: leinir, #frameworks, #plasma, ngraham, broulik, mart
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26690: Make "Default Applications" in mimeapps.list the preferred applications

[Méven Car]

meven updated this revision to Diff 73679.
meven added a comment.


  Update code to have a better implementation reusing existant API

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26690?vs=73633=73679

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26690

AFFECTED FILES
  src/kdeinit/ktoolinvocation_x11.cpp
  src/sycoca/kmimeassociations.cpp
  src/sycoca/kmimeassociations_p.h

To: meven, dfaure, dvratil, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26690: Make "Default Applications" in mimeapps.list the preferred applications

[Méven Car]

meven added a reviewer: Frameworks.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D26690

To: meven, dfaure, dvratil, ervin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26690: Make "Default Applications" in mimeapps.list the preferred applications

[Méven Car]

meven retitled this revision from "[WIP] Add 
KMimeTypeTrader::defaultSchemaHandler to return default service associated with 
scheme" to "Make "Default Applications" in mimeapps.list the preferred 
applications".
meven edited the summary of this revision.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D26690

To: meven, dfaure, dvratil, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26205: KWallet: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.




INLINE COMMENTS

> blaze wrote in kwallet.cpp:180
> > The transformation is targeting file path globbing, which means in 
> > particular that path separators receive special treatment.
> 
> I'm pretty sure the file path case is different from what we have here.
> 
> Also
> 
> > In order to match one of the special characters, place it in square 
> > brackets (for example, "[?]")
> 
> Doesn't it mean you can't just use a bare raw wildcard?
> 
> So my suggestion is just to rollback to the previous solution, at least 
> temporarily, until we don't have something better.

The part about "[?]"; in the QRegularExpression documentation 
https://doc.qt.io/qt-5/qregularexpression.html#wildcardToRegularExpression "?" 
is used for wild card matching:

> ?   Matches any single character. It is the same as . in full regexps.

IIUC, the comment about "[?]" means if wildcardToRegularExpression() is used 
and you want to match a literal "?" character you'll have to use square 
brackets "[?]", different issue.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D26205

To: ahmadsamir, #frameworks, aacid, apol
Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26202: WIP: Refactor KConfigXT

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  arcpatch-D26202

REVISION DETAIL
  https://phabricator.kde.org/D26202

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26690: [WIP] Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme

[Méven Car]

meven added a comment.


  In D26690#595221 , @dfaure wrote:
  
  > s/Schema/Scheme/ everywhere (method name, commit log)
  >
  > I want to deprecate KMimeTypeTrader, this should rather go into the 
upcoming KApplicationTrader D25698 , if new 
API is needed.
  >
  > I'm pretty sure you can use KMimeTypeTrader::query(mimeHandler) instead of 
parsing mimeapps.list. And then I wonder if you really need new API :)
  
  
  Let me be clearer about my intend.
  
  Basically it is about fixing the TODO in kmimeassociation.cpp added in 
3116911fa0d02dc4c5f05923cc6d7bf490a580e5 

  
// TODO "Default Applications" is a separate query and a separate 
algorithm, says the spec.
// For now this is better than nothing though.
parseAddedAssociations(KConfigGroup(, "Default Applications"), 
file, basePreference);
  
  For instance say, I have in  ~/.config/mimeapps.list :
  
[Added Associations]
x-scheme-handler/mailto=org.kde.kate.org;thunderbird.desktop

[Default Applications]
x-scheme-handler/mailto=thunderbird.desktop;
  
  Thunderbird will think it is the default email client (according to the spec) 
but `KMimeTypeTrader::preferredService("x-scheme-handler/mailto")` 
`KApplicationTrader::preferredService("x-scheme-handler/mailto")` will return 
"org.kde.kate.org".
  And in general we have no alternative way to find default association to 
mimetype according to the xdg specs. It may work as long as we don't have any 
"Added Associations", or when they match "Default Applications" but non-kde 
apps are not expected to deviate from the spec for our limitations.
  
  Perhaps all we need is to improve parsing of "Default Applications" so that 
it is returned by `KMimeTypeTrader::preferredService`, that is prepend default 
apps to the list of apps associated with mimetypes.
  I will update this PR soonish to implement this idea.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D26690

To: meven, dfaure, dvratil, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26693: Fix QRegularExpression::wildcardToRegularExpression() usage

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:ce27c7cf1121: Fix 
QRegularExpression::wildcardToRegularExpression() usage (authored by 
ahmadsamir).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26693?vs=73652=73677

REVISION DETAIL
  https://phabricator.kde.org/D26693

AFFECTED FILES
  src/alternativesmodel.cpp

To: ahmadsamir, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 73676.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Add TODO KF6 notes to remove doNameFilter() and doMimeFilter()

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26659?vs=73605=73676

BRANCH
  l-qregexp-deprecate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26659

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister.h
  src/core/kcoredirlister_p.h

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> meven wrote in kfileitem.cpp:787
> I meant this and this what KMountPoint does, better be precise here.

I see. Sorry, I hadn't realized that there is a Q_OS_ANDROID check in 
kmountpoint itself.

> kmountpoint.cpp:437
> +QFileInfo fileinfo(path);
> +if (fileinfo.isSymLink()) {
> +return findByPath(fileinfo.symLinkTarget());

Compared to canonicalPath, this only works if the very last component is a 
symlink.

If I make /home/dfaure a symlink to /opt/dfaure (because I have more disk space 
there), then findByPath("/home/dfaure/Documents/foo.odt") used to return the 
mountpoint for /opt (which was correct) while now it will return the mount 
point for /home.
isSymlink() will say false because foo.odt isn't a symlink.

I don't see a perfect solution to this. The best we can do IMHO is make things 
work for local symlinked directories and for remote mounts, but we can't fully 
avoid slow calls in the case of symlinks-to-remote-mounts.

So I would just call canonicalPath here, once we find out that the orig path 
isn't a slow mount. Yes it might point to a slow mount, but IMHO that's the 
user asking for (performance) trouble :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26407

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ahmadsamir wrote in kcoredirlister.h:595
> Thanks, fixed. Luckily it's a convenience function of sorts and replacing the 
> one instance it was used in KCoreDirLister was simple).

Please write TODO KF6 remove, I see zero reason to keep this a virtual method, 
and lxr says nobody is using it. Same for doMimeFilter.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26659

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: Optimize code when dropping files into the desktop

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> containmentinterface.cpp:589
> +}
> +qDebug() << "clearDataForMimeJob() ends.";
>  }

Don't add uncategorized qDebug, i see it exists in code base but they should be 
ported as well.

> containmentinterface.cpp:816-819
> +//choices->exec();
>  } else {
> -dropJob->setApplicationActions(dropActions);
> +//dropJob->setApplicationActions(m_dropActions);
>  }

Remove, don't leave commented code

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi, #plasma, mart
Cc: anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns