D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:ad625f68f345: Fix the size and pixel alignment of 
checkboxes and radiobuttons (authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26758?vs=73852=74476

REVISION DETAIL
  https://phabricator.kde.org/D26758

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/CheckIndicator.qml
  src/declarativeimports/plasmacomponents3/RadioButton.qml
  src/declarativeimports/plasmacomponents3/RadioIndicator.qml
  src/declarativeimports/plasmastyle/CheckBoxStyle.qml
  src/declarativeimports/plasmastyle/RadioButtonStyle.qml
  src/desktoptheme/breeze/widgets/actionbutton.svg
  src/desktoptheme/breeze/widgets/checkmarks.svg

To: ndavis, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D26955: Fix background SVG colors and adjust background SVG corners

[Noah Davis]

ndavis added a subscriber: niccolove.
ndavis added a comment.


  In D26955#601684 , @ngraham wrote:
  
  > This fixes the color bug, so that's good. :)
  >
  > However with Breeze Dark, now I see pointy corners and very weak shadows: 
F7982216: Screenshot_20200127_221203.png 
  >
  > ...Whereas with the Breeze and Breeze Light plasma style, I see nice 
shadows and rounded corners : F7982219: Screenshot_20200127_221718.png 

  >
  > (and yes I cleared the plasma SVG cache)
  
  
  Did you test the original shadows patch with breeze dark? These shadows are 
identical. I even zoomed into screenshots 1600% and used a color picker on 
different pixels in the shadow. If you don't like these shadows then we should 
just revert the shadows patch instead of fixing them with this patch.
  
  I don't know what to do about the corners. There's no reason why they should 
have sharp corners. Even if I replicate the previous corners, the issue is 
still there. I'm suspecting a bug in the code. @niccolove also had a lot of 
trouble with the mask. He said it doesn't seem to even work and deleting the 
mask from the SVG has no visible effect. I'm not even sure if the mask is the 
cause of the corners. Even the shadows patch still has some visual artifacts in 
the corners: F7982336: Screenshot_20200128_004638.PNG 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26955

To: ndavis, #vdg, #plasma
Cc: niccolove, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks visually broken in the exact same way in Plasma Theme Explorer, so I 
suspect the test code was lifted from it which explains why it's broken in the 
test.
  
  Looks perfect in D26271 . Shipit!
  
  Then let's go fix the test and Plasma Theme Explorer lol

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  checkbox-radiobutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D26955: Fix background SVG colors and adjust background SVG corners

[Nathaniel Graham]

ngraham added a comment.


  This fixes the color bug, so that's good. :)
  
  However with Breeze Dark, now I see pointy corners and very weak shadows: 
F7982216: Screenshot_20200127_221203.png 
  
  ...Whereas with the Breeze and Breeze Light plasma style, I see nice shadows 
and rounded corners : F7982219: Screenshot_20200127_221718.png 

  
  (and yes I cleared the plasma SVG cache)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26955

To: ndavis, #vdg, #plasma
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26955: Fix background SVG colors and adjust background SVG corners

[Noah Davis]

ndavis retitled this revision from "Fix background colors and adjust background 
corners" to "Fix background SVG colors and adjust background SVG corners".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26955

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis added a comment.


  In D26758#601675 , @ngraham wrote:
  
  > I'd like to be able to verify that by looking at a radio button in the 
Plasma style but I can't actually find any. Do you know of any place where 
they're used?
  
  
  plasmathemeexplorer, also D26271 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[Nathaniel Graham]

ngraham added a comment.


  I'd like to be able to verify that by looking at a radio button in the Plasma 
style but I can't actually find any. Do you know of any place where they're 
used?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D26858: Provide an implementation for the tablet interface

[Aleix Pol Gonzalez]

apol updated this revision to Diff 74473.
apol added a comment.


  clang format

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26858?vs=74241=74473

BRANCH
  apol/tablet-unstable-v2-1

REVISION DETAIL
  https://phabricator.kde.org/D26858

AFFECTED FILES
  CMakeLists.txt
  autotests/server/CMakeLists.txt
  autotests/server/test_tablet_interface.cpp
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/tablet_interface.cpp
  src/server/tablet_interface.h

To: apol, #kwin, #frameworks, zzag
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 101 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/101/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 28 Jan 2020 01:50:54 +
 Build duration:
1 min 52 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis added a comment.


  In case it's not clear or for anyone skimming the conversation, I think the 
tests themselves are broken and can't be relied upon because they break things 
that normally work OK or at least better than they do in the tests. I don't 
know QML that well, but I don't see any obvious problems in the code of the 
tests.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis added a comment.


  In D26758#601535 , @ngraham wrote:
  
  > Found one small regression in the test suite. The new correct radio button 
sizing results in vertical misalignment (for both PC2 and PC3):
  >
  > Status quo: F7978647: Screenshot_20200127_112436.PNG 

  >
  > With patch: F7978654: Screenshot_20200127_112559.PNG 

  >
  > Everything else looked good to me. Fix that, then let's ship it.
  
  
  I'm pretty sure that test is broken too.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D26955: Fix background colors and adjust background corners

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The shadows patch before this patch had some problems with the SVGs that 
caused dark themes to be light. This fixes that and also makes the corner 
radius exactly the same as in the Breeze widget style.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-backgrounds (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26955

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg
  src/desktoptheme/breeze/widgets/panel-background.svg
  src/desktoptheme/breeze/widgets/tooltip.svg

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26167: Update holidays and add flagdays and namedays for Sweden

[Allen Winter]

winterz accepted this revision.
winterz added a comment.
This revision is now accepted and ready to land.


  looks fine.
  I also tested and the changes don't break anything.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D26167

To: riiga, #kde_pim, winterz
Cc: ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:87471e14b370: QXmlInputSource is deprecated in qt5.15. 
Port it to QXmlStreamReader (authored by mlaurent).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26890?vs=74428=74460

REVISION DETAIL
  https://phabricator.kde.org/D26890

AFFECTED FILES
  src/gui/kconfigloader.cpp
  src/gui/kconfigloaderhandler_p.h

To: mlaurent, dfaure, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26952: Make tags:/ ioslave not writable

[Stefan Brüns]

bruns added a comment.


  The idea was to assign a tag to a file by dropping a (multiple) file into a 
tag folder, and that somewhat works.
  
  But you can also "delete" a file from a tags folder, which is semantically 
overloaded in a bad way:
  
  - it just removes the tag (you can not delete the item itself)
  - it warns (in dolphin) you are deleting the item permanently.
  
  F7979976: Screenshot_20200127_204337.png 

  
  As this whole nonsense is backed by a lot of code I am in favor of making the 
tags: ioslave strictly readonly.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26952

To: meven, ngraham, #baloo
Cc: bruns, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D26948: [KColorSchemeManager] Don't list duplicates

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  duplicates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26948

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26951: Remove old code that is not used anymore

[David Redondo]

davidre added a comment.


  If it's still something we ship than I think it is better to just change the 
comment

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26951

To: davidre, dfaure, ervin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26952: Make tags:/ ioslave not writable

[Nathaniel Graham]

ngraham added a comment.


  Agreed.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26952

To: meven, ngraham, #baloo
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26952: Make tags:/ ioslave not writable

[Méven Car]

meven added a comment.


  In D26952#601525 , @ngraham wrote:
  
  > That's fine, but what has that got to do with creating a file or folder 
inside the `tags:/` ioslave? The concept of creating a file or folder inside a 
tag does not make conceptual sense; you apply tags to files and folders, but 
you don't create files and folders in tags.
  
  
  This `m_unassignedTags` is what is updated when the user create a dir in 
`tags:/`.
  But indeed subfolders for tags or files it tags:// make no sense.
  
  So I think we want  this`writing=false` and remove this clearly not 
functional way of creating a tag and conceptually not working.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26952

To: meven, ngraham, #baloo
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[Nathaniel Graham]

ngraham added a comment.


  Found one small regression in the test suite. The new correct radio button 
sizing results in vertical misalignment (for both PC2 and PC3):
  
  Status quo: F7978647: Screenshot_20200127_112436.PNG 

  
  With patch: F7978654: Screenshot_20200127_112559.PNG 

  
  Everything else looked good to me. Fix that, then let's ship it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D26952: Make tags:/ ioslave not writable

[Nathaniel Graham]

ngraham added a comment.


  That's fine, but what has that got to do with creating a file or folder 
inside the `tags:/` ioslave? The concept of creating a file or folder inside a 
tag does not make conceptual sense; you apply tags to files and folders, but 
you don't create files and folders in tags.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26952

To: meven, ngraham, #baloo
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26952: Make tags:/ ioslave not writable

[Méven Car]

meven added a comment.


  In D26952#601513 , @ngraham wrote:
  
  > You should be able to create tags, but how does it make any sense to be 
able to create a file or folder in the `tags:/` view? What does that even mean? 
Where does it end up living? What's it for? That's what the bug report is all 
about.
  
  
  Currently the ioslave instances keep a list of yet unused tags 
(`m_unassignedTags`), but that list is not persisted and hence quite volatile, 
each instances of the ioslave keeping its own list.
  AFAIK baloo has no way to persist tags without associated files.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26952

To: meven, ngraham, #baloo
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26952: Make tags:/ ioslave not writable

[Nathaniel Graham]

ngraham added a comment.


  You should be able to create tags, but how does it make any sense to be able 
to create a file or folder in the `tags:/` view? What does that even mean? 
Where does it end up living? What's it for? That's what the bug report is all 
about.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26952

To: meven, ngraham, #baloo
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26931: Introduce SPDX license headers

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D26931#601508 , @cgiboudeaux 
wrote:
  
  > In D26931#601505 , @cordlandwehr 
wrote:
  >
  > > Convert to SPDX-FileCopyrightText tags
  >
  >
  > some files have  by , can I suggest removing this "by"?
  
  
  same question for the extra spaces between authors and email addresses in a 
couple files

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D26931

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26931: Introduce SPDX license headers

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D26931#601505 , @cordlandwehr 
wrote:
  
  > Convert to SPDX-FileCopyrightText tags
  
  
  some files have  by , can I suggest removing this "by"?

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D26931

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Introducing SPDX License Headers

[Andreas Cord-Landwehr]

On Montag, 27. Januar 2020 01:35:07 CET Vlad Zahorodnii wrote:
> Hi,
> 
> On 1/26/20 7:59 PM, Andreas Cord-Landwehr wrote:
> > Does this approach sound reasonable? If anybody wants to review my
> > conversion tool and the license-header-to-SPDX-translations, I am happy
> > for feedback!
> +1
> 
> It appears like the SPDX markers are not used in the source code of your
> licensedigger tool ;-). It would be great to have an option or something
> that could be used to replace all instances of "Copyright (C)" with
> "SPDX-FileCopyrightText:" for consistency sake.

Thanks for the hint! I actually saved the conversion fun for the moment "when 
the tool finally works" and totally forgot about it ;) Now the tool also uses 
SPDX markers. But because of all the differently licensed test files, the reuse 
lint tool will not become happy.
Moreover, I updated the pull request to also convert the existing copyright 
statements.

Cheers,
Andreas

D26931: Introduce SPDX license headers

[Andreas Cord-Landwehr]

cordlandwehr updated this revision to Diff 74452.
cordlandwehr added a comment.


  Convert to SPDX-FileCopyrightText tags

REPOSITORY
  R274 KIdleTime

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26931?vs=74400=74452

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26931

AFFECTED FILES
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/MIT.txt
  examples/KIdleTest.cpp
  examples/KIdleTest.h
  examples/main.cpp
  src/abstractsystempoller.cpp
  src/abstractsystempoller.h
  src/kidletime.cpp
  src/kidletime.h
  src/plugins/osx/macpoller.cpp
  src/plugins/osx/macpoller.h
  src/plugins/windows/windowspoller.cpp
  src/plugins/windows/windowspoller.h
  src/plugins/xscreensaver/xscreensaverbasedpoller.cpp
  src/plugins/xscreensaver/xscreensaverbasedpoller.h
  src/plugins/xsync/fixx11h.h
  src/plugins/xsync/xsyncbasedpoller.cpp
  src/plugins/xsync/xsyncbasedpoller.h
  src/widgetbasedpoller.cpp
  src/widgetbasedpoller.h

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26952: Make tags:/ ioslave not writable

[Méven Car]

meven abandoned this revision.
meven added a comment.


  Makes no sense tags:/ is supposed to be able to have mkdir

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26952

To: meven, ngraham, #baloo
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26951: Remove old code that is not used anymore

[David Edmundson]

davidedmundson added a comment.


  Does it affect:
  
  kwidgetsaddons/src/kselector.h:48
  
  (no idea what that is, just something grep found)

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26951

To: davidre, dfaure, ervin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26952: Make tags:/ ioslave not writable

[Méven Car]

meven created this revision.
meven added reviewers: ngraham, Baloo.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  BUG: 416819
  FIXED-IN: 5.67

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26952

AFFECTED FILES
  src/kioslaves/tags/tags.protocol

To: meven, ngraham, #baloo
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26951: Remove old code that is not used anymore

[David Redondo]

davidre created this revision.
davidre added reviewers: dfaure, ervin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  According to the comment it was for Qt3 support which we don't support 
anymore.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  unused (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26951

AFFECTED FILES
  src/kconfigdialogmanager.cpp

To: davidre, dfaure, ervin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis added a comment.


  Ping. This patch doesn't fix everything, but it's still an improvement over 
the current state.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Nathaniel Graham]

ngraham added a comment.


  Or maybe @niccolove would be interested? Could be an alternative to patches 
like D26944 , D26945 
, and D26946 
, and instead we sould just *remove* the 
extra margins and have everything use the theme's default margins.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: niccolove, martinsotirov, abetts, ndavis, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Nathaniel Graham]

ngraham added a subscriber: niccolove.
ngraham added a comment.


  Or maybe @niccolove would be interested?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: niccolove, martinsotirov, abetts, ndavis, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D26948: [KColorSchemeManager] Don't list duplicates

[David Redondo]

davidre added a reviewer: Frameworks.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26948

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26948: [KColorSchemeManager] Don't list duplicates

[David Redondo]

davidre created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Loading code taken from the colors KCM. Additionally it ensures that when 
color
  schemes with the same file name exist in multiple categories the right one is
  loaded.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  duplicates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26948

AFFECTED FILES
  src/kcolorschememanager.cpp

To: davidre
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  port_QXmlStreamReader (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26890

To: mlaurent, dfaure, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

[Laurent Montel]

mlaurent updated this revision to Diff 74428.
mlaurent added a comment.


  Use QStringRef here too

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26890?vs=74406=74428

BRANCH
  port_QXmlStreamReader (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26890

AFFECTED FILES
  src/gui/kconfigloader.cpp
  src/gui/kconfigloaderhandler_p.h

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kconfigloader.cpp:125
>  for (int i = 0; i < numAttrs; ++i) {
> -QString name = attrs.localName(i).toLower();
> +const QString name = attrs.at(i).name().toString().toLower();
>  if (name == QLatin1String("name")) {

You can use QStringRef::compare() in this if sequence over here too.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26890

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26858: Provide an implementation for the tablet interface

[Vlad Zahorodnii]

zzag added a comment.


  Looks good to me. There are still many coding style issues. I suggest to run 
`clang-format` over individual files in this patch and then adjust the most 
problematic places (I don't think there are that many).
  
  You could borrow a `.clang-format` file from 
https://github.com/KDE/extra-cmake-modules/blob/master/kde-modules/clang-format.cmake.
 Just make sure that `ColumnLimit` is set to 0.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26858

To: apol, #kwin, #frameworks, zzag
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Fwd: KDE CI: Administration » Dependency Build Applications stable-kf5-qt5 FreeBSDQt5.13 - Build # 49 - Still Failing!

[Christophe Giboudeaux]

On lundi 27 janvier 2020 10:30:38 CET Ben Cooksley wrote:
> Hi all,
> 
> Any ideas why this would have suddenly started to fail like this in KHTML?
> From what I can see there haven't been any changes in KHTML itself, so this
> would have to be a regression in another Framework/ECM...
> 
> (This isn't FreeBSD specific either, as a Linux build just tripped up on
> the exact same failure)
> 
> [...]
> /usr/home/jenkins/workspace/Administration/Dependency Build Applications
> stable-kf5-qt5 FreeBSDQt5.13/khtml/src/dom/dom_string.cpp:422:5: error:
> function-like macro 'COMPILER' is not defined

See https://cgit.kde.org/kjs.git/commit/?id=74cd1a49

Fwd: KDE CI: Administration » Dependency Build Applications stable-kf5-qt5 FreeBSDQt5.13 - Build # 49 - Still Failing!

[Ben Cooksley]

Hi all,

Any ideas why this would have suddenly started to fail like this in KHTML?
>From what I can see there haven't been any changes in KHTML itself, so this
would have to be a regression in another Framework/ECM...

(This isn't FreeBSD specific either, as a Linux build just tripped up on
the exact same failure)

Cheers,
Ben

-- Forwarded message -
From: CI System 
Date: Mon, Jan 27, 2020 at 9:40 PM
Subject: KDE CI: Administration » Dependency Build Applications
stable-kf5-qt5 FreeBSDQt5.13 - Build # 49 - Still Failing!
To: 


*BUILD FAILURE*
Build URL
https://build.kde.org/job/Administration/job/Dependency%20Build%20Applications%20stable-kf5-qt5%20FreeBSDQt5.13/49/
Project: Dependency Build Applications stable-kf5-qt5 FreeBSDQt5.13
Date of build: Mon, 27 Jan 2020 07:59:57 +
Build duration: 40 min and counting
* CONSOLE OUTPUT *
[...truncated 65798 lines...]
[2020-01-27T08:40:26.782Z]
/usr/home/jenkins/workspace/Administration/Dependency Build Applications
stable-kf5-qt5 FreeBSDQt5.13/khtml/src/rendering/render_style.h:1052:13:
warning: anonymous types declared in an anonymous union are an extension
[-Wnested-anon-types]
[2020-01-27T08:40:26.782Z] struct {
[2020-01-27T08:40:26.782Z] ^
[2020-01-27T08:40:26.782Z]
/usr/home/jenkins/workspace/Administration/Dependency Build Applications
stable-kf5-qt5 FreeBSDQt5.13/khtml/src/rendering/render_style.h:1093:13:
warning: anonymous types declared in an anonymous union are an extension
[-Wnested-anon-types]
[2020-01-27T08:40:26.782Z] struct {
[2020-01-27T08:40:26.782Z] ^
[2020-01-27T08:40:27.042Z]
/usr/home/jenkins/workspace/Administration/Dependency Build Applications
stable-kf5-qt5 FreeBSDQt5.13/khtml/src/ecma/kjs_context2d.cpp:721:1:
warning: private field 'id' is not used [-Wunused-private-field]
[2020-01-27T08:40:27.042Z] KJS_IMPLEMENT_PROTOFUNC(CanvasPatternFunction)
[2020-01-27T08:40:27.042Z] ^
[2020-01-27T08:40:27.042Z]
/usr/home/jenkins/install-prefix/include/KF5/kjs/lookup.h:414:13: note:
expanded from macro 'KJS_IMPLEMENT_PROTOFUNC'
[2020-01-27T08:40:27.042Z] int id; \
[2020-01-27T08:40:27.042Z] ^
[2020-01-27T08:40:27.307Z] 4 warnings generated.
[2020-01-27T08:40:27.307Z] [ 53%] Building CXX object
src/CMakeFiles/KF5KHtml.dir/ecma/kjs_clientrect.cpp.o
[2020-01-27T08:40:27.307Z]
/usr/home/jenkins/workspace/Administration/Dependency Build Applications
stable-kf5-qt5 FreeBSDQt5.13/khtml/src/ecma/kjs_scriptable.cpp:123:5:
warning: 'QWeakPointer' is deprecated [-Wdeprecated-declarations]
[2020-01-27T08:40:27.307Z] objExtension(owner), objId(objId), field(field),
type(t), refsByUs(1), tableKey(owner)
[2020-01-27T08:40:27.307Z] ^
[2020-01-27T08:40:27.307Z]
/usr/local/include/qt5/QtCore/qsharedpointer_impl.h:578:26: note:
'QWeakPointer' has been explicitly marked deprecated here
[2020-01-27T08:40:27.307Z] QT_DEPRECATED inline QWeakPointer(X *ptr) :
d(ptr ? Data::getAndRef(ptr) : nullptr), value(ptr)
[2020-01-27T08:40:27.307Z] ^
[2020-01-27T08:40:27.881Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Applications
stable-kf5-qt5 FreeBSDQt5.13/khtml/src/ecma/kjs_data.cpp:20:
[2020-01-27T08:40:27.881Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Applications
stable-kf5-qt5 FreeBSDQt5.13/khtml/src/ecma/kjs_data.h:22:
[2020-01-27T08:40:27.881Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Applications
stable-kf5-qt5 FreeBSDQt5.13/khtml/src/ecma/kjs_window.h:30:
[2020-01-27T08:40:27.881Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Applications
stable-kf5-qt5 FreeBSDQt5.13/khtml/src/khtmlpart_p.h:44:
[2020-01-27T08:40:27.881Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Applications
stable-kf5-qt5 FreeBSDQt5.13/khtml/src/html/html_formimpl.h:29:
[2020-01-27T08:40:27.881Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Applications
stable-kf5-qt5 FreeBSDQt5.13/khtml/src/html/html_imageimpl.h:29:
[2020-01-27T08:40:27.881Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Applications
stable-kf5-qt5 FreeBSDQt5.13/khtml/src/rendering/render_object.h:40:
[2020-01-27T08:40:27.881Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Applications
stable-kf5-qt5 FreeBSDQt5.13/khtml/src/rendering/render_style.h:50:
[2020-01-27T08:40:27.881Z]
/usr/home/jenkins/workspace/Administration/Dependency Build Applications
stable-kf5-qt5 FreeBSDQt5.13/khtml/src/rendering/SVGRenderStyle.h:180:13:
warning: anonymous types declared in an anonymous union are an extension
[-Wnested-anon-types]
[2020-01-27T08:40:27.881Z] struct {
[2020-01-27T08:40:27.881Z] ^
[2020-01-27T08:40:27.881Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Applications
stable-kf5-qt5 FreeBSDQt5.13/khtml/src/ecma/kjs_data.cpp:20:
[2020-01-27T08:40:27.881Z] In file included from

D26888: work around to fully support the windows backend

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> notifybysnore.cpp:165
>  
> -void NotifyBySnore::notifyDeferred(KNotification* notification)
> -{
> +Q_UNUSED(config);
>  QProcess *proc = new QProcess();

no `;` here

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26888

To: brute4s99, vonreth, broulik, #kde_connect
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

T11627: Improve KIO asynchronicity

[Méven Car]

meven added a comment.


  In T11627#206210 , @broulik wrote:
  
  > I'm pretty sure there's a tonne of blocking DBus calls being done all over 
the place during file copy (checking for slaves on hold, updating kuiserver job 
tracking info, etc) which can cause apps to hang or slow down if whatever 
they're trying to call into is busy. Best example: SIGSTOP plasmashell, try 
copying a file in Dolphin, won't work until plasmashell SIGCONTs.
  
  
  That's interesting, we need to fix that.
  
  About https://bugs.kde.org/show_bug.cgi?id=281270 `Inconsistent notifications 
during/after file operations (copying, moving, deleting, compressing, 
extracting) depending on amount of data/items involved` :
  
  A possible way to fix this would probably use sendfile with O_NONBLOCK + 
select.
  After a non-blocking sendfile we call select/pselect on the dest file 
descriptor. Then when it returns something other than EWOULDBLOCK, we can 
deduce the processed bytes from the size sent to copy to dest (i.e sendfile 
count parameter) or use pselect and its sigset_t parameter. We then can call 
sendfile again to write next bytes.
  On the plus side it would make the code async which would make progress 
reporting more reactive.

TASK DETAIL
  https://phabricator.kde.org/T11627

To: meven
Cc: broulik, ognarb, #dolphin, #frameworks, meven, dfaure, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov