D27158: Fix some compiler warnings

[Ahmad Samir]

ahmadsamir updated this revision to Diff 75028.
ahmadsamir added a comment.


  Add missing space after ,

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27158?vs=75009&id=75028

BRANCH
  l-compiler-warnings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27158

AFFECTED FILES
  src/core/kconfig.cpp
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/kconfig_compiler.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27157: [KConfigLoader] Code cleanup

[Ahmad Samir]

ahmadsamir updated this revision to Diff 75029.
ahmadsamir added a comment.


  Tweak commit message

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27157?vs=75008&id=75029

BRANCH
  l-configloader (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27157

AFFECTED FILES
  src/gui/kconfigloader.cpp
  src/gui/kconfigloaderhandler_p.h

To: ahmadsamir, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26749: WIP: Support NDK r20 and Qt 5.14

[Volker Krause]

vkrause added a comment.


  Excellent news! Could you post your Kirigami patch somewhere maybe? Makes 
this easier to test here :)
  
  For icons we probably need a similar adjustment, I bet they got affected by 
the same Qt change. Same for translations I think, in ki18n.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D26749

To: vkrause
Cc: flherne, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D27148: update d->m_file in ReadOnlyPart::setUrl()

[Ahmad Samir]

ahmadsamir added a comment.


  IIUC, this diff is fixing https://bugs.kde.org/show_bug.cgi?id=416989 
(Konqueror -> Tools -> open terminal, doesn't work after D26140 
).
  
  Looking at the code in dolphin/src/dolphinpart.cpp, openUrl() is 
reimplemented[1], and it does call ReadOnlyPart::setUrl(); how about checking 
if url is a local file and calling ReadOnlyPart::setLocalFilePath() in 
DolphinPart::openUrl()?
  
  [1] https://cgit.kde.org/dolphin.git/tree/src/dolphinpart.cpp#n300

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D27148

To: pdabrowski, elvisangelaccio, ngraham, #frameworks, dfaure
Cc: ahmadsamir, marten, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> KConfigSourceGenerator.cpp:335
> +// TODO : what happened when same group is repeated ?
> +if (mCurrentGroup.contains(QStringLiteral("\u241D"))) {
> +stream() << "  " << itemPath(entry, cfg()) << "->setGroup(cg" << 
> QString(entry->group.split(QStringLiteral("\u241D")).last()).remove(QRegExp(QStringLiteral("\\W")))
>  << ");\n";

This character won't be easy on the user.
Ideally we perhaps would want to allow users to add  

We could use alternatively attributes.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 75032.
crossi added a comment.


  remove TODO comment that was addressed

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=74938&id=75032

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> meven wrote in KConfigSourceGenerator.cpp:335
> This character won't be easy on the user.
> Ideally we perhaps would want to allow users to add  
> 
> We could use alternatively attributes.

I'm open for another separator, btw this part is not intended for the user, 
they have super user friendly KCM to edit their settings.

Adding nested  as you mentioned has bigger impact on compiler, xsd, and 
so on.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> crossi wrote in KConfigSourceGenerator.cpp:335
> I'm open for another separator, btw this part is not intended for the user, 
> they have super user friendly KCM to edit their settings.
> 
> Adding nested  as you mentioned has bigger impact on compiler, xsd, 
> and so on.

Here, I meant kcfg user, i.e dev users, since kconfig is a lib

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27028: Switch from download.k.o to autoconfig

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 75044.
leinir marked an inline comment as done.
leinir added a comment.


  During some cleanup and addition, i realised it was silly to have
  the documentation for knsrc files in the widgets bits, and in two
  places. In addition, those places were both at least a bit wrong,
  or outdated, and needed fixing anyway, so... consolidate all that
  into the README.md file, as it's fairly central anyway. More could
  reasonably be done with that section, but this is already better.
  
  - Move the knsrc documentation to the central doc (as it's vital)
  - Minor doc fix for engine (which suggested a knsrc version 2 file)

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27028?vs=74896&id=75044

BRANCH
  fix-dko-overload-by-switching-to-autoconfig (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27028

AFFECTED FILES
  README.md
  src/core/cache.cpp
  src/core/engine.h
  src/downloaddialog.h
  src/downloadwidget.h
  tests/khotnewstuff.knsrc
  tests/khotnewstuff_upload.knsrc

To: leinir, bcooksley, #frameworks
Cc: meven, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D27028: Switch from download.k.o to autoconfig

[Dan Leinir Turthra Jensen]

leinir added a reviewer: KNewStuff.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D27028

To: leinir, bcooksley, #frameworks, #knewstuff
Cc: meven, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Benjamin Port]

bport accepted this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> managedconfigmodule.cpp:145-146
> +
> +auto settingsChangedSlotIndex = 
> metaObject()->indexOfMethod("settingsChanged()");
> +auto settingsChangedSlot = 
> metaObject()->method(settingsChangedSlotIndex);
> +

Those calls are done for each skeleton perhaps we can do only one call

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

crossi updated this revision to Diff 75052.
crossi added a comment.


  rebase

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26046?vs=74128&id=75052

REVISION DETAIL
  https://phabricator.kde.org/D26046

AFFECTED FILES
  src/quickaddons/managedconfigmodule.cpp
  src/quickaddons/managedconfigmodule.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Benjamin Port]

bport accepted this revision.
bport added inline comments.

INLINE COMMENTS

> bport wrote in managedconfigmodule.cpp:145-146
> Those calls are done for each skeleton perhaps we can do only one call

registerSettings is not on the hot path, so it will be ok

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:7c4f46aded18: Allow ManagedConfigModule derived class to 
register explicitly… (authored by crossi).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26046?vs=75052&id=75053

REVISION DETAIL
  https://phabricator.kde.org/D26046

AFFECTED FILES
  src/quickaddons/managedconfigmodule.cpp
  src/quickaddons/managedconfigmodule.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/75/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 05 Feb 2020 14:22:20 +
 Build duration:
2 min 15 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 75059.
crossi added a comment.


  update tests

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=75056&id=75059

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 75056.
crossi added a comment.


  fix compiling error for kcfgfile arg="true"

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=75032&id=75056

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27148: update d->m_file in ReadOnlyPart::setUrl()

[Jonathan Marten]

marten added a comment.


  @ahmadsamir: Yes, the problem could be fixed in Dolphin, but that leaves a 
potential trap for any other KPart that reimplements openUrl().
  
  As a minimum, if it is decided that the fix belongs in the application then 
KParts::ReadOnlyPart should have a caution in the API documentation that 
localFilePath() will only return a valid result if openUrl() or 
setLocalFilePath() has previously been called.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D27148

To: pdabrowski, elvisangelaccio, ngraham, #frameworks, dfaure
Cc: ahmadsamir, marten, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D27148: update d->m_file in ReadOnlyPart::setUrl()

[Ahmad Samir]

ahmadsamir added a comment.


  I thought of making ReadOnlyPart::setUrl() set d->m_file if the url is a 
local file... but I am guessing d->m_file and d->m_url are kept separate on 
purpose, so the idea seemed a bit off.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D27148

To: pdabrowski, elvisangelaccio, ngraham, #frameworks, dfaure
Cc: ahmadsamir, marten, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

License Statement Clarification in KArchive

[Andreas Cord-Landwehr]

Hi David,

during the SPDX license marker introduction into KArchive we found the 
following two files in KArchive with ambiguous license statements, which mix 
LGPL and GPL terms:

https://cgit.kde.org/karchive.git/tree/src/krcc.cpp
https://cgit.kde.org/karchive.git/tree/src/krcc.h

For both files you are listed as the only copyright holder and I reviewed that 
all other changes seem to be below the border of copyright holding.
Can you clarify the meaning of the license and/or comment in the follow 
https://phabricator.kde.org/D27104 ?

My suggested reading of this license is:

SPDX-License-Identifier: LGPL-2.0-only OR LGPL-3.0-only OR LicenseRef-KDE-
Accepted-LGPL

Best regards,
Andreas

D27104: Convert license statements to SPDX headers

[Andreas Cord-Landwehr]

cordlandwehr added a comment.


  Thanks for the review, I requested David to clarify the license statement. 
(Unfortunately, exact this license statement is also used in different 
frameworks, but we will have to solve those issues when coming to there.)

INLINE COMMENTS

> cgiboudeaux wrote in krcc.h:4
> The original license doesn't make sense.
> 
> If it's LGPL-2.0 or LGPL-3.0, the GPL 3 clause cannot be invoked
> 
> This needs some code archeology to understand where the issue comes from

Initially I thought that the text can be interpret directly in this sense, but 
after double-checking I agree with your reading.
I sent a mail to the frameworks list, asking David for clarification of the 
license.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D27104

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

About SPDX Header Reviews

[Andreas Cord-Landwehr]

Hi, I was asked to write about the starting (long) list of SPDX header 
conversion review requests and how deeply to review them.

Here is my opinion -- and please feel free to take even a complete different
opinion ;) -- about this:
I am using a mostly automated conversion tooling for doing the conversion. But 
as for any other tooling, there are and will be errors; either by me tagging a 
license header with the wrong SPDX expression or a simple programming mistake. 
Thus, I would like to see the first couple of reviews as beta-test candidates 
and would be very happy about an intense review (I review everything by 
myself, but by myself it is always hard to spot my errors).
Any finding will result in a new test case and thus will make the conversion 
tooling more stable, like the remark in the KArchive conversion that some 
original license statements are ambiguous and have to be clarified with the 
authors. Thus one might relax more with later reviews, but that is a very 
personal choice.

Cheers,
Andreas

D27106: Convert license statements to SPDX markers

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> COPYING:485
>  
> -This library is free software; you can redistribute it and/or
> -modify it under the terms of the GNU Lesser General Public
> -License as published by the Free Software Foundation; either
> -version 2.1 of the License, or (at your option) any later version.
> -
> -This library is distributed in the hope that it will be useful,
> -but WITHOUT ANY WARRANTY; without even the implied warranty of
> -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -Lesser General Public License for more details.
> -
> -You should have received a copy of the GNU Lesser General Public
> -License along with this library; if not, write to the Free Software
> -Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  
> USA
> +SPDX-License-Identifier: LGPL-2.1-or-later
>  

The license shall not be altered :)

> LicenseRef-KDE-Accepted-LGPL.txt:13
> +GNU General Public License for more details.
> \ No newline at end of file


missing new line.

> comment.h:4-5
>  
> -Copyright (c) 2010 Intel Corporation
> -Author: Mateu Batle Sastre 
> -
> -This library is free software; you can redistribute it and/or
> -modify it under the terms of the GNU Lesser General Public
> -License as published by the Free Software Foundation; either
> -version 2.1 of the License, or (at your option) version 3, or any
> -later version accepted by the membership of KDE e.V. (or its
> -successor approved by the membership of KDE e.V.), which shall
> -act as a proxy defined in Section 6 of version 3 of the license.
> -
> -This library is distributed in the hope that it will be useful,
> -but WITHOUT ANY WARRANTY; without even the implied warranty of
> -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -Lesser General Public License for more details.
> -
> -You should have received a copy of the GNU Lesser General Public
> -License along with this library.  If not, see 
> .
> +SPDX-FileCopyrightText: 2010 Intel Corporation
> +SPDX-FileCopyrightText: 2010 Mateu Batle Sastre 
> +

I understand something different: the copyright holder is "Intel corporation", 
Mateu Batle Sastre is a file contributor.

See the FileContributor property: 
https://spdx.org/rdf/terms/dataproperties/fileContributor___-1635717172.html

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D27106

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27092: Update license statements to SPDX identifiers

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  +1 LGTM

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D27092

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27178: Use ecm_qt_install_logging_categories over manual categories file

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Build System, Frameworks, broulik, mlaurent.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

TEST PLAN
  Entries of generated file match existing file, besides order and
  header comments, unless plugin not build, and also for
  ISpellChecker & NSSpellChecker (missing so far)

REPOSITORY
  R246 Sonnet

BRANCH
  generateqtlogcatfile

REVISION DETAIL
  https://phabricator.kde.org/D27178

AFFECTED FILES
  CMakeLists.txt
  sonnet.categories
  src/CMakeLists.txt
  src/core/CMakeLists.txt
  src/plugins/aspell/CMakeLists.txt
  src/plugins/hspell/CMakeLists.txt
  src/plugins/hunspell/CMakeLists.txt
  src/plugins/ispellchecker/CMakeLists.txt
  src/plugins/nsspellchecker/CMakeLists.txt
  src/plugins/voikko/CMakeLists.txt
  src/ui/CMakeLists.txt

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 75069.
kossebau added a comment.


  in doc also be explicit that ecm_qt_install_logging_categories can be in
  another directory, just needs to be called last

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27150?vs=74973&id=75069

BRANCH
  addautomaticcategoriesgeneration

REVISION DETAIL
  https://phabricator.kde.org/D27150

AFFECTED FILES
  modules/ECMQtDeclareLoggingCategory.cmake
  tests/ECMQtDeclareLoggingCategoryTest/CMakeLists.txt
  tests/ECMQtDeclareLoggingCategoryTest/log.categories

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

[Friedrich W. H. Kossebau]

kossebau added a dependent revision: D27178: Use 
ecm_qt_install_logging_categories over manual categories file.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D27150

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D27178: Use ecm_qt_install_logging_categories over manual categories file

[Friedrich W. H. Kossebau]

kossebau added a dependency: D27150: Add ecm_qt_install_logging_categories & 
ecm_qt_export_logging_category.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D27178

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27178: Use ecm_qt_install_logging_categories over manual categories file

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Another example, here with categories declared in different directories, yet 
a single place where the categories file is generated and installed.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D27178

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27017: [KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation

[Noah Davis]

ndavis added a comment.


  Any more suggestions?

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D27017

To: ndavis, #frameworks, dfaure
Cc: mwoehlke, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 290 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/290/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 06 Feb 2020 04:40:16 +
 Build duration:
8 min 37 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27185: Use the right translation catalog to show translations

[Yuri Chornoivan]

yurchor created this revision.
yurchor added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
yurchor requested review of this revision.

REVISION SUMMARY
  Now translations for QML are not shown. Patch by Victor Ryzhykh

TEST PLAN
  Run the new KNewStuff window using some locale (pt, uk, sv, etc.)

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27185

AFFECTED FILES
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/FeedbackOverlay.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

To: yurchor, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Seems ok for me :)

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addautomaticcategoriesgeneration

REVISION DETAIL
  https://phabricator.kde.org/D27150

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns