D27321: Add status icons: data-error, data-warning, data-information

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R267 Oxygen Icons

BRANCH
  adddatastatusicons

REVISION DETAIL
  https://phabricator.kde.org/D27321

To: kossebau, #vdg, ndavis, andreask
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27272: Add status icons: data-error, data-warning, data-information

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Personally, I think emblems are fine, but I'm not going to hold up the 
KDevelop patch just because of that. They already existed in Papirus, the most 
popular 3rd party theme.
  
  The naming spec isn't that useful because there's nobody to enforce it and 
theme designers have to adapt to application designers, who often don't follow 
the naming spec.

REPOSITORY
  R266 Breeze Icons

BRANCH
  adddatastatusicons

REVISION DETAIL
  https://phabricator.kde.org/D27272

To: kossebau, #vdg, ndavis
Cc: #kdevelop, ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27153: port sftp to Result system to force serialization of error/finish condition

[Alexander Saoutkin]

feverfew requested changes to this revision.
feverfew added a comment.
This revision now requires changes to proceed.


  Good  stuff, I'll admit I kind of skimmed over the bits that were rewrites 
`error(...); return;` -> `Result::fail()`, I assume you've mapped correctly 
there. Only minor comments from me.

INLINE COMMENTS

> kio_sftp.cpp:145
>  KIO::fileoffset_t offset = -1;
>  while ((offset = QT_LSEEK(fd, pos, mode)) == EAGAIN);
>  return offset;

Technically unrelated to your changes, but does this even work? isn't the check 
supposed to be against `errno` in this case, not offset?

> kio_sftp.cpp:302
> +{
> +if (!result.success) {
> +error(result.error, result.errorString);

`if (result.success) { ...} else { ... } seems clearer to me

> kio_sftp.cpp:328
> +for (int iInt = 0; iInt < n; ++iInt) {
> +unsigned int i = static_cast(iInt); // can only be 
> >0
>  char echo;

I'm a bit confused, why is this necessary?

> kio_sftp.cpp:418
>  long long fileType = QT_STAT_REG;
> -long long size = 0LL;
> +uint64_t size = 0LL;
>  

Should then be changed from `0LL` to `0U`?

> kio_sftp.cpp:1493
>  
> -void sftpProtocol::close() {
> -closeWithoutFinish();
> -finished();
> +void SFTPInternal::close()
> +{

We should be calling `finished()` (or `Result::pass`) on `close()` IIRC? I'm 
not seeing it called.

> kio_sftp.h:77
> +void setHost(const QString , quint16 port, const QString& user, const 
> QString& pass);
> +Q_REQUIRED_RESULT Result get(const QUrl );
> +Q_REQUIRED_RESULT Result listDir(const QUrl );

TODO KF6 https://en.cppreference.com/w/cpp/language/attributes/nodiscard ?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27153

To: sitter, dfaure, feverfew
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27332: try to fix issue with ispellchecker on windows

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:6e2f32b931e3: fix segfault at exit (authored by cullmann).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27332?vs=75536=75646

REVISION DETAIL
  https://phabricator.kde.org/D27332

AFFECTED FILES
  src/plugins/ispellchecker/ispellcheckerclient.cpp
  src/plugins/ispellchecker/ispellcheckerclient.h
  src/plugins/ispellchecker/ispellcheckerdict.cpp
  src/plugins/ispellchecker/ispellcheckerdict.h

To: cullmann, #frameworks, vonreth
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

[Dominik Haumann]

dhaumann added a subscriber: cullmann.
dhaumann added a comment.


  Ok, I now fully got this, thanks for the explanation. And indeed without any 
left fill visual feedback is missing.
  
  What I wonder is how much of this needs to be configurable. We could also 
just make the left fill of 4 default or so.
  
  In any case, I think we should go forward with this patch. @cullmann your 
opinion?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27285

To: eudoxos, #vdg
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars

D27372: smb: disable mode bits getting forwarded to KIO

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice, this fixes the bug for me and I think the code change makes logical 
sense. I really appreciate these long comments.

REPOSITORY
  R320 KIO Extras

BRANCH
  bug414482

REVISION DETAIL
  https://phabricator.kde.org/D27372

To: sitter, ngraham
Cc: dfaure, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27315: Fix size of the header in GridViewKCM

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:d9b52d900471: Fix size of the header in GridViewKCM 
(authored by davidre).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27315?vs=75445=75642

REVISION DETAIL
  https://phabricator.kde.org/D27315

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

To: davidre, mart, broulik, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 79 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/79/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 13 Feb 2020 20:49:04 +
 Build duration:
1 min 23 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

D27385: [RFC] Return error instead of aborting when receiving an unexpected answer

[Nicolas Fella]

nicolasfella edited reviewers, added: Frameworks, dfaure, meven; removed: 
kiokiio.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27385

To: fifr, #frameworks, dfaure, meven, kiokiio
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27385: [RFC] Return error instead of aborting when receiving an unexpected answer

[Frank Fischer]

fifr retitled this revision from "Return error instead of aborting when 
receiving an unexpected answer" to "[RFC] Return error instead of aborting when 
receiving an unexpected answer".
fifr added a reviewer: kiokiio.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27385

To: fifr, kiokiio
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27385: Return error instead of aborting when receiving an unexpected answer

[Frank Fischer]

fifr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
fifr requested review of this revision.

REVISION SUMMARY
  If SlaveBase::waitForAnswer receives an unexpected subcommand it aborts by 
calling qFatal. However, an unexpected subcommand could be received due to 
external causes, hence the error should be handled properly instead of abort.
  
  BUG: 416895
  FIXED-IN: 5.68

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27385

AFFECTED FILES
  src/core/slavebase.cpp

To: fifr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

[Nathaniel Graham]

ngraham added a comment.


  So like this?
  
  F8101694: Screenshot_20200213_130357.png 

  
  Hmm, I'm not really sure. For one "timeout on server" is pretty jargonistic. 
Also, in this case, there is no server! I think the "Could not connect to host 
for " message is more user-friendly for this case. It also better 
matches what's suggested by the `ERR_CANNOT_CONNECT` name.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27378

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

[Harald Sitter]

sitter added a comment.


  Use an ip address that isn't used by anything. Failing to resolve the 
hostname is different from failing to contact an ip address i.e. "I dunno who 
this is" versus "you have called a number that has been disconnected or is no 
longer in service".

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27378

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

[Nathaniel Graham]

ngraham added a comment.


  I tested out this patch by unplugging the network cable to the machine 
hosting my samba share and then trying to connect to it in Dolphin using the 
saved location in my Places panel where I access it from 
(`smb://gaston@living-room-pc/Users/gaston/Desktop/`) , but I still see the 
same error message as before:
  
  F8101336: Before.png 
  
  Interestingly enough, if I connect to just the server 
(`smb://gaston@living-room-pc/`), I see a different error message:
  
  F8101340: Screenshot_20200213_103906.png 

  
  However I never see the new message. What am I doing wrong?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27378

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  same as the ftp does. in fact, also steal the error message qtcpsocket
  produces. effectively this makes smb://unavailableipaddress spit out
  exactly the same error as ftp://unavailableipaddress
  
  host unreachable being so vague, the pretty string continues to be vague
  as well unfortunately.
  
  BUG: 417166
  FIXED-IN: 20.08.0

TEST PLAN
  error upon accessing the unassigned address 192.168.1.99 is same between smb 
and ftp

REPOSITORY
  R320 KIO Extras

BRANCH
  bug417166

REVISION DETAIL
  https://phabricator.kde.org/D27378

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27377: map ECONNABORTED to ERR_CONNECTION_BROKEN

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  bug415436

REVISION DETAIL
  https://phabricator.kde.org/D27377

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27377: map ECONNABORTED to ERR_CONNECTION_BROKEN

[Nathaniel Graham]

ngraham added a comment.


  I think this is reasonable and at least a small improvement given the 
limitations at play here.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27377

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27354: Remove hardcoded colors

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1ed47e7c4188: Remove hardcoded colors (authored by 
niccolove).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27354?vs=75572=75629

REVISION DETAIL
  https://phabricator.kde.org/D27354

AFFECTED FILES
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27377: map ECONNABORTED to ERR_CONNECTION_BROKEN

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  seems the most reasonable candidate given the pretty strings in
  KIO::buildErrorString and the detailed causes in the detail function.
  
  this does not really improve the error message, but should dolphin
  ever learn to pick up details from detailedErrorStrings it would make
  diagnosing easier.
  
  ECONNABORTED can mean any number of things, so I guess a signle line
  error will always be incredibly vague.
  
  BUG: 415436
  FIXED-IN: 19.12.3

TEST PLAN
  hoping for the best!

REPOSITORY
  R320 KIO Extras

BRANCH
  bug415436

REVISION DETAIL
  https://phabricator.kde.org/D27377

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27376: Sync IndexerConfig on exit

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:a0f8e748159b: Sync IndexerConfig on exit (authored by 
davidedmundson).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27376?vs=75624=75625

REVISION DETAIL
  https://phabricator.kde.org/D27376

AFFECTED FILES
  src/lib/indexerconfig.cpp

To: davidedmundson, ervin, crossi, meven, bport
Cc: broulik, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D27376: Sync IndexerConfig on exit

[Kevin Ottens]

ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.


  damn!

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27376

To: davidedmundson, ervin, crossi, meven, bport
Cc: broulik, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D27376: Sync IndexerConfig on exit

[Kevin Ottens]

ervin added reviewers: ervin, crossi, meven, bport.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27376

To: davidedmundson, ervin, crossi, meven, bport
Cc: broulik, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D27376: Sync IndexerConfig on exit

[Kai Uwe Broulik]

broulik added a comment.


  +1 
  worksforme

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27376

To: davidedmundson
Cc: broulik, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D27376: Sync IndexerConfig on exit

[David Edmundson]

davidedmundson created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  KCoreConfigSkeleton, unlike KConfig does not automagically save on exit.
  
  BUG: 417127

TEST PLAN
  balooctl disable
  balooctl enable

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27376

AFFECTED FILES
  src/lib/indexerconfig.cpp

To: davidedmundson
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27372: smb: disable mode bits getting forwarded to KIO

[Harald Sitter]

sitter added a subscriber: dfaure.
sitter added a comment.


  @dfaure btw, it seems you cannot have no ACL displayed. i.e. properties 
dialog does `d->hasExtendedACL = item.ACL().isExtended() || 
item.defaultACL().isValid();` but isExtended is even true for invalid ACLs, so 
in the smb scenario I have neither modes nor ACLs so it is effectively `KACL()` 
which is invalid but still isExtended for some reason. Not sure I'll find the 
motivation to fix that any time soon but thought I should tell you at least :)

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27372

To: sitter, ngraham
Cc: dfaure, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27372: smb: disable mode bits getting forwarded to KIO

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  mode bits in libsmb_stat are fairly cheaply constructed. file and directory
  qualification is alright beyond that it is a bit of a shambles.
  specifically +W is set iff the DOS attribute READONLY isn't set, but
  that attribute doesn't mean what we think it means, at least not on
  NT+ systems. see exhaustive comment.
  
  long story short: we cannot represent mode bits accurately because NT's
  access controls simply do not map to posix mode bits. therefore I'm
  removing the mode setting for the udsentry, making all entries effectively
  writable.
  
  whether an entry truly is writable is hard to say anyway. specifically
  because SMB+NTFS have independent ACLs. so, the SMB ACL may allow a
  given user or group to do something, that doesn't mean they'll also
  have permissions on a file system level.
  
  BUG: 414482
  FIXED-IN: 19.12.3

TEST PLAN
  previously not writable shares as described in the bug report are now 
writable.
  permission dialog looks a bit meh now, it wasn't really designed around not 
knowing
  what the access situation is. gnome simply shows a "dunno what permissions we 
have" label
  instead of everything, that seems like a reasonable approach

REPOSITORY
  R320 KIO Extras

BRANCH
  bug414482

REVISION DETAIL
  https://phabricator.kde.org/D27372

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27357: Fix infinite recursion in xscreensaver plugin

[Kai Uwe Broulik]

broulik added a reviewer: Frameworks.

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D27357

To: alnikiforov, davidedmundson, broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27272: Add status icons: data-error, data-warning, data-information

[Friedrich W. H. Kossebau]

kossebau added a comment.


  @ndavis Hi, any chance this can sneak in your busy schedule the next days? :) 
Anyone else from the VDG who might have time to sponsor these icons to have 
them available with Breeze?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27272

To: kossebau, #vdg, ndavis
Cc: #kdevelop, ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27366: Construct NullEngine with KPluginMetaData()

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1dc36bc2cee4: Construct NullEngine with KPluginMetaData() 
(authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27366?vs=75604=75613

REVISION DETAIL
  https://phabricator.kde.org/D27366

AFFECTED FILES
  src/plasma/private/dataenginemanager.cpp

To: broulik, #plasma, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27366: Construct NullEngine with KPluginMetaData()

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27366

To: broulik, #plasma, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27246: add buho icon

[Carson Black]

cblack added a comment.


  In D27246#610777 , @ndavis wrote:
  
  > What is buho?
  
  
  Maui's note taking app

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27246

To: mbruchert, camiloh, #vdg, ndavis
Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D27246: add buho icon

[Noah Davis]

ndavis added a comment.


  What is buho?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27246

To: mbruchert, camiloh, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27357: Fix infinite recursion in xscreensaver plugin

[Aleksei Nikiforov]

alnikiforov added a comment.


  In D27357#610605 , @broulik wrote:
  
  > Neither the XSync nor the windows backend explicitly call 
`resumingFromIdle` in `simulateUserActivity`, so I think this should be fine.
  >  However, I don't know if that won't indirectly trigger it if the session 
was idle? Maybe we need to check if the session was idle and only then emit the 
signal.
  
  
  I'm not sure how exactly it works, but if session was idle, wouldn't function 
`screensaverActivated` be called on changing state? And it contains `emit 
resumingFromIdle()`:
  
  
https://phabricator.kde.org/source/kidletime/browse/master/src/plugins/xscreensaver/xscreensaverbasedpoller.cpp$37

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D27357

To: alnikiforov, davidedmundson, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27363: KHolidays: Convert license statements to SPDX expressions

[Christophe Giboudeaux]

cgiboudeaux added subscribers: winterz, cgiboudeaux.
cgiboudeaux added inline comments.

INLINE COMMENTS

> holidayregion.cpp:31
>  // Copied from qlocale_data_p.h and qlocale.h
> -// Copyright (C) 2014 Digia Plc and/or its subsidiary(-ies).
> +// SPDX-FileCopyrightText: 2014 Digia Plc and /or its subsidiary(-ies).
>  // To later be replaced by OpenCodes or public Qt api

I don't think it should be changed here

> lunarphase.cpp:6
>  
> -  Copyright (c) 1989, 1993  //krazy:exclude=copyright
> -  The Regents of the University of California.  All rights reserved.
> +SPDX-FileCopyrightText: 1989, 1993 The Regents of the University of 
> California. All rights reserved.
>  

This looks suspicious

@winterz ?

> holidayparserdriverplan.cpp:6-13
> +SPDX-FileCopyrightText: Preston Brown 
> +SPDX-FileCopyrightText: Reinhold Kainhofer 
>  
>  Portions contributed by
> -Peter Littlefield 
> -Armin Liebl 
> -Efthimios Mavrogeorgiadis 
> -Erwin Hugo Achermann 
> -
> -Major rewrite using Bison C++ skeleton:
> -Copyright 2010 John Layt 
> -
> -This library is free software; you can redistribute it and/or
> -modify it under the terms of the GNU Library General Public
> -License as published by the Free Software Foundation; either
> -version 2 of the License, or (at your option) any later version.
> -
> -This library is distributed in the hope that it will be useful,
> -but WITHOUT ANY WARRANTY; without even the implied warranty of
> -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> -GNU Library General Public License for more details.
> -
> -You should have received a copy of the GNU Library General Public License
> -along with this library; see the file COPYING.LIB.  If not, write to the
> -Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> -Boston, MA 02110-1301, USA.
> +SPDX-FileCopyrightText: Peter Littlefield 
> +SPDX-FileCopyrightText: Armin Liebl 
> 
> +SPDX-FileCopyrightText: Efthimios Mavrogeorgiadis 

The original text lacks clarity. Are these file contributors or copyright 
holders? @winterz

> holidayparserdriverplan.cpp:15
> +
> +Major rewrite using Bison C++ skeleton by
> +SPDX-FileCopyrightText: 2010 John Layt 

why is "by" needed here?

> holidayparserplan.ypp:3-10
> +SPDX-FileCopyrightText: Thomas Driemeyer 
>  
>  Adapted for use in KOrganizer by
> -Preston Brown  and
> -Reinhold Kainhofer 
> +SPDX-FileCopyrightText: Preston Brown  and
> +SPDX-FileCopyrightText: Reinhold Kainhofer 
>  
>  Portions contributed by

same question for this file

> holidayscannerplan.cpp:1297-1301
>  Original version from plan by Thomas Driemeyer 
>  
>  Adapted for use in KOrganizer by
>  Preston Brown  and
>  Reinhold Kainhofer 

and these lines were not updated

> qcalendarsystem.cpp:833
>  \legalese
> -Copyright (c) 1989 The Regents of the University of California.
> +SPDX-FileCopyrightText: 1989 The Regents of the University of California 
> .
>  All rights reserved.

also looks wrong

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D27363

To: cordlandwehr
Cc: cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27065: Fix inverted logic in IOKitStorage::isRemovable

[René J . V . Bertin]

rjvbb added a comment.


  Sorry, no. Swamped with last-minute reconstruction efforts in the, erm, 
structure that's supposed to become my new house next week :-/

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27065

To: mwolff, #frameworks, rjvbb, cgilles
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27366: Construct NullEngine with KPluginMetaData()

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The deprecated constructor taking a `KPluginInfo` unconditionally calls 
`toMetaData()` and then asserts.
  
  BUG: 417557

TEST PLAN
  - Compiles. Can't actually reproduce the crash, even when I delete my 
geolocation dataengine

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27366

AFFECTED FILES
  src/plasma/private/dataenginemanager.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27351: call smb_cutime on the correct url to actually set mtime properly

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:aaedd983729f: smb: call smb_cutime on the correct url to 
actually set mtime properly (authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27351?vs=75557=75598

REVISION DETAIL
  https://phabricator.kde.org/D27351

AFFECTED FILES
  smb/kio_smb_dir.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27295: smb: support more advanced hidden file flag

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:e2eadb7555a6: smb: support more advanced hidden file flag 
(authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27295?vs=75387=75599

REVISION DETAIL
  https://phabricator.kde.org/D27295

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27291: install smb as both smb:// and cifs://

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:a5f51238fab7: smb: install smb as both smb:// and cifs:// 
(authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27291?vs=75382=75603

REVISION DETAIL
  https://phabricator.kde.org/D27291

AFFECTED FILES
  smb/CMakeLists.txt
  smb/kio_smb_browse.cpp
  smb/kio_smb_internal.cpp
  smb/smb.protocol
  smb/smb.protocol.cmake

To: sitter, dfaure, ngraham
Cc: meven, feverfew, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27292: set the share comment as UDS_COMMENT for the UI to display

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:dddafae55363: smb: set the share comment as UDS_COMMENT 
for the UI to display (authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27292?vs=75384=75602

REVISION DETAIL
  https://phabricator.kde.org/D27292

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter, ngraham
Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27352: retain atime properly

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:7f47119b22d5: smb: retain atime properly (authored by 
sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27352?vs=75558=75597

REVISION DETAIL
  https://phabricator.kde.org/D27352

AFFECTED FILES
  smb/kio_smb_dir.cpp

To: sitter, ngraham, meven
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27293: smb: do not map uid and gid

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:25a02064dbee: smb: do not map uid and gid (authored by 
sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27293?vs=75385=75601

REVISION DETAIL
  https://phabricator.kde.org/D27293

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27294: fix free space calculation

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:6832817f311b: smb: fix free space calculation (authored 
by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27294?vs=75386=75600

REVISION DETAIL
  https://phabricator.kde.org/D27294

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter, ngraham, meven
Cc: meven, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27245: Ki18n: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

cordlandwehr added a comment.


  Link to issue on reuse-tool tracker regarding empty lines in LGPL-3.0-only 
license text: https://github.com/fsfe/reuse-tool/issues/178

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D27245

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

cordlandwehr added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in LGPL-3.0-only.txt:15-17
> well, the SPDX text doesn't have these extra lines:
> https://spdx.org/licenses/LGPL-3.0-only.html#licenseText

Just tested again with the reuse tool and it actually provides the license with 
these empty lines. I will report an issue on the reuse tool's bug tracker. For 
now, I would prefer to stick with these (strange) empty lines and update the 
license text only when REUSE is updating their tooling.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D27245

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27065: Fix inverted logic in IOKitStorage::isRemovable

[Milian Wolff]

mwolff added a comment.


  ping? any update?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27065

To: mwolff, #frameworks, rjvbb, cgilles
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> cordlandwehr wrote in LGPL-3.0-only.txt:15-17
> Actually, I have no idea. But according to the REUSE specification, the 
> license files must no be changed and used exactly as provided by SPDX.
> All license files, except the LicenseRef files, of course, were downloaded 
> via the "reuse download" tool and thus are the unmodified versions as 
> provided by SPDX.

well, the SPDX text doesn't have these extra lines:
https://spdx.org/licenses/LGPL-3.0-only.html#licenseText

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D27245

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27363: KHolidays: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D27363

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27363: KHolidays: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license statements to SPDX markers and
  add license files as required by REUSE specification.

REPOSITORY
  R175 KHolidays

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27363

AFFECTED FILES
  LICENSES/BSD-2-Clause.txt
  LICENSES/Bison-exception-2.2.txt
  LICENSES/GPL-3.0-or-later.txt
  LICENSES/LGPL-2.0-or-later.txt
  autotests/testholidayregion.cpp
  autotests/testholidayregion.h
  autotests/testlunar.cpp
  autotests/testlunar.h
  autotests/testseasons.cpp
  autotests/testseasons.h
  autotests/testsunriseset.cpp
  autotests/testsunriseset.h
  autotests/testzodiac.cpp
  src/astroseasons.cpp
  src/astroseasons.h
  src/declarative/holidayregionsmodel.cpp
  src/declarative/holidayregionsmodel.h
  src/declarative/kholidaysdeclarativeplugin.cpp
  src/declarative/kholidaysdeclarativeplugin.h
  src/holiday.cpp
  src/holiday.h
  src/holiday_p.h
  src/holidayregion.cpp
  src/holidayregion.h
  src/lunarphase.cpp
  src/lunarphase.h
  src/parsers/holidayparserdriver.cpp
  src/parsers/holidayparserdriver_p.h
  src/parsers/plan2/FlexLexer.h
  src/parsers/plan2/holidayparserdriverplan.cpp
  src/parsers/plan2/holidayparserdriverplan_p.h
  src/parsers/plan2/holidayparserplan.cpp
  src/parsers/plan2/holidayparserplan.hpp
  src/parsers/plan2/holidayparserplan.ypp
  src/parsers/plan2/holidayscannerplan.cpp
  src/parsers/plan2/holidayscannerplan.lpp
  src/parsers/plan2/holidayscannerplan_p.h
  src/parsers/plan2/location.hh
  src/parsers/plan2/position.hh
  src/parsers/plan2/stack.hh
  src/parsers/qcalendarsystem.cpp
  src/parsers/qcalendarsystem_p.h
  src/sunriseset.cpp
  src/sunriseset.h
  src/zodiac.cpp
  src/zodiac.h

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Re: 2 kirigami fixes for a point release

[David Faure]

On jeudi 13 février 2020 09:46:20 CET David Edmundson wrote:
> > Kirigami seems to be rather unstable, I wonder if anything can be done to
> > improve upon that [*].
> 
> One important thing seems to have been getting sloppy in those repos;
> mandatory code reviews.
> That's an easy thing to enforce, and we know it makes a huge difference to
> code.
> 
> Even if no-one comments, the extra delay of it running on your own
> system delivers a lot.

I fully agree.

(CC'ing the developer lists)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D27245: Ki18n: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

cordlandwehr marked an inline comment as done.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D27245

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

cordlandwehr updated this revision to Diff 75592.
cordlandwehr added a comment.


  Remove unneeded whitespace

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27245?vs=75591=75592

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27245

AFFECTED FILES
  LICENSES/BSD-3-Clause.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/ki18ndeclarativetest.cpp
  autotests/klocalizedstringtest.cpp
  autotests/klocalizedstringtest.h
  autotests/ktranscriptcleantest.cpp
  autotests/ktranscriptcleantest.h
  autotests/ktranscripttest.cpp
  autotests/ktranscripttest.h
  autotests/testhelpers.cpp
  autotests/testhelpers.h
  cmake/FindLibIntl.cmake
  cmake/KF5I18nMacros.cmake.in
  cmake/build-pofiles.cmake
  cmake/build-tsfiles.cmake
  cmake/kf5i18nuic.cmake
  cmake/rules_PyKF5.py
  src/common_helpers.cpp
  src/common_helpers_p.h
  src/config.h.in
  src/gettext.h
  src/kcatalog.cpp
  src/kcatalog_p.h
  src/klocalizedcontext.cpp
  src/klocalizedcontext.h
  src/klocalizedstring.cpp
  src/klocalizedstring.h
  src/klocalizedtranslator.cpp
  src/klocalizedtranslator.h
  src/ktranscript.cpp
  src/ktranscript_p.h
  src/kuitmarkup.cpp
  src/kuitmarkup.h
  src/kuitmarkup_p.h
  src/kuitsetup.h
  src/main.cpp

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

cordlandwehr updated this revision to Diff 75591.
cordlandwehr added a comment.


  Unify license comment header style

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27245?vs=75246=75591

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27245

AFFECTED FILES
  LICENSES/BSD-3-Clause.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/ki18ndeclarativetest.cpp
  autotests/klocalizedstringtest.cpp
  autotests/klocalizedstringtest.h
  autotests/ktranscriptcleantest.cpp
  autotests/ktranscriptcleantest.h
  autotests/ktranscripttest.cpp
  autotests/ktranscripttest.h
  autotests/testhelpers.cpp
  autotests/testhelpers.h
  cmake/FindLibIntl.cmake
  cmake/KF5I18nMacros.cmake.in
  cmake/build-pofiles.cmake
  cmake/build-tsfiles.cmake
  cmake/kf5i18nuic.cmake
  cmake/rules_PyKF5.py
  src/common_helpers.cpp
  src/common_helpers_p.h
  src/config.h.in
  src/gettext.h
  src/kcatalog.cpp
  src/kcatalog_p.h
  src/klocalizedcontext.cpp
  src/klocalizedcontext.h
  src/klocalizedstring.cpp
  src/klocalizedstring.h
  src/klocalizedtranslator.cpp
  src/klocalizedtranslator.h
  src/ktranscript.cpp
  src/ktranscript_p.h
  src/kuitmarkup.cpp
  src/kuitmarkup.h
  src/kuitmarkup_p.h
  src/kuitsetup.h
  src/main.cpp

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

cordlandwehr added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in LGPL-3.0-only.txt:15-17
> why are there so many empty lines?

Actually, I have no idea. But according to the REUSE specification, the license 
files must no be changed and used exactly as provided by SPDX.
All license files, except the LicenseRef files, of course, were downloaded via 
the "reuse download" tool and thus are the unmodified versions as provided by 
SPDX.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D27245

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27103: KItemModels: Convert license headers to SPDX markers

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
Closed by commit R275:be32ab6c49f9: KItemModels: Convert license headers to 
SPDX markers (authored by cordlandwehr).

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27103?vs=75587=75588

REVISION DETAIL
  https://phabricator.kde.org/D27103

AFFECTED FILES
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-2.1-or-later.txt
  autotests/bihash/benchmarks.cpp
  autotests/bihash/functionalitytest.cpp
  autotests/kcolumnheadersmodeltest.cpp
  autotests/kconcatenaterows_qml.cpp
  autotests/kdescendantsproxymodel_smoketest.cpp
  autotests/kdescendantsproxymodeltest.cpp
  autotests/kextracolumnsproxymodeltest.cpp
  autotests/klinkitemselectionmodeltest.cpp
  autotests/klinkitemselectionmodeltest.h
  autotests/kmodelindexproxymappertest.cpp
  autotests/knumbermodeltest.cpp
  autotests/krearrangecolumnsproxymodeltest.cpp
  autotests/krecursivefilterproxymodeltest.cpp
  autotests/kselectionproxymodel_smoketest.cpp
  autotests/kselectionproxymodeltest.cpp
  autotests/kselectionproxymodeltestsuite.cpp
  autotests/kselectionproxymodeltestsuite.h
  autotests/proxymodeltestsuite/dynamictreemodel.cpp
  autotests/proxymodeltestsuite/dynamictreemodel.h
  autotests/proxymodeltestsuite/dynamictreewidget.cpp
  autotests/proxymodeltestsuite/dynamictreewidget.h
  autotests/proxymodeltestsuite/eventloggerregister.cpp
  autotests/proxymodeltestsuite/eventloggerregister.h
  autotests/proxymodeltestsuite/indexfinder.h
  autotests/proxymodeltestsuite/modelcommander.cpp
  autotests/proxymodeltestsuite/modelcommander.h
  autotests/proxymodeltestsuite/modeldumper.cpp
  autotests/proxymodeltestsuite/modeldumper.h
  autotests/proxymodeltestsuite/modeleventlogger.cpp
  autotests/proxymodeltestsuite/modeleventlogger.h
  autotests/proxymodeltestsuite/modelselector.cpp
  autotests/proxymodeltestsuite/modelselector.h
  autotests/proxymodeltestsuite/modelspy.cpp
  autotests/proxymodeltestsuite/modelspy.h
  autotests/proxymodeltestsuite/modeltest.cpp
  autotests/proxymodeltestsuite/modeltest.h
  autotests/proxymodeltestsuite/persistentchangelist.h
  autotests/proxymodeltestsuite/proxymodeltest.cpp
  autotests/proxymodeltestsuite/proxymodeltest.h
  autotests/test_model_helpers.h
  src/core/kbihash_p.h
  src/core/kbreadcrumbselectionmodel.cpp
  src/core/kbreadcrumbselectionmodel.h
  src/core/kcheckableproxymodel.cpp
  src/core/kcheckableproxymodel.h
  src/core/kcolumnheadersmodel.cpp
  src/core/kcolumnheadersmodel.h
  src/core/kconcatenaterowsproxymodel.cpp
  src/core/kconcatenaterowsproxymodel.h
  src/core/kdescendantsproxymodel.cpp
  src/core/kdescendantsproxymodel.h
  src/core/kextracolumnsproxymodel.cpp
  src/core/kextracolumnsproxymodel.h
  src/core/klinkitemselectionmodel.cpp
  src/core/klinkitemselectionmodel.h
  src/core/kmodelindexproxymapper.cpp
  src/core/kmodelindexproxymapper.h
  src/core/knumbermodel.cpp
  src/core/knumbermodel.h
  src/core/krearrangecolumnsproxymodel.cpp
  src/core/krearrangecolumnsproxymodel.h
  src/core/krecursivefilterproxymodel.cpp
  src/core/krecursivefilterproxymodel.h
  src/core/kselectionproxymodel.cpp
  src/core/kselectionproxymodel.h
  src/core/kvoidpointerfactory_p.h
  src/qml/kconcatenaterowsproxymodel_qml.cpp
  src/qml/kconcatenaterowsproxymodel_qml.h
  src/qml/plugin.cpp
  src/qml/plugin.h
  tests/proxymodeltestapp/breadcrumbdirectionwidget.cpp
  tests/proxymodeltestapp/breadcrumbdirectionwidget.h
  tests/proxymodeltestapp/breadcrumbnavigationwidget.cpp
  tests/proxymodeltestapp/breadcrumbnavigationwidget.h
  tests/proxymodeltestapp/breadcrumbswidget.cpp
  tests/proxymodeltestapp/breadcrumbswidget.h
  tests/proxymodeltestapp/checkablewidget.cpp
  tests/proxymodeltestapp/checkablewidget.h
  tests/proxymodeltestapp/descendantpmwidget.cpp
  tests/proxymodeltestapp/descendantpmwidget.h
  tests/proxymodeltestapp/kidentityproxymodelwidget.cpp
  tests/proxymodeltestapp/kidentityproxymodelwidget.h
  tests/proxymodeltestapp/kreparentingproxymodel.cpp
  tests/proxymodeltestapp/kreparentingproxymodel.h
  tests/proxymodeltestapp/lessthanwidget.cpp
  tests/proxymodeltestapp/lessthanwidget.h
  tests/proxymodeltestapp/main.cpp
  tests/proxymodeltestapp/mainwindow.cpp
  tests/proxymodeltestapp/mainwindow.h
  tests/proxymodeltestapp/matchcheckingwidget.cpp
  tests/proxymodeltestapp/matchcheckingwidget.h
  tests/proxymodeltestapp/modelcommanderwidget.cpp
  tests/proxymodeltestapp/modelcommanderwidget.h
  tests/proxymodeltestapp/proxyitemselectionwidget.cpp
  tests/proxymodeltestapp/proxyitemselectionwidget.h
  tests/proxymodeltestapp/proxymodeltestwidget.cpp
  tests/proxymodeltestapp/proxymodeltestwidget.h
  tests/proxymodeltestapp/recursivefilterpmwidget.cpp
  tests/proxymodeltestapp/recursivefilterpmwidget.h
  tests/proxymodeltestapp/reparentingpmwidget.cpp
  tests/proxymodeltestapp/reparentingpmwidget.h
  tests/proxymodeltestapp/scriptablereparentingwidget.cpp
  

D27103: KItemModels: Convert license headers to SPDX markers

[Andreas Cord-Landwehr]

cordlandwehr updated this revision to Diff 75587.
cordlandwehr added a comment.


  Remove unneeded whitespace

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27103?vs=75580=75587

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27103

AFFECTED FILES
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-2.1-or-later.txt
  autotests/bihash/benchmarks.cpp
  autotests/bihash/functionalitytest.cpp
  autotests/kcolumnheadersmodeltest.cpp
  autotests/kconcatenaterows_qml.cpp
  autotests/kdescendantsproxymodel_smoketest.cpp
  autotests/kdescendantsproxymodeltest.cpp
  autotests/kextracolumnsproxymodeltest.cpp
  autotests/klinkitemselectionmodeltest.cpp
  autotests/klinkitemselectionmodeltest.h
  autotests/kmodelindexproxymappertest.cpp
  autotests/knumbermodeltest.cpp
  autotests/krearrangecolumnsproxymodeltest.cpp
  autotests/krecursivefilterproxymodeltest.cpp
  autotests/kselectionproxymodel_smoketest.cpp
  autotests/kselectionproxymodeltest.cpp
  autotests/kselectionproxymodeltestsuite.cpp
  autotests/kselectionproxymodeltestsuite.h
  autotests/proxymodeltestsuite/dynamictreemodel.cpp
  autotests/proxymodeltestsuite/dynamictreemodel.h
  autotests/proxymodeltestsuite/dynamictreewidget.cpp
  autotests/proxymodeltestsuite/dynamictreewidget.h
  autotests/proxymodeltestsuite/eventloggerregister.cpp
  autotests/proxymodeltestsuite/eventloggerregister.h
  autotests/proxymodeltestsuite/indexfinder.h
  autotests/proxymodeltestsuite/modelcommander.cpp
  autotests/proxymodeltestsuite/modelcommander.h
  autotests/proxymodeltestsuite/modeldumper.cpp
  autotests/proxymodeltestsuite/modeldumper.h
  autotests/proxymodeltestsuite/modeleventlogger.cpp
  autotests/proxymodeltestsuite/modeleventlogger.h
  autotests/proxymodeltestsuite/modelselector.cpp
  autotests/proxymodeltestsuite/modelselector.h
  autotests/proxymodeltestsuite/modelspy.cpp
  autotests/proxymodeltestsuite/modelspy.h
  autotests/proxymodeltestsuite/modeltest.cpp
  autotests/proxymodeltestsuite/modeltest.h
  autotests/proxymodeltestsuite/persistentchangelist.h
  autotests/proxymodeltestsuite/proxymodeltest.cpp
  autotests/proxymodeltestsuite/proxymodeltest.h
  autotests/test_model_helpers.h
  src/core/kbihash_p.h
  src/core/kbreadcrumbselectionmodel.cpp
  src/core/kbreadcrumbselectionmodel.h
  src/core/kcheckableproxymodel.cpp
  src/core/kcheckableproxymodel.h
  src/core/kcolumnheadersmodel.cpp
  src/core/kcolumnheadersmodel.h
  src/core/kconcatenaterowsproxymodel.cpp
  src/core/kconcatenaterowsproxymodel.h
  src/core/kdescendantsproxymodel.cpp
  src/core/kdescendantsproxymodel.h
  src/core/kextracolumnsproxymodel.cpp
  src/core/kextracolumnsproxymodel.h
  src/core/klinkitemselectionmodel.cpp
  src/core/klinkitemselectionmodel.h
  src/core/kmodelindexproxymapper.cpp
  src/core/kmodelindexproxymapper.h
  src/core/knumbermodel.cpp
  src/core/knumbermodel.h
  src/core/krearrangecolumnsproxymodel.cpp
  src/core/krearrangecolumnsproxymodel.h
  src/core/krecursivefilterproxymodel.cpp
  src/core/krecursivefilterproxymodel.h
  src/core/kselectionproxymodel.cpp
  src/core/kselectionproxymodel.h
  src/core/kvoidpointerfactory_p.h
  src/qml/kconcatenaterowsproxymodel_qml.cpp
  src/qml/kconcatenaterowsproxymodel_qml.h
  src/qml/plugin.cpp
  src/qml/plugin.h
  tests/proxymodeltestapp/breadcrumbdirectionwidget.cpp
  tests/proxymodeltestapp/breadcrumbdirectionwidget.h
  tests/proxymodeltestapp/breadcrumbnavigationwidget.cpp
  tests/proxymodeltestapp/breadcrumbnavigationwidget.h
  tests/proxymodeltestapp/breadcrumbswidget.cpp
  tests/proxymodeltestapp/breadcrumbswidget.h
  tests/proxymodeltestapp/checkablewidget.cpp
  tests/proxymodeltestapp/checkablewidget.h
  tests/proxymodeltestapp/descendantpmwidget.cpp
  tests/proxymodeltestapp/descendantpmwidget.h
  tests/proxymodeltestapp/kidentityproxymodelwidget.cpp
  tests/proxymodeltestapp/kidentityproxymodelwidget.h
  tests/proxymodeltestapp/kreparentingproxymodel.cpp
  tests/proxymodeltestapp/kreparentingproxymodel.h
  tests/proxymodeltestapp/lessthanwidget.cpp
  tests/proxymodeltestapp/lessthanwidget.h
  tests/proxymodeltestapp/main.cpp
  tests/proxymodeltestapp/mainwindow.cpp
  tests/proxymodeltestapp/mainwindow.h
  tests/proxymodeltestapp/matchcheckingwidget.cpp
  tests/proxymodeltestapp/matchcheckingwidget.h
  tests/proxymodeltestapp/modelcommanderwidget.cpp
  tests/proxymodeltestapp/modelcommanderwidget.h
  tests/proxymodeltestapp/proxyitemselectionwidget.cpp
  tests/proxymodeltestapp/proxyitemselectionwidget.h
  tests/proxymodeltestapp/proxymodeltestwidget.cpp
  tests/proxymodeltestapp/proxymodeltestwidget.h
  tests/proxymodeltestapp/recursivefilterpmwidget.cpp
  tests/proxymodeltestapp/recursivefilterpmwidget.h
  tests/proxymodeltestapp/reparentingpmwidget.cpp
  tests/proxymodeltestapp/reparentingpmwidget.h
  tests/proxymodeltestapp/scriptablereparentingwidget.cpp
  tests/proxymodeltestapp/scriptablereparentingwidget.h
  

D27103: KItemModels: Convert license headers to SPDX markers

[Andreas Cord-Landwehr]

cordlandwehr marked an inline comment as done.

REPOSITORY
  R275 KItemModels

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27103

To: cordlandwehr, dfaure, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  some headers have 3 leading whitespaces, some 4. Can you clarify?

INLINE COMMENTS

> LGPL-3.0-only.txt:15-17
> +
> +  
> +

why are there so many empty lines?

> gettext.h:2
>  /* Convenience header for conditional use of GNU .
> -   Copyright (C) 1995-1998, 2000-2002, 2004-2006 Free Software Foundation, 
> Inc.
> -
> -   This program is free software; you can redistribute it and/or modify it
> -   under the terms of the GNU Library General Public License as published
> -   by the Free Software Foundation; either version 2, or (at your option)
> -   any later version.
> -
> -   This program is distributed in the hope that it will be useful,
> -   but WITHOUT ANY WARRANTY; without even the implied warranty of
> -   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -   Library General Public License for more details.
> -
> -   You should have received a copy of the GNU Library General Public
> -   License along with this program; if not, write to the Free Software
> -   Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301,
> -   USA.  */
> +   SPDX-FileCopyrightText: 1995-1998, 2000-2002, 2004-2006 Free Software 
> Foundation , Inc.
> +

extra space after "Free Software Foundation"

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D27245

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27106: Attica: Convert license statements to SPDX markers

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
Closed by commit R235:4db348a7bb1c: Attica: Convert license statements to SPDX 
markers (authored by cordlandwehr).

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27106?vs=75579=75586

REVISION DETAIL
  https://phabricator.kde.org/D27106

AFFECTED FILES
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/configtest.cpp
  autotests/persontest.cpp
  autotests/privatedatatest.cpp
  autotests/providertest.cpp
  src/accountbalance.cpp
  src/accountbalance.h
  src/accountbalanceparser.cpp
  src/accountbalanceparser.h
  src/achievement.cpp
  src/achievement.h
  src/achievementparser.cpp
  src/achievementparser.h
  src/activity.cpp
  src/activity.h
  src/activityparser.cpp
  src/activityparser.h
  src/atticabasejob.cpp
  src/atticabasejob.h
  src/atticautils.cpp
  src/atticautils.h
  src/buildservice.cpp
  src/buildservice.h
  src/buildservicejob.cpp
  src/buildservicejob.h
  src/buildservicejoboutput.cpp
  src/buildservicejoboutput.h
  src/buildservicejoboutputparser.cpp
  src/buildservicejoboutputparser.h
  src/buildservicejobparser.cpp
  src/buildservicejobparser.h
  src/buildserviceparser.cpp
  src/buildserviceparser.h
  src/category.cpp
  src/category.h
  src/categoryparser.cpp
  src/categoryparser.h
  src/cloud.cpp
  src/cloud.h
  src/cloudparser.cpp
  src/cloudparser.h
  src/comment.cpp
  src/comment.h
  src/commentparser.cpp
  src/commentparser.h
  src/config.cpp
  src/config.h
  src/configparser.cpp
  src/configparser.h
  src/content.cpp
  src/content.h
  src/contentparser.cpp
  src/contentparser.h
  src/deletejob.cpp
  src/deletejob.h
  src/distribution.cpp
  src/distribution.h
  src/distributionparser.cpp
  src/distributionparser.h
  src/downloaddescription.cpp
  src/downloaddescription.h
  src/downloaditem.cpp
  src/downloaditem.h
  src/downloaditemparser.cpp
  src/downloaditemparser.h
  src/event.cpp
  src/event.h
  src/eventparser.cpp
  src/eventparser.h
  src/folder.cpp
  src/folder.h
  src/folderparser.cpp
  src/folderparser.h
  src/forum.cpp
  src/forum.h
  src/forumparser.cpp
  src/forumparser.h
  src/getjob.cpp
  src/getjob.h
  src/homepageentry.cpp
  src/homepageentry.h
  src/homepagetype.cpp
  src/homepagetype.h
  src/homepagetypeparser.cpp
  src/homepagetypeparser.h
  src/icon.cpp
  src/icon.h
  src/itemjob.cpp
  src/itemjob.h
  src/knowledgebaseentry.cpp
  src/knowledgebaseentry.h
  src/knowledgebaseentryparser.cpp
  src/knowledgebaseentryparser.h
  src/license.cpp
  src/license.h
  src/licenseparser.cpp
  src/licenseparser.h
  src/listjob.cpp
  src/listjob.h
  src/listjob_inst.cpp
  src/message.cpp
  src/message.h
  src/messageparser.cpp
  src/messageparser.h
  src/metadata.cpp
  src/metadata.h
  src/parser.cpp
  src/parser.h
  src/person.cpp
  src/person.h
  src/personparser.cpp
  src/personparser.h
  src/platformdependent.h
  src/platformdependent_v2.cpp
  src/platformdependent_v2.h
  src/postfiledata.cpp
  src/postfiledata.h
  src/postjob.cpp
  src/postjob.h
  src/privatedata.cpp
  src/privatedata.h
  src/privatedataparser.cpp
  src/privatedataparser.h
  src/project.cpp
  src/project.h
  src/projectparser.cpp
  src/projectparser.h
  src/provider.cpp
  src/provider.h
  src/providermanager.cpp
  src/providermanager.h
  src/publisher.cpp
  src/publisher.h
  src/publisherfield.cpp
  src/publisherfield.h
  src/publisherfieldparser.cpp
  src/publisherfieldparser.h
  src/publisherparser.cpp
  src/publisherparser.h
  src/putjob.cpp
  src/putjob.h
  src/qtplatformdependent.cpp
  src/qtplatformdependent_p.h
  src/remoteaccount.cpp
  src/remoteaccount.h
  src/remoteaccountparser.cpp
  src/remoteaccountparser.h
  src/topic.cpp
  src/topic.h
  src/topicparser.cpp
  src/topicparser.h
  src/version.h.cmake
  tests/projecttest/main.cpp
  tests/projecttest/projecttest.cpp
  tests/projecttest/projecttest.h

To: cordlandwehr, cgiboudeaux
Cc: dfaure, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27332: try to fix issue with ispellchecker on windows

[Hannah von Reth]

vonreth accepted this revision.
vonreth added a comment.
This revision is now accepted and ready to land.


  looks good but in a future version of sonnet plugins should be unloaded when 
shutting down and we should properly unload stuff.

REPOSITORY
  R246 Sonnet

BRANCH
  arcpatch-D27332

REVISION DETAIL
  https://phabricator.kde.org/D27332

To: cullmann, #frameworks, vonreth
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D12283: Allow to load dictionaries form a rcc

[Hannah von Reth]

vonreth abandoned this revision.
vonreth added a comment.


  as we now have a native windows backend there is no point in this

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D12283

To: vonreth, mlaurent
Cc: ahmadsamir, kde-frameworks-devel, habacker, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

[whitequark]

catherinez added a comment.


  I do not.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D27356

To: catherinez, #kwin, davidedmundson
Cc: davidedmundson, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27352: retain atime properly

[Harald Sitter]

sitter added a comment.


  Oh I'm sorry, I thought this was the other time diff.
  
  In this case before the accessed time before the patch was flat out garbage 
https://bugsfiles.kde.org/attachment.cgi?id=121948 note the year **2106**

REPOSITORY
  R320 KIO Extras

BRANCH
  bug410624

REVISION DETAIL
  https://phabricator.kde.org/D27352

To: sitter, ngraham, meven
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Do you have commit access?

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D27356

To: catherinez, #kwin, davidedmundson
Cc: davidedmundson, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27357: Fix infinite recursion in xscreensaver plugin

[Kai Uwe Broulik]

broulik added a comment.


  Neither the XSync nor the windows backend explicitly call `resumingFromIdle` 
in `simulateUserActivity`, so I think this should be fine.
  However, I don't know if that won't indirectly trigger it if the session was 
idle? Maybe we need to check if the session was idle and only then emit the 
signal.

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D27357

To: alnikiforov, davidedmundson, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27357: Fix infinite recursion in xscreensaver plugin

[Aleksei Nikiforov]

alnikiforov created this revision.
alnikiforov added reviewers: davidedmundson, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
alnikiforov requested review of this revision.

REVISION SUMMARY
  Follow up for D27279 
  
  Related to: D17874 

TEST PLAN
  Test plan similar to D27279 , but 
powerdevil should no longer crash

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D27357

AFFECTED FILES
  src/plugins/xscreensaver/xscreensaverbasedpoller.cpp

To: alnikiforov, davidedmundson, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

[whitequark]

catherinez added a comment.


  Note that there are what I assume 3 more instances of a similar copy-paste 
error, for `DropdownMenu`, `PopupMenu`, and `Notification`. I didn't touch them 
because KDE is currently EWMH compliant for these window types, and because I 
lack the context to understand the consequences of such a change. (For example, 
if I fix `Notification` then it'll start triggering i3 rules for utility 
windows, which seems potentially problematic.)

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D27356

To: catherinez, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

[Kai Uwe Broulik]

broulik added a comment.


  Nice find!
  It appears the `DropdownMenu`, `PopupMenu`, and `Notification` type also 
incorrectly use a `len = 1`?

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D27356

To: catherinez, #kwin
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

[Kai Uwe Broulik]

broulik added a reviewer: KWin.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D27356

To: catherinez, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

[whitequark]

catherinez created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
catherinez requested review of this revision.

REVISION SUMMARY
  The EWMH specification for _NET_WM_WINDOW_TYPE states:
  
  > The Client SHOULD specify window types in order of preference
  >  (the first being most preferable) but MUST include at least one of
  >  the basic window type atoms from the list below. This is to allow
  >  for extension of the list of types whilst providing default behavior
  >  for Window Managers that do not recognize the extensions.
  
  KDE currently does not do this for its extended window types due to
  what appears to be a copy-paste error 5 years ago, and so is not
  EWMH compliant. This also causes focus stealing issues with i3 that
  lack a workaround: https://github.com/i3/i3/issues/3937

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D27356

AFFECTED FILES
  src/platforms/xcb/netwm.cpp

To: catherinez
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27279: Port away from QWidget

[Aleksei Nikiforov]

alnikiforov added a comment.


  I think I found source of infinite recursion.
  
  First call is on 
https://phabricator.kde.org/source/powerdevil/browse/master/daemon/powerdevilcore.cpp$821
  Second call is on 
https://phabricator.kde.org/source/kidletime/browse/master/src/plugins/xscreensaver/xscreensaverbasedpoller.cpp$62
  
  I've removed call at line xscreensaverbasedpoller.cpp:62 and it no longer 
crashes for me. Not sure if anything is going to be broken by this change. I'll 
prepare a patch.

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D27279

To: broulik, #frameworks, davidedmundson
Cc: alnikiforov, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

[eudoxos]

eudoxos added a comment.


  (side note: I am not sure whether to use phabricator.kde.org or 
invent.kde.org for this. Are they complementary or orthogonal?)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27285

To: eudoxos, #vdg
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

[eudoxos]

eudoxos added a comment.


  > No offense meant, but even with the screenshots I still have no idea what 
this is about :)
  
  Good point, I somehow missed to explain the rationale for the change. :) If 
you are familiar with vim, this would be the `breakindent` and `breakindentopt` 
 settings (that was my patch from 2007 which did not make it into vim until a 
few years back).
  
  > Can you add a before/after screenshot so we can see the visual difference?
  
  I will use this example from std::sort documentation 
 which is not the most 
convoluted code (those changes are the most useful for deeply nested code).
  
  This is the original rendering (with narrow window to make the point) and 
D27238  applied (breaking line anywhere 
rather than at whitespace-only):
  F8100695: image.png 
  Note how indentation blocks, manifest from empty space left, and also 
vertical indentation lines, are visually damaged by the dynamic wrap fill (I 
call this left fill, it is left of the indentation level). Dynamic wrap is 
something related to presentation only, not to overall code logic 
(indentation), and is line-local; so the option to enable/disable this fill is 
to make it possible to remove this globally-prominent visual cue about 
something very much local. This is without the left fill (note how indentation 
lines now also extend vertically):
  F8100700: image.png 
  Now, the line being wrapped does have some importance and it should be shown 
somewhere. It is shown already by the arrow in the left margin, but that is way 
too far from the break, even left from folding markers (global logic) (I 
understand the wrap markers are there probably from the age when dynamic 
wrapping did not respect indentation and it was a sin to write code beyond col 
80 ;) ).
  
  So the "right fill" is **right** of the indentation level on subsequent 
visual lines and gives visual cue about the line being wrapped; like this (2 
characters wide, that is adjustable):
  F8100703: image.png 
  Of course, there are many options how to mark the break where it occurs, this 
one was just the easiest one. Onec can clutter configuration more and think of 
options like moving the arrow in the left margin to the line beginning, like 
this (this is just GIMP, not in the code)
  F8100706: image.png 
  but I think it is better to start with something relatively simple.
  
  It is possible to enable both left and right fill (not sure why anybody would 
want that, but I was not sure even for the original (left) fill):
  F8100716: image.png 
  
  > Also, the "fill left" and "fill right" wording is new, and not intuitively 
understandable for me.
  
  That is a new "terminology" I am free to adjust. Left is simply left of 
indentation level, right is on the right.
  
  Hope this explains somewhat.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27285

To: eudoxos, #vdg
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D27103: KItemModels: Convert license headers to SPDX markers

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.


  Please push after fixing the remaining issues

REPOSITORY
  R275 KItemModels

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27103

To: cordlandwehr, dfaure, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27103: KItemModels: Convert license headers to SPDX markers

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> modeltest.h:4
>  
> +SPDX-FileCopyrightText: 2013 Digia Plc and /or its subsidiary(-ies) 
> 
> +SPDX-FileCopyrightText: 2010 Stephen Kelly 

Unneeded extra space added for a couple files "and /or" vs "and/or"

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D27103

To: cordlandwehr, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27103: KItemModels: Convert license headers to SPDX markers

[Andreas Cord-Landwehr]

cordlandwehr marked an inline comment as done.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D27103

To: cordlandwehr, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27103: KItemModels: Convert license headers to SPDX markers

[Andreas Cord-Landwehr]

cordlandwehr updated this revision to Diff 75580.
cordlandwehr added a comment.


  Incorporate review findings
  
  - Use FileContributor tag for stating authors without copyright claim
  - Resolving Qt legal redirect
  - Unify comment style for copyright statements

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27103?vs=74861=75580

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27103

AFFECTED FILES
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-2.1-or-later.txt
  autotests/bihash/benchmarks.cpp
  autotests/bihash/functionalitytest.cpp
  autotests/kcolumnheadersmodeltest.cpp
  autotests/kconcatenaterows_qml.cpp
  autotests/kdescendantsproxymodel_smoketest.cpp
  autotests/kdescendantsproxymodeltest.cpp
  autotests/kextracolumnsproxymodeltest.cpp
  autotests/klinkitemselectionmodeltest.cpp
  autotests/klinkitemselectionmodeltest.h
  autotests/kmodelindexproxymappertest.cpp
  autotests/knumbermodeltest.cpp
  autotests/krearrangecolumnsproxymodeltest.cpp
  autotests/krecursivefilterproxymodeltest.cpp
  autotests/kselectionproxymodel_smoketest.cpp
  autotests/kselectionproxymodeltest.cpp
  autotests/kselectionproxymodeltestsuite.cpp
  autotests/kselectionproxymodeltestsuite.h
  autotests/proxymodeltestsuite/dynamictreemodel.cpp
  autotests/proxymodeltestsuite/dynamictreemodel.h
  autotests/proxymodeltestsuite/dynamictreewidget.cpp
  autotests/proxymodeltestsuite/dynamictreewidget.h
  autotests/proxymodeltestsuite/eventloggerregister.cpp
  autotests/proxymodeltestsuite/eventloggerregister.h
  autotests/proxymodeltestsuite/indexfinder.h
  autotests/proxymodeltestsuite/modelcommander.cpp
  autotests/proxymodeltestsuite/modelcommander.h
  autotests/proxymodeltestsuite/modeldumper.cpp
  autotests/proxymodeltestsuite/modeldumper.h
  autotests/proxymodeltestsuite/modeleventlogger.cpp
  autotests/proxymodeltestsuite/modeleventlogger.h
  autotests/proxymodeltestsuite/modelselector.cpp
  autotests/proxymodeltestsuite/modelselector.h
  autotests/proxymodeltestsuite/modelspy.cpp
  autotests/proxymodeltestsuite/modelspy.h
  autotests/proxymodeltestsuite/modeltest.cpp
  autotests/proxymodeltestsuite/modeltest.h
  autotests/proxymodeltestsuite/persistentchangelist.h
  autotests/proxymodeltestsuite/proxymodeltest.cpp
  autotests/proxymodeltestsuite/proxymodeltest.h
  autotests/test_model_helpers.h
  src/core/kbihash_p.h
  src/core/kbreadcrumbselectionmodel.cpp
  src/core/kbreadcrumbselectionmodel.h
  src/core/kcheckableproxymodel.cpp
  src/core/kcheckableproxymodel.h
  src/core/kcolumnheadersmodel.cpp
  src/core/kcolumnheadersmodel.h
  src/core/kconcatenaterowsproxymodel.cpp
  src/core/kconcatenaterowsproxymodel.h
  src/core/kdescendantsproxymodel.cpp
  src/core/kdescendantsproxymodel.h
  src/core/kextracolumnsproxymodel.cpp
  src/core/kextracolumnsproxymodel.h
  src/core/klinkitemselectionmodel.cpp
  src/core/klinkitemselectionmodel.h
  src/core/kmodelindexproxymapper.cpp
  src/core/kmodelindexproxymapper.h
  src/core/knumbermodel.cpp
  src/core/knumbermodel.h
  src/core/krearrangecolumnsproxymodel.cpp
  src/core/krearrangecolumnsproxymodel.h
  src/core/krecursivefilterproxymodel.cpp
  src/core/krecursivefilterproxymodel.h
  src/core/kselectionproxymodel.cpp
  src/core/kselectionproxymodel.h
  src/core/kvoidpointerfactory_p.h
  src/qml/kconcatenaterowsproxymodel_qml.cpp
  src/qml/kconcatenaterowsproxymodel_qml.h
  src/qml/plugin.cpp
  src/qml/plugin.h
  tests/proxymodeltestapp/breadcrumbdirectionwidget.cpp
  tests/proxymodeltestapp/breadcrumbdirectionwidget.h
  tests/proxymodeltestapp/breadcrumbnavigationwidget.cpp
  tests/proxymodeltestapp/breadcrumbnavigationwidget.h
  tests/proxymodeltestapp/breadcrumbswidget.cpp
  tests/proxymodeltestapp/breadcrumbswidget.h
  tests/proxymodeltestapp/checkablewidget.cpp
  tests/proxymodeltestapp/checkablewidget.h
  tests/proxymodeltestapp/descendantpmwidget.cpp
  tests/proxymodeltestapp/descendantpmwidget.h
  tests/proxymodeltestapp/kidentityproxymodelwidget.cpp
  tests/proxymodeltestapp/kidentityproxymodelwidget.h
  tests/proxymodeltestapp/kreparentingproxymodel.cpp
  tests/proxymodeltestapp/kreparentingproxymodel.h
  tests/proxymodeltestapp/lessthanwidget.cpp
  tests/proxymodeltestapp/lessthanwidget.h
  tests/proxymodeltestapp/main.cpp
  tests/proxymodeltestapp/mainwindow.cpp
  tests/proxymodeltestapp/mainwindow.h
  tests/proxymodeltestapp/matchcheckingwidget.cpp
  tests/proxymodeltestapp/matchcheckingwidget.h
  tests/proxymodeltestapp/modelcommanderwidget.cpp
  tests/proxymodeltestapp/modelcommanderwidget.h
  tests/proxymodeltestapp/proxyitemselectionwidget.cpp
  tests/proxymodeltestapp/proxyitemselectionwidget.h
  tests/proxymodeltestapp/proxymodeltestwidget.cpp
  tests/proxymodeltestapp/proxymodeltestwidget.h
  tests/proxymodeltestapp/recursivefilterpmwidget.cpp
  tests/proxymodeltestapp/recursivefilterpmwidget.h
  tests/proxymodeltestapp/reparentingpmwidget.cpp
  

D27106: Attica: Convert license statements to SPDX markers

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R235 Attica

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27106

To: cordlandwehr, cgiboudeaux
Cc: dfaure, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27106: Attica: Convert license statements to SPDX markers

[Andreas Cord-Landwehr]

cordlandwehr marked 2 inline comments as done.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D27106

To: cordlandwehr
Cc: dfaure, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27106: Attica: Convert license statements to SPDX markers

[Andreas Cord-Landwehr]

cordlandwehr updated this revision to Diff 75579.
cordlandwehr added a comment.


  Solve review findings
  
  - Fix license files
  - Use FileContributor tag for Author statements without copyright claim

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27106?vs=74869=75579

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27106

AFFECTED FILES
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/configtest.cpp
  autotests/persontest.cpp
  autotests/privatedatatest.cpp
  autotests/providertest.cpp
  src/accountbalance.cpp
  src/accountbalance.h
  src/accountbalanceparser.cpp
  src/accountbalanceparser.h
  src/achievement.cpp
  src/achievement.h
  src/achievementparser.cpp
  src/achievementparser.h
  src/activity.cpp
  src/activity.h
  src/activityparser.cpp
  src/activityparser.h
  src/atticabasejob.cpp
  src/atticabasejob.h
  src/atticautils.cpp
  src/atticautils.h
  src/buildservice.cpp
  src/buildservice.h
  src/buildservicejob.cpp
  src/buildservicejob.h
  src/buildservicejoboutput.cpp
  src/buildservicejoboutput.h
  src/buildservicejoboutputparser.cpp
  src/buildservicejoboutputparser.h
  src/buildservicejobparser.cpp
  src/buildservicejobparser.h
  src/buildserviceparser.cpp
  src/buildserviceparser.h
  src/category.cpp
  src/category.h
  src/categoryparser.cpp
  src/categoryparser.h
  src/cloud.cpp
  src/cloud.h
  src/cloudparser.cpp
  src/cloudparser.h
  src/comment.cpp
  src/comment.h
  src/commentparser.cpp
  src/commentparser.h
  src/config.cpp
  src/config.h
  src/configparser.cpp
  src/configparser.h
  src/content.cpp
  src/content.h
  src/contentparser.cpp
  src/contentparser.h
  src/deletejob.cpp
  src/deletejob.h
  src/distribution.cpp
  src/distribution.h
  src/distributionparser.cpp
  src/distributionparser.h
  src/downloaddescription.cpp
  src/downloaddescription.h
  src/downloaditem.cpp
  src/downloaditem.h
  src/downloaditemparser.cpp
  src/downloaditemparser.h
  src/event.cpp
  src/event.h
  src/eventparser.cpp
  src/eventparser.h
  src/folder.cpp
  src/folder.h
  src/folderparser.cpp
  src/folderparser.h
  src/forum.cpp
  src/forum.h
  src/forumparser.cpp
  src/forumparser.h
  src/getjob.cpp
  src/getjob.h
  src/homepageentry.cpp
  src/homepageentry.h
  src/homepagetype.cpp
  src/homepagetype.h
  src/homepagetypeparser.cpp
  src/homepagetypeparser.h
  src/icon.cpp
  src/icon.h
  src/itemjob.cpp
  src/itemjob.h
  src/knowledgebaseentry.cpp
  src/knowledgebaseentry.h
  src/knowledgebaseentryparser.cpp
  src/knowledgebaseentryparser.h
  src/license.cpp
  src/license.h
  src/licenseparser.cpp
  src/licenseparser.h
  src/listjob.cpp
  src/listjob.h
  src/listjob_inst.cpp
  src/message.cpp
  src/message.h
  src/messageparser.cpp
  src/messageparser.h
  src/metadata.cpp
  src/metadata.h
  src/parser.cpp
  src/parser.h
  src/person.cpp
  src/person.h
  src/personparser.cpp
  src/personparser.h
  src/platformdependent.h
  src/platformdependent_v2.cpp
  src/platformdependent_v2.h
  src/postfiledata.cpp
  src/postfiledata.h
  src/postjob.cpp
  src/postjob.h
  src/privatedata.cpp
  src/privatedata.h
  src/privatedataparser.cpp
  src/privatedataparser.h
  src/project.cpp
  src/project.h
  src/projectparser.cpp
  src/projectparser.h
  src/provider.cpp
  src/provider.h
  src/providermanager.cpp
  src/providermanager.h
  src/publisher.cpp
  src/publisher.h
  src/publisherfield.cpp
  src/publisherfield.h
  src/publisherfieldparser.cpp
  src/publisherfieldparser.h
  src/publisherparser.cpp
  src/publisherparser.h
  src/putjob.cpp
  src/putjob.h
  src/qtplatformdependent.cpp
  src/qtplatformdependent_p.h
  src/remoteaccount.cpp
  src/remoteaccount.h
  src/remoteaccountparser.cpp
  src/remoteaccountparser.h
  src/topic.cpp
  src/topic.h
  src/topicparser.cpp
  src/topicparser.h
  src/version.h.cmake
  tests/projecttest/main.cpp
  tests/projecttest/projecttest.cpp
  tests/projecttest/projecttest.h

To: cordlandwehr
Cc: dfaure, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

Re: 2 kirigami fixes for a point release

[Ben Cooksley]

On Thu, Feb 13, 2020 at 9:00 PM Christoph Feck  wrote:
>
> On 02/13/20 08:42, Ben Cooksley wrote:
> > Part of the issue here is that Plasma has been known to add API to
> > Frameworks and then immediately, without any delay, start using it
> > (pretty much always breaking CI in the process)
> >
> > This means that other changes are likely being pushed into Frameworks
> > by Plasma with very little delay as well.
> >
> > Consequently this means stuff is landing in Framework repositories up
> > to the very moment it is released - a release that the next version of
> > Plasma (LTS) then depends on.
> >
> > A better way of approaching this would be to freeze the Frameworks
> > version you are going to require API wise at an earlier point in the
> > Plasma development cycle. This would allow for a full Frameworks
> > release cycle to pass where bugs encountered during the lead up to the
> > Plasma release can be fixed.
>
> You can find bugs in new code best if you are actually using it. I doubt
> that delaying using new API would help much.

The point here was that when new API is added, it has to be added much
earlier in the cycle, so that anything using it gets at a minimum a
full month to cycle among our developers and have all the issues
worked out - in the next release which is the one that Plasma actually
depends on.

Currently it is added to Frameworks and started to be used
immediately, when Plasma has already released it's first Beta - giving
little chance for code to be run on developer systems before it hits
end users.

Cheers,
Ben

D27235: add calindori icon in the new pm style

[Dimitris Kardarakos]

dkardarakos added a comment.


  OK from me (although not a fan of the top white hole, but probably a matter 
of taste). Let the VDG people review it before submitting.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27235

To: mbruchert, dkardarakos, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27224: add Kongress icon

[Dimitris Kardarakos]

dkardarakos added a comment.


  I like it and I will be happy to be the icon of Kongress. But let VDG people 
review it as well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27224

To: mbruchert, dkardarakos, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Re: 2 kirigami fixes for a point release

[Christoph Feck]

On 02/13/20 08:42, Ben Cooksley wrote:

Part of the issue here is that Plasma has been known to add API to
Frameworks and then immediately, without any delay, start using it
(pretty much always breaking CI in the process)

This means that other changes are likely being pushed into Frameworks
by Plasma with very little delay as well.

Consequently this means stuff is landing in Framework repositories up
to the very moment it is released - a release that the next version of
Plasma (LTS) then depends on.

A better way of approaching this would be to freeze the Frameworks
version you are going to require API wise at an earlier point in the
Plasma development cycle. This would allow for a full Frameworks
release cycle to pass where bugs encountered during the lead up to the
Plasma release can be fixed.


You can find bugs in new code best if you are actually using it. I doubt 
that delaying using new API would help much.