D27419: Update Japanese holidays

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D27419

To: nhiga, dvratil, winterz, cgiboudeaux
Cc: #kde_pim, kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, 
dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/53/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 15 Feb 2020 08:47:37 +
 Build duration:
2 min 24 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 490 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

D27065: Fix inverted logic in IOKitStorage::isRemovable

[René J . V . Bertin]

rjvbb added a subscriber: kde-mac.
rjvbb added a comment.


  Well, I got as far as confirming you're probably right, when I finally got to 
sit at my Mac yesterday night ... and then when I woke up it was 3am.
  
  I'm tempted to green-light this but I think someone is going to have to 
verify the results after flipping the logic combined with the check of the 
`Removable` device property, with more than just a single internal drive. Let's 
see if anyone else is reading the kde-mac ML ...

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27065

To: mwolff, #frameworks, rjvbb, cgilles
Cc: kde-mac, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27363: KHolidays: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr updated this revision to Diff 75736.
cordlandwehr added a comment.


  Clarified several statements
  
  - Recovered origin of weekNumber method and its original license
  - Unified verbose license statements
  - Clarified snippet licensing

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27363?vs=75594&id=75736

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27363

AFFECTED FILES
  LICENSES/BSD-2-Clause.txt
  LICENSES/Bison-exception-2.2.txt
  LICENSES/GPL-3.0-or-later.txt
  LICENSES/LGPL-2.0-or-later.txt
  autotests/testholidayregion.cpp
  autotests/testholidayregion.h
  autotests/testlunar.cpp
  autotests/testlunar.h
  autotests/testseasons.cpp
  autotests/testseasons.h
  autotests/testsunriseset.cpp
  autotests/testsunriseset.h
  autotests/testzodiac.cpp
  src/astroseasons.cpp
  src/astroseasons.h
  src/declarative/holidayregionsmodel.cpp
  src/declarative/holidayregionsmodel.h
  src/declarative/kholidaysdeclarativeplugin.cpp
  src/declarative/kholidaysdeclarativeplugin.h
  src/holiday.cpp
  src/holiday.h
  src/holiday_p.h
  src/holidayregion.cpp
  src/holidayregion.h
  src/lunarphase.cpp
  src/lunarphase.h
  src/parsers/holidayparserdriver.cpp
  src/parsers/holidayparserdriver_p.h
  src/parsers/plan2/FlexLexer.h
  src/parsers/plan2/holidayparserdriverplan.cpp
  src/parsers/plan2/holidayparserdriverplan_p.h
  src/parsers/plan2/holidayparserplan.cpp
  src/parsers/plan2/holidayparserplan.hpp
  src/parsers/plan2/holidayparserplan.ypp
  src/parsers/plan2/holidayscannerplan.cpp
  src/parsers/plan2/holidayscannerplan.lpp
  src/parsers/plan2/holidayscannerplan_p.h
  src/parsers/plan2/location.hh
  src/parsers/plan2/position.hh
  src/parsers/plan2/stack.hh
  src/parsers/qcalendarsystem.cpp
  src/parsers/qcalendarsystem_p.h
  src/sunriseset.cpp
  src/sunriseset.h
  src/zodiac.cpp
  src/zodiac.h

To: cordlandwehr
Cc: cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27363: KHolidays: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr marked 5 inline comments as done.
cordlandwehr added a comment.


  Updated several statements, but still need clarification if named people are 
copyright holders or contributors without copyright claim.

INLINE COMMENTS

> cgiboudeaux wrote in holidayscannerplan.cpp:1297-1301
> and these lines were not updated

@winterz same question here as above: are these people copyright holders or 
file contributors?

> cgiboudeaux wrote in qcalendarsystem.cpp:833
> also looks wrong

I did them intense code-digging and found the source of this snippet

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D27363

To: cordlandwehr
Cc: cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27363: KHolidays: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr updated this revision to Diff 75737.
cordlandwehr marked 2 inline comments as done.
cordlandwehr added a comment.


  Make snippet copyright statement more verbose

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27363?vs=75736&id=75737

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27363

AFFECTED FILES
  LICENSES/BSD-2-Clause.txt
  LICENSES/Bison-exception-2.2.txt
  LICENSES/GPL-3.0-or-later.txt
  LICENSES/LGPL-2.0-or-later.txt
  autotests/testholidayregion.cpp
  autotests/testholidayregion.h
  autotests/testlunar.cpp
  autotests/testlunar.h
  autotests/testseasons.cpp
  autotests/testseasons.h
  autotests/testsunriseset.cpp
  autotests/testsunriseset.h
  autotests/testzodiac.cpp
  src/astroseasons.cpp
  src/astroseasons.h
  src/declarative/holidayregionsmodel.cpp
  src/declarative/holidayregionsmodel.h
  src/declarative/kholidaysdeclarativeplugin.cpp
  src/declarative/kholidaysdeclarativeplugin.h
  src/holiday.cpp
  src/holiday.h
  src/holiday_p.h
  src/holidayregion.cpp
  src/holidayregion.h
  src/lunarphase.cpp
  src/lunarphase.h
  src/parsers/holidayparserdriver.cpp
  src/parsers/holidayparserdriver_p.h
  src/parsers/plan2/FlexLexer.h
  src/parsers/plan2/holidayparserdriverplan.cpp
  src/parsers/plan2/holidayparserdriverplan_p.h
  src/parsers/plan2/holidayparserplan.cpp
  src/parsers/plan2/holidayparserplan.hpp
  src/parsers/plan2/holidayparserplan.ypp
  src/parsers/plan2/holidayscannerplan.cpp
  src/parsers/plan2/holidayscannerplan.lpp
  src/parsers/plan2/holidayscannerplan_p.h
  src/parsers/plan2/location.hh
  src/parsers/plan2/position.hh
  src/parsers/plan2/stack.hh
  src/parsers/qcalendarsystem.cpp
  src/parsers/qcalendarsystem_p.h
  src/sunriseset.cpp
  src/sunriseset.h
  src/zodiac.cpp
  src/zodiac.h

To: cordlandwehr
Cc: cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

Re: New Framework Review: KDAV

[Volker Krause]

On Saturday, 9 November 2019 12:33:54 CET Volker Krause wrote:
> Hi,
> 
> during Akademy there was a request to promote KDAV from KDE PIM to
> Frameworks for use by Plasma Mobile. KDAV is a framework that implements
> the CalDav/ CardDav/GroupDav protocol on top of KIO's WebDav support. It
> would be classified as a functional tier 3 framework.
> 
> So far we have fixed a number of obvious ABI-compatibility issues, removed
> QtXml[Patterns] usage from the public interface and relicensed GPL parts
> (apart from a bit of test code) to LGPL. The next step would be a more
> thorough review to identify changes necessary before becoming a Framework.
> 
> To avoid the last minute invasive changes we ended up doing for
> KCalendarCore, I'd propose the following timeline:
> 
> - identify and implement all necessary changes to the API and ABI until the
> 20.04 Application release (that includes the still necessary move to the KF5
> library namespace).

The rename to the KF5 namespace has been done, if more changes to the ABI are 
necessary now would be a good time to point those out, so we can integrate 
them before the 20.04 freeze :)

Thanks,
Volker

> - release KDAV with 20.04 with the final API/ABI that the first KF5 release
> will provide as well
> - become part of the KF5 release in May or June 2020, release as a drop-in
> replacement of the last application release
> 
> In general this is following the same transition process that has been used
> for Syndication, KHolidays, KContacts and KCalendarCore as that should cause
> minimal disruptions for distributors, but if there's better ideas on how to
> handle this, now is a good time to bring this up :)
> 
> Feedback?
> 
> Thanks,
> Volker



signature.asc
Description: This is a digitally signed message part.

Re: New Framework Review: KDAV

[Andreas Cord-Landwehr]

Hi, sorry for this very late mail, missed the call for reviews...

Would it be possible to do some license clarifications before moving kdav into 
the frameworks section?

In mostly all files it is not clear if the LGPL or the GPL is meant (stating 
"GNU Library General Public License" and referring to the GPL text at the end 
of the statement). This license statement is used for all files except 
autotests/fakesever.cpp and autotests/fakeserver.h.
Luckily, from the copyright statements there are only 3 copyright holders: 
Tobias, Sandro and Gregory. I put all 3 into CC.

@Tobias, Sandro, Gregory: Can you clarify that the code you are holding 
copyright about in this repository is licensed according to LGPL-2.0-or-later?

Cheers,
Andreas

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Méven Car]

meven updated this revision to Diff 75740.
meven added a comment.


  Add an assertion to JobTest::stat()^Ccomment out other tests debug output

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25010?vs=75567&id=75740

BRANCH
  arcpatch-D25010_2

REVISION DETAIL
  https://phabricator.kde.org/D25010

AFFECTED FILES
  autotests/jobremotetest.cpp
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/CMakeLists.txt
  src/core/copyjob.cpp
  src/core/deletejob.cpp
  src/core/directorysizejob.cpp
  src/core/global.h
  src/core/statjob.cpp
  src/core/statjob.h
  src/filewidgets/kdiroperator.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/krun.cpp
  src/widgets/paste.cpp
  tests/kioslavetest.cpp
  tests/listjobtest.cpp

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27363: KHolidays: Convert license statements to SPDX expressions

[Allen Winter]

winterz added a comment.


  looks ok to me.

INLINE COMMENTS

> cgiboudeaux wrote in lunarphase.cpp:6
> This looks suspicious
> 
> @winterz ?

no, it's fine.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D27363

To: cordlandwehr
Cc: cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27419: Update Japanese holidays

[Allen Winter]

winterz accepted this revision.
winterz added a comment.


  I tested these changes locally.  works
  
  do you have commit access?

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D27419

To: nhiga, dvratil, winterz, cgiboudeaux
Cc: #kde_pim, kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, 
dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D27419: Update Japanese holidays

[Albert Astals Cid]

aacid added a comment.


  No, she (i think) does not have commit access.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D27419

To: nhiga, dvratil, winterz, cgiboudeaux
Cc: aacid, #kde_pim, kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, 
GB_2, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D27224: add Kongress icon

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  The pixel alignment for all parts of the inner symbol is off. The style of 
the inner symbol is a bit too rounded for the breeze style as well. For 
instance, the podium should have sharper corners in order to look more like 
other breeze icons. I know it's not really easy to tell what can be rounded and 
what can't. That's something we need to nail down in the HIG. In general, use 
roundness where appropriate for a given shape, not as a general style. Objects 
that typically have sharp corners should generally be represented with sharp 
corners.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27224

To: mbruchert, dkardarakos, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27223: add kirigami-gallery icon

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  You've got a duplicate copy of the icon in there. The bottom shadow should 
also be changed to be dark gray, like a darker version of the normal background 
color rather than a dark blue.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

T12641: Refactor KFileProtocol::copy

[David Faure]

dfaure added a comment.


  I don't really understand the relation to ksmserver, surely kioslaves are not 
part of session management.
  
  I also don't really understand what would happen in the new event loop 
(select/poll) of the kioslave while the non-blocking I/O is happening. It's not 
like the slave can handle other commands in parallel. Slaves are in a separate 
process exactly so that they can block.
  
  Regarding O_DIRECT, I have some doubts. The man page you linked to, says
  
In summary, O_DIRECT is a potentially powerful tool that should be used 
with caution. It is recommended that applications treat use of O_DIRECT as a 
performance option which is disabled by default.
"The thing that has always disturbed me about O_DIRECT is that the whole 
interface is just stupid, and was probably designed by a deranged monkey on 
some serious mind-controlling substances."--Linus"`
  
  Are you sure you want to use that? :-)
  More precisely, it says it will break with NFS (in some cases).
  And it sounds like a bad buffer size with O_DIRECT will slow things down (too 
many direct writes instead of buffering).
  Overall, I'd say -- did you check what the `cp` source code does? That's what 
we're competing against :-)

TASK DETAIL
  https://phabricator.kde.org/T12641

To: meven, dfaure
Cc: apol, dfaure, #frameworks, #dolphin, ognarb, broulik, meven, pberestov, 
iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

Re: 2 kirigami fixes for a point release

[Ben Cooksley]

On Sat, Feb 15, 2020 at 8:10 AM Nate Graham  wrote:
>
> On 2020-02-13 00:42, Ben Cooksley wrote:
> > A better way of approaching this would be to freeze the Frameworks
> > version you are going to require API wise at an earlier point in the
> > Plasma development cycle. This would allow for a full Frameworks
> > release cycle to pass where bugs encountered during the lead up to the
> > Plasma release can be fixed.
> >
> > This version of Frameworks would then be the one that Plasma hard depends 
> > on.
>
> We do this; Plasma 5.18 has a minimum Frameworks dependency of 5.66. See
> https://community.kde.org/Schedules/Plasma_5#Support_status_by_Release_Series
>
> The problem here isn't so much API breaks but rather major bugs and UI
> regressions. if a framework has a very visible bug or UI regression in
> 5.66 of the kind that we would really like to fix, but LTS distros
> freeze on that version, then LTS users will be stuck with that issue
> forever unless we make a frameworks point release or cajole distro
> packagers to backport the fix.
>
> Rolling release distro users will first see Plasma 5.18 with Frameworks
> 5.67, so if that frameworks version has a major bug or UI regression, it
> will take a month for the fix to land in users' hands whereas if the
> issue were in Plasma itself, we could fix it immediately and users would
> get the fix in a week (the first point release is one week after the .0
> release).
>
> My point is that the schedules just don't really match up if we want to
> present a polished finished product and continue to fix bugs for the
> lifetime of an LTS release.
>

My point above was that the version you decide to freeze on should
only be the version you depend on during development.
The version you depend on when you release will be the next release of
Frameworks (so by freezing on 5.66 for development, it should have had
a release-day dependency of 5.67)

The release of Plasma should then take place shortly after the
Frameworks version you have a release-day dependency on.

You stagger it like this to ensure that developers are performing a
full burn in of the Frameworks version for several weeks on their
systems, and to ensure that all the problems they find end up in the
Frameworks that users will have on their systems.

As for the distributions that are refusing to update Frameworks, do
you have a list of those distributions?
If they're providing a poor experience to our users then we at the
very least should ensure we steer people away from them.

>
> Nate

Regards,
Ben

D26749: WIP: Support NDK r20 and Qt 5.14

[Aleix Pol Gonzalez]

apol added a comment.


  Patch makes sense to me overall, we could consider landing it.

INLINE COMMENTS

> vkrause wrote in Android.cmake:173
> It's "better" in the way that it actually works with NDK r20, while CMake 
> 3.16 failed to even pass the basic compiler checks. For a toolchain file 
> shipped with a toolchain making adjustments for toolchain changes is of 
> course possible immediately, while with CMake we have to wait for the next 
> release if such changes are necessary.
> 
> It's unfortunately different in various variable names as well in some 
> details of what it sets or doesn't set. That's where most of the changes in 
> this file come from.
> 
> The main reason we didn't use this right from the start, and probably also 
> the reason the toolchain file in CMake exists is that the NDK didn't have 
> CMake support in older versions.

I did some testing and for me it works for arm64 but not for arm32.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D26749

To: vkrause
Cc: flherne, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
GB_2, bencreasy, michaelh, ngraham, bruns

D27065: Fix inverted logic in IOKitStorage::isRemovable

[René J . V . Bertin]

rjvbb accepted this revision.
rjvbb added a comment.
This revision is now accepted and ready to land.


  Works fine as far as I can tell, amazing no one else noticed this before!

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27065

To: mwolff, #frameworks, rjvbb, cgilles
Cc: kde-mac, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27419: Update Japanese holidays

[N. Higa]

nhiga added a comment.


  In D27419#612064 , @winterz wrote:
  
  > I tested these changes locally.  works
  >
  > do you have commit access?
  
  
  No, I do not have commit access. (I think commit access is only granted to 
active developers/contributors? )

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D27419

To: nhiga, dvratil, winterz, cgiboudeaux
Cc: aacid, #kde_pim, kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, 
GB_2, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 298 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/298/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 16 Feb 2020 04:43:30 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 431 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/431/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 16 Feb 2020 04:43:29 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34844/62089)40%
(17706/43872)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9722/10183)47%
(4541/9636)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8730/14619)51%
(4522/8853)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8330)43%
(2078/4812)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1806/4289)36%
(1312/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 306 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/306/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 16 Feb 2020 04:43:29 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34810/62086)40%
(17692/43868)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9722/10183)47%
(4539/9636)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8716/14618)51%
(4516/8853)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8330)43%
(2076/4808)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1791/4288)36%
(1311/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

D27428: KItemViews: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D27428

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27428: KItemViews: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license statements to SPDX markers and
  add license files as required by REUSE specification.

REPOSITORY
  R276 KItemViews

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27428

AFFECTED FILES
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  autotests/klistwidgetsearchlinetest.cpp
  src/kcategorizedsortfilterproxymodel.cpp
  src/kcategorizedsortfilterproxymodel.h
  src/kcategorizedsortfilterproxymodel_p.h
  src/kcategorizedview.cpp
  src/kcategorizedview.h
  src/kcategorizedview_p.h
  src/kcategorydrawer.cpp
  src/kcategorydrawer.h
  src/kextendableitemdelegate.cpp
  src/kextendableitemdelegate.h
  src/kfilterproxysearchline.cpp
  src/kfilterproxysearchline.h
  src/klistwidgetsearchline.cpp
  src/klistwidgetsearchline.h
  src/ktreewidgetsearchline.cpp
  src/ktreewidgetsearchline.h
  src/ktreewidgetsearchlinewidget.cpp
  src/ktreewidgetsearchlinewidget.h
  src/kwidgetitemdelegate.cpp
  src/kwidgetitemdelegate.h
  src/kwidgetitemdelegate_p.h
  src/kwidgetitemdelegatepool.cpp
  src/kwidgetitemdelegatepool_p.h
  tests/kcategorizedviewtest.cpp
  tests/kwidgetitemdelegatetest.cpp

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns