D27965: [KPasswdServer] replace foreach with range/index-based for

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77477.
ahmadsamir added a comment.


  - I missed one foreach before
  - Use erase() instead of remove(), safer to work on QList iterators

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27965?vs=77339=77477

BRANCH
  l-kpasswdserver (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27965

AFFECTED FILES
  src/kpasswdserver/autotests/kpasswdservertest.cpp
  src/kpasswdserver/kpasswdserver.cpp

To: ahmadsamir, #frameworks, dfaure, meven
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D25315: KDirModel: implement showing a root node for the requested URL

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kdirmodeltest_gui.cpp:92
> It doesn't look "normal" : without the ShowRoot feature, you wouldn't see the 
> "/" root node.
> So I would say the test program is valid, no matter what the starting 
> directory is.
> 
> (I was wrong about passing a path as argument, this goes into the code path 
> that does NOT set ShowRoot)

I wasn't re-arguing for changing the path in the test app, just explaining my 
POV (and "normal" as in I expected, mentally, to see "/" as the parent, since, 
well, it is).

When I tested with /usr/share/fonts, I modified the source code directly. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 327 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/327/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Mar 2020 02:12:25 +
 Build duration:
7 min 13 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 326 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/326/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Mar 2020 02:05:18 +
 Build duration:
6 min 47 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[David Faure]

dfaure added a comment.


  Fixed in https://commits.kde.org/kio/440bec1b3524f168fc04898a09ac51457c79ed3b

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27953: Properly read the X-Flatpak-RenamedFrom string list from desktop files

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R309:7d4b33677fdd: Properly read the X-Flatpak-RenamedFrom 
string list from desktop files (authored by apol).

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27953?vs=77467=77475

REVISION DETAIL
  https://phabricator.kde.org/D27953

AFFECTED FILES
  src/services/kservice.cpp

To: apol, dfaure
Cc: broulik, dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

[David Faure]

dfaure updated this revision to Diff 77474.
dfaure added a comment.


  Document how to load a part from a given KPluginMetaData

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27966?vs=77381=77474

REVISION DETAIL
  https://phabricator.kde.org/D27966

AFFECTED FILES
  src/CMakeLists.txt
  src/partloader.cpp
  src/partloader.h
  tests/partviewer.cpp

To: dfaure, aacid, nicolasfella, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  You need to add it to the file 
`src/declarativeimports/plasmaextracomponents/qml/qmldir` or else it doesn't 
get installed in a way that anything can see it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart, ngraham
Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D27953: Properly read the X-Flatpak-RenamedFrom string list from desktop files

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27953

To: apol, dfaure
Cc: broulik, dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Daniel Albers]

dalbers added a comment.


  This doesn't seem to compile:
  
[ 26%] Building CXX object 
src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.o
cd /usr/src/kio-git/src/build/src/ioslaves/file && /usr/lib/ccache/bin/c++  
-DKCOMPLETION_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054100 -DKCOREADDONS_LIB 
-DKF_DEPRECATED_WARNINGS_SINCE=0x06 
-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054300 
-DKIOCORE_DEPRECATED_WARNINGS_SINCE=0x0 
-DKIOCORE_DISABLE_DEPRECATED_BEFORE_AND_AT=0x0 -DQT_CONCURRENT_LIB 
-DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DEPRECATED_WARNINGS_SINCE=0x06 
-DQT_DISABLE_DEPRECATED_BEFORE=0x050d00 -DQT_NETWORK_LIB 
-DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_CAST_TO_ASCII 
-DQT_NO_DEBUG -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT 
-DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING 
-DQT_STRICT_ITERATORS -DQT_USE_QSTRINGBUILDER -DTRANSLATION_DOMAIN=\"kio5\" 
-D_GNU_SOURCE -D_LARGEFILE64_SOURCE -Dkio_file_EXPORTS 
-I/home/al/.cache/yay/kio-git/src/build/src/ioslaves/file 
-I/home/al/.cache/yay/kio-git/src/kio/src/ioslaves/file 
-I/home/al/.cache/yay/kio-git/src/build/src/ioslaves/file/kio_file_autogen/include
 -I/home/al/.cache/yay/kio-git/src/build/src/core/.. 
-I/home/al/.cache/yay/kio-git/src/kio/src/core/kssl 
-I/home/al/.cache/yay/kio-git/src/build/src/core 
-I/home/al/.cache/yay/kio-git/src/kio/src/core -isystem 
/usr/include/KF5/KCoreAddons -isystem /usr/include/KF5-isystem /usr/include/qt 
-isystem /usr/include/qt/QtCore -isystem /usr/lib/qt/mkspecs/linux-g++ -isystem 
/usr/include/KF5/KService -isystem /usr/include/KF5/KConfigCore -isystem 
/usr/include/qt/QtNetwork -isystem /usr/include/qt/QtConcurrent -isystem 
/usr/include/qt/QtDBus -isystem /usr/include/KF5/KI18n -isystem 
/usr/include/KF5/KAuth  -march=x86-64 -mtune=native -O2 -pipe -fno-plt -g 
-fvar-tracking-assignments 
-fdebug-prefix-map=/home/al/.cache/yay/kio-git/src=/usr/src/debug 
-fno-operator-names -fno-exceptions -Wall -Wextra -Wcast-align 
-Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef 
-Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Wvla -Wdate-time 
-Wsuggest-override -Wlogical-op -pedantic -Wzero-as-null-pointer-constant -O3 
-DNDEBUG -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -fPIC 
-std=gnu++11 -o CMakeFiles/kio_file.dir/file.cpp.o -c 
/home/al/.cache/yay/kio-git/src/kio/src/ioslaves/file/file.cpp
/usr/src/kio-git/src/kio/src/ioslaves/file/file.cpp: In member function 
'bool FileProtocol::createUDSEntry(const QString&, const QByteArray&, 
KIO::UDSEntry&, KIO::StatDetails)':
/usr/src/kio-git/src/kio/src/ioslaves/file/file.cpp:1041:38: error: 
'linkTargetBuffer' was not declared in this scope
1041 | targetPath = linkTargetBuffer;
|  ^~~~
make[2]: *** [src/ioslaves/file/CMakeFiles/kio_file.dir/build.make:76: 
src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.o] Error 1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> dfaure wrote in partloader.h:59
> This is an excellent point, thanks for this feedback.
> 
> Loading a part from a given KPluginMetadata is extremely simple, though:
> 
>   KPluginLoader loader(md.fileName());
>   m_part = loader.factory()->create(this, this);
> 
> Just like any other plugin.
> [maybe with md.keyword() as third argument in the future, once that's 
> implemented]
> 
> I can see the idea of providing everything that is needed for KParts at the 
> KParts level, so that one doesn't actually have to figure out that the above 
> is the way to do it. But then again, this is the way to do it for any plugin, 
> there's nothing specific about KParts there. So an alternative would be to 
> put this into the documentation for partsForMimeType?
> 
> What do you think? Docu or wrapper for a two-liner?
> 
> BTW I just implemented part listing (in an actionlist) and part switching in 
> partviewer (which is turning into a mini-konqueror, hehe). It shows that the 
> above works. It also shows that the duplication between new-style JSON and 
> old-style desktop files is a problem, I'll add some duplicate pruning...

I'd say documentation is fine :)

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D27966

To: dfaure, aacid, nicolasfella, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27997: Fix cmake warning

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R309:64ae18840457: Fix cmake warning (authored by apol).

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27997?vs=77466=77470

REVISION DETAIL
  https://phabricator.kde.org/D27997

AFFECTED FILES
  src/CMakeLists.txt

To: apol, #frameworks, aacid
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27953: Properly read the X-Flatpak-RenamedFrom string list from desktop files

[Aleix Pol Gonzalez]

apol added a comment.


  In D27953#626192 , @dfaure wrote:
  
  > How? You think we should change all our config files to use ';'? Welcome to 
migration hell.
  >
  > (I looked at the KConfig history, and in fact the separator was initially a 
method argument which defaulted to comma, I was wrong about it being ';' 
initially. No idea how we ended up with ';' in XDG then)
  
  
  I think it's worth doing, at least for desktop files.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D27953

To: apol, dfaure
Cc: broulik, dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27953: Properly read the X-Flatpak-RenamedFrom string list from desktop files

[Aleix Pol Gonzalez]

apol retitled this revision from "Properly read string lists from desktop files 
when parsing the files" to "Properly read the X-Flatpak-RenamedFrom string list 
from desktop files".
apol edited the summary of this revision.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D27953

To: apol, dfaure
Cc: broulik, dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27953: Properly read string lists from desktop files when parsing the files

[Aleix Pol Gonzalez]

apol updated this revision to Diff 77467.
apol added a comment.


  Fix as suggested

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27953?vs=77305=77467

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27953

AFFECTED FILES
  src/services/kservice.cpp

To: apol, dfaure
Cc: broulik, dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27997: Fix cmake warning

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R309 KService

BRANCH
  warning

REVISION DETAIL
  https://phabricator.kde.org/D27997

To: apol, #frameworks, aacid
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27997: Fix cmake warning

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  cmake complains about these files, just skip them for moc/uic.

TEST PLAN
  Builds without a warning now

REPOSITORY
  R309 KService

BRANCH
  warning

REVISION DETAIL
  https://phabricator.kde.org/D27997

AFFECTED FILES
  src/CMakeLists.txt

To: apol, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25315: KDirModel: implement showing a root node for the requested URL

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in kdirmodeltest_gui.cpp:92
> I did test the /usr/share/fonts path :); it's just that starting at "/" 
> looked "normal", whereas starting at a specific dir conveyed the goal of this 
> change better, to me anyway.

It doesn't look "normal" : without the ShowRoot feature, you wouldn't see the 
"/" root node.
So I would say the test program is valid, no matter what the starting directory 
is.

(I was wrong about passing a path as argument, this goes into the code path 
that does NOT set ShowRoot)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27953: Properly read string lists from desktop files when parsing the files

[David Faure]

dfaure added a comment.


  How? You think we should change all our config files to use ';'? Welcome to 
migration hell.
  
  (I looked at the KConfig history, and in fact the separator was initially a 
method argument which defaulted to comma, I was wrong about it being ';' 
initially. No idea how we ended up with ';' in XDG then)

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D27953

To: apol, dfaure
Cc: broulik, dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27953: Properly read string lists from desktop files when parsing the files

[Kai Uwe Broulik]

broulik added a comment.


  Do we have a task to clean that mix up for kf6 on the work board?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D27953

To: apol, dfaure
Cc: broulik, dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27953: Properly read string lists from desktop files when parsing the files

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  This sounds wrong. The XDG-mandated entries use XDG separators, but the KDE 
entries don't (for instance, grepping my installed desktop files I can see 
those: X-Plasma-RequiredExtensions, X-Plasma-DropMimeTypes, X-KDE-FormFactors, 
X-KIPI-PluginCategories, X-KDE-ParentComponents in kdepim, they all use a comma 
separator).
  
  Yes it's a mess. KDE1 had ';', the XDG standard picked that up, then KDE2 
switched to ',' and now we have a mix. The way we handle this mess is that, in 
KConfig and in KService, the default is ',' and we specifically use 
readXdgListEntry for XDG entries.
  
  I think this means the correct fix here is to specifically hardcode 
X-Flatpak-RenamedFrom instead of testing the property type.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D27953

To: apol, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27965: [KPasswdServer] replace foreach with range/index-based for

[David Faure]

dfaure requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27965

To: ahmadsamir, #frameworks, dfaure, meven
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27965: [KPasswdServer] replace foreach with range/index-based for

[David Faure]

dfaure added a comment.


  In D27965#625676 , @ahmadsamir 
wrote:
  
  > In D27965#625526 , @apol wrote:
  >
  > > Having the iterated value change under the hood will eventually break. 
I'd suggest preferring QList::erase to QList::removeOne.
  >
  >
  > Actually, the code also uses 'delete current', now if there's another 
instance of that AuthInfoContainer* in authList, on a next iteration accessing 
the pointer "current" would be invalid as the object it had pointed to has been 
already delete'ed... I think removeAll() would be a better fit; WDYT?
  
  
  authList does not contain duplicates. Otherwise the current code would 
already have the problem you're mentioning.
  So I see no reason to protect against that case.
  erase sounds much safer than removeOne which has unclear consequences on the 
iterators.

REPOSITORY
  R241 KIO

BRANCH
  l-kpasswdserver (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27965

To: ahmadsamir, #frameworks, dfaure, meven
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 325 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/325/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 11 Mar 2020 21:36:30 +
 Build duration:
6 min 58 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27963: [http_cache_cleaner] replace foreach usage with QDir::removeRecursively()

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:4b4ed81cc5f3: [http_cache_cleaner] replace foreach usage 
with QDir::removeRecursively() (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27963?vs=77462=77463

REVISION DETAIL
  https://phabricator.kde.org/D27963

AFFECTED FILES
  src/ioslaves/http/http_cache_cleaner.cpp

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27963: [http_cache_cleaner] replace foreach usage with QDir::removeRecursively()

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77462.
ahmadsamir added a comment.


  Rebase

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27963?vs=77336=77462

BRANCH
  l-http-foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27963

AFFECTED FILES
  src/ioslaves/http/http_cache_cleaner.cpp

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 324 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/324/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 11 Mar 2020 21:17:08 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:9537bca2b542: [StatJob] Use A QFlag to specify the 
details returned by StatJob (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25010?vs=77386=77460

REVISION DETAIL
  https://phabricator.kde.org/D25010

AFFECTED FILES
  autotests/jobremotetest.cpp
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/CMakeLists.txt
  src/core/copyjob.cpp
  src/core/deletejob.cpp
  src/core/directorysizejob.cpp
  src/core/global.h
  src/core/statjob.cpp
  src/core/statjob.h
  src/filewidgets/kdiroperator.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/krun.cpp
  src/widgets/paste.cpp
  tests/kioslavetest.cpp
  tests/listjobtest.cpp

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[David Faure]

dfaure added a comment.


  Yep, that's what "Accepted" means ;)

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D25010

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Nathaniel Graham]

ngraham added reviewers: VDG, davidedmundson.
ngraham accepted this revision.
ngraham added a subscriber: davidedmundson.
ngraham added a comment.


  Fantastic.
  
  I'm approving this since my concerns have been resolved and it works as 
you've indended it, but don't land it as it needs more discussion first. I know 
that @davidedmundson had concerns about this. Let's make sure everyone is 
included in the discussion.
  
  To be complete, we'll need companion patches to fix the cursor for various 
use cases (dolphin <-> dolphin, dolphin -> Folder View) and add a config UI for 
this in the Workspace Behavior KCM. Something like this:
  
Drag and drop files: (o) Always ask what to do
 ( ) Move files if location is on the same disk

INLINE COMMENTS

> dropjob.cpp:371
> +const KConfigGroup g = 
> KConfigGroup(KSharedConfig::openConfig(QStringLiteral("kdeglobals")), 
> QStringLiteral("KDE"));
> +if (g.readEntry("dndToMove", false) && (m_possibleActions & 
> Qt::MoveAction)) {
> +m_dropAction = Qt::MoveAction;

maybe we should call it something more descriptive, like "dndMoveByDefault"?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27918: [Config] Remove/deprecate disableInitialUpdate

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:bdbf837dfe1a: [Config] Remove/deprecate 
disableInitialUpdate (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27918?vs=77184=77457

REVISION DETAIL
  https://phabricator.kde.org/D27918

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/file/fileindexerconfig.h
  src/lib/baloosettings.kcfg

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D23926: Move "Details" tab to second place in Properties dialog

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ngraham wrote in kpropertiesdialog.cpp:645
>   /home/nate/kde/src/kio/src/widgets/kpropertiesdialog.cpp:645:18: error: 
> ‘class KService’ has no member named ‘serviceId’
> 
> `QStringLiteral`

Build failure from this issue is not resolved yet

> kpropertiesdialog.h:251
> + */
> +void KPropertiesDialog::insertPluginAt(KPropertiesDialogPlugin *plugin, 
> int index);
> +

Remove `KPropertiesDialog::` from this function definition

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, 
pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D27985: Include s_kcrashErrorMessage in our traces

[Aleix Pol Gonzalez]

apol updated this revision to Diff 77452.
apol added a comment.


  Include a usage in the test app, adapt to changes in kcrash

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27985?vs=77424=77452

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27985

AFFECTED FILES
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc
  src/tests/crashtest/crashtest.cpp

To: apol, #frameworks, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27986: Allow providing an error message from the application

[Aleix Pol Gonzalez]

apol updated this revision to Diff 77451.
apol marked an inline comment as done.
apol added a comment.


  We were already creating a QByteArray, just keep it instead of allocating 
constantly

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27986?vs=77425=77451

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27986

AFFECTED FILES
  src/kcrash.cpp
  src/kcrash.h

To: apol, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D23926: Move "Details" tab to second place in Properties dialog

[Matej Mrenica]

mthw updated this revision to Diff 77450.
mthw added a comment.


  Sorry about that, I should have checked waht I am sending.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23926?vs=77445=77450

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23926

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp
  src/widgets/kpropertiesdialog.h

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, 
pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D27932: NetworkManager-Qt: Convert license headers to SPDX expressions

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:fa9ef0d84898: NetworkManager-Qt: Convert license headers 
to SPDX expressions (authored by cordlandwehr).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27932?vs=77211=77449

REVISION DETAIL
  https://phabricator.kde.org/D27932

AFFECTED FILES
  .Doxyfile.cmake
  LICENSES/BSD-3-Clause.txt
  LICENSES/GPL-2.0-only.txt
  LICENSES/GPL-3.0-only.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-GPL.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/activeconnectiontest.cpp
  autotests/activeconnectiontest.h
  autotests/managertest.cpp
  autotests/managertest.h
  autotests/settings/8021xsettingtest.cpp
  autotests/settings/8021xsettingtest.h
  autotests/settings/adslsettingtest.cpp
  autotests/settings/adslsettingtest.h
  autotests/settings/bluetoothsettingtest.cpp
  autotests/settings/bluetoothsettingtest.h
  autotests/settings/bondsettingtest.cpp
  autotests/settings/bondsettingtest.h
  autotests/settings/bridgeportsettingtest.cpp
  autotests/settings/bridgeportsettingtest.h
  autotests/settings/bridgesettingtest.cpp
  autotests/settings/bridgesettingtest.h
  autotests/settings/cdmasettingtest.cpp
  autotests/settings/cdmasettingtest.h
  autotests/settings/connectionsettingtest.cpp
  autotests/settings/connectionsettingtest.h
  autotests/settings/dcbsettingtest.cpp
  autotests/settings/dcbsettingtest.h
  autotests/settings/gsmsettingtest.cpp
  autotests/settings/gsmsettingtest.h
  autotests/settings/infinibandsettingtest.cpp
  autotests/settings/infinibandsettingtest.h
  autotests/settings/iptunnelsettingtest.cpp
  autotests/settings/iptunnelsettingtest.h
  autotests/settings/ipv4settingtest.cpp
  autotests/settings/ipv4settingtest.h
  autotests/settings/ipv6settingtest.cpp
  autotests/settings/ipv6settingtest.h
  autotests/settings/macsecsettingtest.cpp
  autotests/settings/macsecsettingtest.h
  autotests/settings/matchsettingtest.cpp
  autotests/settings/matchsettingtest.h
  autotests/settings/olpcmeshsettingtest.cpp
  autotests/settings/olpcmeshsettingtest.h
  autotests/settings/ovsbridgesettingtest.cpp
  autotests/settings/ovsbridgesettingtest.h
  autotests/settings/ovsinterfacesettingtest.cpp
  autotests/settings/ovsinterfacesettingtest.h
  autotests/settings/ovspatchsettingtest.cpp
  autotests/settings/ovspatchsettingtest.h
  autotests/settings/ovsportsettingtest.cpp
  autotests/settings/ovsportsettingtest.h
  autotests/settings/pppoesettingtest.cpp
  autotests/settings/pppoesettingtest.h
  autotests/settings/pppsettingtest.cpp
  autotests/settings/pppsettingtest.h
  autotests/settings/proxysettingtest.cpp
  autotests/settings/proxysettingtest.h
  autotests/settings/serialsettingtest.cpp
  autotests/settings/serialsettingtest.h
  autotests/settings/tcsettingtest.cpp
  autotests/settings/tcsettingtest.h
  autotests/settings/teamportsettingtest.cpp
  autotests/settings/teamportsettingtest.h
  autotests/settings/tunsettingtest.cpp
  autotests/settings/tunsettingtest.h
  autotests/settings/usersettingtest.cpp
  autotests/settings/usersettingtest.h
  autotests/settings/vlansettingtest.cpp
  autotests/settings/vlansettingtest.h
  autotests/settings/vpnsettingtest.cpp
  autotests/settings/vpnsettingtest.h
  autotests/settings/vxlansettingtest.cpp
  autotests/settings/vxlansettingtest.h
  autotests/settings/wimaxsettingtest.cpp
  autotests/settings/wimaxsettingtest.h
  autotests/settings/wiredsettingtest.cpp
  autotests/settings/wiredsettingtest.h
  autotests/settings/wireguardsettingtest.cpp
  autotests/settings/wireguardsettingtest.h
  autotests/settings/wirelesssecuritysettingtest.cpp
  autotests/settings/wirelesssecuritysettingtest.h
  autotests/settings/wirelesssettingtest.cpp
  autotests/settings/wirelesssettingtest.h
  autotests/settingstest.cpp
  autotests/settingstest.h
  cmake/FindNetworkManager.cmake
  examples/createconnection/main.cpp
  examples/main.cpp
  src/accesspoint.cpp
  src/accesspoint.h
  src/accesspoint_p.h
  src/activeconnection.cpp
  src/activeconnection.h
  src/activeconnection_p.h
  src/adsldevice.cpp
  src/adsldevice.h
  src/adsldevice_p.h
  src/bluetoothdevice.cpp
  src/bluetoothdevice.h
  src/bluetoothdevice_p.h
  src/bonddevice.cpp
  src/bonddevice.h
  src/bonddevice_p.h
  src/bridgedevice.cpp
  src/bridgedevice.h
  src/bridgedevice_p.h
  src/connection.cpp
  src/connection.h
  src/connection_p.h
  src/device.cpp
  src/device.h
  src/device_p.h
  src/devicestatistics.cpp
  src/devicestatistics.h
  src/devicestatistics_p.h
  src/dhcp4config.cpp
  src/dhcp4config.h
  src/dhcp4config_p.h
  src/dhcp6config.cpp
  src/dhcp6config.h
  src/dhcp6config_p.h
  src/dnsconfiguration.cpp
  src/dnsconfiguration.h
  src/dnsdomain.cpp
  src/dnsdomain.h
  src/fakenetwork/accesspoint.cpp
  src/fakenetwork/accesspoint.h
  src/fakenetwork/activeconnection.cpp
  src/fakenetwork/activeconnection.h
  

D27952: Simplify minimum size handling

[Sune Vuorela]

svuorela accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R280 Prison

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D27952

To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27989: Add a new set of barcode size functions

[Sune Vuorela]

svuorela accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R280 Prison

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D27989

To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D23926: Move "Details" tab to second place in Properties dialog

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  For future reference, you can rebase like so:
  
git fetch
git rebase origin/master
  
  Also please make sure your code at least compiles before submitting a patch 
or a change to an existing patch.

INLINE COMMENTS

> kpropertiesdialog.cpp:645
> +
> +if (ptr->serviceId() == 
> QStringLitteral("baloofilepropertiesplugin")) {
> +q->insertPluginAt(plugin, 1);

/home/nate/kde/src/kio/src/widgets/kpropertiesdialog.cpp:645:18: error: ‘class 
KService’ has no member named ‘serviceId’

`QStringLiteral`

> kpropertiesdialog.h:251
> + */
> +void KPropertiesDialog::insertPluginAt(KPropertiesDialogPlugin *plugin, 
> int index)
>  

missing the semicolon

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, 
pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

[Matej Mrenica]

mthw updated this revision to Diff 77445.
mthw added a comment.


  I don't really know how to do a rebase propertly so I hope I managed to do 
the same manually.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23926?vs=77388=77445

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23926

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp
  src/widgets/kpropertiesdialog.h

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, 
pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Méven Car]

meven added a comment.


  Ok to merge ?

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D25010

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27989: Add a new set of barcode size functions

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: svuorela.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  preferredSize() is an improvement over what minimumSize() used to do,
  with taking the device pixel ratio into account. Additionally it also
  works correctly for 1D codes now (ie. those are now scannable on a
  standard DPI screen).
  
  trueMinimumSize() is what minimumSize() should have been, ie. the absolute
  minimum amount of pixels needed to display the code. This is mainly useful
  for applications doing their own layouting/scaling logic, beyond what
  preferredSize() offers.
  
  minimumSize() becomes deprecated by this, the deprecation macros will
  follow once the current users have been adjusted.

REPOSITORY
  R280 Prison

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D27989

AFFECTED FILES
  autotests/aztecbarcodetest.cpp
  autotests/code128barcodetest.cpp
  src/lib/abstractbarcode.cpp
  src/lib/abstractbarcode.h
  src/quick/barcodequickitem.cpp

To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27918: [Config] Remove/deprecate disableInitialUpdate

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27918

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27986: Allow providing an error message from the application

[Harald Sitter]

sitter added a comment.


  Unit test? (:
  
  I also wonder if maybe this should be lazy allocated. The vast majority of 
applications probably will never set it, so allocating the memory on first use 
should be better for the great majority of applications while making no 
difference for the gdb side of crash reporting.

INLINE COMMENTS

> kcrash.cpp:993
>  
> +void KCrash::setErrorMessage(const QString& message)
> +{

& on the wrong side of the space

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D27986

To: apol, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi added a comment.


  In D27951#625881 , @ngraham wrote:
  
  > Excellent. The behavior seems correct to me now. There are a few more 
issues I've like to bring up:
  >
  > - While dragging, the cursor always shows a "copying" icon, even though 
with the patch local drags result in a move. Anytime the file will be moved 
without showing the drop menu, it should show the move cursor, which looks like 
a grabbing hand
  
  
  Because this was set from QDrag, we have to patch Dolphin for this.
  
  > - When dragging and dropping a file to a writable location on another 
partition, we should always show the drop menu. See the discussion in 
https://bugs.kde.org/show_bug.cgi?id=392531. I don't think there's any chance 
that David will accept the patch in its current state if it moves by default 
across partitions/disks without asking first.
  
  Done, please test it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27985: Include s_kcrashErrorMessage in our traces

[Harald Sitter]

sitter added a comment.


  Probably should also get added to one of the parser tests to make sure it 
doesn't fall on the face.
  
  Talking about parser, I feel like this might benefit from highlighting 
somehow, currently it's very squished in with the random stuff in the header. 
That'll make it hard to search bugzilla for, globally, but also across 
different errors within the same application, as the only identifying element 
is `$1` and I'm sure that's profoundly ambiguous as a search term. Admittedly 
the only way to improve it I can think of is `print "Content of 
s_kcrashErrorMessage:"\nprint s_kcrashErrorMessage\n"`. The fact that this also 
prints empty messages doesn't exactly fill me with joy but I have no input on 
how to improve it either.
  
Application: dragon (dragon), signal: Segmentation fault
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
$1 = "!!! HALLO THIS IS A MESSAGE !!", '\000' 
[Current thread is 1 (Thread 0x7f255f320880 (LWP 19076))]

Thread 18 (Thread 0x7f250cff9700 (LWP 19093)):
#0  0x7f255628d9f3 in futex_wait_cancelable (private=, 
expected=0, futex_word=0x2544640) at 
../sysdeps/unix/sysv/linux/futex-internal.h:88
#1  __pthread_cond_wait_common (abstime=0x0, mutex=0

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D27985

To: apol, #frameworks, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi updated this revision to Diff 77433.
trmdi added a comment.


  Apply only when all the sources and the dest are on a same device.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27951?vs=77391=77433

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27951

AFFECTED FILES
  src/widgets/dropjob.cpp

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27928: [VIM Mode] Add g g commands

[Mikhail Zolotukhin]

gikari added a comment.


  Yes, my case.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27928

To: gikari, #kate, #frameworks
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars

D27928: [VIM Mode] Add g g commands

[Christoph Cullmann]

cullmann added a comment.


  I will try to take a look as soon as I have time, if nobody else is faster.
  Just to confirm: Your newly added test case doesn't pass or some other test 
case randomly fails?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27928

To: gikari, #kate, #frameworks
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Aleix Pol Gonzalez]

apol added a comment.


  The patch and the feature sound good to me, the resulting xml feels a bit 
weird and could use some clarification.

INLINE COMMENTS

> test_subgroups.kcfg:21
> +
> +
> +

It feels odd to reference the parent name rather than having a group inside the 
other.

Why don't we do something like:

  
  //entries
  
  //entries
  
  

Might be missing something.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

T11950: Reduce the pain of working on monochrome Breeze icons

[Nathaniel Graham]

ngraham added a comment.


  Yes, looks very nice. Please feel free to work on this. My efforts were not 
very successful due to limited CMake knowledge and use of shell scripts instead 
of something more cross-platform like Python.

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham
Cc: davidhurka, mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, 
manueljlin, Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi added a comment.


  @dfaure, any opinion on this revision ?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 77426.
crossi added a comment.


  rebase

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=77049=77426

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/KConfigXmlParser.h
  src/kconfig_compiler/kcfg.xsd

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27986: Allow providing an error message from the application

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, sitter.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Allows us keep the message provided by QQuickWindow::sceneGraphError to later 
have on our bug reports.
  https://doc.qt.io/qt-5/qquickwindow.html#sceneGraphError
  These are generally problems at the OpenGL level that the user will usually 
be unable to take action on.
  
  CCBUG: 375913

TEST PLAN
  See D27985 

REPOSITORY
  R285 KCrash

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27986

AFFECTED FILES
  src/kcrash.cpp
  src/kcrash.h

To: apol, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27985: Include s_kcrashErrorMessage in our traces

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, sitter.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  CCBUG: 375913

TEST PLAN
  Called `kill -SIGSEGV plasma-discover` and got to see the string I passed.

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27985

AFFECTED FILES
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc

To: apol, #frameworks, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Nathaniel Graham]

ngraham added a comment.


  Excellent. The behavior seems correct to me now. There are a few more issues 
I've like to bring up:
  
  - While dragging, the cursor always shows a "copying" icon, even though with 
the patch local drags result in a move. Anytime the file will be moved without 
showing the drop menu, it should show the move cursor, which looks like a 
grabbing hand
  - When dragging and dropping a file to a writable location on another 
partition, we should always show the drop menu. See the discussion in 
https://bugs.kde.org/show_bug.cgi?id=392531. I don't think there's any chance 
that David will accept the patch in its current state if it moves by default 
across partitions/disks without asking first.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D23926: Move "Details" tab to second place in Properties dialog

[Nathaniel Graham]

ngraham added a comment.


  This needs a rebase.

INLINE COMMENTS

> kpropertiesdialog.cpp:643
> +if (ptr->serviceId() == 
> QStringLitteral("baloofilepropertiesplugin")) {
> +q->insertPluginAt(plugin,1);
> +} else {

space before the comma

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, 
pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D27983: Make find-location show a magnifier on a map, to be different to mark-location

[Nathaniel Graham]

ngraham added subscribers: ndavis, ngraham.
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  This is a waaay nicer and more visually communicative icon. You did the 
stylesheet perfectly and everything is pixel-aligned. Excellent job!
  
  @ndavis?

REPOSITORY
  R266 Breeze Icons

BRANCH
  create-find-location

REVISION DETAIL
  https://phabricator.kde.org/D27983

To: davidhurka, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Nathaniel Graham]

ngraham added a dependent revision: D27979: [WIP] Add top area to notifications.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D21466: Recommend rebooting after installing Samba

[Aleix Pol Gonzalez]

apol added a comment.


  So yes, Discover will notify about updates. That doesn't mean it should be 
shown here too.
  
  If anything, we should be pushing for such updates to happen at 
startup/shutdown because it doesn't seem like the user benefits from it being 
swapped at runtime, but that's a different question.
  
  HTH

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21466

To: ngraham, #vdg, #frameworks, #dolphin, apol
Cc: sitter, bruns

D27983: Make find-location show a magnifier on a map, to be different to mark-location

[David Hurka]

davidhurka edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27983

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27983: Make find-location show a magnifier on a map, to be different to mark-location

[David Hurka]

davidhurka created this revision.
davidhurka added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REVISION SUMMARY
  This changes find-location, and adds the 22px variant.
  BUG: 407061

REPOSITORY
  R266 Breeze Icons

BRANCH
  create-find-location

REVISION DETAIL
  https://phabricator.kde.org/D27983

AFFECTED FILES
  icons-dark/actions/16/find-location.svg
  icons-dark/actions/22/find-location.svg
  icons-dark/actions/symbolic/find-location-symbolic.svg
  icons/actions/16/find-location.svg
  icons/actions/22/find-location.svg
  icons/actions/symbolic/find-location-symbolic.svg

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  Is there a reason why we can't do this? I like it...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77418.
niccolove added a comment.


  Trailing spaces

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=77408=77418

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml

To: niccolove, mart
Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77408.
niccolove added a comment.


  use heading instead of header

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=77405=77408

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml

To: niccolove, mart
Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D27444: Added plasmoid heading svg

[Niccolò Venerandi]

niccolove edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added plasmoid heading svg

[Niccolò Venerandi]

niccolove retitled this revision from "Added top area" to "Added plasmoid 
heading svg".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added top area

[Niccolò Venerandi]

niccolove updated this revision to Diff 77407.
niccolove added a comment.


  Changed filename to heading

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=77272=77407

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77405.
niccolove added a comment.


  bottomPadding rather than bottomMargin

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=77404=77405

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml

To: niccolove, mart
Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77404.
niccolove added a comment.


  Missed a PlasmoidHeading.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=77402=77404

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml

To: niccolove, mart
Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77402.
niccolove added a comment.


  Local is not a type

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=77271=77402

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml

To: niccolove, mart
Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D27445: Move tasks from 3px to 2px

[Niccolò Venerandi]

niccolove abandoned this revision.
niccolove added a comment.


  I'd actually prefer to make the task manager extend to panel borders.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27445

To: niccolove, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D25010

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27965: [KPasswdServer] replace foreach with range/index-based for

[Ahmad Samir]

ahmadsamir added a comment.


  In D27965#625526 , @apol wrote:
  
  > Having the iterated value change under the hood will eventually break. I'd 
suggest preferring QList::erase to QList::removeOne.
  
  
  Actually, the code also uses 'delete current', now if there's another 
instance of that AuthInfoContainer* in authList, on a next iteration accessing 
the pointer "current" would be invalid as the object it had pointed to has been 
already delete'ed... I think removeAll() would be a better fit; WDYT?

REPOSITORY
  R241 KIO

BRANCH
  l-kpasswdserver (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27965

To: ahmadsamir, #frameworks, dfaure, meven
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 273 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/273/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 11 Mar 2020 08:35:32 +
 Build duration:
3 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

D27913: Icons for emoji categories

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:90ed6fdf4317: Icons for emoji categories (authored by Guo 
Yunhe i...@guoyunhe.me).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27913?vs=77169=77393

REVISION DETAIL
  https://phabricator.kde.org/D27913

AFFECTED FILES
  icons-dark/actions/22/animal.svg
  icons-dark/actions/22/food.svg
  icons-dark/actions/22/smiley.svg
  icons/actions/22/animal.svg
  icons/actions/22/food.svg
  icons/actions/22/smiley.svg

To: guoyunhe, #breeze, ndavis
Cc: ndavis, apol, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 159 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/159/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 11 Mar 2020 08:35:32 +
 Build duration:
3 min 18 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 166 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/166/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 11 Mar 2020 08:35:32 +
 Build duration:
1 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi updated this revision to Diff 77391.
trmdi added a comment.


  Code style

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27951?vs=77390=77391

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27951

AFFECTED FILES
  src/widgets/dropjob.cpp

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi updated this revision to Diff 77390.
trmdi added a comment.


  Code style

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27951?vs=77389=77390

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27951

AFFECTED FILES
  src/widgets/dropjob.cpp

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi updated this revision to Diff 77389.
trmdi added a comment.


  Apply only when all items are local.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27951?vs=77351=77389

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27951

AFFECTED FILES
  src/widgets/dropjob.cpp

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D23926: Move "Details" tab to second place in Properties dialog

[Matej Mrenica]

mthw updated this revision to Diff 77388.
mthw added a comment.


  - Made recomemded changes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23926?vs=66003=77388

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23926

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp
  src/widgets/kpropertiesdialog.h

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, 
pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Méven Car]

meven updated this revision to Diff 77386.
meven added a comment.


  Improve comment of StatJob *statDetails

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25010?vs=77385=77386

BRANCH
  arcpatch-D25010

REVISION DETAIL
  https://phabricator.kde.org/D25010

AFFECTED FILES
  autotests/jobremotetest.cpp
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/CMakeLists.txt
  src/core/copyjob.cpp
  src/core/deletejob.cpp
  src/core/directorysizejob.cpp
  src/core/global.h
  src/core/statjob.cpp
  src/core/statjob.h
  src/filewidgets/kdiroperator.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/krun.cpp
  src/widgets/paste.cpp
  tests/kioslavetest.cpp
  tests/listjobtest.cpp

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Méven Car]

meven updated this revision to Diff 77385.
meven added a comment.


  Fix typo, make StatJob::setDetails(KIO::StatDetail detail) build only when 
build_deprecated(5.69) is set

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25010?vs=77235=77385

BRANCH
  arcpatch-D25010

REVISION DETAIL
  https://phabricator.kde.org/D25010

AFFECTED FILES
  autotests/jobremotetest.cpp
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/CMakeLists.txt
  src/core/copyjob.cpp
  src/core/deletejob.cpp
  src/core/directorysizejob.cpp
  src/core/global.h
  src/core/statjob.cpp
  src/core/statjob.h
  src/filewidgets/kdiroperator.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/krun.cpp
  src/widgets/paste.cpp
  tests/kioslavetest.cpp
  tests/listjobtest.cpp

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns