D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise marked an inline comment as done.
cochise added inline comments.

INLINE COMMENTS

> usta wrote in jobtest.cpp:531
> typo :) xattRreader => xattrReader

I really need to sleep, rs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise updated this revision to Diff 78777.
cochise added a comment.


  typo

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17816?vs=78776&id=78777

BRANCH
  arcpatch-D17816_1

REVISION DETAIL
  https://phabricator.kde.org/D17816

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/ConfigureChecks.cmake
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Ömer Fadıl Usta]

usta requested changes to this revision.
usta added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> jobtest.cpp:531
> +
> +QProcess xattRreader;
> +xattRreader.setProcessChannelMode(QProcess::MergedChannels);

typo :) xattRreader => xattrReader

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise marked 3 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise updated this revision to Diff 78776.
cochise added a comment.


  Camel case

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17816?vs=78773&id=78776

BRANCH
  arcpatch-D17816_1

REVISION DETAIL
  https://phabricator.kde.org/D17816

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/ConfigureChecks.cmake
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D28396: [MTimeDB] Consolidate time interval handling code

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  There are two places where half-bounded time intervals with [<=,<,==,>,>=]
  are handled, once in the SearchStore, and once in the MtimeDB itself
  (where the latter only has [<=,==,>=]).
  
  Remove the handling from the MtimeDB and only keep the one in the
  SearchStore.

TEST PLAN
  ctest -V -R mtimedbtest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28396

AFFECTED FILES
  autotests/unit/engine/mtimedbtest.cpp
  src/engine/mtimedb.cpp
  src/engine/mtimedb.h
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/lib/searchstore.cpp
  src/lib/searchstore.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17816: Support for xattrs on kio copy/move

[Ömer Fadıl Usta]

usta requested changes to this revision.
usta added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> jobtest.cpp:500
> +
> +QProcess xattrwriter;
> +xattrwriter.setProcessChannelMode(QProcess::MergedChannels);

aren't we using camelcase rules for variables in kde ? is so xattrwriter => 
xattrWriter

> jobtest.cpp:531
> +
> +QProcess xattrreader;
> +xattrreader.setProcessChannelMode(QProcess::MergedChannels);

camelCase ?  xattrreader => xattrReader

> file_unix.cpp:167
> +// Linux and MacOS return = list of null terminated string, each string 
> = [data,'\0']
> +// BSD return = list of itens, each item prepended of 1 byte size = 
> [size, data]
> +

small typo in comment : itens => items

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[Noah Davis]

ndavis added a comment.


  In T12855#224570 , @davidhurka 
wrote:
  
  > Can anyone explain why rating-unrated and semi-starred-symbolic[-rtl] have 
50% transparency, while rating has 100% opacity? That makes my compare script 
go wild, and I think it doesn’t look intended.
  
  
  Any inconsistencies in the `-symbolic` icons are probably unintentional

TASK DETAIL
  https://phabricator.kde.org/T12855

To: ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

D28391: [pc3/busyindicator] Hide when not running

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  running

REVISION DETAIL
  https://phabricator.kde.org/D28391

To: nicolasfella, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise updated this revision to Diff 78773.
cochise marked an inline comment as done.
cochise added a comment.


  missed cast

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17816?vs=78769&id=78773

BRANCH
  arcpatch-D17816_1

REVISION DETAIL
  https://phabricator.kde.org/D17816

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/ConfigureChecks.cmake
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise marked an inline comment as done.
cochise added a comment.


  done

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> jobtest.cpp:105
> + /
> +m_getXattrCmd = 
> QStandardPaths::findExecutable("getfattr").split("/").last();
> +if (m_getXattrCmd == "getfattr") {

Whats the reason to split off the path?
Also, you can not just concatenate the command and args, see 
https://doc.qt.io/qt-5/qprocess.html#details

  struct ProgramWithArgs { QString program; QStringList args; };
  QVector xattrprograms = {
  { {"getfattr", {}},   {"setfattr", {}} },
  { {"getextattr", {}}, {"setextattr", {}} },
  { {"xattr", {"-p}},   {"xattr", {"-w"}} },
  };
  for (auto& getset : xattrprograms) {
  m_getXattrCmd.program = 
QStandardPaths::findExecutable(getset.first.program);
  m_setXattrCmd.program = 
QStandardPaths::findExecutable(getset.second.program);
  if (!m_getXattrCmd.programm.isEmpty() && 
!m_setXattrCmd.programm.isEmpty()) {
  m_getXattrCmd.args = getset.first.args;
  m_setXattrCmd.args = getset.second.args;
  break;
  }
  } 
  if (m_getXattrCmd.isEmpty() || m_getXattrCmd.isEmpty()) {
  qWarning() << "Neither getfattr, getextattr nor xattr was found.";
  }

> jobtest.cpp:512
> +QVERIFY(xattrwriter.waitForStarted());
> +QCOMPARE(xattrwriter.state(), QProcess::Running);
> +QVERIFY(xattrwriter.waitForFinished(-1));

This seem bogus to me - what guarantees the process has not already finished?

> jobtest.cpp:524
> +
> +void JobTest::compareXattr(const QString &src, const QString &dest)
> +{

void JobTest::compareXattr(const QString &src, const QString &dest)
  {
  auto srcAttrs = readXattr(src);
  auto destAttrs = readXattr(dest);
  QCOMPARE(srcAttrs, destAttrs);
  }
  
  QList JobTest::readXattr(const QString &path)
  {

> jobtest.cpp:536
> +QVERIFY(xattrreader.waitForStarted());
> +QCOMPARE(xattrreader.state(), QProcess::Running);
> +QVERIFY(xattrreader.waitForFinished(-1));

dito

> file_unix.cpp:180
> +#elif HAVE_SYS_EXTATTR_H
> +keyLen = *keyPtr;
> +keyPtr++;

`*keyPtr` needs cast to unsigned char.

> file_unix.cpp:232
> +keyPtr += keyLen;
> +#endif
> +}

what about `#elif defined(Q_OS_MAC)`?

> file_unix.cpp:148
> +#endif
> +if (listlen == -1) {
> +qCDebug(KIO_FILE) << "libc failed to extract list of xattr from 
> file";

You never check if the source FS supports xattrs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi added a comment.


  In D27951#637038 , @dfaure wrote:
  
  > Indeed. Bug in kio_file, fixed in D28388 
.
  
  
  Ok, it works for symlinks now.
  How about normal files in a KDE Connect's mountpoint? It still have the same 
device id with the root partition.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D28393: [Term] Provide toString(Term) overload for QTest

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Without the overload QTest only provides the generic "Compared values
  are not the same" message, without any details.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28393

AFFECTED FILES
  src/lib/term.cpp
  src/lib/term.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28394: [AdvancedQueryParser] Test if quoted phrases are passed correctly

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

TEST PLAN
  ctest -V -R advancedqueryparsertest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28394

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28392: [ResultIterator] Remove unneeded SearchStore forward declaration

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  SearchStore is not even exported, while ResultIterator is.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28392

AFFECTED FILES
  src/lib/resultiterator.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise marked an inline comment as done.
cochise added inline comments.

INLINE COMMENTS

> dfaure wrote in file_unix.cpp:179
> Ah, I see, you still need to call `strlen()` yourself, for the code at the 
> end of the iteration
> 
> Well, then you might as well pass the value to the constructor so it doesn't 
> need to do the same.
> 
>   const QByteArray key(keyPtr, keyLen);
> 
> after the #endif, since it would now be the exact same line of code for both 
> cases.

This look really better.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise updated this revision to Diff 78769.
cochise added a comment.


  Simplify.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17816?vs=78767&id=78769

BRANCH
  arcpatch-D17816_1

REVISION DETAIL
  https://phabricator.kde.org/D17816

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/ConfigureChecks.cmake
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.14/4/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 29 Mar 2020 00:07:10 +
 Build duration:
49 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_read_hdr

D17816: Support for xattrs on kio copy/move

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> file_unix.cpp:179
> +keyLen = strlen(keyPtr);
> +QByteArray key(keyPtr);
> +#elif HAVE_SYS_EXTATTR_H

Ah, I see, you still need to call `strlen()` yourself, for the code at the end 
of the iteration

Well, then you might as well pass the value to the constructor so it doesn't 
need to do the same.

  const QByteArray key(keyPtr, keyLen);

after the #endif, since it would now be the exact same line of code for both 
cases.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise added inline comments.

INLINE COMMENTS

> dfaure wrote in file_unix.cpp:184
> You're doing two copies here. From `offset` to `key.data()`, and then from 
> `key.data()` -- the return value of qstrcpy -- into the QByteArray key (which 
> calls the QByteArray(const char*) constructor).
> 
> This can be simplified.
> Option 1: just remove the assignment, just do the qstrcpy. But it still 
> smells like C to me. And there's a security bug if keyLen is ever too small.
> Option 2: QByteArray key(offset); So simple. No need for strlen before, no 
> need for qstrcpy, it all happens internally in that constructor.

So many time looking for a way to get a copy until a null, and it's in one of 
the constructors.
This looks a lot better.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.14 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.14/3/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 28 Mar 2020 23:48:24 +
 Build duration:
56 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_read_hdr

D28391: [pc3/busyindicator] Hide when not running

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  When not running the indicator should be invisible. This matches the 
behaviour of the org.kde.desktop style.

TEST PLAN
  Run KTrip with Plasma style. Open location search page. Indicator is only 
shown when actually loading things

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  running

REVISION DETAIL
  https://phabricator.kde.org/D28391

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/BusyIndicator.qml

To: nicolasfella, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise updated this revision to Diff 78767.
cochise marked 6 inline comments as done.
cochise added a comment.


  Move away from strcpy =]

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17816?vs=78763&id=78767

BRANCH
  arcpatch-D17816_1

REVISION DETAIL
  https://phabricator.kde.org/D17816

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/ConfigureChecks.cmake
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[David Faure]

dfaure added a comment.


  Almost there ;)

INLINE COMMENTS

> file_unix.cpp:140
> +{
> +// Get the size of the list of keys from soure file
> +#if HAVE_SYS_XATTR_H && !defined(__stub_getxattr) && !defined(Q_OS_MAC)

typo: soure => source

> file_unix.cpp:153
> +if (listlen == 0) {
> +qCDebug(KIO_FILE) << "file " << src_fd << " don't have any xattr";
> +return false;

No need for spaces (after "file" and before "don't"), q[C]Debug inserts spaces 
automatically

> file_unix.cpp:166
> +#endif
> +// Linux and MacOS return = list of null terminated string, each srting 
> = [data,'\0']
> +// BSD return = list of itens, each item prepended of 1 byte size = 
> [size, data]

typo: srting => string

> file_unix.cpp:169
> +
> +QByteArray::const_iterator offset = keylist.cbegin();
> +size_t keyLen;

To me an offset is an integer that represents a relative index.

This is more like a source pointer, or keyData or something like that.

> file_unix.cpp:184
> +#if HAVE_SYS_XATTR_H
> +key = qstrcpy(key.data(), offset);
> +#elif HAVE_SYS_EXTATTR_H

You're doing two copies here. From `offset` to `key.data()`, and then from 
`key.data()` -- the return value of qstrcpy -- into the QByteArray key (which 
calls the QByteArray(const char*) constructor).

This can be simplified.
Option 1: just remove the assignment, just do the qstrcpy. But it still smells 
like C to me. And there's a security bug if keyLen is ever too small.
Option 2: QByteArray key(offset); So simple. No need for strlen before, no need 
for qstrcpy, it all happens internally in that constructor.

> file_unix.cpp:186
> +#elif HAVE_SYS_EXTATTR_H
> +key = qstrncpy(key.data(), offset, keyLen);
> +#endif

Same problem here. Similar solution: QByteArray key(offset, keyLen);

This removes the need for key.resize() before. Which also removes the need for 
the two parallel series of ifdefs, you can just merge them.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D28390: KIO: remove waitForStarted() from the launcher jobs public API

[David Faure]

dfaure created this revision.
dfaure added reviewers: davidedmundson, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  This only exists for KRun. I don't want apps to start using that.
  We have to be able to remove waitForStarted() in KF6 so that we can do other
  async things before starting the process (like resolving URLs, making async 
dbus
  calls for FUSE stuff etc.)
  
  - Rename KRun::KRunPrivate to KRunPrivate so that we can declare it as friend 
in the job classes
  - Move two file-static methods in krun.cpp into the KRunPrivate class so they 
benefit from this

TEST PLAN
  It builds

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28390

AFFECTED FILES
  src/gui/applicationlauncherjob.h
  src/gui/commandlauncherjob.h
  src/widgets/krun.cpp
  src/widgets/krun.h
  src/widgets/krun_p.h

To: dfaure, davidedmundson, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

[David Faure]

dfaure added a reviewer: meven.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28388

To: dfaure, trmdi, ahmadsamir, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

[David Faure]

dfaure created this revision.
dfaure added reviewers: trmdi, ahmadsamir.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  This was inconsistent, for everything else we follow symlinks,
  unless StatResolveSymlink isn't set.

TEST PLAN
  see D27951 

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28388

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp

To: dfaure, trmdi, ahmadsamir
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[David Faure]

dfaure added a comment.


  Indeed. Bug in kio_file, fixed in D28388 .

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise updated this revision to Diff 78763.
cochise marked an inline comment as done.
cochise added a comment.


  trailing space

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17816?vs=78760&id=78763

BRANCH
  arcpatch-D17816_1

REVISION DETAIL
  https://phabricator.kde.org/D17816

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/ConfigureChecks.cmake
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi added a comment.


  In D27951#636980 , @dfaure wrote:
  
  > Seems to work for symlinks here. We *don't* want it to follow symlinks, 
right?
  >
  > I have /opt a symlink to /d/opt, where /d is on another partition
  >
  > $ kioclient5 openProperties /opt
  >  DEVICE 65025
  >
  > $ kioclient5 openProperties /d/opt 
  >  DEVICE 65028
  >
  > Different, as expected.
  
  
  No, we want /opt and /d/opt to have the same device id.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise marked 3 inline comments as done.
cochise added inline comments.

INLINE COMMENTS

> dfaure wrote in file_unix.cpp:183
> What's the purpose of these two lines modifying `key`, given that the next 
> line assigns to `key` anyway?

Removed clear, as is redundant.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise updated this revision to Diff 78760.
cochise added a comment.


  Using a STL-style iterator for keyList and qstrcpy and qtrncpy to get each 
key value.
  Small fixes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17816?vs=77962&id=78760

BRANCH
  arcpatch-D17816_1

REVISION DETAIL
  https://phabricator.kde.org/D17816

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/ConfigureChecks.cmake
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D28387: [QueryTest] Make phrase test case data driven and extend

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Check if also filenames are matched by phrase queries.
  
  Add toString debug helper to get a more meaningful failure output.

TEST PLAN
  ctest -V -R querytest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28387

AFFECTED FILES
  autotests/integration/querytest.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[David Faure]

dfaure added a comment.


  Seems to work for symlinks here. We *don't* want it to follow symlinks, right?
  
  I have /opt a symlink to /d/opt, where /d is on another partition
  
  $ kioclient5 openProperties /opt
  DEVICE 65025
  
  $ kioclient5 openProperties /d/opt 
  DEVICE 65028
  
  Different, as expected.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Nathaniel Graham]

ngraham resigned from this revision.
ngraham added a comment.


  Maybe it was that darned plasma cache! Re-applying the patch and clearing the 
cache substantially improved the appearance. It would be helpful to remind 
people of those details in the Test Plan section in the future. :)
  
  Looking at it for realziez, I think it's okay. The appearance is indeed 
improved IMO when the wallpaper is visible, especially when the wallpaper is 
very visually striking: F8203301: Screenshot_20200328_123057.png 

  
  However as you can see from that screenshot, the background color of the 
pop-up still differs from the color of the panel.
  
  And the panel transparency effect is still a bit too pronounced for my tastes 
when a visually striking wallpaper is being covered by windows and only the 
panel is still visible. It results in a significant difference between the 
background colors of the panel and plasma pop-ups that appear on top of 
windows: F8203294: Screenshot_20200328_122908.png 

  
  I might have proposed this before, but I think an improvement would be to 
dynamically change the transparency of the panel and pop-ups from widgets 
living in it based on the proximity of windows; when a window is butted up 
against a panel, the background color of that panel as well as all pop-ups of 
widgets living on that panel would become opaque, and when the window moved 
away, un-maximized, or tiled, they would resume being transparent. I think this 
would look //great// and would seem to satisfy everyone: people who want pretty 
transparency when the wallpaper is visible would get it, and people who want 
maximum legibility and visual consistency when the system is being used heavily 
would get that too.
  
  Of course that's a bit more ambitious than what could be done in this patch, 
but I think it's a good way forward. However I won't block this patch in its 
current form as it's no longer the usability regression that I originally and 
mistakenly feared.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28384: [Extractor] Delay mimetype check, cleanup debug output

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In case a file is skipped by a name filter there is no need to determine
  the mimetype (which is costly, as a content based mimetype is used here).
  
  Avoid multiple debug messages per file, only issue "Indexing ..." in
  case the file is not skipped. All "Skipping ..." paths have a distinct.
  debug/warning message.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28384

AFFECTED FILES
  src/file/extractor/app.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi added a comment.


  In D27951#636646 , @dfaure wrote:
  
  > Note sure how you're testing UDS_* but you need to pass KIO::StatInode to 
KIO::statDetails for inode and device ID to be filled in.
  >
  > Testcase: apply http://www.davidfaure.fr/2020/uds_device_test.diff then 
`kioclient5 openProperties ~/.bashrc`
  
  
  
  
  > But at least it should work for regular files and directories, right?
  
  Yes, it does.
  But it still doesn't work as expected for symlink and KDE Connect directory. 
These 2 cases have the same device id with the root partition. Do I do it wrong?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D28372: Added a merged look to the plasmoidheading and remove roundedborders

[Niccolò Venerandi]

niccolove marked an inline comment as done.
niccolove added inline comments.

INLINE COMMENTS

> davidedmundson wrote in PlasmoidHeading.qml:77
> What should happen if this is set to merged and someone uses a theme that 
> doesn't have a merged- prefix?
> 
> The old SVG or no SVG at all?

I'd go with no SVG, to make sure that the theme creators will see that it's 
broken and add a merged- look. Keep in mind that the plasmoidheading svg was 
added barely one month ago, and no big Plasma release had it yet, so I find it 
very hard to believe that any third party theme already has it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28372

To: niccolove, #plasma
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28302: [KNewFileMenu] Add extension to proposed filename

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ad0bbeebc568: [KNewFileMenu] Add extension to proposed 
filename (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28302?vs=78731&id=78743

REVISION DETAIL
  https://phabricator.kde.org/D28302

AFFECTED FILES
  autotests/knewfilemenutest.cpp
  src/filewidgets/knewfilemenu.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28372: Added a merged look to the plasmoidheading and remove roundedborders

[Niccolò Venerandi]

niccolove updated this revision to Diff 78742.
niccolove added a comment.


  Specified false by default

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28372?vs=78721&id=78742

BRANCH
  merged-plasmoidheading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28372

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #plasma
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28302: [KNewFileMenu] Add extension to proposed filename

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  l-template-proposed-file-name-ext (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28302

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:10971279a3e7: Ki18n: Convert license headers to SPDX 
statements (authored by cordlandwehr).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27245?vs=75592&id=78740

REVISION DETAIL
  https://phabricator.kde.org/D27245

AFFECTED FILES
  LICENSES/BSD-3-Clause.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/ki18ndeclarativetest.cpp
  autotests/klocalizedstringtest.cpp
  autotests/klocalizedstringtest.h
  autotests/ktranscriptcleantest.cpp
  autotests/ktranscriptcleantest.h
  autotests/ktranscripttest.cpp
  autotests/ktranscripttest.h
  autotests/testhelpers.cpp
  autotests/testhelpers.h
  cmake/FindLibIntl.cmake
  cmake/KF5I18nMacros.cmake.in
  cmake/build-pofiles.cmake
  cmake/build-tsfiles.cmake
  cmake/kf5i18nuic.cmake
  cmake/rules_PyKF5.py
  src/common_helpers.cpp
  src/common_helpers_p.h
  src/config.h.in
  src/gettext.h
  src/kcatalog.cpp
  src/kcatalog_p.h
  src/klocalizedcontext.cpp
  src/klocalizedcontext.h
  src/klocalizedstring.cpp
  src/klocalizedstring.h
  src/klocalizedtranslator.cpp
  src/klocalizedtranslator.h
  src/ktranscript.cpp
  src/ktranscript_p.h
  src/kuitmarkup.cpp
  src/kuitmarkup.h
  src/kuitmarkup_p.h
  src/kuitsetup.h
  src/main.cpp

To: cordlandwehr, cgiboudeaux
Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R249 KI18n

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27245

To: cordlandwehr, cgiboudeaux
Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28379: KWidgetsAddons: Convert copyright headers to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D28379

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28379: KWidgetsAddons: Convert copyright headers to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert copyright headers to SPDX expressions and add license
  texts as required by REUSE specification.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D28379

AFFECTED FILES
  LICENSES/BSD-3-Clause.txt
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-2.1-or-later.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LGPL-3.0-or-later.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/kacceleratormanagertest.cpp
  autotests/kcharselect_unittest.cpp
  autotests/kcollapsiblegroupbox_test.cpp
  autotests/kcollapsiblegroupbox_test.h
  autotests/kcolorbuttontest.cpp
  autotests/kcolorbuttontest.h
  autotests/kcolumnresizertest.cpp
  autotests/kcolumnresizertest.h
  autotests/kdatecomboboxtest.cpp
  autotests/kdatecomboboxtest.h
  autotests/kdatetimeedittest.cpp
  autotests/kdatetimeedittest.h
  autotests/kdualactiontest.cpp
  autotests/kmessagewidgetautotest.cpp
  autotests/kmessagewidgetautotest.h
  autotests/knewpasswordwidgettest.cpp
  autotests/knewpasswordwidgettest.h
  autotests/kpagedialogautotest.cpp
  autotests/kpagedialogautotest.h
  autotests/kpassworddialogautotest.cpp
  autotests/kpassworddialogautotest.h
  autotests/kpasswordlineedittest.cpp
  autotests/kpasswordlineedittest.h
  autotests/kpixmapsequencewidgettest.cpp
  autotests/kselectaction_unittest.cpp
  autotests/kselectaction_unittest.h
  autotests/ksplittercollapserbuttontest.cpp
  autotests/ksplittercollapserbuttontest.h
  autotests/ksqueezedtextlabelautotest.cpp
  autotests/ksqueezedtextlabelautotest.h
  autotests/ktimecomboboxtest.cpp
  autotests/ktimecomboboxtest.h
  autotests/ktooltipwidgettest.cpp
  autotests/ktooltipwidgettest.h
  cmake/rules_PyKF5.py
  examples/kmessagebox/main.cpp
  src/common_helpers.cpp
  src/common_helpers_p.h
  src/fonthelpers.cpp
  src/fonthelpers_p.h
  src/kacceleratormanager.cpp
  src/kacceleratormanager.h
  src/kacceleratormanager_p.h
  src/kactionmenu.cpp
  src/kactionmenu.h
  src/kactionselector.cpp
  src/kactionselector.h
  src/kanimatedbutton.cpp
  src/kanimatedbutton.h
  src/kassistantdialog.cpp
  src/kassistantdialog.h
  src/kbusyindicatorwidget.cpp
  src/kbusyindicatorwidget.h
  src/kcapacitybar.cpp
  src/kcapacitybar.h
  src/kcharselect-generate-datafile.py
  src/kcharselect-translation.cpp
  src/kcharselect.cpp
  src/kcharselect.h
  src/kcharselect_p.h
  src/kcharselectdata.cpp
  src/kcharselectdata_p.h
  src/kcollapsiblegroupbox.cpp
  src/kcollapsiblegroupbox.h
  src/kcolorbutton.cpp
  src/kcolorbutton.h
  src/kcolorcombo.cpp
  src/kcolorcombo.h
  src/kcolumnresizer.cpp
  src/kcolumnresizer.h
  src/kcursor.cpp
  src/kcursor.h
  src/kcursor_p.h
  src/kdatecombobox.cpp
  src/kdatecombobox.h
  src/kdatepicker.cpp
  src/kdatepicker.h
  src/kdatepicker_p.h
  src/kdatetable.cpp
  src/kdatetable_p.h
  src/kdatetimeedit.cpp
  src/kdatetimeedit.h
  src/kdragwidgetdecorator.cpp
  src/kdragwidgetdecorator.h
  src/kdualaction.cpp
  src/kdualaction.h
  src/kdualaction_p.h
  src/keditlistwidget.cpp
  src/keditlistwidget.h
  src/kfontaction.cpp
  src/kfontaction.h
  src/kfontchooser.cpp
  src/kfontchooser.h
  src/kfontrequester.cpp
  src/kfontrequester.h
  src/kfontsizeaction.cpp
  src/kfontsizeaction.h
  src/kguiitem.cpp
  src/kguiitem.h
  src/kled.cpp
  src/kled.h
  src/kmessagebox.cpp
  src/kmessagebox.h
  src/kmessagebox_p.cpp
  src/kmessagebox_p.h
  src/kmessageboxdontaskagaininterface.h
  src/kmessageboxnotifyinterface.h
  src/kmessagewidget.cpp
  src/kmessagewidget.h
  src/kmimetypechooser.cpp
  src/kmimetypechooser.h
  src/kmimetypeeditor.cpp
  src/kmimetypeeditor.h
  src/kmultitabbar.cpp
  src/kmultitabbar.h
  src/kmultitabbar_p.h
  src/knewpassworddialog.cpp
  src/knewpassworddialog.h
  src/knewpasswordwidget.cpp
  src/knewpasswordwidget.h
  src/kpagedialog.cpp
  src/kpagedialog.h
  src/kpagedialog_p.h
  src/kpagemodel.cpp
  src/kpagemodel.h
  src/kpagemodel_p.h
  src/kpageview.cpp
  src/kpageview.h
  src/kpageview_p.cpp
  src/kpageview_p.h
  src/kpagewidget.cpp
  src/kpagewidget.h
  src/kpagewidget_p.h
  src/kpagewidgetmodel.cpp
  src/kpagewidgetmodel.h
  src/kpagewidgetmodel_p.h
  src/kpassworddialog.cpp
  src/kpassworddialog.h
  src/kpasswordlineedit.cpp
  src/kpasswordlineedit.h
  src/kpixmapregionselectordialog.cpp
  src/kpixmapregionselectordialog.h
  src/kpixmapregionselectorwidget.cpp
  src/kpixmapregionselectorwidget.h
  src/kpixmapsequence.cpp
  src/kpixmapsequence.h
  src/kpixmapsequenceoverlaypainter.cpp
  src/kpixmapsequenceoverlaypainter.h
  src/kpixmapsequencewidget.cpp
  src/kpixmapsequencewidget.h
  src/kpopupframe.cpp
  src/kpopupframe.h
  src/kratingpainter.cpp
  src/kratingpainter.h
  src/kratingwidget.cpp
  src/kratingwidget.h
  src/kruler.cpp
  src/kruler.h
 

D28372: Added a merged look to the plasmoidheading and remove roundedborders

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> PlasmoidHeading.qml:58
> + * If false, the plasmoidheading will display a separator. If true, it 
> will be considered merged
> + * with another plasmoidheading and the separator won't be showed.
> + */

Worth writing "the default value is false" in the docs, as it's what most 
people look for.

> PlasmoidHeading.qml:77
>  imagePath: "widgets/plasmoidheading"
> -prefix: location == PlasmoidHeading.Location.Header? 'header' : 
> 'footer'
> -enabledBorders: {
> -var borders = new Array()
> -borders |= PlasmaCore.FrameSvg.LeftBorder
> -borders |= PlasmaCore.FrameSvg.RightBorder
> -if (plasmoid.location !== PlasmaCore.Types.TopEdge || location 
> != PlasmoidHeading.Location.Header) {
> -borders |= PlasmaCore.FrameSvg.TopBorder
> -}
> -if (plasmoid.location !== PlasmaCore.Types.BottomEdge || 
> location != PlasmoidHeading.Location.Footer) {
> -borders |= PlasmaCore.FrameSvg.BottomBorder
> -}
> -return borders
> -}
> +prefix: (merged ? 'merged-' : '') + (location == 
> PlasmoidHeading.Location.Header? 'header' : 'footer')
>  }

What should happen if this is set to merged and someone uses a theme that 
doesn't have a merged- prefix?

The old SVG or no SVG at all?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28372

To: niccolove, #plasma
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27741: KCodecs: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
cordlandwehr marked an inline comment as done.
Closed by commit R270:25365771652b: KCodecs: Convert license statements to SPDX 
expressions (authored by cordlandwehr).

REPOSITORY
  R270 KCodecs

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27741?vs=76689&id=78733

REVISION DETAIL
  https://phabricator.kde.org/D27741

AFFECTED FILES
  LICENSES/BSD-3-Clause.txt
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-or-later.txt
  LICENSES/MIT.txt
  LICENSES/MPL-1.1.txt
  autotests/base64benchmark.cpp
  autotests/codectest.cpp
  autotests/codectest.h
  autotests/kcharsetstest.cpp
  autotests/kcharsetstest.h
  autotests/kcodecstest.cpp
  autotests/kcodecstest.h
  autotests/kemailaddresstest.cpp
  autotests/kemailaddresstest.h
  autotests/kencodingprobertest.cpp
  autotests/kencodingprobertest.h
  autotests/rfc2047test.cpp
  autotests/rfc2047test.h
  cmake/rules_PyKF5.py
  src/kcharsets.cpp
  src/kcharsets.h
  src/kcodecs.cpp
  src/kcodecs.h
  src/kcodecs_p.h
  src/kcodecsbase64.cpp
  src/kcodecsbase64.h
  src/kcodecsidentity.cpp
  src/kcodecsidentity.h
  src/kcodecsqp.cpp
  src/kcodecsqp.h
  src/kcodecsuuencode.cpp
  src/kcodecsuuencode.h
  src/kemailaddress.cpp
  src/kemailaddress.h
  src/kencodingprober.cpp
  src/kencodingprober.h
  src/kentities.gperf
  src/probers/CharDistribution.cpp
  src/probers/CharDistribution.h
  src/probers/ChineseGroupProber.cpp
  src/probers/ChineseGroupProber.h
  src/probers/JapaneseGroupProber.cpp
  src/probers/JapaneseGroupProber.h
  src/probers/JpCntx.cpp
  src/probers/JpCntx.h
  src/probers/LangBulgarianModel.cpp
  src/probers/LangCyrillicModel.cpp
  src/probers/LangGreekModel.cpp
  src/probers/LangHebrewModel.cpp
  src/probers/LangHungarianModel.cpp
  src/probers/LangThaiModel.cpp
  src/probers/UnicodeGroupProber.cpp
  src/probers/UnicodeGroupProber.h
  src/probers/nsBig5Prober.cpp
  src/probers/nsBig5Prober.h
  src/probers/nsCharSetProber.cpp
  src/probers/nsCharSetProber.h
  src/probers/nsCodingStateMachine.h
  src/probers/nsEUCJPProber.cpp
  src/probers/nsEUCJPProber.h
  src/probers/nsEUCKRProber.cpp
  src/probers/nsEUCKRProber.h
  src/probers/nsEscCharsetProber.cpp
  src/probers/nsEscCharsetProber.h
  src/probers/nsEscSM.cpp
  src/probers/nsGB2312Prober.cpp
  src/probers/nsGB2312Prober.h
  src/probers/nsHebrewProber.cpp
  src/probers/nsHebrewProber.h
  src/probers/nsLatin1Prober.cpp
  src/probers/nsLatin1Prober.h
  src/probers/nsMBCSGroupProber.cpp
  src/probers/nsMBCSGroupProber.h
  src/probers/nsMBCSSM.cpp
  src/probers/nsPkgInt.h
  src/probers/nsSBCSGroupProber.cpp
  src/probers/nsSBCSGroupProber.h
  src/probers/nsSBCharSetProber.cpp
  src/probers/nsSBCharSetProber.h
  src/probers/nsSJISProber.cpp
  src/probers/nsSJISProber.h
  src/probers/nsUniversalDetector.cpp
  src/probers/nsUniversalDetector.h
  src/probers/tables/Big5Freq.tab
  src/probers/tables/EUCKRFreq.tab
  src/probers/tables/GB2312Freq.tab
  src/probers/tables/JISFreq.tab

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28203: Move corner fold to top right in 24 icons

[David Hurka]

davidhurka requested review of this revision.
davidhurka added a comment.


  One potentially important thing: See inline comment.

INLINE COMMENTS

> filename-title-amarok.svg:8
> +}
> +.ColorScheme-ButtonFocus {
> +color:#3daee9;

I realized that http://notmart.org/blog/2016/05/icon-colors/ and 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets 
contratict in the class names. One uses `ColorScheme-Highlight`, the other 
`ColorScheme-ButtonFocus`. breeze-icon-cleaner uses `ColorScheme-ButtonFocus`. 
In the repository I see several icons which use `ColorScheme-Highlight`, and 
only a few which use `ColorScheme-ButtonFocus`.

So which one is correct? I assume that 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets 
needs to be fixed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28302: [KNewFileMenu] Add extension to proposed filename

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78731.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  - Fix unit test
  - Handle the case that a templatePath is a file with no extension

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28302?vs=78717&id=78731

BRANCH
  l-template-proposed-file-name-ext (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28302

AFFECTED FILES
  autotests/knewfilemenutest.cpp
  src/filewidgets/knewfilemenu.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28372: Added a merged look to the plasmoidheading and remove roundedborders

[Niccolò Venerandi]

niccolove added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28372

To: niccolove, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28372: Added a merged look to the plasmoidheading and remove roundedborders

[Niccolò Venerandi]

niccolove retitled this revision from "Added a merged look to the 
plasmoidheading" to "Added a merged look to the plasmoidheading and remove 
roundedborders".
niccolove edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28372

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28372: Added a merged look to the plasmoidheading

[Niccolò Venerandi]

niccolove updated this revision to Diff 78721.
niccolove added a comment.


  Removed rounded borders and thus the enabledBorders check

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28372?vs=78719&id=78721

BRANCH
  merged-plasmoidheading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28372

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28371: [KOpenWithDialog] Add generic name from .desktop files as a tooltip

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:f5d5390f32d2: [KOpenWithDialog] Add generic name from 
.desktop files as a tooltip (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28371?vs=78718&id=78720

REVISION DETAIL
  https://phabricator.kde.org/D28371

AFFECTED FILES
  src/widgets/kopenwithdialog.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28371: [KOpenWithDialog] Add generic name from .desktop files as a tooltip

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  l-kopenwith-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28371

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28372: Added a merged look to the plasmoidheading

[Niccolò Venerandi]

niccolove planned changes to this revision.
niccolove added a comment.


  The rounding in the svgs is not necessary.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28372

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28372: Added a merged look to the plasmoidheading

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Added a merged look (without a separator) so that multiple plasmoidheadings 
can be visually merged (e.g.: in system tray).

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  merged-plasmoidheading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28372

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28302: [KNewFileMenu] Add extension to proposed filename

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> knewfilemenu.cpp:467
>  text = text.trimmed(); // In some languages, there is a space in front 
> of "...", see bug 268895
> +// add the extension but also use the translations from "Name=" entry,
> +// should work with .txt, .html and with ".tar.gz"... etc

"use the translation" is done before that comment, so it's a bit of a confusing 
place for it.

> knewfilemenu.cpp:470
> +const QString fileName = 
> entry.templatePath.mid(entry.templatePath.lastIndexOf(QLatin1Char('/')));
> +text = text + fileName.mid(fileName.indexOf(QLatin1Char('.')));
> +

text += fileName.midRef();

This also assumes all those files always have an extension mid(-1) returns 
the whole string.
Since users can create additional templates, maybe this is worth a >=0 check?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28302

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28371: [KOpenWithDialog] Add generic name from .desktop files as a tooltip

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Extend the current setup by adding a tooltip based on the generic name
  entry from the .desktop files.
  
  This is especially useful for new users who don't know what each application
  in the list can be used for.
  
  CCBUG: 109016

TEST PLAN
  make && ctest
  And a quick test of the openwith dialog, a tooltip is displayed for
  most entries.

REPOSITORY
  R241 KIO

BRANCH
  l-kopenwith-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28371

AFFECTED FILES
  src/widgets/kopenwithdialog.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28302: [KNewFileMenu] Add extension to proposed filename

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78717.
ahmadsamir added a comment.


  - Change it as suggested by dfaure to use the translated text from Name= entry
  - Fix typos

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28302?vs=78535&id=78717

BRANCH
  l-template-proposed-file-name-ext (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28302

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

[David Faure]

dfaure added a comment.


  In D28201#635026 , @broulik wrote:
  
  > I think we should also have a replacement job for `new KRun(url)`
  
  
  Yes, these launcher jobs are the building blocks for finally being able to 
turn KRun into a job (KIO::OpenUrlJob). Work in progress
  
  > and I'd love if we could split out the "default app for this mimetype" 
logic we (also?) have in `KFileItemActions` out into a dedicated public class.
  
  The default app for *this* mimetype (singular) is a one-line call to 
KApplicationTrader::preferredService(mimeType).  (Before last month or so, that 
would have been KMimeTypeTrader).
  What KFileItemActions::associatedApplications does on top of that is handle 
the case of multiple files with multiple mimetypes. Is this the use case you 
have in mind here?
  I can see how it would make total sense to move this to KApplicationTrader as 
well, if it's needed outside KFileItemActions. I can work on that, if you 
confirm that your question here wasn't really about a singular mimetype, but a 
list of mimetypes.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28201

To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28302: [KNewFileMenu] Add extension to proposed filename

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Thanks for all your work, I'm impressed!

INLINE COMMENTS

> knewfilemenu.cpp:464
> +// Prompt the user to set the destination filename, and initially display
> +// the filename from the template including the extenstion, e.g. 
> "TextFile.txt",
> +// "HTMLFile.html" in the line edit

typo: extenstion -> extension

> knewfilemenu.cpp:466
> +// "HTMLFile.html" in the line edit
> +QString text = entry.templatePath;
> +text = text.mid(text.lastIndexOf(QLatin1Char('/')) + 1);

The old code was using a translated string as suggested file name.
You're using a filename that it going to be always in English.

How about appending the extension from templatePath to the translated text?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28302

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28295: Introduce KNotificationJobUiDelegate

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> knotificationjobuidelegate.h:58
> +class Private;
> +Private *const d;
> +};

Using QScopedPointer or std::unique_ptr instead of raw pointer also avoids need 
to manually delete in destructor, also better practice these days.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28295

To: broulik, #frameworks, nicolasfella, dfaure
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[David Faure]

dfaure added a comment.


  Note sure how you're testing UDS_* but you need to pass KIO::StatInode to 
KIO::statDetails for inode and device ID to be filled in.
  
  Testcase: apply http://www.davidfaure.fr/2020/uds_device_test.diff then 
`kioclient5 openProperties ~/.bashrc`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D28295: Introduce KNotificationJobUiDelegate

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> knotificationjobuidelegate.cpp:24
> +
> +class Q_DECL_HIDDEN KNotificationJobUiDelegate::Private
> +{

Not using a nested class `Private` but a normal separate one like here to be 
named `KNotificationJobUiDelegatePrivate` seems more simple, avoids the need 
for things like Q_DECL_HIDDEN.

At least recently most code uses the latter, so would be good to standardize on 
that.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28295

To: broulik, #frameworks, nicolasfella, dfaure
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28295: Introduce KNotificationJobUiDelegate

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Indeed missing @since 5.69
  
  To get the description, just connect to the `description` signal and store 
it, until the time you need to show the error?

INLINE COMMENTS

> knotificationjobuidelegate.cpp:32
> +
> +KNotificationJobUiDelegate::Private::Private()
> +{

remove?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28295

To: broulik, #frameworks, nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 503 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/503/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 28 Mar 2020 09:05:03 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 55 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/412)67%
(276/412)56%
(35362/62631)40%
(17879/44172)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(60/60)100%
(60/60)96%
(10029/10498)47%
(4673/10028)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8751/14649)51%
(4540/8837)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8334)43%
(2078/4816)src.gui100%
(5/5)100%
(5/5)81%
(328/407)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)40%
(419/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4286)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

D25315: KDirModel: implement showing a root node for the requested URL

[David Faure]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:78329e2eb60d: KDirModel: implement showing a root node 
for the requested URL (authored by dfaure).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25315?vs=77224&id=78716#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25315?vs=77224&id=78716

REVISION DETAIL
  https://phabricator.kde.org/D25315

AFFECTED FILES
  autotests/kdirmodeltest.cpp
  autotests/kdirmodeltest.h
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h
  tests/kdirmodeltest_gui.cpp

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: rrosch, ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

[whitequark]

catherinez added a comment.


  Could someone commit this, please?

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D27356

To: catherinez, #kwin, davidedmundson
Cc: davidedmundson, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28362: Fix stylesheet linking in 8 icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:1bbf2a546894: Fix stylesheet linking in 8 icons (authored 
by davidhurka, committed by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28362?vs=78702&id=78714

REVISION DETAIL
  https://phabricator.kde.org/D28362

AFFECTED FILES
  icons/actions/16/distribute-vertical-center.svg
  icons/actions/16/edit-clear-locationbar-ltr.svg
  icons/actions/16/mail-reply-all.svg
  icons/actions/22/distribute-vertical-center.svg
  icons/actions/22/edit-clear-locationbar-ltr.svg
  icons/actions/22/kstars_supernovae.svg
  icons/actions/symbolic/list-remove-symbolic.svg
  icons/devices/16/network-wireless-connected-25.svg

To: davidhurka, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28362: Fix stylesheet linking in 8 icons

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-some-style-attributes

REVISION DETAIL
  https://phabricator.kde.org/D28362

To: davidhurka, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns