D28637: Use ecm_setup_qtplugin_macro_names

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:d16f10e2ee1e: Use ecm_setup_qtplugin_macro_names 
(authored by kossebau).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28637?vs=79539&id=79548

REVISION DETAIL
  https://phabricator.kde.org/D28637

AFFECTED FILES
  CMakeLists.txt
  KF5KCMUtilsConfig.cmake.in

To: kossebau, #frameworks, mart, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28637: Use ecm_setup_qtplugin_macro_names

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R295 KCMUtils

BRANCH
  useECMSetupQtPluginMacroNames

REVISION DETAIL
  https://phabricator.kde.org/D28637

To: kossebau, #frameworks, mart, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[Nathaniel Graham]

ngraham added a comment.


  I haven't been working on it. There's an outstanding request to do this in a 
combination of CMake and Python, so it's cross-platform for Windows users of 
Breeze Icons too (see D27557#622879 
). Honestly I need to re-do the 
existing thing before that. But it's hard to gin up the motivation since I find 
working with CMake for anything more trivial than bumping a dependency version 
to be exceptionally unpleasant.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

D28636: Use ecm_setup_qtplugin_macro_names

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R308:423f9b88e0ca: Use ecm_setup_qtplugin_macro_names 
(authored by kossebau).

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28636?vs=79538&id=79541

REVISION DETAIL
  https://phabricator.kde.org/D28636

AFFECTED FILES
  CMakeLists.txt
  KF5RunnerConfig.cmake.in

To: kossebau, #frameworks, broulik, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28636: Use ecm_setup_qtplugin_macro_names

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R308 KRunner

BRANCH
  useECMSetupQtPluginMacroNames

REVISION DETAIL
  https://phabricator.kde.org/D28636

To: kossebau, #frameworks, broulik, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28637: Use ecm_setup_qtplugin_macro_names

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Avoids all the explicit boilerplate needed, consistent with other KF places
  and might catch automatically future changes meeded to adapt to other CMake
  changes

REPOSITORY
  R295 KCMUtils

BRANCH
  useECMSetupQtPluginMacroNames

REVISION DETAIL
  https://phabricator.kde.org/D28637

AFFECTED FILES
  CMakeLists.txt
  KF5KCMUtilsConfig.cmake.in

To: kossebau, #frameworks, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

[Nicolas Fella]

nicolasfella added a comment.


  ping?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25707

To: nicolasfella, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

[Nicolas Fella]

nicolasfella added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25707

To: nicolasfella, #frameworks, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28636: Use ecm_setup_qtplugin_macro_names

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Avoids all the explicit boilerplate needed, consistent with other KF places
  and might catch automatically future changes meeded to adapt to other CMake
  changes

REPOSITORY
  R308 KRunner

BRANCH
  useECMSetupQtPluginMacroNames

REVISION DETAIL
  https://phabricator.kde.org/D28636

AFFECTED FILES
  CMakeLists.txt
  KF5RunnerConfig.cmake.in

To: kossebau, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[David Hurka]

davidhurka added a comment.


  @ngraham How’s your progress with the bash script? I’m currently trying to 
understand bash syntax. Maybe I can do it, if you don’t have done it already.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ndavis, ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 413 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/413/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 06 Apr 2020 20:50:49 +
 Build duration:
41 sec and counting
   CONSOLE OUTPUT
  [...truncated 296 lines...][2020-04-06T20:51:23.813Z] ./src/contents/ui[2020-04-06T20:51:23.813Z] ./src/contents/ui/main.qml[2020-04-06T20:51:23.813Z] ./src/main.cpp[2020-04-06T20:51:23.813Z] ./src/resources.qrc[2020-04-06T20:51:23.813Z] ./kirigami.kdevtemplate[2020-04-06T20:51:23.813Z] ./kirigami-app.png[2020-04-06T20:51:23.813Z] ./org.kde.%{APPNAMELC}.desktop[2020-04-06T20:51:23.813Z] [  8%] Built target kirigami[2020-04-06T20:51:23.813Z] [ 10%] Automatic MOC for target applicationitemapp[2020-04-06T20:51:24.074Z] [ 10%] Built target qmltest_autogen[2020-04-06T20:51:24.074Z] [ 10%] Built target applicationitemapp_autogen[2020-04-06T20:51:24.074Z] [ 12%] Generating qrc_resources.cpp[2020-04-06T20:51:24.074Z] Building up file structure...[2020-04-06T20:51:24.074Z] Insert custom filters...[2020-04-06T20:51:24.074Z] Insert help data for filter section (1 of 1)...[2020-04-06T20:51:24.074Z] Insert files...[2020-04-06T20:51:24.074Z] Insert contents...[2020-04-06T20:51:24.074Z] Insert indices...[2020-04-06T20:51:24.074Z] Documentation successfully generated.[2020-04-06T20:51:24.074Z] [ 12%] Built target KF5Kirigami2_QCH[2020-04-06T20:51:24.074Z] Scanning dependencies of target applicationitemapp[2020-04-06T20:51:24.074Z] Scanning dependencies of target qmltest[2020-04-06T20:51:24.074Z] [ 14%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.o[2020-04-06T20:51:24.074Z] [ 16%] Building CXX object autotests/CMakeFiles/qmltest.dir/qmltest_autogen/mocs_compilation.cpp.o[2020-04-06T20:51:24.074Z] [ 18%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.o[2020-04-06T20:51:24.074Z] [ 20%] Building CXX object autotests/CMakeFiles/qmltest.dir/qmltest.cpp.o[2020-04-06T20:51:24.074Z] [ 20%] Built target KF5Kirigami2_autogen[2020-04-06T20:51:24.074Z] [ 22%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[2020-04-06T20:51:24.074Z] [ 24%] Generating tabletmodemanager_interface.cpp, tabletmodemanager_interface.h[2020-04-06T20:51:24.074Z] [ 26%] Generating tabletmodemanager_interface.moc[2020-04-06T20:51:24.342Z] Scanning dependencies of target KF5Kirigami2[2020-04-06T20:51:24.342Z] [ 28%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[2020-04-06T20:51:24.343Z] [ 32%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[2020-04-06T20:51:24.343Z] [ 32%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[2020-04-06T20:51:24.343Z] [ 34%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[2020-04-06T20:51:24.343Z] [ 36%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[2020-04-06T20:51:24.343Z] [ 38%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodemanager_interface.cpp.o[2020-04-06T20:51:24.343Z] [ 40%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.o[2020-04-06T20:51:25.722Z] [ 42%] Linking CXX shared library ../../bin/libKF5Kirigami2.so[2020-04-06T20:51:25.981Z] [ 44%] Linking CXX executable ../../bin/applicationitemapp[2020-04-06T20:51:26.239Z] [ 44%] Built target KF5Kirigami2[2020-04-06T20:51:26.239Z] Scanning dependencies of target kirigamiplugin_autogen[2020-04-06T20:51:26.239Z] [ 46%] Automatic MOC for target kirigamiplugin[2020-04-06T20:51:26.239Z] [ 46%] Built target applicationitemapp[2020-04-06T20:51:26.497Z] [ 46%] Built target kirigamiplugin_autogen[2020-04-06T20:51:26.497Z] [ 48%] Generating qrc_shaders.cpp[2020-04-06T20:51:26.754Z] Scanning dependencies of target kirigamiplugin[2020-04-06T20:51:26.754Z] [ 50%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin_autogen/mocs_compilation.cpp.o[2020-04-06T20:51:26.754Z] [ 52%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/delegaterecycler.cpp.o[2020-04-06T20:51:26.754Z] [ 54%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenepositionattached.cpp.o[2020-04-06T20:51:26.754Z] [ 58%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin.cpp.o[2020-04-06T20:51:26.755Z] [ 58%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/formlayoutattached.cpp.o[2020-04-06T20:51:26.755Z] [ 60%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/icon.cpp.o[2020-04-06T20:51:26.755Z] [ 62%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/columnview.cpp.o[2020-04-06T20:51:26.755Z] [ 64%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/enums.cpp.o[2020-04-06T20:51:26.755Z] [ 66%] Building CXX object src/CMakeFiles/kiri

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 20 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/20/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 06 Apr 2020 20:50:49 +
 Build duration:
1 min 13 sec and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514 Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D27263: RFC: Accent colour for KColorScheme

[Nathaniel Graham]

ngraham added a comment.


  Whoops, my bad.
  
  Tested this and found that setting an accept color seems to work for apps, 
but unsetting it doesn't go back to the color-scheme-provided one.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27263

To: cblack, #plasma
Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, 
GB_2, michaelh, bruns

D28444: Add ECMCargo module

[Carson Black]

cblack updated this revision to Diff 79521.
cblack added a comment.


  Add STATIC_LIBNAME and DYNAMIC_LIBNAME options

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28444?vs=79430&id=79521

BRANCH
  cblack/cargo-integration

REVISION DETAIL
  https://phabricator.kde.org/D28444

AFFECTED FILES
  modules/ECMCargo.cmake

To: cblack, #frameworks, #build_system
Cc: apol, IlyaBizyaev, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
cblack, GB_2, bencreasy, michaelh, ngraham, bruns

D28444: Add ECMCargo module

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  I don't have enough CMake knowledge to give code comments, but here are some 
things I can notice in case they help in review:
  
  1. The function specifically mentions Cargo workspace, which is basically a 
Rust alternative to `TEMPLATE = subdirs` in qmake. It doesn't seem though that 
the current implementation has code specific for this project type, and it can 
probably work just as well for normal executable and library projects. Am I 
missing something? If it can't, how would developers use this ECM module if 
they don't need the workspace? Can it be generalized?
  2. In the implementation that I mentioned, the resulting target gets a name 
that we can use directly, whereas in your usage example you have to manually 
use an artifact variable to actually be able to link. You also manually specify 
the shared library extension; will this require a platform-dependent wrapper in 
end user's CMakeLists to be able to use this on e.g. Windows?
  
  Thank you for your work :)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28444

To: cblack, #frameworks, #build_system
Cc: apol, IlyaBizyaev, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
cblack, GB_2, bencreasy, michaelh, ngraham, bruns

D27263: RFC: Accent colour for KColorScheme

[Carson Black]

cblack updated this revision to Diff 79517.
cblack added a comment.


  Fix typo

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27263?vs=75311&id=79517

BRANCH
  kcolorscheme-accent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27263

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: cblack, #plasma
Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, 
GB_2, michaelh, bruns

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

[Konrad Materka]

kmaterka added a comment.


  Is it OK now? Any other review comments?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28470

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: davidre, cblack, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D27848: Remove the panel tooltip icon

[Nathaniel Graham]

ngraham added a comment.


  Fixed in 7aaee715aff2a3fadf950f686a8be5e0d49c3297 
 and 
did it the correct way in 1f0cf38dbf2eb7de2b7fe09ef82bbb281a296a68 
. 
Sorry about the breakage.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack, niccolove, apol
Cc: broulik, davidre, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D27840: Introduce SettingState* elements to ease KCM writing

[Cyril Rossi]

crossi added a dependent revision: D28629: [WIP] Port KCM to 
SettingStateBinding.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27840

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27848: Remove the panel tooltip icon

[David Redondo]

davidre added a comment.


  In D27848#643045 , @ngraham wrote:
  
  > See the parent task.
  >
  > This component doesn't only darw system tray tooltips but rather tooltips 
for all panel widgets. The idea was that we don't want icons in *any* of these 
tooltips, because they're either redundant or inconsistent with the icon that 
you're hovering the mouse over. For this patch, I guess I should have marked 
the `icon` parameter as deprecated. I can do that in a follow-up patch.
  >
  > I didn't remove the display of a custom image because I figured that in 
this case, the designer was specifically trying to set something different. But 
maybe that should be deprecated too. Open to opinions.
  >
  > On another note, it would have been nice if these concerns had been brought 
up during the month when the patch was open for review.
  
  
  Wouldn't then be the solution to remove icons to wherever the panel widgets 
set them? And why would a designer only explicitely set images but not icons? 
Also this component does not only draw panel tooltips but also other tooltips, 
for example on the widget edit handle things. 
  Sorry for not noticing earlier

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack, niccolove, apol
Cc: broulik, davidre, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D27848: Remove the panel tooltip icon

[Kai Uwe Broulik]

broulik added a comment.


  > For all panel widgets
  
  which are all governed by a single place: 
`plasma-desktop/desktoppackage/contents/applet/CompactApplet.qml`
  
  Imho an unacceptable behavior break for a Frameworks component.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack, niccolove, apol
Cc: broulik, davidre, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D27848: Remove the panel tooltip icon

[Nathaniel Graham]

ngraham added a comment.


  See the parent task.
  
  This component doesn't only darw system tray tooltips but rather tooltips for 
all panel widgets. The idea was that we don't want icons in *any* of these 
tooltips, because they're either redundant or inconsistent with the icon that 
you're hovering the mouse over. For this patch, I guess I should have marked 
the `icon` parameter as deprecated. I can do that in a follow-up patch.
  
  I didn't remove the display of a custom image because I figured that in this 
case, the designer was specifically trying to set something different. But 
maybe that should be deprecated too. Open to opinions.
  
  On another note, it would have been nice if these concerns had been brought 
up during the month when the patch was open for review.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack, niccolove, apol
Cc: davidre, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D28460: Add KCModuleStateProbe as base class for plugin

[Benjamin Port]

bport updated this revision to Diff 79496.
bport added a comment.


  Take in consideration feedbacks

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28460?vs=78969&id=79496

REVISION DETAIL
  https://phabricator.kde.org/D28460

AFFECTED FILES
  src/CMakeLists.txt
  src/kcmoduleloader.cpp
  src/kcmoduleloader.h
  src/kcmodulestateprobe.cpp
  src/kcmodulestateprobe.h

To: bport, #plasma, ervin
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[David Hurka]

davidhurka added a comment.


  Now we have less than 130 icons which are different in icons/ and 
icons-dark/, and less than 100 icons which we should keep as dark version. 
Maybe we can keep event less.
  
  I have sorted them into two files.
  
  F8221155: dark_icons_to_keep.txt 
  
  F8221154: dark_icons_to_remove.txt 

TASK DETAIL
  https://phabricator.kde.org/T12855

To: davidhurka
Cc: ndavis, ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

D27840: Introduce SettingState* elements to ease KCM writing

[Cyril Rossi]

crossi added a dependent revision: D28622: [WIP] Port KCM KWin Decoration and 
VirtualDesktop to SettingStateBinding.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27840

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28532: Introduce more user-visible error reporting for installations

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:eb23f549ea9b: Introduce more user-visible error reporting 
for installations (authored by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28532?vs=79474&id=79489

REVISION DETAIL
  https://phabricator.kde.org/D28532

AFFECTED FILES
  src/core/engine.cpp
  src/core/installation.cpp
  src/core/installation.h
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/ErrorDisplayer.qml
  src/qtquick/qml/private/MessageBoxSheet.qml

To: leinir, #knewstuff, #plasma, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28624: Print a warning if runner is incompatible with KRunner

[David Redondo]

davidre created this revision.
davidre added a reviewer: broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Useful for finding out why runner isn't loaded even though it's enabled in
  settings. Can for example happen if a runner is installed by an application
  that's compiled against a newer KRunner version than Plasma.

TEST PLAN
  Try to load an incompatible runner plugin

REPOSITORY
  R308 KRunner

BRANCH
  warning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28624

AFFECTED FILES
  src/runnermanager.cpp

To: davidre, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28620: Add readmes clarifying state of plasma component versions

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0051a4f919b6: Add readmes clarifying state of plasma 
component versions (authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28620?vs=79479&id=79486

REVISION DETAIL
  https://phabricator.kde.org/D28620

AFFECTED FILES
  src/declarativeimports/plasmacomponents/README.md
  src/declarativeimports/plasmacomponents3/README.md

To: davidedmundson, #plasma, apol, romangg, mart
Cc: romangg, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28620: Add readmes clarifying state of plasma component versions

[Marco Martin]

mart accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28620

To: davidedmundson, #plasma, apol, romangg, mart
Cc: romangg, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28532: Introduce more user-visible error reporting for installations

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  more-installation-error-handling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28532

To: leinir, #knewstuff, #plasma, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28620: Add readmes clarifying state of plasma component versions

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.


  If you want to you can also add a ⚠️ (`:warning:`) emoticon to the deprecated 
text and in both some headings with `#`, `##`, etc.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28620

To: davidedmundson, #plasma, apol, romangg
Cc: romangg, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 19 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/19/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 06 Apr 2020 13:47:53 +
 Build duration:
1 min 30 sec and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514 Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514.autotests.tst_keynavigation.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514.autotests.tst_listskeynavigation.qml

D28620: Add readmes clarifying state of plasma component versions

[David Edmundson]

davidedmundson updated this revision to Diff 79479.
davidedmundson added a comment.


  use .md

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28620?vs=79467&id=79479

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28620

AFFECTED FILES
  src/declarativeimports/plasmacomponents/README.md
  src/declarativeimports/plasmacomponents3/README.md

To: davidedmundson, #plasma, apol
Cc: romangg, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28620: Add readmes clarifying state of plasma component versions

[Roman Gilg]

romangg added a comment.


  README.md is common for viewing in modern code hosting solutions with 
markdown support.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28620

To: davidedmundson, #plasma, apol
Cc: romangg, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28620: Add readmes clarifying state of plasma component versions

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28620

To: davidedmundson, #plasma, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27848: Remove the panel tooltip icon

[David Redondo]

davidre added a comment.


  I think this was done at the wrong level. If we don't want icons in the 
systray  then the way would be to net set the property in the systray and not 
ignore the property in the generic component but keep the property for api 
stability purposes. Now we have a component with a documented property that 
doesn't work. People trying to use this will think it's broken while we can't 
use it in any context where we want an icon in the future. Furthermore it's 
inconsistent that one can still set an icon via image strengthening the broken 
look from the outside.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack, niccolove, apol
Cc: davidre, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D28532: Introduce more user-visible error reporting for installations

[Dan Leinir Turthra Jensen]

leinir edited the test plan for this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28532

To: leinir, #knewstuff, #plasma, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28532: Introduce more user-visible error reporting for installations

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 79474.
leinir added a comment.


  - Merge branch 'master' into more-installation-error-handling
  - Actually read the error (not just all)

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28532?vs=79195&id=79474

BRANCH
  more-installation-error-handling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28532

AFFECTED FILES
  src/core/engine.cpp
  src/core/installation.cpp
  src/core/installation.h
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/ErrorDisplayer.qml
  src/qtquick/qml/private/MessageBoxSheet.qml

To: leinir, #knewstuff, #plasma, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28606: Add iconSize property to PC2 ToolButton

[Noah Davis]

ndavis abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28606

To: ndavis, #plasma, mart
Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns

D28599: [configview] Simplify code / workaround Qt5.15 crash

[David Edmundson]

davidedmundson updated this revision to Diff 79469.
davidedmundson added a comment.


  setContextProprerties

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28599?vs=79423&id=79469

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28599

AFFECTED FILES
  src/plasmaquick/configview.cpp

To: davidedmundson, #plasma, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28599: [configview] Simplify code / workaround Qt5.15 crash

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0417bf61d53a: [configview] Simplify code / workaround 
Qt5.15 crash (authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28599?vs=79469&id=79470

REVISION DETAIL
  https://phabricator.kde.org/D28599

AFFECTED FILES
  src/plasmaquick/configview.cpp

To: davidedmundson, #plasma, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/4/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Mon, 06 Apr 2020 11:21:17 +
 Build duration:
7 min 45 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.69.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testPascalName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)87%
(260/298)87%
(260/298)67%
(33011/49189)49%
(14807/30096)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src97%
(37/38)97%
(37/38)93%
(4791/5129)49%
(1812/3680)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5526/5568)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)89%
(1677/1892)74%
(1082/1472)src.completion100%
(11/11)100%
(11/11)57%
(1785/3131)42%
(1008/2423)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/457)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/855)0%
(0/180)src.document100%
(4/4)100%
(4/4)61%
(1937/3176)48%
(1419/2977)src.export0%
(0/4)0%
(0/4)0%
(0/121)0%
(0/156)src.include.ktexteditor93%
(14/15)93%
(14/15)84%
(187/222)55%
(125/226)src.inputmode100%
(8/8)100%
(8/8)63%
(192/304)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(378/1050)16%
(146/897)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/278)src.render100%
(7/7)100%
(7/7)77%
(947/1224)67%
(612/916)src.schema29%
(2/7)29%
(2/7)1%
(19/1468)1%
(6/625)src.script100%
(16/16)100%
(16/16)68%
(706/1038)54%
   

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/5/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 06 Apr 2020 11:21:17 +
 Build duration:
6 min 3 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testCppstyleFailed: projectroot.autotests.kateindenttest_testPascalName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D28620: Add readmes clarifying state of plasma component versions

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

TEST PLAN
  N/A

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28620

AFFECTED FILES
  src/declarativeimports/plasmacomponents/README.txt
  src/declarativeimports/plasmacomponents3/README.txt

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28463: do not install testengine

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:6e39c1de5bb3: do not install testengine (authored by 
sitter).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28463?vs=78974&id=79464

REVISION DETAIL
  https://phabricator.kde.org/D28463

AFFECTED FILES
  tests/testengine/CMakeLists.txt

To: sitter, mart, apol
Cc: broulik, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28606: Add iconSize property to PC2 ToolButton

[Marco Martin]

mart added a comment.


  I don't think we should put any new feature in plasmacomponents2. it will be 
removed in qt6 anyways and work should be more concentrated to a) port away 
from it altogether abd b) if the pc3 version doesn't work, put effort in fixing 
that

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28606

To: ndavis, #plasma, mart
Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:daec307b59e9: smb: use prettyname.kio-discovery-wsd for 
hostname of wsdiscoveries (authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28513?vs=79234&id=79457

REVISION DETAIL
  https://phabricator.kde.org/D28513

AFFECTED FILES
  smb/kio_smb_browse.cpp
  smb/wsdiscoverer.cpp

To: sitter, ngraham, meven
Cc: kossebau, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D27804: smb: add hack to support spaces in workgroup names

[Harald Sitter]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:f40191a147c9: smb: add hack to support spaces in 
workgroup names (authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27804?vs=76934&id=79458#toc

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27804?vs=76934&id=79458

REVISION DETAIL
  https://phabricator.kde.org/D27804

AFFECTED FILES
  smb/autotests/smburltest.cpp
  smb/kio_smb_browse.cpp
  smb/smburl.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, thiago, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D27902: smb: figure out the best host to use for the UDS_URL

[Harald Sitter]

sitter abandoned this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27902

To: sitter, ngraham, dfaure
Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, rdieter, mikesomov

D28532: Introduce more user-visible error reporting for installations

[Dan Leinir Turthra Jensen]

leinir edited the test plan for this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28532

To: leinir, #knewstuff, #plasma, ngraham, #frameworks
Cc: pino, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28606: Add iconSize property to PC2 ToolButton

[David Edmundson]

davidedmundson added a comment.


  > He said he wouldn't accept patches that do that for notifications or 
KRunner because of the issues with PC3
  
  I doubt that's what was meant.
  
  There have definitely been some bad patches that blindly ported to PC3 
without adequate testing. That's highly problematic.
  
  But use of PC3 with work put into fixing components of issues that arise 
should certainly be a target. I'll bring it up in the meeting.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28606

To: ndavis, #plasma, mart
Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns