KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.14 - Build # 55 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.14/55/
 Project:
kf5-qt5 AndroidQt5.14
 Date of build:
Tue, 21 Apr 2020 10:07:06 +
 Build duration:
1 min 13 sec and counting

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 33 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/33/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 21 Apr 2020 10:07:03 +
 Build duration:
1 min 21 sec and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514 Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 426 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/426/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 21 Apr 2020 10:07:06 +
 Build duration:
2 min 38 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.70.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512 Failed: 7 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.pagepool/tst_pagepool.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_actiontoolbar.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_icon.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_keynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_listskeynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_pagerouter.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_pagerow.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/5)0%
(0/34)0%
(0/34)0%
(0/3641)0%
(0/2461)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests0%
(0/1)0%
(0/1)0%
(0/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src0%
(0/19)0%
(0/19)0%
(0/2629)0%
(0/1708)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/691)0%
(0/603)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/312)0%
(0/150)

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 29 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/29/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Tue, 21 Apr 2020 10:07:06 +
 Build duration:
2 min 41 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.70.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514 Failed: 7 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.pagepool/tst_pagepool.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_actiontoolbar.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_icon.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_keynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_listskeynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_pagerouter.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_pagerow.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/5)0%
(0/34)0%
(0/34)0%
(0/3641)0%
(0/2461)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests0%
(0/1)0%
(0/1)0%
(0/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src0%
(0/19)0%
(0/19)0%
(0/2629)0%
(0/1708)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/691)0%
(0/603)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/312)0%
(0/150)

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.14 - Build # 104 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.14/104/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 21 Apr 2020 10:07:06 +
 Build duration:
2 min 19 sec and counting
   JUnit Tests
  Name: projectrootC_.CI.Job_Build Failed: 7 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectrootC_.CI.Job_Build.autotests.pagepool/tst_pagepool.qmlFailed: projectrootC_.CI.Job_Build.autotests.tst_actiontoolbar.qmlFailed: projectrootC_.CI.Job_Build.autotests.tst_icon.qmlFailed: projectrootC_.CI.Job_Build.autotests.tst_keynavigation.qmlFailed: projectrootC_.CI.Job_Build.autotests.tst_listskeynavigation.qmlFailed: projectrootC_.CI.Job_Build.autotests.tst_pagerouter.qmlFailed: projectrootC_.CI.Job_Build.autotests.tst_pagerow.qml

D29018: Align description in metainfo.yaml with the one of README.md

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R174:82db5c4d8067: Align description in metainfo.yaml with the 
one of README.md (authored by kossebau).

REPOSITORY
  R174 KContacts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29018?vs=80674&id=80740

REVISION DETAIL
  https://phabricator.kde.org/D29018

AFFECTED FILES
  metainfo.yaml

To: kossebau, mlaurent, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28780: [FstabWatcher] Fix loosing of fstab watcher

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:5f97573881fe: [FstabWatcher] Fix loosing of fstab watcher 
(authored by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28780?vs=79954&id=80741

REVISION DETAIL
  https://phabricator.kde.org/D28780

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabwatcher.cpp
  src/solid/devices/backends/fstab/fstabwatcher.h

To: bruns, #frameworks, ngraham, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/10/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 21 Apr 2020 10:18:34 +
 Build duration:
1 min 34 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D28882: Create protocol to manage video feeds

[Jan Grulich]

jgrulich added a comment.


  Doesn't seem to build here:
  
In file included from 
/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:7:

/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.h:32:121:
 error: ‘std::function’ has not been declared
   32 | ScreencastingSource(const QString &description, const QString 
&iconName, bool isOutput, const QRect &geometry, std::function);
  | 
^~~~
In file included from 
/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:7:

/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.h:32:129:
 error: expected ‘,’ or ‘...’ before ‘<’ token
   32 | ScreencastingSource(const QString &description, const QString 
&iconName, bool isOutput, const QRect &geometry, std::function);
  | 
^

/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:41:1:
 error: no declaration matches 
‘KWayland::Server::ScreencastingSource::ScreencastingSource(const QString&, 
const QString&, bool, const QRect&, std::function)’
   41 | ScreencastingSource::ScreencastingSource(const QString 
&description, const QString &iconName, bool isOutput, const QRect &geometry, 
std::function call)
  | ^~~

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28244: GIT_SILENT minor code formatting

[Ahmad Samir]

ahmadsamir abandoned this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D28244

To: ahmadsamir, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Jan Grulich]

jgrulich added a comment.


  In D28882#653483 , @jgrulich wrote:
  
  > Doesn't seem to build here:
  >
  >   In file included from 
/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:7:
  >   
/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.h:32:121:
 error: ‘std::function’ has not been declared
  >  32 | ScreencastingSource(const QString &description, const QString 
&iconName, bool isOutput, const QRect &geometry, std::function);
  > |   
  ^~~~
  >   In file included from 
/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:7:
  >   
/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.h:32:129:
 error: expected ‘,’ or ‘...’ before ‘<’ token
  >  32 | ScreencastingSource(const QString &description, const QString 
&iconName, bool isOutput, const QRect &geometry, std::function);
  > |   
  ^
  >   
/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:41:1:
 error: no declaration matches 
‘KWayland::Server::ScreencastingSource::ScreencastingSource(const QString&, 
const QString&, bool, const QRect&, std::function)’
  >  41 | ScreencastingSource::ScreencastingSource(const QString 
&description, const QString &iconName, bool isOutput, const QRect &geometry, 
std::function call)
  > | ^~~
  >
  >
  
  
  Missing #include 

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28499: [LauncherJobs] Emit description

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28499

To: broulik, #frameworks, davidedmundson
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29035: Install service files for kwin

[David Edmundson]

davidedmundson added a comment.


  I'm not sure why we set KillMode
  
  Though I'm favour of merging then tweaking some of this, the service files 
won't do anything till someone pulls them in.
  
  Don't push before relevant ECM and relevant p-w patch is in

INLINE COMMENTS

> plasma-kwin_x11.service.in:3
> +Description=KDE Window Manager
> +Wants=plasma-kcminit.service
> +

This should be After= rather than Wants=

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29035

To: broulik, #plasma, #frameworks
Cc: davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, 
crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27158: Fix some compiler warnings

[Ahmad Samir]

ahmadsamir updated this revision to Diff 80753.
ahmadsamir added a comment.


  Rebase

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27158?vs=75028&id=80753

BRANCH
  l-compiler-warnings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27158

AFFECTED FILES
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/kconfig_compiler.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27158: Fix some compiler warnings

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:fb29718d3ac6: Fix some compiler warnings (authored by 
ahmadsamir).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27158?vs=80753&id=80754

REVISION DETAIL
  https://phabricator.kde.org/D27158

AFFECTED FILES
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/kconfig_compiler.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29034: Add systemd user service file for kded

[Kai Uwe Broulik]

broulik planned changes to this revision.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29034

To: broulik, #plasma, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 427 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/427/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 21 Apr 2020 12:26:06 +
 Build duration:
3 min 4 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.70.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512 Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)47%
(16/34)47%
(16/34)46%
(1662/3649)31%
(752/2425)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src63%
(12/19)63%
(12/19)44%
(1190/2681)31%
(533/1708)src.libkirigami50%
(3/6)50%
(3/6)73%
(471/647)39%
(219/567)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/312)0%
(0/150)

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 30 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/30/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Tue, 21 Apr 2020 12:26:06 +
 Build duration:
3 min 23 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.70.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514 Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)47%
(16/34)47%
(16/34)46%
(1662/3649)31%
(752/2425)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src63%
(12/19)63%
(12/19)44%
(1190/2681)31%
(533/1708)src.libkirigami50%
(3/6)50%
(3/6)73%
(471/647)39%
(219/567)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/312)0%
(0/150)

D29033: Remove duplicated code

[Vlad Zahorodnii]

zzag requested changes to this revision.
zzag added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> waylandintegration.cpp:191
>  [this] (PlasmaWindow *w) {
> -emit KWindowSystem::self()->windowAdded(w->internalId());
> -emit KWindowSystem::self()->stackingOrderChanged();

The old and the new code are not the same. With f(), we're going to emit 
windowRemoved() instead of windowAdded().

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29033

To: apol, #frameworks, zzag
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29033: Remove duplicated code

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  My bad, thanks!

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29033

To: apol, #frameworks, zzag
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29049: add telephant icon

[Mathis Brüchert]

mbruchert created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mbruchert requested review of this revision.

REVISION SUMMARY
  add link to appstream-ID

REPOSITORY
  R266 Breeze Icons

BRANCH
  telephant (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29049

AFFECTED FILES
  icons-dark/apps/48/com.fribbledom.telephant.svg
  icons-dark/apps/48/telephant.svg
  icons/apps/48/com.fribbledom.telephant.svg
  icons/apps/48/telephant.svg

To: mbruchert
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29049: add telephant icon

[Carl Schwan]

ognarb added a reviewer: muesli.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29049

To: mbruchert, muesli
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29049: add telephant icon

[Mathis Brüchert]

mbruchert added a comment.


  F8251544: grafik.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29049

To: mbruchert, muesli
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29049: add telephant icon

[Mathis Brüchert]

mbruchert added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29049

To: mbruchert, muesli, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 96 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/96/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 21 Apr 2020 13:07:03 +
 Build duration:
2 min 13 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Package-5.70.0.xmlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testpackage_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)74%
(1641/2230)51%
(1035/2022)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(529/531)48%
(212/442)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(567/763)63%
(532/843)src.kpackage.private100%
(7/7)100%
(7/7)80%
(304/382)47%
(94/199)src.kpackagetool100%
(3/3)100%
(3/3)42%
(227/536)36%
(190/526)

D28856: Save disabling of desktop file components in kglobalshortcutsrc

[Méven Car]

meven requested changes to this revision.
meven added a comment.
This revision now requires changes to proceed.


  Just two qDebug to remove, seems fine otherwise

INLINE COMMENTS

> globalshortcutsregistry.cpp:95
>  {
> +qDebug() << component->uniqueName();
>  if (_components.value(component->uniqueName()))

To remove

> globalshortcutsregistry.cpp:98
>  {
> +qDebug() << component->uniqueName();
>  Q_ASSERT_X(false, "GlobalShortcutsRegistry::addComponent", 
> "component already registered?!?!");

To remove

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D28856

To: davidre, davidedmundson, fvogt, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29032: Add 16px Vvave icon

[Manuel Jesús de la Fuente]

manueljlin updated this revision to Diff 80763.
manueljlin added a comment.


  - Add 16px Vvave icon
  - Update icon style

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29032?vs=80717&id=80763

BRANCH
  vvave16px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29032

AFFECTED FILES
  icons-dark/apps/16/vvave.svg
  icons/apps/16/vvave.svg

To: manueljlin, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29032: Add 16px Vvave icon

[Manuel Jesús de la Fuente]

manueljlin edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29032

To: manueljlin, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29050: WIP KRunner: Fix Bug 420311

[Alexander Lohnau]

alex created this revision.
alex added reviewers: meven, ngraham, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
alex requested review of this revision.

REVISION SUMMARY
  BUG: 420311.
  Because the teardown was rquested and checked the prepped variable was set to 
false and consequently
  the prepare method gets called for the next character typed.
  
  The exact two lines get called in the matchSessionComplete method.
  
  But I honestly don't know where this function gets called :-/.

TEST PLAN
  Try out what was described in bug report.

REPOSITORY
  R308 KRunner

BRANCH
  krunner_signal_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29050

AFFECTED FILES
  src/runnermanager.cpp

To: alex, meven, ngraham, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29050: WIP KRunner: Fix Bug 420311

[Alexander Lohnau]

alex edited the summary of this revision.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D29050

To: alex, meven, ngraham, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29051: Add ecm_generate_dbus_service_file

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, davidedmundson, kossebau, kfunk, habacker.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It serves as a replacement for `kdbusaddons_generate_dbus_service_file`.
  
  An application can be a DBus-activated service just fine without using 
KDBusAddons.
  Moreover, this new module uses named arguments for future-proofing, and adds 
support for specifying a `SystemdService`.
  It also cleans up the confusion on what the "path" is about: Rather than 
requiring to specify executable and path separately, we just extract the 
executable file name on Windows, if necessary.

TEST PLAN
  - Was able to generate a kded service file
  - Was able to generate a kded service file with `SystemdUnit`
  - Verified that it moaned when executable wasn't an absolute path
  - Untested on Windwos

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29051

AFFECTED FILES
  modules/ECMGenerateDBusServiceFile.cmake

To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29051: Add ecm_generate_dbus_service_file

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29051

To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29051: Add ecm_generate_dbus_service_file

[Kai Uwe Broulik]

broulik edited the summary of this revision.
broulik edited the test plan for this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29051

To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29051: Add ecm_generate_dbus_service_file

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Some first quick comments, not yet looked at code itself.
  
  Misses also link file from doc/.

INLINE COMMENTS

> ECMGenerateDBusServiceFile.cmake:6
> +# This module provides the ``ecm_generate_dbus_service_file`` function for
> +# generating a D-Bus service file.
> +#

generate and install

> ECMGenerateDBusServiceFile.cmake:22
> +#
> +# Since 5.70.0.
> +

Would be nice to have an example.
Also having each argument discussed in an own section makes getting the docs 
easier,

> ECMGenerateDBusServiceFile.cmake:90
> +
> +install(FILES ${_service_file} DESTINATION ${KDE_INSTALL_DBUSSERVICEDIR})
> +endfunction()

Creates a dependecy on KDEInstallDirs.

ECM/Modules are supposed to be usable in non-KDE-typical setups. So like other 
places in this subfolder this macro needs an argument to pass the installation 
folder.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29051

To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

[Benjamin Port]

bport created this revision.
bport added reviewers: zzag, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bport requested review of this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29054

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-window-management.xml
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

To: bport, zzag, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

[Benjamin Port]

bport added a dependent revision: D29056: [libtaskmanager] add stacking order 
data for wayland.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29054

To: bport, zzag, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29051: Add ecm_generate_dbus_service_file

[Kai Uwe Broulik]

broulik updated this revision to Diff 80775.
broulik added a comment.


  - Improve docs
  - Add `DESTINATION` arg

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29051?vs=80766&id=80775

REVISION DETAIL
  https://phabricator.kde.org/D29051

AFFECTED FILES
  modules/ECMGenerateDBusServiceFile.cmake

To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29051: Add ecm_generate_dbus_service_file

[Kai Uwe Broulik]

broulik updated this revision to Diff 80776.
broulik added a comment.


  Add docs rst

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29051?vs=80775&id=80776

REVISION DETAIL
  https://phabricator.kde.org/D29051

AFFECTED FILES
  docs/module/ECMGenerateDBusServiceFile.rst
  modules/ECMGenerateDBusServiceFile.cmake

To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29049: add telephant icon

[Christian Muehlhaeuser]

muesli added a comment.


  Gets my approval! I assume those symlinks from 'com.fribbledom.telephant.svg' 
are intentional to match the appstream ID?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29049

To: mbruchert, muesli, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> plasma-window-management.xml:77
> +  
> +This event will be sent when stacking order changed
> +  

we also need to send it on bind

> plasma-window-management.xml:83
>  
>
>  

Can we change them all at once.

> plasmawindowmanagement_interface.cpp:167
> +{
> +wl_array wlIds;
> +

This needs a

wl_resource_get_version(resource) < 
ORG_KDE_PLASMA_SEND_STACK_SOMETHING_SOMETHING_SINCE_VERSION

A user could be using a flatpak or something with a bundled kwayland that's out 
of date with kwin. At that point we don't want the client to receive this event 
or it will explode.

> plasmawindowmanagement_interface.cpp:234
>  }
>  }
>  

We need to send the stacking order here, this way if a client connects and 
nothing changes, they still have the right order.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29054

To: bport, zzag, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29061: [KCharSelect] Minor code optimisation

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, cfeck, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  - Replace one last foreach with range-for, and set -DQT_NO_FOREACH
  - More const and static where appropriate
  - If a capture group is not used with QRegularExpression, better make it a 
clustering/non-capturing group, less book keeping on PCRE side

TEST PLAN
  make && ctest and a quick search in kcharselecttest still works.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-general-code-opti (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29061

AFFECTED FILES
  CMakeLists.txt
  src/kcharselectdata.cpp

To: ahmadsamir, #frameworks, cfeck, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29032: Add 16px Vvave icon

[Manuel Jesús de la Fuente]

manueljlin edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29032

To: manueljlin, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons

[Nathaniel Graham]

ngraham removed a dependency: D29040: Use colorful icon instead of monochrome 
icon for touchpad kcm.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29037

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons

[Nathaniel Graham]

ngraham added a dependent revision: D29040: Use colorful icon instead of 
monochrome icon for touchpad kcm.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29037

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

[Benjamin Port]

bport updated this revision to Diff 80784.
bport marked 4 inline comments as done.
bport added a comment.


  - Send stack order on bind
  - Check ressource have good protocol version

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29054?vs=80772&id=80784

REVISION DETAIL
  https://phabricator.kde.org/D29054

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-window-management.xml
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

To: bport, zzag, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29062: Port KToolInvocation::kdeinitExecWait to QProcess

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: davidedmundson, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

TEST PLAN
  Part of T12185 
  Verified it's calling it and returning with `NormalExit` and `0` exitcode - 
didn't actually test whether it worked :D

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29062

AFFECTED FILES
  src/kded.cpp

To: broulik, davidedmundson, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, mart, apol, sitter, bcooksley.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Setting XDG_DATA_DIRS in the ENVIRONMENT property using
  "XDG_DATA_DIRS=/path:$XDG_DATA_DIRS" has two flaws
  
  - the value string is not evaluated e.g. by a shell but set directly, so 
$XDG_DATA_DIRS will stay verbatim
  - if XDG_DATA_DIRS was not set before, setting it now will trigger the rules 
to use the default /usr/local/share & /usr/share only if XDG_DATA_DIRS is not 
set, thus effectively removing these dirs now

REPOSITORY
  R290 KPackage

BRANCH
  fixXDG_DATA_DIRSextending

REVISION DETAIL
  https://phabricator.kde.org/D29063

AFFECTED FILES
  autotests/CMakeLists.txt

To: kossebau, #frameworks, mart, apol, sitter, bcooksley
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Small disadvantage of the current code is that this binds things to the value 
of XDG_DATA_DIRS at "cmake" runtime, not "make test" runtime. That would need 
the move of the env var setting into kpackagetoolappstreamtest.cmake I guess. 
Tell if you think that is important.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D29063

To: kossebau, #frameworks, mart, apol, sitter, bcooksley
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

[Harald Sitter]

sitter added a comment.


  Looks reasonable.
  
  @apol thoughts?

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D29063

To: kossebau, #frameworks, mart, apol, sitter, bcooksley
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29037

To: guoyunhe, #breeze, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons

[Kai Uwe Broulik]

broulik added a comment.


  At first glance I thought that drawing tablet icon was about the scroll bar

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29037

To: guoyunhe, #breeze, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29065: [KFontChooser] Add a DisplayFlag to allow not showing fixedOnly checkbox

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, cfeck, bport.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  This is useful for apps that only want users to select monospaced fonts,
  and apps that embed KFontChooser, e.g. Konsole that has its own checkbox
  and an accompanying "warning" button (in fact the checkbox in KFontChooser
  was inspired by the one in Konsole, and we don't want the font widget
  there to suffer by having two checkboxes doing the opposite function of
  each other).

TEST PLAN
  See the kfontchooserdialogtest app

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontchooser-onlyfixed-display-flag (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29065

AFFECTED FILES
  src/kfontchooser.cpp
  src/kfontchooser.h
  tests/kfontchooserdialogtest.cpp

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:27fb93d84c2c: Add preferences-desktop-tablet and 
preferences-desktop-touchpad icons (authored by Guo Yunhe 
).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29037?vs=80728&id=80793

REVISION DETAIL
  https://phabricator.kde.org/D29037

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-tablet.svg
  icons-dark/preferences/32/preferences-desktop-touchpad.svg
  icons/preferences/32/preferences-desktop-tablet.svg
  icons/preferences/32/preferences-desktop-touchpad.svg

To: guoyunhe, #breeze, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29049: add telephant icon

[Nathaniel Graham]

ngraham added a comment.


  It's so cute!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29049

To: mbruchert, muesli, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28701: Add KPackage support to KNewStuffCore

[Nathaniel Graham]

ngraham added a comment.


  I mean, GHNS basically *is* a userspace package manager, and things like 
dependency management and removal of stale files are why package managers 
exist. :)
  
  If it needs to be fixed/implemented in other patches, that's okay.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, 
broulik, bshah
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80798.
apol added a comment.


  - Test Cleanup
  - When a resource is destroyed, emit to close all its streams

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80677&id=80798

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29049: add telephant icon

[Mathis Brüchert]

mbruchert added a comment.


  In D29049#653807 , @muesli wrote:
  
  > Gets my approval! I assume those symlinks from 
'com.fribbledom.telephant.svg' are intentional to match the appstream ID?
  
  
  yes they are

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29049

To: mbruchert, muesli, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29049: add telephant icon

[Mathis Brüchert]

mbruchert added a comment.


  In D29049#653807 , @muesli wrote:
  
  > Gets my approval! I assume those symlinks from 
'com.fribbledom.telephant.svg' are intentional to match the appstream ID?
  
  
  could you officially approve it?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29049

To: mbruchert, muesli, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28460: Add KCModuleDada as base class for plugin

[Kevin Ottens]

ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.


  Please fix the typo in the commit title before pushing, otherwise looks fine 
to me.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28460

To: bport, #plasma, ervin
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29049: add telephant icon

[Christian Muehlhaeuser]

muesli accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  telephant (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29049

To: mbruchert, muesli, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80801.
apol added a comment.


  Hopefully fix the build for Jan

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80798&id=80801

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28701: Add KPackage support to KNewStuffCore

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D28701#653954 , @ngraham wrote:
  
  > I mean, GHNS basically *is* a userspace package manager, and things like 
dependency management and removal of stale files are why package managers 
exist. :)
  >
  > If it needs to be fixed/implemented in other patches, that's okay.
  
  
  Definitely, yes, it wants implementing, though i think we need to consider 
precisely where we want it to go... Thinking it probably wants to go in 
KPackage itself for this case (since that's what installs those dependencies - 
it's at the end of the packagejobthread's installPackage function, but i'm 
thinking the optional removal thing likely needs to go into the packagejob, 
possibly as an overload... just brainfarting a bit here), but there's also a 
dependencies and referencing type thing in OCS (and consequently KNewStuff) 
which we'll need to implement more... properly than it is right now. But yup, 
that's sort of orthogonal to this patch anyway, more a "this wants to be done" 
type thing :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, 
broulik, bshah
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29068: [NetworkManager-qt] replace foreach (deprecated) with range-for, first pass

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, jgrulich.
Herald added a project: Frameworks.
Herald added 1 blocking reviewer(s): jgrulich.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-1 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29068

AFFECTED FILES
  src/bonddevice.cpp
  src/bridgedevice.cpp
  src/ipconfig.cpp
  src/manager.cpp
  src/teamdevice.cpp
  src/wimaxdevice.cpp
  src/wirelessdevice.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29069: Removed the purple gradient circle that surrounded the falkon, added it as an outline - made some crude adjustments, I'm not proud of. But I did this because, a) I didn't like the circle and b

[Chris Escargot]

saligari created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
saligari requested review of this revision.

REVISION SUMMARY
  ...way it has a distinct shape.

REPOSITORY
  R266 Breeze Icons

BRANCH
  falkon-icon-patch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29069

AFFECTED FILES
  icons-dark/apps/48/falkon.svg
  icons/apps/48/falkon.svg

To: saligari
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29070: add alligator icon

[Mathis Brüchert]

mbruchert created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mbruchert requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  alligator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29070

AFFECTED FILES
  icons-dark/apps/48/alligator.svg
  icons/apps/48/alligator.svg

To: mbruchert
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29070: add alligator icon

[Mathis Brüchert]

mbruchert added a comment.


  F8252116: grafik.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29070

To: mbruchert
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29069: Falkon icon - Removing circle & adding outline

[Chris Escargot]

saligari retitled this revision from "Removed the purple gradient circle that 
surrounded the falkon, added it as an outline - made some crude adjustments, 
I'm not proud of. But I did this because, a) I didn't like the circle and b) 
there is no good reason I can think to have it, this..." to "Falkon icon - 
Removing circle & adding outline".
saligari edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29069

To: saligari
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29068: [NetworkManager-qt] replace foreach (deprecated) with range-for, first pass

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-1 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29068

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29070: add alligator icon

[Mathis Brüchert]

mbruchert added reviewers: tfella, VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29070

To: mbruchert, tfella, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29070: add alligator icon

[Tobias Fella]

tfella accepted this revision.
tfella added a comment.
This revision is now accepted and ready to land.


  I love the idea with the teeth 👍

REPOSITORY
  R266 Breeze Icons

BRANCH
  alligator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29070

To: mbruchert, tfella, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29069: Falkon icon - Removing circle & adding outline

[Tobias Fella]

tfella added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29069

To: saligari, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29069: Falkon icon - Removing circle & adding outline

[Chris Escargot]

saligari added a comment.


  F8252134: diff.png 
  
  Uploaded in 128x128 the old (left) and new (right) icon next to each other.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29069

To: saligari, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28460: Add KCModuleData as base class for plugin

[Benjamin Port]

bport retitled this revision from "Add KCModuleDada as base class for plugin" 
to "Add KCModuleData as base class for plugin".

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28460

To: bport, #plasma, ervin
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29070: add alligator icon

[Mathis Brüchert]

mbruchert added a comment.


  In D29070#654088 , @tfella wrote:
  
  > I love the idea with the teeth 👍
  
  
  Thank you :)

REPOSITORY
  R266 Breeze Icons

BRANCH
  alligator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29070

To: mbruchert, tfella, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29069: Falkon icon - Removing circle & adding outline

[Nathaniel Graham]

ngraham added reviewers: abetts, Falkon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29069

To: saligari, #vdg, abetts, #falkon
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  Updated optimize-svg.sh script and optimize SVG files.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29072

AFFECTED FILES
  icons-dark/actions/22/color-management.svg
  icons-dark/actions/22/im-skype.svg
  icons-dark/actions/22/office-chart-polar.svg
  icons-dark/actions/22/run-build-clean.svg
  icons-dark/actions/22/run-build-configure.svg
  icons-dark/actions/22/run-build-file.svg
  icons-dark/actions/22/run-build-prune.svg
  icons-dark/actions/22/run-build.svg
  icons-dark/actions/22/step_object_CircularMotor.svg
  icons-dark/actions/22/step_object_LinearMotor.svg
  icons-dark/actions/22/step_object_SoftBody.svg
  icons-dark/actions/32/colors-luma.svg
  icons-dark/actions/symbolic/pan-down-symbolic.svg
  icons-dark/actions/symbolic/pan-end-symbolic.svg
  icons-dark/actions/symbolic/pan-start-symbolic.svg
  icons-dark/actions/symbolic/pan-up-symbolic.svg
  icons-dark/actions/symbolic/selection-end-symbolic.svg
  icons-dark/actions/symbolic/selection-start-symbolic.svg
  icons-dark/applets/128/user-none.svg
  icons-dark/applets/48/weather-clouds-night.svg
  icons-dark/applets/48/weather-few-clouds-night.svg
  icons-dark/applets/48/weather-showers-day.svg
  icons-dark/applets/48/weather-showers-scattered-night.svg
  icons-dark/applets/48/weather-snow-rain.svg
  icons-dark/applets/48/weather-snow-scattered-day.svg
  icons-dark/applets/48/weather-snow.svg
  icons-dark/apps/48/QtProject-designer.svg
  icons-dark/apps/48/accessories-calculator.svg
  icons-dark/apps/48/accessories-character-map.svg
  icons-dark/apps/48/acroread.svg
  icons-dark/apps/48/alienarena.svg
  icons-dark/apps/48/anjuta.svg
  icons-dark/apps/48/babe.svg
  icons-dark/apps/48/baloo.svg
  icons-dark/apps/48/bluegriffon.svg
  icons-dark/apps/48/bovo.svg
  icons-dark/apps/48/braindump.svg
  icons-dark/apps/48/choqok.svg
  icons-dark/apps/48/codeblocks.svg
  icons-dark/apps/48/diaspora.svg
  icons-dark/apps/48/digikam.svg
  icons-dark/apps/48/falkon.svg
  icons-dark/apps/48/granatier.svg
  icons-dark/apps/48/hwinfo.svg
  icons-dark/apps/48/kapman.svg
  icons-dark/apps/48/karbon.svg
  icons-dark/apps/48/kbruch.svg
  icons-dark/apps/48/kde-im-log-viewer.svg
  icons-dark/apps/48/kdiff3.svg
  icons-dark/apps/48/kmag.svg
  icons-dark/apps/48/knights.svg
  icons-dark/apps/48/ksnapshot.svg
  icons-dark/apps/48/ktorrent.svg
  icons-dark/apps/48/logisim.svg
  icons-dark/apps/48/lokalize.svg
  icons-dark/apps/48/mpv.svg
  icons-dark/apps/48/muondiscover.svg
  icons-dark/apps/48/octave.svg
  icons-dark/apps/48/phonon-gstreamer.svg
  icons-dark/apps/48/planetkde.svg
  icons-dark/apps/48/plasma-media-center.svg
  icons-dark/apps/48/qdbusviewer.svg
  icons-dark/apps/48/qtcreator.svg
  icons-dark/apps/48/showfoto.svg
  icons-dark/apps/48/skanlite.svg
  icons-dark/apps/48/step.svg
  icons-dark/apps/48/umbrello.svg
  icons-dark/apps/48/utilities-log-viewer.svg
  icons-dark/apps/48/words.svg
  icons-dark/apps/48/xorg.svg
  icons-dark/categories/32/applications-office.svg
  icons-dark/devices/64/camera-video.svg
  icons-dark/devices/64/input-gaming.svg
  icons-dark/devices/64/media-flash-memory-stick.svg
  icons-dark/devices/64/media-optical-blu-ray.svg
  icons-dark/devices/64/network-rj11-female.svg
  icons-dark/devices/64/network-rj45-female.svg
  icons-dark/mimetypes/16/application-pgp-signature.svg
  icons-dark/mimetypes/16/text-dockerfile.svg
  icons-dark/mimetypes/22/android-package-archive.svg
  icons-dark/mimetypes/22/application-certificate.svg
  icons-dark/mimetypes/22/application-illustrator.svg
  icons-dark/mimetypes/22/application-msonenote.svg
  icons-dark/mimetypes/22/application-msoutlook.svg
  icons-dark/mimetypes/22/application-msword.svg
  icons-dark/mimetypes/22/application-vnd.ms-excel.addin.macroenabled.12.svg
  icons-dark/mimetypes/22/application-vnd.ms-infopath.svg
  icons-dark/mimetypes/22/application-vnd.oasis.opendocument.text-template.svg
  icons-dark/mimetypes/22/application-x-apple-diskimage.svg
  icons-dark/mimetypes/22/application-x-bzip.svg
  icons-dark/mimetypes/22/application-x-font-ttf.svg
  icons-dark/mimetypes/22/application-x-gettext-translation.svg
  icons-dark/mimetypes/22/application-x-javascript.svg
  icons-dark/mimetypes/22/application-x-lyx.svg
  icons-dark/mimetypes/22/application-x-perl.svg
  icons-dark/mimetypes/22/application-x-rdata.svg
  icons-dark/mimetypes/22/application-x-trash.svg
  icons-dark/mimetypes/22/application-x-xliff.svg
  icons-dark/mimetypes/22/application-xmind.svg
  icons-dark/mimetypes/22/application-zip.svg
  icons-dark/mimetypes/22/image-bmp.svg
  icons-dark/mimetypes/22/image-jpeg.svg
  icons-dark/mimetypes/22/image-tiff.svg
  icons-dark/mimetypes/22/image-x-generic.svg
  icons-dark/mimetypes/22/image-x-psd.svg
  icons-dark/mimetypes/22/image-x-tga.svg
  icons-d

D29070: add alligator icon

[Nathaniel Graham]

ngraham added a comment.


  This is my favorite icon in a very long time.

REPOSITORY
  R266 Breeze Icons

BRANCH
  alligator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29070

To: mbruchert, tfella, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29072: Optimize SVG

[Yunhe Guo]

guoyunhe added a reviewer: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

[Yunhe Guo]

guoyunhe edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29070: add alligator icon

[Tobias Fella]

tfella edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  alligator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29070

To: mbruchert, tfella, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29072: Optimize SVG

[Yunhe Guo]

guoyunhe updated this revision to Diff 80811.
guoyunhe added a comment.


  - Merge some paths

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29072?vs=80810&id=80811

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29072

AFFECTED FILES
  icons-dark/actions/22/color-management.svg
  icons-dark/actions/22/im-skype.svg
  icons-dark/actions/22/office-chart-polar.svg
  icons-dark/actions/22/run-build-clean.svg
  icons-dark/actions/22/run-build-configure.svg
  icons-dark/actions/22/run-build-file.svg
  icons-dark/actions/22/run-build-prune.svg
  icons-dark/actions/22/run-build.svg
  icons-dark/actions/22/step_object_CircularMotor.svg
  icons-dark/actions/22/step_object_LinearMotor.svg
  icons-dark/actions/22/step_object_SoftBody.svg
  icons-dark/actions/32/colors-luma.svg
  icons-dark/actions/symbolic/pan-down-symbolic.svg
  icons-dark/actions/symbolic/pan-end-symbolic.svg
  icons-dark/actions/symbolic/pan-start-symbolic.svg
  icons-dark/actions/symbolic/pan-up-symbolic.svg
  icons-dark/actions/symbolic/selection-end-symbolic.svg
  icons-dark/actions/symbolic/selection-start-symbolic.svg
  icons-dark/applets/128/user-none.svg
  icons-dark/applets/48/weather-clouds-night.svg
  icons-dark/applets/48/weather-few-clouds-night.svg
  icons-dark/applets/48/weather-showers-day.svg
  icons-dark/applets/48/weather-showers-scattered-night.svg
  icons-dark/applets/48/weather-snow-rain.svg
  icons-dark/applets/48/weather-snow-scattered-day.svg
  icons-dark/applets/48/weather-snow.svg
  icons-dark/apps/48/QtProject-designer.svg
  icons-dark/apps/48/accessories-calculator.svg
  icons-dark/apps/48/accessories-character-map.svg
  icons-dark/apps/48/acroread.svg
  icons-dark/apps/48/alienarena.svg
  icons-dark/apps/48/anjuta.svg
  icons-dark/apps/48/babe.svg
  icons-dark/apps/48/baloo.svg
  icons-dark/apps/48/bluegriffon.svg
  icons-dark/apps/48/bovo.svg
  icons-dark/apps/48/braindump.svg
  icons-dark/apps/48/choqok.svg
  icons-dark/apps/48/codeblocks.svg
  icons-dark/apps/48/diaspora.svg
  icons-dark/apps/48/digikam.svg
  icons-dark/apps/48/falkon.svg
  icons-dark/apps/48/granatier.svg
  icons-dark/apps/48/hwinfo.svg
  icons-dark/apps/48/kapman.svg
  icons-dark/apps/48/karbon.svg
  icons-dark/apps/48/kbruch.svg
  icons-dark/apps/48/kde-im-log-viewer.svg
  icons-dark/apps/48/kdiff3.svg
  icons-dark/apps/48/kmag.svg
  icons-dark/apps/48/knights.svg
  icons-dark/apps/48/ksnapshot.svg
  icons-dark/apps/48/ktorrent.svg
  icons-dark/apps/48/logisim.svg
  icons-dark/apps/48/lokalize.svg
  icons-dark/apps/48/mpv.svg
  icons-dark/apps/48/muondiscover.svg
  icons-dark/apps/48/octave.svg
  icons-dark/apps/48/phonon-gstreamer.svg
  icons-dark/apps/48/planetkde.svg
  icons-dark/apps/48/plasma-media-center.svg
  icons-dark/apps/48/qdbusviewer.svg
  icons-dark/apps/48/qtcreator.svg
  icons-dark/apps/48/showfoto.svg
  icons-dark/apps/48/skanlite.svg
  icons-dark/apps/48/step.svg
  icons-dark/apps/48/umbrello.svg
  icons-dark/apps/48/utilities-log-viewer.svg
  icons-dark/apps/48/words.svg
  icons-dark/apps/48/xorg.svg
  icons-dark/categories/32/applications-office.svg
  icons-dark/devices/64/camera-video.svg
  icons-dark/devices/64/input-gaming.svg
  icons-dark/devices/64/media-flash-memory-stick.svg
  icons-dark/devices/64/media-optical-blu-ray.svg
  icons-dark/devices/64/network-rj11-female.svg
  icons-dark/devices/64/network-rj45-female.svg
  icons-dark/mimetypes/16/application-pgp-signature.svg
  icons-dark/mimetypes/16/text-dockerfile.svg
  icons-dark/mimetypes/22/android-package-archive.svg
  icons-dark/mimetypes/22/application-certificate.svg
  icons-dark/mimetypes/22/application-illustrator.svg
  icons-dark/mimetypes/22/application-msonenote.svg
  icons-dark/mimetypes/22/application-msoutlook.svg
  icons-dark/mimetypes/22/application-msword.svg
  icons-dark/mimetypes/22/application-vnd.ms-excel.addin.macroenabled.12.svg
  icons-dark/mimetypes/22/application-vnd.ms-infopath.svg
  icons-dark/mimetypes/22/application-vnd.oasis.opendocument.text-template.svg
  icons-dark/mimetypes/22/application-x-apple-diskimage.svg
  icons-dark/mimetypes/22/application-x-bzip.svg
  icons-dark/mimetypes/22/application-x-font-ttf.svg
  icons-dark/mimetypes/22/application-x-gettext-translation.svg
  icons-dark/mimetypes/22/application-x-javascript.svg
  icons-dark/mimetypes/22/application-x-lyx.svg
  icons-dark/mimetypes/22/application-x-perl.svg
  icons-dark/mimetypes/22/application-x-rdata.svg
  icons-dark/mimetypes/22/application-x-trash.svg
  icons-dark/mimetypes/22/application-x-xliff.svg
  icons-dark/mimetypes/22/application-xmind.svg
  icons-dark/mimetypes/22/application-zip.svg
  icons-dark/mimetypes/22/image-bmp.svg
  icons-dark/mimetypes/22/image-jpeg.svg
  icons-dark/mimetypes/22/image-tiff.svg
  icons-dark/mimetypes/22/image-x-generic.svg
  icons-dark/mimetypes/22/image-x-psd.svg
  icons-dark/mimetypes/22/image-x-tga.svg
  icons-dark/mimetypes/22/image-x-xcf.svg
  icons-dark/mimetypes/22/

D29068: [NetworkManager-qt] replace foreach (deprecated) with range-for, first pass

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:7fdf493b041a: [NetworkManager-qt] replace foreach 
(deprecated) with range-for, first pass (authored by ahmadsamir).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29068?vs=80805&id=80812

REVISION DETAIL
  https://phabricator.kde.org/D29068

AFFECTED FILES
  src/bonddevice.cpp
  src/bridgedevice.cpp
  src/ipconfig.cpp
  src/manager.cpp
  src/teamdevice.cpp
  src/wimaxdevice.cpp
  src/wirelessdevice.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Do not create m_storageAccess in the constructor

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28590

To: meven, #frameworks, bruns, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29069: Falkon icon - Removing circle & adding outline

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  I don't think this is necessary.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29069

To: saligari, #vdg, abetts, #falkon, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29049: add telephant icon

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  telephant (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29049

To: mbruchert, muesli, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29032: Add 16px Vvave icon

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  vvave16px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29032

To: manueljlin, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29069: Falkon icon - Removing circle & adding outline

[Nathaniel Graham]

ngraham added a comment.


  I have to agree. This icon isn't my favorite one ever because of the lavender 
color, but I really like the background circle that the head is slightly 
escaping from. I think it's a pretty good composition.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29069

To: saligari, #vdg, abetts, #falkon, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29072: Optimize SVG

[Nathaniel Graham]

ngraham added reviewers: ndavis, VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

[Noah Davis]

ndavis added a comment.


  > You can check pixel diff in Git Cola.
  
  How do I do this? I was not aware of that feature.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

[Noah Davis]

ndavis added a comment.


  If we're going to actually use the optimization script, we should use `scour` 
instead of SVGO. Scour is the SVG optimizer that is least likely to screw up 
and SVG. These days, the purpose of SVG optimization is to make the code 
readable.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29070: add alligator icon

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  alligator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29070

To: mbruchert, tfella, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29072: Optimize SVG

[Noah Davis]

ndavis added a comment.


  The Scour settings I recommend are `--set-precision=8 --enable-viewboxing 
--enable-comment-stripping --remove-descriptive-elements --create-groups 
--strip-xml-space --strip-xml-prolog --nindent=4`

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29062: Port KToolInvocation::kdeinitExecWait to QProcess

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kded.cpp:67
>  
>  static void runKonfUpdate()
>  {

The function has a typo, should be `runKConfUpdate`, no?

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29062

To: broulik, davidedmundson, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29079: android: include the architecture on the apk name

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Android, Frameworks.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Makes them easier to use afterwards.

TEST PLAN
  Tested locally

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29079

AFFECTED FILES
  toolchain/ECMAndroidDeployQt.cmake

To: apol, #android, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Looks like an improvement

REPOSITORY
  R290 KPackage

BRANCH
  fixXDG_DATA_DIRSextending

REVISION DETAIL
  https://phabricator.kde.org/D29063

To: kossebau, #frameworks, mart, apol, sitter, bcooksley
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

[Nathaniel Graham]

ngraham added a comment.


  In D29072#654216 , @ndavis wrote:
  
  > If we're going to actually use the optimization script, we should use 
`scour` instead of SVGO. Scour is the SVG optimizer that is least likely to 
screw up and SVG. These days, the purpose of SVG optimization is to make the 
code readable.
  
  
  Perhaps the script should be updated to do that?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.14/5/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Wed, 22 Apr 2020 04:20:44 +
 Build duration:
34 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> plasmawindowmanagement.cpp:242
>  
> +void PlasmaWindowManagement::Private::stackingOrderCallback(void *data, 
> org_kde_plasma_window_management *interface, wl_array *ids) {
> +auto wm = reinterpret_cast(data);

The opening brace must be on a new line.

> plasmawindowmanagement.cpp:251
> +
> +void PlasmaWindowManagement::Private::setStackingOrder(QVector ids)
> +{

Should be a const ref.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29054

To: bport, zzag, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

[Yunhe Guo]

guoyunhe added a comment.


  I do try scour but the result is disappointing. I get 16 times the following 
error:
  
hge difference of 123 in ./icons-dark/apps/48/hwinfo.svg
  
  which means 16 icons are unacceptable after scour optimization

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29083: correct vscode icon name

[Yunhe Guo]

guoyunhe added a reviewer: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29083

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns