D25551: Mark KXmlRpcClient as porting aid

2020-05-19 Thread Daniel Vrátil 
dvratil accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R312 KXmlRpcClient

BRANCH
  portaid

REVISION DETAIL
  https://phabricator.kde.org/D25551

To: nicolasfella, #frameworks, dvratil
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-19 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  create-kcmshell-openSystemSettings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: ltoscano, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28673: [PackageUrlInterceptor] Make QRegularExpression static

2020-05-19 Thread Kai Uwe Broulik 
broulik added a comment.


  so, can the regexp be replaced or does it need to stay?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28673

To: broulik, #plasma
Cc: bruns, pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D28673: [PackageUrlInterceptor] Make QRegularExpression static

2020-05-19 Thread Pino Toscano 
pino added a comment.


  In D28673#672845 , @broulik wrote:
  
  > so, can the regexp be replaced or does it need to stay?
  
  
  Sure: look for `/ui/` in path, and if it is there, join what's before it + 
prefix + what's after it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28673

To: broulik, #plasma
Cc: bruns, pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

2020-05-19 Thread Matej Mrenica 
mthw added a comment.


  This patch also fixes buttons in kded dialogs like the wifi password dialog.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29815

To: mthw, #frameworks, zzag
Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29228: [KProcessRunner] Use only executable name for scope

2020-05-19 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29228

To: broulik, #frameworks, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29228: [KProcessRunner] Use only executable name for scope

2020-05-19 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:19d23d386cf7: [KProcessRunner] Use only executable name 
for scope (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29228?vs=81338&id=83058

REVISION DETAIL
  https://phabricator.kde.org/D29228

AFFECTED FILES
  src/gui/kprocessrunner.cpp

To: broulik, #frameworks, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 132 - Still Unstable!

2020-05-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/132/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 19 May 2020 09:58:44 +
 Build duration:
8 min 12 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27805: Add a screenshot capture item and use it to test rendering

2020-05-19 Thread Arjen Hiemstra 
ahiemstra abandoned this revision.
ahiemstra added a comment.


  Will continue this on Gitlab.

REPOSITORY
  R1049 KQuickCharts

REVISION DETAIL
  https://phabricator.kde.org/D27805

To: ahiemstra
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

2020-05-19 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  Patch worked fine also on real server run the last two nights. So going to 
push later today once at my respective development setup. Will push as is, 
given safe_load() is now also used without any conditions for the new 
invent.kde.org git helper :) so doing as the real Python developers do.

REPOSITORY
  R264 KApiDox

BRANCH
  makedepworkwithpython3

REVISION DETAIL
  https://phabricator.kde.org/D29797

To: kossebau, #frameworks, ochurlaud, ognarb, cblack, winterz, francescorios
Cc: asturmlechner, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, 
gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna

D29797: Unbreak generation with dep diagrams with Python 3 (break Py2)

2020-05-19 Thread Friedrich W. H. Kossebau 
kossebau retitled this revision from "[RAW PATCH] Unbreak generation with dep 
diagrams with Python 3 (& break P2 :) )" to "Unbreak generation with dep 
diagrams with Python 3 (break Py2)".
kossebau edited the summary of this revision.

REPOSITORY
  R264 KApiDox

BRANCH
  makedepworkwithpython3

REVISION DETAIL
  https://phabricator.kde.org/D29797

To: kossebau, #frameworks, ochurlaud, ognarb, cblack, winterz, francescorios
Cc: asturmlechner, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, 
gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 133 - Fixed!

2020-05-19 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/133/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 19 May 2020 11:21:04 +
 Build duration:
7 min 48 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28673: [PackageUrlInterceptor] Make QRegularExpression static

2020-05-19 Thread Ahmad Samir 
ahmadsamir commandeered this revision.
ahmadsamir added a reviewer: broulik.
ahmadsamir added a comment.


  Should be handled by 
https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/2

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28673

To: ahmadsamir, #plasma, broulik
Cc: ahmadsamir, bruns, pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D28673: [PackageUrlInterceptor] Make QRegularExpression static

2020-05-19 Thread Ahmad Samir 
ahmadsamir abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28673

To: ahmadsamir, #plasma, broulik
Cc: ahmadsamir, bruns, pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D29797: Unbreak generation with dep diagrams with Python 3 (break Py2)

2020-05-19 Thread Friedrich W. H. Kossebau 
kossebau closed this revision.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D29797

To: kossebau, #frameworks, ochurlaud, ognarb, cblack, winterz, francescorios
Cc: asturmlechner, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, 
gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-19 Thread Nathaniel Graham 
ngraham closed this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: ltoscano, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 18 - Still Unstable!

2020-05-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/18/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 19 May 2020 13:03:12 +
 Build duration:
3 min 19 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

D29381: Thumbnail text: use libmagic to detect encoding

2020-05-19 Thread Harald Sitter 
sitter added a comment.


  LGTM. Seeing as I don't have much background knowledge I'm not comfortable 
accepting though. I guess if nobody comes up with better options by next week 
feel free to land.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29381

To: meven, #frameworks, sitter, ngraham
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29463: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

2020-05-19 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29463

To: Zren, #kirigami, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29540: plasmawindowmodel: Expose the internal id to the model

2020-05-19 Thread Aleix Pol Gonzalez 
apol abandoned this revision.
apol added a comment.


  Will move to gitlab

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29540

To: apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29335: Implement notification grouping on Android

2020-05-19 Thread Volker Krause 
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:942bddded289: Implement notification grouping on Android 
(authored by vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D29335?vs=81731&id=83063#toc

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29335?vs=81731&id=83063

REVISION DETAIL
  https://phabricator.kde.org/D29335

AFFECTED FILES
  src/android/org/kde/knotifications/KNotification.java
  src/android/org/kde/knotifications/NotifyByAndroid.java
  src/notifybyandroid.cpp

To: vkrause, nicolasfella
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29358: Implement lock-screen visibility control on Android

2020-05-19 Thread Volker Krause 
vkrause added a comment.


  ping?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29358

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-19 Thread Nathaniel Graham 
ngraham added a comment.


  @ahiemstra #frameworks  #plasma 
 ping.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: ahiemstra, abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D29436: Use font: instead of font.pointSize: where possible

2020-05-19 Thread Carson Black 
cblack accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  use-whole-font (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29436

To: ngraham, #plasma, cblack
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29436: Use font: instead of font.pointSize: where possible

2020-05-19 Thread Nathaniel Graham 
ngraham closed this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29436

To: ngraham, #plasma, cblack
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29381: Thumbnail text: use libmagic to detect encoding

2020-05-19 Thread Méven Car 
meven added a comment.


  I am only half satisfied by the patch.
  Mostly because of libmagic `magic_load` that loads a 5M file each time which 
is not needed to detect encoding.
  
  I would add some tests before landing anyways.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29381

To: meven, #frameworks, sitter, ngraham
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-19 Thread Méven Car 
meven added inline comments.

INLINE COMMENTS

> alex wrote in kpluginselector.cpp:855
> > moduleInfo is part of the ctor here, so the fileName is already available 
> > indirectly.
> 
> Yes, but the KCModuleProxy is just a wrapper class for the KCModule.
> The actual KCModule gets created in kcmoduleloader.cpp line 93+.
> 
> PS: The moduleInfo is also available there, but I don't see any elegant way 
> to make it available to the KCModule other than a property or appending it to 
> the list of arguments.
> 
> >   A good thing would be to avoid having an option for such a niche usage 
> > although legitimate.
> 
> Always open to suggestions 😃

Seems like a property would make sense, after all it is about it, or a ref to 
the KCModuleInfo

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D29201

To: alex, #plasma, ngraham, meven, broulik, mart
Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-19 Thread Alexander Lohnau 
alex added inline comments.

INLINE COMMENTS

> meven wrote in kpluginselector.cpp:855
> Seems like a property would make sense, after all it is about it, or a ref to 
> the KCModuleInfo

I have created a PR on Gitlab for this

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D29201

To: alex, #plasma, ngraham, meven, broulik, mart
Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-19 Thread Alexander Lohnau 
alex abandoned this revision.
alex added a comment.


  Abandoning this in favor of 
https://invent.kde.org/frameworks/kconfigwidgets/-/merge_requests/1 and a 
follow up PR.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D29201

To: alex, #plasma, ngraham, meven, broulik, mart
Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D17816: Support for xattrs on kio copy/move

2020-05-19 Thread Gleb Popov 
arrowd updated this revision to Diff 83068.
arrowd marked 18 inline comments as done.
arrowd added a comment.


  - Use full paths to command line utilities and pass xattr args correctly.
  - Mark some stale comments as done.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17816?vs=83016&id=83068

BRANCH
  arcpatch-D17816

REVISION DETAIL
  https://phabricator.kde.org/D17816

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/ConfigureChecks.cmake
  src/ioslaves/file/config-kioslave-file.h.cmake
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

D25814: [KColorScheme] Add SeparatorColor

2020-05-19 Thread Noah Davis 
ndavis abandoned this revision.
ndavis added a comment.


  Abandoning this since others would rather have this in QPalette

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: ahiemstra, broulik, manueljlin, alexde, ngraham, davidedmundson, filipf, 
cfeck, hpereiradacosta, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D24975: Change some 32px action icons to color style

2020-05-19 Thread Noah Davis 
ndavis abandoned this revision.
ndavis added a comment.


  Saving this for later on invent.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg, ngraham
Cc: ngraham, mglb, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29095: Change mouse icon to have better dark theme contrast

2020-05-19 Thread Noah Davis 
ndavis closed this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: ndavis, #vdg, saligari, ngraham
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D17816: Support for xattrs on kio copy/move

2020-05-19 Thread Cochise César 
cochise added a comment.


  In D17816#671870 , @arrowd wrote:
  
  > I decided to help with this a bit.
  
  
  My hands are full at the moment, so I'm unable to finish this for some time. 
Thank you.
  
  In D17816#672405 , @arrowd wrote:
  
  > At this stage, all tests in `jobtest` pass on FreeBSD.
  
  
  I'm very happy to see this working well on BSD as well.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-19 Thread Méven Car 
meven added a comment.


  ping dear reviewers

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks, ngraham
Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns