KDE CI: Frameworks » kcmutils » kf5-qt5 WindowsMSVCQt5.14 - Build # 40 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20WindowsMSVCQt5.14/40/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 23 May 2020 03:19:51 +
 Build duration:
2 min 38 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KEmoticons, emoticons kcm

[Aleix Pol]

Hi,
I was looking through some Plasma code and I saw that we have some
fairly old emoticons KCM using KF5Emoticons.

Now while I know why this exists, it feels like it's more of a thing
of the past from when people wrote :) instead of . While keeping it
around for the few apps that might still use it (ktp? kopete?) could
make sense, I'm afraid it's probably making it confusing for the users
who expect this to actually allow them to customise their  but
won't.

Do you think it would make sense to deprecate the framework and remove the KCM?

If some application still uses it, they can integrate the kcm
temporarily until their users come to terms that  is the new :).

Aleix

D22488: invoke QIcon::setFallbackThemeName a bit later

[Albert Astals Cid]

aacid added a comment.


  Now i understand this is causing relatively several issues, sorry for 
dropping the ball, so we should probably fix for users before Qt 5.15.1
  
  What about something like
  
diff --git a/src/kicontheme.cpp b/src/kicontheme.cpp
index 4f5d9d5..62fc9d7 100644
--- a/src/kicontheme.cpp
+++ b/src/kicontheme.cpp
@@ -70,6 +70,19 @@ void initRCCIconTheme()
 }
 Q_COREAPP_STARTUP_FUNCTION(initRCCIconTheme)
 
+class SetBreezeFallbackHelper : public QObject
+{
+bool event(QEvent *e) override
+{
+if (e->type() == QEvent::User) {
+QIcon::setFallbackThemeName(QStringLiteral("breeze"));
+deleteLater();
+return true;
+}
+return QObject::event(e);
+}
+};
+
 // Set the icon theme fallback to breeze
 // Most of our apps use "lots" of icons that most of the times
 // are only available with breeze, we still honour the user icon
@@ -77,7 +90,8 @@ Q_COREAPP_STARTUP_FUNCTION(initRCCIconTheme)
 // since it's almost sure it'll be there
 static void setBreezeFallback()
 {
-QIcon::setFallbackThemeName(QStringLiteral("breeze"));
+SetBreezeFallbackHelper *helper = new SetBreezeFallbackHelper();
+QCoreApplication::instance()->postEvent(helper, new 
QEvent(QEvent::User), Qt::HighEventPriority);
 }
 
 Q_COREAPP_STARTUP_FUNCTION(setBreezeFallback)
  
  It's still totally bad since it only sets the fallback after QGuiApplication 
*starts* running (which is mega late since most of the constructors will have 
already be created), but at least doesn't rely on the app creating a KIconTheme.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D22488

To: mart, #frameworks, #plasma
Cc: aacid, mlaurent, broulik, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D22488: invoke QIcon::setFallbackThemeName a bit later

[Albert Astals Cid]

aacid added a comment.


  https://codereview.qt-project.org/c/qt/qtbase/+/301588

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D22488

To: mart, #frameworks, #plasma
Cc: aacid, mlaurent, broulik, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D22488: invoke QIcon::setFallbackThemeName a bit later

[Albert Astals Cid]

aacid added a comment.


  Wouldn't it make more sense to fix in Qt?
  
  Something like
  
diff --git a/src/gui/image/qicon.cpp b/src/gui/image/qicon.cpp
index 41fe649fc5..f86ad3c760 100644
--- a/src/gui/image/qicon.cpp
+++ b/src/gui/image/qicon.cpp
@@ -1260,7 +1260,7 @@ QString QIcon::fallbackThemeName()
 */
 void QIcon::setFallbackThemeName(const QString )
 {
-QIconLoader::instance()->setFallbackThemeName(name);
+QIconLoader::instance(NoInializeNeeded)->setFallbackThemeName(name);
 }
 
 /*!
diff --git a/src/gui/image/qiconloader.cpp b/src/gui/image/qiconloader.cpp
index 15ab1b3cd9..96dfd9163d 100644
--- a/src/gui/image/qiconloader.cpp
+++ b/src/gui/image/qiconloader.cpp
@@ -125,10 +125,12 @@ void QIconLoader::ensureInitialized()
 }
 }
 
-QIconLoader *QIconLoader::instance()
+QIconLoader *QIconLoader::instance(InstanceOptions o)
 {
-   iconLoaderInstance()->ensureInitialized();
-   return iconLoaderInstance();
+if (o == EnsureInitialized) {
+iconLoaderInstance()->ensureInitialized();
+}
+return iconLoaderInstance();
 }
 
 // Queries the system theme and invalidates existing
diff --git a/src/gui/image/qiconloader_p.h b/src/gui/image/qiconloader_p.h
index fac18b5d79..a69da4a5f7 100644
--- a/src/gui/image/qiconloader_p.h
+++ b/src/gui/image/qiconloader_p.h
@@ -185,7 +185,11 @@ public:
 void setFallbackSearchPaths(const QStringList );
 QStringList fallbackSearchPaths() const;
 QIconDirInfo dirInfo(int dirindex);
-static QIconLoader *instance();
+enum InstanceOptions {
+NoInializeNeeded = 0,
+EnsureInitialized = 1
+}
+static QIconLoader *instance(InstanceOptions o = EnsureInitialized);
 void updateSystemTheme();
 void invalidateKey() { m_themeKey++; }
 void ensureInitialized();
  
  I think this should be relatively easy to push though in Qt explaining that 
small ordering issue there is
  
  Not sure it compiles, for some reason i can't compile Qt 5.15 branch right now

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D22488

To: mart, #frameworks, #plasma
Cc: aacid, mlaurent, broulik, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

[Albert Astals Cid]

aacid added a comment.


  Not sure if you're subscribed to https://phabricator.kde.org/D22488 see my 
last comment there i think it's the way to go

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D29826

To: poboiko, aacid, mart, broulik
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

[Albert Astals Cid]

aacid added a comment.


  I don't think moving this code from KIconThemes to kmainwindow makes sense, 
what about all the apps that use KIconThemes but no KMainWindow?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D29826

To: poboiko, aacid, mart, broulik
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/23/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 22 May 2020 20:32:51 +
 Build duration:
59 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 135 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/135/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 22 May 2020 20:03:33 +
 Build duration:
57 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/22/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 22 May 2020 19:08:32 +
 Build duration:
1 hr 24 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

[Matej Mrenica]

mthw added a comment.


  @davidedmundson What do you think about this patch?

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29815

To: mthw, #frameworks, davidedmundson
Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/21/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 22 May 2020 18:10:01 +
 Build duration:
58 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 134 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/134/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 22 May 2020 17:54:08 +
 Build duration:
57 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D29281: Deprecate defunct functions

[Alexander Lohnau]

alex marked an inline comment as done.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D29281

To: alex, #plasma, broulik, davidedmundson, vkrause, meven
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29281: Deprecate defunct functions

[Alexander Lohnau]

alex updated this revision to Diff 83119.
alex added a comment.


  Fix typo in version number

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29281?vs=83115=83119

BRANCH
  deprecations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29281

AFFECTED FILES
  src/CMakeLists.txt
  src/abstractrunner.cpp
  src/abstractrunner.h
  src/querymatch.cpp
  src/querymatch.h

To: alex, #plasma, broulik, davidedmundson, vkrause, meven
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29281: Deprecate defunct functions

[Alexander Lohnau]

alex added inline comments.

INLINE COMMENTS

> meven wrote in querymatch.cpp:338
> Did you really need to remove this code ?

The question this method should answer is: Does this match have a configuration 
interface?
And the answer is no, because the functionality does not exist anymore.
And if it is not removed a deprecated function would be called.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D29281

To: alex, #plasma, broulik, davidedmundson, vkrause, meven
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29281: Deprecate defunct functions

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> querymatch.cpp:338
>  {
> -return d->runner && d->runner.data()->hasRunOptions();
>  }

Did you really need to remove this code ?

> querymatch.cpp:343
>  
> +#if KRUNNER_BUILD_DEPRECATED_SINCE(5, 1)
>  void QueryMatch::createConfigurationInterface(QWidget *parent)

#if KRUNNER_BUILD_DEPRECATED_SINCE(5, 71)

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D29281

To: alex, #plasma, broulik, davidedmundson, vkrause, meven
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29281: Deprecate defunct functions

[Alexander Lohnau]

alex added inline comments.

INLINE COMMENTS

> kossebau wrote in abstractrunner.h:154
> Should be "5.0", not "5,0" here in the API dox text and elsewhere, no? (dot 
> instead of comma)

Yes. I accidentally did it this way, because in German you use a comma :D

> kossebau wrote in abstractrunner.h:156
> ECMGenerateExportHeader now (for 5.71) features support for using a different 
> version number to be shown in the compiler warning: 
> KRUNNER_DEPRECATED_VERSION_BELATED
> 
> So you could make this:
> 
>   KRUNNER_DEPRECATED_VERSION_BELATED(5, 71,  5, 0, "No longer use, feature 
> removed")

This is pretty cool, many thanks again.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D29281

To: alex, #plasma, broulik, davidedmundson, vkrause, meven
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29281: Deprecate defunct functions

[Alexander Lohnau]

alex marked 9 inline comments as done.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D29281

To: alex, #plasma, broulik, davidedmundson, vkrause, meven
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29281: Deprecate defunct functions

[Alexander Lohnau]

alex updated this revision to Diff 83115.
alex added a comment.


  Fix comma, KRUNNER_DEPRECATED_VERSION_BELATED macro

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29281?vs=83110=83115

BRANCH
  deprecations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29281

AFFECTED FILES
  src/CMakeLists.txt
  src/abstractrunner.cpp
  src/abstractrunner.h
  src/querymatch.cpp
  src/querymatch.h

To: alex, #plasma, broulik, davidedmundson, vkrause, meven
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28235: Add a simpler example

[Aleix Pol Gonzalez]

apol closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28235

To: apol, vkrause, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D28235: Add a simpler example

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  ;=) Actually, I just missed this request, sorry.
  
  I think there is no issue with have an extra example.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28235

To: apol, vkrause, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D26524: configmodule: Make sure the kcm information is loaded when the qml is created

[Aleix Pol Gonzalez]

apol added a comment.


  hmmm. Ping @mart. :) what do you suggest we do?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26524

To: apol, #plasma, #frameworks
Cc: mart, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28235: Add a simpler example

[Aleix Pol Gonzalez]

apol added a comment.


  Should I understand this is not desired and that I should abandon it?
  
  I know it's not going to make a big difference to the project but it was hard 
for me to adopt it in the first place.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28235

To: apol, vkrause
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

[Igor Poboiko]

poboiko added a comment.


  My main motivation here is following: 
https://gerrit.libreoffice.org/c/core/+/94691. 
  If it gets accepted, it would fix long-standing issue that people aren't able 
to use Libreoffice with KF5 integration plugin together with dark color scheme 
(and "breeze-dark" icon theme) out-of-the-box.
  
  See also:
  https://bugs.documentfoundation.org/show_bug.cgi?id=116683
  https://bugs.documentfoundation.org/show_bug.cgi?id=127138
  https://forum.manjaro.org/t/change-libreoffice-look-and-feel/48357
  https://bbs.archlinux.org/viewtopic.php?id=20
  https://www.reddit.com/r/kde/comments/4qqpqr/kde_dark_themes_and_libreoffice/
  
https://askubuntu.com/questions/1026103/libre-office-display-more-visible-icons-on-dark-breeze-kde-theme
  
  In short, people suggest using gtk3 VCL plugin, because it hooks with 
kde-gtk-config which exports KDE icon theme to GTK. Instead of native KF5 VCL 
plugin. What a shame!

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D29826

To: poboiko, aacid, mart, broulik
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

[Igor Poboiko]

poboiko edited the summary of this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D29826

To: poboiko, aacid, mart, broulik
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

[Méven Car]

meven added a comment.


  @pino ping

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29805

To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[Méven Car]

meven updated this revision to Diff 83112.
meven added a comment.


  Update @since, improve doc

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28590?vs=81061=83112

BRANCH
  arcpatch-D28590_1

REVISION DETAIL
  https://phabricator.kde.org/D28590

AFFECTED FILES
  src/solid/devices/backends/fakehw/fakedevice.cpp
  src/solid/devices/backends/fakehw/fakedevice.h
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/backends/fstab/fstabmanager.cpp
  src/solid/devices/backends/shared/rootdevice.cpp
  src/solid/devices/backends/shared/rootdevice.h
  src/solid/devices/backends/udev/udevdevice.cpp
  src/solid/devices/backends/udev/udevdevice.h
  src/solid/devices/backends/udev/udevmanager.cpp
  src/solid/devices/backends/udisks2/udisksdevice.cpp
  src/solid/devices/backends/udisks2/udisksdevice.h
  src/solid/devices/backends/udisks2/udisksmanager.cpp
  src/solid/devices/backends/upower/upowerdevice.cpp
  src/solid/devices/backends/upower/upowerdevice.h
  src/solid/devices/backends/upower/upowermanager.cpp
  src/solid/devices/frontend/device.cpp
  src/solid/devices/frontend/device.h
  src/solid/devices/ifaces/device.h

To: meven, #frameworks, bruns, sitter
Cc: ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[Méven Car]

meven added a subscriber: ervin.
meven added a comment.


  @ervin perhaps you might review this as @bruns seems too busy.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28590

To: meven, #frameworks, bruns, sitter
Cc: ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29281: Deprecate defunct functions

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> abstractrunner.h:154
>   * is called, the runner should return true
> + * @deprecated Since 5,0, this feature has been defunct
>   */

Should be "5.0", not "5,0" here in the API dox text and elsewhere, no? (dot 
instead of comma)

> abstractrunner.h:156
>   */
> +KRUNNER_DEPRECATED_VERSION(5, 71, "No longer use, feature removed")
>  bool hasRunOptions();

ECMGenerateExportHeader now (for 5.71) features support for using a different 
version number to be shown in the compiler warning: 
KRUNNER_DEPRECATED_VERSION_BELATED

So you could make this:

  KRUNNER_DEPRECATED_VERSION_BELATED(5, 71,  5, 0, "No longer use, feature 
removed")

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D29281

To: alex, #plasma, broulik, davidedmundson, vkrause, meven
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29281: Deprecate defunct functions

[Alexander Lohnau]

alex added a reviewer: meven.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D29281

To: alex, #plasma, broulik, davidedmundson, vkrause, meven
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29050: KRunner fix prepare/teardown signals

[Alexander Lohnau]

alex added a comment.


  Now I understand where it is called and how it works exactly.
  May I ship this?

REPOSITORY
  R308 KRunner

BRANCH
  krunner_signal_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29050

To: alex, meven, ngraham, broulik
Cc: davidedmundson, cfeck, kde-frameworks-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, michaelh, 
ZrenBot, ngraham, bruns, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D29050: KRunner fix prepare/teardown signals

[Alexander Lohnau]

alex edited the summary of this revision.

REPOSITORY
  R308 KRunner

BRANCH
  krunner_signal_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29050

To: alex, meven, ngraham, broulik
Cc: davidedmundson, cfeck, kde-frameworks-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, michaelh, 
ZrenBot, ngraham, bruns, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D29281: Deprecate defunct functions

[Alexander Lohnau]

alex updated this revision to Diff 83110.
alex added a comment.


  Change deprecation version from 5.70 to 5.71

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29281?vs=81546=83110

BRANCH
  deprecations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29281

AFFECTED FILES
  src/CMakeLists.txt
  src/abstractrunner.cpp
  src/abstractrunner.h
  src/querymatch.cpp
  src/querymatch.h

To: alex, #plasma, broulik, davidedmundson, vkrause
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29050: KRunner fix prepare/teardown signals

[Alexander Lohnau]

alex added a comment.


  > Repo is called milou
  
  Thanks!

REPOSITORY
  R308 KRunner

BRANCH
  krunner_signal_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29050

To: alex, meven, ngraham, broulik
Cc: davidedmundson, cfeck, kde-frameworks-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, michaelh, 
ZrenBot, ngraham, bruns, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D29050: KRunner fix prepare/teardown signals

[David Edmundson]

davidedmundson added a comment.


  > the runner "backend" is used (from the QML side of things).
  
  Repo is called milou

REPOSITORY
  R308 KRunner

BRANCH
  krunner_signal_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29050

To: alex, meven, ngraham, broulik
Cc: davidedmundson, cfeck, kde-frameworks-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, michaelh, 
ZrenBot, ngraham, bruns, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D29050: KRunner fix prepare/teardown signals

[Alexander Lohnau]

alex added a comment.


  But can you please explain, where in the QML code the actual KRunner backend 
is used?
  Maybe then I can understand it better .

REPOSITORY
  R308 KRunner

BRANCH
  krunner_signal_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29050

To: alex, meven, ngraham, broulik
Cc: cfeck, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, michaelh, ZrenBot, ngraham, bruns, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

KDE CI: Frameworks » kcmutils » kf5-qt5 WindowsMSVCQt5.14 - Build # 35 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20WindowsMSVCQt5.14/35/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Fri, 22 May 2020 10:30:10 +
 Build duration:
2 min 12 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kcmoduleinfotest

D29358: Implement lock-screen visibility control on Android

[Nicolas Fella]

nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D29358

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29035: Install service files for kwin

[Kai Uwe Broulik]

broulik marked an inline comment as done.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29035

To: broulik, #plasma, #frameworks
Cc: davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, 
crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29050: KRunner fix prepare/teardown signals

[Kai Uwe Broulik]

broulik added a comment.


  I'm sorry, I don't really know how this teardown stuff all works :/

REPOSITORY
  R308 KRunner

BRANCH
  krunner_signal_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29050

To: alex, meven, ngraham, broulik
Cc: cfeck, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, michaelh, ZrenBot, ngraham, bruns, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: aacid, mart, broulik.
Herald added a project: Frameworks.
poboiko requested review of this revision.

REVISION SUMMARY
  This is alternative approach to D22488: invoke QIcon::setFallbackThemeName a 
bit later  and commit 4214045 
 to 
KIconThemes.
  Okular (and most - if not all - KDE apps inherit KMainWindow, so KDE apps
  should have breeze icons). KMainWindow ctor should be early enough so no icons
  are yet loaded, but late enough so QGuiApplication is already inited.
  
  This should be followed by reverting commit 4214045 
 in 
KIconThemes.
  
  Original problem description (by @mart):
  invoking QIcon::setFallbackThemeName at QCoreApplication ctor
  with Q_COREAPP_STARTUP_FUNCTION breaks the internal status of
  QIconLoader as it instantiates it before the QPlatformTheme,
  but QIconLoader depends from QPlatformTheme to be already instantiated
  otherwise it won't load correctly, thus breaking icon loading
  in QtQuickControls2 styles, such as Material and Fusion
  see https://bugreports.qt.io/browse/QTBUG-74252
  
  CCBUG: 402172

TEST PLAN
  Don't have GTK3 QPA plugin, so cannot test it yet.
  I would appreciate if someone helped me with testing :)

REPOSITORY
  R263 KXmlGui

BRANCH
  icon-load (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29826

AFFECTED FILES
  src/kmainwindow.cpp

To: poboiko, aacid, mart, broulik
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29050: KRunner fix prepare/teardown signals

[Alexander Lohnau]

alex added a comment.


  Thanks and I get why it is hard to review.
  
  Could @broulik please help/have a look at this.
  A issue I have with understanding some of the KRunner stuff is that I don't 
know where exactly
  the runner "backend" is used (from the QML side of things).
  
  Thanks 

REPOSITORY
  R308 KRunner

BRANCH
  krunner_signal_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29050

To: alex, meven, ngraham, broulik
Cc: cfeck, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, michaelh, ZrenBot, ngraham, bruns, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29035: Install service files for kwin

[Kai Uwe Broulik]

broulik updated this revision to Diff 83108.
broulik added a comment.


  - Use `After` instead of `Wants`

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29035?vs=80723=83108

REVISION DETAIL
  https://phabricator.kde.org/D29035

AFFECTED FILES
  CMakeLists.txt
  plasma-kwin_wayland.service.in
  plasma-kwin_x11.service.in

To: broulik, #plasma, #frameworks
Cc: davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, 
crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29825: Add SystemdService to DBus service file

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, davidedmundson, kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Using the new `ECMGenerateDBusServiceFile` of D29051 


TEST PLAN
  - Had a proper file generated and installed

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29825

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt

To: broulik, #frameworks, davidedmundson, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29051: Add ecm_generate_dbus_service_file

[Kai Uwe Broulik]

broulik updated this revision to Diff 83105.
broulik added a comment.


  - Clarify docs

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29051?vs=80776=83105

REVISION DETAIL
  https://phabricator.kde.org/D29051

AFFECTED FILES
  docs/module/ECMGenerateDBusServiceFile.rst
  modules/ECMGenerateDBusServiceFile.cmake

To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29051: Add ecm_generate_dbus_service_file

[Kai Uwe Broulik]

broulik marked 3 inline comments as done.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29051

To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29358: Implement lock-screen visibility control on Android

[Volker Krause]

vkrause updated this revision to Diff 83104.
vkrause added a comment.


  Rename visibility hint.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29358?vs=81734=83104

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D29358

AFFECTED FILES
  src/android/org/kde/knotifications/KNotification.java
  src/android/org/kde/knotifications/NotifyByAndroid.java
  src/notifybyandroid.cpp

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns