D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

[Andreas Kainz]

andreask added a comment.


  I had choose also an tooltip like most other apps do and there it work very 
well.
  
  F6740005: libreoffice-password-content.png 


REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19512

To: loh.tar, #ktexteditor, cullmann
Cc: andreask, ngraham, cullmann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, gennad, domson, michaelh, bruns, demsking, sars, dhaumann

D18282: document-new icon follow ColorScheme-Text

[Andreas Kainz]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:e3804e633e67: document-new icon follow ColorScheme-Text 
(authored by andreask).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18282?vs=49583=49585

REVISION DETAIL
  https://phabricator.kde.org/D18282

AFFECTED FILES
  icons-dark/actions/16/document-new.svg
  icons-dark/actions/22/document-new.svg
  icons-dark/actions/24/document-new.svg
  icons/actions/16/document-new.svg
  icons/actions/22/document-new.svg
  icons/actions/24/document-new.svg

To: andreask, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, andreaska, michaelh, bruns

D18282: document-new icon follow ColorScheme-Text

[Andreas Kainz]

andreask created this revision.
andreask added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
andreask requested review of this revision.

REVISION SUMMARY
  icon follow now ColorScheme-Text color

TEST PLAN
  change to breeze-dark and open kwrite the new icon didn't use the text color

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18282

AFFECTED FILES
  icons-dark/actions/16/document-new.svg
  icons-dark/actions/22/document-new.svg
  icons-dark/actions/24/document-new.svg
  icons/actions/16/document-new.svg
  icons/actions/22/document-new.svg
  icons/actions/24/document-new.svg

To: andreask, #vdg
Cc: kde-frameworks-devel, andreaska, michaelh, ngraham, bruns

D17033: Change primary monochrome icon colors to match new HIG colors

[Andreas Kainz]

andreask added a comment.


  Thanks for the update, I will work with the new colors also in LibO. We have 
there an issue on OS-X cause the contrast was not good enough and the new 
darker color will give an better contrast.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17033

To: ndavis, #vdg, #breeze
Cc: andreask, kde-frameworks-devel, #breeze, #vdg, michaelh, ngraham, bruns

D7446: [Places panel] Add a Recently Used item by default

[Andreas Kainz]

andreask added a comment.


  I would suggest to have by default detail view instead of icon view cause 
with detail view it's easier to read the paths.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, 
andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, 
davidedmundson, ltoscano, #konqueror, alexde, sourabhboss, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D15931: [Places panel] use more appropriate network icon

[Andreas Kainz]

andreaska accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  better-network-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15931

To: ngraham, #vdg, nicolasfella, andreaska
Cc: broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D14218: Introduce a test to make sure we're not offering duplicated icons

[Andreas Kainz]

andreaska accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #breeze, #frameworks
Cc: ngraham, andreask, kde-frameworks-devel, michaelh, bruns

D14123: Add `drive-optical` icon

[Andreas Kainz]

andreaska added a comment.


  Thanks for the patch.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D14123

To: ngraham, broulik, andreask, #breeze, #vdg
Cc: andreaska, kde-frameworks-devel, michaelh, ngraham, bruns

D11874: change 24px view-media-artist icon

[Andreas Kainz]

andreask accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  media-artist

REVISION DETAIL
  https://phabricator.kde.org/D11874

To: astippich, #vdg, andreask
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13137: Updated handles and overflow-menu-*

[Andreas Kainz]

andreask accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13137

To: alex-l, mart, andreask, andreaska
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11863: Add virt-manager icons

[Andreas Kainz]

andreask closed this revision.
andreask added a comment.


  Thanks for the commit.
  
  I checked the icons and optimize the icon size. virt-manager is now in master.
  
  
https://cgit.kde.org/breeze-icons.git/commit/?id=63450fec7aa14ba3a32972a434064c499ea048a9

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11863

To: ndavis, #vdg, ngraham, andreaska, andreask, #breeze
Cc: ngraham, andreaska, #frameworks, michaelh, bruns

D10494: update handle- icons for kirigami

[Andreas Kainz]

andreaska added a comment.


  In D10494#220993 , @mart wrote:
  
  > As discussed on the channel, the icon should be one of these forms, for me 
are both ok
  >  F5744901: handle-right.png 
  
  
  I am for this

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: andreaska, colomar, matheusm, mmustac, ngraham, #frameworks, michaelh, bruns

D11137: overflow-menu as view-more-symbolic, and horizontal

[Andreas Kainz]

andreaska accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  phab/overflow

REVISION DETAIL
  https://phabricator.kde.org/D11137

To: mart, #vdg, andreaska
Cc: Fuchs, #frameworks, michaelh, ngraham, bruns

D11863: Add virt-manager icons

[Andreas Kainz]

andreask accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  virt-manager_icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11863

To: ndavis, #vdg, ngraham, andreaska, andreask
Cc: ngraham, andreaska, #frameworks, michaelh

D11461: rename 64 px icons added for elisa

[Andreas Kainz]

andreask accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  icons_move

REVISION DETAIL
  https://phabricator.kde.org/D11461

To: astippich, #breeze, #vdg, andreask
Cc: #frameworks, michaelh, ngraham

D10292: change 32px icons for playlist shuffle and repeat

[Andreas Kainz]

andreask accepted this revision.
andreask added a comment.
This revision is now accepted and ready to land.


  sorry for the late approve.

REPOSITORY
  R266 Breeze Icons

BRANCH
  playlist_shuffle_repeat

REVISION DETAIL
  https://phabricator.kde.org/D10292

To: astippich, #breeze, #vdg, andreaska, andreask, ngraham
Cc: bcooksley, andreask, ngraham, #frameworks, michaelh

D11390: new icons for disconnected/disabled devices

[Andreas Kainz]

andreask accepted this revision.
andreask added a comment.
This revision is now accepted and ready to land.


  look good to me thanks

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/network

REVISION DETAIL
  https://phabricator.kde.org/D11390

To: mart, #plasma, #vdg, andreask
Cc: andreask, #frameworks, michaelh, ngraham

D11054: Add media status icons

[Andreas Kainz]

andreask accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  mediaStatus

REVISION DETAIL
  https://phabricator.kde.org/D11054

To: romangg, #plasma, #frameworks, #vdg, andreask
Cc: michaelh

D11049: Remove frame around media action icons

[Andreas Kainz]

andreask accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  reworkMediaActions

REVISION DETAIL
  https://phabricator.kde.org/D11049

To: romangg, #breeze, #vdg, andreask
Cc: mart, #frameworks, michaelh

D10292: change 32px icons for playlist shuffle and repeat

[Andreas Kainz]

andreask requested changes to this revision.
andreask added a comment.
This revision now requires changes to proceed.


  only in 16px there is no circle and in general I'm not really happy to have 
no circle around the icon. maybe for repeat and shuffle it will work but 
play/pause are more intuitive with circle than without.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10292

To: astippich, #breeze, #vdg, andreaska, andreask
Cc: andreask, ngraham, #frameworks, michaelh

D10293: remove view-media-playlist from preferences icons

[Andreas Kainz]

andreask accepted this revision.
andreask added a comment.
This revision is now accepted and ready to land.


  I added the colored icon for elisa but I understood if you don't like it. 
personally I'm not 100% happy with large monochrome icons.

REPOSITORY
  R266 Breeze Icons

BRANCH
  delete_playlist_preferences

REVISION DETAIL
  https://phabricator.kde.org/D10293

To: astippich, #breeze, #vdg, andreaska, andreask
Cc: andreask, #frameworks, michaelh

D10279: add 24px media-album-cover icon

[Andreas Kainz]

andreask accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  media-album-cover

REVISION DETAIL
  https://phabricator.kde.org/D10279

To: astippich, #breeze, #vdg, andreaska, andreask
Cc: ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

[Andreas Kainz]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:55b56d236e9b: update handle- icons for kirigami (authored 
by andreask).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10494?vs=27104=27312

REVISION DETAIL
  https://phabricator.kde.org/D10494

AFFECTED FILES
  icons-dark/actions/22/handle-left.svg
  icons-dark/actions/22/handle-right.svg
  icons/actions/22/handle-left.svg
  icons/actions/22/handle-right.svg

To: andreask, alex-l, mart
Cc: matheusm, mmustac, ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

[Andreas Kainz]

andreask added a comment.


  submitted

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: matheusm, mmustac, ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

[Andreas Kainz]

andreask added a comment.


  it doesn't matter where the element in kirigami swap it's for settings and 
have an dotted icon would only increase publicity like here in discover have 
three dot's in each line will give you the information that you can do 
something, but the focus is more on the line content than on the dotted icon.
  F5710557: Screenshot_20180213_230907.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: ngraham, #frameworks, michaelh

D10492: add 64px media icons for elisa

[Andreas Kainz]

andreask added a comment.


  cause I changed my workflow and start use arc but I wasn't interested into a 
review.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10492

To: andreask
Cc: ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

[Andreas Kainz]

andreask added a comment.


  F5710546: Screenshot_20180213_230517.png 

  
  sorry wrong screenshot
  left new
  right old

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

[Andreas Kainz]

andreask added a comment.


  F5710538: photo5773697838952328398.jpg 
  left after
  right before

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

[Andreas Kainz]

andreask added a comment.


  the old icon with 12 dots are a bit of a overkill now with three dot's 
compare to three lines.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: #frameworks, michaelh

D10494: update handle- icons for kirigami

[Andreas Kainz]

andreask added reviewers: alex-l, mart.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: #frameworks, michaelh

D10494: update handle- icons for kirigami

[Andreas Kainz]

andreask created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
andreask requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10494

AFFECTED FILES
  icons-dark/actions/22/handle-left.svg
  icons-dark/actions/22/handle-right.svg
  icons/actions/22/handle-left.svg
  icons/actions/22/handle-right.svg

To: andreask
Cc: #frameworks, michaelh

D10492: add 64px media icons for elisa

[Andreas Kainz]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:6800b88f1819: add 64px media icons for elisa (authored by 
andreask).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10492?vs=27100=27102

REVISION DETAIL
  https://phabricator.kde.org/D10492

AFFECTED FILES
  icons-dark/actions/64/media-album-cover.svg
  icons-dark/actions/64/media-album-track.svg
  icons-dark/actions/64/view-media-playlist.svg
  icons-dark/index.theme
  icons/actions/64/media-album-cover.svg
  icons/actions/64/media-album-track.svg
  icons/actions/64/view-media-playlist.svg
  icons/index.theme

To: andreask
Cc: #frameworks, michaelh

D10492: add 64px media icons for elisa

[Andreas Kainz]

andreask created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
andreask requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10492

AFFECTED FILES
  icons-dark/actions/64/media-album-cover.svg
  icons-dark/actions/64/media-album-track.svg
  icons-dark/actions/64/view-media-playlist.svg
  icons-dark/index.theme
  icons/actions/64/media-album-cover.svg
  icons/actions/64/media-album-track.svg
  icons/actions/64/view-media-playlist.svg
  icons/index.theme

To: andreask
Cc: #frameworks, michaelh

D10365: New icon for Elisa music player

[Andreas Kainz]

andreask added a comment.


  can we get it now to master?
  
  @paullesur is hopefully interested in other icon's too.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien
Cc: mmustac, mgallien, januz, astippich, andreask, andreaska, ltoscano, 
ngraham, #frameworks, jussiv, paullesur, michaelh, ognarb, kmf, progwolff

D10365: New icon for Elisa music player

[Andreas Kainz]

andreask added a comment.


  Elisa is a new music player app (yes another one) cassettes are old-school 
yes, but the benefit is that it look like an old (stable well developed) app in 
addition it's way more unique than other music player apps.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska
Cc: andreask, andreaska, ltoscano, ngraham, #frameworks, paullesur, michaelh, 
ognarb, januz, kmf, progwolff, mgallien

D10243: Improve visibility of disconnected Wi-Fi icons

[Andreas Kainz]

andreask added a comment.


  F5688471: wifi icon.png 
  top after
  
  - breeze(light)
  - breeze-dark
  
  bottom before
  
  - breeze(light)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icon

[Andreas Kainz]

andreask retitled this revision from "Disconnected wi-fi icons are almost 
invisible BUG:384018" to "Improve visibility of disconnected Wi-Fi icon".
andreask edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icons

[Andreas Kainz]

andreask retitled this revision from "Improve visibility of disconnected Wi-Fi 
icon" to "Improve visibility of disconnected Wi-Fi icons".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10243: Disconnected wi-fi icons are almost invisible BUG:384018

[Andreas Kainz]

andreask edited the summary of this revision.
andreask added reviewers: Plasma, Plasma Accessibility, sebas, ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10243: Disconnected wi-fi icons are almost invisible BUG:384018

[Andreas Kainz]

andreask created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
andreask requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10243

AFFECTED FILES
  src/desktoptheme/breeze/icons/network.svgz

To: andreask
Cc: #frameworks, michaelh, ngraham

D10212: New virtualbox icon

[Andreas Kainz]

andreaska accepted this revision.

REVISION DETAIL
  https://phabricator.kde.org/D10212

To: lshoravi, #breeze, ngraham, #vdg, andreaska
Cc: ltoscano, davidc, #frameworks, michaelh, ngraham

D10211: Suggestion for emacs icon

[Andreas Kainz]

andreaska accepted this revision.

REVISION DETAIL
  https://phabricator.kde.org/D10211

To: lshoravi, #breeze, #vdg, ngraham, andreaska
Cc: davidc, michaelh, abetts, ngraham, #frameworks

D9815: [KFileItem] Use "emblem-shared" for shared files

[Andreas Kainz]

andreaska accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9815

To: broulik, #frameworks, dfaure, andreask, andreaska
Cc: apol

D9815: [KFileItem] Use "emblem-shared" for shared files

[Andreas Kainz]

andreask added a comment.


  add an real emblem-shared icon cause the existing one was a symbolic one for 
gnome. should work now so +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9815

To: broulik, #frameworks, dfaure, andreask
Cc: apol

D7520: Fix icon of KStandardAction::MoveToTrash

[Andreas Kainz]

andreaska added a comment.


  +1

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D7520

To: elvisangelaccio, #frameworks
Cc: andreaska, broulik

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

[Andreas Kainz]

andreaska added a comment.


  works for the VDG really good job. well done. I like it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp
Cc: andreaska, gregormi, markg, alexeymin, #frameworks, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, spoorun, 
navarromorales, firef, andrebarros, emmanuelp

D8034: add overflow-menu icon

[Andreas Kainz]

andreaska accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8034

To: mart, andreask, andreaska
Cc: #frameworks

D4917: [Breeze Plasma Theme] Improve action-overlay icons

[Andreas Kainz]

andreaska added a comment.


  F2753390: action-overlays.svgz  only a 
draft (not finished, only that you can review something)
  F2753393: overlayScreenshot.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4917

To: broulik, #plasma, #vdg, andreask, alex-l, mart
Cc: andreaska, hein, plasma-devel, #frameworks, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Accepted] D4649: add a preview for the disk quota plasmoid

[Andreas Kainz]

andreaska accepted this revision.
andreaska added a reviewer: andreaska.
andreaska added a comment.
This revision is now accepted and ready to land.


  thanks look good.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4649

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, andreask, andreaska
Cc: andreaska, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Accepted] D4626: Renamed icons for encrypted and decripted folders

[Andreas Kainz]

andreaska accepted this revision.
andreaska added a comment.
This revision is now accepted and ready to land.


  good point. If you want to use this icons I'll make them for the other places 
size.

REPOSITORY
  R266 Breeze Icons

BRANCH
  ivan/rename-icons

REVISION DETAIL
  https://phabricator.kde.org/D4626

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, alex-l, andreaska
Cc: #frameworks

[Differential] [Commented On] D4495: Remove monochrome application icons

[Andreas Kainz]

andreaska added a comment.


  when was the last release for ktorrent?

REVISION DETAIL
  https://phabricator.kde.org/D4495

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: guoyunhe, #breeze
Cc: andreaska, #frameworks

[Differential] [Commented On] D4495: Remove monochrome application icons

[Andreas Kainz]

andreaska added a comment.


  please have a look at applications like amarok or ktorrent some icons are 
needed for this applications.

REVISION DETAIL
  https://phabricator.kde.org/D4495

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: guoyunhe, #breeze
Cc: andreaska, #frameworks

[Differential] [Commented On] D4253: redesign gwenview icon

[Andreas Kainz]

andreaska added a comment.


  Varlesh you do awesome icon work, but gwenview was changed some time ago so 
no icon redesign needed sorry.
  Please work on other icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4253

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreask, sandsmark, cfeck
Cc: adelsarto, alex-l, andreaska, #frameworks

[Differential] [Accepted] D4278: fix icons bittorrent-sync, codeblocks, darktable, ffmulticonverter

[Andreas Kainz]

andreaska accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4278

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, alex-l, andreaska, #breeze
Cc: alex-l, andreaska, #frameworks

[Differential] [Updated] D4278: fix icons bittorrent-sync, codeblocks, darktable, ffmulticonverter

[Andreas Kainz]

andreaska added a comment.


  +1 bittorent sync
  +1 darktable
  +1 ffmulticonverter
  
  codeblocks is better but the hammer had to much different colors I think

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4278

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, alex-l, #breeze, andreaska
Cc: alex-l, andreaska, #frameworks

[Differential] [Commented On] D4289: Add VLC tray icon

[Andreas Kainz]

andreaska added a comment.


  can you upload the svgz file cause I can't download it here.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4289

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: guoyunhe, #plasma:_design
Cc: andreaska, guoyunhe, #frameworks

[Differential] [Accepted] D4264: redesign android-file-transfer icon

[Andreas Kainz]

andreaska accepted this revision.
andreaska added a reviewer: andreaska.
andreaska added a comment.
This revision is now accepted and ready to land.


  In https://phabricator.kde.org/D4264#79949, @varlesh wrote:
  
  > @alex-l reverted gradient:
  >  F2164722: Снимок экрана от 2017-01-25 01-18-07.png 

  
  
  push this look good to me

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4264

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, andreask, #breeze, andreaska
Cc: andreaska, alex-l, #frameworks

[Differential] [Commented On] D4258: redesign gimp icon

[Andreas Kainz]

andreaska added a comment.


  How does it look without pencil?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4258

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, andreask, #breeze
Cc: andreaska, alex-l, #frameworks

[Differential] [Commented On] D4262: redesign android-studio icon

[Andreas Kainz]

andreaska added a comment.


  oh schit didn't no this. thanks but I thought only the circle is in the icon 
now nearly the full height and in your design only 2/3 of the icon height.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4262

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, andreask, #breeze
Cc: andreaska, alex-l, #frameworks

[Differential] [Commented On] D4264: redesign android-file-transfer icon

[Andreas Kainz]

andreaska added a comment.


  where is this icon used? is it an application or an mimetype?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4264

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, andreask, #breeze
Cc: andreaska, alex-l, #frameworks

[Differential] [Commented On] D4262: redesign android-studio icon

[Andreas Kainz]

andreaska added a comment.


  why is the circle now so small?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4262

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, andreask, #breeze
Cc: andreaska, alex-l, #frameworks

[Differential] [Accepted] D4259: fix alienarena icon

[Andreas Kainz]

andreaska accepted this revision.
andreaska added a reviewer: andreaska.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4259

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, andreask, #breeze, andreaska
Cc: alex-l, #frameworks

[Differential] [Accepted] D4261: redesign atom icon

[Andreas Kainz]

andreaska accepted this revision.
andreaska added a reviewer: andreaska.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4261

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, andreask, #breeze, andreaska
Cc: alex-l, #frameworks

[Differential] [Accepted] D4260: fix bitcoin128 icon

[Andreas Kainz]

andreaska accepted this revision.
andreaska added a reviewer: andreaska.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4260

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, andreask, #breeze, andreaska
Cc: alex-l, #frameworks

[Differential] [Commented On] D4253: redesign gwenview icon

[Andreas Kainz]

andreaska added a comment.


  I also think that we shouldn't update the icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4253

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreask
Cc: alex-l, andreaska, #frameworks

[Differential] [Accepted] D4267: redesign bluefish icon

[Andreas Kainz]

andreaska accepted this revision.
andreaska added a reviewer: andreaska.
andreaska added a comment.
This revision is now accepted and ready to land.


  ship it

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4267

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, andreask, #breeze, andreaska
Cc: andreaska, alex-l, #frameworks

[Differential] [Commented On] D4253: redesign gwenview icon

[Andreas Kainz]

andreaska added a comment.


  first of all, thanks for starting the discussion I think also that the 
gwenview icon could get an update, but I miss something in the update in 
addition the dark eye background look to hard.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4253

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreask
Cc: andreaska, #frameworks

[Differential] [Accepted] D4252: fix brackets icon

[Andreas Kainz]

andreaska accepted this revision.
andreaska added a reviewer: andreaska.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4252

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreaska
Cc: guoyunhe, #frameworks

[Differential] [Commented On] D4252: fix brackets icon

[Andreas Kainz]

andreaska added a comment.


  I submitt the icon thanks

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4252

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreaska
Cc: guoyunhe, #frameworks

[Differential] [Accepted] D4251: Redesign aptana icon

[Andreas Kainz]

andreaska accepted this revision.
andreaska added a reviewer: andreaska.
andreaska added a comment.
This revision is now accepted and ready to land.


  submitted

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4251

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreaska
Cc: andreaska, #frameworks

Re: Review Request 129106: Give a different name to Breeze Dark icon theme

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129106/#review99837
---



hi

thanks for the fix but I already fixed it yesterday, please have a look if it 
now work propper. the problem is that it is to late for the 5.27 release.

- Andreas Kainz


On Okt. 7, 2016, 12:16 vorm., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129106/
> ---
> 
> (Updated Okt. 7, 2016, 12:16 vorm.)
> 
> 
> Review request for KDE Frameworks, Alessandro Longo, Andreas Kainz, and 
> Andreas Kainz.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Otherwise we get the item listed twice with a different icon.
> 
> 
> Diffs
> -
> 
>   icons-dark/index.theme c319289 
> 
> Diff: https://git.reviewboard.kde.org/r/129106/diff/
> 
> 
> Testing
> ---
> 
> It's now shown properly both on the icons kcm and kde-gtk-config
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

Re: Review Request 128680: [KCharSelect] Add ToolButton for disabling characters not available in selected font

[Andreas Kainz]

> On Sept. 4, 2016, 2:34 vorm., Christoph Feck wrote:
> > Andreas, any idea which icon the action could use?
> 
> Andreas Kainz wrote:
> I would use visibility and hint to show/hide the font's that are not 
> available in the selected font. will the font change to "not selected" grayed 
> out when you show all characters also the ones that aren't available?
> 
> Christoph Feck wrote:
> "visibility" and "hint" is the same icon, but one of them crossed-out. If 
> I use both of them, it is confusing, because the tool button itself has a 
> selected state (sunken frame and selected background).
> 
> So I see two options:
> 1) use the "hint" icon, and make the button unselected by default. 
> Selecting it, the unavailable characters are then grayed out.
> 2) use the "visibility" icon, and make the button selected by default.
> Unselecting it, the unavailable characters are then grayed out.
> 
> Which would you prefer? The code currently uses the unselected button for 
> the default (do not gray-out unavailable characters) but I can reverse it.
> 
> Regarding your question, I have difficulties to parse it. Let me try to 
> answer from what I understood: If font-merging is enabled, but none of the 
> installed fonts have glyphs for a specific character, then this character is 
> rendered as an rectangle box. The character cell is not disabled, so you will 
> be able to select the character (e.g. to copy/paste it), even if you have no 
> font with this character.
> 
> Heiko Tietze wrote:
> Third option is to have a less obtrusive visualization (going back to 
> your first proposal) that makes the toggle button obsolete. But I have no 
> idea how to do so since graying out is the opposite of unobtrusive. It 
> depends heavily on the workflow meaning whether or not users should be able 
> to deal with those characters at all.
> 
> Andreas Kainz wrote:
> personally I wouldn't grayed out by default cause I want to have this 
> symbol and I don't care if this is available or not.
> 
> on the other hand I think your app is really nice and usefull but you 
> need some time to understand the different drop downs, ... so I didn't know 
> your initial proposal. I will update some mockup where there is written all 
> fonts and if someone select a font (arial) you see the not available chars 
> grayed out as in your app.

https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/kcharselect.png


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128680/#review98855
---


On Sept. 1, 2016, 4:45 nachm., Christoph Feck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128680/
> ---
> 
> (Updated Sept. 1, 2016, 4:45 nachm.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Andreas Kainz.
> 
> 
> Bugs: 97420
> https://bugs.kde.org/show_bug.cgi?id=97420
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Adds a toolbutton to the right of the font combobox to control the "font 
> merging" property of QFont. When selected, characters which are not available 
> in the font are disabled.
> 
> Seeking feedback about:
> - placement of the button
> - used icon (currently "format-text-strikethrough"; it shows an S character 
> which could stand for "substitution")
> - action name and tooltip (see line 477 and 479)
> - and code changes ;)
> 
> I was unsure if the toolbutton could have a popup menu showing three options:
> 1) show characters from all fonts
> 2) disable characters not available in font
> 3) hide characters not available in font
> 
> but I did not implement it, because it felt odd not being able to see _which_ 
> characters are not available in the font.
> 
> 
> Diffs
> -
> 
>   src/kcharselect.cpp 30ddd34 
>   src/kcharselect_p.h db0259c 
> 
> Diff: https://git.reviewboard.kde.org/r/128680/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Character table with font substitution (default)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/7220dddb-ca1b-42a2-966c-791925156baf__snapshot1.png
> Character table with dimming substituted characters
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/67c02866-b12c-4080-b6a4-22e29006448b__snapshot2.png
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

Re: Review Request 128680: [KCharSelect] Add ToolButton for disabling characters not available in selected font

[Andreas Kainz]

> On Sept. 4, 2016, 2:34 vorm., Christoph Feck wrote:
> > Andreas, any idea which icon the action could use?
> 
> Andreas Kainz wrote:
> I would use visibility and hint to show/hide the font's that are not 
> available in the selected font. will the font change to "not selected" grayed 
> out when you show all characters also the ones that aren't available?
> 
> Christoph Feck wrote:
> "visibility" and "hint" is the same icon, but one of them crossed-out. If 
> I use both of them, it is confusing, because the tool button itself has a 
> selected state (sunken frame and selected background).
> 
> So I see two options:
> 1) use the "hint" icon, and make the button unselected by default. 
> Selecting it, the unavailable characters are then grayed out.
> 2) use the "visibility" icon, and make the button selected by default.
> Unselecting it, the unavailable characters are then grayed out.
> 
> Which would you prefer? The code currently uses the unselected button for 
> the default (do not gray-out unavailable characters) but I can reverse it.
> 
> Regarding your question, I have difficulties to parse it. Let me try to 
> answer from what I understood: If font-merging is enabled, but none of the 
> installed fonts have glyphs for a specific character, then this character is 
> rendered as an rectangle box. The character cell is not disabled, so you will 
> be able to select the character (e.g. to copy/paste it), even if you have no 
> font with this character.
> 
> Heiko Tietze wrote:
> Third option is to have a less obtrusive visualization (going back to 
> your first proposal) that makes the toggle button obsolete. But I have no 
> idea how to do so since graying out is the opposite of unobtrusive. It 
> depends heavily on the workflow meaning whether or not users should be able 
> to deal with those characters at all.

personally I wouldn't grayed out by default cause I want to have this symbol 
and I don't care if this is available or not.

on the other hand I think your app is really nice and usefull but you need some 
time to understand the different drop downs, ... so I didn't know your initial 
proposal. I will update some mockup where there is written all fonts and if 
someone select a font (arial) you see the not available chars grayed out as in 
your app.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128680/#review98855
---


On Sept. 1, 2016, 4:45 nachm., Christoph Feck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128680/
> ---
> 
> (Updated Sept. 1, 2016, 4:45 nachm.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Andreas Kainz.
> 
> 
> Bugs: 97420
> https://bugs.kde.org/show_bug.cgi?id=97420
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Adds a toolbutton to the right of the font combobox to control the "font 
> merging" property of QFont. When selected, characters which are not available 
> in the font are disabled.
> 
> Seeking feedback about:
> - placement of the button
> - used icon (currently "format-text-strikethrough"; it shows an S character 
> which could stand for "substitution")
> - action name and tooltip (see line 477 and 479)
> - and code changes ;)
> 
> I was unsure if the toolbutton could have a popup menu showing three options:
> 1) show characters from all fonts
> 2) disable characters not available in font
> 3) hide characters not available in font
> 
> but I did not implement it, because it felt odd not being able to see _which_ 
> characters are not available in the font.
> 
> 
> Diffs
> -
> 
>   src/kcharselect.cpp 30ddd34 
>   src/kcharselect_p.h db0259c 
> 
> Diff: https://git.reviewboard.kde.org/r/128680/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Character table with font substitution (default)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/7220dddb-ca1b-42a2-966c-791925156baf__snapshot1.png
> Character table with dimming substituted characters
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/67c02866-b12c-4080-b6a4-22e29006448b__snapshot2.png
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

Re: Review Request 128680: [KCharSelect] Add ToolButton for disabling characters not available in selected font

[Andreas Kainz]

> On Sept. 4, 2016, 2:34 vorm., Christoph Feck wrote:
> > Andreas, any idea which icon the action could use?

I would use visibility and hint to show/hide the font's that are not available 
in the selected font. will the font change to "not selected" grayed out when 
you show all characters also the ones that aren't available?


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128680/#review98855
---


On Sept. 1, 2016, 4:45 nachm., Christoph Feck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128680/
> ---
> 
> (Updated Sept. 1, 2016, 4:45 nachm.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Andreas Kainz.
> 
> 
> Bugs: 97420
> https://bugs.kde.org/show_bug.cgi?id=97420
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Adds a toolbutton to the right of the font combobox to control the "font 
> merging" property of QFont. When selected, characters which are not available 
> in the font are disabled.
> 
> Seeking feedback about:
> - placement of the button
> - used icon (currently "format-text-strikethrough"; it shows an S character 
> which could stand for "substitution")
> - action name and tooltip (see line 477 and 479)
> - and code changes ;)
> 
> I was unsure if the toolbutton could have a popup menu showing three options:
> 1) show characters from all fonts
> 2) disable characters not available in font
> 3) hide characters not available in font
> 
> but I did not implement it, because it felt odd not being able to see _which_ 
> characters are not available in the font.
> 
> 
> Diffs
> -
> 
>   src/kcharselect.cpp 30ddd34 
>   src/kcharselect_p.h db0259c 
> 
> Diff: https://git.reviewboard.kde.org/r/128680/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Character table with font substitution (default)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/7220dddb-ca1b-42a2-966c-791925156baf__snapshot1.png
> Character table with dimming substituted characters
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/67c02866-b12c-4080-b6a4-22e29006448b__snapshot2.png
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

Re: Review Request 128694: Fix all edit-clear-location-ltr icons

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128694/#review98835
---



I submit the right icons

thanks for reporting (and fix) the bug.

- Andreas Kainz


On Aug. 15, 2016, 1:57 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128694/
> ---
> 
> (Updated Aug. 15, 2016, 1:57 p.m.)
> 
> 
> Review request for KDE Frameworks and Andreas Kainz.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> icons with -ltr suffix should have the icon going from left to right and
> are used (counterintuitively) in situations where the text layout is
> right to left, if the normal icon points rtl.
> 
> This patch changes the icons from being a symlink to the same icon to being a 
> copy mirrored in inkscape.
> 
> 
> Diffs
> -
> 
>   icons/actions/16/edit-clear-locationbar-ltr.svg 
> 00150527ac1bc368f979a53de4709c146f657c82 
>   icons/actions/16/edit-clear-locationbar-ltr.svg PRE-CREATION 
>   icons/actions/22/edit-clear-locationbar-ltr.svg 
> 00150527ac1bc368f979a53de4709c146f657c82 
>   icons/actions/22/edit-clear-locationbar-ltr.svg PRE-CREATION 
>   icons/actions/24/edit-clear-locationbar-ltr.svg 
> 00150527ac1bc368f979a53de4709c146f657c82 
>   icons/actions/24/edit-clear-locationbar-ltr.svg PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128694/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Review Request 128694: Fix all edit-clear-location-ltr icons

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128694/#review98836
---



the patch isn't needed any more

- Andreas Kainz


On Aug. 15, 2016, 1:57 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128694/
> ---
> 
> (Updated Aug. 15, 2016, 1:57 p.m.)
> 
> 
> Review request for KDE Frameworks and Andreas Kainz.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> icons with -ltr suffix should have the icon going from left to right and
> are used (counterintuitively) in situations where the text layout is
> right to left, if the normal icon points rtl.
> 
> This patch changes the icons from being a symlink to the same icon to being a 
> copy mirrored in inkscape.
> 
> 
> Diffs
> -
> 
>   icons/actions/16/edit-clear-locationbar-ltr.svg 
> 00150527ac1bc368f979a53de4709c146f657c82 
>   icons/actions/16/edit-clear-locationbar-ltr.svg PRE-CREATION 
>   icons/actions/22/edit-clear-locationbar-ltr.svg 
> 00150527ac1bc368f979a53de4709c146f657c82 
>   icons/actions/22/edit-clear-locationbar-ltr.svg PRE-CREATION 
>   icons/actions/24/edit-clear-locationbar-ltr.svg 
> 00150527ac1bc368f979a53de4709c146f657c82 
>   icons/actions/24/edit-clear-locationbar-ltr.svg PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128694/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Review Request 126738: Remove external dependencies from svgs

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126738/#review96341
---



I made a cleanup off all breeze icons so it should now work without troubles if 
you find some please let me know. otherwise you can close the request.

thanks
Andreas

- Andreas Kainz


On Jan. 14, 2016, 1:18 vorm., Dirk Hohndel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126738/
> ---
> 
> (Updated Jan. 14, 2016, 1:18 vorm.)
> 
> 
> Review request for KDE Frameworks, Andreas Kainz and Uri Herrera.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> I don't know what I'm doing here. But when using the icons in a QML app I
> get a lot of warnings like this one:
> 
> Could not resolve property : linearGradient4548
> 
> Running the svgs through inkscape and using the "clean up document"
> function results in this commit (and the warnings are gone).
> 
> This may not be the right thing to do but it would be nice to get rid of
> all these warnings when using the icons.
> 
> Signed-off-by: Dirk Hohndel <d...@hohndel.org>
> 
> 
> Diffs
> -
> 
>   icons/actions/24/dialog-cancel.svg a2b022a9dc7b7cf97e4c3391b87e7800355d2dcb 
>   icons/actions/24/distribute-horizontal-x.svg 
> 262fcaca937cb72d8393fd5dff9c59651367fe36 
>   icons/actions/24/document-edit.svg afb37ca9624b37d6ac5aa9c94f1b2cef620faff6 
>   icons/actions/24/document-save.svg cee0a3521deb7eb1fcb79266afaa8951f4984b20 
> 
> Diff: https://git.reviewboard.kde.org/r/126738/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dirk Hohndel
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128065: move glass theme to kde-look.

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128065/#review96339
---


Ship it!




Ship It!

- Andreas Kainz


On Mai 31, 2016, 8:33 vorm., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128065/
> ---
> 
> (Updated Mai 31, 2016, 8:33 vorm.)
> 
> 
> Review request for KDE Frameworks and Andreas Kainz.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> ---
> 
> we don't need 300 default themes
> 
> http://kde-look.org/content/show.php/Glass?content=176110
> 
> 
> Diffs
> -
> 
>   themes/CMakeLists.txt b48592f78b7a3bebb6e8a7394d0dbf2458fefb2c 
>   themes/Glass/angry.png 2e575a5ef1fd3fd801df0674454e48950be8187f 
>   themes/Glass/bat.png feddc4e24fee018033a0010ecbaf991d4d5a787a 
>   themes/Glass/beer.png e1afd340153b5fe2a6d0294edb9c01525a8a3b3e 
>   themes/Glass/biggrin.png 172cbf99f83354a6ef4b9c8f79fcee37632ac1d6 
>   themes/Glass/cake.png 25849fe7425a14bdd0001bbcbdcd59fbaa73d676 
>   themes/Glass/camera.png 7637807091d7a94dc9a65efac99388071707560a 
>   themes/Glass/cat.png 9c6f407f85480c619725135a8bb147290e447530 
>   themes/Glass/clock.png 14d95ee5aacd7b65b2fd24a99d3221c46d5194b0 
>   themes/Glass/cocktail.png 2740dfc4d2f8164478401530cec91563dddc5c1e 
>   themes/Glass/confused.png eba9ee0157f78d76ac66e4119876861a38827509 
>   themes/Glass/cry.png 64d83bb73041a24c2ab8483835041a4715b51310 
>   themes/Glass/cup.png 34adcb89761a279e2c856f1fd6cf0918e6aff2b8 
>   themes/Glass/dog.png 7ab4a3cf63d24ef04dd215dc1882265955674e4a 
>   themes/Glass/email.png 9b4f3c3b24f3bd92aa6b8c367d4e66efa08a0296 
>   themes/Glass/embarassed.png 8eb0c4774b441b3568233f3fd2732aacc297d0b3 
>   themes/Glass/emoticons.xml 92a1af51f0d8f7f922d38ec05c3e3afea6a2d7f7 
>   themes/Glass/film.png 7b6ee1af4a92b4bc3d57412ca65f8f2c55460ed0 
>   themes/Glass/foot_in_mouth.png c50d95b4e48c395857760ae9a103e07a22f49ca4 
>   themes/Glass/innocent.png d6aee04bb844bf36f7c5e03c56933b2ad39c5baf 
>   themes/Glass/kiss.png c6028a5d9bf64b8d3c31f15542e4dbd17234d08c 
>   themes/Glass/lightbulb.png 65371d930b582d5bdfbe3de0aa848dc07943ade5 
>   themes/Glass/love.png 8bf28061e5466280341fdae3d9ec6ff40d4b517b 
>   themes/Glass/note.png 144fe614ac4e678555c166c5c7bc8bc4b54631d4 
>   themes/Glass/oh.png 5eb0455e83b726ce2e175f029c25b1fc70b649c0 
>   themes/Glass/omg.png f3802716ee8f0487983a671cdb9e9ce4568576e7 
>   themes/Glass/phone.png 448aeb4cf4053de47c8ae16563df693680dd3d46 
>   themes/Glass/present.png add50e216734a40be3a20c798dd24d8e81e2843a 
>   themes/Glass/rose.png 2f6b2783182adc489ab650b3c5bd1908d4f1acce 
>   themes/Glass/sad.png b94892813dad408f7b13d9d747a9d154ca1a6f2c 
>   themes/Glass/shade.png df8141de75c7548e56e155d3df86d7c8019fea9e 
>   themes/Glass/sleep.png 406b4ad40f41959c549f410aa09daad512f05cd2 
>   themes/Glass/smile.png 63bb98d5c08396f4cdba81c61d26fa7b9862af0e 
>   themes/Glass/star.png b08ba65dcb556a0867bbbd626be7d28602d727c2 
>   themes/Glass/teeth.png b2b08341f31c4b03fb17bf327da1de36aa7feaf3 
>   themes/Glass/thumbs_down.png 2e0e59fd313a1f89eea26ceb093be74e8f85d928 
>   themes/Glass/thumbs_up.png f35ec7d0632416dd92e68738b52bf7c8d8a86b11 
>   themes/Glass/tongue.png ba6cbbdbeb4bf8dc0fdf32353166f86bb8fdc720 
>   themes/Glass/undecided.png 07502bc59d22d44a3a29139c076e7723e300bae4 
>   themes/Glass/unhappy.png 58a80dc6ae4a217d958b2eded36e5998aa5d20d8 
>   themes/Glass/unlove.png fef1db952524351f0e21d3029948746bb6819f4f 
>   themes/Glass/wilted_rose.png b00ca9a15086d64307fa18783959f410cdfbbb04 
>   themes/Glass/wink.png 166aef1e5675dabd41ce1a868c9f1d53cc494cc2 
> 
> Diff: https://git.reviewboard.kde.org/r/128065/diff/
> 
> 
> Testing
> ---
> 
> builds and installs
> 
> version from kde-look also installs via knewstuff
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127876/#review95312
---


Ship it!




I can't review the code but this is one of the best features in the past 2 years
+1 from the vdg

- Andreas Kainz


On Mai 9, 2016, 3:32 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127876/
> ---
> 
> (Updated Mai 9, 2016, 3:32 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> with the stylesheet based recoloring for icons, it is possible to make 
> selected icons the same color as the selected text from the palette.
> with the breeze icons style this makes the selected item more readable and 
> more in line with the style.
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyle.cpp 403771c 
> 
> Diff: https://git.reviewboard.kde.org/r/127876/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> menu.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/cfbb4571-ed40-411e-ad89-453d29fa2610__menu.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127878: use the "selected" icon mode in file open dialog sidebar

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127878/#review95314
---


Ship it!




I can't review the code but this is one of the best features in the past 2 years

- Andreas Kainz


On Mai 9, 2016, 4:24 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127878/
> ---
> 
> (Updated Mai 9, 2016, 4:24 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> since now kiconloader can color the icons in the sidebar, by using the 
> "selected" icon mode, when the breeze icon theme is used the icon of the 
> current sidebar item will be of the same color of selected text (white-ish by 
> default), is more in line with breeze style and the monochrome icons become 
> more readable
> 
> 
> Diffs
> -
> 
>   src/filewidgets/kfileplacesview.cpp 03074e0 
> 
> Diff: https://git.reviewboard.kde.org/r/127878/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> menu3.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/41f52d86-6fc5-4799-bd9e-18d17dc5a65a__menu3.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127875: Selected state concept for icons

[Andreas Kainz]

> On Mai 9, 2016, 10:21 nachm., Andreas Kainz wrote:
> > Ship It!

I can't review the code but this is one of the best features in the past 2 years


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127875/#review95309
---


On Mai 9, 2016, 3:26 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127875/
> ---
> 
> (Updated Mai 9, 2016, 3:26 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> QIcon has a Selected state that wasn't mapped to KIcon, use it and in case 
> for svg based icons that take colors from the palette take the 
> highlightedText color from the palette to color the icon instead of the text 
> color, making it possible for styles to have white icons and white text in 
> selected menu items (need explicit support from the style, patches in breeze 
> and the like coming)
> 
> 
> Diffs
> -
> 
>   src/kiconengine.cpp 7c72ade 
>   src/kiconloader.h cf2f58a 
>   src/kiconloader.cpp b3c7166 
> 
> Diff: https://git.reviewboard.kde.org/r/127875/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> menu.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/0fb9a44c-8db4-4a10-91e7-1a6a36e41f62__menu.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127875: Selected state concept for icons

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127875/#review95309
---


Ship it!




Ship It!

- Andreas Kainz


On Mai 9, 2016, 3:26 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127875/
> ---
> 
> (Updated Mai 9, 2016, 3:26 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> QIcon has a Selected state that wasn't mapped to KIcon, use it and in case 
> for svg based icons that take colors from the palette take the 
> highlightedText color from the palette to color the icon instead of the text 
> color, making it possible for styles to have white icons and white text in 
> selected menu items (need explicit support from the style, patches in breeze 
> and the like coming)
> 
> 
> Diffs
> -
> 
>   src/kiconengine.cpp 7c72ade 
>   src/kiconloader.h cf2f58a 
>   src/kiconloader.cpp b3c7166 
> 
> Diff: https://git.reviewboard.kde.org/r/127875/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> menu.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/0fb9a44c-8db4-4a10-91e7-1a6a36e41f62__menu.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127632: Prioritize correct extension per theme

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127632/#review94875
---



Sorry someone add my but I can't follow the discussion. I don't know what this 
is doing. sorry.

- Andreas Kainz


On April 26, 2016, 7:12 nachm., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127632/
> ---
> 
> (Updated April 26, 2016, 7:12 nachm.)
> 
> 
> Review request for KDE Frameworks, Andreas Kainz and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> Usually themes will have 1 kind of extension (2 tops) it doesn't make sense 
> to bindly use an extensions vector that is statically defined.
> 
> Prioritizes the extensions that work, so it will find the icons sooner.
> 
> 
> Diffs
> -
> 
>   src/kiconengine.h 5b9badb 
>   src/kiconloader.cpp 37528ad 
>   src/kicontheme.h 3190665 
>   src/kicontheme.cpp e7e003b 
> 
> Diff: https://git.reviewboard.kde.org/r/127632/diff/
> 
> 
> Testing
> ---
> 
> Builds and tests still pass.
> Also reducess faulty disk accesses to its 45%. Note that by this metric, it's 
> almost as good as the RR #127236, but with a much smaller memory impact, 
> since we're not caching all the icon names (which was specially bad as it was 
> per-process).
> ```
> $ strace kwrite |& grep ENOENT | wc -l
> 4699
> $ strace kwrite |& grep ENOENT | wc -l
> 2119
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

[Andreas Kainz]

> On Feb. 29, 2016, 10:23 p.m., Andreas Kainz wrote:
> > hi, heiko fill a bug report cause you cant see the x icon 
> > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that 
> > knewpassworddialog use an icon cause there is no x icon. is this icon used 
> > from KNewPasswordDialog? can it be colored in white #f2f2f2. 
> > 
> > thanks for the feedback. maybe you can answer on the bug report.
> 
> Elvis Angelaccio wrote:
> Hi. The problem is the X icon/button in this screenshot: 
> https://git.reviewboard.kde.org/r/126523/file/2643/
> 
> Andreas Kainz wrote:
> yes is it really an icon?
> 
> Elvis Angelaccio wrote:
> Mmm you're right. Doesn't look like an icon from Breeze:
> 
> 
> `closeAction->setIcon(q->style()->standardIcon(QStyle::SP_DialogCloseButton));`
>  (from kmessagewidget.cpp)
> 
> So it's an icon coming from the `QStyle`. I guess you should ask some 
> Plasma guy to have a look...
> 
> Heiko Tietze wrote:
> What else if not an icon? Anyway it was removed from the dialog - and 
> probably from all message panels as well.

good to know. not every icon is an icon some are hard coded some are drawn by 
application (QStyle), ... so can you close the bug report Heiko. David say no 
changes before bugs are solved and I'd like to make some changes.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126523/#review92946
---


On Feb. 1, 2016, 6:47 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126523/
> ---
> 
> (Updated Feb. 1, 2016, 6:47 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability, Kai Uwe Broulik, Christoph 
> Feck, and David Faure.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Currently a KNewPasswordDialog makes use of a KTitleWidget to display 
> messages to the user about the password status (e.g. "password too short", 
> etc.). This looks out of place, and so does the associated icon (see 
> screenshots in RR 125619: https://git.reviewboard.kde.org/r/125619/ )
> 
> This patch replaces the KTitleWidget with a KMessageWidget. I also 
> "downgraded" some of the previous "error" red icons to a 
> `KMessageWidget::Warning` type (the orange one in the screenshots), because 
> those kind of messages may be displayed before the user even started typing 
> something as password.
> 
> 
> Diffs
> -
> 
>   src/knewpassworddialog.cpp 1d7ca33ac010a2a1d0971a152d0bef23f78c414d 
>   src/knewpassworddialog.ui 2b492d2a2984296105959d366a1d5306c80af54f 
> 
> Diff: https://git.reviewboard.kde.org/r/126523/diff/
> 
> 
> Testing
> ---
> 
> The KMessageWidgets behaves exactly like the KTitleWidget before: initially 
> is hidden, then is displayed as soon as the user interacts with the password 
> fields.
> 
> 
> File Attachments
> 
> 
> pwd-dialog-1.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/f4870422-d064-4da9-b216-056fe5bec665__pwd-dialog-1.png
> pwd-dialog-2.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3d8b6c2c-6717-4608-b61c-18ef9b224706__pwd-dialog-2.png
> pwd-dialog-3.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3a71ff56-f540-405a-9f3e-868e8d652687__pwd-dialog-3.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

[Andreas Kainz]

> On Feb. 29, 2016, 10:23 p.m., Andreas Kainz wrote:
> > hi, heiko fill a bug report cause you cant see the x icon 
> > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that 
> > knewpassworddialog use an icon cause there is no x icon. is this icon used 
> > from KNewPasswordDialog? can it be colored in white #f2f2f2. 
> > 
> > thanks for the feedback. maybe you can answer on the bug report.
> 
> Elvis Angelaccio wrote:
> Hi. The problem is the X icon/button in this screenshot: 
> https://git.reviewboard.kde.org/r/126523/file/2643/

yes is it really an icon?


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126523/#review92946
---


On Feb. 1, 2016, 6:47 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126523/
> ---
> 
> (Updated Feb. 1, 2016, 6:47 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability, Kai Uwe Broulik, Christoph 
> Feck, and David Faure.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Currently a KNewPasswordDialog makes use of a KTitleWidget to display 
> messages to the user about the password status (e.g. "password too short", 
> etc.). This looks out of place, and so does the associated icon (see 
> screenshots in RR 125619: https://git.reviewboard.kde.org/r/125619/ )
> 
> This patch replaces the KTitleWidget with a KMessageWidget. I also 
> "downgraded" some of the previous "error" red icons to a 
> `KMessageWidget::Warning` type (the orange one in the screenshots), because 
> those kind of messages may be displayed before the user even started typing 
> something as password.
> 
> 
> Diffs
> -
> 
>   src/knewpassworddialog.cpp 1d7ca33ac010a2a1d0971a152d0bef23f78c414d 
>   src/knewpassworddialog.ui 2b492d2a2984296105959d366a1d5306c80af54f 
> 
> Diff: https://git.reviewboard.kde.org/r/126523/diff/
> 
> 
> Testing
> ---
> 
> The KMessageWidgets behaves exactly like the KTitleWidget before: initially 
> is hidden, then is displayed as soon as the user interacts with the password 
> fields.
> 
> 
> File Attachments
> 
> 
> pwd-dialog-1.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/f4870422-d064-4da9-b216-056fe5bec665__pwd-dialog-1.png
> pwd-dialog-2.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3d8b6c2c-6717-4608-b61c-18ef9b224706__pwd-dialog-2.png
> pwd-dialog-3.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3a71ff56-f540-405a-9f3e-868e8d652687__pwd-dialog-3.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126523/#review92946
---



hi, heiko fill a bug report cause you cant see the x icon 
https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that 
knewpassworddialog use an icon cause there is no x icon. is this icon used from 
KNewPasswordDialog? can it be colored in white #f2f2f2. 

thanks for the feedback. maybe you can answer on the bug report.

- Andreas Kainz


On Feb. 1, 2016, 6:47 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126523/
> ---
> 
> (Updated Feb. 1, 2016, 6:47 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability, Kai Uwe Broulik, Christoph 
> Feck, and David Faure.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Currently a KNewPasswordDialog makes use of a KTitleWidget to display 
> messages to the user about the password status (e.g. "password too short", 
> etc.). This looks out of place, and so does the associated icon (see 
> screenshots in RR 125619: https://git.reviewboard.kde.org/r/125619/ )
> 
> This patch replaces the KTitleWidget with a KMessageWidget. I also 
> "downgraded" some of the previous "error" red icons to a 
> `KMessageWidget::Warning` type (the orange one in the screenshots), because 
> those kind of messages may be displayed before the user even started typing 
> something as password.
> 
> 
> Diffs
> -
> 
>   src/knewpassworddialog.cpp 1d7ca33ac010a2a1d0971a152d0bef23f78c414d 
>   src/knewpassworddialog.ui 2b492d2a2984296105959d366a1d5306c80af54f 
> 
> Diff: https://git.reviewboard.kde.org/r/126523/diff/
> 
> 
> Testing
> ---
> 
> The KMessageWidgets behaves exactly like the KTitleWidget before: initially 
> is hidden, then is displayed as soon as the user interacts with the password 
> fields.
> 
> 
> File Attachments
> 
> 
> pwd-dialog-1.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/f4870422-d064-4da9-b216-056fe5bec665__pwd-dialog-1.png
> pwd-dialog-2.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3d8b6c2c-6717-4608-b61c-18ef9b224706__pwd-dialog-2.png
> pwd-dialog-3.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3a71ff56-f540-405a-9f3e-868e8d652687__pwd-dialog-3.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126740: Add a script for optimizing svgs

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review92666
---


Ship it!




Ship It!

- Andreas Kainz


On Feb. 16, 2016, 2:02 vorm., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Feb. 16, 2016, 2:02 vorm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize.svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126949: Remove Air and Oxygen themes

[andreas kainz]

> On Feb. 1, 2016, 8:12 nachm., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.
> 
> David Edmundson wrote:
> Andreas, note the oxygen widget style and plasma theme are different 
> things. 
> The Oxygen plasma style is this theme: 
> https://www.kde.org/announcements/4.0/screenshots/desktop.jpg
> 
> the widget style isn't being touched.
> 
> andreas kainz wrote:
> can we add ALL oxygen stuff in one "unmaintained" area?
> 
> Hugo Pereira Da Costa wrote:
> Wait wait, neither oxygen widget style nor window decoration are 
> unmaintained. (nor broken as far as I know)
> They are in "maintenance" mode on the contrary. Meaning: they are "done", 
> there won't be any new feature, but bugs get fixed when reported. 
> Please 
> - dont move them anywhere else,
> - dont move broken, nor truely unmaintained things in there.
> This is not a trash can :)
> 
> Thx,
> 
> Hugo
> 
> Kai Uwe Broulik wrote:
> Yes, Hugo is doing a fine job of maintaining Oxygen stuff and 
> cherry-picking fixes from Breeze. :) It's really just the Plasma theme that 
> is utterly broken and unmaintained.

I'v never done a plasma theme but I saw how the breeze theme get broken and how 
it was fixed again. As Hugo maintaine oxygen stuff and I maintain oxygen icon 
stuff, it would be good to have the plasma theme also available. I can offer to 
maintain the oxygen plasma theme (one of them).


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 

Re: Review Request 126949: Remove Air and Oxygen themes

[andreas kainz]

> On Feb. 2, 2016, 9:17 vorm., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.

There are missing icons from the oxygen plasma theme and in the future also in 
oxygen-icons. I will work on this but without this the theme is not that broken 
as you show in the screenshot when you use everything from oxygen (plasma 
theme, icons, window decoration, ...) 
https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 7:30 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   src/desktoptheme/air/widgets/clock.svgz 3839dac 
>   src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

[andreas kainz]

> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.
> 
> David Edmundson wrote:
> Andreas, note the oxygen widget style and plasma theme are different 
> things. 
> The Oxygen plasma style is this theme: 
> https://www.kde.org/announcements/4.0/screenshots/desktop.jpg
> 
> the widget style isn't being touched.

can we add ALL oxygen stuff in one "unmaintained" area?


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/prefer

Re: Review Request 126949: Remove Air and Oxygen themes

[andreas kainz]

> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.

in addition a lot of dev's make screenshots with oxygen so there is an user 
group for oxygen.


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.sv

Re: Review Request 126949: Remove Air and Oxygen themes

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---



Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
time I need the plasma oxygen theme too to give the user the one single click 
feature (look & feel package). Is there an space where you can move 
"unmaintained" stuff and the distros can choose what they want to ship. now all 
distros ship oxygen.

I love breeze but oxygen is also really sexy in addition a lot of uers work 
with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 LTS. It 
would be bad to support oxygen for an additional LTS cycle, but for the switch 
it would be nice to give the user the posibility for an soft switch.

- andreas kainz


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   sr

Re: Review Request 126949: Remove Air and Oxygen themes

[andreas kainz]

> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.

ok. that would fit for me. since now we have not that much look and feel 
packages most distros use it for there look and feel stuff and than breeze and 
breeze-dark for people how don't like monochrome (there are a lot) is oxygen. 
it would be nice to have more packages there available so move the oxygen stuff 
in an spacific area is fine for me but don't move them to kde-look cause than 
oxygen is more broken than now and no one can fix it any more.

thanks Kai


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/di

Re: Review Request 126738: Remove external dependencies from svgs

[andreas kainz]

> On Jan. 14, 2016, 4:51 vorm., Dirk Hohndel wrote:
> > this will need to be done for dozens more SVGs - I sent the four that I 
> > needed for my app for review, but if this change gets accepted I'll 
> > volunteer to rewrite all of the SVGs that contain external references. It 
> > just seemed silly to spend hours doing that and then have the project 
> > reject the change :-)

what you need can it be included in https://git.reviewboard.kde.org/r/126740/ 
than we may close this request?


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126738/#review91047
---


On Jan. 14, 2016, 1:18 vorm., Dirk Hohndel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126738/
> ---
> 
> (Updated Jan. 14, 2016, 1:18 vorm.)
> 
> 
> Review request for KDE Frameworks, andreas kainz and Uri Herrera.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> I don't know what I'm doing here. But when using the icons in a QML app I
> get a lot of warnings like this one:
> 
> Could not resolve property : linearGradient4548
> 
> Running the svgs through inkscape and using the "clean up document"
> function results in this commit (and the warnings are gone).
> 
> This may not be the right thing to do but it would be nice to get rid of
> all these warnings when using the icons.
> 
> Signed-off-by: Dirk Hohndel <d...@hohndel.org>
> 
> 
> Diffs
> -
> 
>   icons/actions/24/dialog-cancel.svg a2b022a9dc7b7cf97e4c3391b87e7800355d2dcb 
>   icons/actions/24/distribute-horizontal-x.svg 
> 262fcaca937cb72d8393fd5dff9c59651367fe36 
>   icons/actions/24/document-edit.svg afb37ca9624b37d6ac5aa9c94f1b2cef620faff6 
>   icons/actions/24/document-save.svg cee0a3521deb7eb1fcb79266afaa8951f4984b20 
> 
> Diff: https://git.reviewboard.kde.org/r/126738/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dirk Hohndel
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126740: Add a script for optimizing svgs

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review91352
---



there was also an discussion to use png files cause they are smaler in size but 
than I thing the stylesheet stuff didn't work. I have no problem to change to 
.svgz the only problem is that we have a lot linked files and the links will be 
broken when we change the extension so please include this issue into your 
script.
My decission would to to change to svgz and run the svg optimizing script ones 
in future by each change the dev can say run script if wanted. BUT as we 
already have this stylesheet script (marco) please make one script and say me 
how it works.

- andreas kainz


On Jan. 19, 2016, 10:54 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Jan. 19, 2016, 10:54 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize.svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126740: Add a script for optimizing svgs

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review91064
---


I have no problems to optimzie the svg files BUT my problem with the svg files 
is that they become more complex all the time last time the stylesheet, now 
optimization, 

I love scripts BUT it would be awesome for us to have this scripts before an 
distribution build there packages. In git keep it as simple as possible and 
when an distro will use the icons use therefore an script (check if the 
stylesheets fit, compress, make png files, )

- andreas kainz


On Jan. 14, 2016, 3 vorm., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Jan. 14, 2016, 3 vorm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize-svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125104: When using scalable icons use still only use sizes defined by index metadata

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125104/#review85013
---

Ship it!


Ship It!

- andreas kainz


On Sept. 8, 2015, 2:27 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125104/
> ---
> 
> (Updated Sept. 8, 2015, 2:27 p.m.)
> 
> 
> Review request for KDE Frameworks, andreas kainz and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> Icon metadata contains an entry of what sizes should be used for toolbars.
> 
> If a folder for an icon size contains scalable icons, the current code will 
> list every possible pixel size which could possibly be used. (The toolbar 
> then has code to reduce this back down to 10 "random" entries!)
> 
> Breeze icon designers say this is undesirable as it makes the
> ToolbarSizes config entry redundnant and despite being SVGs they are
> still designed to be rendered at specific pixel sizes.
> 
> 
> Diffs
> -
> 
>   src/kicontheme.cpp d29f82add93b97f8307a370cf3409fede38df865 
> 
> Diff: https://git.reviewboard.kde.org/r/125104/diff/
> 
> 
> Testing
> ---
> 
> Right click on a toolbar in a KF5 app, only lists relevant sizes.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel