from:"Nicolas Fella"

D29391: Introduce setWindow and CloseWhenWindowActivated

2020-05-03 Thread Nicolas Fella

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  This is a replacement for CloseOnWidgetActivated that operates on a QWindow 
instead of QWidget.

TEST PLAN
  PoC port of Yakuake:

REPOSITORY
  R289 KNotifications

BRANCH
  closewin

REVISION DETAIL
  https://phabricator.kde.org/D29391

AFFECTED FILES
  src/knotification.cpp
  src/knotification.h

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29390: Respect QIcon::fallbackSearchpaths()

2020-05-03 Thread Nicolas Fella

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  When an icon isn't found within a theme we are supposed to look for it in 
QIcon::fallbackSearchpaths() (https://doc.qt.io/qt-5/qicon.html#fromTheme).
  
  BUG: 405522

TEST PLAN
  Create /home/nico/foo.svg
  Add QIcon::setFallbackSearchPaths(QIcon::fallbackSearchPaths() << 
QStringLiteral("/home/nico/myicons")); to my app
  Use foo icon somewhere

REPOSITORY
  R302 KIconThemes

BRANCH
  fallback

REVISION DETAIL
  https://phabricator.kde.org/D29390

AFFECTED FILES
  src/kiconloader.cpp

To: nicolasfella, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29339: Implement updating of notifications on Android

2020-05-01 Thread Nicolas Fella

nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29339

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29342: Implement support for notification urgency on Android

2020-05-01 Thread Nicolas Fella

nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29342

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29335: Implement notification grouping on Android

2020-05-01 Thread Nicolas Fella

nicolasfella added inline comments.

INLINE COMMENTS

> vkrause wrote in NotifyByAndroid.java:171
> That seems counter-productive to me, as the Android API documentation always 
> speaks about API level numbers, so you'd need to do an additional translation 
> to/from the letters in your head. So for that I find "26" more useful here 
> than "O". It's also consistent with the rest of the code in this file.

You have a point

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29335

To: vkrause, nicolasfella
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29335: Implement notification grouping on Android

2020-05-01 Thread Nicolas Fella

nicolasfella accepted this revision.
nicolasfella added a comment.
This revision is now accepted and ready to land.


  Haven't tested it, but the code looks sensible

INLINE COMMENTS

> NotifyByAndroid.java:171
> +Notification.Builder builder;
> +if (Build.VERSION.SDK_INT >= 26) {
> +builder = new Notification.Builder(m_ctx, 
> notification.channelId);

Please use 
https://developer.android.com/reference/android/os/Build.VERSION_CODES instead 
of hardcoding numbers

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29335

To: vkrause, nicolasfella
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29021: Remove checks for notification service and fallback to KPassivePopup

2020-05-01 Thread Nicolas Fella

nicolasfella added a dependent revision: D29336: Remove galago from 
method/variable naming.

REPOSITORY
  R289 KNotifications

BRANCH
  nofallback2

REVISION DETAIL
  https://phabricator.kde.org/D29021

To: nicolasfella, #frameworks, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29336: Remove galago from method/variable naming

2020-05-01 Thread Nicolas Fella

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  With D29021  the fallback notification 
system is gone and with it the need for differentating naming. Remove galago 
from the naming since it's outdated and might confuse readers unfamiliar with 
the code and its history. Also inline a now not needed function.

TEST PLAN
  Still get notifications, action invoked signal is correctly sent
  
  Depends on D29021 

REPOSITORY
  R289 KNotifications

BRANCH
  nogalago

REVISION DETAIL
  https://phabricator.kde.org/D29336

AFFECTED FILES
  src/imageconverter.h
  src/notifybypopup.cpp
  src/notifybypopup.h
  src/notifybyportal.cpp

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29323: Handle multi-line and rich-text notifications on Android

2020-05-01 Thread Nicolas Fella

nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29323

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26604: Check if there is an activatable service when notification service owner changes

2020-04-29 Thread Nicolas Fella

nicolasfella abandoned this revision.
nicolasfella added a comment.


  I favor of  D29021 

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26604

To: nicolasfella, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26605: Remove fallback to KPassivePopup

2020-04-29 Thread Nicolas Fella

nicolasfella abandoned this revision.
nicolasfella added a comment.


  In favor of  D29021 

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26605

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29269: Consistently use knotify-config.h to pass in flags about Canberra/Phonon

2020-04-28 Thread Nicolas Fella

nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R305 KNotifyConfig

BRANCH
  useconsistentlyconfigfile

REVISION DETAIL
  https://phabricator.kde.org/D29269

To: kossebau, #frameworks, broulik, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29079: android: include the architecture on the apk name

2020-04-28 Thread Nicolas Fella

nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29079

To: apol, #android, #frameworks, nicolasfella
Cc: vkrause, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
bencreasy, michaelh, ngraham, bruns

D29021: Remove checks for notification service and fallback to KPassivePopup

2020-04-20 Thread Nicolas Fella

nicolasfella edited the summary of this revision.
nicolasfella edited the test plan for this revision.
nicolasfella added reviewers: Frameworks, Plasma, broulik.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29021

To: nicolasfella, #frameworks, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29021: Remove checks for notification service and fallback to KPassivePopup

2020-04-20 Thread Nicolas Fella

nicolasfella created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  nofallback2

REVISION DETAIL
  https://phabricator.kde.org/D29021

AFFECTED FILES
  src/notifybypopup.cpp
  src/notifybypopup.h

To: nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29020: Add example/test application

2020-04-20 Thread Nicolas Fella

nicolasfella updated this revision to Diff 80685.
nicolasfella added a comment.


  - Add license header

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29020?vs=80684=80685

BRANCH
  example

REVISION DETAIL
  https://phabricator.kde.org/D29020

AFFECTED FILES
  CMakeLists.txt
  examples/CMakeLists.txt
  examples/notificationtester.cpp
  examples/notificationtester.qml
  examples/resources.qrc

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29020: Add example/test application

2020-04-20 Thread Nicolas Fella

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The purpose of this is twofold. It serves as a code example, but most 
importantly it can be used to test changes in KNotifications. It is currently 
very basic, but can be expanded in the future

REPOSITORY
  R289 KNotifications

BRANCH
  example

REVISION DETAIL
  https://phabricator.kde.org/D29020

AFFECTED FILES
  CMakeLists.txt
  examples/CMakeLists.txt
  examples/notificationtester.cpp
  examples/notificationtester.qml
  examples/resources.qrc

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28805: Tweak kcmcontrols docs

2020-04-20 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:b8accaad1eda: Tweak kcmcontrols docs (authored by 
nicolasfella).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28805?vs=80044=80640

REVISION DETAIL
  https://phabricator.kde.org/D28805

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml
  src/qmlcontrols/kcmcontrols/qml/ScrollViewKCM.qml
  src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml

To: nicolasfella, #frameworks, jucato, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22701: [kfileutils] Add isExecutableFile from KRun

2020-04-20 Thread Nicolas Fella

nicolasfella abandoned this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D22701

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28020: New class ProcessLauncherJob in KIOGui

2020-04-18 Thread Nicolas Fella

nicolasfella added a comment.


  IIRC startup notification is still a big question mark in Wayland, but other 
Plasma devs know better

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28020

To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik
Cc: jbbgameich, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

Re: KDE CI: Administration » Dependency Build Extragear stable-kf5-qt5 AndroidQt5.14 - Build # 10 - Still Failing!

2020-04-16 Thread Nicolas Fella

Hi,

this looks like a simple prison build failure to me. However, I cannot 
reprocuce this with
the binary factory container and the current Prison Android CI builds is blue. 
There is a
single red Android build in the Prison CI history 
(https://build.kde.org/job/Frameworks/
job/prison/job/kf5-qt5%20AndroidQt5.14/5/[1]) with what appears to be the same
error message. Not sure how to explain that though.

Nico

On Donnerstag, 16. April 2020 21:10:44 CEST Ben Cooksley wrote:
> On Fri, Apr 17, 2020 at 6:37 AM Johan Ouwerkerk  
> wrote:
> > On Thu, Apr 16, 2020 at 10:51 AM Ben Cooksley  wrote:
> >> Hi all,
> >>
> >> Does anyone know why the below would have suddenly started failing a
> >> little while back?
> >>
> >> Thanks,
> >> Ben
> >
> > Based on the error message I would expect this to be related to the effort
> > to fix Android pkgs not being generated for both 32bit and 64bit ARM.
> I see. Do we have a timeline for this being fixed?
>
> > Regards,
> >
> > - Johan
>
> Cheers,
> Ben

[1] 
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.14/5/

D28851: Mark KStatusBarOfflineIndicator as deprecated

2020-04-15 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:cd53f10cad27: Mark KStatusBarOfflineIndicator as 
deprecated (authored by nicolasfella).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28851?vs=80190=80201

REVISION DETAIL
  https://phabricator.kde.org/D28851

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kstatusbarofflineindicator.cpp
  src/filewidgets/kstatusbarofflineindicator.h

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25705: Deprecate KIO::pixmapForUrl

2020-04-15 Thread Nicolas Fella

nicolasfella planned changes to this revision.
nicolasfella added a comment.


  Seems like I missed some usages

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25705

To: nicolasfella, #frameworks, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D25705: Deprecate KIO::pixmapForUrl

2020-04-15 Thread Nicolas Fella

nicolasfella updated this revision to Diff 80199.
nicolasfella added a comment.


  - Fix update

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25705?vs=80197=80199

BRANCH
  arcpatch-D25705_1

REVISION DETAIL
  https://phabricator.kde.org/D25705

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/pixmaploader.cpp
  src/widgets/pixmaploader.h

To: nicolasfella, #frameworks, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D25705: Deprecate KIO::pixmapForUrl

2020-04-15 Thread Nicolas Fella

nicolasfella added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25705

To: nicolasfella, #frameworks, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D25705: Deprecate KIO::pixmapForUrl

2020-04-15 Thread Nicolas Fella

nicolasfella updated this revision to Diff 80197.
nicolasfella added a comment.


  - Update

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25705?vs=72413=80197

BRANCH
  arcpatch-D25705_1

REVISION DETAIL
  https://phabricator.kde.org/D25705

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/pixmaploader.cpp
  src/widgets/pixmaploader.h

To: nicolasfella, #frameworks
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D17805: Allow specifying multiple mimetypes as constraints

2020-04-15 Thread Nicolas Fella

nicolasfella abandoned this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D17805

To: nicolasfella, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28851: Mark KStatusBarOfflineIndicator as deprecated

2020-04-15 Thread Nicolas Fella

nicolasfella added a task: T12373: Move or kill KStatusBarOfflineIndicator.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28851

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28851: Mark KStatusBarOfflineIndicator as deprecated

2020-04-15 Thread Nicolas Fella

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Conceptually it doesn't really belong to KIO and KTorrent was its only user. 
The code has been imported into KTorrent so we don't have any users left.

TEST PLAN
  builds

REPOSITORY
  R241 KIO

BRANCH
  offl

REVISION DETAIL
  https://phabricator.kde.org/D28851

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kstatusbarofflineindicator.cpp
  src/filewidgets/kstatusbarofflineindicator.h

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26034: Replace KLocalSocket with QLocalSocket

2020-04-15 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:28da79f2119e: Replace KLocalSocket with QLocalSocket 
(authored by nicolasfella).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26034?vs=71642=80188

REVISION DETAIL
  https://phabricator.kde.org/D26034

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/klocalsocketservertest.cpp
  autotests/klocalsocketservertest.h
  autotests/klocalsockettest.cpp
  autotests/klocalsockettest.h
  src/core/CMakeLists.txt
  src/core/connection.cpp
  src/core/connectionbackend.cpp
  src/core/connectionbackend_p.h
  src/core/connectionserver.cpp
  src/core/klocalsocket.cpp
  src/core/klocalsocket.h
  src/core/klocalsocket_p.h
  src/core/klocalsocket_unix.cpp
  src/core/klocalsocket_win.cpp

To: nicolasfella, #frameworks, dfaure
Cc: cullmann, vonreth, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28831: Add note about porting loadMimeTypeIcon

2020-04-15 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R302:fe3f59b27dcf: Add note about porting loadMimeTypeIcon 
(authored by nicolasfella).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28831?vs=80128=80186

REVISION DETAIL
  https://phabricator.kde.org/D28831

AFFECTED FILES
  src/kiconloader.h

To: nicolasfella, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D25443: [chmodjob] Port away from QLinkedList

2020-04-15 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e18ae3ea52dc: [chmodjob] Port away from QLinkedList 
(authored by nicolasfella).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25443?vs=80139=80187

REVISION DETAIL
  https://phabricator.kde.org/D25443

AFFECTED FILES
  src/core/chmodjob.cpp

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D19913: [plasma-desktop] make it compiles without foreach

2020-04-14 Thread Nicolas Fella

nicolasfella added a comment.


  The title says plasma-desktop, but this is plasma-framework?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

To: mlaurent, dfaure
Cc: nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D25443: [chmodjob] Port away from QLinkedList

2020-04-14 Thread Nicolas Fella

nicolasfella edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  ll

REVISION DETAIL
  https://phabricator.kde.org/D25443

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D28834: Add metadata properties to calendar

2020-04-14 Thread Nicolas Fella

nicolasfella marked an inline comment as done.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause
Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, 
mlaurent, knauss, dvratil

D28834: Add metadata properties to calendar

2020-04-14 Thread Nicolas Fella

nicolasfella updated this revision to Diff 80150.
nicolasfella added a comment.


  - default to ReadWrite
  - rename icon to iconname to reflect that it's just the name

REPOSITORY
  R172 KCalendar Core

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28834?vs=80140=80150

BRANCH
  props

REVISION DETAIL
  https://phabricator.kde.org/D28834

AFFECTED FILES
  src/calendar.cpp
  src/calendar.h
  src/calendar_p.h

To: nicolasfella, #frameworks, #kde_pim, vkrause
Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, 
mlaurent, knauss, dvratil

D24443: Add a plugin system

2020-04-14 Thread Nicolas Fella

nicolasfella planned changes to this revision.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D24443

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: z3ntu, ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, 
dhaumann, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss

D24443: Add a plugin system

2020-04-14 Thread Nicolas Fella

nicolasfella updated this revision to Diff 80142.
nicolasfella added a comment.


  - Convert license headers to SPDX

REPOSITORY
  R172 KCalendar Core

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24443?vs=80141=80142

BRANCH
  arcpatch-D24443_2

REVISION DETAIL
  https://phabricator.kde.org/D24443

AFFECTED FILES
  src/CMakeLists.txt
  src/calendarplugin.cpp
  src/calendarplugin.h

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: z3ntu, ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, 
dhaumann, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss

D24443: Add a plugin system

2020-04-14 Thread Nicolas Fella

nicolasfella updated this revision to Diff 80141.
nicolasfella added a comment.


  - Remove calendarentry

REPOSITORY
  R172 KCalendar Core

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24443?vs=71067=80141

BRANCH
  arcpatch-D24443_2

REVISION DETAIL
  https://phabricator.kde.org/D24443

AFFECTED FILES
  src/CMakeLists.txt
  src/calendarplugin.cpp
  src/calendarplugin.h

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: z3ntu, ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, 
dhaumann, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss

D24443: Add a plugin system

2020-04-14 Thread Nicolas Fella

nicolasfella edited the summary of this revision.
nicolasfella added a dependency: D28834: Add metadata properties to calendar.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D24443

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: z3ntu, ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, 
dhaumann, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss

D28834: Add metadata properties to calendar

2020-04-14 Thread Nicolas Fella

nicolasfella added a dependent revision: D24443: Add a plugin system.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D28834: Add metadata properties to calendar

2020-04-14 Thread Nicolas Fella

nicolasfella added reviewers: Frameworks, KDE PIM, vkrause.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D25443: [chmodjob] Port away from QLinkedList

2020-04-14 Thread Nicolas Fella

nicolasfella updated this revision to Diff 80139.
nicolasfella added a comment.


  - Update comment

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25443?vs=70143=80139

BRANCH
  ll

REVISION DETAIL
  https://phabricator.kde.org/D25443

AFFECTED FILES
  src/core/chmodjob.cpp

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D25443: [chmodjob] Port away from QLinkedList

2020-04-14 Thread Nicolas Fella

nicolasfella marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25443

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D22554: Finer No-Dbus on Windows

2020-04-14 Thread Nicolas Fella

nicolasfella added a comment.


  @brute4s99 Is this still relevant?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D22554

To: brute4s99, nicolasfella, broulik
Cc: andriusr, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27704: Drop FindAccountsFileDir.cmake

2020-04-14 Thread Nicolas Fella

nicolasfella abandoned this revision.

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27704

To: nicolasfella, #frameworks, bshah, leinir, lbeltrame
Cc: lbeltrame

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

2020-04-14 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ee08d0b4e56e: [renamedialog] Replace KIconLoader usage 
with QIcon::fromTheme (authored by nicolasfella).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25707?vs=70853=80131

REVISION DETAIL
  https://phabricator.kde.org/D25707

AFFECTED FILES
  src/widgets/renamedialog.cpp

To: nicolasfella, #frameworks, dfaure
Cc: ahmadsamir, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

2020-04-14 Thread Nicolas Fella

nicolasfella added a comment.


  In D25707#645694 , @dfaure wrote:
  
  > OK. Then let me change my comment to: please document in kiconloader.h how 
to port away from loadMimeTypeIcon, even if it's not actually deprecated.
  >
  > I remember wondering the same thing at one point.
  
  
  Done in D28831 

REPOSITORY
  R241 KIO

BRANCH
  rena

REVISION DETAIL
  https://phabricator.kde.org/D25707

To: nicolasfella, #frameworks, dfaure
Cc: ahmadsamir, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28831: Add note about porting loadMimeTypeIcon

2020-04-14 Thread Nicolas Fella

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  We're phasing out loadMimeTypeIcon in favor of QIcon::fromTheme(). We can't 
oficially deprecate it yet since there are still unported users, but add a 
comment recommending alternative API.

REPOSITORY
  R302 KIconThemes

BRANCH
  mime

REVISION DETAIL
  https://phabricator.kde.org/D28831

AFFECTED FILES
  src/kiconloader.h

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26918: Improve KNotification API docs

2020-04-13 Thread Nicolas Fella

nicolasfella added a comment.


  ping?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26918

To: nicolasfella, #frameworks, broulik, jucato
Cc: class, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28800: Always create actioncollection

2020-04-13 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R294:4b3fc2aedd86: Always create actioncollection (authored by 
nicolasfella).

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28800?vs=80034=80051

REVISION DETAIL
  https://phabricator.kde.org/D28800

AFFECTED FILES
  src/kbookmarkmenu.cpp

To: nicolasfella, #frameworks, dfaure, stefanocrocco
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28800: Always create actioncollection

2020-04-13 Thread Nicolas Fella

nicolasfella added a comment.


  In D28800#647508 , @dfaure wrote:
  
  > (but now konqueror creates another one, so the konqueror patch needs to 
changed to "if exactly 5.69" only, right?)
  
  
  makes sense

REPOSITORY
  R294 KBookmarks

BRANCH
  emptycoll

REVISION DETAIL
  https://phabricator.kde.org/D28800

To: nicolasfella, #frameworks, dfaure, stefanocrocco
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28805: Tweak kcmcontrols docs

2020-04-13 Thread Nicolas Fella

nicolasfella edited the summary of this revision.
nicolasfella added a reviewer: Frameworks.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28805

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28805: Tweak kcmcontrols docs

2020-04-13 Thread Nicolas Fella

nicolasfella added a reviewer: jucato.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28805

To: nicolasfella, #frameworks, jucato
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28805: Tweak kcmcontrols docs

2020-04-13 Thread Nicolas Fella

nicolasfella created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R296 KDeclarative

BRANCH
  tweakdocs

REVISION DETAIL
  https://phabricator.kde.org/D28805

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml
  src/qmlcontrols/kcmcontrols/qml/ScrollViewKCM.qml
  src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml

To: nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28800: Always create actioncollection

2020-04-13 Thread Nicolas Fella

nicolasfella added reviewers: Frameworks, dfaure, stefanocrocco.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D28800

To: nicolasfella, #frameworks, dfaure, stefanocrocco
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28800: Always create actioncollection

2020-04-13 Thread Nicolas Fella

nicolasfella created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Otherwise subclasses that unconditionally use m_actionCollection will get 
crashes. Observed in D28789 

REPOSITORY
  R294 KBookmarks

BRANCH
  emptycoll

REVISION DETAIL
  https://phabricator.kde.org/D28800

AFFECTED FILES
  src/kbookmarkmenu.cpp

To: nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

2020-04-06 Thread Nicolas Fella

nicolasfella added a comment.


  ping?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25707

To: nicolasfella, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

2020-04-06 Thread Nicolas Fella

nicolasfella added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25707

To: nicolasfella, #frameworks, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D24443: Add a plugin system

2020-04-04 Thread Nicolas Fella

nicolasfella planned changes to this revision.
nicolasfella added a comment.


  - single level hierarchy with a calendargroup object
  - calendar entry folded into calendar
  - calendar::open

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D24443

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, dhaumann, 
fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss

D28391: [pc3/busyindicator] Hide when not running

2020-03-29 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:bc3ccd1782cb: [pc3/busyindicator] Hide when not running 
(authored by nicolasfella).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28391?vs=78768=78812

REVISION DETAIL
  https://phabricator.kde.org/D28391

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/BusyIndicator.qml

To: nicolasfella, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28391: [pc3/busyindicator] Hide when not running

2020-03-28 Thread Nicolas Fella

nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  When not running the indicator should be invisible. This matches the 
behaviour of the org.kde.desktop style.

TEST PLAN
  Run KTrip with Plasma style. Open location search page. Indicator is only 
shown when actually loading things

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  running

REVISION DETAIL
  https://phabricator.kde.org/D28391

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/BusyIndicator.qml

To: nicolasfella, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28295: Introduce KNotificationJobUiDelegate

2020-03-27 Thread Nicolas Fella

nicolasfella accepted this revision.
nicolasfella added a comment.
This revision is now accepted and ready to land.


  Otherwise looks good to me

INLINE COMMENTS

> knotificationjobuidelegate.h:28
> + * @class KNotificationJobUiDelegate knotificationjobuidelegate.h 
> KNotificationJobUiDelegate
> + *
> + * A UI delegate using KNotification for interaction (showing errors and 
> warnings).

@since

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28295

To: broulik, #frameworks, nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28295: Introduce KNotificationJobUiDelegate

2020-03-27 Thread Nicolas Fella

nicolasfella added inline comments.

INLINE COMMENTS

> knotificationjobuidelegate.h:29
> + *
> + * A UI delegate using KMessageBox for interaction (showing errors and 
> warnings).
> + *

s/KMessageBox/KNotification/g?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28295

To: broulik, #frameworks, nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28312: Implement urls using hints

2020-03-26 Thread Nicolas Fella

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Set the hint directly in KNotification instead of the backend. Saves us a bit 
of code

TEST PLAN
  spectacle notifications still has an image

REPOSITORY
  R289 KNotifications

BRANCH
  urlshint

REVISION DETAIL
  https://phabricator.kde.org/D28312

AFFECTED FILES
  src/knotification.cpp
  src/notifybypopup.cpp

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26918: Improve KNotification API docs

2020-03-24 Thread Nicolas Fella

nicolasfella updated this revision to Diff 78423.
nicolasfella added a comment.


  - Drop user config file description since it's an implementation detail

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26918?vs=78416=78423

BRANCH
  docs

REVISION DETAIL
  https://phabricator.kde.org/D26918

AFFECTED FILES
  Mainpage.dox
  src/knotification.h

To: nicolasfella, #frameworks, broulik, jucato
Cc: class, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D26918: Improve KNotification API docs

2020-03-24 Thread Nicolas Fella

nicolasfella updated this revision to Diff 78416.
nicolasfella added a comment.


  - Add a dedicated main page and link to the HIG from there
  - Move most content to main page
  - Fix code example

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26918?vs=75799=78416

BRANCH
  docs

REVISION DETAIL
  https://phabricator.kde.org/D26918

AFFECTED FILES
  Mainpage.dox
  src/knotification.h

To: nicolasfella, #frameworks, broulik, jucato
Cc: class, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D26918: Improve KNotification API docs

2020-03-24 Thread Nicolas Fella

nicolasfella added inline comments.

INLINE COMMENTS

> apol wrote in Mainpage.dox:9
> @class so we create a link.

Doxygen should do that automatically
http://www.doxygen.nl/manual/autolink.html

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26918

To: nicolasfella, #frameworks, broulik, jucato
Cc: class, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D25660: Decouple KBookmarksMenu from KActionCollection

2020-03-24 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R294:0c888e2f8098: Decouple KBookmarksMenu from 
KActionCollection (authored by nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25660?vs=73666=78402#toc

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25660?vs=73666=78402

REVISION DETAIL
  https://phabricator.kde.org/D25660

AFFECTED FILES
  src/CMakeLists.txt
  src/kbookmarkmenu.cpp
  src/kbookmarkmenu.h

To: nicolasfella, #frameworks, dfaure
Cc: kossebau, dfaure, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27635: Restore kio-webdav plugin

2020-03-18 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R155:693d7361428e: Restore kio-webdav plugin (authored by 
nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27635?vs=77280=77965#toc

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27635?vs=77280=77965

REVISION DETAIL
  https://phabricator.kde.org/D27635

AFFECTED FILES
  CMakeLists.txt
  src/kded/kio-webdav/CMakeLists.txt
  src/kded/kio-webdav/createkioservice.cpp
  src/kded/kio-webdav/createkioservice.h
  src/kded/kio-webdav/createnetattachjob.cpp
  src/kded/kio-webdav/createnetattachjob.h
  src/kded/kio-webdav/kioservices.cpp
  src/kded/kio-webdav/kioservices.h
  src/kded/kio-webdav/removekioservice.cpp
  src/kded/kio-webdav/removekioservice.h
  src/kded/kio-webdav/removenetattachjob.cpp
  src/kded/kio-webdav/removenetattachjob.h
  src/kded/kio-webdav/tests/CMakeLists.txt
  src/kded/kio-webdav/tests/testnetattachjobs.cpp
  src/plugins/CMakeLists.txt
  src/plugins/kio-webdav/CMakeLists.txt
  src/plugins/kio-webdav/createkioservice.cpp
  src/plugins/kio-webdav/createkioservice.h
  src/plugins/kio-webdav/createnetattachjob.cpp
  src/plugins/kio-webdav/createnetattachjob.h
  src/plugins/kio-webdav/kio-webdav.json
  src/plugins/kio-webdav/kioservices.cpp
  src/plugins/kio-webdav/kioservices.h
  src/plugins/kio-webdav/removekioservice.cpp
  src/plugins/kio-webdav/removekioservice.h
  src/plugins/kio-webdav/removenetattachjob.cpp
  src/plugins/kio-webdav/removenetattachjob.h
  src/plugins/kio-webdav/tests/CMakeLists.txt
  src/plugins/kio-webdav/tests/testnetattachjobs.cpp

To: nicolasfella, bshah, leinir, #frameworks

D28110: PersonsModel: Fix PersonVCardRole

2020-03-17 Thread Nicolas Fella

nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R307 KPeople

BRANCH
  fix-personsmodel-vcard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28110

To: jbbgameich, apol, nicolasfella
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28110: PersonsModel: Fix PersonVCardRole

2020-03-17 Thread Nicolas Fella

nicolasfella added inline comments.

INLINE COMMENTS

> personsmodel.cpp:186
>  case PersonsModel::PersonVCardRole:
> -return QVariant::fromValue(person);
> +return person->customProperty(QStringLiteral("vcard"));
>  case PersonsModel::ContactsVCardRole:

Use AbstractContact::VCardProperty

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D28110

To: jbbgameich, apol
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27635: Restore kio-webdav plugin

2020-03-09 Thread Nicolas Fella

nicolasfella added inline comments.

INLINE COMMENTS

> leinir wrote in kaccountsdplugin.h:57
> This still introduces a API break, though... Which seems especially silly 
> given the arguments aren't actually used. Perhaps add a new ctor, and have 
> the one without the arguments call the new one, but also make a qwarning (or 
> something similar) note that it's using an old ctor and really out to upgrade?

This shouldn't be in this diff at all

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27635

To: nicolasfella, bshah, leinir, #frameworks

D27635: Restore kio-webdav plugin

2020-03-09 Thread Nicolas Fella

nicolasfella updated this revision to Diff 77280.
nicolasfella added a comment.


  - Remove whitespace change

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27635?vs=77279=77280

BRANCH
  arcpatch-D27635

REVISION DETAIL
  https://phabricator.kde.org/D27635

AFFECTED FILES
  CMakeLists.txt
  src/kded/kio-webdav/CMakeLists.txt
  src/kded/kio-webdav/createkioservice.cpp
  src/kded/kio-webdav/createkioservice.h
  src/kded/kio-webdav/createnetattachjob.cpp
  src/kded/kio-webdav/createnetattachjob.h
  src/kded/kio-webdav/kioservices.cpp
  src/kded/kio-webdav/kioservices.h
  src/kded/kio-webdav/removekioservice.cpp
  src/kded/kio-webdav/removekioservice.h
  src/kded/kio-webdav/removenetattachjob.cpp
  src/kded/kio-webdav/removenetattachjob.h
  src/kded/kio-webdav/tests/CMakeLists.txt
  src/kded/kio-webdav/tests/testnetattachjobs.cpp
  src/plugins/CMakeLists.txt
  src/plugins/kio-webdav/CMakeLists.txt
  src/plugins/kio-webdav/createkioservice.cpp
  src/plugins/kio-webdav/createkioservice.h
  src/plugins/kio-webdav/createnetattachjob.cpp
  src/plugins/kio-webdav/createnetattachjob.h
  src/plugins/kio-webdav/kio-webdav.json
  src/plugins/kio-webdav/kioservices.cpp
  src/plugins/kio-webdav/kioservices.h
  src/plugins/kio-webdav/removekioservice.cpp
  src/plugins/kio-webdav/removekioservice.h
  src/plugins/kio-webdav/removenetattachjob.cpp
  src/plugins/kio-webdav/removenetattachjob.h
  src/plugins/kio-webdav/tests/CMakeLists.txt
  src/plugins/kio-webdav/tests/testnetattachjobs.cpp

To: nicolasfella, bshah, leinir, #frameworks

D27635: Restore kio-webdav plugin

2020-03-09 Thread Nicolas Fella

nicolasfella updated this revision to Diff 77279.
nicolasfella marked an inline comment as done.
nicolasfella added a comment.


  Rebase

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27635?vs=76416=77279

BRANCH
  arcpatch-D27635

REVISION DETAIL
  https://phabricator.kde.org/D27635

AFFECTED FILES
  CMakeLists.txt
  src/kded/kded_accounts.cpp
  src/kded/kio-webdav/CMakeLists.txt
  src/kded/kio-webdav/createkioservice.cpp
  src/kded/kio-webdav/createkioservice.h
  src/kded/kio-webdav/createnetattachjob.cpp
  src/kded/kio-webdav/createnetattachjob.h
  src/kded/kio-webdav/kioservices.cpp
  src/kded/kio-webdav/kioservices.h
  src/kded/kio-webdav/removekioservice.cpp
  src/kded/kio-webdav/removekioservice.h
  src/kded/kio-webdav/removenetattachjob.cpp
  src/kded/kio-webdav/removenetattachjob.h
  src/kded/kio-webdav/tests/CMakeLists.txt
  src/kded/kio-webdav/tests/testnetattachjobs.cpp
  src/plugins/CMakeLists.txt
  src/plugins/kio-webdav/CMakeLists.txt
  src/plugins/kio-webdav/createkioservice.cpp
  src/plugins/kio-webdav/createkioservice.h
  src/plugins/kio-webdav/createnetattachjob.cpp
  src/plugins/kio-webdav/createnetattachjob.h
  src/plugins/kio-webdav/kio-webdav.json
  src/plugins/kio-webdav/kioservices.cpp
  src/plugins/kio-webdav/kioservices.h
  src/plugins/kio-webdav/removekioservice.cpp
  src/plugins/kio-webdav/removekioservice.h
  src/plugins/kio-webdav/removenetattachjob.cpp
  src/plugins/kio-webdav/removenetattachjob.h
  src/plugins/kio-webdav/tests/CMakeLists.txt
  src/plugins/kio-webdav/tests/testnetattachjobs.cpp

To: nicolasfella, bshah, leinir, #frameworks

D27704: Drop FindAccountsFileDir.cmake

2020-03-09 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R155:17ff746ba128: Drop FindAccountsFileDir.cmake (authored by 
nicolasfella).

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27704?vs=76561=77278

REVISION DETAIL
  https://phabricator.kde.org/D27704

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/cmake/CMakeLists.txt
  src/lib/cmake/FindAccountsFileDir.cmake

To: nicolasfella, #frameworks, bshah, leinir

D27708: Cleanup accounts kded module

2020-03-09 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R155:4d36ced449f2: Cleanup accounts kded module (authored by 
nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27708?vs=77182=77277#toc

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27708?vs=77182=77277

REVISION DETAIL
  https://phabricator.kde.org/D27708

AFFECTED FILES
  src/CMakeLists.txt
  src/daemon/CMakeLists.txt
  src/daemon/daemon.cpp
  src/daemon/daemon.h
  src/daemon/kded_accounts.json
  src/daemon/kio-webdav/CMakeLists.txt
  src/daemon/kio-webdav/createkioservice.cpp
  src/daemon/kio-webdav/createkioservice.h
  src/daemon/kio-webdav/createnetattachjob.cpp
  src/daemon/kio-webdav/createnetattachjob.h
  src/daemon/kio-webdav/kioservices.cpp
  src/daemon/kio-webdav/kioservices.h
  src/daemon/kio-webdav/removekioservice.cpp
  src/daemon/kio-webdav/removekioservice.h
  src/daemon/kio-webdav/removenetattachjob.cpp
  src/daemon/kio-webdav/removenetattachjob.h
  src/daemon/kio-webdav/tests/CMakeLists.txt
  src/daemon/kio-webdav/tests/testnetattachjobs.cpp
  src/kded/CMakeLists.txt
  src/kded/kded_accounts.cpp
  src/kded/kded_accounts.h
  src/kded/kded_accounts.json
  src/kded/kio-webdav/CMakeLists.txt
  src/kded/kio-webdav/createkioservice.cpp
  src/kded/kio-webdav/createkioservice.h
  src/kded/kio-webdav/createnetattachjob.cpp
  src/kded/kio-webdav/createnetattachjob.h
  src/kded/kio-webdav/kioservices.cpp
  src/kded/kio-webdav/kioservices.h
  src/kded/kio-webdav/removekioservice.cpp
  src/kded/kio-webdav/removekioservice.h
  src/kded/kio-webdav/removenetattachjob.cpp
  src/kded/kio-webdav/removenetattachjob.h
  src/kded/kio-webdav/tests/CMakeLists.txt
  src/kded/kio-webdav/tests/testnetattachjobs.cpp

To: nicolasfella, #frameworks, bshah, leinir

D27562: [kcmcontrols] Respect header/footer visibility

2020-03-08 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:0dad857cddfb: [kcmcontrols] Respect header/footer 
visibility (authored by nicolasfella).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27562?vs=76136=77221

REVISION DETAIL
  https://phabricator.kde.org/D27562

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml
  src/qmlcontrols/kcmcontrols/qml/ScrollViewKCM.qml

To: nicolasfella, #plasma, mart, ngraham
Cc: iasensio, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27562: [kcmcontrols] Respect header/footer visibility

2020-03-07 Thread Nicolas Fella

nicolasfella added a comment.


  ping?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27562

To: nicolasfella, #plasma, mart
Cc: iasensio, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27708: Cleanup accounts kded module

2020-03-07 Thread Nicolas Fella

nicolasfella updated this revision to Diff 77182.
nicolasfella added a comment.


  rebase

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27708?vs=76570=77182

BRANCH
  arcpatch-D27708

REVISION DETAIL
  https://phabricator.kde.org/D27708

AFFECTED FILES
  src/CMakeLists.txt
  src/daemon/CMakeLists.txt
  src/daemon/daemon.cpp
  src/daemon/daemon.h
  src/daemon/kded_accounts.json
  src/daemon/kio-webdav/CMakeLists.txt
  src/daemon/kio-webdav/createkioservice.cpp
  src/daemon/kio-webdav/createkioservice.h
  src/daemon/kio-webdav/createnetattachjob.cpp
  src/daemon/kio-webdav/createnetattachjob.h
  src/daemon/kio-webdav/kioservices.cpp
  src/daemon/kio-webdav/kioservices.h
  src/daemon/kio-webdav/removekioservice.cpp
  src/daemon/kio-webdav/removekioservice.h
  src/daemon/kio-webdav/removenetattachjob.cpp
  src/daemon/kio-webdav/removenetattachjob.h
  src/daemon/kio-webdav/tests/CMakeLists.txt
  src/daemon/kio-webdav/tests/testnetattachjobs.cpp
  src/kded/CMakeLists.txt
  src/kded/kded_accounts.cpp
  src/kded/kded_accounts.h
  src/kded/kded_accounts.json
  src/kded/kio-webdav/CMakeLists.txt
  src/kded/kio-webdav/createkioservice.cpp
  src/kded/kio-webdav/createkioservice.h
  src/kded/kio-webdav/createnetattachjob.cpp
  src/kded/kio-webdav/createnetattachjob.h
  src/kded/kio-webdav/kioservices.cpp
  src/kded/kio-webdav/kioservices.h
  src/kded/kio-webdav/removekioservice.cpp
  src/kded/kio-webdav/removekioservice.h
  src/kded/kio-webdav/removenetattachjob.cpp
  src/kded/kio-webdav/removenetattachjob.h
  src/kded/kio-webdav/tests/CMakeLists.txt
  src/kded/kio-webdav/tests/testnetattachjobs.cpp

To: nicolasfella, #frameworks, bshah, leinir

D27662: Rewrite nextcloud plugin

2020-03-02 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:bea001a564b1: Rewrite nextcloud plugin (authored by 
nicolasfella).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27662?vs=76421=76772

REVISION DETAIL
  https://phabricator.kde.org/D27662

AFFECTED FILES
  src/plugins/nextcloud/nextcloudjob.cpp
  src/plugins/nextcloud/nextcloudjob.h
  src/plugins/nextcloud/nextcloudplugin_config.qml

To: nicolasfella, #frameworks, apol, bshah
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

2020-03-01 Thread Nicolas Fella

nicolasfella closed this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: jbbgameich, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27740: Adapt action numbering in Android to work like in KNotifications

2020-03-01 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:92f5564da771: Adapt action numbering in Android to work 
like in KNotifications (authored by cacahueto, committed by nicolasfella).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27740?vs=76685=76732

REVISION DETAIL
  https://phabricator.kde.org/D27740

AFFECTED FILES
  src/android/org/kde/knotifications/NotifyByAndroid.java

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: kde-frameworks-devel, jbbgameich, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27740: Adapt action numbering in Android to work like in KNotifications

2020-03-01 Thread Nicolas Fella

nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  adapt-action-numbering-in-android (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27740

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: kde-frameworks-devel, jbbgameich, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27760: WIP | Added BatchMoveJob

2020-03-01 Thread Nicolas Fella

nicolasfella added a comment.


  What's the difference to the job you get with KIO::move with a list of urls? 
https://api.kde.org/frameworks/kio/html/namespaceKIO.html#a20da0b04660f834de30f9440673f6d5e

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27760

To: emateli, dfaure, ngraham
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27707: Use kcoreaddons_add_plugin for kded module

2020-02-28 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R155:4ad7ceea349b: Use kcoreaddons_add_plugin for kded module 
(authored by nicolasfella).

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27707?vs=76569=76612

REVISION DETAIL
  https://phabricator.kde.org/D27707

AFFECTED FILES
  src/daemon/CMakeLists.txt
  src/daemon/accounts.desktop
  src/daemon/kded_accounts.json

To: nicolasfella, #frameworks, bshah, leinir, apol

D27706: Random cmake cleanup

2020-02-28 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R155:3f4fc9d4071b: Random cmake cleanup (authored by 
nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27706?vs=76567=76611#toc

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27706?vs=76567=76611

REVISION DETAIL
  https://phabricator.kde.org/D27706

AFFECTED FILES
  CMakeLists.txt
  src/lib/CMakeLists.txt

To: nicolasfella, #frameworks, bshah, leinir, apol

D27705: Use QStringLiteral

2020-02-28 Thread Nicolas Fella

nicolasfella marked an inline comment as done.

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27705

To: nicolasfella, #frameworks, bshah, leinir, apol
Cc: apol

D27705: Use QStringLiteral

2020-02-28 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R155:be294dcc69e7: Use QStringLiteral (authored by 
nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27705?vs=76566=76610#toc

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27705?vs=76566=76610

REVISION DETAIL
  https://phabricator.kde.org/D27705

AFFECTED FILES
  src/kcm/accounts.cpp
  src/lib/createaccountjob.cpp
  src/lib/getcredentialsjob.cpp
  src/lib/uipluginsmanager.cpp

To: nicolasfella, #frameworks, bshah, leinir, apol
Cc: apol

D27709: Move job classes to kaccounts lib and rename to *Job

2020-02-28 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R155:2030bb498ed3: Move job classes to kaccounts lib and 
rename to *Job (authored by nicolasfella).

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27709?vs=76580=76609

REVISION DETAIL
  https://phabricator.kde.org/D27709

AFFECTED FILES
  example/accounts.qml
  src/declarative/CMakeLists.txt
  src/declarative/kaccountsdeclarativeplugin.cpp
  src/jobs/accountservicetoggle.cpp
  src/jobs/accountservicetoggle.h
  src/jobs/createaccount.cpp
  src/jobs/createaccount.h
  src/kcm/package/contents/ui/AvailableAccounts.qml
  src/kcm/package/contents/ui/AvailableServices.qml
  src/lib/CMakeLists.txt
  src/lib/accountservicetogglejob.cpp
  src/lib/accountservicetogglejob.h
  src/lib/createaccountjob.cpp
  src/lib/createaccountjob.h
  src/lib/uipluginsmanager.cpp

To: nicolasfella, #frameworks, bshah, leinir

D25654: Rename actions to be consistent

2020-02-27 Thread Nicolas Fella

nicolasfella updated this revision to Diff 76587.
nicolasfella added a comment.


  rebase

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25654?vs=70674=76587

BRANCH
  arcpatch-D25654

REVISION DETAIL
  https://phabricator.kde.org/D25654

AFFECTED FILES
  src/kbookmarkmenu.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25654: Rename actions to be consistent

2020-02-27 Thread Nicolas Fella

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R294:dddb013871ba: Rename actions to be consistent (authored 
by nicolasfella).

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25654?vs=76587=76588

REVISION DETAIL
  https://phabricator.kde.org/D25654

AFFECTED FILES
  src/kbookmarkmenu.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27709: Move job classes to kaccounts lib and rename to *Job

2020-02-27 Thread Nicolas Fella

nicolasfella retitled this revision from "Move job classes to kaccounts lib" to 
"Move job classes to kaccounts lib and rename to *Job".

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27709

To: nicolasfella, #frameworks, bshah, leinir

D27709: Move job classes to kaccounts lib

2020-02-27 Thread Nicolas Fella

nicolasfella updated this revision to Diff 76580.
nicolasfella added a comment.


  - Rename to *Job

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27709?vs=76573=76580

BRANCH
  decl

REVISION DETAIL
  https://phabricator.kde.org/D27709

AFFECTED FILES
  example/accounts.qml
  src/declarative/CMakeLists.txt
  src/declarative/kaccountsdeclarativeplugin.cpp
  src/jobs/accountservicetoggle.cpp
  src/jobs/accountservicetoggle.h
  src/jobs/createaccount.cpp
  src/jobs/createaccount.h
  src/kcm/package/contents/ui/AvailableAccounts.qml
  src/kcm/package/contents/ui/AvailableServices.qml
  src/lib/CMakeLists.txt
  src/lib/accountservicetogglejob.cpp
  src/lib/accountservicetogglejob.h
  src/lib/createaccountjob.cpp
  src/lib/createaccountjob.h
  src/lib/uipluginsmanager.cpp

To: nicolasfella, #frameworks, bshah, leinir

D27528: Adapt action numbering in Android to work like in KNotifications

2020-02-27 Thread Nicolas Fella

nicolasfella accepted this revision.
nicolasfella added a comment.
This revision is now accepted and ready to land.


  Let's get this in. Can you please give me your full name and email address so 
I can merge this?

REPOSITORY
  R289 KNotifications

BRANCH
  adapt-action-numbering-in-android-as-in-knotifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: jbbgameich, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27709: Move job classes to kaccounts lib

2020-02-27 Thread Nicolas Fella

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, bshah, leinir.
nicolasfella requested review of this revision.

REVISION SUMMARY
  This makes including them from the qml plugin less weird and they might be 
interesting to use from C++ too.

TEST PLAN
  builds, kcm opens

REPOSITORY
  R155 KAccounts Integration

BRANCH
  decl

REVISION DETAIL
  https://phabricator.kde.org/D27709

AFFECTED FILES
  src/declarative/CMakeLists.txt
  src/declarative/kaccountsdeclarativeplugin.cpp
  src/jobs/accountservicetoggle.cpp
  src/jobs/accountservicetoggle.h
  src/jobs/createaccount.cpp
  src/jobs/createaccount.h
  src/lib/CMakeLists.txt
  src/lib/accountservicetoggle.cpp
  src/lib/accountservicetoggle.h
  src/lib/createaccount.cpp
  src/lib/createaccount.h
  src/lib/uipluginsmanager.cpp

To: nicolasfella, #frameworks, bshah, leinir

D27708: Cleanup accounts kded module

2020-02-27 Thread Nicolas Fella

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, bshah, leinir.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Rename to emphasize it's a kded module plus some random cleanup

TEST PLAN
  builds, kded5 starts

REPOSITORY
  R155 KAccounts Integration

BRANCH
  kded

REVISION DETAIL
  https://phabricator.kde.org/D27708

AFFECTED FILES
  src/CMakeLists.txt
  src/daemon/CMakeLists.txt
  src/daemon/daemon.cpp
  src/daemon/daemon.h
  src/daemon/kded_accounts.json
  src/daemon/kio-webdav/CMakeLists.txt
  src/daemon/kio-webdav/createkioservice.cpp
  src/daemon/kio-webdav/createkioservice.h
  src/daemon/kio-webdav/createnetattachjob.cpp
  src/daemon/kio-webdav/createnetattachjob.h
  src/daemon/kio-webdav/kioservices.cpp
  src/daemon/kio-webdav/kioservices.h
  src/daemon/kio-webdav/removekioservice.cpp
  src/daemon/kio-webdav/removekioservice.h
  src/daemon/kio-webdav/removenetattachjob.cpp
  src/daemon/kio-webdav/removenetattachjob.h
  src/daemon/kio-webdav/tests/CMakeLists.txt
  src/daemon/kio-webdav/tests/testnetattachjobs.cpp
  src/kded/CMakeLists.txt
  src/kded/kded_accounts.cpp
  src/kded/kded_accounts.h
  src/kded/kded_accounts.json
  src/kded/kio-webdav/CMakeLists.txt
  src/kded/kio-webdav/createkioservice.cpp
  src/kded/kio-webdav/createkioservice.h
  src/kded/kio-webdav/createnetattachjob.cpp
  src/kded/kio-webdav/createnetattachjob.h
  src/kded/kio-webdav/kioservices.cpp
  src/kded/kio-webdav/kioservices.h
  src/kded/kio-webdav/removekioservice.cpp
  src/kded/kio-webdav/removekioservice.h
  src/kded/kio-webdav/removenetattachjob.cpp
  src/kded/kio-webdav/removenetattachjob.h
  src/kded/kio-webdav/tests/CMakeLists.txt
  src/kded/kio-webdav/tests/testnetattachjobs.cpp

To: nicolasfella, #frameworks, bshah, leinir

D27707: Use kcoreaddons_add_plugin for kded module

2020-02-27 Thread Nicolas Fella

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, bshah, leinir.
nicolasfella requested review of this revision.

REPOSITORY
  R155 KAccounts Integration

BRANCH
  plug

REVISION DETAIL
  https://phabricator.kde.org/D27707

AFFECTED FILES
  src/daemon/CMakeLists.txt
  src/daemon/accounts.desktop
  src/daemon/kded_accounts.json

To: nicolasfella, #frameworks, bshah, leinir

D27706: Random cmake cleanup

2020-02-27 Thread Nicolas Fella

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, bshah, leinir.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Remove unneeded calls, make coding style a bit more consistent

TEST PLAN
  builds

REPOSITORY
  R155 KAccounts Integration

BRANCH
  cmakecleanup

REVISION DETAIL
  https://phabricator.kde.org/D27706

AFFECTED FILES
  CMakeLists.txt
  src/lib/CMakeLists.txt

To: nicolasfella, #frameworks, bshah, leinir

D27705: Use QStringLiteral

2020-02-27 Thread Nicolas Fella

nicolasfella updated this revision to Diff 76566.
nicolasfella added a comment.


  Remove unintended change

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27705?vs=76565=76566

BRANCH
  arcpatch-D27705

REVISION DETAIL
  https://phabricator.kde.org/D27705

AFFECTED FILES
  src/jobs/createaccount.cpp
  src/kcm/accounts.cpp
  src/lib/getcredentialsjob.cpp
  src/lib/uipluginsmanager.cpp

To: nicolasfella, #frameworks, bshah, leinir

< 1 2 3 4 5 6 7 8 9 >

101 - 200 of 846 matches

Mail list logo