D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  I believe it's done.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D14516: Open `skipPager` functionality

[Scott Harvey]

sharvey created this revision.
sharvey added a reviewer: hein.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
sharvey requested review of this revision.

REVISION SUMMARY
  Open `skipPager` functionality, same as `skipTaskbar`
  REVIEWER NOTE: Several of the autotests are failing, although the build 
itself compiles correctly
  
  - #7: kwayland-testWaylandSeat
  - #23 kwayland-testPlasmaShell
  - #30 kwayland-testSelection

TEST PLAN
  - Apply patch to KWayland, compile
- Run `make tests` to check autotests
- See if #7, #23, #30 fail
  
  Please help resolve.

REPOSITORY
  R127 KWayland

BRANCH
  add-skip-pager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14516

AFFECTED FILES
  .arclint
  CMakeLists.txt.user
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-window-management.xml
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  tests/plasmasurfacetest.cpp

To: sharvey, hein
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14516: Open `skipPager` functionality

[Scott Harvey]

sharvey added a reviewer: Plasma on Wayland.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14516

To: sharvey, hein, #plasma_on_wayland
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14516: Open `skipPager` functionality

[Scott Harvey]

sharvey added a comment.


  Plasma team: Please help me review and fix the failing autotests. I'm not 
familiar enough with the internals of KWayland - or autotests - to successfully 
debug what's happening. The patch builds and compiles without error.
  
  Thanks for your help.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14516

To: sharvey, hein, #plasma_on_wayland
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14516: Open `skipPager` functionality

[Scott Harvey]

sharvey added a comment.


  In D14516#301385 , @ngraham wrote:
  
  > Changes to `.arclint` look unintended, and I'm not sure you meant to check 
in `CMakeLists.txt.user`.
  
  
  The changes are intentional - my arc seems to be broken. It wasn't supposed 
to be checked in. I'll fix.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14516

To: sharvey, hein, #plasma_on_wayland
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14516: Open `skipPager` functionality

[Scott Harvey]

sharvey updated this revision to Diff 38859.
sharvey added a comment.


  Remove untracked `.arclint` and `CMakeLists.txt.user`

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14516?vs=38854&id=38859

BRANCH
  add-skip-pager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14516

AFFECTED FILES
  .arclint
  CMakeLists.txt.user
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-window-management.xml
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  tests/plasmasurfacetest.cpp

To: sharvey, hein, #plasma_on_wayland
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14516: Open `skipPager` functionality

[Scott Harvey]

sharvey added a comment.


  There's no functionality to remove files. I'll submit a new diff.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14516

To: sharvey, hein, #plasma_on_wayland
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14516: Open `skipPager` functionality

[Scott Harvey]

sharvey abandoned this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14516

To: sharvey, hein, #plasma_on_wayland
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14520: Open `skipPager` functionality

[Scott Harvey]

sharvey created this revision.
sharvey added reviewers: Plasma on Wayland, hein.
sharvey added a project: Frameworks.
sharvey requested review of this revision.

REVISION SUMMARY
  Open `skipPager` functionality, same as `skipTaskbar`
  REVIEWER NOTE: Several of the autotests are failing, although the build 
itself compiles correctly
  
  - #7: kwayland-testWaylandSeat
  - #23 kwayland-testPlasmaShell
  - #30 kwayland-testSelection

TEST PLAN
  - Apply patch to KWayland, compile
- Run `make tests` to check autotests
- See if #7, #23, #30 fail
  
  Please help resolve.

REPOSITORY
  R127 KWayland

BRANCH
  arcpatch-D14516

REVISION DETAIL
  https://phabricator.kde.org/D14520

AFFECTED FILES
  .arclint
  CMakeLists.txt.user
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-window-management.xml
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  tests/plasmasurfacetest.cpp

To: sharvey, #plasma_on_wayland, hein
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D14520: Open `skipPager` functionality

[Scott Harvey]

sharvey updated this revision to Diff 38863.
sharvey added a comment.


  - Remove wrongly committed files

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14520?vs=38862&id=38863

BRANCH
  arcpatch-D14516

REVISION DETAIL
  https://phabricator.kde.org/D14520

AFFECTED FILES
  .arclint
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-window-management.xml
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  tests/plasmasurfacetest.cpp

To: sharvey, #plasma_on_wayland, hein
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D14520: Open `skipPager` functionality

[Scott Harvey]

sharvey added a comment.


  Okay, a clean copy. Apologies for the mess. I can do the coding, but the 
infrastructure is another story...

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14520

To: sharvey, #plasma_on_wayland, hein
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D14520: Open `skipPager` functionality

[Scott Harvey]

sharvey updated this revision to Diff 38877.
sharvey added a comment.


  - Whitespace fix & remove .arclint

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14520?vs=38863&id=38877

BRANCH
  arcpatch-D14516

REVISION DETAIL
  https://phabricator.kde.org/D14520

AFFECTED FILES
  .arclint
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-window-management.xml
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  tests/plasmasurfacetest.cpp

To: sharvey, #plasma_on_wayland, hein, #plasma, romangg, davidedmundson
Cc: zzag, kde-frameworks-devel, ngraham, michaelh, bruns

D14520: Open `skipPager` functionality

[Scott Harvey]

sharvey marked an inline comment as done.
sharvey added a comment.


  Hopefully `.arclint` is gone for good this time.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14520

To: sharvey, #plasma_on_wayland, hein, #plasma, romangg, davidedmundson
Cc: zzag, kde-frameworks-devel, ngraham, michaelh, bruns

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

This revision was automatically updated to reflect the committed changes.
Closed by commit R121:d4ee26a76a21: Align lock icon with bold message text; 
reduce overall size of dialog (authored by sharvey).

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12311?vs=32758&id=40505

REVISION DETAIL
  https://phabricator.kde.org/D12311

AFFECTED FILES
  AuthDialog.cpp
  AuthDialog.ui

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

[Scott Harvey]

sharvey added a comment.


  +1. Don't use 'em, won't miss 'em.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: sharvey, elvisangelaccio, abetts, rizzitello, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey created this revision.
sharvey added a reviewer: hein.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
sharvey requested review of this revision.

REVISION SUMMARY
  Adding "SkipSwitcher" to API, stemming from discussion in
  BUG 375921. Please see following comments for important information.

REPOSITORY
  R278 KWindowSystem

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

AFFECTED FILES
  autotests/kwindowinfox11test.cpp
  autotests/netwininfotestwm.cpp
  src/kwindowsystem.h
  src/netwm_def.h
  src/platforms/xcb/atoms_p.h
  src/platforms/xcb/netwm.cpp

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a comment.


  NOTE: This is a junior job and a work in progress!
  
  After discussion in BUG 375921 , 
it was decided to add `SkipSwitcher` to the KWin API. It's a junior job and my 
first submission to the KWin/KWayland/KWindowSystem family. @hein has agreed to 
help me out, and I do in fact have a few issues.
  
  - Autotests 7, 8, and 10 are failing, and I'm unable to determine why. It 
appears to be somehow related to the addition of `NET::SkipSwitcher` to the 
list of `NET::States`, but I'm unclear why or how.
  - I know KWin/X11 is feature-frozen, so this may not be relevant any longer.
  
  As Martin wrote in the bug report, this should be straightforward, and it 
seems that way. But clearly the results of the autotests are a problem, which I 
need help resolving.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey created this revision.
sharvey added a reviewer: hein.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
sharvey requested review of this revision.

REVISION SUMMARY
  Adding "SkipSwitcher" to API, as a result of discussion in
  BUG 375921
  
  Depends on / related to D11924 

REPOSITORY
  R127 KWayland

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11925

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-window-management.xml
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  tests/plasmasurfacetest.cpp

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a comment.


  NOTE: This is a junior job and a work in progress!
  
  Following discussion in BUG 375921 
, it was decided to add 
`SkipSwitcher` to the API. This is my first submission to the 
KWin/KWayland/KWindowSystem group, and @hein has graciously offered to help me 
out.
  
  As Martin wrote in the bug report, this should be straightforward, following 
the implementation of `SkipTaskbar`. For the most part, it is - the autotest 
results include
  
PASS   : TestWindowManagement::testRequestsBoolean(skipSwitcher)
  
  However, autotest #6 (`kwayland-testWaylandSurface`) is failing with an 
exception. I got the same exception when testing KWayland without my changes. 
I'm attaching the test output, in case it helps figure out what's wrong. All 
the other tests succeed.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a comment.


  F5787709: kwayland-test-exception.txt 
  KWayland test results / exception report

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey edited the summary of this revision.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey edited the summary of this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added inline comments.

INLINE COMMENTS

> plasmawindowmodel.h:110
> +/**
> + * @since 5.??
> + */

Correct version number? 5.45?

> plasmashell_interface.h:144
> + * in a window switcher
> + * @since 5.??
> + **/

Version 5.45?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added inline comments.

INLINE COMMENTS

> apol wrote in netwm_def.h:492
> add `@since 5.45`?

Will it be `5.45` for KWayland as well? There were `@since` tags in what I 
duplicated, but I wasn't certain which version.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein
Cc: apol, #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a comment.


  In D11924#239922 , @apol wrote:
  
  > 5.44 was just released, so I'd assume it's 5.45 (or we can fix change it 
later if it takes us longer to merge).
  
  
  I took a minute to think it through and came to the conclusion of `5.45` as 
well.
  
  I'll update.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein
Cc: apol, #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey updated this revision to Diff 31307.
sharvey added a comment.


  - Add `@since 5.45` to SkipSwitcher doxygen comments

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11924?vs=31294&id=31307

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

AFFECTED FILES
  autotests/kwindowinfox11test.cpp
  autotests/netwininfotestwm.cpp
  src/kwindowsystem.h
  src/netwm_def.h
  src/platforms/xcb/atoms_p.h
  src/platforms/xcb/netwm.cpp

To: sharvey, hein
Cc: apol, #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey marked an inline comment as done.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein
Cc: apol, #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey updated this revision to Diff 31308.
sharvey added a comment.


  - Add `@since 5.45` tag to SkipSwitcher doxygen comments

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11925?vs=31296&id=31308

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11925

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-window-management.xml
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  tests/plasmasurfacetest.cpp

To: sharvey, hein, graesslin
Cc: graesslin, #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey marked 2 inline comments as done.
sharvey added inline comments.

INLINE COMMENTS

> graesslin wrote in plasmawindowmodel.h:110
> I normally update those just before pushing to the next frameworks release 
> number.

Sorry. Was busy uploading before seeing your reply. Will gladly change again if 
necessary.

> sharvey wrote in plasmashell_interface.h:144
> Version 5.45?

Will change again if necessary.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: graesslin, #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey updated this revision to Diff 31311.
sharvey marked an inline comment as done.
sharvey added a comment.


  - Correct & update version numbers in XML entries

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11925?vs=31308&id=31311

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11925

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-window-management.xml
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  tests/plasmasurfacetest.cpp

To: sharvey, hein, graesslin
Cc: graesslin, #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey marked 5 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: graesslin, #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a comment.


  In D11924#240057 , @graesslin 
wrote:
  
  > In D11924#240045 , @graesslin 
wrote:
  >
  > > I'm not sure whether we can add elements to the states.
  >
  
  
  
  
  > An implementation MAY add new atoms to this list. Implementations without 
extensions MUST ignore any unknown atoms, effectively removing them from the 
list. These extension atoms MUST NOT start with the prefix _NET.
  
  Thanks, Martin. That's very interesting. I'm in the process of making the 
changes. Does the invalid atom name mean KWin would not honor it? Or does it 
"just" mean it's out of compliance with a standard?

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: graesslin, apol, #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a subscriber: ngraham.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey marked an inline comment as done.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: graesslin, apol, #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey updated this revision to Diff 31330.
sharvey added a comment.


  - Add `_KDE` prefix to SkipSwitcher state; correct enum

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11924?vs=31307&id=31330

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

AFFECTED FILES
  autotests/kwindowinfox11test.cpp
  autotests/netwininfotestwm.cpp
  src/kwindowsystem.h
  src/netwm_def.h
  src/platforms/xcb/atoms_p.h
  src/platforms/xcb/netwm.cpp

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey marked 3 inline comments as done.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: Add "SkipSwitcher" to API

[Scott Harvey]

sharvey retitled this revision from "[WIP] Add "SkipSwitcher" to API" to "Add 
"SkipSwitcher" to API".

REPOSITORY
  R278 KWindowSystem

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a comment.


  Thanks, @graesslin. I enjoyed this challenge.
  
  I removed the `[WIP]` tag from the title.

REPOSITORY
  R278 KWindowSystem

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
sharvey requested review of this revision.

REVISION SUMMARY
  Adjust column sizing options so that "last" column is no longer the largest.
  First column (folder/file name & icon) will now occupy the majority of the 
space

TEST PLAN
  - Compile KIO with patch
  - Recompile an application (i.e. Kate), ensuring it will include the patched 
version of KIO
  - File -> Open (and/or File -> Save); select Detailed Tree View option
  - Check that Name column is the widest and occupies most of the space

REPOSITORY
  R241 KIO

BRANCH
  column-widths (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11993

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp

To: sharvey
Cc: #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey edited the summary of this revision.
sharvey added reviewers: ngraham, dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey added a comment.


  F5795938: Screenshot_20180406_145748.png 

  Before (from user bug report)
  
  F5795942: Screenshot_20180406_145619.png 

  After (mine)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey updated this revision to Diff 31517.
sharvey added a comment.


  - Fix incorrect column index

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11993?vs=31516&id=31517

BRANCH
  column-widths (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11993

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp

To: sharvey, ngraham, dfaure
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey marked an inline comment as done.
sharvey added inline comments.

INLINE COMMENTS

> broulik wrote in kdiroperatordetailview.cpp:103
> For first colum you want to set it to `0`, here it blew up the "Size" column 
> to full width

I got misled by my manual adjustment of the columns from previous tests. Thanks 
for catching.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey marked an inline comment as done.
sharvey added a comment.


  In D11993#241387 , @ngraham wrote:
  
  > This patch is a breath of fresh air when using Detailed View or Detailed 
Tree View. You can resize the window and open and close the preview without 
wanting to kill something!
  
  
  Such passion over a file dialog :)

REPOSITORY
  R241 KIO

BRANCH
  column-widths (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey added a comment.


  Give me a moment to comment it out again and re-check. I thought it was, but 
let me run another test.

REPOSITORY
  R241 KIO

BRANCH
  column-widths (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey added a comment.


  In the works...

REPOSITORY
  R241 KIO

BRANCH
  column-widths (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey added a comment.


  I'll give that a test. I'm sure I can find a file (or make one up) with an 
absurdly long filename.
  
  Once I figure out why @ngraham's uploaded diff won't apply... grr.

REPOSITORY
  R241 KIO

BRANCH
  column-widths (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey updated this revision to Diff 31540.
sharvey added a comment.


  - Remove unneeded resize code; ensure other columns fill to contents

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11993?vs=31517&id=31540

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp
  src/filewidgets/kdiroperatordetailview_p.h

To: sharvey, ngraham, dfaure
Cc: fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey added a comment.


  All seems to be well with the removal of the extraneous resizing code.
  
  Here's the result of a test with a ridiculously long filename:
  F5796698: Screenshot_20180406_195204.png 

  
  I think that looks perfectly reasonable.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey added a comment.


  Also, yes - Stretch has disabled the ability to manually resize the columns. 
Columns 1 & 2 are set to fit the size of their contents, while column 0 fills 
all the remaining space. Resizing the dialog results in only the Name column 
(column 0) to change size; the others stay fixed to the size of their contents.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey updated this revision to Diff 31545.
sharvey added a comment.


  - Remove leftover commented-out code; restore variable declaration

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11993?vs=31540&id=31545

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp
  src/filewidgets/kdiroperatordetailview_p.h

To: sharvey, ngraham, dfaure
Cc: fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey marked 3 inline comments as done.
sharvey added inline comments.

INLINE COMMENTS

> ngraham wrote in kdiroperatordetailview_p.h:56
> Don't leave code commented out like this; if it's not used anymore, delete it!

Remnants of testing. Won't do that again.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D12034: Use the more appropriate "two sliders" icon for "configure"

[Scott Harvey]

sharvey added a comment.


  Since I may or may not have been the one to bring this to @ngraham's 
attention, I'll offer my two cents and be done.
  
  - The mini/mono slider icons for widget & panel configs, are, I believe, 
hardcoded and drawn from Breeze.
  - The full-size two-slider icon for System Settings was done by the VDG as 
part of Breeze, so I've got to trust their judgment. An icon theme will change 
this for me if I don't like it.
  - A "gear" icon is cliche, to me. The same with a 
"crossed-wrench-and-screwdriver" design. They've been done to excess.
  - Although I am fairly handy with ~~Illustrator~~ Inkscape, I wasn't part of 
the Breeze design process, so I'm not volunteering any new icons!
  
  I think that above all, consistency is what matters here. If there's an 
agreed-upon change later, this patch will make it that much easier to 
accomplish.
  
  In closing, +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12034

To: ngraham, #vdg, #plasma, #breeze
Cc: abetts, sharvey, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey updated this revision to Diff 31992.
sharvey marked an inline comment as done.
sharvey added a comment.


  - Remove unneeded resize code; ensure other columns fill to contents
  - Remove leftover commented-out code; restore variable declaration

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11993?vs=31545&id=31992

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp
  src/filewidgets/kdiroperatordetailview_p.h

To: sharvey, ngraham, dfaure, #frameworks, broulik
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey added a comment.


  Rebased (I think). Had to manually resolve a conflict. Hopefully it'll land 
now.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure, #frameworks, broulik
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D12160: Rebase onto fresh master

[Scott Harvey]

sharvey created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
sharvey requested review of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12160

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp
  src/filewidgets/kdiroperatordetailview_p.h

To: sharvey
Cc: #frameworks, michaelh, ngraham, bruns

D12160: Rebase onto fresh master

[Scott Harvey]

sharvey added a comment.


  In D12160#245232 , @ngraham wrote:
  
  > Oops, did you mean to create a new revision? Let's just focus on the 
existing one.
  
  
  git and arc are hating me right now

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12160

To: sharvey
Cc: ngraham, #frameworks, michaelh, bruns

D12160: Rebase onto fresh master

[Scott Harvey]

sharvey abandoned this revision.
sharvey added a comment.


  Created by mistake.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12160

To: sharvey
Cc: ngraham, #frameworks, michaelh, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey updated this revision to Diff 32002.
sharvey added a comment.


  - Repairing merge error

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11993?vs=31992&id=32002

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp
  src/filewidgets/kdiroperatordetailview_p.h

To: sharvey, ngraham, dfaure, #frameworks, broulik
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Scott Harvey]

sharvey marked 2 inline comments as done.
sharvey added a comment.


  Merge errors tracked down and eradicated.

INLINE COMMENTS

> ngraham wrote in kdiroperatordetailview.cpp:53
> Uh-oh :)

What is that? (finding it and killing it)

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D11993

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure, #frameworks, broulik
Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  F5812014: Screenshot_20180418_155156.png 

  The dialog seems immune to QT_SCALE_FACTOR=2.0 (because it's launched from a 
separate process?). I don't have a HiDPI display to test on.
  
  I tried different fonts up to 15pt and all is okay. I even tried the nasty 
Windows-style widgets and it's still okay.
  
  I agree the layout is kind of a mess. I can take a shot at reworking it if 
the reviewers think it's worth the effort.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  F5812033: Screenshot_20180418_161500.png 

  The good news is that it still behaves properly with a scaled display.
  
  The bad news is that, due to the `minimumSize` we configured for System 
Settings, I can't get back to the bottom of the Display KCM to reset my screen 
scale. Had to set `QT_SCALE_FACTOR=0.5` and launch `systemsettings5` directly. 
Never a dull moment!

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12077: Show view mode buttons in the open/save dialog's toolbar

[Scott Harvey]

sharvey added a comment.


  +1 for making things easier and prettier.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D12077

REVISION DETAIL
  https://phabricator.kde.org/D12077

To: ngraham, #frameworks, rkflx, #vdg, abetts
Cc: sharvey, rkflx, mmustac, broulik, michaelh, bruns

D12321: Hide file preview when icon is too small

[Scott Harvey]

sharvey added a comment.


  In D12321#249568 , @anemeth wrote:
  
  > (effective screencast)
  
  
  +1 from me, and you beat me to it. 😃  I was just looking through the code 
when Thunderbird chimed that I had new mail.
  
  For the sake of clarification, the reason this works and my attempt in D12094 
 did not, is because this `KToggleAction` 
is, for lack of a better term, unique. There's no second, competing Preview 
action to confuse the issue and be duplicated in Toolbar Preferences. You 
**can** bend a `KToggleAction` to your will; that's pretty straightforward. As 
you can see in @anemeth's patch, toggling it on or off (or disabling it 
entirely) is just a matter of setting the right flags, under the desired 
conditions. My work in D12094  does much of 
the same, but because we were trying to implement two closely-related Find 
actions, we needed two action entries. Here, we only need one. And because 
there's just one to worry about, Alex can make it do any trick he wants, 
without worrying about interfering with or getting confused with another action 
item.
  
  I think this effect is subtle but very classy and polished. We show previews 
at higher sizes by default, but they can be toggled on or off at any time. The 
Preview button is disabled at tiny sizes, because it makes no sense otherwise. 
Looks good.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin
Cc: sharvey, rkflx, ngraham, #frameworks, michaelh, bruns

D12363: Fix autotest regression after adding SkipSwitcher to API

[Scott Harvey]

sharvey added a comment.


  I'm afraid to admit I don't understand it all that well myself. This is my 
first submission to KWindowSystem. It was supposed to be a straightforward case 
of "implement `skipSwitcher` just like `skipTaskbar` is implemented". I believe 
I noted the problems with the autotests in my original submission.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D12363

To: joselema, graesslin, hein, sharvey
Cc: rikmills, #frameworks, michaelh, bruns

D12363: Fix autotest regression after adding SkipSwitcher to API

[Scott Harvey]

sharvey added a comment.


  Also, related patches D11925  and D11926 
 are still open and uncommitted. I'm 
unclear if those missing pieces are affecting the autotests.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D12363

To: joselema, graesslin, hein, sharvey
Cc: rikmills, #frameworks, michaelh, bruns

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a comment.


  Polite "bump" for my reviewers. Please see D12363 
 - the Kubuntu team has had to manually 
disable some autotests stemming from D11924 
.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: graesslin, #frameworks, michaelh, bruns

D12363: Fix autotest regression after adding SkipSwitcher to API

[Scott Harvey]

sharvey added a subscriber: Plasma.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D12363

To: joselema, graesslin, hein, sharvey
Cc: #plasma, rikmills, #frameworks, michaelh, bruns

D11924: Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a subscriber: Plasma.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: #plasma, ngraham, graesslin, apol, #frameworks, michaelh, bruns

D11925: [WIP] Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a subscriber: Plasma.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: #plasma, graesslin, #frameworks, michaelh, bruns

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  Reviewers: as part of my task to redesign and tidy up this dialog box, I'm 
considering removing the Details button in the bottom left corner, along with 
the small pop-open panel that shows additional information. My argument is that 
the info in the Details panel is quite technical (PID's of calling process and 
polkit process) and - in some circumstances - lucid information about the 
program needing authorization. Most of the time, what's coming through is in 
raw form, such as `com.canonical.ubuntu.synaptic` (more or less) instead of 
`Synaptic Package Manager`.
  
  I know carving out UI elements can be controversial, so please give a few +/- 
1's so I know what others think. Maybe some people use it. I don't. But that's 
not a good enough reason to remove it.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  The small-text boilerplate is definitely on the chopping block. @ltoscano 
makes a fine case for keeping the Details section.
  
  @bruns - Thanks for helping me find the source of the incoming messages. I 
hadn't gotten around to searching for them yet, but you saved me some work. 
Thanks!

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a subscriber: stikonas.
sharvey added a comment.


  Semi-related bug from @stikonas, while I'm on dialog duty: 
https://bugs.kde.org/show_bug.cgi?id=393355

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  Hmm, I was actually leaning the other way. Ditch the generic boilerplate and 
keep the app-specific text. I think it's helpful when the dialog tells you why 
it appeared and what app/function is requesting your password.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey updated this revision to Diff 32758.
sharvey added a comment.


  - Merge branch 'master' into align-lock-icon
  - Undo manual resizing of ser combo box & password error box

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12311?vs=32498&id=32758

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

AFFECTED FILES
  AuthDialog.cpp
  AuthDialog.ui

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  Okay, this patch is back to where we started, with nothing changed except 
centering the icon. Hopefully we can commit it now. I'll move the discussion 
over how to redesign the dialog itself to a separate task.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  FYI: I undid the wonky manual UI sizing that @broulik objected to. In 
hindsight, not the best approach.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D11925: Add "SkipSwitcher" to API

[Scott Harvey]

sharvey retitled this revision from "[WIP] Add "SkipSwitcher" to API" to "Add 
"SkipSwitcher" to API".

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: #plasma, graesslin, #frameworks, michaelh, bruns

D11925: Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a subscriber: davidedmundson.
sharvey added a comment.


  Removed `[WIP]` from title at suggestion of @davidedmundson .

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: davidedmundson, #plasma, graesslin, #frameworks, michaelh, bruns

D11925: Add "SkipSwitcher" to API

[Scott Harvey]

sharvey updated this revision to Diff 32906.
sharvey added a comment.


  - Update interface version number; move setSkipSwitcherCallback to end of 
struct

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11925?vs=31311&id=32906

BRANCH
  arcpatch-D11925

REVISION DETAIL
  https://phabricator.kde.org/D11925

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-window-management.xml
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  tests/plasmasurfacetest.cpp

To: sharvey, hein, graesslin
Cc: davidedmundson, #plasma, graesslin, #frameworks, michaelh, bruns

D11925: Add "SkipSwitcher" to API

[Scott Harvey]

sharvey marked 3 inline comments as done.
sharvey added a comment.


  Changes made. KWayland compiles fine now. Thank you.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: davidedmundson, #plasma, graesslin, #frameworks, michaelh, bruns

D11925: Add "SkipSwitcher" to API

[Scott Harvey]

sharvey updated this revision to Diff 32996.
sharvey added a comment.


  - Update PlasmaWindowManagement interface to version 9

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11925?vs=32906&id=32996

BRANCH
  arcpatch-D11925

REVISION DETAIL
  https://phabricator.kde.org/D11925

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-window-management.xml
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  tests/plasmasurfacetest.cpp

To: sharvey, hein, graesslin
Cc: davidedmundson, #plasma, graesslin, #frameworks, michaelh, bruns

D11925: Add "SkipSwitcher" to API

[Scott Harvey]

sharvey marked an inline comment as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: davidedmundson, #plasma, graesslin, #frameworks, michaelh, bruns

D11925: Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a comment.


  In D11925#253074 , @graesslin 
wrote:
  
  > The adjustments in registry.cpp are still missing.
  
  
  I apologize, but I don't know what adjustments to make in `registry.cpp`. In 
all other cases, I followed the templates for `SkipPager` or `SkipTaskbar`. I 
don't find any reference to those two functions in `registry.cpp`.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: davidedmundson, #plasma, graesslin, #frameworks, michaelh, bruns

D11925: Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a comment.


  In D11925#255082 , @lbeltrame 
wrote:
  
  > For now I reverted the commit in kwin to allow building. Once this review 
is merged, it can be re-instated.
  
  
  Thank you for reverting the commit. The one - and only - reason I committed 
it was because it was flagged as approved and ready to land. I apologize for 
the chaos. I'll work with my reviewers to straighten the rest of this out.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: lbeltrame, rikmills, davidedmundson, #plasma, graesslin, #frameworks, 
michaelh, bruns

D11925: Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a dependent revision: D11926: Add "SkipSwitcher" to API.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: lbeltrame, rikmills, davidedmundson, #plasma, graesslin, #frameworks, 
michaelh, bruns

D11925: Add "SkipSwitcher" to API

[Scott Harvey]

sharvey updated this revision to Diff 34636.
sharvey added a comment.


  - Increate interface versions for PlasmaShell and PlasmaWindowManagement

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11925?vs=32996&id=34636

BRANCH
  arcpatch-D11925

REVISION DETAIL
  https://phabricator.kde.org/D11925

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-window-management.xml
  src/client/registry.cpp
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  tests/plasmasurfacetest.cpp

To: sharvey, hein, graesslin
Cc: kde-frameworks-devel, lbeltrame, rikmills, davidedmundson, #plasma, 
graesslin, michaelh, ngraham, bruns

D11925: Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a comment.


  In D11925#265446 , @graesslin 
wrote:
  
  > any update on this? It's just the version increase in registry.cpp which is 
missing...
  
  
  Done. I was unclear as to what needed to change. I got a little outside help 
from @hein and `registry.cpp` is update to match the XML file.
  
  Once this is approved, is it safe to land along with D11296 
?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: kde-frameworks-devel, lbeltrame, rikmills, davidedmundson, #plasma, 
graesslin, michaelh, ngraham, bruns

D11925: Add "SkipSwitcher" to API

[Scott Harvey]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:10b00a219e9f: Add "SkipSwitcher" to API 
(authored by sharvey).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11925?vs=34636&id=34654

REVISION DETAIL
  https://phabricator.kde.org/D11925

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-window-management.xml
  src/client/registry.cpp
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  tests/plasmasurfacetest.cpp

To: sharvey, hein, graesslin
Cc: kde-frameworks-devel, lbeltrame, rikmills, davidedmundson, #plasma, 
graesslin, michaelh, ngraham, bruns