Unable to start kcmshell5 * after installing kf5 successfully
Hello
I've just build the KF5 using instructions given on
community.kde.org/framework/building using build-kdesrc script.
the build was successful but I'm unable to run kcmshell5 *.
when I execute command an empty dialog box appears as attached with mail.
and it gives error :
"Couldn't start kded5 from org.kde.kded5.service:
QDBusError("org.freedesktop.DBus.Error.ServiceUnknown", "The name
org.kde.kded5 was not provided by any .service files")
Trying to open ksycoca from "/home/amourphious/.cache5/ksycoca5"
"Theme tree: (Oxygen)""
also command kbuildsycoca5 gives output :
kbuildsycoca5 running...
Trying to open ksycoca from "/home/amourphious/.cache5/ksycoca5"
Reusing existing ksycoca
Recreating ksycoca file ("/home/amourphious/.cache5/ksycoca5", version 230)
The desktop entry file "plasma-wallpaper.desktop" has Type= "ServiceType"
instead of "Application" or "Service"
Invalid Service : "plasma-wallpaper.desktop"
Still in the time dict (i.e. deleted files) ("apps")
Menu "applications-kmenuedit.menu" not found.
Saving
Emitting notifyDatabaseChanged ("apps")
any ideas about how to get it to work ?
Thanks
Regards
Shivam
<>___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Porting keyboard module to KF5
Hi I've ported most of the module to KF5 by building it and resolving the warnings indicating deprecated statements and errors I've pushed the changes to 'amourphious/porting' branch. the only warning left is : In file included from /home/amourphious/framework5/kf5d/kde-workspace/kcontrol/keyboard/x11_helper.cpp:19:0: /home/amourphious/framework5/kf5d/kde-workspace/kcontrol/keyboard/x11_helper.h:29:2: warning: #warning XEventNotifier needs porting to QAbstractNativeEventFilter [-Wcpp] for this I think I've to re write this XEventNotifier class with QAbstractNativeEventFilter as base class and re-implementing its only vortual function, but I have no idea about what XEventNotifier does. If you are having any clues about this class and how to port it, I would be obliged to hear the solution. cheers ! Thanks -- Regards Shivam Makkar amourphious.appspot.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[error] Snapshot for krunner extracted successfully, but failed to complete initrepo.sh
Hi I'm not able to build framework 5 due to some update error in Krunner, is there any manual method to build it ? I'm also getting Cmake error while installing kwallet, the error seems to be like some git conflict in cmaketext in kwallet. Am I the only one facing these problems ? :P Please help ! Thanking you cheers ! -- Regards Shivam Makkar amourphious.appspot.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [error] Snapshot for krunner extracted successfully, but failed to complete initrepo.sh
On Fri, Feb 14, 2014 at 4:11 AM, Michael Pyne wrote: > On Thu, February 13, 2014 02:29:21 Shivam Makkar wrote: > > Hi > > > > I'm not able to build framework 5 due to some update error in Krunner, is > > there any manual method to build it ? > > You can pass --no-snapshots to the kdesrc-build command line to disable the > use of a snapshot. kdesrc-build will then use the slightly-slower "git > clone" > command. > > This worked ! Thanks for the help ! > Probably easiest to just remove the kwallet source directory and let > kdesrc- > build regenerate, as there was a rename of some kwallet-related > repositories > recently which is probably causing this. > > > Am I the only one facing these problems ? :P > > I think the rest of us were paying attention to the mailing list > announcement > about the renames. ;) > seems like have to pay more attention to the mailing lists :P I successfully built the KF5, Thaks again ! when I try to run $ kcmshell5 keyboard #(or any other kcm module) I get a window saying : Could not find plugin 'keybaord' for application 'kcmshell5' possible reasons : * An error occured during your last KDE upgrade leaving an orphaned control module * you have old third party modules lying around when I run command $ which kcmshell5 i get : /home/amourphious/kde5/inst/bin and this is the debug output in terminal (which seems not to be an error) : kcmshell5(9959)/(default) KSycocaPrivate::openDatabase: Trying to open ksycoca from "/home/amourphious/.cache5/ksycoca5" kcmshell5(9959)/(default) KIconLoaderPrivate::initIconThemes: "Theme tree: (Oxygen)" Can you please tell me what is going wrong ! I would really appreciate any sort of help ! :) Thanking you ! -- Regards Shivam Makkar amourphious.appspot.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [error] Snapshot for krunner extracted successfully, but failed to complete initrepo.sh
Hi I know I'm popping from no where ( that too on weekend ) but can you please tell me why I'm getting this (http://i.imgur.com/bV2sDqS.jpg / http://imgur.com/bV2sDqS) dialog box whenever I run Kcmshell5 keyboard or any other kcm module. I think the environment is set fine cause I'm able to run Kate inatalled by the KF5 build. hope I would get it fixed soon :) Thanking you ! cheers ! On Sun, Feb 16, 2014 at 7:00 AM, Michael Pyne wrote: > On Sat, February 15, 2014 20:35:28 David Faure wrote: > > On Thursday 13 February 2014 17:41:26 Michael Pyne wrote: > > > In the meantime I will fix kdesrc-build to fallback automatically to > > > git-clone like it's supposed to. > > > > There's two cases: > > > > - snapshot exists, but is broken. This is the current case with krunner's > > snapshot: > > The snapshot was definitely broken (and thanks for emailing Ben, I forgot), > but kdesrc-build was supposed to work in that case too. :) > > It was supposed to delete the broken source directory and then fallback to > git-clone. Instead my recent change had deleted the source directory and > then > thrown an exception to stop the update process for that module completely. > > It should Do the Right Thing in either case now. > > Regards, > - Michael Pyne > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel > -- Regards Shivam Makkar amourphious.appspot.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
configuration file found with version 4.96.0 but version 5.2 is required by the KF5 buld
Hi ! I was trying to build Kde-Framework 5 and got following CMake error while executing ./kdesrc-build. the error produces every time, for Kde-workspace and kde-rumtime, regarding config file found but with older version. *CMake Error at /home/amourphious/kf5/inst/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:52 (find_package):* * Could not find a configuration file for package "KF5Pty" that is compatible* * with requested version "5.2".* * The following configuration files were considered but not accepted:* * /home/amourphious/kf5/inst/lib/x86_64-linux-gnu/cmake/KF5Pty/KF5PtyConfig.cmake, version: 4.96.0* *Call Stack (most recent call first):* * /home/amourphious/kf5/inst/lib/x86_64-linux-gnu/cmake/KF5Su/KF5SuConfig.cmake:58 (find_dependency)* * /home/amourphious/kf5/inst/lib/x86_64-linux-gnu/cmake/KF5/KF5Config.cmake:28 (find_package)* * CMakeLists.txt:50 (find_package)* Am I doing something wrong or should I try to build again after sometime ? or is there any other solution, which I will be glad to hear :) Thanking you ! cheers -- Regards Shivam Makkar amourphious.appspot.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: CMake error compiling kde-runtime
On Sun, Feb 23, 2014 at 3:58 PM, David Faure wrote:
> On Sunday 23 February 2014 11:05:16 David Gil Oliva wrote:
> > CMake Error at
> > /home/david/KF5/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:52
> > (find_package):
> > Could not find a configuration file for package "KF5DesignerPlugin"
> that
> > is
> > compatible with requested version "5.2".
>
> I just analyzed and reported this error on kde-buildsystem.
>
> For now, "git checkout v2.8.12.2" in your cmake git repo, or apply this
>
> diff --git a/kf5-frameworks-build-include b/kf5-frameworks-build-include
> index df4498a..c1cf637 100644
> --- a/kf5-frameworks-build-include
> +++ b/kf5-frameworks-build-include
> @@ -13,6 +13,8 @@
>
> module cmake-git
> repository git://cmake.org/cmake.git
> +# Workaround for broken find_dependency in cmake master right now
> +tag v2.8.12.2
> end module
>
> module libdbusmenu-qt
>
or you can apply the attached patch ( thank to alex )
I ran into the same problem
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE, in particular KDE Frameworks 5
>
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>
--
Regards
Shivam Makkar
amourphious.appspot.com
From d9da7a712d331e647d94fc12162e2c4df29ca7eb Mon Sep 17 00:00:00 2001
From: Alex Merry
Date: Sat, 22 Feb 2014 13:35:14 +
Subject: [PATCH] Fix settings of the version variable of find_dependency macro
It should be reset before use, as this is a macro, and the test should
be against ARGV1, not its value.
---
Modules/CMakeFindDependencyMacro.cmake | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Modules/CMakeFindDependencyMacro.cmake b/Modules/CMakeFindDependencyMacro.cmake
index 0f1f56d..6f7dbe8 100644
--- a/Modules/CMakeFindDependencyMacro.cmake
+++ b/Modules/CMakeFindDependencyMacro.cmake
@@ -29,7 +29,8 @@
macro(find_dependency dep)
if (NOT ${dep}_FOUND)
-if (${ARGV1})
+set(version)
+if (ARGV1)
set(version ${ARGV1})
endif()
set(exact_arg)
--
1.9.0
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: configuration file found with version 4.96.0 but version 5.2 is required by the KF5 buld
On Sat, Feb 22, 2014 at 9:01 PM, Alex Merry wrote: > On 21/02/14 16:01, Shivam Makkar wrote: > > Hi ! > > > > I was trying to build Kde-Framework 5 and got following CMake error > > while executing ./kdesrc-build. > > > > the error produces every time, for Kde-workspace and kde-rumtime, > > regarding config file found but with older version. > > > > /CMake Error at > > > /home/amourphious/kf5/inst/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:52 > > (find_package):/ > > / Could not find a configuration file for package "KF5Pty" that is > > compatible/ > > / with requested version "5.2"./ > > This is a bug in CMake. I've posted a patch to the cmake-developers > list. You can wait for that to be applied, apply it yourself > (attached), or use an older version of CMake (anything from the 2.8.12 > series is fine). > *Thanks Alex :)* [image: Inline image 1] > > Alex > > > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel > > -- Regards Shivam Makkar amourphious.appspot.com <>___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
how to write kded module in framework 5
Hello fellow developers ! :) I am noob in kde and hacking keyboard module these days ! I tried to instantiate object of class keyboardDaemon and I got this error : In file included from /home/amourphious/kde-workspace/kcontrol/keyboard/kcm_keyboard.cpp:37:0: /home/amourphious/kde-workspace/kcontrol/keyboard/keyboard_daemon.h:27:24: fatal error: kdedmodule.h: No such file or directory #include I using instead of which resulted into : In file included from /home/amourphious/kde-workspace/kcontrol/keyboard/keyboard_daemon.h:23:0, from /home/amourphious/kde-workspace/kcontrol/keyboard/kcm_keyboard.cpp:37: /home/amourphious/kf5/inst/include/KF5/KDE4Support/KDE/KDEDModule:1:24: fatal error: kdedmodule.h: No such file or directory #include in Kf5 install directory the kdedmodule.h and KDEDModule can be found at /home/amourphious/kf5/inst/include/KF5/KDBusAddons but code is looking at /home/amourphious/kf5/inst/include/KF5/KDE4Support/KDE/KDEDModule *is there any different way to write kded module in framework 5 ?oris there a way by which I can make the code look at right place to find kdedmodule ?or am I doing something wrong ?* keyboard module is not functioning properly due to this. Thanking you ! Regards Shivam Makkar amourphious.appspot.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: how to write kded module in framework 5
On Mon, Mar 17, 2014 at 4:24 PM, Alex Merry wrote: > On 15/03/14 22:55, Shivam Makkar wrote: > > Hello fellow developers ! :) > > > > I am noob in kde and hacking keyboard module these days ! > > > > I tried to instantiate object of class keyboardDaemon and I got this > > error : > > > > In file included from > > /home/amourphious/kde-workspace/kcontrol/keyboard/kcm_keyboard.cpp:37:0: > > > /home/amourphious/kde-workspace/kcontrol/keyboard/keyboard_daemon.h:27:24: > > fatal error: kdedmodule.h: No such file or directory > > #include > > Have you got KF5::DBusAddons in your target_link_libraries() for this code? > > Thanks ! that did the job ! > Alex > also I want to know how can i start kded5 when I run command kded5 or kdeinit5 i get kded5(16341)/(default) QXcbSessionManager::QXcbSessionManager: Qt: Session management error: networkIdsList argument is NULL is there any debug dialog (kdebugdialog) for framework 5 too ? -- Regards Shivam Makkar amourphious.appspot.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: how to write kded module in framework 5
On Tue, Mar 18, 2014 at 5:20 AM, Alex Merry wrote: > On 17/03/14 19:35, Shivam Makkar wrote: > > also I want to know how can i start kded5 > > > > when I run command > > > > kded5 > > or > > kdeinit5 > > > > i get > > > > kded5(16341)/(default) QXcbSessionManager::QXcbSessionManager: Qt: > > Session management error: networkIdsList argument is NULL > > Hmm... you might want to try > eval `dbus-launch` > before running kded5 or kdeinit5, so that it doesn't interfere with your > current session. > I am using that command ! also is there any other module I need to build to see the changes I've made in keyboard module's daemon ? (keyboard daemon.cpp) -- Regards Shivam Makkar amourphious.appspot.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 118365: Porting keyboard module to framework 5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118365/ --- Review request for kde-workspace, KDE Frameworks and Andriy Rysin. Repository: plasma-desktop Description --- Removed deprecated statements and ported keyboard module to framework 5. Diffs - kcms/keyboard/bindings.cpp 21541e0 kcms/keyboard/flags.cpp b768586 kcms/keyboard/kcm_keyboard.ui 0062d1c kcms/keyboard/kcm_keyboard_widget.cpp 21685eb kcms/keyboard/kcmmisc.h 411bdd2 kcms/keyboard/kcmmisc.cpp 6f787ea kcms/keyboard/kcmmiscwidget.ui 37fbaf4 kcms/keyboard/keyboard_config.cpp f3ff97c kcms/keyboard/keyboard_daemon.cpp 25673b0 kcms/keyboard/keyboard_hardware.cpp dca49b6 kcms/keyboard/layout_memory.cpp 9e72361 kcms/keyboard/layout_memory_persister.cpp 8a6118a kcms/keyboard/layouts_menu.cpp fd436c4 kcms/keyboard/xinput_helper.h 343d7ed kcms/keyboard/xinput_helper.cpp b311579 Diff: https://git.reviewboard.kde.org/r/118365/diff/ Testing --- Thanks, shivam makkar ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118365: Porting keyboard module to framework 5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118365/ --- (Updated May 27, 2014, 8:48 p.m.) Review request for kde-workspace, KDE Frameworks and Andriy Rysin. Repository: plasma-desktop Description --- Removed deprecated statements and ported keyboard module to framework 5. Diffs (updated) - kcms/keyboard/bindings.cpp 21541e0 kcms/keyboard/flags.cpp b768586 kcms/keyboard/kcm_keyboard.ui 0062d1c kcms/keyboard/kcm_keyboard_widget.cpp 21685eb kcms/keyboard/kcmmisc.h 411bdd2 kcms/keyboard/kcmmisc.cpp 6f787ea kcms/keyboard/kcmmiscwidget.ui 37fbaf4 kcms/keyboard/keyboard_config.cpp f3ff97c kcms/keyboard/keyboard_daemon.cpp 25673b0 kcms/keyboard/keyboard_hardware.cpp dca49b6 kcms/keyboard/layout_memory.cpp 9e72361 kcms/keyboard/layout_memory_persister.cpp 8a6118a kcms/keyboard/layouts_menu.cpp fd436c4 kcms/keyboard/xinput_helper.h 343d7ed kcms/keyboard/xinput_helper.cpp b311579 Diff: https://git.reviewboard.kde.org/r/118365/diff/ Testing --- Thanks, shivam makkar ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118365: Porting keyboard module to framework 5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118365/ --- (Updated May 27, 2014, 8:50 p.m.) Status -- This change has been discarded. Review request for kde-workspace, KDE Frameworks and Andriy Rysin. Repository: plasma-desktop Description --- Removed deprecated statements and ported keyboard module to framework 5. Diffs - kcms/keyboard/bindings.cpp 21541e0 kcms/keyboard/flags.cpp b768586 kcms/keyboard/kcm_keyboard.ui 0062d1c kcms/keyboard/kcm_keyboard_widget.cpp 21685eb kcms/keyboard/kcmmisc.h 411bdd2 kcms/keyboard/kcmmisc.cpp 6f787ea kcms/keyboard/kcmmiscwidget.ui 37fbaf4 kcms/keyboard/keyboard_config.cpp f3ff97c kcms/keyboard/keyboard_daemon.cpp 25673b0 kcms/keyboard/keyboard_hardware.cpp dca49b6 kcms/keyboard/layout_memory.cpp 9e72361 kcms/keyboard/layout_memory_persister.cpp 8a6118a kcms/keyboard/layouts_menu.cpp fd436c4 kcms/keyboard/xinput_helper.h 343d7ed kcms/keyboard/xinput_helper.cpp b311579 Diff: https://git.reviewboard.kde.org/r/118365/diff/ Testing --- Thanks, shivam makkar ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 118366: Porting keyboard module to Framework5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- Review request for kde-workspace, KDE Frameworks and Andriy Rysin. Repository: plasma-desktop Description --- Removed deprecated statements and ported keyboard module to framework 5. Diffs - kcms/keyboard/bindings.cpp 21541e0 kcms/keyboard/flags.cpp b768586 kcms/keyboard/kcm_keyboard.ui 0062d1c kcms/keyboard/kcm_keyboard_widget.cpp 21685eb kcms/keyboard/kcmmisc.h 411bdd2 kcms/keyboard/kcmmisc.cpp 6f787ea kcms/keyboard/kcmmiscwidget.ui 37fbaf4 kcms/keyboard/keyboard_config.cpp f3ff97c kcms/keyboard/keyboard_daemon.cpp 25673b0 kcms/keyboard/keyboard_hardware.cpp dca49b6 kcms/keyboard/layout_memory.cpp 9e72361 kcms/keyboard/layout_memory_persister.cpp 8a6118a kcms/keyboard/layouts_menu.cpp fd436c4 kcms/keyboard/xinput_helper.h 343d7ed kcms/keyboard/xinput_helper.cpp b311579 Diff: https://git.reviewboard.kde.org/r/118366/diff/ Testing --- Thanks, shivam makkar ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118366: Porting keyboard module to Framework5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated May 27, 2014, 9:02 p.m.) Review request for kde-workspace, KDE Frameworks and Andriy Rysin. Repository: plasma-desktop Description --- Removed deprecated statements and ported keyboard module to framework 5. Diffs (updated) - kcms/keyboard/bindings.cpp 21541e0 kcms/keyboard/flags.cpp b768586 kcms/keyboard/kcm_keyboard.ui 0062d1c kcms/keyboard/kcm_keyboard_widget.cpp 21685eb kcms/keyboard/kcmmisc.h 411bdd2 kcms/keyboard/kcmmisc.cpp 6f787ea kcms/keyboard/kcmmiscwidget.ui 37fbaf4 kcms/keyboard/keyboard_config.cpp f3ff97c kcms/keyboard/keyboard_daemon.cpp 25673b0 kcms/keyboard/keyboard_hardware.cpp dca49b6 kcms/keyboard/layout_memory.cpp 9e72361 kcms/keyboard/layout_memory_persister.cpp 8a6118a kcms/keyboard/layouts_menu.cpp fd436c4 kcms/keyboard/xinput_helper.h 343d7ed kcms/keyboard/xinput_helper.cpp b311579 Diff: https://git.reviewboard.kde.org/r/118366/diff/ Testing --- Thanks, shivam makkar ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118366: Porting keyboard module to Framework5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated May 29, 2014, 7:53 a.m.) Review request for kde-workspace, KDE Frameworks and Andriy Rysin. Repository: plasma-desktop Description --- Removed deprecated statements and ported keyboard module to framework 5. Diffs (updated) - kcms/keyboard/bindings.cpp 21541e0 kcms/keyboard/bindings.cpp 21541e0 kcms/keyboard/flags.cpp b768586 kcms/keyboard/flags.cpp b768586 kcms/keyboard/flags.cpp 6d25443 kcms/keyboard/kcm_keyboard.ui 0062d1c kcms/keyboard/kcm_keyboard.ui 0062d1c kcms/keyboard/kcm_keyboard_widget.cpp 21685eb kcms/keyboard/kcm_keyboard_widget.cpp 21685eb kcms/keyboard/kcmmisc.h 411bdd2 kcms/keyboard/kcmmisc.h 411bdd2 kcms/keyboard/kcmmisc.cpp 6f787ea kcms/keyboard/kcmmisc.cpp 6f787ea kcms/keyboard/kcmmisc.cpp d14ac2e kcms/keyboard/kcmmiscwidget.ui 37fbaf4 kcms/keyboard/kcmmiscwidget.ui 37fbaf4 kcms/keyboard/keyboard_config.cpp f3ff97c kcms/keyboard/keyboard_config.cpp f3ff97c kcms/keyboard/keyboard_config.cpp 49f059c kcms/keyboard/keyboard_daemon.cpp 25673b0 kcms/keyboard/keyboard_daemon.cpp 25673b0 kcms/keyboard/keyboard_hardware.cpp dca49b6 kcms/keyboard/keyboard_hardware.cpp dca49b6 kcms/keyboard/layout_memory.cpp 9e72361 kcms/keyboard/layout_memory.cpp 9e72361 kcms/keyboard/layout_memory_persister.cpp 8a6118a kcms/keyboard/layout_memory_persister.cpp 8a6118a kcms/keyboard/layouts_menu.cpp fd436c4 kcms/keyboard/layouts_menu.cpp fd436c4 kcms/keyboard/layouts_menu.cpp e357c6a kcms/keyboard/x11_helper.h 719b13f kcms/keyboard/x11_helper.cpp 0e2806e kcms/keyboard/xinput_helper.h 343d7ed kcms/keyboard/xinput_helper.h 343d7ed kcms/keyboard/xinput_helper.cpp b311579 kcms/keyboard/xinput_helper.cpp b311579 kcms/keyboard/xinput_helper.cpp b245e91 Diff: https://git.reviewboard.kde.org/r/118366/diff/ Testing --- Thanks, shivam makkar ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118366: Porting keyboard module to Framework5
> On May 28, 2014, 6:10 a.m., Martin Gräßlin wrote: > > kcms/keyboard/kcmmisc.cpp, lines 77-78 > > <https://git.reviewboard.kde.org/r/118366/diff/2/?file=275630#file275630line77> > > > > for new connects I would use the new compile time checked syntax. I tried it but it was giving some error "unable to deduce function pointer " > On May 28, 2014, 6:10 a.m., Martin Gräßlin wrote: > > kcms/keyboard/xinput_helper.cpp, line 95 > > <https://git.reviewboard.kde.org/r/118366/diff/2/?file=275639#file275639line95> > > > > removing the event doesn't remove the fact that this method is not yet > > ported. See the #if 0 which indicates that this code has not been adjusted > > to xcb yet. Will be porting it later ! - shivam --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/#review58618 ------- On May 29, 2014, 7:53 a.m., shivam makkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118366/ > --- > > (Updated May 29, 2014, 7:53 a.m.) > > > Review request for kde-workspace, KDE Frameworks and Andriy Rysin. > > > Repository: plasma-desktop > > > Description > --- > > Removed deprecated statements and ported keyboard module to framework 5. > > > Diffs > - > > kcms/keyboard/bindings.cpp 21541e0 > kcms/keyboard/bindings.cpp 21541e0 > kcms/keyboard/flags.cpp b768586 > kcms/keyboard/flags.cpp b768586 > kcms/keyboard/flags.cpp 6d25443 > kcms/keyboard/kcm_keyboard.ui 0062d1c > kcms/keyboard/kcm_keyboard.ui 0062d1c > kcms/keyboard/kcm_keyboard_widget.cpp 21685eb > kcms/keyboard/kcm_keyboard_widget.cpp 21685eb > kcms/keyboard/kcmmisc.h 411bdd2 > kcms/keyboard/kcmmisc.h 411bdd2 > kcms/keyboard/kcmmisc.cpp 6f787ea > kcms/keyboard/kcmmisc.cpp 6f787ea > kcms/keyboard/kcmmisc.cpp d14ac2e > kcms/keyboard/kcmmiscwidget.ui 37fbaf4 > kcms/keyboard/kcmmiscwidget.ui 37fbaf4 > kcms/keyboard/keyboard_config.cpp f3ff97c > kcms/keyboard/keyboard_config.cpp f3ff97c > kcms/keyboard/keyboard_config.cpp 49f059c > kcms/keyboard/keyboard_daemon.cpp 25673b0 > kcms/keyboard/keyboard_daemon.cpp 25673b0 > kcms/keyboard/keyboard_hardware.cpp dca49b6 > kcms/keyboard/keyboard_hardware.cpp dca49b6 > kcms/keyboard/layout_memory.cpp 9e72361 > kcms/keyboard/layout_memory.cpp 9e72361 > kcms/keyboard/layout_memory_persister.cpp 8a6118a > kcms/keyboard/layout_memory_persister.cpp 8a6118a > kcms/keyboard/layouts_menu.cpp fd436c4 > kcms/keyboard/layouts_menu.cpp fd436c4 > kcms/keyboard/layouts_menu.cpp e357c6a > kcms/keyboard/x11_helper.h 719b13f > kcms/keyboard/x11_helper.cpp 0e2806e > kcms/keyboard/xinput_helper.h 343d7ed > kcms/keyboard/xinput_helper.h 343d7ed > kcms/keyboard/xinput_helper.cpp b311579 > kcms/keyboard/xinput_helper.cpp b311579 > kcms/keyboard/xinput_helper.cpp b245e91 > > Diff: https://git.reviewboard.kde.org/r/118366/diff/ > > > Testing > --- > > > Thanks, > > shivam makkar > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118366: Porting keyboard module to Framework5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated May 31, 2014, 7:27 p.m.) Review request for kde-workspace, KDE Frameworks and Andriy Rysin. Repository: plasma-desktop Description --- Removed deprecated statements and ported keyboard module to framework 5. Diffs (updated) - kcms/keyboard/bindings.cpp 21541e0 kcms/keyboard/bindings.cpp 21541e0 kcms/keyboard/flags.cpp b768586 kcms/keyboard/flags.cpp b768586 kcms/keyboard/flags.cpp 6d25443 kcms/keyboard/flags.cpp 3fb98e5 kcms/keyboard/kcm_keyboard.ui 0062d1c kcms/keyboard/kcm_keyboard.ui 0062d1c kcms/keyboard/kcm_keyboard_widget.cpp 21685eb kcms/keyboard/kcm_keyboard_widget.cpp 21685eb kcms/keyboard/kcmmisc.h 411bdd2 kcms/keyboard/kcmmisc.h 411bdd2 kcms/keyboard/kcmmisc.cpp 6f787ea kcms/keyboard/kcmmisc.cpp 6f787ea kcms/keyboard/kcmmisc.cpp d14ac2e kcms/keyboard/kcmmiscwidget.ui 37fbaf4 kcms/keyboard/kcmmiscwidget.ui 37fbaf4 kcms/keyboard/keyboard_config.cpp f3ff97c kcms/keyboard/keyboard_config.cpp f3ff97c kcms/keyboard/keyboard_config.cpp 49f059c kcms/keyboard/keyboard_daemon.cpp 25673b0 kcms/keyboard/keyboard_daemon.cpp 25673b0 kcms/keyboard/keyboard_hardware.cpp dca49b6 kcms/keyboard/keyboard_hardware.cpp dca49b6 kcms/keyboard/layout_memory.cpp 9e72361 kcms/keyboard/layout_memory.cpp 9e72361 kcms/keyboard/layout_memory_persister.cpp 8a6118a kcms/keyboard/layout_memory_persister.cpp 8a6118a kcms/keyboard/layouts_menu.cpp fd436c4 kcms/keyboard/layouts_menu.cpp fd436c4 kcms/keyboard/layouts_menu.cpp e357c6a kcms/keyboard/x11_helper.h 719b13f kcms/keyboard/x11_helper.cpp 0e2806e kcms/keyboard/xinput_helper.h 343d7ed kcms/keyboard/xinput_helper.h 343d7ed kcms/keyboard/xinput_helper.cpp b311579 kcms/keyboard/xinput_helper.cpp b311579 kcms/keyboard/xinput_helper.cpp b245e91 kcms/keyboard/xinput_helper.cpp 980338e Diff: https://git.reviewboard.kde.org/r/118366/diff/ Testing --- Thanks, shivam makkar ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118366: Porting keyboard module to Framework5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated June 19, 2014, 6:48 p.m.) Review request for kde-workspace, KDE Frameworks and Andriy Rysin. Repository: plasma-desktop Description --- Removed deprecated statements and ported keyboard module to framework 5. Diffs - kcms/keyboard/bindings.cpp 21541e0 kcms/keyboard/bindings.cpp 21541e0 kcms/keyboard/flags.cpp b768586 kcms/keyboard/flags.cpp b768586 kcms/keyboard/flags.cpp 6d25443 kcms/keyboard/flags.cpp 3fb98e5 kcms/keyboard/kcm_keyboard.ui 0062d1c kcms/keyboard/kcm_keyboard.ui 0062d1c kcms/keyboard/kcm_keyboard_widget.cpp 21685eb kcms/keyboard/kcm_keyboard_widget.cpp 21685eb kcms/keyboard/kcmmisc.h 411bdd2 kcms/keyboard/kcmmisc.h 411bdd2 kcms/keyboard/kcmmisc.cpp 6f787ea kcms/keyboard/kcmmisc.cpp 6f787ea kcms/keyboard/kcmmisc.cpp d14ac2e kcms/keyboard/kcmmiscwidget.ui 37fbaf4 kcms/keyboard/kcmmiscwidget.ui 37fbaf4 kcms/keyboard/keyboard_config.cpp f3ff97c kcms/keyboard/keyboard_config.cpp f3ff97c kcms/keyboard/keyboard_config.cpp 49f059c kcms/keyboard/keyboard_daemon.cpp 25673b0 kcms/keyboard/keyboard_daemon.cpp 25673b0 kcms/keyboard/keyboard_hardware.cpp dca49b6 kcms/keyboard/keyboard_hardware.cpp dca49b6 kcms/keyboard/layout_memory.cpp 9e72361 kcms/keyboard/layout_memory.cpp 9e72361 kcms/keyboard/layout_memory_persister.cpp 8a6118a kcms/keyboard/layout_memory_persister.cpp 8a6118a kcms/keyboard/layouts_menu.cpp fd436c4 kcms/keyboard/layouts_menu.cpp fd436c4 kcms/keyboard/layouts_menu.cpp e357c6a kcms/keyboard/x11_helper.h 719b13f kcms/keyboard/x11_helper.cpp 0e2806e kcms/keyboard/xinput_helper.h 343d7ed kcms/keyboard/xinput_helper.h 343d7ed kcms/keyboard/xinput_helper.cpp b311579 kcms/keyboard/xinput_helper.cpp b311579 kcms/keyboard/xinput_helper.cpp b245e91 kcms/keyboard/xinput_helper.cpp 980338e Diff: https://git.reviewboard.kde.org/r/118366/diff/ Testing --- Thanks, shivam makkar ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118366: Porting keyboard module to Framework5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated June 20, 2014, 9:24 p.m.) Review request for kde-workspace, KDE Frameworks and Andriy Rysin. Repository: plasma-desktop Description --- Removed deprecated statements and ported keyboard module to framework 5. Diffs (updated) - kcms/keyboard/bindings.h c576455 kcms/keyboard/bindings.cpp 21541e0 kcms/keyboard/bindings.cpp 21541e0 kcms/keyboard/bindings.cpp 325dd3c kcms/keyboard/flags.cpp b768586 kcms/keyboard/flags.cpp b768586 kcms/keyboard/flags.cpp 6d25443 kcms/keyboard/flags.cpp 3fb98e5 kcms/keyboard/iso_codes.h 6a33739 kcms/keyboard/iso_codes.cpp 3e3b210 kcms/keyboard/kcm_keyboard.cpp 42b7fe4 kcms/keyboard/kcm_keyboard.ui 0062d1c kcms/keyboard/kcm_keyboard.ui 0062d1c kcms/keyboard/kcm_keyboard_widget.h 657ddda kcms/keyboard/kcm_keyboard_widget.cpp 21685eb kcms/keyboard/kcm_keyboard_widget.cpp 21685eb kcms/keyboard/kcm_keyboard_widget.cpp 2840e26 kcms/keyboard/kcm_keyboard_widget.cpp 9b0f584 kcms/keyboard/kcmmisc.h 411bdd2 kcms/keyboard/kcmmisc.h 411bdd2 kcms/keyboard/kcmmisc.h 1183fb1 kcms/keyboard/kcmmisc.cpp 6f787ea kcms/keyboard/kcmmisc.cpp 6f787ea kcms/keyboard/kcmmisc.cpp d14ac2e kcms/keyboard/kcmmisc.cpp 3327ce5 kcms/keyboard/kcmmiscwidget.ui 37fbaf4 kcms/keyboard/kcmmiscwidget.ui 37fbaf4 kcms/keyboard/keyboard_config.h b86418d kcms/keyboard/keyboard_config.cpp f3ff97c kcms/keyboard/keyboard_config.cpp f3ff97c kcms/keyboard/keyboard_config.cpp 49f059c kcms/keyboard/keyboard_config.cpp a227a34 kcms/keyboard/keyboard_daemon.h 4edb968 kcms/keyboard/keyboard_daemon.cpp 25673b0 kcms/keyboard/keyboard_daemon.cpp 25673b0 kcms/keyboard/keyboard_daemon.cpp dcda1ec kcms/keyboard/keyboard_hardware.cpp dca49b6 kcms/keyboard/keyboard_hardware.cpp dca49b6 kcms/keyboard/keyboard_hardware.cpp 9a61159 kcms/keyboard/layout_memory.h df8568c kcms/keyboard/layout_memory.cpp 9e72361 kcms/keyboard/layout_memory.cpp 9e72361 kcms/keyboard/layout_memory.cpp d78e677 kcms/keyboard/layout_memory_persister.h 8c4b3c5 kcms/keyboard/layout_memory_persister.cpp 8a6118a kcms/keyboard/layout_memory_persister.cpp 8a6118a kcms/keyboard/layout_memory_persister.cpp 1dba024 kcms/keyboard/layout_widget.cpp e67b2d7 kcms/keyboard/layouts_menu.h db2f3ff kcms/keyboard/layouts_menu.cpp fd436c4 kcms/keyboard/layouts_menu.cpp fd436c4 kcms/keyboard/layouts_menu.cpp e357c6a kcms/keyboard/layouts_menu.cpp 7d4c4d6 kcms/keyboard/x11_helper.h 719b13f kcms/keyboard/x11_helper.h 385ae28 kcms/keyboard/x11_helper.cpp 0e2806e kcms/keyboard/x11_helper.cpp cbb2cfc kcms/keyboard/xinput_helper.h 343d7ed kcms/keyboard/xinput_helper.h 343d7ed kcms/keyboard/xinput_helper.cpp b311579 kcms/keyboard/xinput_helper.cpp b311579 kcms/keyboard/xinput_helper.cpp b245e91 kcms/keyboard/xinput_helper.cpp 980338e kcms/keyboard/xinput_helper.cpp 1c9604b kcms/keyboard/xinput_helper.cpp 2b374ae kcms/keyboard/xkb_helper.cpp 967399e kcms/keyboard/xkb_rules.h 2be8562 kcms/keyboard/xkb_rules.cpp f09e675 Diff: https://git.reviewboard.kde.org/r/118366/diff/ Testing --- Thanks, shivam makkar ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118366: Porting keyboard module to Framework5
> On May 28, 2014, 6:10 a.m., Martin Gräßlin wrote: > > kcms/keyboard/kcmmisc.cpp, lines 77-78 > > <https://git.reviewboard.kde.org/r/118366/diff/2/?file=275630#file275630line77> > > > > for new connects I would use the new compile time checked syntax. > > shivam makkar wrote: > I tried it but it was giving some error "unable to deduce function > pointer " > > Martin Gräßlin wrote: > for which one was that? ::changed exists I think as a signal and a slot. > You might need to cast it to the appropriate type. thanks ! type casted the function ptr > On May 28, 2014, 6:10 a.m., Martin Gräßlin wrote: > > kcms/keyboard/xinput_helper.cpp, line 95 > > <https://git.reviewboard.kde.org/r/118366/diff/2/?file=275639#file275639line95> > > > > removing the event doesn't remove the fact that this method is not yet > > ported. See the #if 0 which indicates that this code has not been adjusted > > to xcb yet. > > shivam makkar wrote: > Will be porting it later ! ported - shivam --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/#review58618 --- On June 20, 2014, 9:24 p.m., shivam makkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118366/ > --- > > (Updated June 20, 2014, 9:24 p.m.) > > > Review request for kde-workspace, KDE Frameworks and Andriy Rysin. > > > Repository: plasma-desktop > > > Description > --- > > Removed deprecated statements and ported keyboard module to framework 5. > > > Diffs > - > > kcms/keyboard/bindings.h c576455 > kcms/keyboard/bindings.cpp 21541e0 > kcms/keyboard/bindings.cpp 21541e0 > kcms/keyboard/bindings.cpp 325dd3c > kcms/keyboard/flags.cpp b768586 > kcms/keyboard/flags.cpp b768586 > kcms/keyboard/flags.cpp 6d25443 > kcms/keyboard/flags.cpp 3fb98e5 > kcms/keyboard/iso_codes.h 6a33739 > kcms/keyboard/iso_codes.cpp 3e3b210 > kcms/keyboard/kcm_keyboard.cpp 42b7fe4 > kcms/keyboard/kcm_keyboard.ui 0062d1c > kcms/keyboard/kcm_keyboard.ui 0062d1c > kcms/keyboard/kcm_keyboard_widget.h 657ddda > kcms/keyboard/kcm_keyboard_widget.cpp 21685eb > kcms/keyboard/kcm_keyboard_widget.cpp 21685eb > kcms/keyboard/kcm_keyboard_widget.cpp 2840e26 > kcms/keyboard/kcm_keyboard_widget.cpp 9b0f584 > kcms/keyboard/kcmmisc.h 411bdd2 > kcms/keyboard/kcmmisc.h 411bdd2 > kcms/keyboard/kcmmisc.h 1183fb1 > kcms/keyboard/kcmmisc.cpp 6f787ea > kcms/keyboard/kcmmisc.cpp 6f787ea > kcms/keyboard/kcmmisc.cpp d14ac2e > kcms/keyboard/kcmmisc.cpp 3327ce5 > kcms/keyboard/kcmmiscwidget.ui 37fbaf4 > kcms/keyboard/kcmmiscwidget.ui 37fbaf4 > kcms/keyboard/keyboard_config.h b86418d > kcms/keyboard/keyboard_config.cpp f3ff97c > kcms/keyboard/keyboard_config.cpp f3ff97c > kcms/keyboard/keyboard_config.cpp 49f059c > kcms/keyboard/keyboard_config.cpp a227a34 > kcms/keyboard/keyboard_daemon.h 4edb968 > kcms/keyboard/keyboard_daemon.cpp 25673b0 > kcms/keyboard/keyboard_daemon.cpp 25673b0 > kcms/keyboard/keyboard_daemon.cpp dcda1ec > kcms/keyboard/keyboard_hardware.cpp dca49b6 > kcms/keyboard/keyboard_hardware.cpp dca49b6 > kcms/keyboard/keyboard_hardware.cpp 9a61159 > kcms/keyboard/layout_memory.h df8568c > kcms/keyboard/layout_memory.cpp 9e72361 > kcms/keyboard/layout_memory.cpp 9e72361 > kcms/keyboard/layout_memory.cpp d78e677 > kcms/keyboard/layout_memory_persister.h 8c4b3c5 > kcms/keyboard/layout_memory_persister.cpp 8a6118a > kcms/keyboard/layout_memory_persister.cpp 8a6118a > kcms/keyboard/layout_memory_persister.cpp 1dba024 > kcms/keyboard/layout_widget.cpp e67b2d7 > kcms/keyboard/layouts_menu.h db2f3ff > kcms/keyboard/layouts_menu.cpp fd436c4 > kcms/keyboard/layouts_menu.cpp fd436c4 > kcms/keyboard/layouts_menu.cpp e357c6a > kcms/keyboard/layouts_menu.cpp 7d4c4d6 > kcms/keyboard/x11_helper.h 719b13f > kcms/keyboard/x11_helper.h 385ae28 > kcms/keyboard/x11_helper.cpp 0e2806e > kcms/keyboard/x11_helper.cpp cbb2cfc > kcms/keyboard/xinput_helper.h 343d7ed > kcms/keyboard/xinput_helper.h 343d7ed > kcms/keyboard/xinput_helper.cpp b311579 > kcms/keyboard/xinput_helper.cpp b311579 > kcms/keyboard/xinput_helper.cpp b245e91 > kcms/keyboard/xinput_helper.cpp 980338e > kcms/
Re: Review Request 118366: Porting keyboard module to Framework5
> On June 19, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote: > > kcms/keyboard/flags.cpp, line 21 > > <https://git.reviewboard.kde.org/r/118366/diff/4/?file=276646#file276646line21> > > > > remove? see the latest revision, apparently the diff is showing all the revisions made to the same file. > On June 19, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote: > > kcms/keyboard/flags.cpp, line 22 > > <https://git.reviewboard.kde.org/r/118366/diff/4/?file=276649#file276649line22> > > > > wtf happened here? xD hehe, merge conflict while pull and push :P > On June 19, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote: > > kcms/keyboard/kcmmisc.cpp, line 134 > > <https://git.reviewboard.kde.org/r/118366/diff/4/?file=276656#file276656line134> > > > > please, don't add commented code. latest revision > On June 19, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote: > > kcms/keyboard/kcmmisc.cpp, line 68 > > <https://git.reviewboard.kde.org/r/118366/diff/4/?file=276658#file276658line68> > > > > I wouldn't do coding style changes while coding. will add another review dedicated to coding style changes only. - shivam --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/#review60569 --- On June 20, 2014, 9:24 p.m., shivam makkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118366/ > --- > > (Updated June 20, 2014, 9:24 p.m.) > > > Review request for kde-workspace, KDE Frameworks and Andriy Rysin. > > > Repository: plasma-desktop > > > Description > --- > > Removed deprecated statements and ported keyboard module to framework 5. > > > Diffs > - > > kcms/keyboard/bindings.h c576455 > kcms/keyboard/bindings.cpp 21541e0 > kcms/keyboard/bindings.cpp 21541e0 > kcms/keyboard/bindings.cpp 325dd3c > kcms/keyboard/flags.cpp b768586 > kcms/keyboard/flags.cpp b768586 > kcms/keyboard/flags.cpp 6d25443 > kcms/keyboard/flags.cpp 3fb98e5 > kcms/keyboard/iso_codes.h 6a33739 > kcms/keyboard/iso_codes.cpp 3e3b210 > kcms/keyboard/kcm_keyboard.cpp 42b7fe4 > kcms/keyboard/kcm_keyboard.ui 0062d1c > kcms/keyboard/kcm_keyboard.ui 0062d1c > kcms/keyboard/kcm_keyboard_widget.h 657ddda > kcms/keyboard/kcm_keyboard_widget.cpp 21685eb > kcms/keyboard/kcm_keyboard_widget.cpp 21685eb > kcms/keyboard/kcm_keyboard_widget.cpp 2840e26 > kcms/keyboard/kcm_keyboard_widget.cpp 9b0f584 > kcms/keyboard/kcmmisc.h 411bdd2 > kcms/keyboard/kcmmisc.h 411bdd2 > kcms/keyboard/kcmmisc.h 1183fb1 > kcms/keyboard/kcmmisc.cpp 6f787ea > kcms/keyboard/kcmmisc.cpp 6f787ea > kcms/keyboard/kcmmisc.cpp d14ac2e > kcms/keyboard/kcmmisc.cpp 3327ce5 > kcms/keyboard/kcmmiscwidget.ui 37fbaf4 > kcms/keyboard/kcmmiscwidget.ui 37fbaf4 > kcms/keyboard/keyboard_config.h b86418d > kcms/keyboard/keyboard_config.cpp f3ff97c > kcms/keyboard/keyboard_config.cpp f3ff97c > kcms/keyboard/keyboard_config.cpp 49f059c > kcms/keyboard/keyboard_config.cpp a227a34 > kcms/keyboard/keyboard_daemon.h 4edb968 > kcms/keyboard/keyboard_daemon.cpp 25673b0 > kcms/keyboard/keyboard_daemon.cpp 25673b0 > kcms/keyboard/keyboard_daemon.cpp dcda1ec > kcms/keyboard/keyboard_hardware.cpp dca49b6 > kcms/keyboard/keyboard_hardware.cpp dca49b6 > kcms/keyboard/keyboard_hardware.cpp 9a61159 > kcms/keyboard/layout_memory.h df8568c > kcms/keyboard/layout_memory.cpp 9e72361 > kcms/keyboard/layout_memory.cpp 9e72361 > kcms/keyboard/layout_memory.cpp d78e677 > kcms/keyboard/layout_memory_persister.h 8c4b3c5 > kcms/keyboard/layout_memory_persister.cpp 8a6118a > kcms/keyboard/layout_memory_persister.cpp 8a6118a > kcms/keyboard/layout_memory_persister.cpp 1dba024 > kcms/keyboard/layout_widget.cpp e67b2d7 > kcms/keyboard/layouts_menu.h db2f3ff > kcms/keyboard/layouts_menu.cpp fd436c4 > kcms/keyboard/layouts_menu.cpp fd436c4 > kcms/keyboard/layouts_menu.cpp e357c6a > kcms/keyboard/layouts_menu.cpp 7d4c4d6 > kcms/keyboard/x11_helper.h 719b13f > kcms/keyboard/x11_helper.h 385ae28 > kcms/keyboard/x11_helper.cpp 0e2806e > kcms/keyboard/x11_helper.cpp cbb2cfc > kcms/keyboard/xinput_helper.h 343d7ed > kcms/keyboard/xinput_helper.h 343d7ed > kcms/keyboard/xinput_helper.cpp b311579 > kcms/keyboard/xinpu
Re: Review Request 118366: Porting keyboard module to Framework5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated June 23, 2014, 1:46 p.m.) Review request for kde-workspace, KDE Frameworks and Andriy Rysin. Repository: plasma-desktop Description --- Removed deprecated statements and ported keyboard module to framework 5. Diffs - kcms/keyboard/bindings.h c5764556d97e06ebad4f1737ffbbea2981ff32ca kcms/keyboard/bindings.cpp 21541e095da0b8d6ea1f789644f6e09d577c298b kcms/keyboard/flags.cpp b768586cc644fc5750245a8b1c3db4c55a43c16e kcms/keyboard/iso_codes.h 6a337392e958546e9f36423d7e3fd10d9e12c6f8 kcms/keyboard/iso_codes.cpp 3e3b210b9f0f89c71a04535e74bd43b6b3b243e9 kcms/keyboard/kcm_keyboard.cpp 42b7fe4df5fddd9ae738cde62d0c9e8a3dcad103 kcms/keyboard/kcm_keyboard.ui 0062d1c53877f13d0036c0220691347434a9d47f kcms/keyboard/kcm_keyboard_widget.h 657ddda3bc1d75a632a6ddbd1a9ec690b6244909 kcms/keyboard/kcm_keyboard_widget.cpp 21685eb527b7fd1d8a322d0e17ae2c0ae291ce41 kcms/keyboard/kcmmisc.h 411bdd2b0f61257b4382fe35be4b8fa4ea2ecba6 kcms/keyboard/kcmmisc.cpp 6f787ea3723f223537252b9581c15db203f4764c kcms/keyboard/kcmmiscwidget.ui 37fbaf4b9c9af9a62713bb9b5444cc04320e8d53 kcms/keyboard/keyboard_config.h b86418de47a83e75eb85e723cc8eb24071e1f43d kcms/keyboard/keyboard_config.cpp f3ff97ca84d444acfb215a32bb900815318aefd9 kcms/keyboard/keyboard_daemon.h 4edb968bb071445c52332c695e7978d26363ad09 kcms/keyboard/keyboard_daemon.cpp 25673b073e104357cb3d56b13688ef7d790ee8cd kcms/keyboard/keyboard_hardware.cpp dca49b674083dbae6398e8ba0e524c647a36e47a kcms/keyboard/layout_memory.h df8568c2bdb82f0be713424e1cf6404761312ea5 kcms/keyboard/layout_memory.cpp 9e723612b75b82fb04ac1fd5c2271e58e3c1aaf7 kcms/keyboard/layout_memory_persister.h 8c4b3c5f60277c319b4d94ad3d40b1a65b706b8d kcms/keyboard/layout_memory_persister.cpp 8a6118aad9edea5c6a4a627144c3fd3bf837fe0e kcms/keyboard/layout_widget.cpp e67b2d77d32b87339003285712b6ef98fc292bd3 kcms/keyboard/layouts_menu.h db2f3ff5844e16340ad3ca6102e6b1c4866ad8db kcms/keyboard/layouts_menu.cpp fd436c406671dcbb859dcb7367b9c83fba99da0c kcms/keyboard/x11_helper.h 719b13fec63265e0c0fed01c21e197349305928e kcms/keyboard/x11_helper.cpp 0e2806eeb55e4987c2b8f528d026ec5864d2dd9c kcms/keyboard/xinput_helper.h 343d7ed2a0528459069b0b2e3a3d4aa4d8ce43d8 kcms/keyboard/xinput_helper.cpp b311579d1b65f3068d0c25b180bc1dd88fe7ba65 kcms/keyboard/xkb_helper.cpp 967399ebca42e3cd18b441152a0cf3a31e28b131 kcms/keyboard/xkb_rules.h 2be856246cc150abb24775c6d56b8af2a07df94f kcms/keyboard/xkb_rules.cpp f09e6750130799d6e0cdc380a6dbaa834c43aa43 Diff: https://git.reviewboard.kde.org/r/118366/diff/ Testing --- Thanks, shivam makkar ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118366: Porting keyboard module to Framework5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated Oct. 21, 2016, 11:23 a.m.) Status -- This change has been discarded. Review request for kde-workspace, KDE Frameworks and Andriy Rysin. Repository: plasma-desktop Description --- Removed deprecated statements and ported keyboard module to framework 5. Diffs - kcms/keyboard/bindings.h c5764556d97e06ebad4f1737ffbbea2981ff32ca kcms/keyboard/bindings.cpp 21541e095da0b8d6ea1f789644f6e09d577c298b kcms/keyboard/flags.cpp b768586cc644fc5750245a8b1c3db4c55a43c16e kcms/keyboard/iso_codes.h 6a337392e958546e9f36423d7e3fd10d9e12c6f8 kcms/keyboard/iso_codes.cpp 3e3b210b9f0f89c71a04535e74bd43b6b3b243e9 kcms/keyboard/kcm_keyboard.cpp 42b7fe4df5fddd9ae738cde62d0c9e8a3dcad103 kcms/keyboard/kcm_keyboard.ui 0062d1c53877f13d0036c0220691347434a9d47f kcms/keyboard/kcm_keyboard_widget.h 657ddda3bc1d75a632a6ddbd1a9ec690b6244909 kcms/keyboard/kcm_keyboard_widget.cpp 21685eb527b7fd1d8a322d0e17ae2c0ae291ce41 kcms/keyboard/kcmmisc.h 411bdd2b0f61257b4382fe35be4b8fa4ea2ecba6 kcms/keyboard/kcmmisc.cpp 6f787ea3723f223537252b9581c15db203f4764c kcms/keyboard/kcmmiscwidget.ui 37fbaf4b9c9af9a62713bb9b5444cc04320e8d53 kcms/keyboard/keyboard_config.h b86418de47a83e75eb85e723cc8eb24071e1f43d kcms/keyboard/keyboard_config.cpp f3ff97ca84d444acfb215a32bb900815318aefd9 kcms/keyboard/keyboard_daemon.h 4edb968bb071445c52332c695e7978d26363ad09 kcms/keyboard/keyboard_daemon.cpp 25673b073e104357cb3d56b13688ef7d790ee8cd kcms/keyboard/keyboard_hardware.cpp dca49b674083dbae6398e8ba0e524c647a36e47a kcms/keyboard/layout_memory.h df8568c2bdb82f0be713424e1cf6404761312ea5 kcms/keyboard/layout_memory.cpp 9e723612b75b82fb04ac1fd5c2271e58e3c1aaf7 kcms/keyboard/layout_memory_persister.h 8c4b3c5f60277c319b4d94ad3d40b1a65b706b8d kcms/keyboard/layout_memory_persister.cpp 8a6118aad9edea5c6a4a627144c3fd3bf837fe0e kcms/keyboard/layout_widget.cpp e67b2d77d32b87339003285712b6ef98fc292bd3 kcms/keyboard/layouts_menu.h db2f3ff5844e16340ad3ca6102e6b1c4866ad8db kcms/keyboard/layouts_menu.cpp fd436c406671dcbb859dcb7367b9c83fba99da0c kcms/keyboard/x11_helper.h 719b13fec63265e0c0fed01c21e197349305928e kcms/keyboard/x11_helper.cpp 0e2806eeb55e4987c2b8f528d026ec5864d2dd9c kcms/keyboard/xinput_helper.h 343d7ed2a0528459069b0b2e3a3d4aa4d8ce43d8 kcms/keyboard/xinput_helper.cpp b311579d1b65f3068d0c25b180bc1dd88fe7ba65 kcms/keyboard/xkb_helper.cpp 967399ebca42e3cd18b441152a0cf3a31e28b131 kcms/keyboard/xkb_rules.h 2be856246cc150abb24775c6d56b8af2a07df94f kcms/keyboard/xkb_rules.cpp f09e6750130799d6e0cdc380a6dbaa834c43aa43 Diff: https://git.reviewboard.kde.org/r/118366/diff/ Testing --- Thanks, shivam makkar
Re: Review Request 118366: Porting keyboard module to Framework5
> On Oct. 21, 2016, 11:12 a.m., Albert Astals Cid wrote: > > Seems this was somehow forgotten, sadly the patch does not apply anymore > > (or maybe it was commited and this was never closed?). > > > > Could you either upload a new patch if it's still needed or close the > > review if it is now? The porting has been done, I guess it was tracked in some other cr. Therefore discarding. - shivam --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/#review100194 --- On June 23, 2014, 1:46 p.m., shivam makkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118366/ > --- > > (Updated June 23, 2014, 1:46 p.m.) > > > Review request for kde-workspace, KDE Frameworks and Andriy Rysin. > > > Repository: plasma-desktop > > > Description > --- > > Removed deprecated statements and ported keyboard module to framework 5. > > > Diffs > - > > kcms/keyboard/bindings.h c5764556d97e06ebad4f1737ffbbea2981ff32ca > kcms/keyboard/bindings.cpp 21541e095da0b8d6ea1f789644f6e09d577c298b > kcms/keyboard/flags.cpp b768586cc644fc5750245a8b1c3db4c55a43c16e > kcms/keyboard/iso_codes.h 6a337392e958546e9f36423d7e3fd10d9e12c6f8 > kcms/keyboard/iso_codes.cpp 3e3b210b9f0f89c71a04535e74bd43b6b3b243e9 > kcms/keyboard/kcm_keyboard.cpp 42b7fe4df5fddd9ae738cde62d0c9e8a3dcad103 > kcms/keyboard/kcm_keyboard.ui 0062d1c53877f13d0036c0220691347434a9d47f > kcms/keyboard/kcm_keyboard_widget.h > 657ddda3bc1d75a632a6ddbd1a9ec690b6244909 > kcms/keyboard/kcm_keyboard_widget.cpp > 21685eb527b7fd1d8a322d0e17ae2c0ae291ce41 > kcms/keyboard/kcmmisc.h 411bdd2b0f61257b4382fe35be4b8fa4ea2ecba6 > kcms/keyboard/kcmmisc.cpp 6f787ea3723f223537252b9581c15db203f4764c > kcms/keyboard/kcmmiscwidget.ui 37fbaf4b9c9af9a62713bb9b5444cc04320e8d53 > kcms/keyboard/keyboard_config.h b86418de47a83e75eb85e723cc8eb24071e1f43d > kcms/keyboard/keyboard_config.cpp f3ff97ca84d444acfb215a32bb900815318aefd9 > kcms/keyboard/keyboard_daemon.h 4edb968bb071445c52332c695e7978d26363ad09 > kcms/keyboard/keyboard_daemon.cpp 25673b073e104357cb3d56b13688ef7d790ee8cd > kcms/keyboard/keyboard_hardware.cpp > dca49b674083dbae6398e8ba0e524c647a36e47a > kcms/keyboard/layout_memory.h df8568c2bdb82f0be713424e1cf6404761312ea5 > kcms/keyboard/layout_memory.cpp 9e723612b75b82fb04ac1fd5c2271e58e3c1aaf7 > kcms/keyboard/layout_memory_persister.h > 8c4b3c5f60277c319b4d94ad3d40b1a65b706b8d > kcms/keyboard/layout_memory_persister.cpp > 8a6118aad9edea5c6a4a627144c3fd3bf837fe0e > kcms/keyboard/layout_widget.cpp e67b2d77d32b87339003285712b6ef98fc292bd3 > kcms/keyboard/layouts_menu.h db2f3ff5844e16340ad3ca6102e6b1c4866ad8db > kcms/keyboard/layouts_menu.cpp fd436c406671dcbb859dcb7367b9c83fba99da0c > kcms/keyboard/x11_helper.h 719b13fec63265e0c0fed01c21e197349305928e > kcms/keyboard/x11_helper.cpp 0e2806eeb55e4987c2b8f528d026ec5864d2dd9c > kcms/keyboard/xinput_helper.h 343d7ed2a0528459069b0b2e3a3d4aa4d8ce43d8 > kcms/keyboard/xinput_helper.cpp b311579d1b65f3068d0c25b180bc1dd88fe7ba65 > kcms/keyboard/xkb_helper.cpp 967399ebca42e3cd18b441152a0cf3a31e28b131 > kcms/keyboard/xkb_rules.h 2be856246cc150abb24775c6d56b8af2a07df94f > kcms/keyboard/xkb_rules.cpp f09e6750130799d6e0cdc380a6dbaa834c43aa43 > > Diff: https://git.reviewboard.kde.org/r/118366/diff/ > > > Testing > --- > > > Thanks, > > shivam makkar > >
