Re: KDE Frameworks with failing CI (master) (10 March 2024)

[Tobias C. Berner]

Moin moin

I'll rebuild the package repo to use Qt 6.6.2 -- I'll ping you once
the repo is updated.


mfg Tobias

On Tue, 12 Mar 2024 at 10:50, Ben Cooksley  wrote:
>
> On Mon, Mar 11, 2024 at 12:46 PM Albert Astals Cid  wrote:
>>
>> Please work on fixing them, otherwise i will remove the failing CI jobs on
>> their 4th failing week, it is very important that CI is passing for multiple
>> reasons.
>>
>> Bad news: 1 repository is still failing and 1 new has started failing
>>
>>
>> kimageformats - 3rd week
>>  * https://invent.kde.org/frameworks/kimageformats/-/pipelines/627271
>>   * kimageformats-read-xcf fails in Linux CI
>>* https://invent.kde.org/frameworks/kimageformats/-/merge_requests/211
>> fixes it but then breaks the BSD builder (because it is on an older Qt) Can 
>> we
>> update Qt in the BSD builder to 6.6.2?
>
>
> Please file a ticket for that update.
>
>>
>>
>>
>> kpackage - NEW
>>  * https://invent.kde.org/frameworks/kpackage/-/pipelines/627276
>>   * appstream check fails
>
>
> It would appear that this will require changes to the KPackage format to 
> ensure that we allow (require?) plugins to specify a homepage to comply with 
> Appstream requirements.
>
>>
>>
>> Cheers,
>>   Albert
>>
>>
>
> Regards,
> Ben

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.15 - Build # 291 - Unstable!

[Tobias C. Berner]

Moin moin

I will update the installation in around 8 hours


mfg Tobias

On Mon, 5 Apr 2021 at 21:52, Christoph Cullmann  wrote:
>
> Hi,
>
> On 2021-04-05 21:40, Adriaan de Groot wrote:
> > On Monday, 5 April 2021 19:20:08 CEST Ben Cooksley wrote:
> >> On Tue, Apr 6, 2021 at 3:33 AM Christoph Cullmann
> >> 
> >> > I reverted my test commit to see if we have still some unpatched 5.15
> >> > with a broken QJSEngine around again.
> >> >
> >> > Still, I think it would be great if one could have some patched version
> >> > in the CI.
> >> >
> >> > Could one update there the Qt installation to the latest available patch
> >> > release?
> >
> > It would be really useful if you specified **what** version; if
> > ktexteditor
> > requires Qt 5.15.2, then please set the minimum Qt version to 5.15.2.
> > Do not
> > allow 5.15.0 and then complain that it triggers crashes. Alternately,
> > use
> > QEXPECT_FAIL if you have a beef with specific Qt versions.
>
> is that allowed for Frameworks?
> Naturally that would be preferable.
>
> I just wanted to test with my commit if the CI stuff has fresh enough
> stuff
> that has no broke QJSEngine. That failed ;=) But if you update as said
> below,
> that is nice.
>
> I would love to raise the version to minimal 5.15.2 given that 5.15
> below that path
> has a QJSEngine that randomly crashes during GC, for everything.
>
> I am still amazed that not more stuff fails there, given our javascripts
> are trivial,
> perhaps we are just unlucky to have unit tests with JS stuff.
>
> > All that said, yes, we can update the CI builders to 5.15.2, which is
> > what
> > most folk on FreeBSD would be using now anyway.
>
> That would be great!
>
> Greetings
> Christoph
>
> --
> Ignorance is bliss...
> https://cullmann.io | https://kate-editor.org

Re: Shift for parts of the CI system to Qt 5.15

[Tobias C. Berner]

Moin moin

On Sat, 20 Jun 2020 at 10:13, Volker Krause  wrote:
>
> On Saturday, 20 June 2020 08:20:18 CEST Ben Cooksley wrote:
> > Hi all,
> >
> > This weekend parts of our CI system shifted to using Qt 5.15, with all
> > FreeBSD builds now being based on Qt 5.15. We also shifted all Linux
> > builds of Plasma, and the latest Qt version build of Frameworks to Qt
> > 5.15 as well (apologies for the massive amount of email this kicked
> > up)
> >
> > It has however exposed a series of SIC changes in Qt which will need
> > to be adapted to. The list of affected projects appears to be as
> > follows:
> > - kalarm
> > - kdesdk-kioslaves
> > - kompare
> > - subtitlecomposer
>
> all fixed
>
> > - kaffeine
>
> This doesn't look like something caused by Qt 5.15, more like an issue with
> the FreeBSD DVB headers, builds on Linux.
Indeed, the v4l_compat package [1] is likely the issue. When building
kaffeine in the FreeBSD ports, the include/ directory of kaffeine gets
removed prior to building, as the headers are provided by v4l_compat
already.


mfg Tobias

[1] https://www.freshports.org/multimedia/v4l_compat

>
> > In addition, the following projects appear to have long standing build
> > issues. It would be appreciated if they could please investigate and
> > correct these:
> > - kbibtex
>
> fixed
>
> > - atcore
> > - kmymoney
>
> MSVC-only, or rather GCC/clang being a bit too forgiving.
>
> atcore looks like an ambiguous default argument, removing that should fix it,
> but since this is a public interface I didn't want to just change this, being
> unable to estimate the impact.
>
> kmymoney is using an exported class in two DLLs with the same export macro,
> that doesn't work. Needs more insights into the project to restructure that
> accordingly I think.
>
> > - ring-kde
>
> build errors seem to be in stuff downloaded by cmake!?
>
> > Further, the following project appears to have a broken build due to
> > SIC changes within another KDE project:
> > - zanshin
>
> fixed
>
> Regards,
> Volker
>
>
>

D28407: Fix configure when xmllint is not present

[Tobias C. Berner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:23b32c25f0be: Fix configure when xmllint is not present 
(authored by tcberner).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28407?vs=78796&id=78801

REVISION DETAIL
  https://phabricator.kde.org/D28407

AFFECTED FILES
  icons-dark/CMakeLists.txt
  icons/CMakeLists.txt

To: tcberner, kossebau
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28407: Fix configure when xmllint is not present

[Tobias C. Berner]

tcberner created this revision.
tcberner added a reviewer: kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
tcberner requested review of this revision.

REVISION SUMMARY
  The breeze-validate-svg target is only generated when xmllint is found.
  breeze-generate-24px-versions cannot be added as a dependency, unless
  the target exists.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28407

AFFECTED FILES
  icons-dark/CMakeLists.txt
  icons/CMakeLists.txt

To: tcberner, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27927: Use more flexible shebang

[Tobias C. Berner]

tcberner created this revision.
tcberner added reviewers: FreeBSD, sitter.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
tcberner requested review of this revision.

REVISION SUMMARY
  `bash` is in `${LOCALBASE}` in FreeBSD, which defaults to `/usr/local`.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27927

AFFECTED FILES
  generate-24px-versions.sh

To: tcberner, #freebsd, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Re: Does FreeBSD have HAL?

[Tobias C. Berner]

Moin moin

We will replace (ancient) hal with Gleb's implementation of usdisks2
"bsdisks2" in the near future by default.

Hald is likely not enabled on the CI hosts -- I could enable it :) --
or we could push the switch and make bsdisks2 the default in master,
which I would prefer.
What is your thought on this Gleb?


mfg Tobias

On Sat, 4 Jan 2020 at 18:16, David Faure  wrote:
>
> solid/src/CMakeLists.txt offers the option to use "UDisks2/bsdisks backend 
> instead of HAL to manage disk devices" on FreeBSD, but OFF by default.
>
> So the default is the HAL backend, which however completely fails on CI:
> https://build.kde.org/job/Frameworks/view/Platform%20-%20FreeBSDQt5.13/job/solid/job/kf5-qt5%20FreeBSDQt5.13/52/testReport/projectroot/autotests/halbasictest/
> basically says that org.freedesktop.Hal is not running (on the system bus)
>
> FreeBSD users: does `qdbus --system org.freedesktop.HalManager` work for you?
> If it does, any idea what should be done on the CI to make that work there?
>
> I'm really hoping for fully-green unittests one day, but FreeBSD isn't really 
> helping with that :-)
>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>

D17863: Add ecm_check_linker_flags function

[Tobias C. Berner]

tcberner abandoned this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D17863

To: tcberner, #freebsd, dfaure, apol, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

[Tobias C. Berner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:b1d27cabc2a9: KProcessInfoList -- add proclist backend 
for FreeBSD (authored by tcberner).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21146?vs=68138&id=68151

REVISION DETAIL
  https://phabricator.kde.org/D21146

AFFECTED FILES
  CMakeLists.txt
  cmake/FindProcstat.cmake
  src/lib/CMakeLists.txt
  src/lib/util/kprocesslist_unix_procstat.cpp
  src/lib/util/kprocesslist_unix_procstat_p.h

To: tcberner, #freebsd, adridg, davidedmundson
Cc: pino, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

[Tobias C. Berner]

tcberner added a comment.


  @adridg I've addressed your comments [finally].

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21146

To: tcberner, #freebsd, adridg, davidedmundson
Cc: pino, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

[Tobias C. Berner]

tcberner updated this revision to Diff 68138.
tcberner added a comment.


  - procstat: add FindProcstat.cmake
  - procstat: add procstat backend
  - procstat: add procstat option
  - procstat: add linkage for procstat backend

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21146?vs=57921&id=68138

BRANCH
  procstat_v3

REVISION DETAIL
  https://phabricator.kde.org/D21146

AFFECTED FILES
  CMakeLists.txt
  cmake/FindProcstat.cmake
  src/lib/CMakeLists.txt
  src/lib/util/kprocesslist_unix_procstat.cpp
  src/lib/util/kprocesslist_unix_procstat_p.h

To: tcberner, #freebsd, adridg, davidedmundson
Cc: pino, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

[Tobias C. Berner]

tcberner marked an inline comment as done.
tcberner added a comment.


  Gargh, the code `kdelibs` code formatter changed a lot more in 
`kprocesslist_unix_proc.cpp` than wanted :/

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21146

To: tcberner, #freebsd, adridg, davidedmundson
Cc: pino, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

[Tobias C. Berner]

tcberner updated this revision to Diff 57921.
tcberner added a comment.


  - Switch to 2-Clause
  - Move procstat backend into its own file
  - Remove now unnecessary config-kprocesslist.cmake

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21146?vs=57915&id=57921

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21146

AFFECTED FILES
  CMakeLists.txt
  cmake/FindProcstat.cmake
  src/lib/CMakeLists.txt
  src/lib/util/kprocesslist_unix.cpp
  src/lib/util/kprocesslist_unix_proc.cpp
  src/lib/util/kprocesslist_unix_procstat.cpp

To: tcberner, #freebsd, adridg, davidedmundson
Cc: pino, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

[Tobias C. Berner]

tcberner updated this revision to Diff 57915.
tcberner added a comment.


  Remove commented line.

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21146?vs=57913&id=57915

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21146

AFFECTED FILES
  CMakeLists.txt
  cmake/FindProcstat.cmake
  src/lib/CMakeLists.txt
  src/lib/util/config-kprocesslist.h.cmake
  src/lib/util/kprocesslist_unix.cpp

To: tcberner, #freebsd, adridg, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

[Tobias C. Berner]

tcberner added inline comments.

INLINE COMMENTS

> FindProcstat.cmake:18
> +#documentation and/or other materials provided with the distribution.
> +# 3. Neither the name of the University nor the names of its contributors
> +#may be used to endorse or promote products derived from this software

^ that should probably be 2-clause...

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21146

To: tcberner, #freebsd, adridg, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

[Tobias C. Berner]

tcberner created this revision.
tcberner added reviewers: FreeBSD, adridg, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
tcberner requested review of this revision.

REVISION SUMMARY
  This adds
  
  - unixProcessListKinfoProcStat() to KProcessInfoList to query process info 
via FreeBSD's procstat library
  - FindProcstat.cmake and config-kprocesslist.h.cmake to handle finding and 
using it
  
  - Additionally, the ps-argument in unixProcessListPS was changed to 
'commmand' form 'cmd' for FreeBSD.
  
  - Todo: make it nicer :)
  
  See D20007 

TEST PLAN
Totals: 6 passed, 0 failed, 0 skipped, 0 blacklisted, 198ms
* Finished testing of KProcessListTest *

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21146

AFFECTED FILES
  CMakeLists.txt
  cmake/FindProcstat.cmake
  src/lib/CMakeLists.txt
  src/lib/util/config-kprocesslist.h.cmake
  src/lib/util/kprocesslist_unix.cpp

To: tcberner, #freebsd, adridg, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19075: Fix FindEGL

[Tobias C. Berner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:7c64db956829: Fix FindEGL (authored by tcberner).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19075?vs=51847&id=52057

REVISION DETAIL
  https://phabricator.kde.org/D19075

AFFECTED FILES
  find-modules/FindEGL.cmake

To: tcberner, #automotive, hausmann, #freebsd, apol
Cc: bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19075: Fix FindEGL

[Tobias C. Berner]

tcberner updated this revision to Diff 51847.
tcberner added a comment.


  Simply set `NAMES EGL/egl.h` and fixup the header version check.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19075?vs=51842&id=51847

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19075

AFFECTED FILES
  find-modules/FindEGL.cmake

To: tcberner, #automotive, hausmann, #freebsd
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19075: Fix FindEGL

[Tobias C. Berner]

tcberner added a comment.


  In D19075#413462 , @hausmann wrote:
  
  > I think that it should be NAMES EGL/egl.h
  
  
  Yeah, then it might actuayll work without redefining the path -- but in both 
cases we are kind of assuming that all install egl.h into a subdir called 'EGL'.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19075

To: tcberner, #automotive, hausmann, #freebsd
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19075: Fix FindEGL

[Tobias C. Berner]

tcberner updated this revision to Diff 51842.
tcberner added a comment.


  Store the path gathered via pkgconfig in `COMPLETE_EGL_INCLUDE_DIR` and 
  use its parent directory for `EGL_INCLUDE_DIR`.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19075?vs=51825&id=51842

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19075

AFFECTED FILES
  find-modules/FindEGL.cmake

To: tcberner, #automotive, hausmann, #freebsd
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19075: Fix FindEGL

[Tobias C. Berner]

tcberner added a comment.


  Possibly the returend `EGL_INCLUDE_DIR` should possibly be stripped of the 
suffix too, as most will proably include 'EGL/egl.h', and not 'egl.h', I guess?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19075

To: tcberner, #automotive, hausmann, #freebsd
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19075: Fix FindEGL

[Tobias C. Berner]

tcberner added a reviewer: FreeBSD.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19075

To: tcberner, #automotive, hausmann, #freebsd
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19075: Fix FindEGL

[Tobias C. Berner]

tcberner created this revision.
tcberner added reviewers: Automotive, hausmann.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
tcberner requested review of this revision.

REVISION SUMMARY
  ${EGL_INCLUDE_DIR} is the path up to 'egl.h' -- so the header is
  ${EGL_INCLUDE_DIR}/egl.h
  
  The compile test on the other hand includes 'EGL/egl.h', so the path
  that needs to be passed to the compile test is "${EGL_INCLUDE_DIR}/..".

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19075

AFFECTED FILES
  find-modules/FindEGL.cmake

To: tcberner, #automotive, hausmann
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19075: Fix FindEGL

[Tobias C. Berner]

tcberner added a dependency: D18960: Add compile check to FindEGL.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19075

To: tcberner, #automotive, hausmann
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18960: Add compile check to FindEGL

[Tobias C. Berner]

tcberner added a dependent revision: D19075: Fix FindEGL.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18960

To: hausmann, vkrause, apol
Cc: bcooksley, tcberner, kossebau, kde-frameworks-devel, kde-buildsystem, 
michaelh, ngraham, bruns

D18960: Add compile check to FindEGL

[Tobias C. Berner]

tcberner added a comment.


  In D18960#411562 , @kossebau wrote:
  
  > Seems this is sadly breaking something for FreeBSD though, see
  >  
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/21/console
  
  
  I'll look into it.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18960

To: hausmann, vkrause, apol
Cc: tcberner, kossebau, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D17863: Add ecm_check_linker_flags function

[Tobias C. Berner]

tcberner added a comment.


  In D17863#384145 , @cgiboudeaux 
wrote:
  
  > Why not fixing kstars instead?
  
  
  
  
include(ECMCheckLinkerFlags)
[...]
# Check for nodump support
SET(NODUMP_FLAGS "-Wl,-z,nodump")
ecm_check_linker_flags("${NODUMP_FLAGS}" NODUMP_SUPPORTED)
if (NODUMP_SUPPORTED)
SET(SEC_LINK_FLAGS "${SEC_LINK_FLAGS} ${NODUMP_FLAGS}")
endif ()
  
  ^ that is the fix for kstars.  -- Of course kstars could also just stop 
adding nodump ever :)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D17863

To: tcberner, #freebsd, dfaure, apol, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17863: Add ecm_check_linker_flags function

[Tobias C. Berner]

tcberner added a comment.


  See: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230603

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D17863

To: tcberner, #freebsd, dfaure, apol
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17863: Add ecm_check_linker_flags function

[Tobias C. Berner]

tcberner edited the summary of this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D17863

To: tcberner, #freebsd, dfaure, apol
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17863: Add ecm_check_linker_flags function

[Tobias C. Berner]

tcberner created this revision.
tcberner added reviewers: FreeBSD, dfaure, apol.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
tcberner requested review of this revision.

REVISION SUMMARY
kstars appends '-Wl,-z,nodump' to the linker flags, which is not supported 
by lld>=7 (previous versions just discareded unkonwn flags).

Add an ecm module to check whether a linker flag is supported.

Usage:
``` 
  include(ECMCheckLinkerFlags)
  [...]
  # Check for nodump support
  SET(NODUMP_FLAGS "-Wl,-z,nodump")
  ecm_check_linker_flags("${NODUMP_FLAGS}" NODUMP_SUPPORTED)
  if (NODUMP_SUPPORTED)
  SET(SEC_LINK_FLAGS "${SEC_LINK_FLAGS} ${NODUMP_FLAGS}")
  endif ()
 ```

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17863

AFFECTED FILES
  modules/ECMCheckLinkerFlags.cmake

To: tcberner, #freebsd, dfaure, apol
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17015: Fix the Qt doc creation with Qt 5.12.

[Tobias C. Berner]

tcberner added inline comments.

INLINE COMMENTS

> ECMQueryQmake.cmake:9
> +# We need to look for the executable directly.
> +find_program(_qmake_executable_default NAMES qmake-qt5)
>  endif()

^ on FreeBSD qmake-qt5 is just called qmake (which is in fact qtchooser).

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D17015

To: cgiboudeaux, kossebau
Cc: tcberner, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

Re: ktextwidgets on FreeBSD

[Tobias C. Berner]

I can read speech-dispatcher, which had the hanging processes, if you want.

mfg Tobias

On Sun, 5 Aug 2018 at 01:41, Ben Cooksley  wrote:

> On Sat, Aug 4, 2018 at 11:06 PM, David Faure  wrote:
> > Anyone running FreeBSD, who could to try and debug this hanging unittest
> from the ktextwidgets framework?
> >
> >
> https://build.kde.org/view/Frameworks/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.10/9/testReport/junit/(root)/TestSuite/ktextwidgets_krichtextedittest/
> >
> > There's no waiting of any kind in the code, it's straight QTextDocument
> usage, this shouldn't deadlock or anything.
> > Yet it times out (after 30 seconds!!) quite often in CI.
>
> This is a rather unusual failure, as the CI system is giving that test
> 5 minutes to timeout, after the test has finished.
>
> Usually this happens when tests start background daemons and don't
> kill those processes off before the test exits (which CTest doesn't
> like).
> However I don't think it's a background process sticking around in
> this case as those type of hangs are usually
> manual-intervention-required ones, which this isn't.
>
> Unfortunately it seems that the issue has gone away though so it's not
> possible to dig into this much further...
>
> https://build.kde.org/view/Frameworks/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.10/22/
>
> >
> > Just a backtrace would be very useful already.
> >
> >
> > void KRichTextEditTest::testUpdateLinkAdd()
> > {
> > KRichTextEdit edit;
> > edit.enableRichTextMode();
> >
> > // Add text, apply initial formatting, and add a link
> > QTextCursor cursor = edit.textCursor();
> > cursor.insertText(QStringLiteral("Test"));
> > QTextCharFormat charFormat = cursor.charFormat();
> > // Note that QTextEdit doesn't use the palette. Black is black.
> > QCOMPARE(charFormat.foreground().color().name(),
> QColor(Qt::black).name());
> >
> > cursor.select(QTextCursor::BlockUnderCursor);
> > edit.setTextCursor(cursor);
> > edit.setTextBold(true);
> > edit.setTextItalic(true);
> > edit.updateLink(QStringLiteral("http://www.kde.org";),
> QStringLiteral("KDE"));
> >
> > // Validate text and formatting
> > cursor.movePosition(QTextCursor::Start);
> > cursor.select(QTextCursor::WordUnderCursor);
> > edit.setTextCursor(cursor);
> > QCOMPARE(edit.toPlainText(), QStringLiteral("KDE "));
> > QCOMPARE(edit.fontItalic(), true);
> > QCOMPARE(edit.fontWeight(), static_cast(QFont::Bold));
> > QCOMPARE(edit.fontUnderline(), true);
> > charFormat = cursor.charFormat();
> > QCOMPARE(charFormat.foreground(),
> QBrush(KColorScheme(QPalette::Active,
> KColorScheme::View).foreground(KColorScheme::LinkText).color()));
> > QCOMPARE(charFormat.underlineColor(), KColorScheme(QPalette::Active,
> KColorScheme::View).foreground(KColorScheme::LinkText).color());
> > QCOMPARE(charFormat.underlineStyle(),
> QTextCharFormat::SingleUnderline);
> > }
> >
> > --
> > David Faure, fa...@kde.org, http://www.davidfaure.fr
> > Working on KDE Frameworks 5
> >
> >
> >
>
> Cheers,
> Ben
>

D12231: Reduce the number of zombies to a minimum

[Tobias C . Berner]

tcberner abandoned this revision.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12231

To: tcberner, #freebsd, sitter, apol
Cc: adridg, anthonyfieroni, #frameworks, michaelh, ngraham, bruns

D12226: balooshow: Colorize only when attached to terminal

[Tobias C . Berner]

tcberner accepted this revision.
tcberner added a comment.
This revision is now accepted and ready to land.


  Works as intended on FreeBSD.

REPOSITORY
  R293 Baloo

BRANCH
  no-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12226

To: michaelh, #baloo, bruns, #freebsd, tcberner
Cc: tcberner, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12231: Reduce the number of zombies to a minimum

[Tobias C . Berner]

tcberner updated this revision to Diff 32216.
tcberner added a comment.


  Simplify the diff.

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12231?vs=32210&id=32216

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12231

AFFECTED FILES
  cmake/build-pofiles.cmake

To: tcberner, #freebsd, sitter, apol
Cc: #frameworks, michaelh, ngraham, bruns

D12231: Reduce the number of zombies to a minimum

[Tobias C . Berner]

tcberner added inline comments.

INLINE COMMENTS

> build-pofiles.cmake:64
>  set(i 0)
> +set(commands "")
>  endif()

^ this is probalby the only required change.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12231

To: tcberner, #freebsd, sitter, apol
Cc: #frameworks, michaelh, ngraham, bruns

D12231: Reduce the number of zombies to a minimum

[Tobias C . Berner]

tcberner created this revision.
tcberner added reviewers: FreeBSD, sitter, apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
tcberner requested review of this revision.

REVISION SUMMARY
  With Frameworks 5.45 [1] when building for example plasma-workspace, I get
  1000s of zombie processes, and the build hangs (burries zombies) for a long 
time.
  
  Whith this change here, this is no longer the case.
  
  [1] Probably from: https://phabricator.kde.org/D10776

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12231

AFFECTED FILES
  cmake/build-pofiles.cmake

To: tcberner, #freebsd, sitter, apol
Cc: #frameworks, michaelh, ngraham, bruns

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

[Tobias C . Berner]

tcberner abandoned this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D5784

To: tcberner, #freebsd, poboiko, bruns
Cc: bruns, adridg, kfunk, #frameworks, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, alexeymin

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Tobias C . Berner]

tcberner abandoned this revision.
tcberner added a comment.


  Works for me

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco
Cc: bcooksley, rikmills, rakuco, kfunk, adridg, kossebau, #frameworks, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Tobias C . Berner]

tcberner added a comment.


  I think as @adridg points out that it should be a target, this should go in 
-- and the @kossebau already committed the proper workaround in D10485 
, right?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco
Cc: rikmills, rakuco, kfunk, adridg, kossebau, #frameworks, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Tobias C . Berner]

tcberner added reviewers: bshah, dfaure.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure
Cc: #frameworks, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Tobias C . Berner]

tcberner created this revision.
tcberner added reviewers: FreeBSD, mpyne.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
tcberner requested review of this revision.

REVISION SUMMARY
  This creates a custom target 'desktop_to_json_X' and then depends on
  it instead of the output file.
  
  This (hopefully) fixes the build failure noticed in the FreeBSD (and some 
linuxes)
  
  - 
https://build.kde.org/view/OS%20-%20FreeBSD/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/138/console
  - https://mail.kde.org/pipermail/kde-freebsd/2018-February/027372.html
  - https://www.mail-archive.com/kde-bugs-dist@kde.org/msg207825.html

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10450

AFFECTED FILES
  KF5CoreAddonsMacros.cmake

To: tcberner, #freebsd, mpyne
Cc: #frameworks, michaelh

D6253: Use FindInotify.cmake to decide wheter inotify is available.

[Tobias C. Berner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:59db8a5ea224: Use FindInotify.cmake to decide wheter 
inotify is available. (authored by tcberner).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6253?vs=15532&id=15584

REVISION DETAIL
  https://phabricator.kde.org/D6253

AFFECTED FILES
  CMakeLists.txt
  src/lib/CMakeLists.txt
  src/lib/io/kdirwatch.cpp

To: tcberner, #freebsd, dfaure, kfunk
Cc: #frameworks

D6253: Use FindInotify.cmake to decide wheter inotify is available.

[Tobias C. Berner]

tcberner updated this revision to Diff 15532.
tcberner added a comment.


  Fix identation.

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6253?vs=15531&id=15532

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6253

AFFECTED FILES
  CMakeLists.txt
  src/lib/CMakeLists.txt
  src/lib/io/kdirwatch.cpp

To: tcberner, #freebsd, dfaure
Cc: #frameworks

D6253: Use FindInotify.cmake to decide wheter inotify is available.

[Tobias C. Berner]

tcberner edited the summary of this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D6253

To: tcberner, #freebsd, dfaure
Cc: #frameworks

D6253: Use FindInotify.cmake to decide wheter inotify is available.

[Tobias C. Berner]

tcberner created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  FreeBSD also as sys/inotify.h available, but it is a library.
  
  We added FindInotify.cmake to ecm a while a go for this, but never got 
  around to upstream the rest of the patches.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6253

AFFECTED FILES
  CMakeLists.txt
  src/lib/CMakeLists.txt
  src/lib/io/kdirwatch.cpp

To: tcberner, #freebsd, dfaure
Cc: #frameworks

D6076: Do not depend on bash uncessarily, and do not validate icons by default.

[Tobias C. Berner]

tcberner updated this revision to Diff 15116.
tcberner added a comment.


  Add find_programm(SH_EXE sh)

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6076?vs=15115&id=15116

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6076

AFFECTED FILES
  CMakeLists.txt
  icons-dark/light2Dark
  optimize-svg.sh
  validate_svg.sh

To: tcberner, #freebsd, winterz
Cc: #frameworks

D6076: Do not depend on bash uncessarily, and do not validate icons by default.

[Tobias C. Berner]

tcberner updated this revision to Diff 15115.
tcberner added a comment.


  - Fix cmake
  - find_program call for xmllint

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6076?vs=15114&id=15115

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6076

AFFECTED FILES
  CMakeLists.txt
  icons-dark/light2Dark
  optimize-svg.sh
  validate_svg.sh

To: tcberner, #freebsd, winterz
Cc: #frameworks

D6076: Do not depend on bash uncessarily, and do not validate icons by default.

[Tobias C. Berner]

tcberner added a reviewer: winterz.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D6076

To: tcberner, #freebsd, winterz
Cc: #frameworks

D6076: Do not depend on bash uncessarily, and do not validate icons by default.

[Tobias C. Berner]

tcberner created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  I don't think it makes sense, that the icons are xmllint'ed every time 
someone builds the icons. 
  This is an action that should take place once, before cutting the next 
release.
  
  Also, from a first glance, the scripts do not actually require bash, and 
should work with -- let's call it 'standard' -- /bin/sh.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6076

AFFECTED FILES
  CMakeLists.txt
  icons-dark/light2Dark
  optimize-svg.sh
  validate_svg.sh

To: tcberner, #freebsd
Cc: #frameworks

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

[Tobias C. Berner]

tcberner updated this revision to Diff 14965.
tcberner added a comment.


  Use QStorageInfo.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5784?vs=14334&id=14965

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5784

AFFECTED FILES
  src/engine/fsutils.cpp

To: tcberner, #freebsd
Cc: kfunk, #frameworks

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

[Tobias C. Berner]

tcberner added a comment.


  Ok, I think I found the issue in QStorageInfo -- it calls getmntinfo() with 
`flags=0` [1] . Instead one of the valid arguments 1-4 [2].
  
  [1] 
https://github.com/qt/qtbase/blob/dev/src/corelib/io/qstorageinfo_unix.cpp#L199
  [2] 
https://svnweb.freebsd.org/base/head/sys/sys/mount.h?revision=318736&view=markup#l441

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D5784

To: tcberner, #freebsd
Cc: kfunk, #frameworks

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

[Tobias C. Berner]

tcberner planned changes to this revision.
tcberner added a comment.


  I agree. I'll try and figure out whats wrong inside QStorageInfo, and then 
update the review here to be using it.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D5784

To: tcberner, #freebsd
Cc: kfunk, #frameworks

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

[Tobias C. Berner]

tcberner added a comment.


  Hm, QStorageInfo does not seem to return anything sensible on FreeBSD:
  
""
name: ""
fileSystemType: ""
size: 0 MB
availableSize: 0 MB
  
  This is the output from the `QStorageInfo::root()` example.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D5784

To: tcberner, #freebsd
Cc: kfunk, #frameworks

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

[Tobias C. Berner]

tcberner created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  This is not really needed at the moment, as it only seems to be needed to 
check if the filesystem is btrfs.
  
  I'm however not sure, if the simpler code used for FreeBSD would not also 
work on linux :)

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D5784

AFFECTED FILES
  src/engine/fsutils.cpp

To: tcberner, #freebsd
Cc: #frameworks

D5766: Change default pkgconfig install path for FreeBSD

[Tobias C. Berner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:416c7e9facf9: Change default pkgconfig install path for 
FreeBSD (authored by tcberner).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5766?vs=14296&id=14305

REVISION DETAIL
  https://phabricator.kde.org/D5766

AFFECTED FILES
  modules/ECMGeneratePkgConfigFile.cmake

To: tcberner, #freebsd, apol, kfunk
Cc: kfunk, #frameworks, #build_system

D5766: Change default pkgconfig install path for FreeBSD

[Tobias C. Berner]

tcberner marked an inline comment as done.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D5766

To: tcberner, #freebsd, apol, kfunk
Cc: kfunk, #frameworks, #build_system

D5766: Change default pkgconfig install path for FreeBSD

[Tobias C. Berner]

tcberner updated this revision to Diff 14296.
tcberner added a comment.


  - Turn around cases of the if-clause.
  - Fix cmake `matches` -> `MATCHES`.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5766?vs=14285&id=14296

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5766

AFFECTED FILES
  modules/ECMGeneratePkgConfigFile.cmake

To: tcberner, #freebsd, apol, kfunk
Cc: kfunk, #frameworks, #build_system

D5766: Change default pkgconfig install path for FreeBSD

[Tobias C. Berner]

tcberner updated this revision to Diff 14285.
tcberner added a comment.


  Drop space after `if`.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5766?vs=14284&id=14285

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5766

AFFECTED FILES
  modules/ECMGeneratePkgConfigFile.cmake

To: tcberner, #freebsd, apol
Cc: #frameworks, #build_system

D5766: Change default pkgconfig install path for FreeBSD

[Tobias C. Berner]

tcberner created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.

REVISION SUMMARY
  FreeBSD, opposed to most other sytems, does not install pkgconfig files to
  lib/pkgconfig, but to libdata/pkgconfig.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5766

AFFECTED FILES
  modules/ECMGeneratePkgConfigFile.cmake

To: tcberner, #freebsd, apol
Cc: #frameworks, #build_system

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

[Tobias C. Berner]

tcberner added a comment.


  We talked about it some more, and think that it is maybe better to not do any 
cmake magic.
  
#ifdef st_birthtime
  if (buff.st_birthtime > 0) {
entry.insert(KIO::UDSEntry::UDS_CREATION_TIME, 
buff.st_birthtime);
}
#endif
#ifdev __st_birthtime 
  if (buff.__st_birthtime > 0) {
entry.insert(KIO::UDSEntry::UDS_CREATION_TIME, 
buff.__st_birthtime);
}
#endif 
  
  and so on. The first would add it for FreeBSD/NetBSD and the second for 
OpenBSD -- given, that the syscall for linux will be completely different too.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5138

To: tcberner, arrowdodger, rakuco, dfaure, adridg
Cc: aacid, kfunk, emmanuelp, #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

[Tobias C. Berner]

tcberner updated this revision to Diff 12745.
tcberner added a comment.


  Fix typo.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5138?vs=12744&id=12745

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5138

AFFECTED FILES
  src/ioslaves/file/CMakeLists.txt
  src/ioslaves/file/config-kioslave-file.h.cmake
  src/ioslaves/file/file.cpp

To: tcberner, arrowdodger, rakuco, dfaure, adridg
Cc: kfunk, emmanuelp, #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

[Tobias C. Berner]

tcberner updated this revision to Diff 12744.
tcberner added a comment.


  Add `#cmakedefine01 HAVE_ST_BIRTHTIME` to `config-kioslave-file.h.cmake`

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5138?vs=12743&id=12744

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5138

AFFECTED FILES
  src/ioslaves/file/CMakeLists.txt
  src/ioslaves/file/config-kioslave-file.h.cmake
  src/ioslaves/file/file.cpp

To: tcberner, arrowdodger, rakuco, dfaure, adridg
Cc: emmanuelp, #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

[Tobias C. Berner]

tcberner updated this revision to Diff 12743.
tcberner added a comment.


  Use cmake to check for `st_birthime`.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5138?vs=12704&id=12743

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5138

AFFECTED FILES
  src/ioslaves/file/CMakeLists.txt
  src/ioslaves/file/file.cpp

To: tcberner, arrowdodger, rakuco, dfaure, adridg
Cc: emmanuelp, #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

[Tobias C. Berner]

tcberner added a comment.


  F3114620: dolphin2.png 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D5138

To: tcberner, adridg, arrowdodger, rakuco, dfaure
Cc: #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

[Tobias C. Berner]

tcberner added reviewers: rakuco, dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D5138

To: tcberner, adridg, arrowdodger, rakuco, dfaure
Cc: #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

[Tobias C. Berner]

tcberner created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  It seems UDS_CREATION_TIME is never filled at all (as far as I could find in 
the short time I invested :D ).
  
  From the manpage:
  
st_birthtim  Time when the inode was created.
  
  This allows us to display file creation dates in (patched) dolphin.
  
  This is with respect to: 
  https://bugs.kde.org/show_bug.cgi?id=374063

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5138

AFFECTED FILES
  src/ioslaves/file/file.cpp

To: tcberner
Cc: #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

[Tobias C. Berner]

tcberner added reviewers: adridg, arrowdodger.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D5138

To: tcberner, adridg, arrowdodger
Cc: #frameworks