D24959: Add new preferences search icons

[TrickyRicky]

trickyricky26 accepted this revision.
trickyricky26 added a comment.
This revision is now accepted and ready to land.


  Sorry, I kind of forgot about this revision.
  But looks all good now!

REPOSITORY
  R266 Breeze Icons

BRANCH
  newSearchIcon

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham, trickyricky26
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D24959: Add new preferences search icons

[TrickyRicky]

trickyricky26 added a comment.


  What do you think of this? The symbol with 1px lines.
  
  F7727547: preferences-desktop-search.svg 

  
  F7727552: montage.png 
  I thought this might look nicer, but it is too thin IMO.
  
  In your current icon, the shadow is a bit off, the upper edge isn't quite 45° 
and it doesn't originate exactly from the circle. I can fix these tiny details 
if you like.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham, trickyricky26
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D24959: Add new preferences search icons

[TrickyRicky]

trickyricky26 added a comment.


  In D24959#556058 , @ngraham wrote:
  
  > Better now @trickyricky26?
  
  
  I do think the new version looks better, more because of the nicer 
proportions of the magnifying glass than the shadow.
  
  I think it's not optimal to add another symbol-on-single-color-circle icon, 
in addition to the bluetooth, user, accessibility etc. icons. It would be nice 
to have a more distinctive icon for this, but I don't have any concrete ideas 
for such a design. The previous icon for this was the magnifying glass on a 
file, but perhaps this isn't quite accurate here as the KCM deals with Baloo as 
well as krunner, which does more than only search for files.
  
  In any case, I would try making the symbol have 1px thickness to match the 
other similar preferences icons, perhaps even copy the symbol directly from the 
old symbol-on-file icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham, trickyricky26
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D24959: Add new preferences search icons

[TrickyRicky]

trickyricky26 requested changes to this revision.
trickyricky26 added a comment.
This revision now requires changes to proceed.


  On the technical side, we usually convert everything to paths, and even 
though I can't imagine Qt SVG Renderer would have a problem with `circle`, it 
might be better to convert the background to a path.
  
  As for the design, I think this can be improved. My suggestion would 
basically be to use the magnifying glass from the Kfind icon, which IMO fits 
better with Breeze because of the thinner lines and the longer handle, which 
make the symbol feel more balanced.
  Additionally, maybe you could try adding the Breeze-typical 45° shadow, which 
is usually used in these symbol-on-background icons, although it might not look 
right with the magnifying glass extending in the same direction.
  
  Overall I think this will be a nice addition.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham, trickyricky26
Cc: trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham

D24957: Add new baloo icons

[TrickyRicky]

trickyricky26 added a comment.


  Some of my thoughts on the new preferences-desktop-search icons 
(D24959#554523 ) also apply here: I 
think that lines of the magnifying glass symbol feel a bit too thick for 
Breeze, and IMO the large glass-to-handle ratio doesn't feel quite right, 
although I realize you have to fit that paw symbol in there. Also, this kind of 
icon is a classic candidate for the 45° degree shadow.
  
  I would also try making the paw symbol a bit more simple, perhaps by removing 
the ellipses between the bottom and the claws themselves, in order to make the 
design less visually noisy. Then it might also be possible to make the paw 
smaller in the 32px version.
  
  Maybe we can also come up with a more interesting background than a blue 
circle, which is quite bland, considering this is an application icon.

REPOSITORY
  R266 Breeze Icons

BRANCH
  newBalooIcon

REVISION DETAIL
  https://phabricator.kde.org/D24957

To: astippich, #vdg, ngraham, bruns
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24807: Fix incorrect rendering of 22px edit-opacity icon

[TrickyRicky]

trickyricky26 added reviewers: VDG, simgunz.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24807

To: trickyricky26, #vdg, simgunz
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24807: Fix incorrect rendering of 22px edit-opacity icon

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REVISION SUMMARY
  This patch should fix the incorrect rendering of the new 22px `edit-opacity` 
icon added in D24753 .
  The preview in Dolphin and Ikona no longer shows renders the file 
incorrectly, so should also resolve the issue for viewing in Okular and 
Cuttlefish.
  While optimizing the file, `svgo` altered some paths, which apparently 
resulted in the file rendering incorrectly in the Qt SVG Renderer, but not in 
Inkscape.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-edit-opacity-22px-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24807

AFFECTED FILES
  icons-dark/actions/22/edit-opacity.svg
  icons/actions/22/edit-opacity.svg

To: trickyricky26
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24753: Add edit-opacity icons

[TrickyRicky]

trickyricky26 added a comment.


  In D24753#550676 , @simgunz wrote:
  
  > First, thanks for the excellent work on the new icons for Okular. I really 
like them.
  >
  > I have noticed that the edit-opacity icon does not render correctly in some 
cases:
  >
  > F7636237: Screenshot_20191020_150623.png 

  >  Preview in Cuttlefish.
  >
  > F7636244: Screenshot_20191020_150857.png 

  >  Okular annotation toolbar
  
  
  Huh, I noticed that when copying the files in Dolphin, the preview also 
showed this exact distortion of the 22px icon (but not the 16px one). I'll see 
if I can make this work.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg, ngraham, ndavis
Cc: simgunz, ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24753: Add edit-opacity icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24753: Add edit-opacity icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 68262.
trickyricky26 added a comment.


  - Remove top stripe, reduce the opacity of the remaining stripes

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24753?vs=68223&id=68262

BRANCH
  arcpatch-D24753

REVISION DETAIL
  https://phabricator.kde.org/D24753

AFFECTED FILES
  icons-dark/actions/16/edit-opacity.svg
  icons-dark/actions/22/edit-opacity.svg
  icons/actions/16/edit-opacity.svg
  icons/actions/22/edit-opacity.svg

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24753: Add edit-opacity icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24753: Add edit-opacity icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24753: Add edit-opacity icons

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REVISION SUMMARY
  This patch adds edit-opacity icons requested by Okular for D15580 
.
  
  I'm not quite sure about the naming, and even if the Qt SVG renderer can 
handle this transparency. I also considered a style with a checkerboard 
pattern, which is the symbol for transparency e.g. in GIMP, but I felt this is 
not recognizable enough to most people.
  
  I think this should be the last icon needed for 
https://bugs.kde.org/show_bug.cgi?id=408283, so I'm tagging this as closing 
that bug.
  
  BUG: 408283
  FIXED-IN: 5.64

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-opacity-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24753

AFFECTED FILES
  icons-dark/actions/16/edit-opacity.svg
  icons-dark/actions/22/edit-opacity.svg
  icons/actions/16/edit-opacity.svg
  icons/actions/22/edit-opacity.svg

To: trickyricky26
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24598: Update elisa icon

[TrickyRicky]

trickyricky26 accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  elisa_updated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24537: Icons for windy weather

[TrickyRicky]

trickyricky26 added a comment.


  With the blue color, I like these icons. Please remember to update images in 
the test plan when you make changes such as this color change, they're very 
helpful for judging things e.g. on a phone.

REPOSITORY
  R266 Breeze Icons

BRANCH
  windy-weather-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg, ndavis, ngraham
Cc: trickyricky26, GB_2, vkrause, ndavis, kossebau, ngraham, 
kde-frameworks-devel, LeGast00n, michaelh, bruns

D24621: [RFC] New Konsole and Yakuake icons

[TrickyRicky]

trickyricky26 requested changes to this revision.
trickyricky26 added a comment.
This revision now requires changes to proceed.


  Before this is can be landed, you will have to also add/change the Konsole 
and Yakuake icons in the icons-dark directory.
  
  While I think these icons do look nice on their own and I quite like the 
clever design of the Yakuake Prompt / "Y" symbol, I don't think they fit the 
Breeze icon style very well. I think they are too boxy and flat (even though 
you used gradients) to fit in. I would suggest you try to use more slim lines, 
similar to the current Konsole icon, as well as gradients with bigger 
differences between the colors.
  
  In D24621#546750 , @ndavis wrote:
  
  > Maybe something like this? I'm not sure. F7592258: 
Screenshot_20191014_011043.png  F7592287: 
konsole.svg 
  
  
  I think these tabs look more Breeze-y, but still the icon looks quite flat 
and imo the thickness of the prompt symbol does not look right for a Breeze 
icon.
  
  In D24621#546750 , @ndavis wrote:
  
  > I think the K in most of the Konsole variants is a bit too much and I think 
it would be too distracting. It's not immediately obvious that it's a K. When I 
look at it, the first thing my eyes see is "**>**__|**<**__", rather than 
"**>**__K__", which is confusing. IIRC the discussion about the redesign of 
these icons started with the problem that they are not recognizable enough as 
standalone apps, not just as genric terminal emulators. I think we should try 
to experiment some more with the "K" symbol until we maybe find a variant that 
we like and fits well enough with other Breeze icons. Otherwise, I don't 
necessarily think F7592258: Screenshot_20191014_011043.png 
  or one of the variant B icons will be 
an improvement over the current Konsole icon, which I personally like because 
of it's simplicity.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

To: mglb, #vdg, #konsole, #yakuake, trickyricky26
Cc: trickyricky26, ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D24598: Update elisa icon

[TrickyRicky]

trickyricky26 requested changes to this revision.
trickyricky26 added a comment.
This revision now requires changes to proceed.


  Please optimize the SVG files using one of these methods: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization
  
  In D24598#546420 , @astippich 
wrote:
  
  > F7585764: elisaSmallNew.png 
  >
  > F7585766: elisaBigNew.png 
  
  
  About the design itself, I think the area where the "Elisa" branding was 
previously looks a bit empty now. I would suggest you either find some nice 
pattern to put there or simply center the tape window in the colored area.
  Overall I think this is a good improvement, the letters in that icon were 
what kept me from putting Elisa permanently in my dock :P

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24493: Add draw-highlight action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-highlight-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24493

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24555: Add draw-arrow icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24555

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24555: Add draw-arrow icons

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-draw-arrow-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24555

AFFECTED FILES
  icons-dark/actions/16/draw-arrow.svg
  icons-dark/actions/22/draw-arrow.svg
  icons/actions/16/draw-arrow.svg
  icons/actions/22/draw-arrow.svg

To: trickyricky26
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24493: Add draw-highlight action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24493

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24493: Add draw-highlight action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24493

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24493: Add draw-highlight action icons

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-highlight-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24493

AFFECTED FILES
  icons-dark/actions/16/draw-highlight.svg
  icons-dark/actions/22/draw-highlight.svg
  icons/actions/16/draw-highlight.svg
  icons/actions/22/draw-highlight.svg

To: trickyricky26
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24412: Add edit-line-width icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24412

To: trickyricky26, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24412: Add edit-line-width icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24412

To: trickyricky26, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24412: Add edit-line-width icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 67348.
trickyricky26 added a comment.


  - Use design with multiple lines of different thickness

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24412?vs=67319&id=67348

BRANCH
  add-line-width-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24412

AFFECTED FILES
  icons-dark/actions/16/edit-line-width.svg
  icons-dark/actions/22/edit-line-width.svg
  icons/actions/16/edit-line-width.svg
  icons/actions/22/edit-line-width.svg

To: trickyricky26, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24412: Add edit-line-width icons

[TrickyRicky]

trickyricky26 planned changes to this revision.
trickyricky26 added a comment.


  In D24412#542056 , @ndavis wrote:
  
  > I think something similar to this line width icon would work well: 
F6304104: Lines.png 
  >  Inkscape uses a similar icon, but for all line styles: F7517386: 
Screenshot_20191004_143517.png 
  
  
  Yeah, that seems like a more obvious choice.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24412

To: trickyricky26, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24412: Add edit-line-width icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24412

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24412: Add edit-line-width icons

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-line-width-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24412

AFFECTED FILES
  icons-dark/actions/16/edit-line-width.svg
  icons-dark/actions/22/edit-line-width.svg
  icons/actions/16/edit-line-width.svg
  icons/actions/22/edit-line-width.svg

To: trickyricky26
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24253: Make 22px squiggle more like 16px squiggle

[TrickyRicky]

trickyricky26 added a comment.


  Visually I think this is fine and a good improvement.
  
  I wonder why your SVGs have two seperate paths as opposed to unifying them 
into one path (as I usually do)? Just curious if there is any benefit to using 
one approach above the other.
  Also, judging by the MDN Page 
 I don't 
think the `fill-rule="evenodd"` does anything here.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24253

To: ndavis, #vdg
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24185: Add format-text-underline-squiggle actions icons

[TrickyRicky]

trickyricky26 added a comment.


  In D24185#537880 , @ngraham wrote:
  
  > Now the butt ends are gone again. :)
  
  
  Yes, I think it makes more sense for this underline to be a visual crop of a 
longer one as they would appear in eg. LibreOffice Writer. It should also make 
for a tiny bit more contrast at the ends at 100%

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D24185

REVISION DETAIL
  https://phabricator.kde.org/D24185

To: trickyricky26, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24185: Add format-text-underline-squiggle actions icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D24185

REVISION DETAIL
  https://phabricator.kde.org/D24185

To: trickyricky26, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24185: Add format-text-underline-squiggle actions icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 66827.
trickyricky26 added a comment.
This revision is now accepted and ready to land.


  - Use sine wave as suggested by ndavis

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24185?vs=66778&id=66827

BRANCH
  arcpatch-D24185

REVISION DETAIL
  https://phabricator.kde.org/D24185

AFFECTED FILES
  icons-dark/actions/16/format-text-underline-squiggle.svg
  icons-dark/actions/22/format-text-underline-squiggle.svg
  icons/actions/16/format-text-underline-squiggle.svg
  icons/actions/22/format-text-underline-squiggle.svg

To: trickyricky26, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24185: Add format-text-underline-squiggle actions icons

[TrickyRicky]

trickyricky26 planned changes to this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24185

To: trickyricky26, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24185: Add format-text-underline-squiggle actions icons

[TrickyRicky]

trickyricky26 added a comment.


  In D24185#537365 , @ndavis wrote:
  
  > I have some improvements to the squiggle, but unfortunately, I have no 
internet in my house except on my phone until the 27th.
  >
  > basically, I
  >
  > - made a rectangle
  > - gave it a stroke
  > - shrunk the height to fit in the 12x3 area under the U
  > - used the function plotter to generate a sine wave
  >   - adjusted the width and function x/y parameters of the function plotter 
until I got exactly the right length from the low point (left) to the high 
point (right)
  > - converted the stroke to a path
  > - cut it at the low point (left)/high point (right)
  > - simplified the path
  >
  >   this probably could have been simpler
  
  
  I tried to do this with a Sine wave, but I couldn't get it to generate a 
fitting wave, so I guess I abandoned that approach prematurely. I'll try again 
with some of your parameters.

REPOSITORY
  R266 Breeze Icons

BRANCH
  format-text-underline-squiggle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24185

To: trickyricky26, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24185: Add format-text-underline-squiggle actions icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 66778.
trickyricky26 added a comment.


  - Use butt line ending for slightly nicer asthetics

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24185?vs=66738&id=66778

BRANCH
  format-text-underline-squiggle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24185

AFFECTED FILES
  icons-dark/actions/16/format-text-underline-squiggle.svg
  icons-dark/actions/22/format-text-underline-squiggle.svg
  icons/actions/16/format-text-underline-squiggle.svg
  icons/actions/22/format-text-underline-squiggle.svg

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24185: Add format-text-underline-squiggle actions icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24185

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24185: Add format-text-underline-squiggle actions icons

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  format-text-underline-squiggle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24185

AFFECTED FILES
  icons-dark/actions/16/format-text-underline-squiggle.svg
  icons-dark/actions/22/format-text-underline-squiggle.svg
  icons/actions/16/format-text-underline-squiggle.svg
  icons/actions/22/format-text-underline-squiggle.svg

To: trickyricky26
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21169: Add app icon for the Kirogi Drone control app

[TrickyRicky]

trickyricky26 updated this revision to Diff 66594.
trickyricky26 added a comment.


  - A tiny bit more optimized

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21169?vs=57954&id=66594

BRANCH
  kirogi-app-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21169

AFFECTED FILES
  icons-dark/apps/48/kirogi.svg
  icons/apps/48/kirogi.svg

To: trickyricky26, hein, #vdg, ngraham
Cc: ognarb, ngraham, apol, kde-frameworks-devel, hein, LeGast00n, GB_2, 
michaelh, bruns

D21169: Add app icon for the Kirogi Drone control app

[TrickyRicky]

trickyricky26 added a comment.


  Should I land this or abandon it?
  It doesn't really make a difference if the icon is in Breeze in addition to 
being shipped with the app, but IMO it would also be strange to not have this 
Breeze-style icon for a KDE app in Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg
Cc: ngraham, apol, kde-frameworks-devel, hein, LeGast00n, GB_2, michaelh, bruns

D23761: Make small recent documents icons look like documents and improve clock emblems

[TrickyRicky]

trickyricky26 added a comment.


  In D23761#527355 , @meven wrote:
  
  > Is that the expected result ?
  >
  > F7328222: Screenshot_20190907_230008.png 

  >
  > If so, it needs some polishing IMO.
  
  
  In your screenshot, it looks like the 32px version of `document-open-recent` 
is used, the removal/visual fixing of which is discussed in D23778 
.
  
  The `folder-open-recent` icon appearsto use a smaller size than that, which 
is inappropriate.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23761

To: ngraham, #vdg, ndavis
Cc: trickyricky26, kde-frameworks-devel, meven, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23782: Add "edit-none-border" icon

[TrickyRicky]

trickyricky26 added a comment.


  In D23782#527623 , @ndavis wrote:
  
  > What is this icon used for?
  
  
  @GB_2 used it here: https://phabricator.kde.org/D23779#527639. It is used for 
the KWin no window border context menu entry.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23782

To: GB_2, #vdg
Cc: trickyricky26, ndavis, ngraham, broulik, kde-frameworks-devel, #vdg, 
LeGast00n, GB_2, michaelh, bruns

D23464: Add breeze icons for ROOT cern files

[TrickyRicky]

trickyricky26 added a comment.


  My thoughts on your submission:
  
  For the 16px and 22px designs, I would with the designs @ndavis proposed here:
  
  In D23464#521662 , @ndavis wrote:
  
  > F7290924: mimetypes.tar.gz 
  
  
  Yes, the symbol there has the same thickness throughout the root sign, which 
differs from the original branding, but this makes the icon much more 
discernable and it's not like you could make out that difference at that size 
anyway.
  As @noahdvs mentioned above, the white background should be removed and the 
entire symbol should be made up of one filled path with no outline (!). This is 
important to keep the icon looking as intended with the Qt SVG renderer.
  
  As for the 32px and 64px designs, I would much prefer using only two colors 
by placing white variants of the smaller icons on top of a blue document 
background. 
  Example for the 32px icon:
  F7293342: application-x-root-32.png 
  
  I think this fits much better with other Breeze mimetype icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[TrickyRicky]

trickyricky26 added a comment.


  In D23116#511430 , @GB_2 wrote:
  
  > Maybe instead of hardcoding the blue and red colors you can use the 
stylesheet colors `ButtonFocus` and `NegativeText`: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets
  
  
  I thought about that, too, and while the red used in the icon is exactly 
`NegativeText`, the blue in the current icon is darker and has a less vibrant 
hue than `ButtonFocus`, so I'm not quite comfortable with using that for the 
blue color. Do we have this darker blue as a CSS color that we can use in this 
way? I see this dark blue is also used in the `channelmixer` icon, which has 
its colors hardcoded as well. I also don't think it would make sense to only 
use stylesheet colors for only one of these two colors.
  
  Btw, in the relevant HIG page 
(https://hig.kde.org/style/icon.html#action-and-status-icons) the color 
`ColorScheme-ButtonFocus` in the page you linked is called 
`ColorScheme-Highlight` and there are other anme differences, too. Is one of 
these inaccurate, or do they both work?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg, ngraham, ndavis
Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[TrickyRicky]

trickyricky26 marked 4 inline comments as done.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 63652.
trickyricky26 added a comment.


  - Fix stylesheet ids

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23116?vs=63626&id=63652

BRANCH
  fix-depth-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23116

AFFECTED FILES
  icons-dark/actions/22/depth16to8.svg
  icons-dark/actions/22/depth8to16.svg
  icons/actions/22/depth16to8.svg
  icons/actions/22/depth8to16.svg

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[TrickyRicky]

trickyricky26 added a comment.


  I am not quite sure of the version for the FIXED-IN tag.
  
  Also, this bug was reported in digikam running on Windows 10, are there any 
additional steps necessary to get this change from breeze-icons to the digikam 
Windows build?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-depth-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23116

AFFECTED FILES
  icons-dark/actions/22/depth16to8.svg
  icons-dark/actions/22/depth8to16.svg
  icons/actions/22/depth16to8.svg
  icons/actions/22/depth8to16.svg

To: trickyricky26
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21169: Add app icon for the Kirogi Drone control app

[TrickyRicky]

trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg
Cc: kde-frameworks-devel, hein, michaelh, ngraham, bruns

D21169: Add app icon for the Kirogi Drone control app

[TrickyRicky]

trickyricky26 created this revision.
trickyricky26 added a reviewer: hein.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REVISION SUMMARY
  Adds an app icon for @hein's upcoming Kirogi app.

REPOSITORY
  R266 Breeze Icons

BRANCH
  kirogi-app-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21169

AFFECTED FILES
  icons-dark/apps/48/kirogi.svg
  icons/apps/48/kirogi.svg

To: trickyricky26, hein
Cc: kde-frameworks-devel, hein, michaelh, ngraham, bruns

D20063: Sublime Merge Icon.

[TrickyRicky]

trickyricky26 added a comment.


  I think the cyan color is too bright and saturated. It fits the original 
branding well, but stands out from other Breeze icons.
  
  I would suggest using a darker, more blue than cyan color.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20063

To: otavva, #vdg, ndavis
Cc: trickyricky26, filipf, ngraham, #vdg, kde-frameworks-devel, arvidhansson, 
ian, hannahk, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, 
GB_2, rooty, mglb, michaelh, crozbo, ndavis, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D19575: Add collapse-all and expand-all action icons

[TrickyRicky]

trickyricky26 added a comment.


  Sure, go ahead. I'm busy right now

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 53522.
trickyricky26 added a comment.


  - Use design by @ndavis with tighter spacing

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19575?vs=53430&id=53522

BRANCH
  collapse-expand-all-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19575

AFFECTED FILES
  icons-dark/actions/16/collapse-all.svg
  icons-dark/actions/16/expand-all.svg
  icons-dark/actions/22/collapse-all.svg
  icons-dark/actions/22/expand-all.svg
  icons-dark/actions/24/collapse-all.svg
  icons-dark/actions/24/expand-all.svg
  icons-dark/actions/32/collapse-all.svg
  icons-dark/actions/32/expand-all.svg
  icons-dark/actions/symbolic/collapse-all-symbolic.svg
  icons-dark/actions/symbolic/expand-all-symbolic.svg
  icons/actions/16/collapse-all.svg
  icons/actions/16/expand-all.svg
  icons/actions/22/collapse-all.svg
  icons/actions/22/expand-all.svg
  icons/actions/24/collapse-all.svg
  icons/actions/24/expand-all.svg
  icons/actions/32/collapse-all.svg
  icons/actions/32/expand-all.svg
  icons/actions/symbolic/collapse-all-symbolic.svg
  icons/actions/symbolic/expand-all-symbolic.svg

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 53430.
trickyricky26 added a comment.


  - Name -symbolic icons properly

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19575?vs=53315&id=53430

BRANCH
  collapse-expand-all-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19575

AFFECTED FILES
  icons-dark/actions/16/collapse-all.svg
  icons-dark/actions/16/expand-all.svg
  icons-dark/actions/22/collapse-all.svg
  icons-dark/actions/22/expand-all.svg
  icons-dark/actions/24/collapse-all.svg
  icons-dark/actions/24/expand-all.svg
  icons-dark/actions/32/collapse-all.svg
  icons-dark/actions/32/expand-all.svg
  icons-dark/actions/symbolic/collapse-all-symbolic.svg
  icons-dark/actions/symbolic/expand-all-symbolic.svg
  icons/actions/16/collapse-all.svg
  icons/actions/16/expand-all.svg
  icons/actions/22/collapse-all.svg
  icons/actions/22/expand-all.svg
  icons/actions/24/collapse-all.svg
  icons/actions/24/expand-all.svg
  icons/actions/32/collapse-all.svg
  icons/actions/32/expand-all.svg
  icons/actions/symbolic/collapse-all-symbolic.svg
  icons/actions/symbolic/expand-all-symbolic.svg

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19575: Add collapse-all and expand-all action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19575: Add collapse-all and expand-all action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19575: Add collapse-all and expand-all action icons

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  collapse-expand-all-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19575

AFFECTED FILES
  icons-dark/actions/16/collapse-all.svg
  icons-dark/actions/16/expand-all.svg
  icons-dark/actions/22/collapse-all.svg
  icons-dark/actions/22/expand-all.svg
  icons-dark/actions/24/collapse-all.svg
  icons-dark/actions/24/expand-all.svg
  icons-dark/actions/32/collapse-all.svg
  icons-dark/actions/32/expand-all.svg
  icons-dark/actions/symbolic/collapse-all.svg
  icons-dark/actions/symbolic/expand-all.svg
  icons/actions/16/collapse-all.svg
  icons/actions/16/expand-all.svg
  icons/actions/22/collapse-all.svg
  icons/actions/22/expand-all.svg
  icons/actions/24/collapse-all.svg
  icons/actions/24/expand-all.svg
  icons/actions/32/collapse-all.svg
  icons/actions/32/expand-all.svg
  icons/actions/symbolic/collapse-all.svg
  icons/actions/symbolic/expand-all.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19307: Enforce new muted icon style in all action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19307

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19307: Enforce new muted icon style in all action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19307

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19307: Enforce new muted icon style in all action icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 52566.
trickyricky26 added a comment.


  - Change 16px player-volume-muted to symlink in order to pass duplicate test

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19307?vs=52543&id=52566

BRANCH
  correct-muted-action-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19307

AFFECTED FILES
  icons-dark/actions/16/player-volume-muted.svg
  icons-dark/actions/24/audio-volume-low.svg
  icons-dark/actions/24/audio-volume-medium.svg
  icons-dark/actions/24/audio-volume-muted.svg
  icons/actions/16/player-volume-muted.svg
  icons/actions/24/audio-volume-low.svg
  icons/actions/24/audio-volume-medium.svg
  icons/actions/24/audio-volume-muted.svg

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19307: Enforce new muted icon style in all action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19307

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19307: Enforce new muted icon style in all action icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 52543.
trickyricky26 added a comment.


  - Lower opacity of inactive sound waves to 0.25

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19307?vs=52542&id=52543

BRANCH
  correct-muted-action-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19307

AFFECTED FILES
  icons-dark/actions/16/player-volume-muted.svg
  icons-dark/actions/24/audio-volume-low.svg
  icons-dark/actions/24/audio-volume-medium.svg
  icons-dark/actions/24/audio-volume-muted.svg
  icons/actions/16/player-volume-muted.svg
  icons/actions/24/audio-volume-low.svg
  icons/actions/24/audio-volume-medium.svg
  icons/actions/24/audio-volume-muted.svg

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19307: Enforce new muted icon style in all action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19307

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19307: Enforce new muted icon style in all action icons

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  correct-muted-action-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19307

AFFECTED FILES
  icons-dark/actions/16/player-volume-muted.svg
  icons-dark/actions/24/audio-volume-muted.svg
  icons/actions/16/player-volume-muted.svg
  icons/actions/24/audio-volume-muted.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18986: [breeze-icons] Add video camera icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 52165.
trickyricky26 added a comment.


  - Add -symbolic symlinks to the 16px version

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18986?vs=52161&id=52165

BRANCH
  arcpatch-D18986

REVISION DETAIL
  https://phabricator.kde.org/D18986

AFFECTED FILES
  icons-dark/devices/16/camera-video.svg
  icons-dark/devices/22/camera-video.svg
  icons-dark/devices/64/camera-video.svg
  icons-dark/devices/symbolic/camera-video-symbolic.svg
  icons/devices/16/camera-video.svg
  icons/devices/22/camera-video.svg
  icons/devices/64/camera-video.svg
  icons/devices/symbolic/camera-video-symbolic.svg

To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D18986

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 52161.
trickyricky26 added a comment.


  - Add the bottom 1px shadow

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18986?vs=52154&id=52161

BRANCH
  arcpatch-D18986

REVISION DETAIL
  https://phabricator.kde.org/D18986

AFFECTED FILES
  icons-dark/devices/16/camera-video.svg
  icons-dark/devices/22/camera-video.svg
  icons-dark/devices/64/camera-video.svg
  icons/devices/16/camera-video.svg
  icons/devices/22/camera-video.svg
  icons/devices/64/camera-video.svg

To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 52154.
trickyricky26 added a comment.


  - Improve contrast by making the camera silver, add Breeze-style shadows to 
screen and buttons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18986?vs=52151&id=52154

BRANCH
  arcpatch-D18986

REVISION DETAIL
  https://phabricator.kde.org/D18986

AFFECTED FILES
  icons-dark/devices/16/camera-video.svg
  icons-dark/devices/22/camera-video.svg
  icons-dark/devices/64/camera-video.svg
  icons/devices/16/camera-video.svg
  icons/devices/22/camera-video.svg
  icons/devices/64/camera-video.svg

To: trickyricky26, #vdg, hein, ndavis, rooty
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: trickyricky26, #vdg, hein, ndavis, rooty
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 52151.
trickyricky26 added a comment.


  - Use a 64px design with a shotgun-type mic; use steeper angle for the lens 
on small versions

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18986?vs=52021&id=52151

BRANCH
  arcpatch-D18986

REVISION DETAIL
  https://phabricator.kde.org/D18986

AFFECTED FILES
  icons-dark/devices/16/camera-video.svg
  icons-dark/devices/22/camera-video.svg
  icons-dark/devices/64/camera-video.svg
  icons/devices/16/camera-video.svg
  icons/devices/22/camera-video.svg
  icons/devices/64/camera-video.svg

To: trickyricky26, #vdg, hein, ndavis, rooty
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: trickyricky26, #vdg, hein, ndavis, rooty
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[TrickyRicky]

trickyricky26 commandeered this revision.
trickyricky26 added a reviewer: rooty.
trickyricky26 added a comment.


  I will make some minor changes to the 64px design.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: trickyricky26, #vdg, hein, ndavis, rooty
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19020: [breeze-icons] Revamp system.svgz

[TrickyRicky]

trickyricky26 added a comment.


  As they are now it's long, short, long (exact same length as rectangle number 
1), shorter than height (which looks bad imo). There are no medium lengths and 
the same length is used twice. I would suggest giving every bar a different 
length.
  
  If you're going to remove the spaces, this won't be an issue, but I would not 
remove the spaces until we are certain that spaces are not allowed in the real 
thing.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19020: [breeze-icons] Revamp system.svgz

[TrickyRicky]

trickyricky26 added a comment.


  I like it!
  
  I think the "Type User" Icon would look better if the bars acting as 
placeholder text were a bit less regular in width and would not be shorter than 
they are tall (which is the case for the rightmost rectangle).
  Also, can the usernames in the type user field contain spaces? If not, it 
might not be fitting to use multiple split rectangles to represent the 
username, as these gaps represent spaces.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18986: [breeze-icons] Add video camera icons

[TrickyRicky]

trickyricky26 added a comment.


  In D18986#411807 , @ngraham wrote:
  
  > I like the head-on camcorder style, but there's the risk that it's less 
recognizable than the "classic" style of video recorder icon that's used pretty 
much everywhere. If we go with the head-on style, it needs to be //perfect//.
  
  
  To add to this, this type of camcorder was a design trend that pretty much 
stopped a few years ago as smartphone cameras got better. This means this style 
will probably become less recognizable in the future. Also it looks completely 
different than your 16px and 22px icons.
  
  I would suggest adding a handle with the integrated microphone to the 
"classic" video camera design.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[TrickyRicky]

trickyricky26 added a comment.


  I think the monochrome version is fine.
  For the colorful version, I suggest making the screen much bigger if that 
side isn't going to be filled with more buttons or the like.
  
  Also the partial outlines only on the top and bottom feel weird to me. I know 
these are present in `camera-photo` as well, so perhaps that should also be 
changed. I just think it would look nicer if the border went all the way around 
the camera body and across the front of the lens as well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18940: Add battery icons

[TrickyRicky]

trickyricky26 added a comment.


  In D18940#410980 , @ndavis wrote:
  
  > I think having a different location based on battery level would get 
annoying
  
  
  You're probably right.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18940

To: ndavis, #vdg, hein
Cc: filipf, trickyricky26, kde-frameworks-devel, hein, michaelh, ngraham, bruns

D18959: [breeze-icons] Add monochrome/smaller SD card and memory stick icons

[TrickyRicky]

trickyricky26 added a comment.


  Try rendering pngs of these icons with the montage-breeze commands found 
here: https://invent.kde.org/ndavis/hig-kde-org/wikis/home

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18959

To: rooty, #vdg, broulik
Cc: trickyricky26, kde-frameworks-devel, michaelh, ngraham, bruns

D18940: Add battery icons

[TrickyRicky]

trickyricky26 added a comment.


  I like it!
  Would you consider moving the green charging to either the filled-in or the 
white part where the symbol is currently above the line where the filled-in 
part ends?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18940

To: ndavis, #vdg, hein
Cc: trickyricky26, kde-frameworks-devel, hein, michaelh, ngraham, bruns

D18901: Add device icons for drones

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18901

To: trickyricky26, #vdg, hein
Cc: ngraham, hein, kde-frameworks-devel, michaelh, bruns

D18901: Add device icons for drones

[TrickyRicky]

trickyricky26 updated this revision to Diff 51351.
trickyricky26 added a comment.


  - Use a circular design for the rotor to make it more recognisable

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18901?vs=51323&id=51351

BRANCH
  drone-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18901

AFFECTED FILES
  icons-dark/devices/16/uav-quadcopter.svg
  icons-dark/devices/16/uav.svg
  icons-dark/devices/22/uav-quadcopter.svg
  icons-dark/devices/22/uav.svg
  icons/devices/16/uav-quadcopter.svg
  icons/devices/16/uav.svg
  icons/devices/22/uav-quadcopter.svg
  icons/devices/22/uav.svg

To: trickyricky26, #vdg, hein
Cc: ngraham, hein, kde-frameworks-devel, michaelh, bruns

D18901: Add device icons for drones

[TrickyRicky]

trickyricky26 planned changes to this revision.
trickyricky26 added a comment.


  In D18901#409255 , @ngraham wrote:
  
  > From a distance, I wonder if those stationary rotors really connote the 
right thing. How hard would it be to make them look spinning, by replacing them 
with circles instead?
  
  
  I agree. I will experiment with different circles as rotors.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18901

To: trickyricky26, #vdg, hein
Cc: ngraham, hein, kde-frameworks-devel, michaelh, bruns

D18901: Add device icons for drones

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added reviewers: VDG, hein.
trickyricky26 added a subscriber: hein.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18901

To: trickyricky26, #vdg, hein
Cc: hein, kde-frameworks-devel, michaelh, ngraham, bruns

D18901: Add device icons for drones

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  drone-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18901

AFFECTED FILES
  icons-dark/devices/16/uav-quadcopter.svg
  icons-dark/devices/16/uav.svg
  icons-dark/devices/22/uav-quadcopter.svg
  icons-dark/devices/22/uav.svg
  icons/devices/16/uav-quadcopter.svg
  icons/devices/16/uav.svg
  icons/devices/22/uav-quadcopter.svg
  icons/devices/22/uav.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

[TrickyRicky]

trickyricky26 updated this revision to Diff 50703.
trickyricky26 added a comment.


  - Use a less flat gradient with a silver ringer

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18533?vs=50280&id=50703

BRANCH
  improve-notification-bell-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18533

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-notification-bell.svg
  icons/preferences/32/preferences-desktop-notification-bell.svg

To: trickyricky26, #vdg
Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

[TrickyRicky]

trickyricky26 added a comment.


  I changed the shape a bit, but making it less flat is difficult: Linear 
gradients look off because of the curvature of the bell.
  
  Other options are blurring a curved object or using mesh gradients, but I'm 
not sure how well, if it all, these will work in icons.
  This is what I have:
  F6581498: preferences-desktop-notification-bell-new.svg.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

[TrickyRicky]

trickyricky26 planned changes to this revision.
trickyricky26 added a comment.


  I will try to visually improve the design.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: ndavis, djarvie, kde-frameworks-devel, michaelh, ngraham, bruns

D18554: (Hopefully) rebase on master

[TrickyRicky]

trickyricky26 abandoned this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18554

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18439: Add proper edit-delete-shred icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 50341.
trickyricky26 added a comment.


  Hopefully finally rebase on master, please?

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18439?vs=50116&id=50341

BRANCH
  arcpatch-D18439

REVISION DETAIL
  https://phabricator.kde.org/D18439

AFFECTED FILES
  icons-dark/actions/16/edit-delete-shred.svg
  icons-dark/actions/22/edit-delete-shred.svg
  icons-dark/actions/24/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete.svg
  icons/actions/16/edit-delete-shred.svg
  icons/actions/22/edit-delete-shred.svg
  icons/actions/24/edit-delete-shred.svg
  icons/actions/32/edit-delete-shred.svg
  icons/actions/32/edit-delete.svg

To: trickyricky26, #vdg, ndavis, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D18554: (Hopefully) rebase on master

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D18439

REVISION DETAIL
  https://phabricator.kde.org/D18554

AFFECTED FILES
  icons-dark/actions/16/edit-delete-shred.svg
  icons-dark/actions/22/edit-delete-shred.svg
  icons-dark/actions/24/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete.svg
  icons/actions/16/edit-delete-shred.svg
  icons/actions/22/edit-delete-shred.svg
  icons/actions/24/edit-delete-shred.svg
  icons/actions/32/edit-delete-shred.svg
  icons/actions/32/edit-delete.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18553: Add 32px changes

[TrickyRicky]

trickyricky26 abandoned this revision.
trickyricky26 added a comment.


  This was created by mistake when I tried to work around Phabricators symlink 
bug. It shall remain a testament to this terrible pain facing developers.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18553

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18553: Add 32px changes

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D18439_1

REVISION DETAIL
  https://phabricator.kde.org/D18553

AFFECTED FILES
  icons-dark/actions/32/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete.svg
  icons/actions/32/edit-delete-shred.svg
  icons/actions/32/edit-delete.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18552: Add trim margins and trim to selection icons

[TrickyRicky]

trickyricky26 added a comment.


  In D18552#400508 , @ngraham wrote:
  
  > I think the differences between those icon sizes is okay. If it's 
considered a problem, maybe we could make the 32px version match the smaller 
ones and omit the bottom line. I imagine adding a bottom line to the smaller 
sizes wasn't visually acceptable?
  
  
  Yes, it is not possible at smaller sizes due to space constraints.

REPOSITORY
  R266 Breeze Icons

BRANCH
  okular-trim-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18552

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D18552: Add trim margins and trim to selection icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  okular-trim-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18552

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D18552: Add trim margins and trim to selection icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 50336.
trickyricky26 added a comment.
This revision is now accepted and ready to land.


  - Enlarge faded lines in trim-to-selection icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18552?vs=50334&id=50336

BRANCH
  okular-trim-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18552

AFFECTED FILES
  icons-dark/actions/16/trim-margins.svg
  icons-dark/actions/16/trim-to-selection.svg
  icons-dark/actions/22/trim-margins.svg
  icons-dark/actions/22/trim-to-selection.svg
  icons-dark/actions/24/trim-margins.svg
  icons-dark/actions/24/trim-to-selection.svg
  icons-dark/actions/32/trim-margins.svg
  icons-dark/actions/32/trim-to-selection.svg
  icons/actions/16/trim-margins.svg
  icons/actions/16/trim-to-selection.svg
  icons/actions/22/trim-margins.svg
  icons/actions/22/trim-to-selection.svg
  icons/actions/24/trim-margins.svg
  icons/actions/24/trim-to-selection.svg
  icons/actions/32/trim-margins.svg
  icons/actions/32/trim-to-selection.svg

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns