D13698: Improve ECMAddAppIconMacro.
vpinon added inline comments. INLINE COMMENTS > dschmidt wrote in FindIcoTool.cmake:1 > @vpinon Can you let me know what you want here? Hello, FindIcoTool.cmake is largely copied from FindPng2Ico.cmake, I'm even not sure I can really claim the copyright. In any case, I would choose the same license as all other ECM files (among which FindPng2Ico.cmake), which doesn't give its name but I believe is LGPLv2? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth, vpinon, apol, alexmerry Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
D8427: Allow cross compiling resource file
vpinon added a comment. Note: if you want to see the rest of frameworks cross-building for Kdenlive: https://github.com/vpinon/mxe/tree/master/plugins/kdeframeworks REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8427 To: vpinon, apol, kfunk Cc: #frameworks, bartoloni, benjaminnelan, afarid, fernandoteles, mardelle
D8427: Allow cross compiling resource file
vpinon added a comment. Thank you Aleix, You're right! //Before// launching cmake for cross compiling, I build the tool for host (this requires to have Qt5 dev files on build host): I haven't found a way to access the host compiler & libs //within// cmake (which has a toolchain file to switch to cross-compiling). My complete cross compiling sequence is (in Makefile syntax for MXE): cd "$(1)" && $(BUILD_CXX) -std=c++11 qrcAlias.cpp -o $(PREFIX)/bin/qrcAlias -fPIC $(shell pkg-config --cflags Qt5Core --libs Qt5Core) mkdir "$(1)/build" cd "$(1)/build" && cmake .. \ -DCMAKE_TOOLCHAIN_FILE="$(CMAKE_TOOLCHAIN_FILE)" \ -DCMAKE_BUILD_TYPE=Release \ -DKDE_INSTALL_USE_QT_SYS_PATHS=ON \ -DBUILD_TESTING=OFF \ -DBINARY_ICONS_RESOURCE=ON \ -DQRCALIAS_EXECUTABLE=$(PREFIX)/bin/qrcAlias $(MAKE) -C "$(1)/build" -j $(JOBS) install Would you have directions for a better approach? Or should I just add in comment the line to build qrcAlias? I wanted to have a look at how KF5_HOST_TOOLING works, but couldn't find where it is defined in ECM or in the frameworks that use it (kdecoration, kdeclarative)... REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8427 To: vpinon, apol, kfunk Cc: #frameworks, bartoloni, benjaminnelan, afarid, fernandoteles, mardelle
D8428: Fix cross-compiling with MinGW (MXE)
vpinon created this revision. vpinon added reviewers: vonreth, habacker. vpinon added a project: Kdenlive. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY While cross-compiling Kdenlive with MXE (mingw64), I don't get pid_t properly defined. This patch solves the situation on my side TEST PLAN I only tested the cross-building, maybe someone having Windows MinGW development environment could check it doesn't break REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D8428 AFFECTED FILES src/kdeinit/kinit_win.cpp To: vpinon, vonreth, habacker Cc: #frameworks, bartoloni, benjaminnelan, afarid, fernandoteles, mardelle
D8427: Allow cross compiling resource file
vpinon created this revision. vpinon added reviewers: apol, kfunk. vpinon added a project: Kdenlive. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY While cross-compiling Kdenlive with MXE, I had to use host's qrcAlias. I followed the standard pattern, checking CMAKE_CROSSCOMPILING and the defined tool path. TEST PLAN Using it to build Kdenlive for 1 year (several ECM/Qt updates) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8427 AFFECTED FILES CMakeLists.txt To: vpinon, apol, kfunk Cc: #frameworks, bartoloni, benjaminnelan, afarid, fernandoteles, mardelle
D8281: Allow to use IcoTool for Windows icons
vpinon created this revision. vpinon added reviewers: dfaure, apol, kfunk. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY ECM to creating application icons asks for png2ico on Windows target. When cross-compiling from Debian, this program is not packaged, while there is icotool available. This patch allows to fallback to icotool if png2ico is not available. TEST PLAN Successfully cross-built Kdenlive 17.08.2 with MXE REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8281 AFFECTED FILES find-modules/FindIcoTool.cmake modules/ECMAddAppIcon.cmake To: vpinon, dfaure, apol, kfunk Cc: #frameworks, #build_system
