from:"Yunhe Guo"

D29159: Optimize SVG with sour

2020-04-24 Thread Yunhe Guo

guoyunhe added a reviewer: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29159

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29159: Optimize SVG with sour

2020-04-24 Thread Yunhe Guo

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  Some icons are failed to optimize due to huge pixel difference though you 
cannot tell by eyes. These files are not updated in this patch.

REPOSITORY
  R266 Breeze Icons

BRANCH
  scour

REVISION DETAIL
  https://phabricator.kde.org/D29159

AFFECTED FILES
  icons-dark/actions/22/im-skype.svg
  icons-dark/actions/22/office-chart-polar.svg
  icons-dark/actions/22/run-build-clean.svg
  icons-dark/actions/22/run-build-configure.svg
  icons-dark/actions/22/run-build-file.svg
  icons-dark/actions/22/run-build-prune.svg
  icons-dark/actions/22/run-build.svg
  icons-dark/actions/22/step_object_CircularMotor.svg
  icons-dark/actions/22/step_object_LinearMotor.svg
  icons-dark/actions/22/step_object_SoftBody.svg
  icons-dark/actions/32/colors-luma.svg
  icons-dark/actions/symbolic/pan-down-symbolic.svg
  icons-dark/actions/symbolic/pan-end-symbolic.svg
  icons-dark/actions/symbolic/pan-start-symbolic.svg
  icons-dark/actions/symbolic/pan-up-symbolic.svg
  icons-dark/actions/symbolic/selection-end-symbolic.svg
  icons-dark/actions/symbolic/selection-start-symbolic.svg
  icons-dark/applets/128/user-none.svg
  icons-dark/applets/48/weather-clouds-night.svg
  icons-dark/applets/48/weather-few-clouds-night.svg
  icons-dark/applets/48/weather-showers-day.svg
  icons-dark/applets/48/weather-showers-scattered-night.svg
  icons-dark/applets/48/weather-snow-rain.svg
  icons-dark/applets/48/weather-snow-scattered-day.svg
  icons-dark/applets/48/weather-snow.svg
  icons-dark/apps/48/QtProject-designer.svg
  icons-dark/apps/48/accessories-calculator.svg
  icons-dark/apps/48/acroread.svg
  icons-dark/apps/48/alienarena.svg
  icons-dark/apps/48/anjuta.svg
  icons-dark/apps/48/babe.svg
  icons-dark/apps/48/baloo.svg
  icons-dark/apps/48/bluegriffon.svg
  icons-dark/apps/48/bovo.svg
  icons-dark/apps/48/braindump.svg
  icons-dark/apps/48/choqok.svg
  icons-dark/apps/48/codeblocks.svg
  icons-dark/apps/48/diaspora.svg
  icons-dark/apps/48/digikam.svg
  icons-dark/apps/48/falkon.svg
  icons-dark/apps/48/granatier.svg
  icons-dark/apps/48/kapman.svg
  icons-dark/apps/48/karbon.svg
  icons-dark/apps/48/kbruch.svg
  icons-dark/apps/48/kde-im-log-viewer.svg
  icons-dark/apps/48/kdiff3.svg
  icons-dark/apps/48/kmag.svg
  icons-dark/apps/48/knights.svg
  icons-dark/apps/48/ksnapshot.svg
  icons-dark/apps/48/ktorrent.svg
  icons-dark/apps/48/lokalize.svg
  icons-dark/apps/48/mpv.svg
  icons-dark/apps/48/muondiscover.svg
  icons-dark/apps/48/octave.svg
  icons-dark/apps/48/phonon-gstreamer.svg
  icons-dark/apps/48/planetkde.svg
  icons-dark/apps/48/plasma-media-center.svg
  icons-dark/apps/48/qdbusviewer.svg
  icons-dark/apps/48/qtcreator.svg
  icons-dark/apps/48/showfoto.svg
  icons-dark/apps/48/skanlite.svg
  icons-dark/apps/48/step.svg
  icons-dark/apps/48/umbrello.svg
  icons-dark/apps/48/utilities-log-viewer.svg
  icons-dark/apps/48/words.svg
  icons-dark/categories/32/applications-office.svg
  icons-dark/devices/64/camera-video.svg
  icons-dark/devices/64/input-gaming.svg
  icons-dark/devices/64/media-flash-memory-stick.svg
  icons-dark/devices/64/media-optical-blu-ray.svg
  icons-dark/devices/64/network-rj11-female.svg
  icons-dark/devices/64/network-rj45-female.svg
  icons-dark/mimetypes/16/application-pgp-signature.svg
  icons-dark/mimetypes/16/text-dockerfile.svg
  icons-dark/mimetypes/22/android-package-archive.svg
  icons-dark/mimetypes/22/application-certificate.svg
  icons-dark/mimetypes/22/application-illustrator.svg
  icons-dark/mimetypes/22/application-msonenote.svg
  icons-dark/mimetypes/22/application-msoutlook.svg
  icons-dark/mimetypes/22/application-msword.svg
  icons-dark/mimetypes/22/application-vnd.ms-excel.addin.macroenabled.12.svg
  icons-dark/mimetypes/22/application-vnd.ms-infopath.svg
  icons-dark/mimetypes/22/application-vnd.oasis.opendocument.text-template.svg
  icons-dark/mimetypes/22/application-x-apple-diskimage.svg
  icons-dark/mimetypes/22/application-x-bzip.svg
  icons-dark/mimetypes/22/application-x-gettext-translation.svg
  icons-dark/mimetypes/22/application-x-javascript.svg
  icons-dark/mimetypes/22/application-x-lyx.svg
  icons-dark/mimetypes/22/application-x-rdata.svg
  icons-dark/mimetypes/22/application-x-trash.svg
  icons-dark/mimetypes/22/application-x-xliff.svg
  icons-dark/mimetypes/22/application-xmind.svg
  icons-dark/mimetypes/22/application-zip.svg
  icons-dark/mimetypes/22/image-bmp.svg
  icons-dark/mimetypes/22/image-jpeg.svg
  icons-dark/mimetypes/22/image-tiff.svg
  icons-dark/mimetypes/22/image-x-generic.svg
  icons-dark/mimetypes/22/image-x-psd.svg
  icons-dark/mimetypes/22/image-x-tga.svg
  icons-dark/mimetypes/22/image-x-xcf.svg
  icons-dark/mimetypes/22/package-x-generic.svg
  icons-dark/mimetypes/22/text-css.svg
  icons-dark/mimetypes/22/text-x-qml.svg
  icons-dark/mimetypes/22/video-mp4.svg
  icons-d

D29072: Optimize SVG

2020-04-24 Thread Yunhe Guo

guoyunhe added a comment.


  The diff compare is based on Inkscape PNG output. And you can also check git 
cola's pixel diff, the diff of `icons-dark/actions/22/color-management.svg` 
looks like this (black means no difference):
  
  F8258009: image.png 
  
  The scour solution is D29159 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29083: correct vscode icon name

2020-04-22 Thread Yunhe Guo

guoyunhe added a comment.


  The icon was renamed since 2018. Most users should have updated to newer 
version.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29083

To: guoyunhe, #breeze, cblack, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29083: correct vscode icon name

2020-04-21 Thread Yunhe Guo

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  `com.visualstudio.code.svg` and `com.visualstudio.code.oss.svg`

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29083

AFFECTED FILES
  icons-dark/apps/48/code-oss.svg
  icons-dark/apps/48/code.svg
  icons-dark/apps/48/com.visualstudio.code.oss.svg
  icons-dark/apps/48/com.visualstudio.code.svg
  icons/apps/48/code-oss.svg
  icons/apps/48/code.svg
  icons/apps/48/com.visualstudio.code.oss.svg
  icons/apps/48/com.visualstudio.code.svg

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29083: correct vscode icon name

2020-04-21 Thread Yunhe Guo

guoyunhe added a reviewer: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29083

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

2020-04-21 Thread Yunhe Guo

guoyunhe added a comment.


  I do try scour but the result is disappointing. I get 16 times the following 
error:
  
hge difference of 123 in ./icons-dark/apps/48/hwinfo.svg
  
  which means 16 icons are unacceptable after scour optimization

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29072: Optimize SVG

2020-04-21 Thread Yunhe Guo

guoyunhe updated this revision to Diff 80811.
guoyunhe added a comment.


  - Merge some paths

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29072?vs=80810&id=80811

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29072

AFFECTED FILES
  icons-dark/actions/22/color-management.svg
  icons-dark/actions/22/im-skype.svg
  icons-dark/actions/22/office-chart-polar.svg
  icons-dark/actions/22/run-build-clean.svg
  icons-dark/actions/22/run-build-configure.svg
  icons-dark/actions/22/run-build-file.svg
  icons-dark/actions/22/run-build-prune.svg
  icons-dark/actions/22/run-build.svg
  icons-dark/actions/22/step_object_CircularMotor.svg
  icons-dark/actions/22/step_object_LinearMotor.svg
  icons-dark/actions/22/step_object_SoftBody.svg
  icons-dark/actions/32/colors-luma.svg
  icons-dark/actions/symbolic/pan-down-symbolic.svg
  icons-dark/actions/symbolic/pan-end-symbolic.svg
  icons-dark/actions/symbolic/pan-start-symbolic.svg
  icons-dark/actions/symbolic/pan-up-symbolic.svg
  icons-dark/actions/symbolic/selection-end-symbolic.svg
  icons-dark/actions/symbolic/selection-start-symbolic.svg
  icons-dark/applets/128/user-none.svg
  icons-dark/applets/48/weather-clouds-night.svg
  icons-dark/applets/48/weather-few-clouds-night.svg
  icons-dark/applets/48/weather-showers-day.svg
  icons-dark/applets/48/weather-showers-scattered-night.svg
  icons-dark/applets/48/weather-snow-rain.svg
  icons-dark/applets/48/weather-snow-scattered-day.svg
  icons-dark/applets/48/weather-snow.svg
  icons-dark/apps/48/QtProject-designer.svg
  icons-dark/apps/48/accessories-calculator.svg
  icons-dark/apps/48/accessories-character-map.svg
  icons-dark/apps/48/acroread.svg
  icons-dark/apps/48/alienarena.svg
  icons-dark/apps/48/anjuta.svg
  icons-dark/apps/48/babe.svg
  icons-dark/apps/48/baloo.svg
  icons-dark/apps/48/bluegriffon.svg
  icons-dark/apps/48/bovo.svg
  icons-dark/apps/48/braindump.svg
  icons-dark/apps/48/choqok.svg
  icons-dark/apps/48/codeblocks.svg
  icons-dark/apps/48/diaspora.svg
  icons-dark/apps/48/digikam.svg
  icons-dark/apps/48/falkon.svg
  icons-dark/apps/48/granatier.svg
  icons-dark/apps/48/hwinfo.svg
  icons-dark/apps/48/kapman.svg
  icons-dark/apps/48/karbon.svg
  icons-dark/apps/48/kbruch.svg
  icons-dark/apps/48/kde-im-log-viewer.svg
  icons-dark/apps/48/kdiff3.svg
  icons-dark/apps/48/kmag.svg
  icons-dark/apps/48/knights.svg
  icons-dark/apps/48/ksnapshot.svg
  icons-dark/apps/48/ktorrent.svg
  icons-dark/apps/48/logisim.svg
  icons-dark/apps/48/lokalize.svg
  icons-dark/apps/48/mpv.svg
  icons-dark/apps/48/muondiscover.svg
  icons-dark/apps/48/octave.svg
  icons-dark/apps/48/phonon-gstreamer.svg
  icons-dark/apps/48/planetkde.svg
  icons-dark/apps/48/plasma-media-center.svg
  icons-dark/apps/48/qdbusviewer.svg
  icons-dark/apps/48/qtcreator.svg
  icons-dark/apps/48/showfoto.svg
  icons-dark/apps/48/skanlite.svg
  icons-dark/apps/48/step.svg
  icons-dark/apps/48/umbrello.svg
  icons-dark/apps/48/utilities-log-viewer.svg
  icons-dark/apps/48/words.svg
  icons-dark/apps/48/xorg.svg
  icons-dark/categories/32/applications-office.svg
  icons-dark/devices/64/camera-video.svg
  icons-dark/devices/64/input-gaming.svg
  icons-dark/devices/64/media-flash-memory-stick.svg
  icons-dark/devices/64/media-optical-blu-ray.svg
  icons-dark/devices/64/network-rj11-female.svg
  icons-dark/devices/64/network-rj45-female.svg
  icons-dark/mimetypes/16/application-pgp-signature.svg
  icons-dark/mimetypes/16/text-dockerfile.svg
  icons-dark/mimetypes/22/android-package-archive.svg
  icons-dark/mimetypes/22/application-certificate.svg
  icons-dark/mimetypes/22/application-illustrator.svg
  icons-dark/mimetypes/22/application-msonenote.svg
  icons-dark/mimetypes/22/application-msoutlook.svg
  icons-dark/mimetypes/22/application-msword.svg
  icons-dark/mimetypes/22/application-vnd.ms-excel.addin.macroenabled.12.svg
  icons-dark/mimetypes/22/application-vnd.ms-infopath.svg
  icons-dark/mimetypes/22/application-vnd.oasis.opendocument.text-template.svg
  icons-dark/mimetypes/22/application-x-apple-diskimage.svg
  icons-dark/mimetypes/22/application-x-bzip.svg
  icons-dark/mimetypes/22/application-x-font-ttf.svg
  icons-dark/mimetypes/22/application-x-gettext-translation.svg
  icons-dark/mimetypes/22/application-x-javascript.svg
  icons-dark/mimetypes/22/application-x-lyx.svg
  icons-dark/mimetypes/22/application-x-perl.svg
  icons-dark/mimetypes/22/application-x-rdata.svg
  icons-dark/mimetypes/22/application-x-trash.svg
  icons-dark/mimetypes/22/application-x-xliff.svg
  icons-dark/mimetypes/22/application-xmind.svg
  icons-dark/mimetypes/22/application-zip.svg
  icons-dark/mimetypes/22/image-bmp.svg
  icons-dark/mimetypes/22/image-jpeg.svg
  icons-dark/mimetypes/22/image-tiff.svg
  icons-dark/mimetypes/22/image-x-generic.svg
  icons-dark/mimetypes/22/image-x-psd.svg
  icons-dark/mimetypes/22/image-x-tga.svg
  icons-dark/mimetypes/22/image-x-xcf.svg
  icons-dark/mimetypes/22/

D29072: Optimize SVG

2020-04-21 Thread Yunhe Guo

guoyunhe edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

2020-04-21 Thread Yunhe Guo

guoyunhe added a reviewer: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

2020-04-21 Thread Yunhe Guo

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  Updated optimize-svg.sh script and optimize SVG files.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29072

AFFECTED FILES
  icons-dark/actions/22/color-management.svg
  icons-dark/actions/22/im-skype.svg
  icons-dark/actions/22/office-chart-polar.svg
  icons-dark/actions/22/run-build-clean.svg
  icons-dark/actions/22/run-build-configure.svg
  icons-dark/actions/22/run-build-file.svg
  icons-dark/actions/22/run-build-prune.svg
  icons-dark/actions/22/run-build.svg
  icons-dark/actions/22/step_object_CircularMotor.svg
  icons-dark/actions/22/step_object_LinearMotor.svg
  icons-dark/actions/22/step_object_SoftBody.svg
  icons-dark/actions/32/colors-luma.svg
  icons-dark/actions/symbolic/pan-down-symbolic.svg
  icons-dark/actions/symbolic/pan-end-symbolic.svg
  icons-dark/actions/symbolic/pan-start-symbolic.svg
  icons-dark/actions/symbolic/pan-up-symbolic.svg
  icons-dark/actions/symbolic/selection-end-symbolic.svg
  icons-dark/actions/symbolic/selection-start-symbolic.svg
  icons-dark/applets/128/user-none.svg
  icons-dark/applets/48/weather-clouds-night.svg
  icons-dark/applets/48/weather-few-clouds-night.svg
  icons-dark/applets/48/weather-showers-day.svg
  icons-dark/applets/48/weather-showers-scattered-night.svg
  icons-dark/applets/48/weather-snow-rain.svg
  icons-dark/applets/48/weather-snow-scattered-day.svg
  icons-dark/applets/48/weather-snow.svg
  icons-dark/apps/48/QtProject-designer.svg
  icons-dark/apps/48/accessories-calculator.svg
  icons-dark/apps/48/accessories-character-map.svg
  icons-dark/apps/48/acroread.svg
  icons-dark/apps/48/alienarena.svg
  icons-dark/apps/48/anjuta.svg
  icons-dark/apps/48/babe.svg
  icons-dark/apps/48/baloo.svg
  icons-dark/apps/48/bluegriffon.svg
  icons-dark/apps/48/bovo.svg
  icons-dark/apps/48/braindump.svg
  icons-dark/apps/48/choqok.svg
  icons-dark/apps/48/codeblocks.svg
  icons-dark/apps/48/diaspora.svg
  icons-dark/apps/48/digikam.svg
  icons-dark/apps/48/falkon.svg
  icons-dark/apps/48/granatier.svg
  icons-dark/apps/48/hwinfo.svg
  icons-dark/apps/48/kapman.svg
  icons-dark/apps/48/karbon.svg
  icons-dark/apps/48/kbruch.svg
  icons-dark/apps/48/kde-im-log-viewer.svg
  icons-dark/apps/48/kdiff3.svg
  icons-dark/apps/48/kmag.svg
  icons-dark/apps/48/knights.svg
  icons-dark/apps/48/ksnapshot.svg
  icons-dark/apps/48/ktorrent.svg
  icons-dark/apps/48/logisim.svg
  icons-dark/apps/48/lokalize.svg
  icons-dark/apps/48/mpv.svg
  icons-dark/apps/48/muondiscover.svg
  icons-dark/apps/48/octave.svg
  icons-dark/apps/48/phonon-gstreamer.svg
  icons-dark/apps/48/planetkde.svg
  icons-dark/apps/48/plasma-media-center.svg
  icons-dark/apps/48/qdbusviewer.svg
  icons-dark/apps/48/qtcreator.svg
  icons-dark/apps/48/showfoto.svg
  icons-dark/apps/48/skanlite.svg
  icons-dark/apps/48/step.svg
  icons-dark/apps/48/umbrello.svg
  icons-dark/apps/48/utilities-log-viewer.svg
  icons-dark/apps/48/words.svg
  icons-dark/apps/48/xorg.svg
  icons-dark/categories/32/applications-office.svg
  icons-dark/devices/64/camera-video.svg
  icons-dark/devices/64/input-gaming.svg
  icons-dark/devices/64/media-flash-memory-stick.svg
  icons-dark/devices/64/media-optical-blu-ray.svg
  icons-dark/devices/64/network-rj11-female.svg
  icons-dark/devices/64/network-rj45-female.svg
  icons-dark/mimetypes/16/application-pgp-signature.svg
  icons-dark/mimetypes/16/text-dockerfile.svg
  icons-dark/mimetypes/22/android-package-archive.svg
  icons-dark/mimetypes/22/application-certificate.svg
  icons-dark/mimetypes/22/application-illustrator.svg
  icons-dark/mimetypes/22/application-msonenote.svg
  icons-dark/mimetypes/22/application-msoutlook.svg
  icons-dark/mimetypes/22/application-msword.svg
  icons-dark/mimetypes/22/application-vnd.ms-excel.addin.macroenabled.12.svg
  icons-dark/mimetypes/22/application-vnd.ms-infopath.svg
  icons-dark/mimetypes/22/application-vnd.oasis.opendocument.text-template.svg
  icons-dark/mimetypes/22/application-x-apple-diskimage.svg
  icons-dark/mimetypes/22/application-x-bzip.svg
  icons-dark/mimetypes/22/application-x-font-ttf.svg
  icons-dark/mimetypes/22/application-x-gettext-translation.svg
  icons-dark/mimetypes/22/application-x-javascript.svg
  icons-dark/mimetypes/22/application-x-lyx.svg
  icons-dark/mimetypes/22/application-x-perl.svg
  icons-dark/mimetypes/22/application-x-rdata.svg
  icons-dark/mimetypes/22/application-x-trash.svg
  icons-dark/mimetypes/22/application-x-xliff.svg
  icons-dark/mimetypes/22/application-xmind.svg
  icons-dark/mimetypes/22/application-zip.svg
  icons-dark/mimetypes/22/image-bmp.svg
  icons-dark/mimetypes/22/image-jpeg.svg
  icons-dark/mimetypes/22/image-tiff.svg
  icons-dark/mimetypes/22/image-x-generic.svg
  icons-dark/mimetypes/22/image-x-psd.svg
  icons-dark/mimetypes/22/image-x-tga.svg
  icons-d

D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons

2020-04-21 Thread Yunhe Guo

guoyunhe added a dependency: D29040: Use colorful icon instead of monochrome 
icon for touchpad kcm.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29037

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons

2020-04-21 Thread Yunhe Guo

guoyunhe edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29037

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons

2020-04-21 Thread Yunhe Guo

guoyunhe edited the summary of this revision.
guoyunhe added a reviewer: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29037

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons

2020-04-21 Thread Yunhe Guo

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  KCM should use icons in prefernces folder (always colorful) instead of 
devices folder (monochrome in small size)

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29037

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-tablet.svg
  icons-dark/preferences/32/preferences-desktop-touchpad.svg
  icons/preferences/32/preferences-desktop-tablet.svg
  icons/preferences/32/preferences-desktop-touchpad.svg

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27913: Icons for emoji categories

2020-03-09 Thread Yunhe Guo

guoyunhe added a comment.


  D27915  is for the change. The ibus dict 
comes with untranslated categories name. The category names may change. But it 
seems the dict hasn't been updated that often.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27913

To: guoyunhe, #breeze
Cc: apol, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27913: Icons for emoji categories

2020-03-08 Thread Yunhe Guo

guoyunhe added a comment.


  In D27913#624159 , @ngraham wrote:
  
  > If we do this, then won't the category icons look different from the actual 
emoji icons when using a font where the emojis look different?
  
  
  Hi @ngraham , the main idea is to make the left panel use only Breeze icons.
  
  Reference design in Telegram Desktop:
  
  F8145244: image.png 
  
  In WhatsApp:
  
  F8145247: image.png 
  
  In this way we can choose what the icon look like.
  
  Current implementation renders the first emoji in the category. You can see 
the "Objects" category is a "Muted" emoji. And the "Symbols" icon is an "ATM" 
emoji. They don't fit the category very well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27913

To: guoyunhe, #breeze
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27913: Icons for emoji categories

2020-03-07 Thread Yunhe Guo

guoyunhe added a dependent revision: D27915: Use breeze icons for categories.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27913

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27913: Icons for emoji categories

2020-03-07 Thread Yunhe Guo

guoyunhe edited the summary of this revision.
guoyunhe added a reviewer: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27913

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27913: Icons for emoji categories

2020-03-07 Thread Yunhe Guo

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27913

AFFECTED FILES
  icons-dark/actions/22/animal.svg
  icons-dark/actions/22/food.svg
  icons-dark/actions/22/smiley.svg
  icons/actions/22/animal.svg
  icons/actions/22/food.svg
  icons/actions/22/smiley.svg

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2020-01-15 Thread Yunhe Guo

guoyunhe added a comment.


  I am not 100% sure. It seems installed under `/etc/xdg/menus/*.menu`. You can 
install as many *.menu files as you want but keep different names.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: davidedmundson, ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2020-01-15 Thread Yunhe Guo

guoyunhe added a comment.


  if we copy `applications.menu` to plasma-workspace and patch it there, it 
will only be shipped with future plasma releases.
  
  Existing released plasma can still get the old menu from kservice even with 
newer frameworks and it is not updated.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: davidedmundson, ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2020-01-15 Thread Yunhe Guo

guoyunhe added a comment.


  Then how about I copy this file `applications.menu` to plasma-workspace? 
After one or two years, we can delete this file from frameworks. But for 
compatibility, it will exist in both repositories for some time.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: davidedmundson, ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2020-01-15 Thread Yunhe Guo

guoyunhe added a comment.


  The dependency D24424  has been landed 
three month ago. Do you think it is safe to ship this patch now?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: davidedmundson, ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25564: Fix conflicts of shortcuts

2019-11-27 Thread Yunhe Guo

guoyunhe added a reviewer: Frameworks.

REPOSITORY
  R480 Kipi Plugins

REVISION DETAIL
  https://phabricator.kde.org/D25564

To: guoyunhe, #frameworks

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2019-11-24 Thread Yunhe Guo

guoyunhe added a comment.


  I also think these *.menu and *.directory files should not be required at 
compile time. And they should better be in same repository because they are 
connected so closely.
  
  In this patch, we added a new file `kf5-network.directory` in 
plasma-workspace and reference it here. But this means frameworks 5.65 will 
depend on plasma-workspace 5.18. Any other combination, like frameworks 5.65 + 
plasma 5.17 or frameworks 5.64 + plasma 5.18, will break.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: davidedmundson, ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2019-11-24 Thread Yunhe Guo

guoyunhe added a comment.


  Not sure who should I ping. So I posted in maillist plasma-de...@kde.org

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2019-11-24 Thread Yunhe Guo

guoyunhe added a comment.


  @ngraham @ltoscano should I create bug ticket about the dependency issue we 
have here?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2019-10-16 Thread Yunhe Guo

guoyunhe added a comment.


  `kf5-network.directory` has been added to `plasma-workspace`.
  
  The trouble is still here: if we land this patch and released new frameworks, 
it won't work with older plasma workspace (like 5.17.0, 5.16.x).

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

2019-10-12 Thread Yunhe Guo

guoyunhe marked an inline comment as done.
guoyunhe added inline comments.

INLINE COMMENTS

> dfaure wrote in krun.cpp:1101
> should this be in ifdef Q_OS_WIN?
> 
> On windows, *.exe is executed, not opened (with e.g. wine)

Yes, I updated this part.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

2019-10-12 Thread Yunhe Guo

guoyunhe updated this revision to Diff 67761.
guoyunhe added a comment.


  *.exe should be normal executable in Windows

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24463?vs=67458&id=67761

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

AFFECTED FILES
  src/widgets/executablefileopendialog.cpp
  src/widgets/executablefileopendialog_p.h
  src/widgets/krun.cpp
  src/widgets/krun_p.h

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

2019-10-07 Thread Yunhe Guo

guoyunhe edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

2019-10-07 Thread Yunhe Guo

guoyunhe retitled this revision from "WIP: Treat 
"application/x-ms-dos-executable" as executable on all platforms" to "Treat 
"application/x-ms-dos-executable" as executable on all platforms".
guoyunhe edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: WIP: Treat "application/x-ms-dos-executable" as executable on all platforms

2019-10-07 Thread Yunhe Guo

guoyunhe added a comment.


  It is now working. The condition is so complex. Please help test this patch!
  
  F7541884: image.png 

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: WIP: Treat "application/x-ms-dos-executable" as executable on all platforms

2019-10-07 Thread Yunhe Guo

guoyunhe updated this revision to Diff 67458.
guoyunhe added a comment.


  Fix *.exe execution condition

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24463?vs=67444&id=67458

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

AFFECTED FILES
  src/widgets/executablefileopendialog.cpp
  src/widgets/executablefileopendialog_p.h
  src/widgets/krun.cpp
  src/widgets/krun_p.h

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: WIP: Treat "application/x-ms-dos-executable" as executable on all platforms

2019-10-07 Thread Yunhe Guo

guoyunhe retitled this revision from "Treat "application/x-ms-dos-executable" 
as executable on all platforms" to "WIP: Treat 
"application/x-ms-dos-executable" as executable on all platforms".
guoyunhe edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

2019-10-07 Thread Yunhe Guo

guoyunhe updated this revision to Diff 67444.
guoyunhe added a comment.


  "openAsExecute" parameter for ExecutableFileOpenDialog

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24463?vs=67424&id=67444

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

AFFECTED FILES
  src/widgets/executablefileopendialog.cpp
  src/widgets/executablefileopendialog_p.h
  src/widgets/krun.cpp
  src/widgets/krun_p.h

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

2019-10-07 Thread Yunhe Guo

guoyunhe added a comment.


  I just realized that this patch might be unfinished. In the pop up, you 
usually have "Open", "Execute" and "Cancel". But for *.exe, "Open" is actually 
to be executed by Wine? "Execute" will do nothing because it isn't a native 
executable for Linux/BSD.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

2019-10-07 Thread Yunhe Guo

guoyunhe added a comment.


  In D24463#543070 , @ngraham wrote:
  
  > Maybe can we check to see if WINE is installed or if there's a handler for 
`application/x-ms-dos-executable`? Otherwise if you don't have WINE installed, 
won't you see a dialog that gives you the option to execute it when that 
doesn't work?
  
  
  It is another feature. We also need to check if PHP/Python/Perl/Ruby/Node.js 
is installed for other script types. It is not Wine specific problem but a 
general issue for all executable that requires an interpreter.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks
Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

2019-10-07 Thread Yunhe Guo

guoyunhe added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

2019-10-07 Thread Yunhe Guo

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  Because of Wine, *.exe can be executed in almost all desktop platforms. BUG: 
412694

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

AFFECTED FILES
  src/widgets/krun.cpp

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24436: Add applications-network icon for renaming Internet category to Network

2019-10-06 Thread Yunhe Guo

guoyunhe added a comment.


  They can easily rename/link the icon. Correct semantic naming can improve the 
icon design. In a long view, having the same naming from the freedestop.org 
specification, to KDE categories, to icons, can reduce confusion.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24436

To: guoyunhe, #breeze
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24436: Add applications-network icon for renaming Internet category to Network

2019-10-06 Thread Yunhe Guo

guoyunhe added a reviewer: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24436

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24436: Add applications-network icon for renaming Internet category to Network

2019-10-06 Thread Yunhe Guo

guoyunhe added a dependent revision: D24424: Create kf5-network.directory.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24436

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24436: Add applications-network icon for renaming Internet category to Network

2019-10-06 Thread Yunhe Guo

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  See D24424 

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24436

AFFECTED FILES
  icons-dark/categories/32/applications-network.svg
  icons/categories/32/applications-network.svg

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2019-10-05 Thread Yunhe Guo

guoyunhe added a dependency: D24424: Create kf5-network.directory.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2019-10-05 Thread Yunhe Guo

guoyunhe edited the summary of this revision.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2019-10-05 Thread Yunhe Guo

guoyunhe added a reviewer: Frameworks.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2019-10-05 Thread Yunhe Guo

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  In freedesktop.org specification, the category is Network. Most applications
  under this category can also be used in local network, like FTP client,
  browsers, P2P clients, cloud storage clients. So I think "Network" is the
  best name for this category.
  
  The "Internet>Terminal" category actually doesn't include anything because it
  doesn't have a `` block. "Terminal" sub-category is already included
  in "System" category. So I removed it.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24423

AFFECTED FILES
  src/applications.menu

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-04 Thread Yunhe Guo

guoyunhe added a comment.


  If I install amor, it would be shown in both Games and Games > Toys. This 
patch will let it only shows in Games.
  
  Another situation is that, if the application is 
`Categories=Multimedia;Amusement;`, it will not fit Games or Games>Toys. This 
patch can also help to always follow the primary category. (Amusement is an 
additional/secondary category)

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-04 Thread Yunhe Guo

guoyunhe updated this revision to Diff 67310.
guoyunhe added a comment.


  In case Amusement is under other primary category, let it be placed in its 
actually primary category, rather than force it in Games.

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24384?vs=67304&id=67310

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

AFFECTED FILES
  src/applications.menu

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-04 Thread Yunhe Guo

guoyunhe added a comment.


  In RPM package groups, **Amusement** is a top level category and **Game** is 
its child category. So a game can be categorized as **Amusement/Game/Other**.
  
  However, in freedesktop.org specification, **Game** is primary category. 
**Amusement** is secondary category but not under **Game**.
  
  I searched through all KDE apps to find **Amusement** category in desktop 
files. And find the only one :
  
  amor - Amusing Misuse of Resources animation that sits on top of the curent 
window. Categories=Qt;KDE;Game;Amusement;
  
  F7514185: image.png 

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-04 Thread Yunhe Guo

guoyunhe edited the summary of this revision.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-04 Thread Yunhe Guo

guoyunhe updated this revision to Diff 67304.
guoyunhe added a comment.


  Update description

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24384?vs=67252&id=67304

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

AFFECTED FILES
  src/applications.menu

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Yunhe Guo

guoyunhe added a comment.


  In D24384#541589 , @aacid wrote:
  
  > Have you contacted Valve to tell them amusement is the wrong category for 
Steam?
  >
  > Because the spec says Amusement - > a simple amusement
  >
  > And that's not what steam is
  >
  > IMHO this patch is wrong and steam is what needs fixing.
  
  
  Dispite what Steam belongs to, "a simple amusement" should not be named 
"toys". Do we have any applications or games that are "toys"?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks
Cc: aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Yunhe Guo

guoyunhe updated this revision to Diff 67252.
guoyunhe added a comment.


  Fix tabs

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24384?vs=67251&id=67252

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

AFFECTED FILES
  src/applications.menu

To: guoyunhe, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Yunhe Guo

guoyunhe added a reviewer: Frameworks.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Yunhe Guo

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  The Amusement category doesn't mean it is about toys. For example, Steam, the 
gaming platform and store, isn't about toys.
  
  BUG 412553

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

AFFECTED FILES
  src/applications.menu

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo

guoyunhe added a comment.


  @ndavis can you give review? thanks!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo

guoyunhe added a comment.


  Changed to `currentColor`

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo

guoyunhe updated this revision to Diff 66083.
guoyunhe added a comment.


  Remove hardcoded colors

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23942?vs=66080&id=66083

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23942

AFFECTED FILES
  icons-dark/actions/16/font-disable.svg
  icons-dark/actions/16/font-enable.svg
  icons-dark/actions/22/font-disable.svg
  icons-dark/actions/22/font-enable.svg
  icons/actions/16/font-disable.svg
  icons/actions/16/font-enable.svg
  icons/actions/22/font-disable.svg
  icons/actions/22/font-enable.svg

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo

guoyunhe added a comment.


  @GB_2 is it correct now?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo

guoyunhe updated this revision to Diff 66080.
guoyunhe added a comment.


  Add inline styles

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23942?vs=66077&id=66080

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23942

AFFECTED FILES
  icons-dark/actions/16/font-disable.svg
  icons-dark/actions/16/font-enable.svg
  icons-dark/actions/22/font-disable.svg
  icons-dark/actions/22/font-enable.svg
  icons/actions/16/font-disable.svg
  icons/actions/16/font-enable.svg
  icons/actions/22/font-disable.svg
  icons/actions/22/font-enable.svg

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo

guoyunhe added a comment.


  I was asked to remove the hard code color like: `fill="currentColor"` and 
`fill="#da4453"`. But I see other icons have something like 
`style="fill:currentColor"`. Can anyone tell me correct way of applying colors?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo

guoyunhe added a comment.


  @ndavis it looks strange when I removed the inline style
  
  F7351830: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo

guoyunhe added a comment.


  I just followed the email icons' color: check mark is black/white, disable 
mark is red.
  
  F7351796: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo

guoyunhe updated this revision to Diff 66077.
guoyunhe added a comment.


  Remove hardcoded colors

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23942?vs=66071&id=66077

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23942

AFFECTED FILES
  icons-dark/actions/16/font-disable.svg
  icons-dark/actions/16/font-enable.svg
  icons-dark/actions/22/font-disable.svg
  icons-dark/actions/22/font-enable.svg
  icons/actions/16/font-disable.svg
  icons/actions/16/font-enable.svg
  icons/actions/22/font-disable.svg
  icons/actions/22/font-enable.svg

To: guoyunhe, #breeze, ndavis
Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo

guoyunhe added a comment.


  @ndavis, @broulik, @ngraham, I made some change. Can you have another look?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis
Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo

guoyunhe updated this revision to Diff 66071.
guoyunhe added a comment.


  Add 16px icons for font-enable and font-disable

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23942?vs=66067&id=66071

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23942

AFFECTED FILES
  icons-dark/actions/16/font-disable.svg
  icons-dark/actions/16/font-enable.svg
  icons-dark/actions/22/font-disable.svg
  icons-dark/actions/22/font-enable.svg
  icons/actions/16/font-disable.svg
  icons/actions/16/font-enable.svg
  icons/actions/22/font-disable.svg
  icons/actions/22/font-enable.svg

To: guoyunhe, #breeze, ndavis
Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo

guoyunhe updated this revision to Diff 66067.
guoyunhe added a comment.


  Reduce space between A and marks

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23942?vs=66050&id=66067

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23942

AFFECTED FILES
  icons-dark/actions/22/font-disable.svg
  icons-dark/actions/22/font-enable.svg
  icons/actions/22/font-disable.svg
  icons/actions/22/font-enable.svg

To: guoyunhe, #breeze, ndavis
Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo

guoyunhe updated this revision to Diff 66050.
guoyunhe edited the summary of this revision.
guoyunhe added a comment.


  Rename enablefont and disablefont icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23942?vs=66043&id=66050

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23942

AFFECTED FILES
  icons-dark/actions/22/font-disable.svg
  icons-dark/actions/22/font-enable.svg
  icons/actions/22/font-disable.svg
  icons/actions/22/font-enable.svg

To: guoyunhe, #breeze, ndavis
Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo

guoyunhe added a comment.


  In D23942#531086 , @broulik wrote:
  
  > Please use a more hierarchical name, e.g. "font-enable" and "font-disable", 
to match the other font icons we have such as "font-size-up" and "font-face"
  
  
  OK. Then need to update kfontinst, too.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze, ndavis
Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23943: HiDPI support

2019-09-14 Thread Yunhe Guo

guoyunhe added a reviewer: Frameworks.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D23943

To: guoyunhe, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23943: HiDPI support

2019-09-14 Thread Yunhe Guo

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  Make the change password pop up sharp in HiDPI display, which is a part of 
kwalletd.

REPOSITORY
  R311 KWallet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23943

AFFECTED FILES
  src/runtime/kwalletd/main.cpp

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo

guoyunhe edited the summary of this revision.
guoyunhe added a reviewer: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23942

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23942

AFFECTED FILES
  icons-dark/actions/22/disablefont.svg
  icons-dark/actions/22/enablefont.svg
  icons/actions/22/disablefont.svg
  icons/actions/22/enablefont.svg

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23161: Make media control icons outline style instead of solid style

2019-08-14 Thread Yunhe Guo

guoyunhe added a comment.


  Yes, I did a search on the internet and almost all popular music app use 
solid play/pause/stop icon.
  
  The outline icon will look like this in JuK:
  
  F7247683: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23161

To: guoyunhe, #vdg, ndavis, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23161: Make media control icons outline style instead of solid style

2019-08-14 Thread Yunhe Guo

guoyunhe updated this revision to Diff 63763.
guoyunhe added a comment.


  22px icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23161?vs=63762&id=63763

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23161

AFFECTED FILES
  icons-dark/actions/16/media-playback-pause.svg
  icons-dark/actions/16/media-playback-start.svg
  icons-dark/actions/16/media-playback-stop.svg
  icons-dark/actions/22/media-playback-pause.svg
  icons-dark/actions/22/media-playback-start.svg
  icons-dark/actions/22/media-playback-stop.svg
  icons/actions/16/media-playback-pause.svg
  icons/actions/16/media-playback-start.svg
  icons/actions/16/media-playback-stop.svg
  icons/actions/22/media-playback-pause.svg
  icons/actions/22/media-playback-start.svg
  icons/actions/22/media-playback-stop.svg

To: guoyunhe, #vdg, ndavis, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23161: Make media control icons outline style instead of solid style

2019-08-14 Thread Yunhe Guo

guoyunhe updated this revision to Diff 63762.
guoyunhe added a comment.


  Correct SVG format

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23161?vs=63760&id=63762

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23161

AFFECTED FILES
  icons-dark/actions/16/media-playback-pause.svg
  icons-dark/actions/16/media-playback-start.svg
  icons-dark/actions/16/media-playback-stop.svg
  icons-dark/actions/22/media-playback-start.svg
  icons/actions/16/media-playback-pause.svg
  icons/actions/16/media-playback-start.svg
  icons/actions/16/media-playback-stop.svg
  icons/actions/22/media-playback-start.svg

To: guoyunhe, #vdg, ndavis, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23161: Make media control icons outline style instead of solid style

2019-08-14 Thread Yunhe Guo

guoyunhe edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23161

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23161: Make media control icons outline style instead of solid style

2019-08-14 Thread Yunhe Guo

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  In progress. If others think this is the correct way to do it, I can continue 
with other media control icons and all sizes.
  
  From my understanding of KDE HIG, the icon should be outline style whenever 
possible.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23161

AFFECTED FILES
  icons-dark/actions/16/media-playback-pause.svg
  icons-dark/actions/16/media-playback-start.svg
  icons-dark/actions/16/media-playback-stop.svg
  icons/actions/16/media-playback-pause.svg
  icons/actions/16/media-playback-start.svg
  icons/actions/16/media-playback-stop.svg

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23051: Make file bookmark names consistent

2019-08-09 Thread Yunhe Guo

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  Other bookmarks don't have "Files", like "Videos", "Documents". So "Audio 
Files" should be changed to "Audio".

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23051

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D19812: Add a web page to view and compare icons of different sizes

2019-04-26 Thread Yunhe Guo

guoyunhe abandoned this revision.
guoyunhe added a comment.


  Using a library can save a lot of time. Just like many simple web pages use 
jQuery, D3 , etc.
  
  I don't have the ability to write it all by hands from scratch...

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: ltoscano, filipf, trickyricky26, GB_2, pino, bcooksley, ngraham, 
kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

2019-04-26 Thread Yunhe Guo

guoyunhe added a comment.


  In D19812#456869 , @ltoscano wrote:
  
  > The documentation website of krita is a different type of repository. This 
project is going to be distributed and compiled by the distributions, and many 
of them will have to patch out the minified javascript and replace it with a 
dependency on a proper packaged version. The idea is that the minified 
(obscured) version is not the preferred form of distribution (not the "source 
code"), more or less. So special care should be taken here.
  
  
  The web page is only used by developer/designer. End users don't need it. It 
won't be executed during packaging or installation. It won't be installed, 
either. Here isn't cmake rule to execute or install it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: ltoscano, filipf, trickyricky26, GB_2, pino, bcooksley, ngraham, 
kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

2019-04-26 Thread Yunhe Guo

guoyunhe added a comment.


  The code is stable version Vue.js. Source is here 
https://github.com/vuejs/vue/blob/v2.6.10/dist/vue.min.js
  Uncompiled version is here 
https://github.com/vuejs/vue/blob/v2.6.10/dist/vue.js
  
  I used to include it from remote URL. But someone think it is not trusted. So 
I changed it to local file.
  
  Here are some KDE projects also including compiled JavaScript files 
https://cgit.kde.org/websites/docs-krita-org.git/tree/theme/static/js/modernizr.min.js

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: filipf, trickyricky26, GB_2, pino, bcooksley, ngraham, 
kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

2019-04-26 Thread Yunhe Guo

guoyunhe added a comment.


  In D19812#456848 , @ngraham wrote:
  
  > What is this giant javascript file with no whitespace that you're adding? I 
really don't like how it's formatted in such a way that makes the code 
practically impossible to read. This would be the perfect place to sneak in 
malware (not saying you or the author have done this, but that this kind of 
obfuscated code is a perfect vector for it).
  
  
  It is Vue, a MVC library to make interactive single page application. I can 
provide some examples:
  
  1. WordPress https://github.com/WordPress/WordPress/tree/master/wp-includes/js
  2. Bootstrap https://github.com/twbs/bootstrap/tree/master/dist/js
  3. Phabricator (this website) 
https://github.com/phacility/phabricator/blob/master/webroot/rsrc/externals/d3/d3.min.js
  
  They all have some minified JavaScript in Git repository.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: trickyricky26, GB_2, pino, bcooksley, ngraham, kde-frameworks-devel, 
michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

2019-04-24 Thread Yunhe Guo

guoyunhe added a comment.


  Hi @ngraham @pino @bcooksley , I have updated the script/configuration. Can 
you give some further opinion?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

2019-04-10 Thread Yunhe Guo

guoyunhe added a comment.


  Hi all,
  
  Can you check if here is anything else that needs to be changed? Thanks.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

2019-04-10 Thread Yunhe Guo

guoyunhe marked 5 inline comments as done.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

2019-03-26 Thread Yunhe Guo

guoyunhe updated this revision to Diff 54919.
guoyunhe added a comment.


  Output to stderr

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19812?vs=54918&id=54919

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19812

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  generate_web_data.sh
  index.html
  vue.min.js

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

2019-03-26 Thread Yunhe Guo

guoyunhe updated this revision to Diff 54918.
guoyunhe added a comment.


  Don't use remote JavaScript library

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19812?vs=54688&id=54918

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19812

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  generate_web_data.sh
  index.html
  vue.min.js

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

2019-03-24 Thread Yunhe Guo

guoyunhe updated this revision to Diff 54688.
guoyunhe added a comment.


  Fix typo

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19812?vs=54546&id=54688

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19812

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  generate_web_data.sh
  index.html

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

2019-03-22 Thread Yunhe Guo

guoyunhe updated this revision to Diff 54546.
guoyunhe added a comment.


  Improve bash script

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19812?vs=54535&id=54546

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19812

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  generate_web_data.sh
  index.html

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

2019-03-22 Thread Yunhe Guo

guoyunhe added a comment.


  In D19812#436154 , @pino wrote:
  
  > - please harden the script using at least -e and -u flags for set: this 
way, it will not keep executing when a command fails, and undeclared variables 
are not silently expanded to empty string (to prevent typos)
  
  
  Sorry, I am not very familiar with shell script. What does the -e or -u flags 
mean and how to use them? Can you give an example? Thanks.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

2019-03-22 Thread Yunhe Guo

guoyunhe updated this revision to Diff 54535.
guoyunhe added a comment.


  Add search function

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19812?vs=54533&id=54535

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19812

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  generate_web_data.sh
  index.html

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

2019-03-21 Thread Yunhe Guo

guoyunhe added a comment.


  F6709477: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

2019-03-21 Thread Yunhe Guo

guoyunhe updated this revision to Diff 54533.
guoyunhe added a comment.


  Add color blind mode

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19812?vs=54532&id=54533

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19812

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  generate_web_data.sh
  index.html

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

2019-03-21 Thread Yunhe Guo

guoyunhe updated this revision to Diff 54532.
guoyunhe added a comment.


  Move build files to CMake build directory

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19812?vs=54257&id=54532

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19812

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  generate_web_data.sh
  index.html

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

2019-03-18 Thread Yunhe Guo

guoyunhe added a comment.


  In D19812#434089 , @ngraham wrote:
  
  > Thanks, it compiles with CMake now! \o/
  >
  > I'm not a fan of how it dumps all this stuff in the source directory. 
Ideally it would put everything to the build directory when doing an 
out-of-source build so the source dir isn't cluttered up with transient and 
rapidly-changing information. Then you also wouldn't need to add these files to 
`gitignore`.
  
  
  The challenge is that in HTML file, it uses certain relative paths to icons 
and data files. CMake build directory can be anywhere. I have to make sure 
icons, index.html, .breeze.txt always in same relative paths.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

2019-03-18 Thread Yunhe Guo

guoyunhe updated this revision to Diff 54257.
guoyunhe added a comment.


  Use typical Breeze background colors

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19812?vs=54252&id=54257

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19812

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  generate_web_data.sh
  index.html

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

1 2 >

1 - 100 of 148 matches

Mail list logo