D12734: Scale up folder icon before creating preview overlays

[Peter Mühlenpfordt]

muhlenpfordt added a reviewer: Frameworks.
muhlenpfordt added subscribers: rkflx, ngraham.
muhlenpfordt added a comment.


  Also see D12509  for Gwenview effects on 
this issue.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12734

To: muhlenpfordt, #frameworks
Cc: ngraham, rkflx

D12734: Scale up folder icon before creating preview overlays

[Henrik Fehlauer]

rkflx accepted this revision.
rkflx added a comment.
This revision is now accepted and ready to land.


  +1, but I'd feel a bit uncomfortable (almost) self-approving my own patch 
(sans the `qMax`) here, so perhaps wait until the end of the week for any other 
opinions before committing.
  
  BTW, any reason you are targetting `master` only?

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12734

To: muhlenpfordt, #frameworks, rkflx
Cc: ngraham, rkflx

D12734: Scale up folder icon before creating preview overlays

[Peter Mühlenpfordt]

muhlenpfordt added a comment.


  In D12734#259336 , @rkflx wrote:
  
  > +1, but I'd feel a bit uncomfortable (almost) self-approving my own patch 
(sans the `qMax`) here, so perhaps wait until the end of the week for any other 
opinions before committing.
  
  
  I did nearly the same in my initial search, except for the separate `extent` 
var. So, two ideas leading to the same code can't be wrong.  ;)  But sure, I'll 
wait until next week.
  
  > BTW, any reason you are targetting `master` only?
  
  I wanted to be careful here since I'm a bit afraid of changing library 
functions. If you think it's ok for `Applications/18.04` I'll rebase it.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12734

To: muhlenpfordt, #frameworks, rkflx
Cc: ngraham, rkflx

D12734: Scale up folder icon before creating preview overlays

[Peter Mühlenpfordt]

muhlenpfordt added a comment.


  Forgot to mention this...
  There's a nice test application in `kio` for viewing a folder's preview in 
any desired size (created by `KIO::PreviewJob`): `previewtest`. Just enter the 
full path to the folder here.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12734

To: muhlenpfordt, #frameworks, rkflx
Cc: ngraham, rkflx

D12734: Scale up folder icon before creating preview overlays

[Henrik Fehlauer]

rkflx added a comment.


  In D12734#259445 , @muhlenpfordt 
wrote:
  
  > I wanted to be careful here since I'm a bit afraid of changing library 
functions. If you think it's ok for `Applications/18.04` I'll rebase it.
  
  
  How else would you fix problems in a library ;)
  
  Nevertheless, let's check the impact of this again: 
https://lxr.kde.org/ident?_i=thumbForDirectory
  
  Does not look too critical to me, and we probably tested most of the code 
paths.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12734

To: muhlenpfordt, #frameworks, rkflx
Cc: ngraham, rkflx

D12734: Scale up folder icon before creating preview overlays

[Peter Mühlenpfordt]

muhlenpfordt updated this revision to Diff 33822.
muhlenpfordt added a comment.


  Rebase to `Applications/18.04`

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12734?vs=33749&id=33822

BRANCH
  scale-up-folder-icon (branched from Applications/18.04)

REVISION DETAIL
  https://phabricator.kde.org/D12734

AFFECTED FILES
  thumbnail/thumbnail.cpp

To: muhlenpfordt, #frameworks, rkflx
Cc: ngraham, rkflx

D12734: Scale up folder icon before creating preview overlays

[Peter Mühlenpfordt]

muhlenpfordt added a comment.


  In D12734#259515 , @rkflx wrote:
  
  > Nevertheless, let's check the impact of this again: 
https://lxr.kde.org/ident?_i=thumbForDirectory
  >  Does not look too critical to me, and we probably tested most of the code 
paths.
  
  
  The normal KDE file dialog (e.g. Kate > File > Open...) also uses the 
upscaled preview without any problems.
  I searched for (`KIO::`)`filePreview` on lxr which gives a couple of results. 
They all use similar methods to handle the icons and I can't spot anything 
unsual related to the returned size.
  Ok to commit?

REPOSITORY
  R320 KIO Extras

BRANCH
  scale-up-folder-icon (branched from Applications/18.04)

REVISION DETAIL
  https://phabricator.kde.org/D12734

To: muhlenpfordt, #frameworks, rkflx
Cc: ngraham, rkflx

D12734: Scale up folder icon before creating preview overlays

[Henrik Fehlauer]

rkflx added a comment.


  In D12734#262368 , @muhlenpfordt 
wrote:
  
  > Ok to commit?
  
  
  Sure, go ahead 👍

REPOSITORY
  R320 KIO Extras

BRANCH
  scale-up-folder-icon (branched from Applications/18.04)

REVISION DETAIL
  https://phabricator.kde.org/D12734

To: muhlenpfordt, #frameworks, rkflx
Cc: ngraham, rkflx

D12734: Scale up folder icon before creating preview overlays

[Peter Mühlenpfordt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:bafc90d730f2: Scale up folder icon before creating 
preview overlays (authored by muhlenpfordt).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12734?vs=33822&id=34202

REVISION DETAIL
  https://phabricator.kde.org/D12734

AFFECTED FILES
  thumbnail/thumbnail.cpp

To: muhlenpfordt, #frameworks, rkflx
Cc: ngraham, rkflx