D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann added a comment.


  I don't think we should alter the default.
  If you can not find it in neither the settings nor the context menu, we 
really can't help you.
  And I agree with Dominik, that usually, you just not care for the maximum 
number.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13442: Implemented displaying of total lines in kate

[Nathaniel Graham]

ngraham added a comment.


  Thanks!
  
  Unfortunately, Subham's patch still had the feature turned off by default. 
Any chance we have have it on by default, and rely on the new context menu to 
help experts with limited horizontal status bar space figure out how to turn it 
off as needed?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann closed this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  We can keep the dialog stuff ;=)
  
  Ok, I pushed the original parts + the status bar stuff. (and a minor fix in 
updateConfig)
  
  Git commit 3f0638e717a990c81fbc248298cc62709e8af851 by Christoph Cullmann, on 
behalf of Shubham Jangra.
  Committed on 20/06/2018 at 18:40.
  Pushed by cullmann into branch 'master'.
  
  Implemented displaying of total lines in kate
  
  GUI: new option to display total lines in the status bar
  
  BUG: 387362
  
  M  +3-0src/dialogs/katedialogs.cpp
  M  +10   -0src/dialogs/textareaappearanceconfigwidget.ui
  M  +25   -0src/utils/kateconfig.cpp
  M  +5-0src/utils/kateconfig.h
  
  https://commits.kde.org/ktexteditor/3f0638e717a990c81fbc248298cc62709e8af851
  
  Git commit 7651b840075f90e2091903e5d918ad03517fee19 by Christoph Cullmann.
  Committed on 20/06/2018 at 18:40.
  Pushed by cullmann into branch 'master'.
  
  add context menu to statusbar to toggle show total lines/word count
  
  GUI: context menu for status bar to alter settings
  
  Differential Revision: https://phabricator.kde.org/D13442
  
  M  +32   -0src/view/katestatusbar.cpp
  M  +3-0src/view/katestatusbar.h
  M  +1-0src/view/kateview.cpp
  
  https://commits.kde.org/ktexteditor/7651b840075f90e2091903e5d918ad03517fee19
  
  > Thanks for the contribution.
  ==

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13442: Implemented displaying of total lines in kate

[Nathaniel Graham]

ngraham added a comment.


  In terms of user interface principles, a context menu should never be the 
sole place where something can be accessed. Context menus are accelerators for 
experts; many regular users never use them, and of course they're not available 
at all with a touch interface (e.g. a convertible laptop).
  
  So if we move the setting to a context menu, it needs to also be available 
elsewhere too.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  Okay fine

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann added a comment.


  I want a context menu on the status bar, it is only a few lines of code.
  I will add that and move the show word count option to that place too.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  You want a context menu which opens when right clicked on the status bar or 
the editor?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann added a comment.


  I will take a look at the context menu part.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  Cullman,brauch,dhaumann : can you please tell how to have a context menu?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  Since the word count option is similar to line count in the config options, 
can't I just show word count and line count with a single button option?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  In D13442#277786 , @ngraham wrote:
  
  > I'm not sure how to do that, and I realize it might be a lot of work.
  >
  > In D13442#277600 , @shubham 
wrote:
  >
  > > How can the self toggling be done based on the space available?
  >
  >
  > Conceptually, I would have the status bar emit a signal when it's about to 
elide some of its text, and then connect that to a slot that hides content as 
needed.
  
  
  Seems like they want it as a context menu option

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13442: Implemented displaying of total lines in kate

[Nathaniel Graham]

ngraham added a comment.


  I'm not sure how to do that, and I realize it might be a lot of work.
  
  In D13442#277600 , @shubham wrote:
  
  > How can the self toggling be done based on the space available?
  
  
  Conceptually, I would have the status bar emit a signal when it's about to 
elide some of its text, and then connect that to a slot that hides content as 
needed.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  Oh, didnt come to me that of part when translated to other languages may 
result in longer texts, so this configure option is to be received and context 
menu is to be added?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13442: Implemented displaying of total lines in kate

[Dominik Haumann]

dhaumann added a comment.


  +1 for the context menu on the line/column fields.
  
  By the way, the argument that " of " is short does not hold, since 
translations into other languages may result in much longer text.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13442: Implemented displaying of total lines in kate

[F. Fox]

firef added a comment.


  a line counter as an ECMAscript snippet ships with:
  
  https://store.kde.org/p/1240493

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13442: Implemented displaying of total lines in kate

[Sven Brauch]

brauch added a comment.


  I was also thinking about the context menu, yes. That is also where a lot of 
users would first look for it I think, even before the config dialog.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  The "of " is mere couple of alphabets, does this takes space on the bar and 
annoys, I dont think so, in my view 
  it should be by default,what u say cullmann?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann added a comment.


  But then the question is: some want it, some not, and it is always visible, 
what to do?
  Perhaps the choice to have a config dialog entry is already bad and we should 
just have a context menu for the statusbar that allows to configure the 
appearance like other editors do?
  Then we wouldn't clutter the config dialog at all.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Sven Brauch]

brauch added a comment.


  I don't like this being user-controllable. We spend so much effort in keeping 
our option set clearly arranged and limited to useful choices, to me this seems 
like a very bad opportunity to break that rule.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  How can the self toggling be done based on the space available?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Nathaniel Graham]

ngraham added a comment.


  Now the option is disabled by default, so nobody will ever find it, kind of 
defeating the point. If we absolutely have to make this a user-controllable 
option, I recommend having it on by default, because most of the time you're 
not space constrained. However I still think a far more user-friendly approach 
is to have no user-visible option and for it to simply turn itself off 
automatically when there's limited space in the status bar.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham updated this revision to Diff 36019.
shubham added a comment.


  This patch implements the config option for the display of total lines in a 
document.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13442?vs=35886&id=36019

REVISION DETAIL
  https://phabricator.kde.org/D13442

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/katestatusbar.cpp

To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Michel Ludwig]

mludwig added a comment.


  If you decide to add a config option, it would be great if you could add a 
programmatic way to inform applications that don't use the default status bar 
about changes regarding that config option.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  I think the "of .." part is so small it wont bother anyone ,

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Nathaniel Graham]

ngraham added a comment.


  In that case, maybe it would make more sense to have it disappear on its own 
when there's not enough room to properly display it. That would be a lot more 
user-friendly than making you hunt around in the settings dialog every time you 
open a vertical split view or make the window small.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Alexander Zhigalin]

zhigalin added a comment.


  In D13442#276750 , @ngraham wrote:
  
  >   what's the use case for someone who wants it off?
  
  
  Small or vertically divided window for me...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Nathaniel Graham]

ngraham added a comment.


  Are we sure this needs another preference to control it? Especially if it's 
on by default (which I would recommend), what's the use case for someone who 
wants it off and (more importantly) knows the settings exists and can easily 
find it?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Alexander Zhigalin]

zhigalin added a comment.


  In D13442#276584 , @shubham wrote:
  
  > Cullman , I just got intimidated by what and all is to be added, but no 
problem I will do it anf if doubt arises will ask it to you
  
  
  You can see what you should add here D11822 
 that's not so much as you fear...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann added a comment.


  @dhaumann: I would only show the max colum of the current line ;=) but as 
said, better lets focus on the max line, until nobody seemed to care for max 
column.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Dominik Haumann]

dhaumann added a comment.


  @cullmann Hm, ist showing the maximum column really important. You'd need to 
compute this over the entire document ...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  Cullman , I just got intimidated by what and all is to be added, but no 
problem I will do it anf if doubt arises will ask it to you

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann added a comment.


  Hi,
  
  my idea with the link to the patch was, that it shows which places to touch 
for a new option.
  
  You need to add a bool with getter/setter to kateconfig.cpp/h
  You need to add a checkbox to the dialog in katedialogs.cpp (and the ui file).
  
  I think if you look around in the attached patch and the files you will see 
what is needed.
  If something concrete is unclear, please ask.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  I'm finding it difficult to implement it , can you help?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  Can I make "show word count" checkbox as "show word count and total lines"?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  I'm unable to apply this patch, dont know why

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  Thank you cullman, will try to finish it.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann added a comment.


  For the config stuff, here is a analog addition of UI parts for the "show 
word count":
  
  
https://cgit.kde.org/ktexteditor.git/patch/src/dialogs/katedialogs.cpp?id=594c51bbf61dcf7014a44727519afb4a6b58c074
  
  For the column: just ignore that, we can finish the stuff with the line ;)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  And about the column thing, does it have any importance rather than just 
telling the number of characters in the current line?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  Now I understood,since i,m a novice can you tell how can that configuration 
option be implemented?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann added a comment.


  Sorry, I did mix up things, more clear, hopefully:
  
  1. I think one shall have a configuration option to turn the "of ..." part 
on/off, people might not like it, and as it is always visible, that might be bad
  2. One might think about showing "Column x of y", too.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  Cullman I didnt get you, do u want a display for max column, isnt the maximum 
column same  as opposed to line.Is it req?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann added a comment.


  Actually, it might make sense to show the maximal column, too.
  But perhaps we should make that configurable.
  Options are bad on one side, but the space in the statusbar is not that large 
if you have a smaller windows.
  Could you add a preference for that?
  We don't need a menu entry, just a global preference to show max line/column 
info.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Nathaniel Graham]

ngraham added a comment.


  I was expressing support for the current state, no need for changes from my 
perspective. :-)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  Should I display it as a fraction or leave it, having mixed reactions

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Nathaniel Graham]

ngraham added a comment.


  +1, this seems like a good way to display it to me!
  
  I rather like seeing the total number of lines, especially as implemented 
with this patch, as expressed as a sort of fraction. I think it gives the user 
a good sense of position.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Dominik Haumann]

dhaumann added a comment.


  Personally, I belong to the group that does not care about the total number 
of lines. To me, this is visual noise. The current line number is relevant for 
me, since it identifies a unique location in the document. But if you think 
this is required I will not stop this patch.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham updated this revision to Diff 35886.
shubham added a comment.


  hopefully this is the final patch.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13442?vs=35881&id=35886

REVISION DETAIL
  https://phabricator.kde.org/D13442

AFFECTED FILES
  src/view/katestatusbar.cpp

To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  Will change that too

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann added a comment.


  It makes sense to be consistent.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  In D13442#276202 , @brauch wrote:
  
  > Since the other two number displays use QLocale().toString(), probaly this 
should too ...
  
  
  Is it mandatory?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Sven Brauch]

brauch added a comment.


  Since the other two number displays use QLocale().toString(), probaly this 
should too ...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham updated this revision to Diff 35881.
shubham added a comment.


  This should be fine?

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13442?vs=35872&id=35881

REVISION DETAIL
  https://phabricator.kde.org/D13442

AFFECTED FILES
  src/view/katestatusbar.cpp

To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  As you wish , will implement in the next patch

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann added a comment.


  Hi,
  I can understand that some people want that, but I think in this way, it 
takes a lot of space.
  If we want that, could we not just say
  
  Line 20 of 100, Column 34?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham edited reviewers, added: brauch; removed: ngraham.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added reviewers: cullmann, ngraham.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, ngraham
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham edited reviewers, added: KTextEditor; removed: cullmann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham edited reviewers, added: cullmann; removed: KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham created this revision.
shubham added a reviewer: KTextEditor.
shubham created this object with visibility "All Users".
shubham added a project: KTextEditor.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.
shubham requested review of this revision.

REVISION SUMMARY
  Feature: 387362

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

AFFECTED FILES
  src/view/katestatusbar.cpp

To: shubham, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann