D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines
loh.tar added a comment. > can you please rephrase the title of this review to make it understandable? Of course, if I could, I would have done it :-) "Remove all what is not nice text" ? It may help you to read all posts to get a hint of my intention. It turned out that this here ist still not working charming. Sometimes is still stuff removed which shouldn't. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17128 To: loh.tar, #ktexteditor, cullmann, mwolff Cc: mwolff, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, head7, kfunk, sars
D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines
mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. can you please rephrase the title of this review to make it understandable? "Remove all" - what do you remove? All what? Also, can you please add tests for the feature you are adding, this also acts as documentation on what this patch actually does REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17128 To: loh.tar, #ktexteditor, cullmann, mwolff Cc: mwolff, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, head7, kfunk, sars
D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines
loh.tar added inline comments. INLINE COMMENTS > katedocument.cpp:4016 > // behavior when deleting from the start of a line, just when > explicitly > // calling the join command > Kate::TextLine tl = kateTextLine(line + 1); Can one point me why this is needed/desired? I'm often annoyed from the keeped space REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17128 To: loh.tar, #ktexteditor, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, head7, kfunk, sars
D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines
loh.tar updated this revision to Diff 48994. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. Try to be smart REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17128?vs=48486=48994 REVISION DETAIL https://phabricator.kde.org/D17128 AFFECTED FILES src/document/katedocument.cpp To: loh.tar, #ktexteditor, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, head7, kfunk, sars
D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines
loh.tar added a comment. It's almost untested, will try to use it on daily basis. After think a little about it, I came to this variant. Code lines are unlikely to "join", so why test for comments? A little off topic: Would it OK to modify the wrap stuff that it behaves differently? There are some bug reports and comments which often says, "nope". I have in mind that without a selection only the current line is wrapped and not the whole document. REVISION DETAIL https://phabricator.kde.org/D17128 To: loh.tar, #ktexteditor, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, head7, kfunk, sars
D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines
loh.tar updated this revision to Diff 48486. loh.tar retitled this revision from "DocumentPrivate: Remove comment mark when joining lines" to "WIP DocumentPrivate: Remove all from next line which may annoying when joining lines". loh.tar edited the summary of this revision. loh.tar added a comment. - Don't rely on comments or highlighting This way you can also handy join e-mail like quotations. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17128?vs=46095=48486 REVISION DETAIL https://phabricator.kde.org/D17128 AFFECTED FILES src/document/katedocument.cpp To: loh.tar, #ktexteditor, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, head7, kfunk, sars
