D18163: Set the color scheme to Printing when print preview'ing

2019-01-30 Thread Milian Wolff 
mwolff requested changes to this revision.
mwolff added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kateprinter.cpp:164
>  QPrinter printer;
> -KatePrinterPrivate p(view->doc(), view);
> +KatePrinterPrivate p(view->doc(), view, true);
>  QPrintPreviewDialog preview();

better add a setter before and then call

`p.setColorScheme(QStringLiteral("Printing"));`

here

> kateprinter.cpp:180
>  QPrinter printer;
> -KatePrinterPrivate p(doc);
> +KatePrinterPrivate p(doc, nullptr, true);
>  QPrintPreviewDialog preview();

dito

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18163: Set the color scheme to Printing when print preview'ing

2019-01-29 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 50503.
ahmadsamir retitled this revision from "KateRenderer: when printing initially 
set the color scheme to Printing" to "Set the color scheme to Printing when 
print preview'ing".
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this revision.
ahmadsamir removed a subscriber: mwolff.
ahmadsamir added a comment.


  Only set the color scheme to printing when using print preview

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18163?vs=49184=50503

BRANCH
  print-preview-text-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18163

AFFECTED FILES
  src/printing/kateprinter.cpp

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann