D19102: Fix extraction of aspect ratio property
This revision was automatically updated to reflect the committed changes. Closed by commit R286:1082b1e009bc: Fix extraction of aspect ratio property (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19102?vs=52114=53021 REVISION DETAIL https://phabricator.kde.org/D19102 AFFECTED FILES autotests/ffmpegextractortest.cpp autotests/propertyinfotest.cpp src/extractors/ffmpegextractor.cpp src/formatstrings.cpp src/formatstrings_p.h src/propertyinfo.cpp To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D19102: Fix extraction of aspect ratio property
astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:157 > Thats obviously just avoiding the rules. You can ask for an exception anyway. The intention was to land the fix as soon as possible while complying to the rules, and fixing the i18n in the following frameworks release. REPOSITORY R286 KFileMetaData BRANCH ffmpeg_aspectratio REVISION DETAIL https://phabricator.kde.org/D19102 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D19102: Fix extraction of aspect ratio property
bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > astippich wrote in formatstrings.cpp:157 > That was actually done deliberately to get this in for Kf 5.56 since there is > string freeze. But if concatenation is a no go, this has to wait Thats obviously just avoiding the rules. You can ask for an exception anyway. REPOSITORY R286 KFileMetaData BRANCH ffmpeg_aspectratio REVISION DETAIL https://phabricator.kde.org/D19102 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D19102: Fix extraction of aspect ratio property
astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:157 > Proper i18n That was actually done deliberately to get this in for Kf 5.56 since there is string freeze. But if concatenation is a no go, this has to wait REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19102 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D19102: Fix extraction of aspect ratio property
astippich updated this revision to Diff 52114. astippich added a comment. - do not use QString::number REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19102?vs=52104=52114 BRANCH ffmpeg_aspectratio REVISION DETAIL https://phabricator.kde.org/D19102 AFFECTED FILES autotests/ffmpegextractortest.cpp autotests/propertyinfotest.cpp src/extractors/ffmpegextractor.cpp src/formatstrings.cpp src/formatstrings_p.h src/propertyinfo.cpp To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D19102: Fix extraction of aspect ratio property
bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> formatstrings.cpp:157
> +{
> +return QString(QString::number(round(value.toDouble() * 100) / 100) +
> QStringLiteral(":1"));
> +}
Proper i18n
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D19102
To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns, abrahams
D19102: Fix extraction of aspect ratio property
astippich updated this revision to Diff 52104. astippich added a comment. - rebase - use exact value for test REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19102?vs=51918=52104 BRANCH ffmpeg_aspectratio REVISION DETAIL https://phabricator.kde.org/D19102 AFFECTED FILES autotests/ffmpegextractortest.cpp autotests/propertyinfotest.cpp src/extractors/ffmpegextractor.cpp src/formatstrings.cpp src/formatstrings_p.h src/propertyinfo.cpp To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D19102: Fix extraction of aspect ratio property
bruns added inline comments. INLINE COMMENTS > ffmpegextractortest.cpp:53 > QVERIFY(abs(result.properties().value(FrameRate).toDouble() - 23.976) < > 1e-4); > +QVERIFY(abs(result.properties().value(AspectRatio).toDouble() - 1.8) > < 1e-4); > } 16.0/9 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19102 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D19102: Fix extraction of aspect ratio property
astippich added a dependency: D19101: Increase precision of frame rate property. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19102 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D19102: Fix extraction of aspect ratio property
astippich created this revision. astippich added reviewers: bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY The extraction of the aspect ratio was broken for multiple reasons. Using the function provided by ffmpeg fixes this. REPOSITORY R286 KFileMetaData BRANCH ffmpeg_aspectratio REVISION DETAIL https://phabricator.kde.org/D19102 AFFECTED FILES autotests/ffmpegextractortest.cpp autotests/propertyinfotest.cpp src/extractors/ffmpegextractor.cpp src/formatstrings.cpp src/formatstrings_p.h src/propertyinfo.cpp To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
