D19436: [kservice] compile without deprecated method
This revision was automatically updated to reflect the committed changes. Closed by commit R309:45337a4c28c3: [kservice] compile without deprecated method (authored by mlaurent). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19436?vs=53011=53018 REVISION DETAIL https://phabricator.kde.org/D19436 AFFECTED FILES CMakeLists.txt autotests/kmimeassociationstest.cpp autotests/ksycocathreadtest.cpp src/services/kservicetypeprofile.cpp src/sycoca/kbuildservicefactory.cpp src/sycoca/kbuildsycoca.cpp To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D19436: [kservice] compile without deprecated method
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH compile_without_deprecated_method (branched from master) REVISION DETAIL https://phabricator.kde.org/D19436 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D19436: [kservice] compile without deprecated method
mlaurent updated this revision to Diff 53011. mlaurent added a comment. Use toSecsSinceEpoch REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19436?vs=52878=53011 BRANCH compile_without_deprecated_method (branched from master) REVISION DETAIL https://phabricator.kde.org/D19436 AFFECTED FILES CMakeLists.txt autotests/kmimeassociationstest.cpp autotests/ksycocathreadtest.cpp src/services/kservicetypeprofile.cpp src/sycoca/kbuildservicefactory.cpp src/sycoca/kbuildsycoca.cpp To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D19436: [kservice] compile without deprecated method
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ksycocathreadtest.cpp:306
> now = QDateTime::currentDateTime();
> -if (now.toTime_t() == ctime.toTime_t()) // truncate milliseconds
> +if (now.toMSecsSinceEpoch() == ctime.toMSecsSinceEpoch()) //
> truncate milliseconds
> {
This doesn't truncate milliseconds anymore
You should port toTime_t to toSecsSinceEpoch (no 'M')
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D19436
To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D19436: [kservice] compile without deprecated method
mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without deprecated method TEST PLAN autotest ok REPOSITORY R309 KService BRANCH compile_without_deprecated_method (branched from master) REVISION DETAIL https://phabricator.kde.org/D19436 AFFECTED FILES CMakeLists.txt autotests/kmimeassociationstest.cpp autotests/ksycocathreadtest.cpp src/services/kservicetypeprofile.cpp src/sycoca/kbuildservicefactory.cpp src/sycoca/kbuildsycoca.cpp To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
