D19979: Don't create thumbnails for encrypted Vaults

2019-03-24 Thread Ivan Čukić 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:bc42a1b2f913: Dont create thumbnails for encrypted 
Vaults (authored by ivan).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19979?vs=54673=54678

REVISION DETAIL
  https://phabricator.kde.org/D19979

AFFECTED FILES
  src/widgets/previewjob.cpp

To: ivan, davidedmundson, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19979: Don't create thumbnails for encrypted Vaults

2019-03-24 Thread David Edmundson 
davidedmundson accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19979

To: ivan, davidedmundson, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19979: Don't create thumbnails for encrypted Vaults

2019-03-24 Thread Ivan Čukić 
ivan updated this revision to Diff 54673.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19979?vs=54582=54673

REVISION DETAIL
  https://phabricator.kde.org/D19979

AFFECTED FILES
  src/widgets/previewjob.cpp

To: ivan, davidedmundson, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19979: Don't create thumbnails for encrypted Vaults

2019-03-24 Thread Ivan Čukić 
ivan marked an inline comment as done.
ivan added inline comments.

INLINE COMMENTS

> broulik wrote in previewjob.cpp:307
> Did you profile the impact of this call? I don't think it's cached. Can this 
> maybe be moved to the thumbnail KIO so it's done out of process?

I didn't do any profiling.

We can not cache because mount points can change. KMountPoint provides no 
signals of this.

It should not be overly expensive - small number of mounts to process.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19979

To: ivan, davidedmundson, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19979: Don't create thumbnails for encrypted Vaults

2019-03-23 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> previewjob.cpp:307
>  
> +auto mountsList = KMountPoint::currentMountPoints();
> +KMountPoint::List encryptedMountsList;

Did you profile the impact of this call? I don't think it's cached. Can this 
maybe be moved to the thumbnail KIO so it's done out of process?

> previewjob.cpp:325
> +
> +if (encryptedMountsList.findByPath(item.item.url().toLocalFile())) {
> +continue;

Use `KFileItem::localPath()`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19979

To: ivan, davidedmundson, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19979: Don't create thumbnails for encrypted Vaults

2019-03-22 Thread Ivan Čukić 
ivan edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19979

To: ivan, davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19979: Don't create thumbnails for encrypted Vaults

2019-03-22 Thread Ivan Čukić 
ivan retitled this revision from "Don't create thumbnails for encrypted drives 
(Vaults)" to "Don't create thumbnails for encrypted Vaults".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19979

To: ivan, davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns