D24598: Update elisa icon

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:a51651fd91a2: Update elisa icon (authored by astippich).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24598?vs=68192&id=68470

REVISION DETAIL
  https://phabricator.kde.org/D24598

AFFECTED FILES
  icons-dark/apps/22/elisa.svg
  icons-dark/apps/48/elisa.svg
  icons/apps/22/elisa.svg
  icons/apps/48/elisa.svg

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24598: Update elisa icon

[TrickyRicky]

trickyricky26 accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  elisa_updated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24598: Update elisa icon

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24598: Update elisa icon

[Alexander Stippich]

astippich updated this revision to Diff 68192.
astippich added a comment.


  - update and save as optimized svg

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24598?vs=67836&id=68192

BRANCH
  elisa_updated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24598

AFFECTED FILES
  icons-dark/apps/22/elisa.svg
  icons-dark/apps/48/elisa.svg
  icons/apps/22/elisa.svg
  icons/apps/48/elisa.svg

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24598: Update elisa icon

[Nathaniel Graham]

ngraham added a comment.


  Let's get this in!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24598: Update elisa icon

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24598: Update elisa icon

[Matthieu Gallien]

mgallien accepted this revision.
mgallien added a comment.


  Thanks

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24598: Update elisa icon

[Nathaniel Graham]

ngraham added a comment.


  In D24598#548335 , @astippich 
wrote:
  
  > This is with the tape window moved up 1px
  >  F7608368: elisaBigNew2.png 
  >  When I look at images of real cassettes, they are not centered, hence why 
I only did this slight adjustment.
  >  If everyone is okay with this, I will update the revision with the 
optimized svgs.
  >  I don't think that filling this space is useful.
  
  
  That's just fine IMO!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24598: Update elisa icon

[Alexander Stippich]

astippich added a comment.


  This is with the tape window moved up 1px
  F7608368: elisaBigNew2.png 
  When I look at images of real cassettes, they are not centered, hence why I 
only did this slight adjustment.
  If everyone is okay with this, I will update the revision with the optimized 
svgs.
  I don't think that filling this space is useful.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24598: Update elisa icon

[TrickyRicky]

trickyricky26 requested changes to this revision.
trickyricky26 added a comment.
This revision now requires changes to proceed.


  Please optimize the SVG files using one of these methods: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization
  
  In D24598#546420 , @astippich 
wrote:
  
  > F7585764: elisaSmallNew.png 
  >
  > F7585766: elisaBigNew.png 
  
  
  About the design itself, I think the area where the "Elisa" branding was 
previously looks a bit empty now. I would suggest you either find some nice 
pattern to put there or simply center the tape window in the colored area.
  Overall I think this is a good improvement, the letters in that icon were 
what kept me from putting Elisa permanently in my dock :P

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24598: Update elisa icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Lovely!

REPOSITORY
  R266 Breeze Icons

BRANCH
  elisa_updated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien
Cc: GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24598: Update elisa icon

[Alexander Stippich]

astippich added a comment.


  F7585764: elisaSmallNew.png 
  
  F7585766: elisaBigNew.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien
Cc: GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24598: Update elisa icon

[Alexander Stippich]

astippich updated this revision to Diff 67836.
astippich added a comment.


  - update

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24598?vs=67799&id=67836

BRANCH
  elisa_updated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24598

AFFECTED FILES
  icons-dark/apps/22/elisa.svg
  icons-dark/apps/48/elisa.svg
  icons/apps/22/elisa.svg
  icons/apps/48/elisa.svg

To: astippich, #vdg, ngraham, mgallien
Cc: GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24598: Update elisa icon

[Matthieu Gallien]

mgallien added a comment.


  In D24598#546135 , @astippich 
wrote:
  
  > I have no intention on taking over D12992 
 as I would like rather like to code for 
Elisa. I am no designer.
  >  I was unsatisfied with the icon and @mgallien agreed on some slight 
adjustments to the current one.
  >  D12992  has been around for ages. I 
hope that this incremental update can be agreed upon faster and land for next 
frameworks release. Especially I find the "Elisa" text ugly and worth removing 
it quickly.
  
  
  I am in support of the work that is done here. Thanks @astippich

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien
Cc: GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24598: Update elisa icon

[Nathaniel Graham]

ngraham added a comment.


  Can you make the gradient extend all the way to the top of the white center 
area?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien
Cc: GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24598: Update elisa icon

[Alexander Stippich]

astippich added a comment.


  I have no intention on taking over D12992 
 as I would like rather like to code for 
Elisa. I am no designer.
  I was unsatisfied with the icon and @mgallien agreed on some slight 
adjustments to the current one.
  D12992  has been around for ages. I hope 
that this incremental update can be agreed upon faster and land for next 
frameworks release. Especially I find the "Elisa" text ugly and worth removing 
it quickly.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien
Cc: GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24598: Update elisa icon

[Björn Feber]

GB_2 added a comment.


  I don't think it makes sense to change the icon here if D12992 
 already does it. If you want it to 
progress then take over the revision and work on the completely new style there 
or make a ping comment and have some patience.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien
Cc: GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24598: Update elisa icon

[Alexander Stippich]

astippich added a comment.


  old icons
  22px
  F7580424: elisaSmallOld.png 
  48px
  F7580438: elisaBigOld.png 
  
  updated icons
  22px
  F7580429: elisaSmall.png 
  48px
  F7580433: elisaBig.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien
Cc: kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, GB_2, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24598: Update elisa icon

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: VDG, ngraham, mgallien.
astippich added a project: Elisa.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Since D12992  seems stuck, update the 
current icon
  a little bit and add a blueish gradient to the
  icon. Also remove the ugly text for the 48px icon,
  since it was not readable anyway at small sizes.

REPOSITORY
  R266 Breeze Icons

BRANCH
  elisa_updated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24598

AFFECTED FILES
  icons-dark/apps/22/elisa.svg
  icons-dark/apps/48/elisa.svg
  icons/apps/22/elisa.svg
  icons/apps/48/elisa.svg

To: astippich, #vdg, ngraham, mgallien
Cc: kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, GB_2, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien