D24621: [RFC] New Konsole and Yakuake icons

2019-11-02 Thread Mariusz Glebocki
mglb abandoned this revision.
mglb added a comment.


  Yakuake icon moved to: https://phabricator.kde.org/D25123
  
  Abandoning this one. If I decide to come back with Konsole icon I'll do it in 
dedicated task.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

To: mglb, #vdg, #konsole, #yakuake, trickyricky26
Cc: ngraham, trickyricky26, ndavis, cblack, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns


D24621: [RFC] New Konsole and Yakuake icons

2019-11-02 Thread Mariusz Glebocki
mglb added a comment.


  I'll do the split today or tomorrow.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

To: mglb, #vdg, #konsole, #yakuake, trickyricky26
Cc: ngraham, trickyricky26, ndavis, cblack, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns


D24621: [RFC] New Konsole and Yakuake icons

2019-10-31 Thread Nathaniel Graham
ngraham added a comment.


  In D24621#547787 , @ngraham wrote:
  
  > I really like the Yakuake icon that has a subtle "Y" in it. If everyone 
else does too, maybe that should be moved into a separate patch so we can get 
it in quickly and then concentrate on the Konsole icon.
  
  
  @mglb could we move forward with this so the Yakuake icon doesn't get stuck 
waiting on the results of the conversation about the Konsole icon?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

To: mglb, #vdg, #konsole, #yakuake, trickyricky26
Cc: ngraham, trickyricky26, ndavis, cblack, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns


D24621: [RFC] New Konsole and Yakuake icons

2019-10-15 Thread Nathaniel Graham
ngraham added a comment.


  I really like the Yakuake icon that has a subtle "Y" in it. If everyone else 
does too, maybe that should be moved into a separate patch so we can get it in 
quickly and then concentrate on the Konsole icon.
  
  Personally I'm not 100% sold on integrating the bottom tabs into the icon. 
The tab bar location is configurable, after all. But, I won't formally object 
to that part if everyone else likes it. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

To: mglb, #vdg, #konsole, #yakuake, trickyricky26
Cc: ngraham, trickyricky26, ndavis, cblack, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns


D24621: [RFC] New Konsole and Yakuake icons

2019-10-14 Thread Mariusz Glebocki
mglb edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

To: mglb, #vdg, #konsole, #yakuake, trickyricky26
Cc: trickyricky26, ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns


D24621: [RFC] New Konsole and Yakuake icons

2019-10-14 Thread Mariusz Glebocki
mglb added a comment.


  Please note that Konsole icon is intended to be personalized icon/"logo" (see 
T10243 ).
  The prompt symbol is thick as it is main symbol (like symbols in e.g Plasma, 
Akregator, Kile, "K" icons/logos) - the window-like background (or just square 
in var C) is just secondary addition.
  
  I did Yakuake symbol first and this is the only one I really like. Konsole 
symbol is just an attempt to make something similar, so ideas how to modify it 
are welcome.
  
  In D24621#546750 , @ndavis wrote:
  
  > I think that green color is not particularly Breeze-like and there's no 
clear reason why green would be a symbol for Konsole.
  
  
  This is  "Icon Green" (the prompt slightly lighter, K slightly darker), 
breeze secondary color.
  In terminals era, monochrome monitors were usually green, amber or white. 
Green one was apparently most popular. Green terminal is also a thing in pop 
culture today.
  
  > I do like the idea of tabs on the bottom, but they look a bit off somehow. 
Maybe it's because they don't look like Breeze tabs? We may want to consider 
changing the look of Breeze tabs in the future though, so it's probably best if 
we don't try too hard to match the look of the Breeze widget theme.
  >  Maybe something like this? I'm not sure. F7592258: 
Screenshot_20191014_011043.png  F7592287: 
konsole.svg 
  
  Intentional - I wanted to make it more symbolic than real-looking. Realistic 
widget representations are good for utility icons (e.g preferences) IMO. Also, 
when I look at this dark background and ">_" in variant B, I see something like 
squarish Konsole-Konqui :P
  
  In D24621#546894 , @trickyricky26 
wrote:
  
  > gradients with bigger differences between the colors.
  
  
  Changed, now the ligthness difference in dark gradient is similar to other 
icons.
  
  > IIRC the discussion about the redesign of these icons started with the 
problem that they are not recognizable enough as standalone apps, not just as 
genric terminal emulators. I think we should try to experiment some more with 
the "K" symbol until we maybe find a variant that we like and fits well enough 
with other Breeze icons. Otherwise, I don't necessarily think or one of the 
variant B icons will be an improvement over the current Konsole icon, which I 
personally like because of it's simplicity.
  
  There were also complaints that there is no Konsole icon in Breeze, only 
generic utilities-terminal.
  
  ---
  
  Update: lighter background
  F7595525: konsole-icon.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

To: mglb, #vdg, #konsole, #yakuake, trickyricky26
Cc: trickyricky26, ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns


D24621: [RFC] New Konsole and Yakuake icons

2019-10-14 Thread Mariusz Glebocki
mglb updated this revision to Diff 67926.
mglb added a comment.


  Brighten background

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24621?vs=67871=67926

BRANCH
  mglb/add-konsole-yakuake-icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

AFFECTED FILES
  icons/apps/48/konsole.svg
  icons/apps/48/yakuake.svg

To: mglb, #vdg, #konsole, #yakuake, trickyricky26
Cc: trickyricky26, ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns


D24621: [RFC] New Konsole and Yakuake icons

2019-10-14 Thread TrickyRicky
trickyricky26 requested changes to this revision.
trickyricky26 added a comment.
This revision now requires changes to proceed.


  Before this is can be landed, you will have to also add/change the Konsole 
and Yakuake icons in the icons-dark directory.
  
  While I think these icons do look nice on their own and I quite like the 
clever design of the Yakuake Prompt / "Y" symbol, I don't think they fit the 
Breeze icon style very well. I think they are too boxy and flat (even though 
you used gradients) to fit in. I would suggest you try to use more slim lines, 
similar to the current Konsole icon, as well as gradients with bigger 
differences between the colors.
  
  In D24621#546750 , @ndavis wrote:
  
  > Maybe something like this? I'm not sure. F7592258: 
Screenshot_20191014_011043.png  F7592287: 
konsole.svg 
  
  
  I think these tabs look more Breeze-y, but still the icon looks quite flat 
and imo the thickness of the prompt symbol does not look right for a Breeze 
icon.
  
  In D24621#546750 , @ndavis wrote:
  
  > I think the K in most of the Konsole variants is a bit too much and I think 
it would be too distracting. It's not immediately obvious that it's a K. When I 
look at it, the first thing my eyes see is "**>**__|**<**__", rather than 
"**>**__K__", which is confusing. IIRC the discussion about the redesign of 
these icons started with the problem that they are not recognizable enough as 
standalone apps, not just as genric terminal emulators. I think we should try 
to experiment some more with the "K" symbol until we maybe find a variant that 
we like and fits well enough with other Breeze icons. Otherwise, I don't 
necessarily think F7592258: Screenshot_20191014_011043.png 
  or one of the variant B icons will be 
an improvement over the current Konsole icon, which I personally like because 
of it's simplicity.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

To: mglb, #vdg, #konsole, #yakuake, trickyricky26
Cc: trickyricky26, ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns


D24621: [RFC] New Konsole and Yakuake icons

2019-10-13 Thread Noah Davis
ndavis added a comment.


  The Yakuake icon is a major improvement. The little angled rectangle making 
the prompt arrow look like a Y is a little distracting, but also kind of 
charming and helps to distinguish it from Konsole. I kind of still prefer the 
plainer ">_" version though.
  
  I think the K in most of the Konsole variants is a bit too much and I think 
it would be too distracting. It's not immediately obvious that it's a K. When I 
look at it, the first thing my eyes see is "**>**__|**<**__", rather than 
"**>**__K__", which is confusing. I think that green color is not particularly 
Breeze-like and there's no clear reason why green would be a symbol for 
Konsole. The reason why blue is commonly used is because of Plasma Blue 
(`#3daee9`), Plasma's main accent/highlight color. I do like the idea of tabs 
on the bottom, but they look a bit off somehow. Maybe it's because they don't 
look like Breeze tabs? We may want to consider changing the look of Breeze tabs 
in the future though, so it's probably best if we don't try too hard to match 
the look of the Breeze widget theme. 
  Maybe something like this? I'm not sure. F7592258: 
Screenshot_20191014_011043.png  F7592287: 
konsole.svg 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

To: mglb, #vdg, #konsole, #yakuake
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D24621: [RFC] New Konsole and Yakuake icons

2019-10-13 Thread Carson Black
cblack added a comment.


  They look nice, but I'm not sure how well they fit in with other Breeze icons.
  Comparison montages:
  F7590391: image.png 
  F7590397: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

To: mglb, #vdg, #konsole, #yakuake
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D24621: [RFC] New Konsole and Yakuake icons

2019-10-13 Thread Mariusz Glebocki
mglb created this revision.
mglb added reviewers: VDG, Konsole, Yakuake.
mglb added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mglb requested review of this revision.

REVISION SUMMARY
  Variants:
  
  F7589725: konsole-yakuake-icons.png 
  
  Which one do you like? The patch (so far) contains Konsole and Yakuake icons, 
48px, variant A. Personally I like variant C for Konsole the most.
  
  Note that in T10243  I've published 
following version, with slightly different colors:
  F7524018: konsole-icon.png 
  
  If you like these colors (especially dark bg), I can use them.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-konsole-yakuake-icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

AFFECTED FILES
  icons/apps/48/konsole.svg
  icons/apps/48/yakuake.svg

To: mglb, #vdg, #konsole, #yakuake
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns