D25791: Fix writeFlags with KConfigCompilerSignallingItem

2019-12-10 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:89fb70b57115: Fix writeFlags with 
KConfigCompilerSignallingItem (authored by davidedmundson).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25791?vs=71029=71154

REVISION DETAIL
  https://phabricator.kde.org/D25791

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h

To: davidedmundson, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25791: Fix writeFlags with KConfigCompilerSignallingItem

2019-12-10 Thread Kevin Ottens 
ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.


  Indeed not pretty and error prone but as you say: should be fine in 
autogenerated code

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25791

To: davidedmundson, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25791: Fix writeFlags with KConfigCompilerSignallingItem

2019-12-06 Thread David Edmundson 
davidedmundson added a dependent revision: D25792: Add notifiers to workspace 
options kcfg.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25791

To: davidedmundson, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25791: Fix writeFlags with KConfigCompilerSignallingItem

2019-12-06 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: ervin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  KConfigCompilerSignallingItem both inherits KConfigSkeletonItem and
  internally is powered by a separate KConfigSkeletonItem
  
  The generated code calls setWriteFlags on the outer
  KConfigCompilerSignallingItem instance, but the real writing is
  performed by the internal version. We need to set the flags in the right
  place.
  
  Ideally we would do this in an overload of KConfigSkeletonItem, but
  given we can't, I've shadowed the method. This isn't pretty, but given
  the docs say it should generally only be used from auto generated code,
  should be fine.

TEST PLAN
  Used in workspace KCM

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25791

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h

To: davidedmundson, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns