D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

[Nathaniel Graham]

ngraham added a comment.


  Hmm, I'm not totally sure I agree. If the text becomes focusable by tabbing, 
then I think that just clutters up the focus chain with non-interactive UI 
elements that nobody is actually going to care about doing something with 99% 
of the time.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D26649

To: ngraham, dfaure, #frameworks, #vdg, ndavis
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

[David Faure]

dfaure added a comment.


  IMHO the proper fix is to make tabbing work, and to fix Qt not to show a 
caret when the label gets the focus via a mouse click.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D26649

To: ngraham, dfaure, #frameworks, #vdg, ndavis
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:945f1849cc24: [KMessageBox] Only allow selecting text in 
the dialog box using the mouse (authored by ngraham).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26649?vs=73478&id=73555

REVISION DETAIL
  https://phabricator.kde.org/D26649

AFFECTED FILES
  src/kmessagebox.cpp

To: ngraham, dfaure, #frameworks, #vdg, ndavis
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

[Nathaniel Graham]

ngraham added a comment.


  In D26649#593825 , @broulik wrote:
  
  > So you can't tab around to end up focusing the text field?
  
  
  As Noah said, you already can't. This doesn't change anything about what you 
can focus with the tab key.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-more-keyboard-selectability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26649

To: ngraham, dfaure, #frameworks, #vdg, ndavis
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

[Noah Davis]

ndavis added a comment.


  In D26649#593825 , @broulik wrote:
  
  > So you can't tab around to end up focusing the text field?
  
  
  You currently aren't able to, but after you click with the mouse on the text, 
you can use the arrow keys to move an I beam around in the text.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-more-keyboard-selectability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26649

To: ngraham, dfaure, #frameworks, #vdg, ndavis
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

[Kai Uwe Broulik]

broulik added a comment.


  So you can't tab around to end up focusing the text field?

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-more-keyboard-selectability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26649

To: ngraham, dfaure, #frameworks, #vdg, ndavis
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-more-keyboard-selectability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26649

To: ngraham, dfaure, #frameworks, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: dfaure, Frameworks, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now, when you select text in the dialog box, an insertion point 
appears. It never
  disappears. This looks odd: F7882083: Weird Insertion point.png 

  
  The insertion point allows you to navigate the text using the keyboard. But 
this is kind
  of pointless since you have to use the mouse to make the insertion point 
appear in the
  text in the first place, so you might as well just use the mouse to make the 
selection.
  
  This patch makes the text only mouse-selectable. Dolphin recently did the 
same thing
  for its Information Panel labels in D25241 
 for the same reason.
  
  BUG: 416204
  FIXED-IN: 5.67

TEST PLAN
  Try to open 6 items at once in Dolphin and click-and-drag in the message box 
text.
  Test is still selectable, but an insertion point is no longer created that 
cannot be
  removed.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-more-keyboard-selectability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26649

AFFECTED FILES
  src/kmessagebox.cpp

To: ngraham, dfaure, #frameworks, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns