D27106: Convert license statements to SPDX markers

2020-02-08 Thread David Faure 
dfaure added a comment.


  Can you add the repository name in the title of the review request? Otherwise 
they all look the same in emails.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D27106

To: cordlandwehr
Cc: dfaure, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27106: Convert license statements to SPDX markers

2020-02-05 Thread Christophe Giboudeaux 
cgiboudeaux added inline comments.

INLINE COMMENTS

> COPYING:485
>  
> -This library is free software; you can redistribute it and/or
> -modify it under the terms of the GNU Lesser General Public
> -License as published by the Free Software Foundation; either
> -version 2.1 of the License, or (at your option) any later version.
> -
> -This library is distributed in the hope that it will be useful,
> -but WITHOUT ANY WARRANTY; without even the implied warranty of
> -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -Lesser General Public License for more details.
> -
> -You should have received a copy of the GNU Lesser General Public
> -License along with this library; if not, write to the Free Software
> -Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  
> USA
> +SPDX-License-Identifier: LGPL-2.1-or-later
>  

The license shall not be altered :)

> LicenseRef-KDE-Accepted-LGPL.txt:13
> +GNU General Public License for more details.
> \ No newline at end of file


missing new line.

> comment.h:4-5
>  
> -Copyright (c) 2010 Intel Corporation
> -Author: Mateu Batle Sastre 
> -
> -This library is free software; you can redistribute it and/or
> -modify it under the terms of the GNU Lesser General Public
> -License as published by the Free Software Foundation; either
> -version 2.1 of the License, or (at your option) version 3, or any
> -later version accepted by the membership of KDE e.V. (or its
> -successor approved by the membership of KDE e.V.), which shall
> -act as a proxy defined in Section 6 of version 3 of the license.
> -
> -This library is distributed in the hope that it will be useful,
> -but WITHOUT ANY WARRANTY; without even the implied warranty of
> -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -Lesser General Public License for more details.
> -
> -You should have received a copy of the GNU Lesser General Public
> -License along with this library.  If not, see 
> .
> +SPDX-FileCopyrightText: 2010 Intel Corporation
> +SPDX-FileCopyrightText: 2010 Mateu Batle Sastre 
> +

I understand something different: the copyright holder is "Intel corporation", 
Mateu Batle Sastre is a file contributor.

See the FileContributor property: 
https://spdx.org/rdf/terms/dataproperties/fileContributor___-1635717172.html

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D27106

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27106: Convert license statements to SPDX markers

2020-02-02 Thread Andreas Cord-Landwehr 
cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D27106

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27106: Convert license statements to SPDX markers

2020-02-02 Thread Andreas Cord-Landwehr 
cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license statements to SPDX markers and
  add license files.

REPOSITORY
  R235 Attica

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27106

AFFECTED FILES
  COPYING
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/configtest.cpp
  autotests/persontest.cpp
  autotests/privatedatatest.cpp
  autotests/providertest.cpp
  src/accountbalance.cpp
  src/accountbalance.h
  src/accountbalanceparser.cpp
  src/accountbalanceparser.h
  src/achievement.cpp
  src/achievement.h
  src/achievementparser.cpp
  src/achievementparser.h
  src/activity.cpp
  src/activity.h
  src/activityparser.cpp
  src/activityparser.h
  src/atticabasejob.cpp
  src/atticabasejob.h
  src/atticautils.cpp
  src/atticautils.h
  src/buildservice.cpp
  src/buildservice.h
  src/buildservicejob.cpp
  src/buildservicejob.h
  src/buildservicejoboutput.cpp
  src/buildservicejoboutput.h
  src/buildservicejoboutputparser.cpp
  src/buildservicejoboutputparser.h
  src/buildservicejobparser.cpp
  src/buildservicejobparser.h
  src/buildserviceparser.cpp
  src/buildserviceparser.h
  src/category.cpp
  src/category.h
  src/categoryparser.cpp
  src/categoryparser.h
  src/cloud.cpp
  src/cloud.h
  src/cloudparser.cpp
  src/cloudparser.h
  src/comment.cpp
  src/comment.h
  src/commentparser.cpp
  src/commentparser.h
  src/config.cpp
  src/config.h
  src/configparser.cpp
  src/configparser.h
  src/content.cpp
  src/content.h
  src/contentparser.cpp
  src/contentparser.h
  src/deletejob.cpp
  src/deletejob.h
  src/distribution.cpp
  src/distribution.h
  src/distributionparser.cpp
  src/distributionparser.h
  src/downloaddescription.cpp
  src/downloaddescription.h
  src/downloaditem.cpp
  src/downloaditem.h
  src/downloaditemparser.cpp
  src/downloaditemparser.h
  src/event.cpp
  src/event.h
  src/eventparser.cpp
  src/eventparser.h
  src/folder.cpp
  src/folder.h
  src/folderparser.cpp
  src/folderparser.h
  src/forum.cpp
  src/forum.h
  src/forumparser.cpp
  src/forumparser.h
  src/getjob.cpp
  src/getjob.h
  src/homepageentry.cpp
  src/homepageentry.h
  src/homepagetype.cpp
  src/homepagetype.h
  src/homepagetypeparser.cpp
  src/homepagetypeparser.h
  src/icon.cpp
  src/icon.h
  src/itemjob.cpp
  src/itemjob.h
  src/knowledgebaseentry.cpp
  src/knowledgebaseentry.h
  src/knowledgebaseentryparser.cpp
  src/knowledgebaseentryparser.h
  src/license.cpp
  src/license.h
  src/licenseparser.cpp
  src/licenseparser.h
  src/listjob.cpp
  src/listjob.h
  src/listjob_inst.cpp
  src/message.cpp
  src/message.h
  src/messageparser.cpp
  src/messageparser.h
  src/metadata.cpp
  src/metadata.h
  src/parser.cpp
  src/parser.h
  src/person.cpp
  src/person.h
  src/personparser.cpp
  src/personparser.h
  src/platformdependent.h
  src/platformdependent_v2.cpp
  src/platformdependent_v2.h
  src/postfiledata.cpp
  src/postfiledata.h
  src/postjob.cpp
  src/postjob.h
  src/privatedata.cpp
  src/privatedata.h
  src/privatedataparser.cpp
  src/privatedataparser.h
  src/project.cpp
  src/project.h
  src/projectparser.cpp
  src/projectparser.h
  src/provider.cpp
  src/provider.h
  src/providermanager.cpp
  src/providermanager.h
  src/publisher.cpp
  src/publisher.h
  src/publisherfield.cpp
  src/publisherfield.h
  src/publisherfieldparser.cpp
  src/publisherfieldparser.h
  src/publisherparser.cpp
  src/publisherparser.h
  src/putjob.cpp
  src/putjob.h
  src/qtplatformdependent.cpp
  src/qtplatformdependent_p.h
  src/remoteaccount.cpp
  src/remoteaccount.h
  src/remoteaccountparser.cpp
  src/remoteaccountparser.h
  src/topic.cpp
  src/topic.h
  src/topicparser.cpp
  src/topicparser.h
  src/version.h.cmake
  tests/projecttest/main.cpp
  tests/projecttest/projecttest.cpp
  tests/projecttest/projecttest.h

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns