D27372: smb: disable mode bits getting forwarded to KIO
This revision was automatically updated to reflect the committed changes. Closed by commit R320:718abcb69b78: smb: disable mode bits getting forwarded to KIO (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27372?vs=75618=75704 REVISION DETAIL https://phabricator.kde.org/D27372 AFFECTED FILES smb/kio_smb_browse.cpp To: sitter, ngraham Cc: dfaure, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D27372: smb: disable mode bits getting forwarded to KIO
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice, this fixes the bug for me and I think the code change makes logical sense. I really appreciate these long comments. REPOSITORY R320 KIO Extras BRANCH bug414482 REVISION DETAIL https://phabricator.kde.org/D27372 To: sitter, ngraham Cc: dfaure, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D27372: smb: disable mode bits getting forwarded to KIO
sitter added a subscriber: dfaure. sitter added a comment. @dfaure btw, it seems you cannot have no ACL displayed. i.e. properties dialog does `d->hasExtendedACL = item.ACL().isExtended() || item.defaultACL().isValid();` but isExtended is even true for invalid ACLs, so in the smb scenario I have neither modes nor ACLs so it is effectively `KACL()` which is invalid but still isExtended for some reason. Not sure I'll find the motivation to fix that any time soon but thought I should tell you at least :) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27372 To: sitter, ngraham Cc: dfaure, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D27372: smb: disable mode bits getting forwarded to KIO
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY mode bits in libsmb_stat are fairly cheaply constructed. file and directory qualification is alright beyond that it is a bit of a shambles. specifically +W is set iff the DOS attribute READONLY isn't set, but that attribute doesn't mean what we think it means, at least not on NT+ systems. see exhaustive comment. long story short: we cannot represent mode bits accurately because NT's access controls simply do not map to posix mode bits. therefore I'm removing the mode setting for the udsentry, making all entries effectively writable. whether an entry truly is writable is hard to say anyway. specifically because SMB+NTFS have independent ACLs. so, the SMB ACL may allow a given user or group to do something, that doesn't mean they'll also have permissions on a file system level. BUG: 414482 FIXED-IN: 19.12.3 TEST PLAN previously not writable shares as described in the bug report are now writable. permission dialog looks a bit meh now, it wasn't really designed around not knowing what the access situation is. gnome simply shows a "dunno what permissions we have" label instead of everything, that seems like a reasonable approach REPOSITORY R320 KIO Extras BRANCH bug414482 REVISION DETAIL https://phabricator.kde.org/D27372 AFFECTED FILES smb/kio_smb_browse.cpp To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
