Minutes GSoC meeting
Present: me, chinmoy, arnav/shortstheory Minutes are in the attachment. P.S. Minutes of the previous meetings were sent only to the kfm-devel list, but that was an oversight on my part (as chinmoy's project is mainly kio-related and so the frameworks list is the proper place). P.P.S. Meetings are every saturday at 10am UTC on #kde-fm, if anyone wants to join them. Cheers, Elvis2017-07-09 10:00:53 eangMeeting! 2017-07-09 10:01:12 eangchinmoy, shortsthey ? 2017-07-09 10:01:18 IrcsomeBot Yo 2017-07-09 10:01:22 eang*shortstheory 2017-07-09 10:01:31 IrcsomeBot I'm here 2017-07-09 10:02:07 chinmoy[m] eang: here 2017-07-09 10:02:32 eanglet's start! 2017-07-09 10:03:39 chinmoy[m] this week was pretty rough on me. all i did was bit of cleaning up of patches 2017-07-09 10:03:55 chinmoy[m] mostly I worked on dfaure's suggestions 2017-07-09 10:04:51 chinmoy[m] I can say now 90% of KIO's wwork is done 2017-07-09 10:05:23 chinmoy[m] unit tests and all the warnings and rest of the stuffs are in place 2017-07-09 10:05:35 chinmoy[m] only thing left is prepare proper patches 2017-07-09 10:06:01 chinmoy[m] and unlocking of kauth actions 2017-07-09 10:06:18 chinmoy[m] that is all 2017-07-09 10:06:28 IrcsomeBot sounds good 2017-07-09 10:06:43 eanghave you fixed the BIC issue pointer by david? 2017-07-09 10:07:14 chinmoy[m] I created a separate class inheriting from jobuidelegate 2017-07-09 10:07:20 eang*pointed 2017-07-09 10:07:40 IrcsomeBot what issue? 2017-07-09 10:08:15 eanghttps://phabricator.kde.org/D6197#inline-26630 2017-07-09 10:08:16 sKreamerDiff 6197 "Add basic KAuth support to file ioslave" [Needs Revision] https://phabricator.kde.org/D6197 2017-07-09 10:08:46 chinmoy[m] a separate class should do right? 2017-07-09 10:10:14 chinmoy[m] ok I haven't updated the patch so you might not be able to tell. 2017-07-09 10:13:06 chinmoy[m] I have something to ask. Consider this, a user tries to copy a file to '/opt' but there already exists the same file so he decides to overwrite it. now as per the code the file will be deleted and considering it's '/opt' our helper m,ethod will be called and auth dialog will pop up. so what message should be there? 2017-07-09 10:13:30 chinmoy[m] "copying needs privilege" or "deleting needs privilege"? 2017-07-09 10:14:21 eangI'd say the former 2017-07-09 10:14:37 eangthe fact that we delete under the hood is an implementation detail 2017-07-09 10:16:37 chinmoy[m] so the exact reason why password is being asked should'nt be shown? 2017-07-09 10:17:53 IrcsomeBot Yup 2017-07-09 10:17:54 chinmoy[m] say if a user tries to copy a large directory which happens to have one file with read access restricted then won't it add to unnecessary confusion? 2017-07-09 10:22:28 chinmoy[m] eang, shortheory: apart from this have you any ideas whether dolphin has some kind of restrictions on its plugins or not? 2017-07-09 10:23:09 IrcsomeBot No restrictions in my experience 2017-07-09 10:23:30 IrcsomeBot Though most of my work was actually changing parts of dolphin than optional plugins 2017-07-09 10:23:32 eangit runs whatever plugins are installed in the proper place 2017-07-09 10:23:47 IrcsomeBot And Emmanuel approved all of those readily 2017-07-09 10:24:25 IrcsomeBot What plugins would we need here? 2017-07-09 10:24:55 chinmoy[m] if privileges are elevated for a brief time period will a plugin be able to do whatever it wants? 2017-07-09 10:25:55 IrcsomeBot not too sure about that 2017-07-09 10:25:58 eangyes, the plugins are part of the dolphin process, so if they use KIO::del that could be a problem 2017-07-09 10:27:06 chinmoy[m] I really can't get my head around this 2017-07-09 10:27:52 chinmoy[m] it seems we have to remove the persistence 2017-07-09 10:28:39 chinmoy[m] thats about the only solution I could come up with. 2017-07-09 10:32:18 eangwhat about removing the "don't ask again" checkbox? 2017-07-09 10:33:50 chinmoy[m] the dialog won't be having one but its called from the client thus the client can choose to skip the dialog altogether 2017-07-09 10:34:59 eangclient = malicious plugin, in this case? 2017-07-09 10:35:09 chinmoy[m] yes 2017-07-09 10:36:44 eangwe probably need a workspace-level solution, removing the perstistence would be annoying imho 2017-07-09 10:37:11 chinmoy[m] I tried it and it was frustrating 2017-07-09 10:37:24 chinmoy[m] is it possible to generate some kind of uid before calling the job? 2017-07-09 10:37:48 eangI wonder if kio could check whether 3d-party plugins have been installed 2017-07-09 10:3
Minutes GSoC meeting
Present: me, chinmoy Minutes in the attachment. Cheers, Elvis2017-07-15 10:00:18 eangMeeting? 2017-07-15 10:00:39 chinmoy[m] i am here 2017-07-15 10:01:24 eanglet's start, as arnav said he wouldn't make it 2017-07-15 10:01:35 chinmoy[m] sure. 2017-07-15 10:02:19 chinmoy[m] this week i mostly created patches. 2017-07-15 10:03:01 chinmoy[m] however i found one serious flaw in my logic in showing the warning from ioslave 2017-07-15 10:03:47 chinmoy[m] in short with the available infrastructure showing warning at proper times is not just possible 2017-07-15 10:04:31 chinmoy[m] my previous patches just happen to work 2017-07-15 10:05:34 eangwhat's the problem? 2017-07-15 10:07:29 chinmoy[m] the warning from ioslave is only shown properly when a single folder is being deleted and it contains one or more read restricted file. 2017-07-15 10:08:33 chinmoy[m] with arnav's kio-stash and in copy operation the warning would have been shown as many times as there are read-restricted files 2017-07-15 10:11:12 eangI see, how are you planning to address this? 2017-07-15 10:13:48 chinmoy[m] In case you are interested, here's the cause. KIO::del and copy are high level jobs. they create number of subjobs according to the number of items, so, there are that many ioslaves as well. And there is no way for an ioslave to check for existence of its other siblings. 2017-07-15 10:14:46 chinmoy[m] Right now, I removed the code for warning from ioslave 2017-07-15 10:16:14 chinmoy[m] added a job flag PrivilegeExecution for application to use and a public method enablePrivilegeExecution which will be used from the job's side if the above flag is encountered. 2017-07-15 10:17:02 chinmoy[m] and those jobs which use this method will also show warning dialogs as well 2017-07-15 10:19:11 eangthe problem of checking whether other ioslaves are running could be solved with a kded plugin 2017-07-15 10:19:13 chinmoy[m] and when execAsPrivilegeUser is called a signal will be sent to job requessting if the method should be executed and it will be the responsibility of the job to send back a message containing "ElevatePrivilege" 2017-07-15 10:19:33 eang(in case you want to give it a shot) 2017-07-15 10:19:59 chinmoy[m] can you explain it a bit 2017-07-15 10:20:48 eangkded is always running, so an ioslave can query it any time 2017-07-15 10:21:10 eangthe plugin could have dbus methods such as "registerJob", "isJobRunning", etc. 2017-07-15 10:22:22 chinmoy[m] the jobs are scheduled synchronously (addSubJob) so i dont think it would serve the purpose 2017-07-15 10:23:04 chinmoy[m] the slaves will be destroyed as soon as the job finishes no? 2017-07-15 10:24:27 eangyes, but maybe it's possible to query kded between schedule time and deletion time? I don't know 2017-07-15 10:24:47 eanganyway, it would complicate things for sure 2017-07-15 10:25:18 chinmoy[m] definitely 2017-07-15 10:25:36 chinmoy[m] well give me few minutes I will update my patch 2017-07-15 10:26:14 chinmoy[m] I think with my current approach the loopholes David mentioned should be no more 2017-07-15 10:27:06 eangok sounds good 2017-07-15 10:28:44 eangchinmoy: anything else you wanted to discuss? 2017-07-15 10:31:36 chinmoy[m] there's one thing, what does BIC stands for? I think i didn't get it properly. 2017-07-15 10:32:05 eanghave you read https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B ? 2017-07-15 10:32:26 chinmoy[m] ok BCI 2017-07-15 10:33:42 chinmoy[m] I am slowly familiarising myself with abbreviations 2017-07-15 10:34:07 eangI'm actually not sure what BIC stands for 2017-07-15 10:34:07 chinmoy[m] so it is BIC after all 2017-07-15 10:34:23 eangthe important thing is you understand the concept 2017-07-15 10:34:45 eang(it could be Binary Interface Compatibility or something similar) 2017-07-15 10:35:04 chinmoy[m] whatever, now i understood 2017-07-15 10:35:44 eangmeeting over then? 2017-07-15 10:36:01 chinmoy[m] i think yes
Minutes GSoC meeting
Present: me, chinmoy, pepo.
Minutes in the attachment.
Cheers,
Elvis2017-07-22 10:00:25 eangMeeting!
2017-07-22 10:00:41 chinmoy[m] i here
2017-07-22 10:00:57 eangwe can start
2017-07-22 10:01:50 chinmoy[m] this week
2017-07-22 10:02:56 chinmoy[m] I worked on my new approach and made
the dolphin context menu usable inside a read-only folder
2017-07-22 10:04:23 chinmoy[m] things that are not working are,
changing properties, creating archives, creating link to application, and all
operations for a forbidden folder
2017-07-22 10:05:14 <-- pepo_ (~p...@p57a40fc1.dip0.t-ipconnect.de) has
quit (Read error: Connection reset by peer)
2017-07-22 10:05:25 chinmoy[m] there are certain things like dropping
items and renaming multiple files that needs changes from dolphins side
2017-07-22 10:05:30 --> pepo_ (~p...@p57a40fc1.dip0.t-ipconnect.de) has
joined #kde-fm
2017-07-22 10:06:10 eangcreating archives needs support in ark, kinda
out of scope
2017-07-22 10:06:55 chinmoy[m] if we leave that only thing needed
right now is David Faure's acceptance of my approach
2017-07-22 10:07:27 pepo_ and distributions acceptance. I know some patch
out ktexteditor stuff.
2017-07-22 10:08:27 eangpepo_, suse or..?
2017-07-22 10:08:38 pepo_ y
2017-07-22 10:09:48 eangpepo_: I thought that was only temporary
(pending review) ?
2017-07-22 10:11:28 chinmoy[m] so do i need to add someone from suse
for review
2017-07-22 10:12:15 eangchinmoy: yeah, maybe fvogt
2017-07-22 10:12:32 chinmoy[m] ok
2017-07-22 10:12:35 eanghe did some fixes in the ktexteditor patch
2017-07-22 10:14:58 chinmoy[m] then that is all from my side. right
now i am in process of creating a phab task.
2017-07-22 10:15:23 eangchinmoy: could you please recap the new
architecture for the warning dialogs?
2017-07-22 10:15:49 chinmoy[m] sure.
2017-07-22 10:16:38 chinmoy[m] slave will send a signal,
elevatePrivilegeData("AskConfirmation")
2017-07-22 10:17:19 chinmoy[m] and then it will be jobs responsibility
to show the dialog
2017-07-22 10:19:32 chinmoy[m] actually i will upload the diff. then
you can get it better
2017-07-22 10:20:37 eangso am I right that we'll always show the "Root
privileges are required to..." dialog before each operation?
2017-07-22 10:20:50 chinmoy[m] yes
2017-07-22 10:21:44 chinmoy[m] since the warning describes the action
pretty much, we dont need multiple kauth actions
2017-07-22 10:22:08 eangok I think is a good solution, maybe needs some
tweaks in the text
2017-07-22 10:22:42 chinmoy[m] yup the message are only for temporary
basis
2017-07-22 10:23:50 eangok
2017-07-22 10:24:56 eangwhat about the plans for undo that you
mentioned yesterday?
2017-07-22 10:27:24 chinmoy[m] undojob basically uses KIO::simplejob
for all it undoing. so most sensible and easiest solution is to use copyjob
2017-07-22 10:28:22 chinmoy[m] actually i haven't added privilege
execution support to simplejob as most of them don't support job flags
2017-07-22 10:29:35 chinmoy[m] that's undoing isn't working. had it
been copyjob it would have worked straight away like knewfilemenu
2017-07-22 10:31:10 eangI see
2017-07-22 10:32:20 eangthat's all from my side, I think
2017-07-22 10:32:29 eanglooking forward to the patches on phab
2017-07-22 10:33:47 chinmoy[m] one thing, is there any option for
adding a diff to task or do i only have to mention the task
2017-07-22 10:34:37 eangfrom the diff: Edit Related Objects -> Edit
Tasks ?
2017-07-22 10:35:54 chinmoy[m] i see. so thats there function. never
tried it that's why i asked
2017-07-22 10:36:07 chinmoy[m] so meeting over then?
2017-07-22 10:36:26 eangyes :)
Minutes GSoC meeting
Present: me, chinmoy Minutes in the attachment. Cheers, Elvis2017-08-06 14:59:49 eangI'm finally here, shall we start the meeting? 2017-08-06 15:00:07 chinmoy[m] eang, i am here 2017-08-06 15:03:58 eangchinmoy: let's start! 2017-08-06 15:04:41 chinmoy[m] ok 2017-08-06 15:07:01 chinmoy[m] I spent this week figuring out the suitable permissions when creating files and folders 2017-08-06 15:07:57 chinmoy[m] some of the operations were not working due to incorrect permissions and ownership 2017-08-06 15:09:57 chinmoy[m] Then i did some experiments by adding a new KIO job to serve as parent when jobs are executed in loop 2017-08-06 15:11:16 chinmoy[m] AFAICS only dolphin seems to require this. There is a work around forFileUndoManager 2017-08-06 15:11:41 chinmoy[m] and i cant find any other use case where this new job might be needed 2017-08-06 15:12:09 eangcan you show me where is this dolphin code? 2017-08-06 15:12:40 chinmoy[m] views/renamedialog.cpp ::renameItem() 2017-08-06 15:14:13 eangso there is a KIO::moveAs() in a loop, basically 2017-08-06 15:14:24 chinmoy[m] yes 2017-08-06 15:15:25 eangthis also causes https://bugs.kde.org/show_bug.cgi?id=364615 2017-08-06 15:15:27 sKreamerKDE bug 364615 in dolphin (general) "after mass rename, ctrl+z (undo) should revert ALL folders/files names" [normal,] https://bugs.kde.org/show_bug.cgi?id=364615 2017-08-06 15:17:04 eangand also https://bugs.kde.org/show_bug.cgi?id=381483 2017-08-06 15:17:04 sKreamerKDE bug 381483 in dolphin (general) "Dolphin hangs on mass rename" [normal,] https://bugs.kde.org/show_bug.cgi?id=381483 2017-08-06 15:18:00 eangso, renaming in dolphin is messy 2017-08-06 15:18:28 chinmoy[m] so my new job isn't necessary 2017-08-06 15:19:02 chinmoy[m] from the bugs it seems a new method is required in copyjob 2017-08-06 15:19:52 eangwe may need dfaure's input for this 2017-08-06 15:20:39 chinmoy[m] yes. as a temporary solution we can disable the rename option when multiple files are selected 2017-08-06 15:23:28 eangthere is a KIO::move() that takes a list of urls 2017-08-06 15:23:41 eangcan you try to seee if we can use that? 2017-08-06 15:24:06 chinmoy[m] it takes multiple source urls and one dest url 2017-08-06 15:24:31 eangah, right 2017-08-06 15:28:38 eangok, let's postpone the rename issue and move on 2017-08-06 15:29:15 chinmoy[m] on surface it seems straightforward and easy to fix 2017-08-06 15:31:08 chinmoy[m] but then its dinner time and i might be wrong 2017-08-06 15:32:09 chinmoy[m] apart from these issues, I fixed my existing patches. 2017-08-06 15:32:29 eangis the permission issue sorted out? 2017-08-06 15:33:38 chinmoy[m] yes. I wasn't serializing the path of file thats why the warning 2017-08-06 15:33:51 chinmoy[m] in place of path i was passing the permission 2017-08-06 15:34:53 chinmoy[m] this typo costed me a whole day 2017-08-06 15:35:31 eangeheh, happens all the time :) 2017-08-06 15:36:20 eangwhat's the status of unit tests? are they ready? 2017-08-06 15:37:43 chinmoy[m] nope. can't get my head around them. 2017-08-06 15:38:15 chinmoy[m] not that I dont understand the qt test, its just the part of code to test 2017-08-06 15:39:15 chinmoy[m] what will you suggest, testing every job with the new flag or just run a random job and check the metadata returned by slave? 2017-08-06 15:41:45 eangthe former is a good integration test, but I'm not sure how to handle the authentication dialog 2017-08-06 15:41:56 eangthe latter is a sort of white test that could be also good 2017-08-06 15:41:59 chinmoy[m] we dont need to 2017-08-06 15:42:11 chinmoy[m] handle the auth dialog 2017-08-06 15:42:49 chinmoy[m] checking for validity of the kauth action is also fine 2017-08-06 15:43:43 --> pursuivant (pursuivant@kde/bot/commit-notifications) has joined #kde-fm 2017-08-06 15:43:43 pursuivant baloo (master) v5.9.0-763-g16f12765 * l10n daemon script: CMakeLists.txt 2017-08-06 15:43:44 pursuivant GIT_SILENT Upgrade Qt5 version requirement to 5.7.0. 2017-08-06 15:43:44 pursuivant https://commits.kde.org/baloo/16f1276572704aebd12df0393aad01a6978b38f2 2017-08-06 15:44:07 eangthen yes, I'd at least test the most important jobs (e.g. CopyJob) 2017-08-06 15:45:25 chinmoy[m] ok, this makes more sense 2017-08-06 15:47:09 chinmoy[m] it may need some rearranging in execWithElevatePrivilege method as the code for unit test is after the signal for warning dialog 2017-08-06 15:49:21 eangok, anything else you wanted to discuss? 2017-08-06 15:49:48 chinmoy[m] no 2017-08-06 15:5
Minutes GSoC meeting
Present: me, chinmoy, shortstheory
Minutes in the attachment.
Cheers,
Elvis[Saturday, 12 August 2017] [12:01:15 CEST] Meeting!
[Saturday, 12 August 2017] [12:01:28 CEST] Hey
[Saturday, 12 August 2017] [12:02:14 CEST] chinmoy: ?
[Saturday, 12 August 2017] [12:11:22 CEST] eang: i am here
[Saturday, 12 August 2017] [12:11:43 CEST] we can start then
[Saturday, 12 August 2017] [12:13:06 CEST] This week I finished my
work on KIO side
[Saturday, 12 August 2017] [12:13:49 CEST] Well the unit test are
not complete yet
[Saturday, 12 August 2017] [12:14:22 CEST] apart from that undo,
DnD, and rest of the file operatioons are working fine
[Saturday, 12 August 2017] [12:15:48 CEST] Today I will put all
the KIO related patches up for review
[Saturday, 12 August 2017] [12:16:22 CEST] I think we can talk
about dolphin's side now
[Saturday, 12 August 2017] [12:17:55 CEST] cool!
[Saturday, 12 August 2017] [12:19:36 CEST] you mentioned a new setting
in D7270, what's that for?
[Saturday, 12 August 2017] [12:19:37 CEST] Diff 7270
"[FileUndoManager] Enable undoing changes in read-only folders" [Needs Review]
https://phabricator.kde.org/D7270
[Saturday, 12 August 2017] [12:20:32 CEST] I was thinking of a
toggle button in dolphin's setting for enabling or disabling undo
[Saturday, 12 August 2017] [12:21:21 CEST] why would I want to disable
undo?
[Saturday, 12 August 2017] [12:22:47 CEST] its disabling undo in
read-only directory :)
[Saturday, 12 August 2017] [12:23:06 CEST] some user might want
the changes to be permanent
[Saturday, 12 August 2017] [12:25:16 CEST] Don't
think disabling makes much sense
[Saturday, 12 August 2017] [12:27:27 CEST] so it should be always
enabled then ?
[Saturday, 12 August 2017] [12:28:26 CEST] I haven't tested it yet, what
happens when I undo in a RO folder? Do I get the usual permission warning
dialog?
[Saturday, 12 August 2017] [12:28:37 CEST] yes
[Saturday, 12 August 2017] [12:33:55 CEST] the problem with settings is
that they clutter the UI, there should be a really good reason for adding a new
one
[Saturday, 12 August 2017] [12:34:20 CEST] ok i will remove it then
[Saturday, 12 August 2017] [12:34:24 CEST] also, it would be hard to
explain that it only affects the polkit case
[Saturday, 12 August 2017] [12:35:04 CEST] Yeah
that too
[Saturday, 12 August 2017] [12:35:07 CEST] since we get the warning
dialog, that's enough imho
[Saturday, 12 August 2017] [12:35:25 CEST] if I don't want to undo, I
can just abort the job
[Saturday, 12 August 2017] [12:35:36 CEST] actually i was planing
something similar for drag and drop
[Saturday, 12 August 2017] [12:01:36 CEST] It's
important to have this project 100% for release. Dfaure was telling me that a
lot of gsoc projects don't get shipped because they're only 80% there most of
the time
[Saturday, 12 August 2017] [12:01:36 CEST] Though
he did say he was quite optimistic about this one
[Saturday, 12 August 2017] [12:01:37 CEST] in drop job theere is a
check for write permission. Depending on which drop menu is created. Shall I
remove that check?
[Saturday, 12 August 2017] [12:41:00 CEST] you mean the if
(!KProtocolManager::supportsWriting(m_destUrl)) check?
[Saturday, 12 August 2017] [12:41:20 CEST] no below that
[Saturday, 12 August 2017] [12:41:44 CEST] right. I think so
[Saturday, 12 August 2017] [12:42:13 CEST] on second thought
adding check for PrivilegeExecution flag should do the job.
[Saturday, 12 August 2017] [12:42:18 CEST] even though... this possibly
breaks non-dolphin clients?
[Saturday, 12 August 2017] [12:42:56 CEST] I was thinking of this
[Saturday, 12 August 2017] [12:42:57 CEST] if
(!m_destItem.isNull() && !m_destItem.isWritable() && !(m_flags &
KIO::PrivilegeExecution)) {
[Saturday, 12 August 2017] [12:42:58 CEST] return
KIO::ERR_WRITE_ACCESS_DENIED;
[Saturday, 12 August 2017] [12:42:59 CEST] }
[Saturday, 12 August 2017] [12:43:36 CEST] yep, this looks better
[Saturday, 12 August 2017] [12:44:45 CEST] Yea
[Saturday, 12 August 2017] [12:46:28 CEST] all right, so drops
operations are still WIP?
[Saturday, 12 August 2017] [12:48:08 CEST] Its finished
[Saturday, 12 August 2017] [12:48:28 CEST] I have just pushed all
the changes to master
[Saturday, 12 August 2017] [12:48:36 CEST] check it out
[Saturday, 12 August 2017] [12:48:39 CEST] ok great
[Saturday, 12 August 2017] [12:48:58 CEST] so, what's missing from the
dolphin side?
[Saturday, 12 August 2017] [12:50:50 CEST] a setting to toggle
privilege execution, mass renaming as root, notification for user that they are
in read-only dir and privilege execution is available
[Saturday, 12 August 2017] [12:52:31 CEST] again, not sure we really
need a setting for that
[Saturday, 12 August 2017] [12:53:11 CEST] +1 for notifying though
[Saturday, 12 August 2017] [12:56:35 CEST] use this dolphin patch
https://paste.kde.org/pw4aotqra
[Saturday, 12 August 2017] [12:57:42 CEST] sorry, lunch is ready, bb
Minutes GSoC meeting
Present: me, chinmoy, shortstheory
Minutes in the attachment.
Cheers,
Elvis2017-08-20 09:01:22 eangMeeting!
2017-08-20 09:01:27 chinmoy[m] yes
2017-08-20 09:02:11 eanglet's start then
2017-08-20 09:03:44 chinmoy[m] Didn't do much this week due to college
:(
2017-08-20 09:04:14 chinmoy[m] Mostly fixed the issues in my diffs
2017-08-20 09:04:51 chinmoy[m] And got my fd sharing code reveiwed
2017-08-20 09:05:38 chinmoy[m] here I posted my code for review
https://codereview.stackexchange.com/questions/173306/sharing-file-descriptor-between-an-under-privileged-and-a-privileged-process-us
2017-08-20 09:06:19 chinmoy[m] eang have a look and tell me if you
want to add something
2017-08-20 09:07:15 IrcsomeBot yup
2017-08-20 09:09:26 eanggood idea, the more eyes on it, the better
2017-08-20 09:10:00 chinmoy[m] that's what i thought
2017-08-20 09:11:20 eangchinmoy: have you seen
https://phabricator.kde.org/T6561#106742 ?
2017-08-20 09:11:21 sKreamerTask 6561 "Polkit support in KIO"
[Open,High] {Frameworks} https://phabricator.kde.org/T6561
2017-08-20 09:11:35 eangcan you confirm that PrivilegeExecution will be
a no-op on windows?
2017-08-20 09:12:04 chinmoy[m] it will be
2017-08-20 09:12:59 chinmoy[m] execWithElevatedPrivilege will be
called in windows as well but it will return false there
2017-08-20 09:13:27 eangok that's good
2017-08-20 09:17:43 eangchinmoy: I have a question, after I upgraded to
KF5.37 and rebuilt your kio fork, kio_file dies
2017-08-20 09:17:58 eangQ_ASSERT(d->appConnection.inited()); in
slavebase.cpp:283
2017-08-20 09:18:12 eanghave you ever seen this?
2017-08-20 09:18:38 chinmoy[m] I have but not recently
2017-08-20 09:18:47 chinmoy[m] I mean four weeks back
2017-08-20 09:20:53 chinmoy[m] I will look into it.
2017-08-20 09:22:19 eangok thanks, weird error
2017-08-20 09:22:39 chinmoy[m] I have prepared some unit tests: D7430.
can you tell me if I am doing anything wrong?
2017-08-20 09:22:40 sKreamerDiff 7430 "Add unit test" [Needs
Review] https://phabricator.kde.org/D7430
2017-08-20 09:26:46 eanglooks good to me, you can put it on for review
2017-08-20 09:33:31 chinmoy[m] eang, I have nothing else to add.
2017-08-20 09:34:30 chinmoy[m] anything you want to say
2017-08-20 09:34:44 eangso, August 21 - 29, 2017 => Students Submit
Code and Evaluations
2017-08-20 09:35:05 eangremember that you need to update
https://community.kde.org/GSoC/2017/StatusReports/chinmoyrp
2017-08-20 09:35:30 chinmoy[m] sure.
2017-08-20 09:36:11 eangwhat's the status of the dolphin patch? will be
ready before the 29th?
2017-08-20 09:36:27 eangwe have one more meeting before the deadline
2017-08-20 09:38:16 chinmoy[m] I haven't had time to work on dolphin
patch yet
2017-08-20 09:43:26 chinmoy[m] judging from the work left It should
take one day or two days at most to complete the dolphin patch.
2017-08-20 09:43:41 chinmoy[m] only if we exclude mass rename
2017-08-20 09:45:50 eangok, so is one more meeting enough for you? we
could also re-schedule to have two
2017-08-20 09:46:09 chinmoy[m] one should do
2017-08-20 09:46:40 eangall right, so next meeting Saturday 26th
2017-08-20 09:46:47 chinmoy[m] ok
2017-08-20 09:46:57 eangthat's all from my side
2017-08-20 09:47:10 eangmeeting over!
2017-08-20 09:47:17 chinmoy[m] sure
Minutes GSoC meeting
Present: me, chinmoy, shortstheory Minutes in the attachment. Cheers, Elvis2017-08-26 08:59:26 eangMeeting! 2017-08-26 09:00:12 IrcsomeBot Sup 2017-08-26 09:00:28 chinmoy[m] here 2017-08-26 09:00:39 eanglet's start :) 2017-08-26 09:01:57 chinmoy[m] this week mostly polished the code and spent quite a lot of time on dolphin 2017-08-26 09:02:24 chinmoy[m] can't figure out what toi do with the code for read-only dir check 2017-08-26 09:03:00 chinmoy[m] I mean there's a lot of code that need to be removed 2017-08-26 09:03:24 eangyeah 2017-08-26 09:04:49 chinmoy[m] anyway from my side everything is done with the exception of two unit test and the status report page 2017-08-26 09:05:39 chinmoy[m] i will put my dolphin patch for review later tonight 2017-08-26 09:05:58 eangok 2017-08-26 09:07:06 chinmoy[m] as for the FD patch, i don't think thiago will be able to review it anytime soon 2017-08-26 09:08:52 eangabout that one, what's up with the std::strings? Is is because QString is more complex for a root process? 2017-08-26 09:10:08 chinmoy[m] well, thiago suggested to use avoid using qt for the root process 2017-08-26 09:10:37 eangok 2017-08-26 09:11:05 chinmoy[m] and what should i do with mass rename? 2017-08-26 09:15:49 eangHave you asked dfaure? 2017-08-26 09:16:07 chinmoy[m] nope 2017-08-26 09:19:23 eangI'd say ask him in the dolphin diff 2017-08-26 09:19:37 chinmoy[m] ok 2017-08-26 09:20:56 eangAnything else? 2017-08-26 09:21:20 chinmoy[m] i think no 2017-08-26 09:21:35 eangI'd like to see a final blog post 2017-08-26 09:21:56 eangand of course the wiki page 2017-08-26 09:24:39 chinmoy[m] yeah, a blog... 2017-08-26 09:25:51 chinmoy[m] any thoughts on adding a setting to dolphin? you said no but just reconsider it once 2017-08-26 09:26:16 chinmoy[m] it will be easier on my back 2017-08-26 09:27:34 eangI need to see the patch to evaluate 2017-08-26 09:28:29 eangso, just explain in the revision how the patch would become simpler if it had the new setting 2017-08-26 09:29:00 chinmoy[m] ok 2017-08-26 09:30:06 eangAny idea about that assert crash in kiofile? 2017-08-26 09:30:54 chinmoy[m] i can't reproduce that crash 2017-08-26 09:31:16 chinmoy[m] even after updating kio 2017-08-26 09:31:26 eangok 2017-08-26 09:31:39 eangmust be something on my setup 2017-08-26 09:33:54 chinmoy[m] i think i should rebuild kf5 on a fresh installation 2017-08-26 09:35:02 chinmoy[m] and see if that crash occurs 2017-08-26 09:35:13 eangThat's all from me 2017-08-26 09:35:31 chinmoy[m] nothing from me either 2017-08-26 09:35:46 eangdeadline is on 29th right? 2017-08-26 09:36:01 chinmoy[m] yes 2017-08-26 09:36:11 eangall right, meeting over then!
