Re: Review Request 115388: Remove unused dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115388/ --- (Updated Jan. 30, 2014, 2:44 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Marco Martin. Repository: kdeclarative Description --- QtScript is not used. QtGui is actually used rather than QtWidgets. Diffs - CMakeLists.txt 536f7f33ca6ac25fc87966bf2bb4e2fc248c37fd src/kdeclarative.h 84f313302c70f9161ab2244c735166e08947f252 Diff: https://git.reviewboard.kde.org/r/115388/diff/ Testing --- Builds. Didn't find any reference to QtScript or QtWidgets when inspecting source. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115388: Remove unused dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115388/#review48619 --- This review has been submitted with commit 4c4ee1e843b06a769f3367d47037e33a45d8908b by Michael Palimaka to branch master. - Commit Hook On Jan. 29, 2014, 5:06 p.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115388/ > --- > > (Updated Jan. 29, 2014, 5:06 p.m.) > > > Review request for KDE Frameworks and Marco Martin. > > > Repository: kdeclarative > > > Description > --- > > QtScript is not used. QtGui is actually used rather than QtWidgets. > > > Diffs > - > > CMakeLists.txt 536f7f33ca6ac25fc87966bf2bb4e2fc248c37fd > src/kdeclarative.h 84f313302c70f9161ab2244c735166e08947f252 > > Diff: https://git.reviewboard.kde.org/r/115388/diff/ > > > Testing > --- > > Builds. Didn't find any reference to QtScript or QtWidgets when inspecting > source. > > > Thanks, > > Michael Palimaka > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115388: Remove unused dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115388/#review48607 --- Ship it! Looks good to me. - Aurélien Gâteau On Jan. 29, 2014, 6:06 p.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115388/ > --- > > (Updated Jan. 29, 2014, 6:06 p.m.) > > > Review request for KDE Frameworks and Marco Martin. > > > Repository: kdeclarative > > > Description > --- > > QtScript is not used. QtGui is actually used rather than QtWidgets. > > > Diffs > - > > CMakeLists.txt 536f7f33ca6ac25fc87966bf2bb4e2fc248c37fd > src/kdeclarative.h 84f313302c70f9161ab2244c735166e08947f252 > > Diff: https://git.reviewboard.kde.org/r/115388/diff/ > > > Testing > --- > > Builds. Didn't find any reference to QtScript or QtWidgets when inspecting > source. > > > Thanks, > > Michael Palimaka > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
