Re: Review Request 124121: KPlotWidget: add setAutoDeletePlotObjects, fix memory leak in replacePlotObject
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124121/ --- (Updated June 30, 2015, 12:45 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Feck. Changes --- Submitted with commit b776f35911f54ad9264f14ce5e1a5ec124703b37 by David Faure to branch master. Repository: kplotting Description --- REVIEW: 124121 Diffs - src/kplotwidget.h e5b3e16b31d6d34b7c544df42531f2f91105830d src/kplotwidget.cpp 8dcc4ecef798a53376dd8cc4a0a6e6c1804db593 Diff: https://git.reviewboard.kde.org/r/124121/diff/ Testing --- (Not trivial to unittest because KPlotObject is not a QObject.) Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124121: KPlotWidget: add setAutoDeletePlotObjects, fix memory leak in replacePlotObject
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124121/ --- (Updated June 19, 2015, 10:20 a.m.) Review request for KDE Frameworks and Christoph Feck. Changes --- + docu Repository: kplotting Description (updated) --- REVIEW: 124121 Diffs (updated) - src/kplotwidget.h e5b3e16b31d6d34b7c544df42531f2f91105830d src/kplotwidget.cpp 8dcc4ecef798a53376dd8cc4a0a6e6c1804db593 Diff: https://git.reviewboard.kde.org/r/124121/diff/ Testing --- (Not trivial to unittest because KPlotObject is not a QObject.) Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124121: KPlotWidget: add setAutoDeletePlotObjects, fix memory leak in replacePlotObject
On June 18, 2015, 5:56 p.m., David Edmundson wrote: src/kplotwidget.h, line 190 https://git.reviewboard.kde.org/r/124121/diff/1/?file=380403#file380403line190 might be good to explain that KPlotWidget will take ownership (unless set otherwise) Hehe, yeah, I added that then I removed it, the class documentation mentionning this already. But I agree, I'll add it here again and mention setAutoDelete in both places. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124121/#review81558 --- On June 18, 2015, 9:59 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124121/ --- (Updated June 18, 2015, 9:59 a.m.) Review request for KDE Frameworks and Christoph Feck. Repository: kplotting Description --- KPlotWidget: add setAutoDeletePlotObjects, fix memory leak in replacePlotObject Diffs - src/kplotwidget.h e5b3e16b31d6d34b7c544df42531f2f91105830d src/kplotwidget.cpp 8dcc4ecef798a53376dd8cc4a0a6e6c1804db593 Diff: https://git.reviewboard.kde.org/r/124121/diff/ Testing --- (Not trivial to unittest because KPlotObject is not a QObject.) Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124121: KPlotWidget: add setAutoDeletePlotObjects, fix memory leak in replacePlotObject
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124121/#review81558 --- Ship it! src/kplotwidget.h (line 188) https://git.reviewboard.kde.org/r/124121/#comment55902 might be good to explain that KPlotWidget will take ownership (unless set otherwise) - David Edmundson On June 18, 2015, 9:59 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124121/ --- (Updated June 18, 2015, 9:59 a.m.) Review request for KDE Frameworks and Christoph Feck. Repository: kplotting Description --- KPlotWidget: add setAutoDeletePlotObjects, fix memory leak in replacePlotObject Diffs - src/kplotwidget.h e5b3e16b31d6d34b7c544df42531f2f91105830d src/kplotwidget.cpp 8dcc4ecef798a53376dd8cc4a0a6e6c1804db593 Diff: https://git.reviewboard.kde.org/r/124121/diff/ Testing --- (Not trivial to unittest because KPlotObject is not a QObject.) Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
