Re: Review Request 125905: Make kactivitymanagerd a QApplication
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125905/#review87792 --- So, we went a full circle back to QApplication :) What assert are you hitting on unity? - Ivan Čukić On Nov. 1, 2015, 1:33 a.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125905/ > --- > > (Updated Nov. 1, 2015, 1:33 a.m.) > > > Review request for KDE Frameworks, Martin Gräßlin and Ivan Čukić. > > > Repository: kactivities > > > Description > --- > > KWindowSystem is QWidget based so needs QApplication or asserts in some > situations (when run on unity7 for example) > > > Diffs > - > > src/service/Application.h 387d4d7 > src/service/Application.cpp ec74daa > > Diff: https://git.reviewboard.kde.org/r/125905/diff/ > > > Testing > --- > > > Thanks, > > Albert Astals Cid > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125905: Make kactivitymanagerd a QApplication
> On nov. 1, 2015, 11:49 a.m., Ivan Čukić wrote: > > So, we went a full circle back to QApplication :) > > > > What assert are you hitting on unity? KWindowSystem uses QApplication::desktopWidget which you can't if you're not a QApplication - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125905/#review87792 --- On nov. 1, 2015, 1:33 a.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125905/ > --- > > (Updated nov. 1, 2015, 1:33 a.m.) > > > Review request for KDE Frameworks, Martin Gräßlin and Ivan Čukić. > > > Repository: kactivities > > > Description > --- > > KWindowSystem is QWidget based so needs QApplication or asserts in some > situations (when run on unity7 for example) > > > Diffs > - > > src/service/Application.h 387d4d7 > src/service/Application.cpp ec74daa > > Diff: https://git.reviewboard.kde.org/r/125905/diff/ > > > Testing > --- > > > Thanks, > > Albert Astals Cid > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125905: Make kactivitymanagerd a QApplication
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125905/#review87825 --- I've made https://git.reviewboard.kde.org/r/125915/ - David Edmundson On Nov. 1, 2015, 1:33 a.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125905/ > --- > > (Updated Nov. 1, 2015, 1:33 a.m.) > > > Review request for KDE Frameworks, Martin Gräßlin and Ivan Čukić. > > > Repository: kactivities > > > Description > --- > > KWindowSystem is QWidget based so needs QApplication or asserts in some > situations (when run on unity7 for example) > > > Diffs > - > > src/service/Application.h 387d4d7 > src/service/Application.cpp ec74daa > > Diff: https://git.reviewboard.kde.org/r/125905/diff/ > > > Testing > --- > > > Thanks, > > Albert Astals Cid > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125905: Make kactivitymanagerd a QApplication
> On Nov. 1, 2015, 11:35 p.m., David Edmundson wrote: > > I've made https://git.reviewboard.kde.org/r/125915/ back referencing my comment to that review: I think trying to change KWindowSystem to not use desktopWidget doesn't solve the problem. KWindowSystem is a QWidget based framework. Thus it requires a QApplication. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125905/#review87825 --- On Nov. 1, 2015, 2:33 a.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125905/ > --- > > (Updated Nov. 1, 2015, 2:33 a.m.) > > > Review request for KDE Frameworks, Martin Gräßlin and Ivan Čukić. > > > Repository: kactivities > > > Description > --- > > KWindowSystem is QWidget based so needs QApplication or asserts in some > situations (when run on unity7 for example) > > > Diffs > - > > src/service/Application.h 387d4d7 > src/service/Application.cpp ec74daa > > Diff: https://git.reviewboard.kde.org/r/125905/diff/ > > > Testing > --- > > > Thanks, > > Albert Astals Cid > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125905: Make kactivitymanagerd a QApplication
> On Nov. 1, 2015, 12:49 p.m., Ivan Čukić wrote: > > So, we went a full circle back to QApplication :) > > > > What assert are you hitting on unity? > > Albert Astals Cid wrote: > KWindowSystem uses QApplication::desktopWidget which you can't if you're > not a QApplication > What assert are you hitting on unity? The reason for this is that Compiz in opposite to KWin does virtual desktops through viewports. The code paths with the desktopWidget are the fallback code paths for viewport handling. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125905/#review87792 --- On Nov. 1, 2015, 2:33 a.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125905/ > --- > > (Updated Nov. 1, 2015, 2:33 a.m.) > > > Review request for KDE Frameworks, Martin Gräßlin and Ivan Čukić. > > > Repository: kactivities > > > Description > --- > > KWindowSystem is QWidget based so needs QApplication or asserts in some > situations (when run on unity7 for example) > > > Diffs > - > > src/service/Application.h 387d4d7 > src/service/Application.cpp ec74daa > > Diff: https://git.reviewboard.kde.org/r/125905/diff/ > > > Testing > --- > > > Thanks, > > Albert Astals Cid > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125905: Make kactivitymanagerd a QApplication
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125905/#review87946 --- Ship it! Ship It! - Ivan Čukić On Nov. 1, 2015, 1:33 a.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125905/ > --- > > (Updated Nov. 1, 2015, 1:33 a.m.) > > > Review request for KDE Frameworks, Martin Gräßlin and Ivan Čukić. > > > Repository: kactivities > > > Description > --- > > KWindowSystem is QWidget based so needs QApplication or asserts in some > situations (when run on unity7 for example) > > > Diffs > - > > src/service/Application.h 387d4d7 > src/service/Application.cpp ec74daa > > Diff: https://git.reviewboard.kde.org/r/125905/diff/ > > > Testing > --- > > > Thanks, > > Albert Astals Cid > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125905: Make kactivitymanagerd a QApplication
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125905/ --- (Updated Nov. 3, 2015, 7:12 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Martin Gräßlin and Ivan Čukić. Changes --- Submitted with commit 8316370e021ff14c54dea4632ec7548253d731b4 by Albert Astals Cid to branch master. Repository: kactivities Description --- KWindowSystem is QWidget based so needs QApplication or asserts in some situations (when run on unity7 for example) Diffs - src/service/Application.h 387d4d7 src/service/Application.cpp ec74daa Diff: https://git.reviewboard.kde.org/r/125905/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
