Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129361/
---

(Updated Nov. 9, 2016, 10:36 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter.


Changes
---

Submitted with commit 97876c1d152f7d0ea0e5adcfe88abeab4e7117c9 by Albert Astals 
Cid to branch master.


Repository: kpty


Description
---

Read the summary


Diffs
-

  cmake/FindUTEMPTER.cmake d3236c8 

Diff: https://git.reviewboard.kde.org/r/129361/diff/


Testing
---

Works


Thanks,

Albert Astals Cid

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

[Allen Winter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129361/#review100729
---



Doesn't help me on Fedora 24 though (yes, I know this is about Ubuntu)

On Fedora24 I have /usr/libexec/utempter/utempter except it isn't readable by 
the average user.

$ file /usr/libexec/utempter/utempter
/usr/libexec/utempter/utempter: setgid executable, regular file, no read 
permission


I think the non-privildged user should be able to build kpty.

- Allen Winter


On Nov. 7, 2016, 11:02 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129361/
> ---
> 
> (Updated Nov. 7, 2016, 11:02 p.m.)
> 
> 
> Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> Read the summary
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake d3236c8 
> 
> Diff: https://git.reviewboard.kde.org/r/129361/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129361/#review100717
---


Ship it!




Ship It!

- Jonathan Riddell


On Nov. 7, 2016, 11:02 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129361/
> ---
> 
> (Updated Nov. 7, 2016, 11:02 p.m.)
> 
> 
> Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> Read the summary
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake d3236c8 
> 
> Diff: https://git.reviewboard.kde.org/r/129361/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

[Jonathan Riddell]

> On Nov. 8, 2016, 11:33 a.m., Jonathan Riddell wrote:
> > On my system (ubuntu 16.04 base) this is achieved by 
> > ${KDE_INSTALL_FULL_LIBDIR}/utempter
> > What's changed in 16.10 that alters this?
> 
> Albert Astals Cid wrote:
> That only works under the bogus assumption that one will install KDE 
> (what does "installing KDE" mean in a frameworks world anyway) to the same 
> place you have installed utempter, which is clearly not the case for me ( 
> i.e. ${KDE_INSTALL_FULL_LIBDIR} is 
> /home/tsdgeos/kde_stuff/instalado/lib/x86_64-linux-gnu )

true enough


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129361/#review100710
---


On Nov. 7, 2016, 11:02 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129361/
> ---
> 
> (Updated Nov. 7, 2016, 11:02 p.m.)
> 
> 
> Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> Read the summary
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake d3236c8 
> 
> Diff: https://git.reviewboard.kde.org/r/129361/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

[Albert Astals Cid]

> On Nov. 8, 2016, 11:57 a.m., Anthony Fieroni wrote:
> > cmake/FindUTEMPTER.cmake, line 43
> > 
> >
> > I think we shouldn't search in fixed path i.e. /usr/...
> > ${CMAKE_PREFIX_PATH}/lib/${CMAKE_LIBRARY_ARCHITECTURE}/utempter
> > So "patch" like above one is error prone

So how do you suggest we fix the fact that the utempter library is not found 
for me?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129361/#review100712
---


On Nov. 7, 2016, 11:02 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129361/
> ---
> 
> (Updated Nov. 7, 2016, 11:02 p.m.)
> 
> 
> Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> Read the summary
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake d3236c8 
> 
> Diff: https://git.reviewboard.kde.org/r/129361/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

[Albert Astals Cid]

> On Nov. 8, 2016, 11:33 a.m., Jonathan Riddell wrote:
> > On my system (ubuntu 16.04 base) this is achieved by 
> > ${KDE_INSTALL_FULL_LIBDIR}/utempter
> > What's changed in 16.10 that alters this?

That only works under the bogus assumption that one will install KDE (what does 
"installing KDE" mean in a frameworks world anyway) to the same place you have 
installed utempter, which is clearly not the case for me ( i.e. 
${KDE_INSTALL_FULL_LIBDIR} is 
/home/tsdgeos/kde_stuff/instalado/lib/x86_64-linux-gnu )


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129361/#review100710
---


On Nov. 7, 2016, 11:02 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129361/
> ---
> 
> (Updated Nov. 7, 2016, 11:02 p.m.)
> 
> 
> Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> Read the summary
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake d3236c8 
> 
> Diff: https://git.reviewboard.kde.org/r/129361/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129361/#review100712
---




cmake/FindUTEMPTER.cmake (line 43)


I think we shouldn't search in fixed path i.e. /usr/...
${CMAKE_PREFIX_PATH}/lib/${CMAKE_LIBRARY_ARCHITECTURE}/utempter
So "patch" like above one is error prone


- Anthony Fieroni


On Nov. 8, 2016, 1:02 a.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129361/
> ---
> 
> (Updated Nov. 8, 2016, 1:02 a.m.)
> 
> 
> Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> Read the summary
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake d3236c8 
> 
> Diff: https://git.reviewboard.kde.org/r/129361/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129361/#review100710
---



On my system (ubuntu 16.04 base) this is achieved by 
${KDE_INSTALL_FULL_LIBDIR}/utempter
What's changed in 16.10 that alters this?

- Jonathan Riddell


On Nov. 7, 2016, 11:02 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129361/
> ---
> 
> (Updated Nov. 7, 2016, 11:02 p.m.)
> 
> 
> Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> Read the summary
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake d3236c8 
> 
> Diff: https://git.reviewboard.kde.org/r/129361/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>