Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-21 Thread Àlex Fiestas 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/
---

(Updated Oct. 21, 2013, 2:09 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Moved KBuildsyscoca to KService.

I have done the moving and the cleaning in different commits, just unified them 
for reviewboard.


Diffs
-

  kded/CMakeLists.txt 3aba077 
  kded/applications.menu  
  kded/kbuildmimetypefactory.h  
  kded/kbuildmimetypefactory.cpp 2e81ce7 
  kded/kbuildservicefactory.h  
  kded/kbuildservicefactory.cpp 971f327 
  kded/kbuildservicegroupfactory.h  
  kded/kbuildservicegroupfactory.cpp 5485b1c 
  kded/kbuildservicetypefactory.h  
  kded/kbuildservicetypefactory.cpp f473cd6 
  kded/kbuildsycoca.h  
  kded/kbuildsycoca.cpp 8ea2d2e 
  kded/kbuildsycocainterface.h  
  kded/kctimefactory.h  
  kded/kctimefactory.cpp  
  kded/kmimeassociations.h  
  kded/kmimeassociations.cpp  
  kded/ksycocaresourcelist.h  
  kded/tests/CMakeLists.txt da51ed4 
  kded/tests/kmimeassociationstest.cpp  
  kded/vfolder_menu.h  
  kded/vfolder_menu.cpp  
  staging/kservice/CMakeLists.txt 4e8dbd2 
  staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
  staging/kservice/tests/CMakeLists.txt 23d4854 

Diff: http://git.reviewboard.kde.org/r/113148/diff/


Testing
---


Thanks,

Àlex Fiestas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-21 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/#review42095
---


This review has been submitted with commit 
4c47af4414c11a8fb0d5dc0a5750eda024e88feb by Àlex Fiestas to branch frameworks.

- Commit Hook


On Oct. 21, 2013, 10:22 a.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113148/
> ---
> 
> (Updated Oct. 21, 2013, 10:22 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Moved KBuildsyscoca to KService.
> 
> I have done the moving and the cleaning in different commits, just unified 
> them for reviewboard.
> 
> 
> Diffs
> -
> 
>   kded/CMakeLists.txt 3aba077 
>   kded/applications.menu  
>   kded/kbuildmimetypefactory.h  
>   kded/kbuildmimetypefactory.cpp 2e81ce7 
>   kded/kbuildservicefactory.h  
>   kded/kbuildservicefactory.cpp 971f327 
>   kded/kbuildservicegroupfactory.h  
>   kded/kbuildservicegroupfactory.cpp 5485b1c 
>   kded/kbuildservicetypefactory.h  
>   kded/kbuildservicetypefactory.cpp f473cd6 
>   kded/kbuildsycoca.h  
>   kded/kbuildsycoca.cpp 8ea2d2e 
>   kded/kbuildsycocainterface.h  
>   kded/kctimefactory.h  
>   kded/kctimefactory.cpp  
>   kded/kmimeassociations.h  
>   kded/kmimeassociations.cpp  
>   kded/ksycocaresourcelist.h  
>   kded/tests/CMakeLists.txt da51ed4 
>   kded/tests/kmimeassociationstest.cpp  
>   kded/vfolder_menu.h  
>   kded/vfolder_menu.cpp  
>   staging/kservice/CMakeLists.txt 4e8dbd2 
>   staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
>   staging/kservice/tests/CMakeLists.txt 23d4854 
> 
> Diff: http://git.reviewboard.kde.org/r/113148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-21 Thread Kevin Ottens 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/#review42083
---

Ship it!


Ship It!

- Kevin Ottens


On Oct. 21, 2013, 10:22 a.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113148/
> ---
> 
> (Updated Oct. 21, 2013, 10:22 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Moved KBuildsyscoca to KService.
> 
> I have done the moving and the cleaning in different commits, just unified 
> them for reviewboard.
> 
> 
> Diffs
> -
> 
>   kded/CMakeLists.txt 3aba077 
>   kded/applications.menu  
>   kded/kbuildmimetypefactory.h  
>   kded/kbuildmimetypefactory.cpp 2e81ce7 
>   kded/kbuildservicefactory.h  
>   kded/kbuildservicefactory.cpp 971f327 
>   kded/kbuildservicegroupfactory.h  
>   kded/kbuildservicegroupfactory.cpp 5485b1c 
>   kded/kbuildservicetypefactory.h  
>   kded/kbuildservicetypefactory.cpp f473cd6 
>   kded/kbuildsycoca.h  
>   kded/kbuildsycoca.cpp 8ea2d2e 
>   kded/kbuildsycocainterface.h  
>   kded/kctimefactory.h  
>   kded/kctimefactory.cpp  
>   kded/kmimeassociations.h  
>   kded/kmimeassociations.cpp  
>   kded/ksycocaresourcelist.h  
>   kded/tests/CMakeLists.txt da51ed4 
>   kded/tests/kmimeassociationstest.cpp  
>   kded/vfolder_menu.h  
>   kded/vfolder_menu.cpp  
>   staging/kservice/CMakeLists.txt 4e8dbd2 
>   staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
>   staging/kservice/tests/CMakeLists.txt 23d4854 
> 
> Diff: http://git.reviewboard.kde.org/r/113148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-21 Thread Àlex Fiestas 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/
---

(Updated Oct. 21, 2013, 10:22 a.m.)


Review request for KDE Frameworks.


Changes
---

Rebased the patch, fixed all issues and restored KCrash.


Repository: kdelibs


Description
---

Moved KBuildsyscoca to KService.

I have done the moving and the cleaning in different commits, just unified them 
for reviewboard.


Diffs (updated)
-

  kded/CMakeLists.txt 3aba077 
  kded/applications.menu  
  kded/kbuildmimetypefactory.h  
  kded/kbuildmimetypefactory.cpp 2e81ce7 
  kded/kbuildservicefactory.h  
  kded/kbuildservicefactory.cpp 971f327 
  kded/kbuildservicegroupfactory.h  
  kded/kbuildservicegroupfactory.cpp 5485b1c 
  kded/kbuildservicetypefactory.h  
  kded/kbuildservicetypefactory.cpp f473cd6 
  kded/kbuildsycoca.h  
  kded/kbuildsycoca.cpp 8ea2d2e 
  kded/kbuildsycocainterface.h  
  kded/kctimefactory.h  
  kded/kctimefactory.cpp  
  kded/kmimeassociations.h  
  kded/kmimeassociations.cpp  
  kded/ksycocaresourcelist.h  
  kded/tests/CMakeLists.txt da51ed4 
  kded/tests/kmimeassociationstest.cpp  
  kded/vfolder_menu.h  
  kded/vfolder_menu.cpp  
  staging/kservice/CMakeLists.txt 4e8dbd2 
  staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
  staging/kservice/tests/CMakeLists.txt 23d4854 

Diff: http://git.reviewboard.kde.org/r/113148/diff/


Testing
---


Thanks,

Àlex Fiestas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-14 Thread Àlex Fiestas 


> On Oct. 12, 2013, 4:57 p.m., David Faure wrote:
> > kded/kbuildsycoca.cpp, line 84
> > 
> >
> > Not called anymore with your commit.
> > 
> > But I'm not sure we want to remove the feature... what's the problem 
> > with keeping the kcrash dependency?

I don't have an opinion on this, if you want to keep it then we can keep it.

I removed it because it looked like we wanted to do it but we couldn't because 
of abi/api/behavior compatibility, now it is the time to break things so I 
removed it :p

For what is worth I think that we could replace some of KSCrash functionality 
with systemd-coredump but I don't know exactly how either of them work so...


- Àlex


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/#review41603
---


On Oct. 10, 2013, 10:04 a.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113148/
> ---
> 
> (Updated Oct. 10, 2013, 10:04 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Moved KBuildsyscoca to KService.
> 
> I have done the moving and the cleaning in different commits, just unified 
> them for reviewboard.
> 
> 
> Diffs
> -
> 
>   kded/CMakeLists.txt 4f9133f 
>   kded/applications.menu  
>   kded/kbuildmimetypefactory.h  
>   kded/kbuildmimetypefactory.cpp 2e81ce7 
>   kded/kbuildservicefactory.h  
>   kded/kbuildservicefactory.cpp 971f327 
>   kded/kbuildservicegroupfactory.h  
>   kded/kbuildservicegroupfactory.cpp 5485b1c 
>   kded/kbuildservicetypefactory.h  
>   kded/kbuildservicetypefactory.cpp f473cd6 
>   kded/kbuildsycoca.h  
>   kded/kbuildsycoca.cpp 8ea2d2e 
>   kded/kbuildsycocainterface.h  
>   kded/kctimefactory.h  
>   kded/kctimefactory.cpp  
>   kded/kmimeassociations.h  
>   kded/kmimeassociations.cpp  
>   kded/ksycocaresourcelist.h  
>   kded/tests/CMakeLists.txt ca392d2 
>   kded/tests/kmimeassociationstest.cpp  
>   kded/vfolder_menu.h  
>   kded/vfolder_menu.cpp  
>   staging/kservice/CMakeLists.txt b244731 
>   staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
>   staging/kservice/tests/CMakeLists.txt 23d4854 
> 
> Diff: http://git.reviewboard.kde.org/r/113148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-13 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/#review41661
---



kded/kbuildsycoca.cpp


I would keep it (the kcrash dependency, not the #if of course).

The "bic feature reduction" was a very early attempt at cutting away deps; 
we do this much more cleanly in kf5 (kcrash doesn't bring all of kdeui anymore).



- David Faure


On Oct. 10, 2013, 10:04 a.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113148/
> ---
> 
> (Updated Oct. 10, 2013, 10:04 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Moved KBuildsyscoca to KService.
> 
> I have done the moving and the cleaning in different commits, just unified 
> them for reviewboard.
> 
> 
> Diffs
> -
> 
>   kded/CMakeLists.txt 4f9133f 
>   kded/applications.menu  
>   kded/kbuildmimetypefactory.h  
>   kded/kbuildmimetypefactory.cpp 2e81ce7 
>   kded/kbuildservicefactory.h  
>   kded/kbuildservicefactory.cpp 971f327 
>   kded/kbuildservicegroupfactory.h  
>   kded/kbuildservicegroupfactory.cpp 5485b1c 
>   kded/kbuildservicetypefactory.h  
>   kded/kbuildservicetypefactory.cpp f473cd6 
>   kded/kbuildsycoca.h  
>   kded/kbuildsycoca.cpp 8ea2d2e 
>   kded/kbuildsycocainterface.h  
>   kded/kctimefactory.h  
>   kded/kctimefactory.cpp  
>   kded/kmimeassociations.h  
>   kded/kmimeassociations.cpp  
>   kded/ksycocaresourcelist.h  
>   kded/tests/CMakeLists.txt ca392d2 
>   kded/tests/kmimeassociationstest.cpp  
>   kded/vfolder_menu.h  
>   kded/vfolder_menu.cpp  
>   staging/kservice/CMakeLists.txt b244731 
>   staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
>   staging/kservice/tests/CMakeLists.txt 23d4854 
> 
> Diff: http://git.reviewboard.kde.org/r/113148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-12 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/#review41603
---



kded/kbuildsycoca.cpp


Not called anymore with your commit.

But I'm not sure we want to remove the feature... what's the problem with 
keeping the kcrash dependency?



staging/kservice/kbuildsycoca/CMakeLists.txt


remove the if(), whichever solution we choose


- David Faure


On Oct. 10, 2013, 10:04 a.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113148/
> ---
> 
> (Updated Oct. 10, 2013, 10:04 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Moved KBuildsyscoca to KService.
> 
> I have done the moving and the cleaning in different commits, just unified 
> them for reviewboard.
> 
> 
> Diffs
> -
> 
>   kded/CMakeLists.txt 4f9133f 
>   kded/applications.menu  
>   kded/kbuildmimetypefactory.h  
>   kded/kbuildmimetypefactory.cpp 2e81ce7 
>   kded/kbuildservicefactory.h  
>   kded/kbuildservicefactory.cpp 971f327 
>   kded/kbuildservicegroupfactory.h  
>   kded/kbuildservicegroupfactory.cpp 5485b1c 
>   kded/kbuildservicetypefactory.h  
>   kded/kbuildservicetypefactory.cpp f473cd6 
>   kded/kbuildsycoca.h  
>   kded/kbuildsycoca.cpp 8ea2d2e 
>   kded/kbuildsycocainterface.h  
>   kded/kctimefactory.h  
>   kded/kctimefactory.cpp  
>   kded/kmimeassociations.h  
>   kded/kmimeassociations.cpp  
>   kded/ksycocaresourcelist.h  
>   kded/tests/CMakeLists.txt ca392d2 
>   kded/tests/kmimeassociationstest.cpp  
>   kded/vfolder_menu.h  
>   kded/vfolder_menu.cpp  
>   staging/kservice/CMakeLists.txt b244731 
>   staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
>   staging/kservice/tests/CMakeLists.txt 23d4854 
> 
> Diff: http://git.reviewboard.kde.org/r/113148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-10 Thread Àlex Fiestas 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/
---

(Updated Oct. 10, 2013, 10:04 a.m.)


Review request for KDE Frameworks.


Changes
---

Nuked KCrash usage


Repository: kdelibs


Description
---

Moved KBuildsyscoca to KService.

I have done the moving and the cleaning in different commits, just unified them 
for reviewboard.


Diffs (updated)
-

  kded/CMakeLists.txt 4f9133f 
  kded/applications.menu  
  kded/kbuildmimetypefactory.h  
  kded/kbuildmimetypefactory.cpp 2e81ce7 
  kded/kbuildservicefactory.h  
  kded/kbuildservicefactory.cpp 971f327 
  kded/kbuildservicegroupfactory.h  
  kded/kbuildservicegroupfactory.cpp 5485b1c 
  kded/kbuildservicetypefactory.h  
  kded/kbuildservicetypefactory.cpp f473cd6 
  kded/kbuildsycoca.h  
  kded/kbuildsycoca.cpp 8ea2d2e 
  kded/kbuildsycocainterface.h  
  kded/kctimefactory.h  
  kded/kctimefactory.cpp  
  kded/kmimeassociations.h  
  kded/kmimeassociations.cpp  
  kded/ksycocaresourcelist.h  
  kded/tests/CMakeLists.txt ca392d2 
  kded/tests/kmimeassociationstest.cpp  
  kded/vfolder_menu.h  
  kded/vfolder_menu.cpp  
  staging/kservice/CMakeLists.txt b244731 
  staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
  staging/kservice/tests/CMakeLists.txt 23d4854 

Diff: http://git.reviewboard.kde.org/r/113148/diff/


Testing
---


Thanks,

Àlex Fiestas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-07 Thread Àlex Fiestas 


> On Oct. 7, 2013, 2:47 p.m., Aleix Pol Gonzalez wrote:
> > kded/kbuildsycoca.cpp, line 48
> > 
> >
> > What happens with this?
> 
> Àlex Fiestas wrote:
> I vote for removing it, any objections ?

Plus I forgot to move some code that sets this in case 
"KDE_PLATFORM_FEATURE_BINARY_COMPATIBLE_FEATURE_REDUCTION" is set. Will wait 
until David comment on this to either move it or simply remove it.


- Àlex


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/#review41351
---


On Oct. 7, 2013, 3:21 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113148/
> ---
> 
> (Updated Oct. 7, 2013, 3:21 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Moved KBuildsyscoca to KService.
> 
> I have done the moving and the cleaning in different commits, just unified 
> them for reviewboard.
> 
> 
> Diffs
> -
> 
>   kded/CMakeLists.txt 4f9133f 
>   kded/applications.menu  
>   kded/kbuildmimetypefactory.h  
>   kded/kbuildmimetypefactory.cpp 2e81ce7 
>   kded/kbuildservicefactory.h  
>   kded/kbuildservicefactory.cpp 971f327 
>   kded/kbuildservicegroupfactory.h  
>   kded/kbuildservicegroupfactory.cpp 5485b1c 
>   kded/kbuildservicetypefactory.h  
>   kded/kbuildservicetypefactory.cpp f473cd6 
>   kded/kbuildsycoca.h  
>   kded/kbuildsycoca.cpp 8ea2d2e 
>   kded/kbuildsycocainterface.h  
>   kded/kctimefactory.h  
>   kded/kctimefactory.cpp  
>   kded/kmimeassociations.h  
>   kded/kmimeassociations.cpp  
>   kded/ksycocaresourcelist.h  
>   kded/tests/CMakeLists.txt ca392d2 
>   kded/tests/kmimeassociationstest.cpp  
>   kded/vfolder_menu.h  
>   kded/vfolder_menu.cpp  
>   staging/kservice/CMakeLists.txt b244731 
>   staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
>   staging/kservice/tests/CMakeLists.txt 23d4854 
> 
> Diff: http://git.reviewboard.kde.org/r/113148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-07 Thread Àlex Fiestas 


> On Oct. 7, 2013, 2:47 p.m., Aleix Pol Gonzalez wrote:
> > kded/kbuildsycoca.cpp, line 48
> > 
> >
> > What happens with this?

I vote for removing it, any objections ?


- Àlex


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/#review41351
---


On Oct. 7, 2013, 3:21 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113148/
> ---
> 
> (Updated Oct. 7, 2013, 3:21 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Moved KBuildsyscoca to KService.
> 
> I have done the moving and the cleaning in different commits, just unified 
> them for reviewboard.
> 
> 
> Diffs
> -
> 
>   kded/CMakeLists.txt 4f9133f 
>   kded/applications.menu  
>   kded/kbuildmimetypefactory.h  
>   kded/kbuildmimetypefactory.cpp 2e81ce7 
>   kded/kbuildservicefactory.h  
>   kded/kbuildservicefactory.cpp 971f327 
>   kded/kbuildservicegroupfactory.h  
>   kded/kbuildservicegroupfactory.cpp 5485b1c 
>   kded/kbuildservicetypefactory.h  
>   kded/kbuildservicetypefactory.cpp f473cd6 
>   kded/kbuildsycoca.h  
>   kded/kbuildsycoca.cpp 8ea2d2e 
>   kded/kbuildsycocainterface.h  
>   kded/kctimefactory.h  
>   kded/kctimefactory.cpp  
>   kded/kmimeassociations.h  
>   kded/kmimeassociations.cpp  
>   kded/ksycocaresourcelist.h  
>   kded/tests/CMakeLists.txt ca392d2 
>   kded/tests/kmimeassociationstest.cpp  
>   kded/vfolder_menu.h  
>   kded/vfolder_menu.cpp  
>   staging/kservice/CMakeLists.txt b244731 
>   staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
>   staging/kservice/tests/CMakeLists.txt 23d4854 
> 
> Diff: http://git.reviewboard.kde.org/r/113148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-07 Thread Àlex Fiestas 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/
---

(Updated Oct. 7, 2013, 3:21 p.m.)


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Moved KBuildsyscoca to KService.

I have done the moving and the cleaning in different commits, just unified them 
for reviewboard.


Diffs (updated)
-

  kded/CMakeLists.txt 4f9133f 
  kded/applications.menu  
  kded/kbuildmimetypefactory.h  
  kded/kbuildmimetypefactory.cpp 2e81ce7 
  kded/kbuildservicefactory.h  
  kded/kbuildservicefactory.cpp 971f327 
  kded/kbuildservicegroupfactory.h  
  kded/kbuildservicegroupfactory.cpp 5485b1c 
  kded/kbuildservicetypefactory.h  
  kded/kbuildservicetypefactory.cpp f473cd6 
  kded/kbuildsycoca.h  
  kded/kbuildsycoca.cpp 8ea2d2e 
  kded/kbuildsycocainterface.h  
  kded/kctimefactory.h  
  kded/kctimefactory.cpp  
  kded/kmimeassociations.h  
  kded/kmimeassociations.cpp  
  kded/ksycocaresourcelist.h  
  kded/tests/CMakeLists.txt ca392d2 
  kded/tests/kmimeassociationstest.cpp  
  kded/vfolder_menu.h  
  kded/vfolder_menu.cpp  
  staging/kservice/CMakeLists.txt b244731 
  staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
  staging/kservice/tests/CMakeLists.txt 23d4854 

Diff: http://git.reviewboard.kde.org/r/113148/diff/


Testing
---


Thanks,

Àlex Fiestas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-07 Thread Aurélien Gâteau 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/#review41352
---



staging/kservice/kbuildsycoca/CMakeLists.txt


You probably want to update this comment :)


- Aurélien Gâteau


On Oct. 7, 2013, 4:43 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113148/
> ---
> 
> (Updated Oct. 7, 2013, 4:43 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Moved KBuildsyscoca to KService.
> 
> I have done the moving and the cleaning in different commits, just unified 
> them for reviewboard.
> 
> 
> Diffs
> -
> 
>   kded/CMakeLists.txt 4f9133f 
>   kded/applications.menu  
>   kded/kbuildmimetypefactory.h  
>   kded/kbuildmimetypefactory.cpp 2e81ce7 
>   kded/kbuildservicefactory.h  
>   kded/kbuildservicefactory.cpp 971f327 
>   kded/kbuildservicegroupfactory.h  
>   kded/kbuildservicegroupfactory.cpp 5485b1c 
>   kded/kbuildservicetypefactory.h  
>   kded/kbuildservicetypefactory.cpp f473cd6 
>   kded/kbuildsycoca.h  
>   kded/kbuildsycoca.cpp 8ea2d2e 
>   kded/kbuildsycocainterface.h  
>   kded/kctimefactory.h  
>   kded/kctimefactory.cpp  
>   kded/kmimeassociations.h  
>   kded/kmimeassociations.cpp  
>   kded/ksycocaresourcelist.h  
>   kded/tests/CMakeLists.txt ca392d2 
>   kded/tests/kmimeassociationstest.cpp  
>   kded/vfolder_menu.h  
>   kded/vfolder_menu.cpp  
>   staging/kservice/CMakeLists.txt b244731 
>   staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
>   staging/kservice/tests/CMakeLists.txt 23d4854 
> 
> Diff: http://git.reviewboard.kde.org/r/113148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-07 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/#review41351
---



kded/kbuildsycoca.cpp


Maybe it could be removed?



kded/kbuildsycoca.cpp


What happens with this?


- Aleix Pol Gonzalez


On Oct. 7, 2013, 2:43 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113148/
> ---
> 
> (Updated Oct. 7, 2013, 2:43 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Moved KBuildsyscoca to KService.
> 
> I have done the moving and the cleaning in different commits, just unified 
> them for reviewboard.
> 
> 
> Diffs
> -
> 
>   kded/CMakeLists.txt 4f9133f 
>   kded/applications.menu  
>   kded/kbuildmimetypefactory.h  
>   kded/kbuildmimetypefactory.cpp 2e81ce7 
>   kded/kbuildservicefactory.h  
>   kded/kbuildservicefactory.cpp 971f327 
>   kded/kbuildservicegroupfactory.h  
>   kded/kbuildservicegroupfactory.cpp 5485b1c 
>   kded/kbuildservicetypefactory.h  
>   kded/kbuildservicetypefactory.cpp f473cd6 
>   kded/kbuildsycoca.h  
>   kded/kbuildsycoca.cpp 8ea2d2e 
>   kded/kbuildsycocainterface.h  
>   kded/kctimefactory.h  
>   kded/kctimefactory.cpp  
>   kded/kmimeassociations.h  
>   kded/kmimeassociations.cpp  
>   kded/ksycocaresourcelist.h  
>   kded/tests/CMakeLists.txt ca392d2 
>   kded/tests/kmimeassociationstest.cpp  
>   kded/vfolder_menu.h  
>   kded/vfolder_menu.cpp  
>   staging/kservice/CMakeLists.txt b244731 
>   staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
>   staging/kservice/tests/CMakeLists.txt 23d4854 
> 
> Diff: http://git.reviewboard.kde.org/r/113148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-07 Thread Àlex Fiestas 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113148/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Moved KBuildsyscoca to KService.

I have done the moving and the cleaning in different commits, just unified them 
for reviewboard.


Diffs
-

  kded/CMakeLists.txt 4f9133f 
  kded/applications.menu  
  kded/kbuildmimetypefactory.h  
  kded/kbuildmimetypefactory.cpp 2e81ce7 
  kded/kbuildservicefactory.h  
  kded/kbuildservicefactory.cpp 971f327 
  kded/kbuildservicegroupfactory.h  
  kded/kbuildservicegroupfactory.cpp 5485b1c 
  kded/kbuildservicetypefactory.h  
  kded/kbuildservicetypefactory.cpp f473cd6 
  kded/kbuildsycoca.h  
  kded/kbuildsycoca.cpp 8ea2d2e 
  kded/kbuildsycocainterface.h  
  kded/kctimefactory.h  
  kded/kctimefactory.cpp  
  kded/kmimeassociations.h  
  kded/kmimeassociations.cpp  
  kded/ksycocaresourcelist.h  
  kded/tests/CMakeLists.txt ca392d2 
  kded/tests/kmimeassociationstest.cpp  
  kded/vfolder_menu.h  
  kded/vfolder_menu.cpp  
  staging/kservice/CMakeLists.txt b244731 
  staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION 
  staging/kservice/tests/CMakeLists.txt 23d4854 

Diff: http://git.reviewboard.kde.org/r/113148/diff/


Testing
---


Thanks,

Àlex Fiestas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel