Re: Review Request 113248: Cleanup KNotifyConfig
On Oct. 15, 2013, 3:51 p.m., Aurélien Gâteau wrote: Standalone build fails here with this message: -- Found KF5: /home/aurelien/opt/kf5/share/ECM/find-modules/FindKF5.cmake (found suitable version 5.0.0, minimum required is 5.0.0) found components: CMake Compiler InstallDirs CMake Error at CMakeLists.txt:19 (find_package): Found package configuration file: /home/aurelien/opt/kf5/lib/x86_64-linux-gnu/cmake/KIO/KIOConfig.cmake but it set KIO_FOUND to FALSE so package KIO is considered to be NOT FOUND. Reason given by package: The following imported targets are referenced, but are missing: KF5::KBookmarks KF5::XmlGui KF5::Solid Aleix Pol Gonzalez wrote: Is it really a problem in KNotifyConfig? I'd say it is in KIO... Indeed, you are probably right. - Aurélien --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/#review41778 --- On Oct. 14, 2013, 7:33 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/ --- (Updated Oct. 14, 2013, 7:33 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Sort dependencies out, adopt the different cmake constructions to make sure everything will be installed properly. Diffs - staging/knotifyconfig/CMakeLists.txt 65867ba staging/knotifyconfig/KNotifyConfigConfig.cmake.in fbdea78 staging/knotifyconfig/src/CMakeLists.txt 9be9ba4 staging/knotifyconfig/tests/CMakeLists.txt 1ed0360 Diff: http://git.reviewboard.kde.org/r/113248/diff/ Testing --- builds, teh test seems to work still. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113248: Cleanup KNotifyConfig
On Oct. 15, 2013, 1:51 p.m., Aurélien Gâteau wrote: Standalone build fails here with this message: -- Found KF5: /home/aurelien/opt/kf5/share/ECM/find-modules/FindKF5.cmake (found suitable version 5.0.0, minimum required is 5.0.0) found components: CMake Compiler InstallDirs CMake Error at CMakeLists.txt:19 (find_package): Found package configuration file: /home/aurelien/opt/kf5/lib/x86_64-linux-gnu/cmake/KIO/KIOConfig.cmake but it set KIO_FOUND to FALSE so package KIO is considered to be NOT FOUND. Reason given by package: The following imported targets are referenced, but are missing: KF5::KBookmarks KF5::XmlGui KF5::Solid Is it really a problem in KNotifyConfig? I'd say it is in KIO... - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/#review41778 --- On Oct. 14, 2013, 5:33 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/ --- (Updated Oct. 14, 2013, 5:33 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Sort dependencies out, adopt the different cmake constructions to make sure everything will be installed properly. Diffs - staging/knotifyconfig/CMakeLists.txt 65867ba staging/knotifyconfig/KNotifyConfigConfig.cmake.in fbdea78 staging/knotifyconfig/src/CMakeLists.txt 9be9ba4 staging/knotifyconfig/tests/CMakeLists.txt 1ed0360 Diff: http://git.reviewboard.kde.org/r/113248/diff/ Testing --- builds, teh test seems to work still. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113248: Cleanup KNotifyConfig
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/#review41776 --- staging/knotifyconfig/CMakeLists.txt http://git.reviewboard.kde.org/r/113248/#comment30504 Shouldn't this type of conditional removed now that we use alias targets? Or you plan to change that in another commit? - Kevin Ottens On Oct. 14, 2013, 5:33 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/ --- (Updated Oct. 14, 2013, 5:33 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Sort dependencies out, adopt the different cmake constructions to make sure everything will be installed properly. Diffs - staging/knotifyconfig/CMakeLists.txt 65867ba staging/knotifyconfig/KNotifyConfigConfig.cmake.in fbdea78 staging/knotifyconfig/src/CMakeLists.txt 9be9ba4 staging/knotifyconfig/tests/CMakeLists.txt 1ed0360 Diff: http://git.reviewboard.kde.org/r/113248/diff/ Testing --- builds, teh test seems to work still. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113248: Cleanup KNotifyConfig
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/#review41778 --- Standalone build fails here with this message: -- Found KF5: /home/aurelien/opt/kf5/share/ECM/find-modules/FindKF5.cmake (found suitable version 5.0.0, minimum required is 5.0.0) found components: CMake Compiler InstallDirs CMake Error at CMakeLists.txt:19 (find_package): Found package configuration file: /home/aurelien/opt/kf5/lib/x86_64-linux-gnu/cmake/KIO/KIOConfig.cmake but it set KIO_FOUND to FALSE so package KIO is considered to be NOT FOUND. Reason given by package: The following imported targets are referenced, but are missing: KF5::KBookmarks KF5::XmlGui KF5::Solid - Aurélien Gâteau On Oct. 14, 2013, 7:33 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/ --- (Updated Oct. 14, 2013, 7:33 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Sort dependencies out, adopt the different cmake constructions to make sure everything will be installed properly. Diffs - staging/knotifyconfig/CMakeLists.txt 65867ba staging/knotifyconfig/KNotifyConfigConfig.cmake.in fbdea78 staging/knotifyconfig/src/CMakeLists.txt 9be9ba4 staging/knotifyconfig/tests/CMakeLists.txt 1ed0360 Diff: http://git.reviewboard.kde.org/r/113248/diff/ Testing --- builds, teh test seems to work still. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113248: Cleanup KNotifyConfig
On Oct. 15, 2013, 1:44 p.m., Kevin Ottens wrote: staging/knotifyconfig/CMakeLists.txt, line 17 http://git.reviewboard.kde.org/r/113248/diff/1/?file=201274#file201274line17 Shouldn't this type of conditional removed now that we use alias targets? Or you plan to change that in another commit? No, that should stay as long as it can be compiled from a higher module. Otherwise all modules would be writing their own summary. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/#review41776 --- On Oct. 14, 2013, 5:33 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/ --- (Updated Oct. 14, 2013, 5:33 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Sort dependencies out, adopt the different cmake constructions to make sure everything will be installed properly. Diffs - staging/knotifyconfig/CMakeLists.txt 65867ba staging/knotifyconfig/KNotifyConfigConfig.cmake.in fbdea78 staging/knotifyconfig/src/CMakeLists.txt 9be9ba4 staging/knotifyconfig/tests/CMakeLists.txt 1ed0360 Diff: http://git.reviewboard.kde.org/r/113248/diff/ Testing --- builds, teh test seems to work still. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113248: Cleanup KNotifyConfig
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Sort dependencies out, adopt the different cmake constructions to make sure everything will be installed properly. Diffs - Diff: http://git.reviewboard.kde.org/r/113248/diff/ Testing --- builds, teh test seems to work still. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113248: Cleanup KNotifyConfig
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/ --- (Updated Oct. 14, 2013, 5:33 p.m.) Review request for KDE Frameworks. Changes --- forgot the diff Repository: kdelibs Description --- Sort dependencies out, adopt the different cmake constructions to make sure everything will be installed properly. Diffs (updated) - staging/knotifyconfig/CMakeLists.txt 65867ba staging/knotifyconfig/KNotifyConfigConfig.cmake.in fbdea78 staging/knotifyconfig/src/CMakeLists.txt 9be9ba4 staging/knotifyconfig/tests/CMakeLists.txt 1ed0360 Diff: http://git.reviewboard.kde.org/r/113248/diff/ Testing --- builds, teh test seems to work still. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
