Review Request 113328: Fix standalone build of kdoctools

2013-10-18 Thread Aurélien Gâteau 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113328/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Fix standalone build of kdoctools: it was not looking for KArchive. This patch 
also aligns the top-level CMakeLists.txt with template/CMakeLists.txt.


Diffs
-

  tier2/kdoctools/src/CMakeLists.txt 8b726a8 
  tier2/kdoctools/CMakeLists.txt 53fd0e9 
  superbuild/CMakeLists.txt 5cdec94 

Diff: http://git.reviewboard.kde.org/r/113328/diff/


Testing
---

Builds within kdelibs and using superbuild.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-18 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113328/#review41951
---



tier2/kdoctools/CMakeLists.txt


The KF5 find_package should be outside of the if


- Aleix Pol Gonzalez


On Oct. 18, 2013, 12:14 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113328/
> ---
> 
> (Updated Oct. 18, 2013, 12:14 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Fix standalone build of kdoctools: it was not looking for KArchive. This 
> patch also aligns the top-level CMakeLists.txt with template/CMakeLists.txt.
> 
> 
> Diffs
> -
> 
>   tier2/kdoctools/src/CMakeLists.txt 8b726a8 
>   tier2/kdoctools/CMakeLists.txt 53fd0e9 
>   superbuild/CMakeLists.txt 5cdec94 
> 
> Diff: http://git.reviewboard.kde.org/r/113328/diff/
> 
> 
> Testing
> ---
> 
> Builds within kdelibs and using superbuild.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-18 Thread Aurélien Gâteau 


> On Oct. 18, 2013, 5:23 p.m., Aleix Pol Gonzalez wrote:
> > tier2/kdoctools/CMakeLists.txt, line 30
> > 
> >
> > The KF5 find_package should be outside of the if

Oh right, should update the template as well then.


- Aurélien


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113328/#review41951
---


On Oct. 18, 2013, 2:14 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113328/
> ---
> 
> (Updated Oct. 18, 2013, 2:14 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Fix standalone build of kdoctools: it was not looking for KArchive. This 
> patch also aligns the top-level CMakeLists.txt with template/CMakeLists.txt.
> 
> 
> Diffs
> -
> 
>   tier2/kdoctools/src/CMakeLists.txt 8b726a8 
>   tier2/kdoctools/CMakeLists.txt 53fd0e9 
>   superbuild/CMakeLists.txt 5cdec94 
> 
> Diff: http://git.reviewboard.kde.org/r/113328/diff/
> 
> 
> Testing
> ---
> 
> Builds within kdelibs and using superbuild.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-18 Thread Aurélien Gâteau 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113328/
---

(Updated Oct. 18, 2013, 5:42 p.m.)


Review request for KDE Frameworks.


Changes
---

Move find_package(KF5)


Repository: kdelibs


Description
---

Fix standalone build of kdoctools: it was not looking for KArchive. This patch 
also aligns the top-level CMakeLists.txt with template/CMakeLists.txt.


Diffs (updated)
-

  superbuild/CMakeLists.txt 5cdec94 
  tier2/kdoctools/CMakeLists.txt 53fd0e9 
  tier2/kdoctools/src/CMakeLists.txt 8b726a8 

Diff: http://git.reviewboard.kde.org/r/113328/diff/


Testing
---

Builds within kdelibs and using superbuild.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-21 Thread Kevin Ottens 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113328/#review42080
---



tier2/kdoctools/CMakeLists.txt


FOOBAR really? :-)

In fact ecm_setup_version might not even be needed for that one, it has no 
lib, just a runtime tool IIRC.


- Kevin Ottens


On Oct. 18, 2013, 3:42 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113328/
> ---
> 
> (Updated Oct. 18, 2013, 3:42 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Fix standalone build of kdoctools: it was not looking for KArchive. This 
> patch also aligns the top-level CMakeLists.txt with template/CMakeLists.txt.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 5cdec94 
>   tier2/kdoctools/CMakeLists.txt 53fd0e9 
>   tier2/kdoctools/src/CMakeLists.txt 8b726a8 
> 
> Diff: http://git.reviewboard.kde.org/r/113328/diff/
> 
> 
> Testing
> ---
> 
> Builds within kdelibs and using superbuild.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-21 Thread Aurélien Gâteau 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113328/
---

(Updated Oct. 21, 2013, 3:32 p.m.)


Review request for KDE Frameworks.


Changes
---

No need to call ecm_setup_version() in kdoctools, it's not a library.


Repository: kdelibs


Description
---

Fix standalone build of kdoctools: it was not looking for KArchive. This patch 
also aligns the top-level CMakeLists.txt with template/CMakeLists.txt.


Diffs (updated)
-

  superbuild/CMakeLists.txt 5cdec94 
  tier2/kdoctools/CMakeLists.txt 53fd0e9 
  tier2/kdoctools/src/CMakeLists.txt 8b726a8 

Diff: http://git.reviewboard.kde.org/r/113328/diff/


Testing
---

Builds within kdelibs and using superbuild.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-21 Thread Aurélien Gâteau 


> On Oct. 21, 2013, 1:43 p.m., Kevin Ottens wrote:
> > tier2/kdoctools/CMakeLists.txt, line 18
> > 
> >
> > FOOBAR really? :-)
> > 
> > In fact ecm_setup_version might not even be needed for that one, it has 
> > no lib, just a runtime tool IIRC.

Oups, copy'n'paste from template is dangerous :)

Anyway you are right, ecm_setup_version() is not needed here, just updated the 
request.


- Aurélien


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113328/#review42080
---


On Oct. 21, 2013, 3:32 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113328/
> ---
> 
> (Updated Oct. 21, 2013, 3:32 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Fix standalone build of kdoctools: it was not looking for KArchive. This 
> patch also aligns the top-level CMakeLists.txt with template/CMakeLists.txt.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 5cdec94 
>   tier2/kdoctools/CMakeLists.txt 53fd0e9 
>   tier2/kdoctools/src/CMakeLists.txt 8b726a8 
> 
> Diff: http://git.reviewboard.kde.org/r/113328/diff/
> 
> 
> Testing
> ---
> 
> Builds within kdelibs and using superbuild.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-29 Thread Kevin Ottens 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113328/#review42576
---

Ship it!


Ship It!

- Kevin Ottens


On Oct. 21, 2013, 1:32 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113328/
> ---
> 
> (Updated Oct. 21, 2013, 1:32 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Fix standalone build of kdoctools: it was not looking for KArchive. This 
> patch also aligns the top-level CMakeLists.txt with template/CMakeLists.txt.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 5cdec94 
>   tier2/kdoctools/CMakeLists.txt 53fd0e9 
>   tier2/kdoctools/src/CMakeLists.txt 8b726a8 
> 
> Diff: http://git.reviewboard.kde.org/r/113328/diff/
> 
> 
> Testing
> ---
> 
> Builds within kdelibs and using superbuild.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-29 Thread Aurélien Gâteau 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113328/
---

(Updated Oct. 29, 2013, 1:12 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Fix standalone build of kdoctools: it was not looking for KArchive. This patch 
also aligns the top-level CMakeLists.txt with template/CMakeLists.txt.


Diffs
-

  superbuild/CMakeLists.txt 5cdec94 
  tier2/kdoctools/CMakeLists.txt 53fd0e9 
  tier2/kdoctools/src/CMakeLists.txt 8b726a8 

Diff: http://git.reviewboard.kde.org/r/113328/diff/


Testing
---

Builds within kdelibs and using superbuild.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-29 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113328/#review42632
---


This review has been submitted with commit 
7582c2b341c97362aab0b8f832d1fe7c0836aeb6 by Aurélien Gâteau to branch 
frameworks.

- Commit Hook


On Oct. 21, 2013, 1:32 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113328/
> ---
> 
> (Updated Oct. 21, 2013, 1:32 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Fix standalone build of kdoctools: it was not looking for KArchive. This 
> patch also aligns the top-level CMakeLists.txt with template/CMakeLists.txt.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 5cdec94 
>   tier2/kdoctools/CMakeLists.txt 53fd0e9 
>   tier2/kdoctools/src/CMakeLists.txt 8b726a8 
> 
> Diff: http://git.reviewboard.kde.org/r/113328/diff/
> 
> 
> Testing
> ---
> 
> Builds within kdelibs and using superbuild.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel