Review Request 115203: Allow compiling with MSVC

2014-01-21 Thread Alexander Richardson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115203/
---

Review request for KDE Frameworks.


Repository: kcrash


Description
---

Allow compiling with MSVC


Diffs
-

  src/config-strlcpy.h.cmake 5d9163d7a60d89b9792afcdf498af6425a9038a8 
  src/kcrash.cpp 13b64adff7bce5782b054bf43ef9e357e9aa1622 

Diff: https://git.reviewboard.kde.org/r/115203/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115203: Allow compiling with MSVC

2014-01-22 Thread Alexander Richardson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115203/
---

(Updated Jan. 22, 2014, 4:13 p.m.)


Review request for KDE Frameworks and kdewin.


Repository: kcrash


Description
---

Allow compiling with MSVC


Diffs
-

  src/config-strlcpy.h.cmake 5d9163d7a60d89b9792afcdf498af6425a9038a8 
  src/kcrash.cpp 13b64adff7bce5782b054bf43ef9e357e9aa1622 

Diff: https://git.reviewboard.kde.org/r/115203/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115203: Allow compiling with MSVC

2014-01-26 Thread Kevin Ottens 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115203/#review48351
---


Looks good to me, opinion of someone from kdewin would be welcome though.

- Kevin Ottens


On Jan. 22, 2014, 3:13 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115203/
> ---
> 
> (Updated Jan. 22, 2014, 3:13 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Allow compiling with MSVC
> 
> 
> Diffs
> -
> 
>   src/config-strlcpy.h.cmake 5d9163d7a60d89b9792afcdf498af6425a9038a8 
>   src/kcrash.cpp 13b64adff7bce5782b054bf43ef9e357e9aa1622 
> 
> Diff: https://git.reviewboard.kde.org/r/115203/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115203: Allow compiling with MSVC

2014-01-30 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115203/#review48600
---



src/config-strlcpy.h.cmake


I'm not convinced this is the correct fix; I don't think strlcpy *should* 
be exported by kcrash.  Instead, I suspect the KCRASH_EXPORT should be removed 
from strlcpy-fake.c.


- Alex Merry


On Jan. 22, 2014, 3:13 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115203/
> ---
> 
> (Updated Jan. 22, 2014, 3:13 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Allow compiling with MSVC
> 
> 
> Diffs
> -
> 
>   src/config-strlcpy.h.cmake 5d9163d7a60d89b9792afcdf498af6425a9038a8 
>   src/kcrash.cpp 13b64adff7bce5782b054bf43ef9e357e9aa1622 
> 
> Diff: https://git.reviewboard.kde.org/r/115203/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115203: Allow compiling with MSVC

2014-02-03 Thread Alexander Richardson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115203/
---

(Updated Feb. 3, 2014, 7:43 p.m.)


Review request for KDE Frameworks.


Changes
---

no longer export strlcpy


Repository: kcrash


Description
---

Allow compiling with MSVC


Diffs (updated)
-

  src/kcrash.cpp 1510dc5279b502411a6b0bcafa3e614e42b32c57 
  src/strlcpy-fake.c 8a6146c077bbee9fa7c4cca036eeec05dcdc4ea8 

Diff: https://git.reviewboard.kde.org/r/115203/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115203: Allow compiling with MSVC

2014-02-03 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115203/#review48869
---

Ship it!


Just one thing, then it can go in.


src/kcrash.cpp


This comment is no longer correct now that the function is not at the end 
of the file.  It should say something like "the following function is 
copy&pasted from kinit/wrapper.cpp"


- Alex Merry


On Feb. 3, 2014, 6:43 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115203/
> ---
> 
> (Updated Feb. 3, 2014, 6:43 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Allow compiling with MSVC
> 
> 
> Diffs
> -
> 
>   src/kcrash.cpp 1510dc5279b502411a6b0bcafa3e614e42b32c57 
>   src/strlcpy-fake.c 8a6146c077bbee9fa7c4cca036eeec05dcdc4ea8 
> 
> Diff: https://git.reviewboard.kde.org/r/115203/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115203: Allow compiling with MSVC

2014-02-03 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115203/#review48872
---


This review has been submitted with commit 
ad3dc08b0892a521084eafef3be3324a3477d5c4 by Alex Richardson to branch master.

- Commit Hook


On Feb. 3, 2014, 6:43 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115203/
> ---
> 
> (Updated Feb. 3, 2014, 6:43 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Allow compiling with MSVC
> 
> 
> Diffs
> -
> 
>   src/kcrash.cpp 1510dc5279b502411a6b0bcafa3e614e42b32c57 
>   src/strlcpy-fake.c 8a6146c077bbee9fa7c4cca036eeec05dcdc4ea8 
> 
> Diff: https://git.reviewboard.kde.org/r/115203/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115203: Allow compiling with MSVC

2014-02-03 Thread Alexander Richardson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115203/
---

(Updated Feb. 3, 2014, 10:25 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcrash


Description
---

Allow compiling with MSVC


Diffs
-

  src/kcrash.cpp 1510dc5279b502411a6b0bcafa3e614e42b32c57 
  src/strlcpy-fake.c 8a6146c077bbee9fa7c4cca036eeec05dcdc4ea8 

Diff: https://git.reviewboard.kde.org/r/115203/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel