Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-03-25 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115717/#review54113
---


This review has been submitted with commit 
e0fd6fe3bea55b72084024ccfa2ac31c7e354668 by Martin Gräßlin to branch master.

- Commit Hook


On Feb. 13, 2014, 9:41 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115717/
> ---
> 
> (Updated Feb. 13, 2014, 9:41 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesu
> 
> 
> Description
> ---
> 
> Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set
> 
> If kdesu is compiled with X11 it required the DISPLAY variable to be
> set. This is no longer correct as it might have been compiled with
> X11 but is run on Wayland. Thus the code checks now also for
> WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support
> should become more complete, I do not know how it behaves if we compile
> without X11 support. Unfortunately there are no autotests and no test
> applications which one could use.
> 
> 
> Diffs
> -
> 
>   src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 
>   src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 
> 
> Diff: https://git.reviewboard.kde.org/r/115717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-03-25 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115717/
---

(Updated March 25, 2014, 2:21 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdesu


Description
---

Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

If kdesu is compiled with X11 it required the DISPLAY variable to be
set. This is no longer correct as it might have been compiled with
X11 but is run on Wayland. Thus the code checks now also for
WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support
should become more complete, I do not know how it behaves if we compile
without X11 support. Unfortunately there are no autotests and no test
applications which one could use.


Diffs
-

  src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 
  src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 

Diff: https://git.reviewboard.kde.org/r/115717/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-03-24 Thread Kevin Ottens


> On March 17, 2014, 4:44 p.m., Kevin Ottens wrote:
> > OK, let's go for it without a test app...

Anything still blocking?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115717/#review53187
---


On Feb. 13, 2014, 9:41 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115717/
> ---
> 
> (Updated Feb. 13, 2014, 9:41 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesu
> 
> 
> Description
> ---
> 
> Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set
> 
> If kdesu is compiled with X11 it required the DISPLAY variable to be
> set. This is no longer correct as it might have been compiled with
> X11 but is run on Wayland. Thus the code checks now also for
> WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support
> should become more complete, I do not know how it behaves if we compile
> without X11 support. Unfortunately there are no autotests and no test
> applications which one could use.
> 
> 
> Diffs
> -
> 
>   src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 
>   src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 
> 
> Diff: https://git.reviewboard.kde.org/r/115717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-03-17 Thread Kevin Ottens

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115717/#review53187
---

Ship it!


OK, let's go for it without a test app...

- Kevin Ottens


On Feb. 13, 2014, 9:41 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115717/
> ---
> 
> (Updated Feb. 13, 2014, 9:41 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesu
> 
> 
> Description
> ---
> 
> Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set
> 
> If kdesu is compiled with X11 it required the DISPLAY variable to be
> set. This is no longer correct as it might have been compiled with
> X11 but is run on Wayland. Thus the code checks now also for
> WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support
> should become more complete, I do not know how it behaves if we compile
> without X11 support. Unfortunately there are no autotests and no test
> applications which one could use.
> 
> 
> Diffs
> -
> 
>   src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 
>   src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 
> 
> Diff: https://git.reviewboard.kde.org/r/115717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-03-13 Thread Martin Gräßlin


> On Feb. 19, 2014, 3:07 p.m., Alex Merry wrote:
> > I don't think papering over the X11-ness of kdesu like this is the right 
> > approach.  Of course, what this framework really needs is a test app; maybe 
> > a simple port of the kdesu app from kde-runtime?
> 
> Kevin Ottens wrote:
> This kind of "papering over" can only be temporary indeed. Just wondering 
> if Martin has the possibility to clean that up better at that stage?
> 
> As for the test app: hell yes, definitely needed.
> 
> Martin Gräßlin wrote:
> well yes if there's a testapp and that works I can implement it properly. 
> But IIRC kdesu never worked on my setup (not having a password for root).
> 
> Kevin Ottens wrote:
> You can use it for other users than root you know. ;-)
> 
> Martin Gräßlin wrote:
> no, I didn't and which other users? ;-)
> 
> Kevin Ottens wrote:
> My point is that if you need to test it's trivial to add a temporary 
> user...
> 
> Kevin Ottens wrote:
> So what do we do of this patch? Any chance of a test app?

> Any chance of a test app?

I would prefer if the test app could be integrated by a domain expert. I do not 
really feel comfortable about it.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115717/#review50240
---


On Feb. 13, 2014, 10:41 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115717/
> ---
> 
> (Updated Feb. 13, 2014, 10:41 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesu
> 
> 
> Description
> ---
> 
> Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set
> 
> If kdesu is compiled with X11 it required the DISPLAY variable to be
> set. This is no longer correct as it might have been compiled with
> X11 but is run on Wayland. Thus the code checks now also for
> WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support
> should become more complete, I do not know how it behaves if we compile
> without X11 support. Unfortunately there are no autotests and no test
> applications which one could use.
> 
> 
> Diffs
> -
> 
>   src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 
>   src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 
> 
> Diff: https://git.reviewboard.kde.org/r/115717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-03-12 Thread Kevin Ottens


> On Feb. 19, 2014, 2:07 p.m., Alex Merry wrote:
> > I don't think papering over the X11-ness of kdesu like this is the right 
> > approach.  Of course, what this framework really needs is a test app; maybe 
> > a simple port of the kdesu app from kde-runtime?
> 
> Kevin Ottens wrote:
> This kind of "papering over" can only be temporary indeed. Just wondering 
> if Martin has the possibility to clean that up better at that stage?
> 
> As for the test app: hell yes, definitely needed.
> 
> Martin Gräßlin wrote:
> well yes if there's a testapp and that works I can implement it properly. 
> But IIRC kdesu never worked on my setup (not having a password for root).
> 
> Kevin Ottens wrote:
> You can use it for other users than root you know. ;-)
> 
> Martin Gräßlin wrote:
> no, I didn't and which other users? ;-)
> 
> Kevin Ottens wrote:
> My point is that if you need to test it's trivial to add a temporary 
> user...

So what do we do of this patch? Any chance of a test app?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115717/#review50240
---


On Feb. 13, 2014, 9:41 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115717/
> ---
> 
> (Updated Feb. 13, 2014, 9:41 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesu
> 
> 
> Description
> ---
> 
> Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set
> 
> If kdesu is compiled with X11 it required the DISPLAY variable to be
> set. This is no longer correct as it might have been compiled with
> X11 but is run on Wayland. Thus the code checks now also for
> WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support
> should become more complete, I do not know how it behaves if we compile
> without X11 support. Unfortunately there are no autotests and no test
> applications which one could use.
> 
> 
> Diffs
> -
> 
>   src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 
>   src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 
> 
> Diff: https://git.reviewboard.kde.org/r/115717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-03-05 Thread Kevin Ottens


> On Feb. 19, 2014, 2:07 p.m., Alex Merry wrote:
> > I don't think papering over the X11-ness of kdesu like this is the right 
> > approach.  Of course, what this framework really needs is a test app; maybe 
> > a simple port of the kdesu app from kde-runtime?
> 
> Kevin Ottens wrote:
> This kind of "papering over" can only be temporary indeed. Just wondering 
> if Martin has the possibility to clean that up better at that stage?
> 
> As for the test app: hell yes, definitely needed.
> 
> Martin Gräßlin wrote:
> well yes if there's a testapp and that works I can implement it properly. 
> But IIRC kdesu never worked on my setup (not having a password for root).
> 
> Kevin Ottens wrote:
> You can use it for other users than root you know. ;-)
> 
> Martin Gräßlin wrote:
> no, I didn't and which other users? ;-)

My point is that if you need to test it's trivial to add a temporary user...


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115717/#review50240
---


On Feb. 13, 2014, 9:41 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115717/
> ---
> 
> (Updated Feb. 13, 2014, 9:41 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesu
> 
> 
> Description
> ---
> 
> Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set
> 
> If kdesu is compiled with X11 it required the DISPLAY variable to be
> set. This is no longer correct as it might have been compiled with
> X11 but is run on Wayland. Thus the code checks now also for
> WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support
> should become more complete, I do not know how it behaves if we compile
> without X11 support. Unfortunately there are no autotests and no test
> applications which one could use.
> 
> 
> Diffs
> -
> 
>   src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 
>   src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 
> 
> Diff: https://git.reviewboard.kde.org/r/115717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-03-05 Thread Martin Gräßlin


> On Feb. 19, 2014, 3:07 p.m., Alex Merry wrote:
> > I don't think papering over the X11-ness of kdesu like this is the right 
> > approach.  Of course, what this framework really needs is a test app; maybe 
> > a simple port of the kdesu app from kde-runtime?
> 
> Kevin Ottens wrote:
> This kind of "papering over" can only be temporary indeed. Just wondering 
> if Martin has the possibility to clean that up better at that stage?
> 
> As for the test app: hell yes, definitely needed.
> 
> Martin Gräßlin wrote:
> well yes if there's a testapp and that works I can implement it properly. 
> But IIRC kdesu never worked on my setup (not having a password for root).
> 
> Kevin Ottens wrote:
> You can use it for other users than root you know. ;-)

no, I didn't and which other users? ;-)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115717/#review50240
---


On Feb. 13, 2014, 10:41 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115717/
> ---
> 
> (Updated Feb. 13, 2014, 10:41 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesu
> 
> 
> Description
> ---
> 
> Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set
> 
> If kdesu is compiled with X11 it required the DISPLAY variable to be
> set. This is no longer correct as it might have been compiled with
> X11 but is run on Wayland. Thus the code checks now also for
> WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support
> should become more complete, I do not know how it behaves if we compile
> without X11 support. Unfortunately there are no autotests and no test
> applications which one could use.
> 
> 
> Diffs
> -
> 
>   src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 
>   src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 
> 
> Diff: https://git.reviewboard.kde.org/r/115717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-03-04 Thread Kevin Ottens


> On Feb. 19, 2014, 2:07 p.m., Alex Merry wrote:
> > I don't think papering over the X11-ness of kdesu like this is the right 
> > approach.  Of course, what this framework really needs is a test app; maybe 
> > a simple port of the kdesu app from kde-runtime?
> 
> Kevin Ottens wrote:
> This kind of "papering over" can only be temporary indeed. Just wondering 
> if Martin has the possibility to clean that up better at that stage?
> 
> As for the test app: hell yes, definitely needed.
> 
> Martin Gräßlin wrote:
> well yes if there's a testapp and that works I can implement it properly. 
> But IIRC kdesu never worked on my setup (not having a password for root).

You can use it for other users than root you know. ;-)


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115717/#review50240
---


On Feb. 13, 2014, 9:41 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115717/
> ---
> 
> (Updated Feb. 13, 2014, 9:41 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesu
> 
> 
> Description
> ---
> 
> Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set
> 
> If kdesu is compiled with X11 it required the DISPLAY variable to be
> set. This is no longer correct as it might have been compiled with
> X11 but is run on Wayland. Thus the code checks now also for
> WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support
> should become more complete, I do not know how it behaves if we compile
> without X11 support. Unfortunately there are no autotests and no test
> applications which one could use.
> 
> 
> Diffs
> -
> 
>   src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 
>   src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 
> 
> Diff: https://git.reviewboard.kde.org/r/115717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-02-20 Thread Martin Gräßlin


> On Feb. 19, 2014, 3:07 p.m., Alex Merry wrote:
> > I don't think papering over the X11-ness of kdesu like this is the right 
> > approach.  Of course, what this framework really needs is a test app; maybe 
> > a simple port of the kdesu app from kde-runtime?
> 
> Kevin Ottens wrote:
> This kind of "papering over" can only be temporary indeed. Just wondering 
> if Martin has the possibility to clean that up better at that stage?
> 
> As for the test app: hell yes, definitely needed.

well yes if there's a testapp and that works I can implement it properly. But 
IIRC kdesu never worked on my setup (not having a password for root).


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115717/#review50240
---


On Feb. 13, 2014, 10:41 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115717/
> ---
> 
> (Updated Feb. 13, 2014, 10:41 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesu
> 
> 
> Description
> ---
> 
> Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set
> 
> If kdesu is compiled with X11 it required the DISPLAY variable to be
> set. This is no longer correct as it might have been compiled with
> X11 but is run on Wayland. Thus the code checks now also for
> WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support
> should become more complete, I do not know how it behaves if we compile
> without X11 support. Unfortunately there are no autotests and no test
> applications which one could use.
> 
> 
> Diffs
> -
> 
>   src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 
>   src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 
> 
> Diff: https://git.reviewboard.kde.org/r/115717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-02-20 Thread Kevin Ottens


> On Feb. 19, 2014, 2:07 p.m., Alex Merry wrote:
> > I don't think papering over the X11-ness of kdesu like this is the right 
> > approach.  Of course, what this framework really needs is a test app; maybe 
> > a simple port of the kdesu app from kde-runtime?

This kind of "papering over" can only be temporary indeed. Just wondering if 
Martin has the possibility to clean that up better at that stage?

As for the test app: hell yes, definitely needed.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115717/#review50240
---


On Feb. 13, 2014, 9:41 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115717/
> ---
> 
> (Updated Feb. 13, 2014, 9:41 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesu
> 
> 
> Description
> ---
> 
> Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set
> 
> If kdesu is compiled with X11 it required the DISPLAY variable to be
> set. This is no longer correct as it might have been compiled with
> X11 but is run on Wayland. Thus the code checks now also for
> WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support
> should become more complete, I do not know how it behaves if we compile
> without X11 support. Unfortunately there are no autotests and no test
> applications which one could use.
> 
> 
> Diffs
> -
> 
>   src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 
>   src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 
> 
> Diff: https://git.reviewboard.kde.org/r/115717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-02-19 Thread Alex Merry

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115717/#review50240
---


I don't think papering over the X11-ness of kdesu like this is the right 
approach.  Of course, what this framework really needs is a test app; maybe a 
simple port of the kdesu app from kde-runtime?

- Alex Merry


On Feb. 13, 2014, 9:41 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115717/
> ---
> 
> (Updated Feb. 13, 2014, 9:41 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesu
> 
> 
> Description
> ---
> 
> Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set
> 
> If kdesu is compiled with X11 it required the DISPLAY variable to be
> set. This is no longer correct as it might have been compiled with
> X11 but is run on Wayland. Thus the code checks now also for
> WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support
> should become more complete, I do not know how it behaves if we compile
> without X11 support. Unfortunately there are no autotests and no test
> applications which one could use.
> 
> 
> Diffs
> -
> 
>   src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 
>   src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 
> 
> Diff: https://git.reviewboard.kde.org/r/115717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-02-13 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115717/
---

Review request for KDE Frameworks.


Repository: kdesu


Description
---

Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

If kdesu is compiled with X11 it required the DISPLAY variable to be
set. This is no longer correct as it might have been compiled with
X11 but is run on Wayland. Thus the code checks now also for
WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support
should become more complete, I do not know how it behaves if we compile
without X11 support. Unfortunately there are no autotests and no test
applications which one could use.


Diffs
-

  src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 
  src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 

Diff: https://git.reviewboard.kde.org/r/115717/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel