Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review52077 --- This review has been submitted with commit 68fa427587a38805f27e28cd9b6de1b248b18fe5 by Lamarque V. Souza on behalf of Alex Richardson to branch master. - Commit Hook On March 5, 2014, 2:46 a.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116098/ > --- > > (Updated March 5, 2014, 2:46 a.m.) > > > Review request for KDE Frameworks, Daniel Nicoletti, Lamarque Souza, and > Sebastian Kügler. > > > Repository: libnm-qt > > > Description > --- > > Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs > > This means there is no longer a need for passing -DLIB_SUFFIX=64 on e.g. > openSuSE, since CMake will detect the correct install directory for most > distributions. If for some reason CMake doesn't detect the correct > directory it can be overriden using e.g. -DCMAKE_INSTALL_LIBDIR=lib32 > > > Diffs > - > > CMakeLists.txt 9918278 > NetworkManagerQt.pc.cmake 2c3ab07 > include/CMakeLists.txt 2b51ced > include/settings/CMakeLists.txt 1a00bdb > > Diff: https://git.reviewboard.kde.org/r/116098/diff/ > > > Testing > --- > > Installed into the right directories after applying the patch. > > > Thanks, > > Alexander Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review52076 --- This review has been submitted with commit 9b32aab411fc79d00febf9beef98958987b66ae0 by Lamarque V. Souza on behalf of Alex Richardson to branch NM/0.9.8. - Commit Hook On March 5, 2014, 2:46 a.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116098/ > --- > > (Updated March 5, 2014, 2:46 a.m.) > > > Review request for KDE Frameworks, Daniel Nicoletti, Lamarque Souza, and > Sebastian Kügler. > > > Repository: libnm-qt > > > Description > --- > > Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs > > This means there is no longer a need for passing -DLIB_SUFFIX=64 on e.g. > openSuSE, since CMake will detect the correct install directory for most > distributions. If for some reason CMake doesn't detect the correct > directory it can be overriden using e.g. -DCMAKE_INSTALL_LIBDIR=lib32 > > > Diffs > - > > CMakeLists.txt 9918278 > NetworkManagerQt.pc.cmake 2c3ab07 > include/CMakeLists.txt 2b51ced > include/settings/CMakeLists.txt 1a00bdb > > Diff: https://git.reviewboard.kde.org/r/116098/diff/ > > > Testing > --- > > Installed into the right directories after applying the patch. > > > Thanks, > > Alexander Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/ --- (Updated March 5, 2014, 2:46 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Daniel Nicoletti, Lamarque Souza, and Sebastian Kügler. Repository: libnm-qt Description --- Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs This means there is no longer a need for passing -DLIB_SUFFIX=64 on e.g. openSuSE, since CMake will detect the correct install directory for most distributions. If for some reason CMake doesn't detect the correct directory it can be overriden using e.g. -DCMAKE_INSTALL_LIBDIR=lib32 Diffs - CMakeLists.txt 9918278 NetworkManagerQt.pc.cmake 2c3ab07 include/CMakeLists.txt 2b51ced include/settings/CMakeLists.txt 1a00bdb Diff: https://git.reviewboard.kde.org/r/116098/diff/ Testing --- Installed into the right directories after applying the patch. Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review52000 --- This review has been submitted with commit fb5d0510dbc136ce9c815f106b943a7f0c87aa34 by Alex Richardson to branch qt5. - Commit Hook On March 4, 2014, 4:13 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116098/ > --- > > (Updated March 4, 2014, 4:13 p.m.) > > > Review request for KDE Frameworks, Daniel Nicoletti, Lamarque Souza, and > Sebastian Kügler. > > > Repository: libnm-qt > > > Description > --- > > Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs > > This means there is no longer a need for passing -DLIB_SUFFIX=64 on e.g. > openSuSE, since CMake will detect the correct install directory for most > distributions. If for some reason CMake doesn't detect the correct > directory it can be overriden using e.g. -DCMAKE_INSTALL_LIBDIR=lib32 > > > Diffs > - > > CMakeLists.txt 9918278 > NetworkManagerQt.pc.cmake 2c3ab07 > include/CMakeLists.txt 2b51ced > include/settings/CMakeLists.txt 1a00bdb > > Diff: https://git.reviewboard.kde.org/r/116098/diff/ > > > Testing > --- > > Installed into the right directories after applying the patch. > > > Thanks, > > Alexander Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs
> On March 4, 2014, 4:42 p.m., Lamarque Souza wrote: > > Ship It! > > Lamarque Souza wrote: > This should be ported to branches master and NM/0.9.8 as well. > > Alexander Richardson wrote: > How should I commit it? Commit to oldest branch and then merge? Or rather > put this into qt5 and then apply patches to the other branches? The latter > might make merging a bit harder. I usually apply to master e cherry-pick individual commits to NM/0.9.8. The CMakeListst.txt in qt5 branch is quit different from the ones in the other branches, your patch does not apply. - Lamarque --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review51909 --- On March 4, 2014, 4:13 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116098/ > --- > > (Updated March 4, 2014, 4:13 p.m.) > > > Review request for KDE Frameworks, Daniel Nicoletti, Lamarque Souza, and > Sebastian Kügler. > > > Repository: libnm-qt > > > Description > --- > > Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs > > This means there is no longer a need for passing -DLIB_SUFFIX=64 on e.g. > openSuSE, since CMake will detect the correct install directory for most > distributions. If for some reason CMake doesn't detect the correct > directory it can be overriden using e.g. -DCMAKE_INSTALL_LIBDIR=lib32 > > > Diffs > - > > CMakeLists.txt 9918278 > NetworkManagerQt.pc.cmake 2c3ab07 > include/CMakeLists.txt 2b51ced > include/settings/CMakeLists.txt 1a00bdb > > Diff: https://git.reviewboard.kde.org/r/116098/diff/ > > > Testing > --- > > Installed into the right directories after applying the patch. > > > Thanks, > > Alexander Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs
> On March 4, 2014, 5:42 p.m., Lamarque Souza wrote: > > Ship It! > > Lamarque Souza wrote: > This should be ported to branches master and NM/0.9.8 as well. How should I commit it? Commit to oldest branch and then merge? Or rather put this into qt5 and then apply patches to the other branches? The latter might make merging a bit harder. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review51909 --- On March 4, 2014, 5:13 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116098/ > --- > > (Updated March 4, 2014, 5:13 p.m.) > > > Review request for KDE Frameworks, Daniel Nicoletti, Lamarque Souza, and > Sebastian Kügler. > > > Repository: libnm-qt > > > Description > --- > > Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs > > This means there is no longer a need for passing -DLIB_SUFFIX=64 on e.g. > openSuSE, since CMake will detect the correct install directory for most > distributions. If for some reason CMake doesn't detect the correct > directory it can be overriden using e.g. -DCMAKE_INSTALL_LIBDIR=lib32 > > > Diffs > - > > CMakeLists.txt 9918278 > NetworkManagerQt.pc.cmake 2c3ab07 > include/CMakeLists.txt 2b51ced > include/settings/CMakeLists.txt 1a00bdb > > Diff: https://git.reviewboard.kde.org/r/116098/diff/ > > > Testing > --- > > Installed into the right directories after applying the patch. > > > Thanks, > > Alexander Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs
> On March 4, 2014, 4:42 p.m., Lamarque Souza wrote: > > Ship It! This should be ported to branches master and NM/0.9.8 as well. - Lamarque --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review51909 --- On March 4, 2014, 4:13 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116098/ > --- > > (Updated March 4, 2014, 4:13 p.m.) > > > Review request for KDE Frameworks, Daniel Nicoletti, Lamarque Souza, and > Sebastian Kügler. > > > Repository: libnm-qt > > > Description > --- > > Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs > > This means there is no longer a need for passing -DLIB_SUFFIX=64 on e.g. > openSuSE, since CMake will detect the correct install directory for most > distributions. If for some reason CMake doesn't detect the correct > directory it can be overriden using e.g. -DCMAKE_INSTALL_LIBDIR=lib32 > > > Diffs > - > > CMakeLists.txt 9918278 > NetworkManagerQt.pc.cmake 2c3ab07 > include/CMakeLists.txt 2b51ced > include/settings/CMakeLists.txt 1a00bdb > > Diff: https://git.reviewboard.kde.org/r/116098/diff/ > > > Testing > --- > > Installed into the right directories after applying the patch. > > > Thanks, > > Alexander Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review51909 --- Ship it! Ship It! - Lamarque Souza On March 4, 2014, 4:13 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116098/ > --- > > (Updated March 4, 2014, 4:13 p.m.) > > > Review request for KDE Frameworks, Daniel Nicoletti, Lamarque Souza, and > Sebastian Kügler. > > > Repository: libnm-qt > > > Description > --- > > Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs > > This means there is no longer a need for passing -DLIB_SUFFIX=64 on e.g. > openSuSE, since CMake will detect the correct install directory for most > distributions. If for some reason CMake doesn't detect the correct > directory it can be overriden using e.g. -DCMAKE_INSTALL_LIBDIR=lib32 > > > Diffs > - > > CMakeLists.txt 9918278 > NetworkManagerQt.pc.cmake 2c3ab07 > include/CMakeLists.txt 2b51ced > include/settings/CMakeLists.txt 1a00bdb > > Diff: https://git.reviewboard.kde.org/r/116098/diff/ > > > Testing > --- > > Installed into the right directories after applying the patch. > > > Thanks, > > Alexander Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/ --- (Updated March 4, 2014, 5:13 p.m.) Review request for KDE Frameworks, Daniel Nicoletti, Lamarque Souza, and Sebastian Kügler. Summary (updated) - Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs Repository: libnm-qt Description (updated) --- Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs This means there is no longer a need for passing -DLIB_SUFFIX=64 on e.g. openSuSE, since CMake will detect the correct install directory for most distributions. If for some reason CMake doesn't detect the correct directory it can be overriden using e.g. -DCMAKE_INSTALL_LIBDIR=lib32 Diffs (updated) - CMakeLists.txt 9918278 NetworkManagerQt.pc.cmake 2c3ab07 include/CMakeLists.txt 2b51ced include/settings/CMakeLists.txt 1a00bdb Diff: https://git.reviewboard.kde.org/r/116098/diff/ Testing (updated) --- Installed into the right directories after applying the patch. Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
