Re: Review Request 123679: Fix build with Qt 5.5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123679/#review80075 --- src/kselectionproxymodel.cpp (line 2501) https://git.reviewboard.kde.org/r/123679/#comment54938 this should be adapted as well to say connect(d-m_selectionModel.data(), QItemSelectionModel::modelChanged, this, handleSelectionModelModel); otherwise you'll leak the lambda connection even when this is destroyed, leading to undefined behavior. - Milian Wolff On May 7, 2015, 11:31 p.m., Jan Kundrát wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123679/ --- (Updated May 7, 2015, 11:31 p.m.) Review request for KDE Frameworks and Stephen Kelly. Repository: kitemmodels Description --- Turns out that there's apparently no overload accepting a QPointer as the first argument. This is on Gentoo with qtbase e374ffc29c67493a51527117b55a53dfa5dd4267 and GCC 4.8.3. Diffs - src/kselectionproxymodel.cpp 0755fb1ca527dde8287ba2607d915a4e18c20134 Diff: https://git.reviewboard.kde.org/r/123679/diff/ Testing --- Thanks, Jan Kundrát ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123679: Fix build with Qt 5.5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123679/#review80082 --- Ship it! Ship It! - Milian Wolff On May 8, 2015, 10:42 a.m., Jan Kundrát wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123679/ --- (Updated May 8, 2015, 10:42 a.m.) Review request for KDE Frameworks and Stephen Kelly. Repository: kitemmodels Description --- Turns out that there's apparently no overload accepting a QPointer as the first argument. This is on Gentoo with qtbase e374ffc29c67493a51527117b55a53dfa5dd4267 and GCC 4.8.3. Also make sure to tie the lifetime of the connection with `this` because the lambda accesses our D-pointer, which means that it has to be disconnected on destruction of `this`. Thanks to Milian Wolff for catching this. REVIEW: 123679 Diffs - src/kselectionproxymodel.cpp 0755fb1ca527dde8287ba2607d915a4e18c20134 Diff: https://git.reviewboard.kde.org/r/123679/diff/ Testing --- Thanks, Jan Kundrát ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123679: Fix build with Qt 5.5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123679/ --- (Updated May 8, 2015, 11:48 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Stephen Kelly. Changes --- Submitted with commit d598382536d8c9982bba3ee210869e50d1313dff by Jan Kundrát to branch master. Repository: kitemmodels Description --- Turns out that there's apparently no overload accepting a QPointer as the first argument. This is on Gentoo with qtbase e374ffc29c67493a51527117b55a53dfa5dd4267 and GCC 4.8.3. Also make sure to tie the lifetime of the connection with `this` because the lambda accesses our D-pointer, which means that it has to be disconnected on destruction of `this`. Thanks to Milian Wolff for catching this. REVIEW: 123679 Diffs - src/kselectionproxymodel.cpp 0755fb1ca527dde8287ba2607d915a4e18c20134 Diff: https://git.reviewboard.kde.org/r/123679/diff/ Testing --- Thanks, Jan Kundrát ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123679: Fix build with Qt 5.5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123679/ --- Review request for KDE Frameworks and Stephen Kelly. Repository: kitemmodels Description --- Turns out that there's apparently no overload accepting a QPointer as the first argument. This is on Gentoo with qtbase e374ffc29c67493a51527117b55a53dfa5dd4267 and GCC 4.8.3. Diffs - src/kselectionproxymodel.cpp 0755fb1ca527dde8287ba2607d915a4e18c20134 Diff: https://git.reviewboard.kde.org/r/123679/diff/ Testing --- Thanks, Jan Kundrát ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
