Re: Review Request 124155: Add KStatusNotifierItem::action(const QString &) to retrieve an action by name

2015-07-01 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124155/
---

(Updated July 1, 2015, 8:05 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit f8d29aa9108fa74c1a3666c1774779eb100325a9 by Martin 
Klapetek to branch master.


Bugs: 349513
https://bugs.kde.org/show_bug.cgi?id=349513


Repository: knotifications


Description
---

Apparently this got removed while porting; the code allows to set custom action 
by name and remove too, no reason why it shouldn't allow retrieving it by the 
name.


Diffs
-

  src/kstatusnotifieritem.h 04102d1 
  src/kstatusnotifieritem.cpp 4fd2fda 

Diff: https://git.reviewboard.kde.org/r/124155/diff/


Testing
---


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124155: Add KStatusNotifierItem::action(const QString &) to retrieve an action by name

2015-06-25 Thread Alexander Potashev 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124155/#review81741
---


Nothing "criminal" I could see here. Side note: I guess action names could be 
QLatin1Strings, not QStrings, may be we should change this in KF6.

- Alexander Potashev


On June 23, 2015, 12:04 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124155/
> ---
> 
> (Updated June 23, 2015, 12:04 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 349513
> https://bugs.kde.org/show_bug.cgi?id=349513
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Apparently this got removed while porting; the code allows to set custom 
> action by name and remove too, no reason why it shouldn't allow retrieving it 
> by the name.
> 
> 
> Diffs
> -
> 
>   src/kstatusnotifieritem.h 04102d1 
>   src/kstatusnotifieritem.cpp 4fd2fda 
> 
> Diff: https://git.reviewboard.kde.org/r/124155/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124155: Add KStatusNotifierItem::action(const QString &) to retrieve an action by name

2015-06-25 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124155/#review81740
---


Any comments?

- Martin Klapetek


On June 23, 2015, 2:04 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124155/
> ---
> 
> (Updated June 23, 2015, 2:04 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 349513
> https://bugs.kde.org/show_bug.cgi?id=349513
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Apparently this got removed while porting; the code allows to set custom 
> action by name and remove too, no reason why it shouldn't allow retrieving it 
> by the name.
> 
> 
> Diffs
> -
> 
>   src/kstatusnotifieritem.h 04102d1 
>   src/kstatusnotifieritem.cpp 4fd2fda 
> 
> Diff: https://git.reviewboard.kde.org/r/124155/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124155: Add KStatusNotifierItem::action(const QString &) to retrieve an action by name

2015-06-23 Thread Mark Gaiser 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124155/#review81704
---


+1

- Mark Gaiser


On jun 23, 2015, 12:04 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124155/
> ---
> 
> (Updated jun 23, 2015, 12:04 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 349513
> https://bugs.kde.org/show_bug.cgi?id=349513
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Apparently this got removed while porting; the code allows to set custom 
> action by name and remove too, no reason why it shouldn't allow retrieving it 
> by the name.
> 
> 
> Diffs
> -
> 
>   src/kstatusnotifieritem.h 04102d1 
>   src/kstatusnotifieritem.cpp 4fd2fda 
> 
> Diff: https://git.reviewboard.kde.org/r/124155/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124155: Add KStatusNotifierItem::action(const QString &) to retrieve an action by name

2015-06-23 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124155/
---

(Updated June 23, 2015, 2:04 p.m.)


Review request for KDE Frameworks.


Bugs: 349513
https://bugs.kde.org/show_bug.cgi?id=349513


Repository: knotifications


Description
---

Apparently this got removed while porting; the code allows to set custom action 
by name and remove too, no reason why it shouldn't allow retrieving it by the 
name.


Diffs (updated)
-

  src/kstatusnotifieritem.h 04102d1 
  src/kstatusnotifieritem.cpp 4fd2fda 

Diff: https://git.reviewboard.kde.org/r/124155/diff/


Testing
---


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124155: Add KStatusNotifierItem::action(const QString &) to retrieve an action by name

2015-06-23 Thread Mark Gaiser 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124155/#review81700
---



src/kstatusnotifieritem.h (line 413)


Add
@since ...



src/kstatusnotifieritem.h (line 414)


The function isn't const, but it looks like it could be.
QAction *action(const QString &name) const;



src/kstatusnotifieritem.cpp (line 477)


... &name) const


Just minor nitpicks.

- Mark Gaiser


On jun 23, 2015, 10:16 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124155/
> ---
> 
> (Updated jun 23, 2015, 10:16 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 349513
> https://bugs.kde.org/show_bug.cgi?id=349513
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Apparently this got removed while porting; the code allows to set custom 
> action by name and remove too, no reason why it shouldn't allow retrieving it 
> by the name.
> 
> 
> Diffs
> -
> 
>   src/kstatusnotifieritem.h 04102d1 
>   src/kstatusnotifieritem.cpp 4fd2fda 
> 
> Diff: https://git.reviewboard.kde.org/r/124155/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 124155: Add KStatusNotifierItem::action(const QString &) to retrieve an action by name

2015-06-23 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124155/
---

Review request for KDE Frameworks.


Bugs: 349513
https://bugs.kde.org/show_bug.cgi?id=349513


Repository: knotifications


Description
---

Apparently this got removed while porting; the code allows to set custom action 
by name and remove too, no reason why it shouldn't allow retrieving it by the 
name.


Diffs
-

  src/kstatusnotifieritem.h 04102d1 
  src/kstatusnotifieritem.cpp 4fd2fda 

Diff: https://git.reviewboard.kde.org/r/124155/diff/


Testing
---


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel